Merge branch 'main' into refactor-scope-filter-ux

addons/api/addon/models/host-catalog.js

@@ -1,3 +1,10 @@
 import GeneratedHostCatalogModel from '../generated/models/host-catalog';
 
-export default class HostCatalogModel extends GeneratedHostCatalogModel {}
+export default class HostCatalogModel extends GeneratedHostCatalogModel {
+  /**
+   * @type {boolean}
+   */
+  get isStatic() {
+    return this.type === 'static';
+  }
+}

addons/api/mirage/factories/host-catalog.js

@@ -18,9 +18,9 @@ export default factory.extend({
   },
   withChildren: trait({
     afterCreate(hostCatalog, server) {
-      const { scope } = hostCatalog;
-      const hosts = server.createList('host', 10, { scope, hostCatalog });
-      server.createList('host-set', 3, { scope, hostCatalog, hosts });
+      const { scope, type } = hostCatalog;
+      const hosts = server.createList('host', 10, { scope, hostCatalog, type });
+      server.createList('host-set', 3, { scope, hostCatalog, hosts, type });
     },
   }),
 });

addons/api/mirage/generated/factories/host-catalog.js

@@ -5,7 +5,7 @@ import { random, date, datatype } from 'faker';
  * GeneratedHostCatalogModelFactory
  */
 export default Factory.extend({
-  type: 'static',
+  type: () => random.arrayElement(['static', 'plugin']),
   name: () => random.words(),
   description: () => random.words(),
   created_time: () => date.recent(),

addons/api/tests/unit/models/host-catalog-test.js

@@ -9,4 +9,14 @@ module('Unit | Model | host catalog', function (hooks) {
     let model = store.createRecord('host-catalog', {});
     assert.ok(model);
   });
+
+  test('it has isStatic function and returns the expected values', async function (assert) {
+    assert.expect(3);
+    const store = this.owner.lookup('service:store');
+    const modelA = store.createRecord('host-catalog', { type: 'static' });
+    const modelB = store.createRecord('host-catalog', { type: 'plugin' });
+    assert.equal(typeof modelA.isStatic, 'boolean');
+    assert.true(modelA.isStatic);
+    assert.false(modelB.isStatic);
+  });
 });

addons/api/tests/unit/models/host-test.js

@@ -5,12 +5,14 @@ module('Unit | Model | host', function (hooks) {
   setupTest(hooks);
 
   test('it exists', function (assert) {
+    assert.expect(1);
     let store = this.owner.lookup('service:store');
     let model = store.createRecord('host', {});
     assert.ok(model);
   });
 
   test('it contains attributes', function (assert) {
+    assert.expect(1);
     let store = this.owner.lookup('service:store');
     let model = store.createRecord('host', {
       type: 'static',

ui/admin/app/templates/scopes/scope/host-catalogs/host-catalog/hosts/index.hbs

@@ -18,6 +18,7 @@
                 @route='scopes.scope.host-catalogs.host-catalog.hosts.host'
                 @model={{host.id}}
               >
+
                 {{host.displayName}}
               </LinkTo>
             {{else}}

ui/admin/app/templates/scopes/scope/host-catalogs/index.hbs

@@ -41,37 +41,39 @@
         </table.header>
         <table.body as |body|>
           {{#each @model as |hostCatalog|}}
-            <body.row as |row|>
-              <row.headerCell>
-                {{#if (can 'read model' hostCatalog)}}
-                  <LinkTo
-                    @route='scopes.scope.host-catalogs.host-catalog'
-                    @model={{hostCatalog.id}}
-                  >
+            {{#if hostCatalog.isStatic}}
+              <body.row as |row|>
+                <row.headerCell>
+                  {{#if (can 'read model' hostCatalog)}}
+                    <LinkTo
+                      @route='scopes.scope.host-catalogs.host-catalog'
+                      @model={{hostCatalog.id}}
+                    >
+                      {{hostCatalog.displayName}}
+                    </LinkTo>
+                  {{else}}
                     {{hostCatalog.displayName}}
-                  </LinkTo>
-                {{else}}
-                  {{hostCatalog.displayName}}
-                {{/if}}
-                <p>{{hostCatalog.description}}</p>
-              </row.headerCell>
-              <row.cell>
-                <Rose::Badge>
-                  {{t
-                    (concat 'resources.host-catalog.types.' hostCatalog.type)
-                  }}
-                </Rose::Badge>
-              </row.cell>
-              <row.cell>
-                <Copyable
-                  @text={{hostCatalog.id}}
-                  @buttonText={{t 'actions.copy-to-clipboard'}}
-                  @acknowledgeText={{t 'states.copied'}}
-                >
-                  <code>{{hostCatalog.id}}</code>
-                </Copyable>
-              </row.cell>
-            </body.row>
+                  {{/if}}
+                  <p>{{hostCatalog.description}}</p>
+                </row.headerCell>
+                <row.cell>
+                  <Rose::Badge>
+                    {{t
+                      (concat 'resources.host-catalog.types.' hostCatalog.type)
+                    }}
+                  </Rose::Badge>
+                </row.cell>
+                <row.cell>
+                  <Copyable
+                    @text={{hostCatalog.id}}
+                    @buttonText={{t 'actions.copy-to-clipboard'}}
+                    @acknowledgeText={{t 'states.copied'}}
+                  >
+                    <code>{{hostCatalog.id}}</code>
+                  </Copyable>
+                </row.cell>
+              </body.row>
+            {{/if}}
           {{/each}}
         </table.body>
       </Rose::Table>

ui/desktop/app/templates/scopes/scope/projects/targets/target/hosts.hbs

@@ -1,8 +1,15 @@
 {{page-title (t 'resources.host-set.title_plural')}}
 
 {{#if @model.hosts}}
-
   <Rose::Table as |table|>
+    <table.header as |header|>
+      <header.row as |row|>
+        <row.headerCell>{{t 'form.name.label'}}</row.headerCell>
+        <row.headerCell>{{t 'form.id.label'}}</row.headerCell>
+        <row.headerCell>{{t 'form.address.label'}}</row.headerCell>
+        <row.headerCell />
+      </header.row>
+    </table.header>
     <table.body as |body|>
       {{#each @model.hosts as |host|}}
         <body.row as |row|>
@@ -20,11 +27,6 @@
             </Copyable>
           </row.cell>
           <row.cell>{{host.attributes.address}}</row.cell>
-          <row.cell>
-            <Rose::Badge>{{t
-                (concat 'resources.host.types.' host.type)
-              }}</Rose::Badge>
-          </row.cell>
           <row.cell>
             <Rose::Button
               @style='secondary'
@@ -37,7 +39,6 @@
       {{/each}}
     </table.body>
   </Rose::Table>
-
 {{else}}
 
   <Rose::Layout::Centered>