CyberCoveLLC/threshold-ui
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Icu 16409 roles list & global-scope (#2747)

Browse Source 
* chore: 🤖 add test selectors to roles list tests

* chore: 🤖 add test selectors for roles global-scope tests

* chore: 🤖 add TABLE_RESOURCE_LINK to global-scope tests

* test: 💍 change exists to isVisible
This commit is contained in:
Cameron Perera authored and GitHub committed 2025-03-28 13:11:33 -05:00
1 parent 4b1327db24
commit b4d9cd5bb7
6 files changed
+362 -346
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

addons/rose/addon/components/rose/pagination/index.hbs
+1
View File
@@ -4,6 +4,7 @@
}}
<Hds::Pagination::Numbered
data-test-pagination
@totalItems={{@totalItems}}
@currentPage={{@currentPage}}
@currentPageSize={{@currentPageSize}}
ui/admin/app/components/form/role/manage-scopes/index.hbs
+1
View File
@@ -87,6 +87,7 @@
'scopes.scope.roles.role.manage-scopes.manage-org-projects'
}}
@model={{if @model.scope.isOrg @model.scope.id}}
data-test-manage-custom-scopes-button
/>
<Hds::Form::HelperText
ui/admin/tests/acceptance/roles/global-scope-test.js
+294 -308
View File
File diff suppressed because it is too large. Load diff
ui/admin/tests/acceptance/roles/list-test.js
+33 -38
View File
@@ -17,21 +17,14 @@ import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
import { setupIndexedDb } from 'api/test-support/helpers/indexed-db';
import { authenticateSession } from 'ember-simple-auth/test-support';
import { GRANT_SCOPE_THIS } from 'api/models/role';
import * as selectors from './selectors';
import * as commonSelectors from 'admin/tests/helpers/selectors';
module('Acceptance | roles | list', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);
setupIndexedDb(hooks);
const ROLE_BADGE_SELECTOR = (id) =>
`tbody [data-test-role-row="${id}"] td:nth-child(2) .hds-badge__text`;
const ROLE_TOOLTIP_BTN_SELECTOR = (id) =>
`tbody [data-test-role-row="${id}"] td:nth-child(2) .hds-tooltip-button`;
const ROLE_TOOLTIP_CONTENT_SELECTOR = (id) =>
`tbody [data-test-role-row="${id}"] td:nth-child(2) [data-tippy-root]`;
const SEARCH_INPUT_SELECTOR = '.search-filtering [type="search"]';
const NO_RESULTS_MSG_SELECTOR = '[data-test-no-role-results]';
const instances = {
scopes: {
global: null,
@@ -72,64 +65,66 @@ module('Acceptance | roles | list', function (hooks) {
test('users can navigate to roles with proper authorization', async function (assert) {
await visit(urls.globalScope);
await click(`[href="${urls.orgScope}"]`);
await click(commonSelectors.HREF(urls.orgScope));
assert.true(
instances.scopes.org.authorized_collection_actions.roles.includes('list'),
);
assert.dom(`[href="${urls.roles}"]`).exists();
assert.dom(commonSelectors.HREF(urls.roles)).isVisible();
});
test('users cannot navigate to index without either list or create actions', async function (assert) {
instances.scopes.org.authorized_collection_actions.roles = [];
await visit(urls.globalScope);
await click(`[href="${urls.orgScope}"]`);
await click(commonSelectors.HREF(urls.orgScope));
assert.false(
instances.scopes.org.authorized_collection_actions.roles.includes('list'),
);
assert.dom(`[href="${urls.roles}"]`).doesNotExist();
assert.dom(commonSelectors.HREF(urls.roles)).doesNotExist();
});
test('users can navigate to index with only create action', async function (assert) {
instances.scopes.org.authorized_collection_actions.roles = ['create'];
await visit(urls.globalScope);
await click(`[href="${urls.orgScope}"]`);
await click(commonSelectors.HREF(urls.orgScope));
assert.dom(`[href="${urls.roles}"]`).exists();
assert.dom(commonSelectors.HREF(urls.roles)).isVisible();
});
test('user can search for a specifc role by id', async function (assert) {
test('user can search for a specific role by id', async function (assert) {
await visit(urls.orgScope);
await click(`[href="${urls.roles}"]`);
await click(commonSelectors.HREF(urls.roles));
assert.dom(`[href="${urls.role1}"]`).exists();
assert.dom(`[href="${urls.role2}"]`).exists();
assert.dom(commonSelectors.HREF(urls.role1)).isVisible();
assert.dom(commonSelectors.HREF(urls.role2)).isVisible();
await fillIn(SEARCH_INPUT_SELECTOR, instances.role1.id);
await waitUntil(() => findAll(`[href="${urls.role2}"]`).length === 0);
await fillIn(commonSelectors.SEARCH_INPUT, instances.role1.id);
await waitUntil(
() => findAll(commonSelectors.HREF(urls.role2)).length === 0,
);
assert.dom(`[href="${urls.role1}"]`).exists();
assert.dom(`[href="${urls.role2}"]`).doesNotExist();
assert.dom(commonSelectors.HREF(urls.role1)).isVisible();
assert.dom(commonSelectors.HREF(urls.role2)).doesNotExist();
});
test('user can search for roles and get no results', async function (assert) {
await visit(urls.orgScope);
await click(`[href="${urls.roles}"]`);
await click(commonSelectors.HREF(urls.roles));
assert.dom(`[href="${urls.role1}"]`).exists();
assert.dom(`[href="${urls.role2}"]`).exists();
assert.dom(commonSelectors.HREF(urls.role1)).isVisible();
assert.dom(commonSelectors.HREF(urls.role2)).isVisible();
await fillIn(SEARCH_INPUT_SELECTOR, 'fake role that does not exist');
await waitUntil(() => findAll(NO_RESULTS_MSG_SELECTOR).length === 1);
await fillIn(commonSelectors.SEARCH_INPUT, 'fake role that does not exist');
await waitUntil(() => findAll(selectors.NO_RESULTS_MSG).length === 1);
assert.dom(`[href="${urls.role1}"]`).doesNotExist();
assert.dom(`[href="${urls.role2}"]`).doesNotExist();
assert.dom(NO_RESULTS_MSG_SELECTOR).includesText('No results found');
assert.dom(commonSelectors.HREF(urls.role1)).doesNotExist();
assert.dom(commonSelectors.HREF(urls.role2)).doesNotExist();
assert.dom(selectors.NO_RESULTS_MSG).includesText('No results found');
});
test('correct badge in grants applied column is visible to user', async function (assert) {
@@ -138,22 +133,22 @@ module('Acceptance | roles | list', function (hooks) {
);
await visit(urls.orgScope);
await click(`[href="${urls.roles}"]`);
await click(commonSelectors.HREF(urls.roles));
assert.true(instances.role2.grant_scope_ids.includes(GRANT_SCOPE_THIS));
assert.dom(ROLE_BADGE_SELECTOR(instances.role1.id)).hasText('No');
assert.dom(ROLE_BADGE_SELECTOR(instances.role2.id)).hasText('Yes');
assert.dom(selectors.ROLE_BADGE(instances.role1.id)).hasText('No');
assert.dom(selectors.ROLE_BADGE(instances.role2.id)).hasText('Yes');
await focus(ROLE_TOOLTIP_BTN_SELECTOR(instances.role1.id));
await focus(selectors.ROLE_TOOLTIP_BTN(instances.role1.id));
assert
.dom(ROLE_TOOLTIP_CONTENT_SELECTOR(instances.role1.id))
.dom(selectors.ROLE_TOOLTIP_CONTENT(instances.role1.id))
.hasText('The grants on this role have not been applied to this scope.');
await focus(ROLE_TOOLTIP_BTN_SELECTOR(instances.role2.id));
await focus(selectors.ROLE_TOOLTIP_BTN(instances.role2.id));
assert
.dom(ROLE_TOOLTIP_CONTENT_SELECTOR(instances.role2.id))
.dom(selectors.ROLE_TOOLTIP_CONTENT(instances.role2.id))
.hasText('The grants on this role have been applied to this scope.');
});
});
ui/admin/tests/acceptance/roles/selectors.js
+31
View File
@@ -12,3 +12,34 @@ export const MANAGE_DROPDOWN_ROLES_SCOPES =
'[data-test-manage-dropdown-scopes]';
export const MANAGE_DROPDOWN_ROLES_REMOVE =
'[data-test-manage-roles-dropdown] div:last-child button';
export const ROLE_BADGE = (id) =>
`tbody [data-test-role-row="${id}"] td:nth-child(2) .hds-badge__text`;
export const ROLE_TOOLTIP_BTN = (id) =>
`tbody [data-test-role-row="${id}"] td:nth-child(2) .hds-tooltip-button`;
export const ROLE_TOOLTIP_CONTENT = (id) =>
`tbody [data-test-role-row="${id}"] td:nth-child(2) [data-tippy-root]`;
export const GRANT_SCOPE_ROW = (id) =>
`tbody [data-test-grant-scope-row="${id}"]`;
export const GRANT_SCOPE_PARENT_SCOPE =
'tbody tr:nth-child(2) td:nth-child(3) a';
export const TABLE_ALL_CHECKBOX = 'thead input[type="checkbox"]';
export const NO_RESULTS_MSG = '[data-test-no-role-results]';
export const NO_RESULTS_GRANT_SCOPE_MSG = '[data-test-no-grant-scope-results]';
export const NO_SCOPES_MSG = '.role-grant-scopes div';
export const NO_SCOPES_MSG_LINK = '.role-grant-scopes div div:nth-child(3) a';
// Manage scopes selectors
export const SCOPE_TOGGLE = (name) => `.hds-form-toggle input[name="${name}"]`;
export const SCOPE_CHECKBOX = (type, id) =>
`tbody [data-test-${type}-scopes-table-row="${id}"] input`;
export const MANAGE_CUSTOM_SCOPES_BUTTON_ICON =
'[data-test-manage-custom-scopes-button] [data-test-icon="check-circle"]';
export const REMOVE_ORG_MODAL = (name) =>
`[data-test-manage-scopes-remove-${name}-modal]`;
export const REMOVE_ORG_ONLY_BTN = (name) =>
`[data-test-manage-scopes-remove-${name}-modal] div:nth-child(3) button:last-of-type`;
export const REMOVE_ORG_PROJECTS_BTN = (name) =>
`[data-test-manage-scopes-remove-${name}-modal] div:nth-child(3) button`;
ui/admin/tests/helpers/selectors.js
+2
View File
@@ -62,3 +62,5 @@ export const FILTER_DROPDOWN = (filterName) =>
export const FILTER_DROPDOWN_ITEM = (itemList) => `input[value="${itemList}"]`;
export const FILTER_DROPDOWN_ITEM_APPLY_BTN = (filterName) =>
`.search-filtering [name="${filterName}"] .hds-dropdown__footer button`;
export const PAGINATION = '[data-test-pagination]';