feat: 🎸 Changing div for h2

Changing the heading text container from a div to an h2
This commit is contained in:
Carlos Alcaide committed 2021-06-18 16:23:07 -07:00
1 parent 445d789344
commit bfdaacc2cd
2 files changed
+10 -3

No files matched your search

+2 -2
View File
@@ -1,12 +1,12 @@
<section class='card'> <section class='card'>
<header class='card-header'> <header class='card-header'>
{{#if @heading}} {{#if @heading}}
<div> <h2>
{{#if @icon}} {{#if @icon}}
<Rose::Icon @name={{@icon}} @size='medium' /> <Rose::Icon @name={{@icon}} @size='medium' />
{{/if}} {{/if}}
{{@heading}} {{@heading}}
</div> </h2>
{{/if}} {{/if}}
{{yield to='header'}} {{yield to='header'}}
</header> </header>
+8 -1
View File
@@ -369,12 +369,19 @@
margin-bottom: sizing.rems(m); margin-bottom: sizing.rems(m);
.card-header { .card-header {
align-items: center;
border-bottom: sizing.rems(xxxxs) solid var(--ui-gray-subtler-3); border-bottom: sizing.rems(xxxxs) solid var(--ui-gray-subtler-3);
display: flex; display: flex;
justify-content: flex-start; justify-content: flex-start;
padding: sizing.rems(s); padding: sizing.rems(s);
div { h2 {
@include type.type(s, normal);
color: var(--ui-gray-starker-1);
}
div,
h2 {
display: flex; display: flex;
flex-shrink: 1; flex-shrink: 1;
width: 100%; width: 100%;