chore: fix eslint-related issues (#2690)

* chore: 🤖 add .eslintignore for e2e-tests directory

* chore: 🤖 add auto-fixable eslint changes

* chore: 🤖 make js tasks more explicit to avoid race conditions

avoid having js files be in two separate concurrent branches where tasks
could result in race-condition writes

* chore: 🤖 expand .eslintignore to include more generated dirs

* chore: 🤖 fix additional lint-staged tasks

Fix additional lint-staged tasks that could result in race conditions

addons/api/package.json

@@ -82,8 +82,8 @@
     "configPath": "tests/dummy/config"
   },
   "lint-staged": {
-    "*.js": "eslint --fix",
+    "*.js": ["eslint --fix", "prettier --write"],
     "*.hbs": "ember-template-lint --fix",
-    "*.{js,scss,yaml}": "prettier --write"
+    "*.{scss,yaml}": "prettier --write"
   }
 }

addons/auth/package.json

@@ -77,8 +77,8 @@
     "configPath": "tests/dummy/config"
   },
   "lint-staged": {
-    "*.js": "eslint --fix",
+    "*.js": ["eslint --fix", "prettier --write"],
     "*.hbs": "ember-template-lint --fix",
-    "*.{js,scss,yaml}": "prettier --write"
+    "*.{scss,yaml}": "prettier --write"
   }
 }

addons/core/package.json

@@ -98,8 +98,8 @@
     "configPath": "tests/dummy/config"
   },
   "lint-staged": {
-    "*.js": "eslint --fix",
+    "*.js": ["eslint --fix", "prettier --write"],
     "*.hbs": "ember-template-lint --fix",
-    "*.{js,scss,yaml}": "prettier --write"
+    "*.{scss,yaml}": "prettier --write"
   }
 }

addons/rose/package.json

@@ -107,9 +107,9 @@
     "configPath": "tests/dummy/config"
   },
   "lint-staged": {
-    "*.js": "eslint --fix",
+    "*.js": ["eslint --fix", "prettier --write"],
     "*.hbs": "ember-template-lint --fix",
-    "*.scss": "stylelint --fix",
-    "*.{js,scss,mdx,yaml}": "prettier --write"
+    "*.scss": ["stylelint --fix", "prettier --write"],
+    "*.{mdx,yaml}": "prettier --write"
   }
 }

e2e-tests/.eslintignore

@@ -0,0 +1,4 @@
+# e2e test output
+admin/artifacts
+desktop/artifacts
+playwright-report

e2e-tests/desktop/tests/credentials.spec.js

@@ -303,11 +303,11 @@ test.describe('Credential Panel tests', () => {
     // Empty string and null should not be visible
     await expect(
       authedPage.getByRole('listitem').filter({ hasText: 'nested.key3' }),
-    ).not.toBeVisible();
+    ).toBeHidden();
 
     await expect(
       authedPage.getByRole('listitem').filter({ hasText: 'nested.key4' }),
-    ).not.toBeVisible();
+    ).toBeHidden();
 
     await authedPage
       .getByRole('listitem')

e2e-tests/package.json

@@ -42,7 +42,7 @@
     "node": "20.* || 22.*"
   },
   "lint-staged": {
-    "*.js": "eslint --fix",
-    "*.{js,scss,yaml}": "prettier --write"
+    "*.js": ["eslint --fix", "prettier --write"],
+    "*.{scss,yaml}": "prettier --write"
   }
 }

ui/admin/package.json

@@ -107,8 +107,8 @@
     "edition": "octane"
   },
   "lint-staged": {
-    "*.js": "eslint --fix",
+    "*.js": ["eslint --fix", "prettier --write"],
     "*.hbs": "ember-template-lint --fix",
-    "*.{js,scss,yaml}": "prettier --write"
+    "*.{scss,yaml}": "prettier --write"
   }
 }

ui/desktop/package.json

@@ -119,8 +119,8 @@
     "edition": "octane"
   },
   "lint-staged": {
-    "*.js": "eslint --fix",
+    "*.js": ["eslint --fix", "prettier --write"],
     "*.hbs": "ember-template-lint --fix",
-    "*.{js,scss,yaml}": "prettier --write"
+    "*.{scss,yaml}": "prettier --write"
   }
 }