Merge pull request #736 from hashicorp/cred-lib-create-list

Cred lib create list
2021-09-03 11:43:32 -07:00
commit cf70ea3e01
@@ -13,6 +13,11 @@ export default factory.extend({
      'update',
      'delete',
    ],
+  authorized_collection_actions: () => {
+    return {
+      'credential-libraries': ['create', 'list'],
+    };
+  },
  id: (i) => `credential-store-id-${i}`,
  type: (i) => types[i % types.length],

@@ -3,19 +3,28 @@ import { action } from '@ember/object';
 import loading from 'ember-loading/decorator';
 import { confirm } from 'core/decorators/confirm';
 import { notifySuccess, notifyError } from 'core/decorators/notify';
+import { inject as service } from '@ember/service';

 export default class ScopesScopeCredentialStoresCredentialStoreCredentialLibrariesRoute extends Route {
  // =methods
+  @service can;

  /**
   * Loads all credential libraries under the current credential store.
   * @return {Promise{[CredentialLibraryModel]}}
   */
  model() {
-    const { id: credential_store_id } = this.modelFor(
+    const credentialStore = this.modelFor(
      'scopes.scope.credential-stores.credential-store'
    );
-    return this.store.query('credential-library', { credential_store_id });
+    const { id: credential_store_id } = credentialStore;
+    if (
+      this.can.can('list collection', credentialStore, {
+        collection: 'credential-libraries',
+      })
+    ) {
+      return this.store.query('credential-library', { credential_store_id });
+    }
  }

  // =actions
@@ -1,3 +1,13 @@
 import Route from '@ember/routing/route';

-export default class ScopesScopeCredentialStoresCredentialStoreCredentialLibrariesIndexRoute extends Route {}
+export default class ScopesScopeCredentialStoresCredentialStoreCredentialLibrariesIndexRoute extends Route {
+  // =methods
+
+  setupController(controller) {
+    const credentialStore = this.modelFor(
+      'scopes.scope.credential-stores.credential-store'
+    );
+    super.setupController(...arguments);
+    controller.setProperties({ credentialStore });
+  }
+}
@@ -3,12 +3,15 @@
  @dropdownRight={{true}}
  as |dropdown|
 >
-  <dropdown.link
-    @route='scopes.scope.credential-stores.credential-store.credential-libraries.new'
-    @model={{@model}}
-  >
-    {{t 'resources.credential-library.actions.create'}}
-  </dropdown.link>
+  {{#if (can 'create collection' @model collection='credential-libraries')}}
+
+    <dropdown.link
+      @route='scopes.scope.credential-stores.credential-store.credential-libraries.new'
+      @model={{@model}}
+    >
+      {{t 'resources.credential-library.actions.create'}}
+    </dropdown.link>
+  {{/if}}
  {{#if (can 'delete model' @model)}}
    <dropdown.separator />
    <dropdown.button
@@ -2,9 +2,12 @@
  <nav.link @route='scopes.scope.credential-stores.credential-store.index'>
    {{t 'titles.details'}}
  </nav.link>
-  <nav.link
-    @route='scopes.scope.credential-stores.credential-store.credential-libraries'
-  >
-    {{t 'resources.credential-library.title_plural'}}
-  </nav.link>
+  {{#if (can 'navigate collection' @model collection='credential-libraries')}}
+
+    <nav.link
+      @route='scopes.scope.credential-stores.credential-store.credential-libraries'
+    >
+      {{t 'resources.credential-library.title_plural'}}
+    </nav.link>
+  {{/if}}
 </Rose::Nav::Tabs>
@@ -53,14 +53,49 @@
      as |message|
    >
      <message.description>
-        {{t 'resources.credential-library.messages.none.description'}}
+        {{#if
+          (can
+            'list collection'
+            this.credentialStore
+            collection='credential-libraries'
+          )
+        }}
+          {{! can list (at least):  show default welcome message}}
+          {{t 'resources.credential-library.description'}}
+
+        {{else if (can
+          'create collection'
+          this.credentialStore
+          collection='credential-libraries'
+        )}}
+          {{! can create (only):  show create-but-not-list welcome message}}
+          {{t
+            'descriptions.create-but-not-list'
+            resource=(t 'resources.credential-library.title_plural')
+          }}
+        {{else}}
+          {{! can neither list nor create }}
+          {{t
+            'descriptions.neither-list-nor-create'
+            resource=(t 'resources.credential-library.title_plural')
+          }}
+        {{/if}}
+
      </message.description>
-      <message.link
-        @route='scopes.scope.credential-stores.credential-store.credential-libraries.new'
-      >
-        <Rose::Icon @name='flight-icons/plus-circle-16' />
-        {{t 'titles.new'}}
-      </message.link>
+      {{#if
+        (can
+          'create collection'
+          this.credentialStore
+          collection='credential-libraries'
+        )
+      }}
+        <message.link
+          @route='scopes.scope.credential-stores.credential-store.credential-libraries.new'
+        >
+          <Rose::Icon @name='flight-icons/plus-circle-16' />
+          {{t 'titles.new'}}
+        </message.link>
+      {{/if}}
    </Rose::Message>
  </Rose::Layout::Centered>

@@ -6,7 +6,7 @@ import a11yAudit from 'ember-a11y-testing/test-support/audit';
 import { authenticateSession } from 'ember-simple-auth/test-support';
 import { Response } from 'miragejs';

-module('Acceptance | credential-libraries', function (hooks) {
+module('Acceptance | credential-libraries | create', function (hooks) {
  setupApplicationTest(hooks);
  setupMirage(hooks);

@@ -93,6 +93,20 @@ module('Acceptance | credential-libraries', function (hooks) {
    assert.equal(getCredentialLibraryCount(), count + 1);
  });

+  test('Users cannot navigate to new credential library route without proper authorization', async function (assert) {
+    assert.expect(2);
+    instances.credentialStore.authorized_collection_actions[
+      'credential-libraries'
+    ] = [];
+    await visit(urls.credentialStore);
+    assert.notOk(
+      instances.credentialStore.authorized_collection_actions[
+        'credential-libraries'
+      ].includes('create')
+    );
+    assert.notOk(find(`[href="${urls.credentialLibraries}"]`));
+  });
+
  test('can cancel create a new credential library', async function (assert) {
    assert.expect(2);
    const count = getCredentialLibraryCount();
@@ -0,0 +1,95 @@
+import { module, test } from 'qunit';
+import { visit, find } from '@ember/test-helpers';
+import { setupApplicationTest } from 'ember-qunit';
+import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
+import {
+  authenticateSession,
+  // These are left here intentionally for future reference.
+  //currentSession,
+  //invalidateSession,
+} from 'ember-simple-auth/test-support';
+
+module('Acceptance | credential-libraries | list', function (hooks) {
+  setupApplicationTest(hooks);
+  setupMirage(hooks);
+
+  const instances = {
+    scopes: {
+      global: null,
+      org: null,
+      project: null,
+    },
+  };
+
+  const urls = {
+    globalScope: null,
+    orgScope: null,
+    projectScope: null,
+    credentialStores: null,
+    credentialStore: null,
+    credentialLibrary: null,
+    credentialLibraries: null,
+  };
+
+  hooks.beforeEach(function () {
+    instances.scopes.global = this.server.create('scope', { id: 'global' });
+    instances.scopes.org = this.server.create('scope', {
+      type: 'org',
+      scope: { id: 'global', type: 'global' },
+    });
+    instances.scopes.project = this.server.create('scope', {
+      type: 'project',
+      scope: { id: instances.scopes.org.id, type: 'org' },
+    });
+    instances.credentialStore = this.server.create('credential-store', {
+      scope: instances.scopes.project,
+    });
+    instances.credentialLibrary = this.server.create('credential-library', {
+      scope: instances.scopes.project,
+      credentialStore: instances.credentialStore,
+    });
+    // Generate route URLs for resources
+    urls.globalScope = `/scopes/global/scopes`;
+    urls.orgScope = `/scopes/${instances.scopes.org.id}/scopes`;
+    urls.projectScope = `/scopes/${instances.scopes.project.id}`;
+    urls.credentialStores = `${urls.projectScope}/credential-stores`;
+    urls.credentialStore = `${urls.credentialStores}/${instances.credentialStore.id}`;
+    urls.credentialLibraries = `${urls.credentialStore}/credential-libraries`;
+    urls.credentialLibrary = `${urls.credentialLibraries}/${instances.credentialLibrary.id}`;
+    authenticateSession({});
+  });
+
+  test('Users can navigate to credential libraries with proper authorization', async function (assert) {
+    assert.expect(2);
+    await visit(urls.credentialStore);
+    assert.ok(
+      instances.credentialStore.authorized_collection_actions[
+        'credential-libraries'
+      ].includes('list')
+    );
+    assert.ok(find(`[href="${urls.credentialLibraries}"]`));
+  });
+
+  test('Users cannot navigate to index without either list or create actions', async function (assert) {
+    assert.expect(2);
+    instances.credentialStore.authorized_collection_actions[
+      'credential-libraries'
+    ] = [];
+    await visit(urls.credentialStore);
+    assert.notOk(
+      instances.credentialStore.authorized_collection_actions[
+        'credential-libraries'
+      ].includes('list')
+    );
+    assert.notOk(find(`[href="${urls.credentialLibraries}"]`));
+  });
+
+  test('Users can navigate to index with only create action', async function (assert) {
+    assert.expect(1);
+    instances.credentialStore.authorized_collection_actions[
+      'credential-libraries'
+    ] = ['create'];
+    await visit(urls.credentialStore);
+    assert.ok(find(`[href="${urls.credentialLibraries}"]`));
+  });
+});