Merge pull request #718 from hashicorp/cred-store-capabilities

Cred store capabilities
This commit is contained in:
Dharini Jeeva authored and GitHub committed 2021-08-24 11:49:41 -07:00
commit d881b57b87
8 files changed
+413 -199

No files matched your search

@@ -1,10 +1,18 @@
import factory from '../generated/factories/credential-store';
import { random, internet, datatype } from 'faker';
import { trait } from 'ember-cli-mirage';
import permissions from '../helpers/permissions';
const types = ['vault'];
export default factory.extend({
authorized_actions: () =>
permissions.authorizedActionsFor('credential-store') || [
'no-op',
'read',
'update',
'delete',
],
id: (i) => `credential-store-id-${i}`,
type: (i) => types[i % types.length],
@@ -233,11 +233,12 @@
</field.errors>
{{/if}}
</form.textarea>
<form.actions
@disabled={{if @model.cannotSave @model.cannotSave}}
@enableEditText={{t 'actions.edit-form'}}
@submitText={{t 'actions.save'}}
@cancelText={{t 'actions.cancel'}}
/>
{{#if (can 'save model' @model)}}
<form.actions
@disabled={{if @model.cannotSave @model.cannotSave}}
@enableEditText={{t 'actions.edit-form'}}
@submitText={{t 'actions.save'}}
@cancelText={{t 'actions.cancel'}}
/>
{{/if}}
</Rose::Form>
@@ -9,12 +9,14 @@
>
{{t 'resources.credential-library.actions.create'}}
</dropdown.link>
<dropdown.separator />
<dropdown.button
@style='danger'
@disabled={{@model.canSave}}
{{on 'click' (route-action 'delete' @model)}}
>
{{t 'resources.credential-store.actions.delete'}}
</dropdown.button>
{{#if (can 'delete model' @model)}}
<dropdown.separator />
<dropdown.button
@style='danger'
@disabled={{@model.canSave}}
{{on 'click' (route-action 'delete' @model)}}
>
{{t 'resources.credential-store.actions.delete'}}
</dropdown.button>
{{/if}}
</Rose::Dropdown>
@@ -39,12 +39,16 @@
{{#each @model as |credentialStore|}}
<body.row as |row|>
<row.headerCell>
<LinkTo
@route='scopes.scope.credential-stores.credential-store'
@model={{credentialStore.id}}
>
{{#if (can 'read model' credentialStore)}}
<LinkTo
@route='scopes.scope.credential-stores.credential-store'
@model={{credentialStore.id}}
>
{{credentialStore.displayName}}
</LinkTo>
{{else}}
{{credentialStore.displayName}}
</LinkTo>
{{/if}}
<p>{{credentialStore.description}}</p>
</row.headerCell>
<row.cell>
@@ -0,0 +1,124 @@
import { module, test } from 'qunit';
import { visit, find, click } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
import { authenticateSession } from 'ember-simple-auth/test-support';
import { Response } from 'miragejs';
import { resolve, reject } from 'rsvp';
import sinon from 'sinon';
module('Acceptance | credential-stores | delete', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);
let getCredentialStoresCount;
const instances = {
scopes: {
global: null,
org: null,
project: null,
},
};
const urls = {
globalScope: null,
orgScope: null,
projectScope: null,
credentialStores: null,
credentialStore: null,
unknownCredentialStore: null,
newCredentialStore: null,
};
hooks.beforeEach(function () {
// Generate resources
instances.scopes.global = this.server.create('scope', { id: 'global' });
instances.scopes.org = this.server.create('scope', {
type: 'org',
scope: { id: 'global', type: 'global' },
});
instances.scopes.project = this.server.create('scope', {
type: 'project',
scope: { id: instances.scopes.org.id, type: 'org' },
});
instances.credentialStore = this.server.create('credential-store', {
scope: instances.scopes.project,
});
// Generate route URLs for resources
urls.globalScope = `/scopes/global/scopes`;
urls.orgScope = `/scopes/${instances.scopes.org.id}/scopes`;
urls.projectScope = `/scopes/${instances.scopes.project.id}`;
urls.credentialStores = `${urls.projectScope}/credential-stores`;
urls.credentialStore = `${urls.credentialStores}/${instances.credentialStore.id}`;
urls.unknownCredentialStore = `${urls.credentialStores}/foo`;
urls.newCredentialStore = `${urls.credentialStores}/new`;
// Generate resource counter
getCredentialStoresCount = () => {
return this.server.schema.credentialStores.all().models.length;
};
authenticateSession({});
});
test('can delete credential store', async function (assert) {
assert.expect(1);
const count = getCredentialStoresCount();
await visit(urls.credentialStore);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.equal(getCredentialStoresCount(), count - 1);
});
test('cannot delete a credential store without proper authorization', async function (assert) {
assert.expect(1);
instances.credentialStore.authorized_actions =
instances.credentialStore.authorized_actions.filter(
(item) => item !== 'delete'
);
await visit(urls.credentialStores);
assert.notOk(
find('.rose-layout-page-actions .rose-dropdown-button-danger')
);
});
test('can accept delete credential store via dialog', async function (assert) {
assert.expect(2);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
confirmService.confirm = sinon.fake.returns(resolve());
const count = getCredentialStoresCount();
await visit(urls.credentialStore);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.equal(getCredentialStoresCount(), count - 1);
assert.ok(confirmService.confirm.calledOnce);
});
test('cannot cancel delete credential store via dialog', async function (assert) {
assert.expect(2);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
confirmService.confirm = sinon.fake.returns(reject());
const count = getCredentialStoresCount();
await visit(urls.credentialStore);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.equal(getCredentialStoresCount(), count);
assert.ok(confirmService.confirm.calledOnce);
});
test('deleting a credential store which errors displays error messages', async function (assert) {
assert.expect(1);
this.server.del('/credential-stores/:id', () => {
return new Response(
490,
{},
{
status: 490,
code: 'error',
message: 'Oops.',
}
);
});
await visit(urls.credentialStore);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.ok(find('[role="alert"]').textContent.trim(), 'Oops.');
});
});
@@ -0,0 +1,84 @@
import { module, test } from 'qunit';
import { visit, currentURL, find } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
import a11yAudit from 'ember-a11y-testing/test-support/audit';
import { authenticateSession } from 'ember-simple-auth/test-support';
module('Acceptance | credential-stores | read', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);
const instances = {
scopes: {
global: null,
org: null,
project: null,
},
};
const urls = {
globalScope: null,
orgScope: null,
projectScope: null,
credentialStores: null,
credentialStore: null,
unknownCredentialStore: null,
newCredentialStore: null,
};
hooks.beforeEach(function () {
// Generate resources
instances.scopes.global = this.server.create('scope', { id: 'global' });
instances.scopes.org = this.server.create('scope', {
type: 'org',
scope: { id: 'global', type: 'global' },
});
instances.scopes.project = this.server.create('scope', {
type: 'project',
scope: { id: instances.scopes.org.id, type: 'org' },
});
instances.credentialStore = this.server.create('credential-store', {
scope: instances.scopes.project,
});
// Generate route URLs for resources
urls.globalScope = `/scopes/global/scopes`;
urls.orgScope = `/scopes/${instances.scopes.org.id}/scopes`;
urls.projectScope = `/scopes/${instances.scopes.project.id}`;
urls.credentialStores = `${urls.projectScope}/credential-stores`;
urls.credentialStore = `${urls.credentialStores}/${instances.credentialStore.id}`;
urls.unknownCredentialStore = `${urls.credentialStores}/foo`;
urls.newCredentialStore = `${urls.credentialStores}/new`;
authenticateSession({});
});
test('visiting /credential-stores', async function (assert) {
assert.expect(2);
await visit(urls.credentialStores);
await a11yAudit();
assert.equal(currentURL(), urls.credentialStores);
await visit(urls.credentialStore);
await a11yAudit();
assert.equal(currentURL(), urls.credentialStore);
});
test('cannot navigate to a credential store form without proper authorization', async function (assert) {
assert.expect(1);
instances.credentialStore.authorized_actions =
instances.credentialStore.authorized_actions.filter(
(item) => item !== 'read'
);
await visit(urls.credentialStores);
assert.notOk(find('main tbody .rose-table-header-cell:nth-child(1) a'));
});
test('visiting an unknown credential store display 404 message', async function (assert) {
assert.expect(1);
await visit(urls.unknownCredentialStore);
await a11yAudit();
assert.equal(
find('.rose-message-subtitle').textContent.trim(),
'Error 404'
);
});
});
@@ -0,0 +1,170 @@
import { module, test } from 'qunit';
import { visit, currentURL, find, click, fillIn } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
import { authenticateSession } from 'ember-simple-auth/test-support';
import { Response } from 'miragejs';
module('Acceptance | credential-stores | update', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);
const instances = {
scopes: {
global: null,
org: null,
project: null,
},
};
const urls = {
globalScope: null,
orgScope: null,
projectScope: null,
credentialStores: null,
credentialStore: null,
unknownCredentialStore: null,
newCredentialStore: null,
};
hooks.beforeEach(function () {
// Generate resources
instances.scopes.global = this.server.create('scope', { id: 'global' });
instances.scopes.org = this.server.create('scope', {
type: 'org',
scope: { id: 'global', type: 'global' },
});
instances.scopes.project = this.server.create('scope', {
type: 'project',
scope: { id: instances.scopes.org.id, type: 'org' },
});
instances.credentialStore = this.server.create('credential-store', {
scope: instances.scopes.project,
});
// Generate route URLs for resources
urls.globalScope = `/scopes/global/scopes`;
urls.orgScope = `/scopes/${instances.scopes.org.id}/scopes`;
urls.projectScope = `/scopes/${instances.scopes.project.id}`;
urls.credentialStores = `${urls.projectScope}/credential-stores`;
urls.credentialStore = `${urls.credentialStores}/${instances.credentialStore.id}`;
urls.unknownCredentialStore = `${urls.credentialStores}/foo`;
urls.newCredentialStore = `${urls.credentialStores}/new`;
authenticateSession({});
});
test('can save changes to existing credential store', async function (assert) {
assert.expect(3);
assert.notEqual(instances.credentialStore.name, 'random string');
await visit(urls.credentialStore);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
await click('.rose-form-actions [type="submit"]');
assert.equal(currentURL(), urls.credentialStore);
assert.equal(
this.server.schema.credentialStores.all().models[0].name,
'random string'
);
});
test('cannot make changes to an existing credential store without proper authorization', async function (assert) {
assert.expect(1);
instances.credentialStore.authorized_actions =
instances.credentialStore.authorized_actions.filter(
(item) => item !== 'update'
);
await visit(urls.credentialStore);
assert.notOk(find('.rose-layout-page-actions .rose-button-secondary'));
});
test('can cancel changes to existing credential store', async function (assert) {
assert.expect(2);
await visit(urls.credentialStore);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
await click('.rose-form-actions [type="button"]');
assert.notEqual(instances.credentialStore.name, 'random string');
assert.equal(find('[name="name"]').value, instances.credentialStore.name);
});
test('saving an existing credential store with invalid fields displays error messages', async function (assert) {
assert.expect(2);
this.server.patch('/credential-stores/:id', () => {
return new Response(
400,
{},
{
status: 400,
code: 'invalid_argument',
message: 'The request was invalid.',
details: {
request_fields: [
{
name: 'name',
description: 'Name is required.',
},
],
},
}
);
});
await visit(urls.credentialStore);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
await click('[type="submit"]');
assert.ok(
find('[role="alert"]').textContent.trim(),
'The request was invalid.'
);
assert.ok(
find('.rose-form-error-message').textContent.trim(),
'Name is required.'
);
});
test('can discard unsaved credential store changes via dialog', async function (assert) {
assert.expect(5);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
assert.notEqual(instances.credentialStore.name, 'random string');
await visit(urls.credentialStore);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
assert.equal(currentURL(), urls.credentialStore);
try {
await visit(urls.credentialStores);
} catch (e) {
assert.ok(find('.rose-dialog'));
await click('.rose-dialog-footer button:first-child', 'Click Discard');
assert.equal(currentURL(), urls.credentialStores);
assert.notEqual(
this.server.schema.credentialStores.all().models[0].name,
'random string'
);
}
});
test('can cancel discard unsaved credential store via dialog', async function (assert) {
assert.expect(5);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
assert.notEqual(instances.credentialStore.name, 'random string');
await visit(urls.credentialStore);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
assert.equal(currentURL(), urls.credentialStore);
try {
await visit(urls.credentialStores);
} catch (e) {
assert.ok(find('.rose-dialog'));
await click('.rose-dialog-footer button:last-child');
assert.equal(currentURL(), urls.credentialStore);
assert.notEqual(
this.server.schema.credentialStores.all().models[0].name,
'random string'
);
}
});
});
@@ -2,11 +2,8 @@ import { module, test } from 'qunit';
import { visit, currentURL, find, click, fillIn } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
import a11yAudit from 'ember-a11y-testing/test-support/audit';
import { authenticateSession } from 'ember-simple-auth/test-support';
import { Response } from 'miragejs';
import { resolve, reject } from 'rsvp';
import sinon from 'sinon';
module('Acceptance | credential-stores', function (hooks) {
setupApplicationTest(hooks);
@@ -61,26 +58,6 @@ module('Acceptance | credential-stores', function (hooks) {
authenticateSession({});
});
test('visiting /credential-stores', async function (assert) {
assert.expect(2);
await visit(urls.credentialStores);
await a11yAudit();
assert.equal(currentURL(), urls.credentialStores);
await visit(urls.credentialStore);
await a11yAudit();
assert.equal(currentURL(), urls.credentialStore);
});
test('visiting an unknown credential store display 404 message', async function (assert) {
assert.expect(1);
await visit(urls.unknownCredentialStore);
await a11yAudit();
assert.equal(
find('.rose-message-subtitle').textContent.trim(),
'Error 404'
);
});
test('can create a new credential stores', async function (assert) {
assert.expect(1);
const count = getCredentialStoresCount();
@@ -132,160 +109,4 @@ module('Acceptance | credential-stores', function (hooks) {
'Name is required.'
);
});
test('can save changes to existing credential store', async function (assert) {
assert.expect(3);
assert.notEqual(instances.credentialStore.name, 'random string');
await visit(urls.credentialStore);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
await click('.rose-form-actions [type="submit"]');
assert.equal(currentURL(), urls.credentialStore);
assert.equal(
this.server.schema.credentialStores.all().models[0].name,
'random string'
);
});
test('can cancel changes to existing credential store', async function (assert) {
assert.expect(2);
await visit(urls.credentialStore);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
await click('.rose-form-actions [type="button"]');
assert.notEqual(instances.credentialStore.name, 'random string');
assert.equal(find('[name="name"]').value, instances.credentialStore.name);
});
test('saving an existing credential store with invalid fields displays error messages', async function (assert) {
assert.expect(2);
this.server.patch('/credential-stores/:id', () => {
return new Response(
400,
{},
{
status: 400,
code: 'invalid_argument',
message: 'The request was invalid.',
details: {
request_fields: [
{
name: 'name',
description: 'Name is required.',
},
],
},
}
);
});
await visit(urls.credentialStore);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
await click('[type="submit"]');
assert.ok(
find('[role="alert"]').textContent.trim(),
'The request was invalid.'
);
assert.ok(
find('.rose-form-error-message').textContent.trim(),
'Name is required.'
);
});
test('can discard unsaved credential store changes via dialog', async function (assert) {
assert.expect(5);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
assert.notEqual(instances.credentialStore.name, 'random string');
await visit(urls.credentialStore);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
assert.equal(currentURL(), urls.credentialStore);
try {
await visit(urls.credentialStores);
} catch (e) {
assert.ok(find('.rose-dialog'));
await click('.rose-dialog-footer button:first-child', 'Click Discard');
assert.equal(currentURL(), urls.credentialStores);
assert.notEqual(
this.server.schema.credentialStores.all().models[0].name,
'random string'
);
}
});
test('can cancel discard unsaved credential store via dialog', async function (assert) {
assert.expect(5);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
assert.notEqual(instances.credentialStore.name, 'random string');
await visit(urls.credentialStore);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
assert.equal(currentURL(), urls.credentialStore);
try {
await visit(urls.credentialStores);
} catch (e) {
assert.ok(find('.rose-dialog'));
await click('.rose-dialog-footer button:last-child');
assert.equal(currentURL(), urls.credentialStore);
assert.notEqual(
this.server.schema.credentialStores.all().models[0].name,
'random string'
);
}
});
test('can delete credential store', async function (assert) {
assert.expect(1);
const count = getCredentialStoresCount();
await visit(urls.credentialStore);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.equal(getCredentialStoresCount(), count - 1);
});
test('can accept delete credential store via dialog', async function (assert) {
assert.expect(2);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
confirmService.confirm = sinon.fake.returns(resolve());
const count = getCredentialStoresCount();
await visit(urls.credentialStore);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.equal(getCredentialStoresCount(), count - 1);
assert.ok(confirmService.confirm.calledOnce);
});
test('cannot cancel delete credential store via dialog', async function (assert) {
assert.expect(2);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
confirmService.confirm = sinon.fake.returns(reject());
const count = getCredentialStoresCount();
await visit(urls.credentialStore);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.equal(getCredentialStoresCount(), count);
assert.ok(confirmService.confirm.calledOnce);
});
test('deleting a credential store which errors displays error messages', async function (assert) {
assert.expect(1);
this.server.del('/credential-stores/:id', () => {
return new Response(
490,
{},
{
status: 490,
code: 'error',
message: 'Oops.',
}
);
});
await visit(urls.credentialStore);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.ok(find('[role="alert"]').textContent.trim(), 'Oops.');
});
});