CyberCoveLLC/threshold-ui
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: 💡 worker filter feature flags (#2720)

Browse Source
This commit is contained in:
Dharini Jeeva authored and GitHub committed 2025-03-13 15:12:36 -07:00
1 parent ecd0c1de20
commit dff5cac4fe
16 files changed
+35 -39
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ui/admin/tests/acceptance/credential-store/create-test.js
+1 -1
View File
@@ -91,7 +91,7 @@ module('Acceptance | credential-stores | create', function (hooks) {
test('Users can create a new credential store of type vault with a worker filter', async function (assert) {
featuresService.enable('static-credentials');
featuresService.enable('vault-worker-filter');
featuresService.enable('worker-filter');
const count = getVaultCredentialStoresCount();
await visit(urls.newCredentialStore);
ui/admin/tests/acceptance/credential-store/update-test.js
+1 -1
View File
@@ -63,7 +63,7 @@ module('Acceptance | credential-stores | update', function (hooks) {
// Enable feature flag
const featuresService = this.owner.lookup('service:features');
featuresService.enable('vault-worker-filter');
featuresService.enable('worker-filter');
});
test('can save changes to existing static credential store', async function (assert) {
ui/admin/tests/acceptance/host-catalogs/create-test.js
+2 -2
View File
@@ -231,13 +231,13 @@ module('Acceptance | host-catalogs | create', function (hooks) {
});
test('users should see worker filter field in enterprise edition when AWS host catalog is selected', async function (assert) {
featuresService.enable('host-catalog-worker-filter');
featuresService.enable('worker-filter');
await visit(urls.newAWSDynamicHostCatalog);
assert.dom(WORKER_FILTER_INPUT_SELECTOR).isVisible();
});
test('users should see worker filter field in enterprise edition when GCP host catalog is selected', async function (assert) {
featuresService.enable('host-catalog-worker-filter');
featuresService.enable('worker-filter');
await visit(urls.newAWSDynamicHostCatalog);
assert.dom(WORKER_FILTER_INPUT_SELECTOR).isVisible();
});
ui/admin/tests/acceptance/targets/workers-test.js
+12 -12
View File
@@ -161,8 +161,8 @@ module('Acceptance | targets | workers', function (hooks) {
assert.dom(CODE_BLOCK_SELECTOR('egress')).doesNotExist();
});
test('user can view egress and ingress filters when `target-worker-filters-v2-ingress` is enabled', async function (assert) {
featuresService.enable('target-worker-filters-v2-ingress');
test('user can view egress and ingress filters when `worker-filter` is enabled', async function (assert) {
featuresService.enable('worker-filter');
await visit(urls.target);
await click(`[href="${urls.targetWorkers}"]`);
@@ -175,8 +175,8 @@ module('Acceptance | targets | workers', function (hooks) {
.hasText(instances.target.egress_worker_filter);
});
test('user can only view egress filter when `target-worker-filters-v2-ingress` is disabled', async function (assert) {
featuresService.disable('target-worker-filters-v2-ingress');
test('user can only view egress filter when `worker-filter` is disabled', async function (assert) {
featuresService.disable('worker-filter');
await visit(urls.target);
await click(`[href="${urls.targetWorkers}"]`);
@@ -187,8 +187,8 @@ module('Acceptance | targets | workers', function (hooks) {
.hasText(instances.target.egress_worker_filter);
});
test('user can save ingress worker filter to a target when `target-worker-filters-v2-ingress` is enabled', async function (assert) {
featuresService.enable('target-worker-filters-v2-ingress');
test('user can save ingress worker filter to a target when `worker-filter` is enabled', async function (assert) {
featuresService.enable('worker-filter');
instances.target.update({ ingress_worker_filter: '' });
const ingressWorkerFilter = '"random" in "/worker/filters"';
await visit(urls.target);
@@ -205,8 +205,8 @@ module('Acceptance | targets | workers', function (hooks) {
assert.dom(CODE_BLOCK_SELECTOR('ingress')).hasText(ingressWorkerFilter);
});
test('user can cancel changes to ingress worker filter in a target when `target-worker-filters-v2-ingress` is enabled', async function (assert) {
featuresService.enable('target-worker-filters-v2-ingress');
test('user can cancel changes to ingress worker filter in a target when `worker-filter` is enabled', async function (assert) {
featuresService.enable('worker-filter');
const ingressWorkerFilter = '"random" in "/worker/filters"';
await visit(urls.target);
@@ -246,7 +246,7 @@ module('Acceptance | targets | workers', function (hooks) {
});
test('user will see "Add worker filter" if no filter set', async function (assert) {
featuresService.enable('target-worker-filters-v2-ingress');
featuresService.enable('worker-filter');
instances.target.update({
egress_worker_filter: '',
ingress_worker_filter: '',
@@ -264,7 +264,7 @@ module('Acceptance | targets | workers', function (hooks) {
});
test('user will see "Edit worker filter" if filter is set', async function (assert) {
featuresService.enable('target-worker-filters-v2-ingress');
featuresService.enable('worker-filter');
await visit(urls.target);
await click(`[href="${urls.targetWorkers}"]`);
@@ -296,7 +296,7 @@ module('Acceptance | targets | workers', function (hooks) {
});
test('can discard unsaved ingress worker filter changes in a target via dialog', async function (assert) {
featuresService.enable('target-worker-filters-v2-ingress');
featuresService.enable('worker-filter');
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
const ingressWorkerFilter = '"random" in "/worker/filters"';
@@ -321,7 +321,7 @@ module('Acceptance | targets | workers', function (hooks) {
});
test('can click cancel on discard dialog box for unsaved ingress worker filter changes', async function (assert) {
featuresService.enable('target-worker-filters-v2-ingress');
featuresService.enable('worker-filter');
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
const ingressWorkerFilter = '"random" in "/worker/filters"';
ui/admin/tests/integration/components/worker-diagram/dual-filter/hcp/index-test.js
+1 -1
View File
@@ -16,7 +16,7 @@ module(
setupIntl(hooks, 'en-us');
let featuresService;
const targetWorkerFilterHCP = 'target-worker-filters-v2-hcp';
const targetWorkerFilterHCP = 'worker-filter-hcp';
hooks.beforeEach(function () {
featuresService = this.owner.lookup('service:features');
ui/admin/tests/integration/components/worker-diagram/dual-filter/index-test.js
+1 -1
View File
@@ -16,7 +16,7 @@ module(
setupIntl(hooks, 'en-us');
let featuresService;
const targetWorkerFilterIngress = 'target-worker-filters-v2-ingress';
const targetWorkerFilterIngress = 'worker-filter';
hooks.beforeEach(function () {
featuresService = this.owner.lookup('service:features');
ui/admin/tests/integration/components/worker-diagram/index-test.js
+4 -4
View File
@@ -14,8 +14,8 @@ module('Integration | Component | worker-diagram/index', function (hooks) {
setupIntl(hooks, 'en-us');
let featuresService;
const targetWorkerFilterIngress = 'target-worker-filters-v2-ingress';
const targetWorkerFilterHCP = 'target-worker-filters-v2-hcp';
const targetWorkerFilterIngress = 'worker-filter';
const targetWorkerFilterHCP = 'worker-filter-hcp';
test('it renders a single filter diagram', async function (assert) {
featuresService = this.owner.lookup('service:features');
@@ -25,7 +25,7 @@ module('Integration | Component | worker-diagram/index', function (hooks) {
assert.dom('[data-test-single-filter-egress-off]').isVisible();
});
test('it renders a dual filter diagram when `target-worker-filters-v2-ingress` is enabled', async function (assert) {
test('it renders a dual filter diagram when `worker-filter` is enabled', async function (assert) {
featuresService = this.owner.lookup('service:features');
featuresService.enable(targetWorkerFilterIngress);
assert.true(featuresService.isEnabled(targetWorkerFilterIngress));
@@ -35,7 +35,7 @@ module('Integration | Component | worker-diagram/index', function (hooks) {
assert.dom('[data-test-dual-filter-egress-off-ingress-off]').isVisible();
});
test('it renders an HCP dual filter diagram when `target-worker-filters-v2-hcp` is enabled', async function (assert) {
test('it renders an HCP dual filter diagram when `worker-filter-hcp` is enabled', async function (assert) {
featuresService = this.owner.lookup('service:features');
featuresService.enable(targetWorkerFilterIngress);
featuresService.enable(targetWorkerFilterHCP);