Icu 16535 refactor usage of did insert modifiers (#2722)

* refactor: 💡 remove ember-render-modifiers {{did-insert}} usage

ui/admin/app/components/breadcrumbs/container/index.hbs

@@ -6,7 +6,7 @@
 <Hds::Breadcrumb
   ...attributes
   data-test-breadcrumbs-container
-  {{did-insert this.registerContainer}}
+  {{this.insertedBreadcrumbContainer}}
 >
   {{yield}}
 </Hds::Breadcrumb>

ui/admin/app/components/breadcrumbs/container/index.js

@@ -5,7 +5,7 @@
 
 import Component from '@glimmer/component';
 import { service } from '@ember/service';
-import { action } from '@ember/object';
+import { modifier } from 'ember-modifier';
 
 /*
   The `containers` property from the `breadcrumbsService` is tracked
@@ -18,8 +18,7 @@ export default class BreadcrumbsContainerComponent extends Component {
 
   container = null;
 
-  @action
-  registerContainer(element) {
+  insertedBreadcrumbContainer = modifier((element) => {
     // A child `ol` is rendered in the Hds::Breadcrumb container and this is
     // the element that the in-element helper should drop breadcrumbs into.
     this.container = {
@@ -27,11 +26,7 @@ export default class BreadcrumbsContainerComponent extends Component {
     };
 
     this.breadcrumbsService.registerContainer(this.container);
-  }
 
-  willDestroy() {
-    super.willDestroy(...arguments);
-
-    this.breadcrumbsService.unregisterContainer(this.container);
-  }
+    return () => this.breadcrumbsService.unregisterContainer(this.container);
+  });
 }

ui/admin/app/components/breadcrumbs/item/index.hbs

@@ -14,7 +14,7 @@
       @model={{@model}}
       @current={{this.current}}
       ...attributes
-      {{did-insert this.registerSelf}}
+      {{this.insertedBreadcrumbItem}}
       data-test-breadcrumbs-item
     />
   {{/in-element}}

ui/admin/app/components/breadcrumbs/item/index.js

@@ -5,8 +5,8 @@
 
 import Component from '@glimmer/component';
 import { service } from '@ember/service';
-import { action } from '@ember/object';
 import { tracked } from '@glimmer/tracking';
+import { modifier } from 'ember-modifier';
 
 /*
   `BreadcrumbsItem` inserts the crumbs to an existing container.
@@ -18,10 +18,9 @@ export default class BreadcrumbsItemComponent extends Component {
 
   @tracked element = null;
 
-  @action
-  registerSelf(element) {
+  insertedBreadcrumbItem = modifier((element) => {
     this.element = element;
-  }
+  });
 
   get current() {
     const crumbs = this.breadcrumbsService.containers[0].element.children;