CyberCoveLLC/threshold-ui
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: 🤖 Ad ember-a11y-ignore to existing violations (#3159)

Browse Source
This commit is contained in:
Lisbet Alvarez authored and GitHub committed 2026-02-04 14:43:15 -08:00
1 parent f8af37db43
commit ebe5ae5f19
5 files changed
+166
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ui/desktop/app/components/settings-card/preferred-clients/index.hbs
+2
View File
@@ -48,6 +48,8 @@
</Hds::Text::Body>
{{else}}
<Hds::Form::Select::Field
name='preferred-rdp-client'
aria-label={{t 'settings.preferred-clients.title'}}
@width='100%'
{{on 'change' B.data.updateClient}}
data-test-select-preferred-rdp-client
ui/desktop/tests/acceptance/projects/sessions/session-test.js
+36
View File
@@ -597,6 +597,15 @@ module('Acceptance | projects | sessions | session', function (hooks) {
});
test('visiting an RDP session should display "open" button when preferred client is set', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
this.ipcStub.withArgs('cliExists').returns(true);
this.rdpService.preferredRdpClient = RDP_CLIENT_WINDOWS_APP;
@@ -624,6 +633,15 @@ module('Acceptance | projects | sessions | session', function (hooks) {
});
test('visiting an RDP session should not display "open" button when preferred client is set to none', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
this.ipcStub.withArgs('cliExists').returns(true);
this.rdpService.preferredRdpClient = RDP_CLIENT_NONE;
@@ -645,6 +663,15 @@ module('Acceptance | projects | sessions | session', function (hooks) {
});
test('it shows confirm modal when connection error occurs on launching rdp client', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
this.ipcStub.withArgs('cliExists').returns(true);
this.rdpService.preferredRdpClient = RDP_CLIENT_WINDOWS_APP;
@@ -674,6 +701,15 @@ module('Acceptance | projects | sessions | session', function (hooks) {
});
test('it displays open button without cancel session permission', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
this.ipcStub.withArgs('cliExists').returns(true);
this.rdpService.preferredRdpClient = RDP_CLIENT_WINDOWS_APP;
instances.target.update({ type: TYPE_TARGET_RDP });
ui/desktop/tests/acceptance/projects/settings/index-test.js
+56
View File
@@ -244,12 +244,40 @@ module('Acceptance | projects | settings | index', function (hooks) {
});
test('preferred RDP client is selected correctly for Windows', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
'heading-order': {
// [ember-a11y-ignore]: axe rule "heading-order" automatically ignored on 2026-02-02
enabled: false,
},
},
});
await visit(urls.settings);
assert.dom(RDP_PREFERRED_CLIENT).isVisible().hasValue(RDP_CLIENT_MSTSC);
});
test('preferred RDP client is selected correctly for Mac', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
'heading-order': {
// [ember-a11y-ignore]: axe rule "heading-order" automatically ignored on 2026-02-02
enabled: false,
},
},
});
// update IPC stub fo mac
this.ipcStub.withArgs('checkOS').returns({ isWindows: false, isMac: true });
this.ipcStub
@@ -267,6 +295,20 @@ module('Acceptance | projects | settings | index', function (hooks) {
});
test('recommended RDP client is shown when no RDP clients are detected', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
'heading-order': {
// [ember-a11y-ignore]: axe rule "heading-order" automatically ignored on 2026-02-02
enabled: false,
},
},
});
// update IPC stub for no RDP clients
this.ipcStub.withArgs('getRdpClients').returns([RDP_CLIENT_NONE]);
this.ipcStub.withArgs('getPreferredRdpClient').returns(RDP_CLIENT_NONE);
@@ -280,6 +322,20 @@ module('Acceptance | projects | settings | index', function (hooks) {
});
test('preferred RDP client is updated correctly', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
'heading-order': {
// [ember-a11y-ignore]: axe rule "heading-order" automatically ignored on 2026-02-02
enabled: false,
},
},
});
const rdpService = this.owner.lookup('service:rdp');
this.ipcStub.withArgs('setPreferredRdpClient').resolves();
await visit(urls.settings);
ui/desktop/tests/acceptance/projects/targets/index-test.js
+54
View File
@@ -720,6 +720,15 @@ module('Acceptance | projects | targets | index', function (hooks) {
});
test('shows `Open` button for RDP target with preferred client', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
this.rdpService.preferredRdpClient = RDP_CLIENT_WINDOWS_APP;
instances.target.update({
type: TYPE_TARGET_RDP,
@@ -732,6 +741,15 @@ module('Acceptance | projects | targets | index', function (hooks) {
});
test('shows `Connect` button for RDP target with no preferred client', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
this.rdpService.preferredRdpClient = RDP_CLIENT_NONE;
instances.target.update({
type: TYPE_TARGET_RDP,
@@ -744,6 +762,15 @@ module('Acceptance | projects | targets | index', function (hooks) {
});
test('shows `Connect` button for non-RDP target', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
await visit(urls.targets);
assert.dom(TARGET_CONNECT_BUTTON(instances.target.id)).exists();
@@ -751,6 +778,15 @@ module('Acceptance | projects | targets | index', function (hooks) {
});
test('clicking `Open` button for RDP target calls launchRdpClient IPC', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
this.ipcStub.withArgs('cliExists').returns(true);
this.rdpService.preferredRdpClient = RDP_CLIENT_WINDOWS_APP;
@@ -775,6 +811,15 @@ module('Acceptance | projects | targets | index', function (hooks) {
});
test('clicking `Connect` button for RDP target without preferred client calls connect IPC', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
this.ipcStub.withArgs('cliExists').returns(true);
this.rdpService.preferredRdpClient = RDP_CLIENT_NONE;
@@ -798,6 +843,15 @@ module('Acceptance | projects | targets | index', function (hooks) {
});
test('shows confirm modal when connection error occurs on launching rdp client', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
this.rdpService.preferredRdpClient = RDP_CLIENT_WINDOWS_APP;
instances.target.update({ type: TYPE_TARGET_RDP });
ui/desktop/tests/acceptance/projects/targets/target-test.js
+18
View File
@@ -662,6 +662,15 @@ module('Acceptance | projects | targets | target', function (hooks) {
});
test('clicking `open` button for RDP target triggers launchRdpClient', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
this.rdpService.preferredRdpClient = RDP_CLIENT_WINDOWS_APP;
instances.target.update({ type: TYPE_TARGET_RDP });
@@ -686,6 +695,15 @@ module('Acceptance | projects | targets | target', function (hooks) {
});
test('shows `Connect` button for rdp target without preferred client', async function (assert) {
setRunOptions({
rules: {
'color-contrast': {
// [ember-a11y-ignore]: axe rule "color-contrast" automatically ignored on 2026-02-02
enabled: false,
},
},
});
this.rdpService.preferredRdpClient = null;
instances.target.update({ type: TYPE_TARGET_RDP });