CyberCoveLLC/threshold
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refact(e2e): Rename credential methods for clarity (#6219)

Browse Source 
* refact(e2e): Rename method to usernamepassworddomain

* refact(e2e): Rename method to usernamepassword
This commit is contained in:
Michael Li authored and GitHub committed 2025-11-04 14:29:05 -05:00
1 parent 31277e0b23
commit 06d69f699e
9 files changed
+13 -13
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

testing/internal/e2e/boundary/credential.go
+4 -4
View File
@@ -202,10 +202,10 @@ func CreateStaticCredentialPrivateKeyCli(t testing.TB, ctx context.Context, cred
return credentialId, nil
}
// CreateStaticCredentialPasswordCli uses the cli to create a new password credential in the
// CreateStaticCredentialUsernamePasswordCli uses the cli to create a new password credential in the
// provided static credential store.
// Returns the id of the new credential
func CreateStaticCredentialPasswordCli(t testing.TB, ctx context.Context, credentialStoreId string, user string, password string) (string, error) {
func CreateStaticCredentialUsernamePasswordCli(t testing.TB, ctx context.Context, credentialStoreId string, user string, password string) (string, error) {
name, err := base62.Random(16)
if err != nil {
return "", err
@@ -238,10 +238,10 @@ func CreateStaticCredentialPasswordCli(t testing.TB, ctx context.Context, creden
return credentialId, nil
}
// CreateStaticCredentialPasswordDomainCli uses the cli to create a new username password domain credential in the
// CreateStaticCredentialUsernamePasswordDomainCli uses the cli to create a new username password domain credential in the
// provided static credential store.
// Returns the id of the new credential
func CreateStaticCredentialPasswordDomainCli(t testing.TB, ctx context.Context, credentialStoreId string, user string, password string, domain string) (string, error) {
func CreateStaticCredentialUsernamePasswordDomainCli(t testing.TB, ctx context.Context, credentialStoreId string, user string, password string, domain string) (string, error) {
name, err := base62.Random(16)
if err != nil {
return "", err
testing/internal/e2e/tests/base/credential_store_test.go
+2 -2
View File
@@ -77,11 +77,11 @@ func TestCliStaticCredentialStore(t *testing.T) {
require.NoError(t, err)
privateKeyCredentialsId, err := boundary.CreateStaticCredentialPrivateKeyCli(t, ctx, storeId, c.TargetSshUser, testPemFile)
require.NoError(t, err)
pwCredentialId, err := boundary.CreateStaticCredentialPasswordCli(t, ctx, storeId, c.TargetSshUser, testPassword)
pwCredentialId, err := boundary.CreateStaticCredentialUsernamePasswordCli(t, ctx, storeId, c.TargetSshUser, testPassword)
require.NoError(t, err)
jsonCredentialId, err := boundary.CreateStaticCredentialJsonCli(t, ctx, storeId, testCredentialsFile)
require.NoError(t, err)
updCredentialId, err := boundary.CreateStaticCredentialPasswordDomainCli(t, ctx, storeId, c.TargetSshUser, testPassword, testDomain)
updCredentialId, err := boundary.CreateStaticCredentialUsernamePasswordDomainCli(t, ctx, storeId, c.TargetSshUser, testPassword, testDomain)
require.NoError(t, err)
// Get credentials for target (expect empty)
testing/internal/e2e/tests/base/paginate_credential_test.go
+1 -1
View File
@@ -88,7 +88,7 @@ func TestCliPaginateCredentials(t *testing.T) {
assert.Empty(t, initialCredentials.ListToken)
// Create a new credential and destroy one of the other credentials
credentialId, err := boundary.CreateStaticCredentialPasswordCli(t, ctx, storeId, "user", "password")
credentialId, err := boundary.CreateStaticCredentialUsernamePasswordCli(t, ctx, storeId, "user", "password")
require.NoError(t, err)
output = e2e.RunCommand(ctx, "boundary",
e2e.WithArgs(
testing/internal/e2e/tests/base/target_tcp_connect_cassandra_test.go
+1 -1
View File
@@ -82,7 +82,7 @@ func TestCliTcpTargetConnectCassandra(t *testing.T) {
storeId, err := boundary.CreateCredentialStoreStaticCli(t, ctx, projectId)
require.NoError(t, err)
credentialId, err := boundary.CreateStaticCredentialPasswordCli(
credentialId, err := boundary.CreateStaticCredentialUsernamePasswordCli(
t,
ctx,
storeId,
testing/internal/e2e/tests/base/target_tcp_connect_mongo_test.go
+1 -1
View File
@@ -83,7 +83,7 @@ func TestCliTcpTargetConnectMongo(t *testing.T) {
storeId, err := boundary.CreateCredentialStoreStaticCli(t, ctx, projectId)
require.NoError(t, err)
credentialId, err := boundary.CreateStaticCredentialPasswordCli(
credentialId, err := boundary.CreateStaticCredentialUsernamePasswordCli(
t,
ctx,
storeId,
testing/internal/e2e/tests/base/target_tcp_connect_mysql_test.go
+1 -1
View File
@@ -82,7 +82,7 @@ func TestCliTcpTargetConnectMysql(t *testing.T) {
storeId, err := boundary.CreateCredentialStoreStaticCli(t, ctx, projectId)
require.NoError(t, err)
credentialId, err := boundary.CreateStaticCredentialPasswordCli(
credentialId, err := boundary.CreateStaticCredentialUsernamePasswordCli(
t,
ctx,
storeId,
testing/internal/e2e/tests/base/target_tcp_connect_redis_test.go
+1 -1
View File
@@ -84,7 +84,7 @@ func TestCliTcpTargetConnectRedis(t *testing.T) {
storeId, err := boundary.CreateCredentialStoreStaticCli(t, ctx, projectId)
require.NoError(t, err)
credentialId, err := boundary.CreateStaticCredentialPasswordCli(
credentialId, err := boundary.CreateStaticCredentialUsernamePasswordCli(
t,
ctx,
storeId,
testing/internal/e2e/tests/base_plus/target_tcp_connect_postgres_test.go
+1 -1
View File
@@ -47,7 +47,7 @@ func TestCliTcpTargetConnectPostgres(t *testing.T) {
require.NoError(t, err)
storeId, err := boundary.CreateCredentialStoreStaticCli(t, ctx, projectId)
require.NoError(t, err)
credentialId, err := boundary.CreateStaticCredentialPasswordCli(
credentialId, err := boundary.CreateStaticCredentialUsernamePasswordCli(
t,
ctx,
storeId,
testing/internal/e2e/tests/database/migration_test.go
+1 -1
View File
@@ -268,7 +268,7 @@ func populateBoundaryDatabase(t testing.TB, ctx context.Context, c *config, te T
// Create static credentials
storeId, err := boundary.CreateCredentialStoreStaticCli(t, ctx, projectId)
require.NoError(t, err)
_, err = boundary.CreateStaticCredentialPasswordCli(t, ctx, storeId, c.TargetSshUser, "password")
_, err = boundary.CreateStaticCredentialUsernamePasswordCli(t, ctx, storeId, c.TargetSshUser, "password")
require.NoError(t, err)
_, err = boundary.CreateStaticCredentialJsonCli(t, ctx, storeId, "testdata/credential.json")
require.NoError(t, err)