test(servers base): add tests ahead of functionality change
Adds tests to `SetupControllerPublicClusterAddress` and `SetupWorkerPublicAddress` ahead of changes in these functions to ensure functionality is preserved.
This commit is contained in:
1 parent
5417cc5cb0
commit
21a771b581
1 file changed
+441
@@ -5,9 +5,12 @@ import (
|
||||
"sync"
|
||||
"testing"
|
||||
|
||||
"github.com/hashicorp/boundary/internal/cmd/config"
|
||||
"github.com/hashicorp/boundary/internal/errors"
|
||||
"github.com/hashicorp/boundary/internal/observability/event"
|
||||
"github.com/hashicorp/go-hclog"
|
||||
"github.com/hashicorp/go-secure-stdlib/configutil"
|
||||
"github.com/hashicorp/go-secure-stdlib/listenerutil"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
@@ -209,3 +212,441 @@ func TestServer_AddEventerToContext(t *testing.T) {
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestSetupControllerPublicClusterAddress(t *testing.T) {
|
||||
t.Parallel()
|
||||
tests := []struct {
|
||||
name string
|
||||
inputConfig *config.Config
|
||||
inputFlagValue string
|
||||
stateFn func(t *testing.T)
|
||||
expErr bool
|
||||
expErrStr string
|
||||
expPublicClusterAddress string
|
||||
}{
|
||||
{
|
||||
name: "nil controller",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Controller: nil,
|
||||
},
|
||||
inputFlagValue: "",
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicClusterAddress: ":9201",
|
||||
},
|
||||
{
|
||||
name: "setting public cluster address directly with ip",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Controller: &config.Controller{
|
||||
PublicClusterAddr: "127.0.0.1",
|
||||
},
|
||||
},
|
||||
inputFlagValue: "",
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicClusterAddress: "127.0.0.1:9201",
|
||||
},
|
||||
{
|
||||
name: "setting public cluster address directly with ip:port",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Controller: &config.Controller{
|
||||
PublicClusterAddr: "127.0.0.1:8080",
|
||||
},
|
||||
},
|
||||
inputFlagValue: "",
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicClusterAddress: "127.0.0.1:8080",
|
||||
},
|
||||
{
|
||||
name: "setting pubic cluster address to env var",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Controller: &config.Controller{
|
||||
PublicClusterAddr: "env://TEST_ENV_VAR_FOR_CONTROLLER_ADDR",
|
||||
},
|
||||
},
|
||||
inputFlagValue: "",
|
||||
stateFn: func(t *testing.T) {
|
||||
t.Setenv("TEST_ENV_VAR_FOR_CONTROLLER_ADDR", "127.0.0.1:8080")
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicClusterAddress: "127.0.0.1:8080",
|
||||
},
|
||||
{
|
||||
name: "using flag value with ip only",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Controller: &config.Controller{},
|
||||
},
|
||||
inputFlagValue: "127.0.0.1",
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicClusterAddress: "127.0.0.1:9201",
|
||||
},
|
||||
{
|
||||
name: "using flag value with ip:port",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Controller: &config.Controller{},
|
||||
},
|
||||
inputFlagValue: "127.0.0.1:8080",
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicClusterAddress: "127.0.0.1:8080",
|
||||
},
|
||||
{
|
||||
name: "using flag value to point to env var with ip only",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Controller: &config.Controller{},
|
||||
},
|
||||
inputFlagValue: "env://TEST_ENV_VAR_FOR_CONTROLLER_ADDR",
|
||||
stateFn: func(t *testing.T) {
|
||||
t.Setenv("TEST_ENV_VAR_FOR_CONTROLLER_ADDR", "127.0.0.1")
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicClusterAddress: "127.0.0.1:9201",
|
||||
},
|
||||
{
|
||||
name: "using flag value to point to env var with ip:port",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Controller: &config.Controller{},
|
||||
},
|
||||
inputFlagValue: "env://TEST_ENV_VAR_FOR_CONTROLLER_ADDR",
|
||||
stateFn: func(t *testing.T) {
|
||||
t.Setenv("TEST_ENV_VAR_FOR_CONTROLLER_ADDR", "127.0.0.1:8080")
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicClusterAddress: "127.0.0.1:8080",
|
||||
},
|
||||
{
|
||||
name: "read address from listeners ip only",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{
|
||||
{Purpose: []string{"cluster"}, Address: "127.0.0.1"},
|
||||
},
|
||||
},
|
||||
Controller: &config.Controller{},
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicClusterAddress: "127.0.0.1:9201",
|
||||
},
|
||||
{
|
||||
name: "read address from listeners ip:port",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{
|
||||
{Purpose: []string{"cluster"}, Address: "127.0.0.1:8080"},
|
||||
},
|
||||
},
|
||||
Controller: &config.Controller{},
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicClusterAddress: "127.0.0.1:8080",
|
||||
},
|
||||
{
|
||||
name: "read address from listeners is ignored on different purpose",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{
|
||||
{Purpose: []string{"somethingelse"}, Address: "127.0.0.1:8080"},
|
||||
},
|
||||
},
|
||||
Controller: &config.Controller{},
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicClusterAddress: ":9201",
|
||||
},
|
||||
{
|
||||
name: "using flag value to point to nonexistent file",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Controller: &config.Controller{},
|
||||
},
|
||||
inputFlagValue: "file://this_doesnt_exist_for_sure",
|
||||
expErr: true,
|
||||
expErrStr: "Error parsing public cluster addr: error reading file at file://this_doesnt_exist_for_sure: open this_doesnt_exist_for_sure: no such file or directory",
|
||||
expPublicClusterAddress: "",
|
||||
},
|
||||
{
|
||||
name: "using flag value to provoke error in SpitHostPort",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Controller: &config.Controller{},
|
||||
},
|
||||
inputFlagValue: "abc::123",
|
||||
expErr: true,
|
||||
expErrStr: "Error splitting public cluster adddress host/port: address abc::123: too many colons in address",
|
||||
expPublicClusterAddress: "",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
if tt.stateFn != nil {
|
||||
tt.stateFn(t)
|
||||
}
|
||||
s := Server{}
|
||||
err := s.SetupControllerPublicClusterAddress(tt.inputConfig, tt.inputFlagValue)
|
||||
if tt.expErr {
|
||||
require.EqualError(t, err, tt.expErrStr)
|
||||
return
|
||||
}
|
||||
|
||||
require.NoError(t, err)
|
||||
require.NotNil(t, tt.inputConfig.Controller)
|
||||
require.Equal(t, tt.expPublicClusterAddress, tt.inputConfig.Controller.PublicClusterAddr)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestSetupWorkerPublicAddress(t *testing.T) {
|
||||
t.Parallel()
|
||||
tests := []struct {
|
||||
name string
|
||||
inputConfig *config.Config
|
||||
inputFlagValue string
|
||||
stateFn func(t *testing.T)
|
||||
expErr bool
|
||||
expErrStr string
|
||||
expPublicAddress string
|
||||
}{
|
||||
{
|
||||
name: "nil worker",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Worker: nil,
|
||||
},
|
||||
inputFlagValue: "",
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicAddress: ":9202",
|
||||
},
|
||||
{
|
||||
name: "setting public address directly with ip",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Worker: &config.Worker{
|
||||
PublicAddr: "127.0.0.1",
|
||||
},
|
||||
},
|
||||
inputFlagValue: "",
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicAddress: "127.0.0.1:9202",
|
||||
},
|
||||
{
|
||||
name: "setting public address directly with ip:port",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Worker: &config.Worker{
|
||||
PublicAddr: "127.0.0.1:8080",
|
||||
},
|
||||
},
|
||||
inputFlagValue: "",
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicAddress: "127.0.0.1:8080",
|
||||
},
|
||||
{
|
||||
name: "setting pubic address to env var",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Worker: &config.Worker{
|
||||
PublicAddr: "env://TEST_ENV_VAR_FOR_WORKER_ADDR",
|
||||
},
|
||||
},
|
||||
inputFlagValue: "",
|
||||
stateFn: func(t *testing.T) {
|
||||
t.Setenv("TEST_ENV_VAR_FOR_WORKER_ADDR", "127.0.0.1:8080")
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicAddress: "127.0.0.1:8080",
|
||||
},
|
||||
{
|
||||
name: "using flag value with ip only",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Worker: &config.Worker{},
|
||||
},
|
||||
inputFlagValue: "127.0.0.1",
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicAddress: "127.0.0.1:9202",
|
||||
},
|
||||
{
|
||||
name: "using flag value with ip:port",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Worker: &config.Worker{},
|
||||
},
|
||||
inputFlagValue: "127.0.0.1:8080",
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicAddress: "127.0.0.1:8080",
|
||||
},
|
||||
{
|
||||
name: "using flag value to point to env var with ip only",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Worker: &config.Worker{},
|
||||
},
|
||||
inputFlagValue: "env://TEST_ENV_VAR_FOR_WORKER_ADDR",
|
||||
stateFn: func(t *testing.T) {
|
||||
t.Setenv("TEST_ENV_VAR_FOR_WORKER_ADDR", "127.0.0.1")
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicAddress: "127.0.0.1:9202",
|
||||
},
|
||||
{
|
||||
name: "using flag value to point to env var with ip:port",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Worker: &config.Worker{},
|
||||
},
|
||||
inputFlagValue: "env://TEST_ENV_VAR_FOR_WORKER_ADDR",
|
||||
stateFn: func(t *testing.T) {
|
||||
t.Setenv("TEST_ENV_VAR_FOR_WORKER_ADDR", "127.0.0.1:8080")
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicAddress: "127.0.0.1:8080",
|
||||
},
|
||||
{
|
||||
name: "read address from listeners ip only",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{
|
||||
{Purpose: []string{"proxy"}, Address: "127.0.0.1"},
|
||||
},
|
||||
},
|
||||
Worker: &config.Worker{},
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicAddress: "127.0.0.1:9202",
|
||||
},
|
||||
{
|
||||
name: "read address from listeners ip:port",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{
|
||||
{Purpose: []string{"proxy"}, Address: "127.0.0.1:8080"},
|
||||
},
|
||||
},
|
||||
Worker: &config.Worker{},
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicAddress: "127.0.0.1:8080",
|
||||
},
|
||||
{
|
||||
name: "read address from listeners is ignored on different purpose",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{
|
||||
{Purpose: []string{"somethingelse"}, Address: "127.0.0.1:8080"},
|
||||
},
|
||||
},
|
||||
Worker: &config.Worker{},
|
||||
},
|
||||
expErr: false,
|
||||
expErrStr: "",
|
||||
expPublicAddress: ":9202",
|
||||
},
|
||||
{
|
||||
name: "using flag value to point to nonexistent file",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Worker: &config.Worker{},
|
||||
},
|
||||
inputFlagValue: "file://this_doesnt_exist_for_sure",
|
||||
expErr: true,
|
||||
expErrStr: "Error parsing public addr: error reading file at file://this_doesnt_exist_for_sure: open this_doesnt_exist_for_sure: no such file or directory",
|
||||
expPublicAddress: "",
|
||||
},
|
||||
{
|
||||
name: "using flag value to provoke error in SpitHostPort",
|
||||
inputConfig: &config.Config{
|
||||
SharedConfig: &configutil.SharedConfig{
|
||||
Listeners: []*listenerutil.ListenerConfig{},
|
||||
},
|
||||
Worker: &config.Worker{},
|
||||
},
|
||||
inputFlagValue: "abc::123",
|
||||
expErr: true,
|
||||
expErrStr: "Error splitting public adddress host/port: address abc::123: too many colons in address",
|
||||
expPublicAddress: "",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
if tt.stateFn != nil {
|
||||
tt.stateFn(t)
|
||||
}
|
||||
s := Server{}
|
||||
err := s.SetupWorkerPublicAddress(tt.inputConfig, tt.inputFlagValue)
|
||||
if tt.expErr {
|
||||
require.EqualError(t, err, tt.expErrStr)
|
||||
return
|
||||
}
|
||||
|
||||
require.NoError(t, err)
|
||||
require.NotNil(t, tt.inputConfig.Worker)
|
||||
require.Equal(t, tt.expPublicAddress, tt.inputConfig.Worker.PublicAddr)
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user