CyberCoveLLC/threshold
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

internal/db: use more efficient index for host listing (#4256)

Browse Source 
In tests, the index including the catalog_id performs significantly
better.
This commit is contained in:
Johan Brandhorst-Satzkorn authored and GitHub committed 2024-01-19 10:59:18 -08:00
1 parent 22fcf8a2ba
commit b229ece914
2 files changed
+12 -12
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

internal/db/schema/migrations/oss/postgres/81/09_host_table_updates.up.sql
+8 -8
View File
@@ -4,18 +4,18 @@
begin;
-- Add new indexes for the create time and update time queries.
create index host_plugin_host_create_time_public_id_idx
on host_plugin_host (create_time desc, public_id desc);
create index host_plugin_host_update_time_public_id_idx
on host_plugin_host (update_time desc, public_id desc);
create index host_plugin_host_catalog_id_create_time_public_id_idx
on host_plugin_host (catalog_id, create_time desc, public_id desc);
create index host_plugin_host_catalog_id_update_time_public_id_idx
on host_plugin_host (catalog_id, update_time desc, public_id desc);
analyze host_plugin_host;
-- Add new indexes for the create time and update time queries.
create index static_host_create_time_public_id_idx
on static_host (create_time desc, public_id desc);
create index static_host_update_time_public_id_idx
on static_host (update_time desc, public_id desc);
create index static_host_catalog_id_create_time_public_id_idx
on static_host (catalog_id, create_time desc, public_id desc);
create index static_host_catalog_id_update_time_public_id_idx
on static_host (catalog_id, update_time desc, public_id desc);
analyze static_host;
internal/db/sqltest/tests/pagination/host.sql
+4 -4
View File
@@ -4,11 +4,11 @@
begin;
select plan(4);
select has_index('host_plugin_host', 'host_plugin_host_create_time_public_id_idx', array['create_time', 'public_id']);
select has_index('host_plugin_host', 'host_plugin_host_update_time_public_id_idx', array['update_time', 'public_id']);
select has_index('host_plugin_host', 'host_plugin_host_catalog_id_create_time_public_id_idx', array['catalog_id', 'create_time', 'public_id']);
select has_index('host_plugin_host', 'host_plugin_host_catalog_id_update_time_public_id_idx', array['catalog_id', 'update_time', 'public_id']);
select has_index('static_host', 'static_host_create_time_public_id_idx', array['create_time', 'public_id']);
select has_index('static_host', 'static_host_update_time_public_id_idx', array['update_time', 'public_id']);
select has_index('static_host', 'static_host_catalog_id_create_time_public_id_idx', array['catalog_id', 'create_time', 'public_id']);
select has_index('static_host', 'static_host_catalog_id_update_time_public_id_idx', array['catalog_id', 'update_time', 'public_id']);
select * from finish();