bug(workers): Create worker-led panics on invalid token (#2388)
* Check for error before returning result
This commit is contained in:
1 parent
b0bc6bd632
commit
b43e61c8c7
2 files changed
+8
-2
No files matched your search
@@ -291,7 +291,10 @@ func executeExtraOidcActionsImpl(c *OidcCommand, origResp *api.Response, origIte
|
||||
opts = append(opts, authmethods.WithOidcAuthMethodDisableDiscoveredConfigValidation(true))
|
||||
}
|
||||
result, err := amClient.ChangeState(c.Context, c.FlagId, version, c.flagState, opts...)
|
||||
return result.GetResponse(), result.GetItem(), err
|
||||
if err != nil {
|
||||
return nil, nil, err
|
||||
}
|
||||
return result.GetResponse(), result.GetItem(), nil
|
||||
}
|
||||
return origResp, origItem, origError
|
||||
}
|
||||
@@ -58,7 +58,10 @@ func executeExtraWorkerLedActionsImpl(c *WorkerLedCommand, origResp *api.Respons
|
||||
switch c.Func {
|
||||
case "create":
|
||||
result, err := workerClient.CreateWorkerLed(c.Context, c.flagWorkerGeneratedAuthToken, c.FlagScopeId, opts...)
|
||||
return result.GetResponse(), result.GetItem(), err
|
||||
if err != nil {
|
||||
return nil, nil, err
|
||||
}
|
||||
return result.GetResponse(), result.GetItem(), nil
|
||||
}
|
||||
return origResp, origItem, origError
|
||||
}
|
||||
Reference in new issue
Block a user