Commit Graph
12 Commits
Author SHA1 Message Date
Sorawis Nilparuk (Bo) 42e682e120 Mark expired Vault token as expired when Vault is unreachable (#6235)
* add shutdown function to TestVaultServer

* implement shutdown function in TestVaultServer

* stop renewing vault token when token has already expired

* Add comment

* clean up error checks

* modify credential_vault_token_renewal_revocation_view to include expiration_time

* include TokenExpirationTime in clientStore

* add test to validate that unexpired tokens are not set as expired

* add token status validation

* add expiration time validation to tests

* add small comment

* remove unnecessary renew from test

* fix token translation uses wrong time field and add tests

* add more token status validation

* fix lint

* move migration to 103

* remove t.Parallel() comments

* remove unused setup code

* use atomic for testvault.stopped

implement atomic read/write for testvault

* remove file created by merge conflict

* make gen
2026-01-15 12:29:06 -08:00
Sorawis Nilparuk (Bo) fe09f61a85 chore(test) fix flaky tests (#6315)
* internal/cmd/commands/server/listener_reload_test.go remove t.Parallel() comment

* internal/cmd/commands/server/worker_initial_upstreams_reload_test.go remove t.Parallel

* internal/cmd/commands/server/worker_tags_reload_test.go wait by polling worker instead of sleep

* internal/daemon/worker/routing_info.go make deep copy in LastRoutingInfoSuccess to avoid race condition

* internal/tests/cluster/parallel/orphaned_connections_test.go raise grace period time to allow test to wait for longer

* improve logging in sequential tests

* move ports around and use t.Cleanup to send shutdown signal to test server

* fix one typo

* do final assert in t.Cleanup instead of defer

* undo t.Cleanup change

* add another signal to force shutdown running servers

* add exit early and increase server start timeout

* tighten workerRPC settings on session tests

* tighten more workerRPC timing

* make gen

* add comment explaining deep copying lastRoutingInfoSuccess
2026-01-05 10:40:28 -08:00
Sorawis Nilparuk (Bo) b061cc544d fix(bug): runMigrations not using named returned properly (#5913)
* return nil when no transaction is opened

* use named return for retErr

* add a comment
2025-07-09 11:13:03 -07:00
Sorawis Nilparuk (Bo) d32245a33e fix(bug): database migration does not rollback schema version on hook failure (#5908)
* add tests

* correct expect schema version

* use conventional named return

* add rollback test and more description in godoc

* refactor to use commit at the end and defer rollback

* add comment

* lint
2025-07-09 10:11:30 -04:00
Sorawis Nilparuk (Bo) 610aa340fc fix authorized_collections_action not returning for host-catalog (#5899) 2025-07-07 09:26:50 -07:00
Sorawis Nilparuk (Bo) ababe653f9 add tests to all users API (#5879) 2025-06-25 11:34:50 -07:00
Sorawis Nilparuk (Bo) ee26fefc5e bug: fix list target permissions resource ID overriding all resource grants (#5877)
* fix list target not handling all resources permissions

* add test

* fix same bug for session package

* split target tests to two separate tests
2025-06-23 14:03:33 -07:00
Sorawis Nilparuk (Bo) 50303f9c18 bosorawis cherrypick authtoken.TestRoleGrantsForToken removal (#5872)
* bosorawis remove TestRoleGrantsForToken (#5840)

* refactor auth method grants tests

* refactor credential libraries grants tests

* refactor hosts grants tests

* refactor roles grants tests

* refactor scopes grants tests

* refactor tcp targets grants tests

* refactor users grants tests

* refactor worker grants tests

* fix authmethod test broken during the refactor

* remove authtoken.TestRoleGrantsForToken

* add pinned ID test

* correct event name

* fix make gen and lint
# Conflicts:
#	internal/daemon/controller/handlers/roles/grants_test.go
#	internal/daemon/controller/handlers/scopes/grants_test.go
#	internal/daemon/controller/handlers/targets/tcp/grants_test.go
#	internal/daemon/controller/handlers/workers/grants_test.go

* remove one forgotten reference
2025-06-20 14:50:51 -07:00
7c4451dc73 Bug: fix groups in children scopes being filtered out by grants (#5418)
* add utility functions for grants tests

* use passed in scopeID to create user

* add test for groups list

* groups: set ParentScopeId before FetchActionSetForId

* add comment to TestRoleGrantsForToken

* lint and ran make gen

* fix import groups

* add an additional test case

* remove print

* changelog

* fix(alias): set parent scope id for alias resource (#5434)

set the `ParentScopeId` before fetching authorized actions for alias

* fix(worker): set parent scope id for worker resource (#5435)

set the `ParentScopeId` before fetching authorized actions for worker

* fix(user): children scopes being filtered out by grants for user (#5436)

* fix(user): children scopes being filtered out by grants for user

Resources are being filtered out due to missing ParentScopeId when constructing Resource to pass into authResults.FetchActionSetForId.

* fix(scope): set parent scope id for worker resource (#5439)

set the `ParentScopeId` before fetching authorized actions for worker

* fix(target): set parent scope id for target resource (#5447)

set the `ParentScopeId` before fetching authorized actions for target

* fix(roles): set parent scope id for roles resource (#5452)

* fix(roles): set parent scope id for roles resource

set the `ParentScopeId` before fetching authorized actions for role resource

* test(managed-group): add grants test coverage (#5453)

* fix(managed-group): set parent scope id for managed-group resource

set the ParentScopeId before fetching authorized actions for managed resource

* fix(host): set parent scope id for host resource (#5455)

set the `ParentScopeId` before fetching authorized actions for host resource

* fix(host-set): set parent scope id for host-set resource (#5456)

set the ParentScopeId before fetching authorized actions for host-set resource

* fix(host-catalog): set parent scope id for host-catalog resource (#5457)

set the ParentScopeId before fetching authorized actions for host-catalog resource

* fix(credential-store): set parent scope id for credential-store resource (#5458)

set the ParentScopeId before fetching authorized actions for credential-store resource

* fix(authmethods): set parent scope ID for auth methods resource (#5448)

* handlers/authmethods: fix children permission

* documentation

* formatting

* fix(credential): set parent scope id for credential resource (#5459)

set the `ParentScopeId` before fetching authorized actions for credential resource

* fix(accounts): bug grants filter children accounts (#5431)

* handlers/accounts: fix children grants filtering out results unexpectedly

* make gen

* fix(authtokens): set parent scope ID for auth token resource (#5451)

* fix authtokens not passing children scope ID

* make gen

* fix(credential-libraries): set parent scope ID (#5463)

* fix(common) set parent ID before fetching action setsparent ID before fetching action sets (#5467)

* fix(common) set parent ID before fetching action sets

* make gen

* additional test

* rename test

* more tests

* remove duplicate test

* make gen

* Update CHANGELOG.md

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>

---------

Co-authored-by: Elim Tsiagbey <elim.tsiagbey@hashicorp.com>
Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
2025-01-24 10:23:33 -08:00
Sorawis Nilparuk (Bo) 350ac90a57 implement configurable getDownstreamWorker timeout (#5007)
* implement configurable getDownstreamWorker timeout

* add parsing test

* typos

* fix tests

* fix worker tests

* 0 is a valid value
2024-08-13 14:27:39 -07:00
Sorawis Nilparuk (Bo) 8f457c9c93 make newSendCtx also handle context.DeadlineExceeded (#4603)
* make newSendCtx also handle context.DeadlineExceeded

* add assertion to check that context is valid
2024-04-19 09:23:40 -07:00
Sorawis Nilparuk (Bo) 45eb3b7b51 support remote-dev format for cluster ID (#3637) 2023-11-01 16:41:27 -04:00