I112_Add_support_for_a_different_php_basename #113

ken_fallon · 2023-05-30T07:15:00Z

ken_fallon commented

2023-05-30 07:15:00 +00:00

Changes to allow for the separation of static content from dynamic(php) content.

rho_n commented

2023-05-30 14:55:19 +00:00

I see the reason for the php_baseurl and implementation looks ok.

Although I would replace all the

<!--% absolute_path(php_baseurl) %-->

with

<!--% php_baseurl %-->

The absolute_path macro was more to deal with absolute paths when using the baseurl variable.

So for the Upload links in it should be:

<a href="<!--% php_baseurl %-->calendar.php"><strong>⇧Upload⇧</strong></a>

I see the reason for the php_baseurl and implementation looks ok. Although I would replace all the ```  ``` with ```  ``` The absolute_path macro was more to deal with absolute paths when using the baseurl variable. So for the Upload links in it should be: ``` <a href="calendar.php"><strong>⇧Upload⇧</strong></a> ```

ken_fallon commented

2023-05-30 16:00:31 +00:00

Well spotted. I fixed that.

Sign in to join this conversation.

No reviewers