It is building and functioning locally - I suggest a check on the server would be prudent before merging!
The following changes have been made:
- Updated site-generator
- Removed [DBI] configuration section
- Updated template files to remove un-used field
- Deleted MySQL specific template files.
It is building and functioning locally - I suggest a check on the server would be prudent before merging!
I am ok with removing the mysql specific templates, but I would like to keep the site-generator itself DB agnostic. So a reversion to those changes in the site-generator Perl code is requested.
In general, I view the site-generator.pl code as independent of HPR (so want to keep that code as generic as possible), while the templates are HPR specific.
Hi Paul,
I am ok with removing the mysql specific templates, but I would like to keep the site-generator itself DB agnostic. So a reversion to those changes in the site-generator Perl code is requested.
In general, I view the site-generator.pl code as independent of HPR (so want to keep that code as generic as possible), while the templates are HPR specific.
For all of the PROCESS statements that pull in the "queries-*.tpl.html" templates in the various page templates. These could be changed to just pull in the "queries-*-sqlite.tpl.html" directly. Those *.sqlite.tpl.html query templates could also drop the sqlite in the naming scheme.
For example: queries-episode-sqlite.tpl.html is renamed queries-episode.tpl.html and then the PROCESS statement can change to: <!--% PROCESS 'queries-episode.tpl.html' %-->
For all of the PROCESS statements that pull in the "queries-\*.tpl.html" templates in the various page templates. These could be changed to just pull in the "queries-\*-sqlite.tpl.html" directly. Those *.sqlite.tpl.html query templates could also drop the sqlite in the naming scheme.
For example: _queries-episode-sqlite.tpl.html_ is renamed _queries-episode.tpl.html_ and then the PROCESS statement can change to:
`<!--% PROCESS 'queries-episode.tpl.html' %-->`
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
rho_n
The following changes have been made:
It is building and functioning locally - I suggest a check on the server would be prudent before merging!
Hi Paul,
I am ok with removing the mysql specific templates, but I would like to keep the site-generator itself DB agnostic. So a reversion to those changes in the site-generator Perl code is requested.
In general, I view the site-generator.pl code as independent of HPR (so want to keep that code as generic as possible), while the templates are HPR specific.
@@ -3,17 +3,6 @@# dbi:<driver name [SQLite, CSV, ADO, mSQL, etc.]>:<database name># For more information on Perl Template Toolkit see:# http://template-toolkit.org/docs/manual/index.html[DBI]Per previous request, the DBI section needs to be retained but we can remove any comments about setting up a connection to a mysql db
@@ -2,7 +2,8 @@<!--% PROCESS 'shared-utils.tpl.html' %--><!--% PROCESS 'shared-listen-now.tpl.html' %--><!--% PROCESS "queries-episode-${constants.database}.tpl.html" %-->For all of the PROCESS statements that pull in the "queries-*.tpl.html" templates in the various page templates. These could be changed to just pull in the "queries-*-sqlite.tpl.html" directly. Those *.sqlite.tpl.html query templates could also drop the sqlite in the naming scheme.
For example: queries-episode-sqlite.tpl.html is renamed queries-episode.tpl.html and then the PROCESS statement can change to:
<!--% PROCESS 'queries-episode.tpl.html' %-->c5c5dd89b9to86e1d73085@rho_n - Hopefully I have captured all your points! Thanks for reviewing.
Looks great Paul! Thanks for this PR and your continued interest in helping with the code.