HPR/hpr_hub
8
0
Fork 3
Code Issues 47 Pull Requests 1 Packages Projects Releases Wiki Activity

Upload form fields need changes #94

New Issue
Open
opened 2025-06-22 19:58:13 +00:00 by davmo · 2 comments
davmo commented 2025-06-22 19:58:13 +00:00
Owner
Copy Link

The upload form is presented if the browser does not permit JavaScript.

The part of the form requesting details of the show being uploaded has some layout problems:

  • The "Format" field (which asks for the format of the notes provided later in the form) is placed first in the section. It refers to "show notes above" since it used to follow the "Notes" field.
  • The "Tags" field is difficult to see. The label is centred in relation to the tag entry widget and the text which follows, and the entry widget is difficult to distinguish as a consequence.
  • Ideally all field labels should be aligned to the top of each field to aid readability, but this is probably a matter of opinion.

A screenshot of the relevant part of the form is attached.

The upload form is presented if the browser does not permit JavaScript. The part of the form requesting details of the show being uploaded has some layout problems: - The "Format" field (which asks for the format of the notes provided later in the form) is placed first in the section. It refers to "show notes above" since it used to follow the "Notes" field. - The "Tags" field is difficult to see. The label is centred in relation to the tag entry widget and the text which follows, and the entry widget is difficult to distinguish as a consequence. - Ideally all field labels should be aligned to the top of each field to aid readability, but this is probably a matter of opinion. A screenshot of the relevant part of the form is attached.
Screenshot_2025-06-21_18-48-24.png
112 KiB
Screenshot_2025-06-21_18-48-24.png
rho_n self-assigned this 2025-06-26 02:40:54 +00:00
rho_n commented 2025-06-26 02:57:12 +00:00
Owner
Copy Link

@davmo @ken_fallon I wasn't able to test this running as PHP. I made a copy of the upload.php and renamed it upload.html. I added the <head>...</head> lines from header.html so that I could test the changes to CSS I made to help with the layout problems. I think it resolves Dave's issues. I did test it without javascript and didn't see the issue with the Format field being in the wrong place. I don't know if not running it as PHP would affect the layout and hide the issue.

@davmo @ken_fallon I wasn't able to test this running as PHP. I made a copy of the upload.php and renamed it upload.html. I added the <head>...</head> lines from header.html so that I could test the changes to CSS I made to help with the layout problems. I think it resolves Dave's issues. I did test it without javascript and didn't see the issue with the Format field being in the wrong place. I don't know if not running it as PHP would affect the layout and hide the issue.
rho_n commented 2025-06-26 13:22:00 +00:00
Owner
Copy Link

Here is the PR with the changes I made: #95

Here is the PR with the changes I made: https://repo.anhonesthost.net/HPR/hpr_hub/pulls/95
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
archer72 davmo jknapp ken_fallon norrist paulj rho_n sgoti
No Assignees rho_n
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HPR/hpr_hub#94
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?