HPR/hpr_hub
8
0
Fork 3
Code Issues 48 Pull Requests Packages Projects Releases Wiki Activity

Update hub layout to match the new HPR website #99

Merged
rho_n merged 12 commits from newsite into main 2025-10-18 03:33:13 +00:00
Conversation 3 Commits 12 Files Changed 24 +1134 -231
rho_n commented 2025-10-10 03:15:27 +00:00
Owner
Copy Link

This PR updates the hub layout to match the new HPR look.

It adds a global $referrerurl to use in links back to the HPR website from which they came to the hub site.
It adds a global $generator_name and $generator_email to use in the footer, and make creating other hub instances easier in the future.

It updates some of the 412 pages to match the format of the rest of the site and make them look nicer. Not sure I updated all instances.

Update meta link URL's to use $baseurl and $hubBaseurl to make testing locally and setting up other hub instances easier in the future.

I ran into one CORS issue when referencing external css file. The regular hpr.css file was fine, but threw a CORS issue when trying to load the font files.
I had to add:
Header set Access-Control-Allow-Origin "*"
to my apache conf file for my local instance of the HPR website (after enabling the headers mod) to fix the issue.

This PR updates the hub layout to match the new HPR look. It adds a global $referrerurl to use in links back to the HPR website from which they came to the hub site. It adds a global $generator_name and $generator_email to use in the footer, and make creating other hub instances easier in the future. It updates some of the 412 pages to match the format of the rest of the site and make them look nicer. Not sure I updated all instances. Update meta link URL's to use $baseurl and $hubBaseurl to make testing locally and setting up other hub instances easier in the future. I ran into one CORS issue when referencing external css file. The regular hpr.css file was fine, but threw a CORS issue when trying to load the font files. I had to add: Header set Access-Control-Allow-Origin "*" to my apache conf file for my local instance of the HPR website (after enabling the headers mod) to fix the issue.
rho_n added 10 commits 2025-10-10 03:15:27 +00:00
Rename header.html to header.php 56a876214f
update files to include header.php 2609ee5710
Update files to use $hubBaseurl 4d51954c3c 
Remove hard coded references to hub.hackerpublicradio.org to allow hub to be run on different servers and make testing locally possible.
Update files to use global $referrerurl variable fbac9f923d 
If possible, capture the referring URL to use in links to static website pages. This way when coming from a distributed HPR website and not hackerpublicradio.com, clicking on a page link will return you to the original domain.
Use $baseurl in rss meta link tags 007d9ba738
Add footer to request error response 083d3d3390
Use $baseurl to refer to css location 37f2e01306
Rename footer.html to footer.php 0dc05ed7ee 
The new website design has variable data in the footer based
on its distributed hpr instance.
Update the footer and header to match HPR new website 7ac9582162
Add generator related global variables to credentials.php 7a777a2b64
rho_n requested review from ken_fallon 2025-10-10 03:15:27 +00:00
ken_fallon commented 2025-10-12 16:57:07 +00:00
Owner
Copy Link

The CORS workaround would be a problem, if necessary we can copy the css localy

When do you suggest we merge these ?

The CORS workaround would be a problem, if necessary we can copy the css localy When do you suggest we merge these ?
rho_n commented 2025-10-14 17:49:49 +00:00
Author
Owner
Copy Link

The CORS workaround would be a problem, if necessary we can copy the css localy

I was thinking the easiest way is to just copy the CSS. Does mean we have to keep it synchronized, but shouldn't be that much of an issue.

When do you suggest we merge these ?

I will add the CSS to hub either tonight or tomorrow night. Once that is merged, I am fine to merge both hpr_generator and hpr_hub PRs to main. You can merge the PR for each repository to main. Once we are sure it is all good, we can delete the PRs and the branches.

Thanks for your help and patience with this redesign.

> The CORS workaround would be a problem, if necessary we can copy the css localy > I was thinking the easiest way is to just copy the CSS. Does mean we have to keep it synchronized, but shouldn't be that much of an issue. > When do you suggest we merge these ? I will add the CSS to hub either tonight or tomorrow night. Once that is merged, I am fine to merge both hpr_generator and hpr_hub PRs to main. You can merge the PR for each repository to main. Once we are sure it is all good, we can delete the PRs and the branches. Thanks for your help and patience with this redesign.
ken_fallon commented 2025-10-14 18:52:39 +00:00
Owner
Copy Link

Go for it.

Go for it.
ken_fallon added 1 commit 2025-10-14 18:53:18 +00:00
Merge branch 'main' into newsite d26809200a
rho_n added 1 commit 2025-10-17 03:45:09 +00:00
Load HPR CSS locally 2bef78a367 
To prevent triggering CORS serve CSS and fonts from same domain.
rho_n merged commit cfe29eb0e2 into main 2025-10-18 03:33:13 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
ken_fallon
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
archer72 davmo jknapp ken_fallon norrist paulj rho_n sgoti
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HPR/hpr_hub#99
No description provided.
Delete Branch "newsite"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?