MacroPad/MP-Server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

fix: drop netifaces (unbuildable), harden build install #9

Merged
jknapp merged 1 commits from fix/netifaces-build into main 2026-07-18 05:40:51 +00:00
Conversation 0 Commits 1 Files Changed 7
+42 -16
jknapp commented 2026-07-18 05:40:49 +00:00
Owner
Copy Link
Copy Source

Fixes the ModuleNotFoundError: PySide6 crash in the packaged exe. netifaces broke pip install -e . (no wheel, needs MSVC); replaced with socket-based LAN IP detection and made pip failures fatal + added a runtime-import smoke check.

Fixes the ModuleNotFoundError: PySide6 crash in the packaged exe. netifaces broke `pip install -e .` (no wheel, needs MSVC); replaced with socket-based LAN IP detection and made pip failures fatal + added a runtime-import smoke check.
jknapp added 1 commit 2026-07-18 05:40:50 +00:00
fix: drop netifaces (unbuildable on runner), harden build install 2f855bf720 
The packaged exe crashed with ModuleNotFoundError: No module named 'PySide6'.
Root cause: `pip install -e .` aborted because netifaces has no wheel for the
build's Python and needs MSVC to compile from source, so NO dependencies were
installed — and the workflow didn't catch it (native-command failures don't
trip $ErrorActionPreference, and the next pip command succeeded).

- Replace netifaces with a dependency-free socket-based LAN IP detection in the
  GUI; remove netifaces from pyproject and all PyInstaller specs.
- Make pip failures fatal (check $LASTEXITCODE) and add a "Verify runtime
  imports" step that fails the build before bundling if any dep is missing.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jknapp merged commit d409b64efa into main 2026-07-18 05:40:51 +00:00
jknapp deleted branch fix/netifaces-build 2026-07-18 05:40:51 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jknapp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MacroPad/MP-Server#9
Delete Branch "fix/netifaces-build"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?