fix(entrypoint): graceful docker stop + cac-fpm error_log owner on first start
Graceful stop (cac, cac-fpm, shared-httpd, and form-sender which runs cac): entrypoint.sh, entrypoint-fpm.sh and entrypoint-shared-httpd.sh end with bash as PID 1 tailing logs. PID 1 only receives signals it has a handler for, so docker stop's SIGTERM was dropped; docker waited the full 10s and SIGKILLed apache / php-fpm mid-request (exit 137). The entrypoints now trap TERM/INT and stop each daemon they started via the new scripts/stop-services.sh: httpd graceful-stop (WINCH), php-fpm QUIT, crond TERM, each with a bounded wait and a TERM/KILL fallback, budgets summing to < 10s, then exit 0. The log tail is backgrounded + `wait`ed (and shared-httpd's 60s rescan sleep likewise) so the trap runs immediately. Log streaming to docker logs is unchanged. cac-fpm error_log: entrypoint-fpm.sh `touch`ed logs/php-fpm/error.log as root AFTER its chown -R, so on a site's first start the pool (customer uid) could not open it and PHP errors went out as FastCGI stderr to shared-httpd's log until the next restart. The file is now created and chowned to the customer right after the logs dir is made, before php-fpm starts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
14761597bb
commit
eaf616eb30
5 files changed
+137
-8
No files matched your search
@@ -16,6 +16,14 @@ adduser -u $uid $user
|
||||
|
||||
mkdir -p /home/$user/public_html
|
||||
mkdir -p /home/$user/logs/php-fpm
|
||||
# Create the pool's error_log (php_admin_value[error_log] in
|
||||
# create-php-config.sh) BEFORE the chown -R below, and chown it explicitly.
|
||||
# It used to be `touch`ed as root at the very end, after the chown, so on a
|
||||
# site's first start the pool (customer uid) could not open it and PHP errors
|
||||
# fell back to FastCGI stderr -> shared-httpd's error log until the next
|
||||
# restart's chown -R fixed the owner.
|
||||
touch /home/$user/logs/php-fpm/error.log
|
||||
chown $user:$user /home/$user/logs/php-fpm/error.log
|
||||
|
||||
ln -sf /home/$user/logs/php-fpm /var/log/php-fpm
|
||||
|
||||
@@ -89,8 +97,26 @@ crontab -u $user /home/$user/crontab
|
||||
|
||||
/usr/sbin/crond
|
||||
|
||||
# Tail PHP-FPM logs (becomes PID 1 process)
|
||||
touch /home/$user/logs/php-fpm/error.log
|
||||
tail -f /home/$user/logs/php-fpm/*
|
||||
# Graceful shutdown. bash is PID 1 here, and PID 1 only receives signals it
|
||||
# has a handler for, so without this trap `docker stop`'s SIGTERM was dropped:
|
||||
# docker waited the full 10s and SIGKILLed php-fpm mid-request (exit 137).
|
||||
# php-fpm QUIT = graceful (workers finish their current request), then crond.
|
||||
source /scripts/stop-services.sh
|
||||
TAIL_PID=""
|
||||
shutdown() {
|
||||
trap - TERM INT
|
||||
echo "entrypoint: received stop signal, shutting down"
|
||||
stop_service php-fpm /run/php-fpm/php-fpm.pid QUIT 6 'php-fpm: master'
|
||||
stop_service crond /run/crond.pid TERM 1 '^/usr/sbin/crond'
|
||||
[ -n "$TAIL_PID" ] && kill "$TAIL_PID" 2>/dev/null
|
||||
exit 0
|
||||
}
|
||||
trap shutdown TERM INT
|
||||
|
||||
# Tail PHP-FPM logs to docker logs. Backgrounded + `wait` (instead of a
|
||||
# foreground tail) so bash can run the trap as soon as a signal arrives.
|
||||
tail -f /home/$user/logs/php-fpm/* &
|
||||
TAIL_PID=$!
|
||||
wait "$TAIL_PID"
|
||||
|
||||
exit 0
|
||||
Reference in new issue
Block a user