tests: fix SC2034 + pipefail hazard in lsphp-src-upload-progress test #47

Merged
jknapp merged 1 commits from fix/shellcheck-upload-progress-test into trunk 2026-11-19 20:13:38 +00:00
Owner

Fixes the red Shell-Checks job on trunk (added by PR #42).

  • SC2034 in scripts/tests/lsphp-src-upload-progress.test.sh: SRC is only consumed inside an eval'd sed line, so it is now exported.
  • lsphp-info-probe.test.sh "1 failed" was REAL, not stale: its structural scan correctly flagged grep | grep | head -n1 (early-exit reader under pipefail, SIGPIPE hazard) at line 18 of the same upload-progress test. It has failed since that test file was added. Replaced with a plain read loop. The probe script and the probe test are untouched.

Local results: shellcheck -S warning on the workflow's exact file list is clean; bash -n on all scripts OK; lsphp-info-probe 36 passed / 0 failed; all scripts/tests/*.test.sh pass except lsphp-abi-gate (needs pahole/gcc, skipped locally, unrelated).

Merge with [skip ci] if a trunk build is in progress: push to trunk triggers build-push for every leg.

🤖 Generated with Claude Code

https://claude.ai/code/session_0185ukXi4YX5FxJGqhi6qab6

Fixes the red Shell-Checks job on trunk (added by PR #42). - SC2034 in scripts/tests/lsphp-src-upload-progress.test.sh: `SRC` is only consumed inside an `eval`'d sed line, so it is now exported. - lsphp-info-probe.test.sh "1 failed" was REAL, not stale: its structural scan correctly flagged `grep | grep | head -n1` (early-exit reader under pipefail, SIGPIPE hazard) at line 18 of the same upload-progress test. It has failed since that test file was added. Replaced with a plain read loop. The probe script and the probe test are untouched. Local results: shellcheck -S warning on the workflow's exact file list is clean; bash -n on all scripts OK; lsphp-info-probe 36 passed / 0 failed; all scripts/tests/*.test.sh pass except lsphp-abi-gate (needs pahole/gcc, skipped locally, unrelated). Merge with `[skip ci]` if a trunk build is in progress: push to trunk triggers build-push for every leg. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0185ukXi4YX5FxJGqhi6qab6
jknapp added 1 commit 2026-11-19 20:01:14 +00:00
Shell-Checks failed on SC2034 (SRC only used inside eval), and the
lsphp-info-probe structural scan flagged the grep|grep|head pipeline
(pipefail SIGPIPE hazard) in the same new test. Replace with a read loop;
export SRC. No product script changes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0185ukXi4YX5FxJGqhi6qab6
jknapp merged commit 935b02eae4 into trunk 2026-11-19 20:13:38 +00:00
jknapp deleted branch fix/shellcheck-upload-progress-test 2026-11-19 20:13:38 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cloud-hosting-platform/cloud-apache-container#47