script nits: slider hover/visibility pause + silent autoplay + iframe amp guard
ContentSlider: autoplay's setInterval now pauses on mouseenter and on document visibilitychange (tab hidden), resumes on mouseleave/visible, and is always clearable (timer var + clearInterval). The aria-live region is "off" while autoplay is silently auto-rotating and only flips to "polite" on manual next/prev/dot navigation, so screen readers aren't spammed with an announcement every `interval` ms (F-export review Minor). Updates the one existing test that hard-coded aria-live="polite" as always-on to match this intentional behavior change. (Countdown's ticking-interval-stops-at-zero nit shipped in the previous commit alongside its node-id migration, since both touched the same inline script.) Adds regression tests locking in that MapEmbed/VideoBlock iframe src attributes (built by string concatenation with literal `&` query params) are HTML-entity-encoded via the existing escapeAttr(safeUrl()) pipeline -- verified already correct, no source change needed there. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -14,3 +14,16 @@ describe('MapEmbed.toHtml iframe accessibility (F2.4)', () => {
|
||||
expect(html).toContain('title="Map of Golden Gate Bridge"');
|
||||
});
|
||||
});
|
||||
|
||||
describe('MapEmbed.toHtml iframe src ampersand encoding (F-export review Minor)', () => {
|
||||
test('the iframe src (built by string concatenation with literal &) emits & in the attribute, not a raw &', () => {
|
||||
const { html } = toHtml({ address: 'New York, NY', zoom: 14 }, '');
|
||||
const srcMatch = html.match(/<iframe src="([^"]+)"/);
|
||||
expect(srcMatch).toBeTruthy();
|
||||
// The raw src is `...q=...&z=14&output=embed` -- concatenated with
|
||||
// literal `&`s -- so the emitted attribute must HTML-encode them.
|
||||
expect(srcMatch![1]).toContain('&z=14');
|
||||
expect(srcMatch![1]).toContain('&output=embed');
|
||||
expect(srcMatch![1]).not.toMatch(/&(?!amp;)/);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user