script nits: slider hover/visibility pause + silent autoplay + iframe amp guard
ContentSlider: autoplay's setInterval now pauses on mouseenter and on document visibilitychange (tab hidden), resumes on mouseleave/visible, and is always clearable (timer var + clearInterval). The aria-live region is "off" while autoplay is silently auto-rotating and only flips to "polite" on manual next/prev/dot navigation, so screen readers aren't spammed with an announcement every `interval` ms (F-export review Minor). Updates the one existing test that hard-coded aria-live="polite" as always-on to match this intentional behavior change. (Countdown's ticking-interval-stops-at-zero nit shipped in the previous commit alongside its node-id migration, since both touched the same inline script.) Adds regression tests locking in that MapEmbed/VideoBlock iframe src attributes (built by string concatenation with literal `&` query params) are HTML-entity-encoded via the existing escapeAttr(safeUrl()) pipeline -- verified already correct, no source change needed there. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -71,3 +71,18 @@ describe('VideoBlock.toHtml iframe accessibility (F2.4)', () => {
|
||||
expect(html).toMatch(/<iframe[^>]*title="[^"]+"/);
|
||||
});
|
||||
});
|
||||
|
||||
describe('VideoBlock.toHtml iframe src ampersand encoding (F-export review Minor)', () => {
|
||||
test('embed params joined with literal & are HTML-entity-encoded in the emitted src attribute', () => {
|
||||
// autoplay+muted+controls=false forces buildEmbedParams to concatenate
|
||||
// multiple query params onto the URL with literal `&`s.
|
||||
const { html } = toHtml(
|
||||
{ videoUrl: 'https://www.youtube.com/watch?v=dQw4w9WgXcQ', autoplay: true, muted: true, controls: false },
|
||||
''
|
||||
);
|
||||
const srcMatch = html.match(/<iframe src="([^"]+)"/);
|
||||
expect(srcMatch).toBeTruthy();
|
||||
expect(srcMatch![1]).toMatch(/&/);
|
||||
expect(srcMatch![1]).not.toMatch(/&(?!amp;)/);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user