cloud-hosting-platform/site-builder
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sitesmith: strip diagnostic shim + state-dump now that the fix is verified

Browse Source 
Apply path is stable end-to-end with the linkedNode pre-creation patch;
diagnostic shim + window.__sitesmithLastState dump are no longer earning
their footprint. Reverts:
  - vite.config.ts: drops the tiny-invariant alias
  - src/utils/tiny-invariant-shim.ts: deleted
  - PageContext.tsx: removes the post-walk dump/scan block
This commit is contained in:
Josh Knapp
2026-05-24 17:32:38 -07:00
parent 87dd4340f7
commit 5e60415311
3 changed files with 0 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
craft/src/state/PageContext.tsx
View File

@@ -383,25 +383,6 @@ export const PageProvider: React.FC<{ children: ReactNode }> = ({ children }) =>
return id;
};
const rootId = walk(tree, null);
// DIAGNOSTIC: dump the produced state + scan for type=undefined nodes
// so when the resolver invariant fires we can see which node is bad.
try {
const w = window as any;
w.__sitesmithLastTree = tree;
w.__sitesmithLastState = nodes;
const bad: Array<{id:string; node:any}> = [];
for (const [nid, n] of Object.entries(nodes)) {
const t = (n as any).type;
const name = t && typeof t === 'object' ? t.resolvedName : t;
if (!name) bad.push({ id: nid, node: n });
}
if (bad.length > 0) {
// eslint-disable-next-line no-console
console.warn('[SITESMITH] nodes with undefined type:', bad);
}
// eslint-disable-next-line no-console
console.log('[SITESMITH] treeToState produced', Object.keys(nodes).length, 'nodes; rootId=', rootId);
} catch (_e) { /* diagnostic only */ }
// Craft.js deserialize requires the root node keyed as 'ROOT'
if (rootId !== 'ROOT') {
nodes['ROOT'] = nodes[rootId];

28
craft/src/utils/tiny-invariant-shim.ts
View File

@@ -1,28 +0,0 @@
/**
* Diagnostic shim for tiny-invariant. The prod tiny-invariant strips
* the failure message, so we lose the actual reason for any Craft.js
* Invariant. Aliasing tiny-invariant -> this shim restores it.
*/
/**
* Some Craft.js invariants are used as control-flow (try/catch wraps them
* to test a condition without explicit branching). Logging every one would
* drown out the actually-interesting failures. Suppress the well-known
* "is-it-X check" messages and log only the unfamiliar ones.
*/
const BENIGN = new Set<string>([
'A top-level Node cannot be moved',
'Cannot drag a non-canvas Node onto another Node',
]);
export default function invariant(condition: unknown, message?: string | (() => string)): asserts condition {
if (condition) return;
const provided = typeof message === 'function' ? message() : message;
const value = provided ? `Invariant failed: ${provided}` : 'Invariant failed';
if (!provided || !BENIGN.has(String(provided))) {
// eslint-disable-next-line no-console
console.error('[CRAFT INVARIANT]', value);
// eslint-disable-next-line no-console
console.error(new Error('stack-only').stack);
}
throw new Error(value);
}

3
craft/vite.config.ts
View File

@@ -8,9 +8,6 @@ export default defineConfig({
resolve: {
alias: {
'@': path.resolve(__dirname, './src'),
// Diagnostic: replace tiny-invariant with a shim that always logs the
// failure message (the upstream prod build strips it).
'tiny-invariant': path.resolve(__dirname, './src/utils/tiny-invariant-shim.ts'),
},
},
build: {