feat(builder): items 10+12+13 — scope canvas guides, Show Guides toggle, Layers panel hover/icons, topbar unification
Item 10: dashed canvas "guide" outlines were applied via blanket tag
selectors (div/section/header/...), so a finished section showed 3-4
nested dashed boxes. RenderNode.tsx (the <Editor onRender> override) now
tags each Craft.js droppable container's real DOM node with a
`data-craft-node` attribute (node.data.isCanvas, excluding ROOT), and
editor.css's guide rules target that attribute instead — a component's own
internal wrapper markup is no longer mistaken for a drop target. Added a
"Show guides" topbar toggle (default ON, persisted to localStorage),
state lifted in EditorShell.tsx (mirrors how `device` is already lifted),
flips `.guides-off` on Canvas.tsx's `.canvas-device-frame`.
Item 12: Layers panel rows get per-type FA icons (keyed off the same
craft.displayName used for the row label, seeded from BlocksPanel's
choices), indent-guide lines connecting nested rows, and row hover
highlights the matching canvas element (`data-layer-hovered`, written
directly to the node's DOM via `query.node(id).get().dom` — NOT via
`actions.setNodeEvent`, which is stripped from useEditor()'s public
`actions` at runtime, not just in its TS type, and threw when called).
Along the way, Craft.js's own connect() was found to already wire mouse
hover to the same `hovered` node event internally (previously invisible
because the matching CSS was dead) — RenderNode now also mirrors that
onto `data-craft-hovered` for a real-mouse-hover canvas highlight, and
both hover attributes plus the guide attribute are suppressed under
`.guides-off` so the toggle stays airtight.
Item 13: unified the topbar to one button radius (`.topbar-btn` 20px pill
-> var(--radius-md)), demoted Code/Preview to icon-only with
`data-tooltip`. Fixed a latent bug the new tooltips exposed: `[data-tooltip]`
tooltips render above their trigger, but the topbar has no room above it
(`body { overflow: hidden }`) — added a `.topbar` override to render
those below instead.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -8,6 +8,8 @@ import { exportBodyHtml } from '../utils/html-export';
|
|||||||
|
|
||||||
interface CanvasProps {
|
interface CanvasProps {
|
||||||
device: DeviceMode;
|
device: DeviceMode;
|
||||||
|
/** Item 10: when false, applies `.guides-off` to hide the dashed drop-target guides. */
|
||||||
|
showGuides: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -120,7 +122,7 @@ export const EmptyCanvasHint: React.FC = () => {
|
|||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
export const Canvas: React.FC<CanvasProps> = ({ device }) => {
|
export const Canvas: React.FC<CanvasProps> = ({ device, showGuides }) => {
|
||||||
const width = DEVICE_WIDTHS[device];
|
const width = DEVICE_WIDTHS[device];
|
||||||
const { isEditingHeader, isEditingFooter, headerPage, footerPage } = usePages();
|
const { isEditingHeader, isEditingFooter, headerPage, footerPage } = usePages();
|
||||||
|
|
||||||
@@ -137,7 +139,7 @@ export const Canvas: React.FC<CanvasProps> = ({ device }) => {
|
|||||||
return (
|
return (
|
||||||
<div className="editor-canvas">
|
<div className="editor-canvas">
|
||||||
<div
|
<div
|
||||||
className="canvas-device-frame"
|
className={`canvas-device-frame${showGuides ? '' : ' guides-off'}`}
|
||||||
style={{
|
style={{
|
||||||
width,
|
width,
|
||||||
maxWidth: '100%',
|
maxWidth: '100%',
|
||||||
|
|||||||
@@ -9,8 +9,34 @@ import { useContextMenu } from '../hooks/useContextMenu';
|
|||||||
import { useKeyboardShortcuts } from '../hooks/useKeyboardShortcuts';
|
import { useKeyboardShortcuts } from '../hooks/useKeyboardShortcuts';
|
||||||
import { DeviceMode } from '../types';
|
import { DeviceMode } from '../types';
|
||||||
|
|
||||||
|
const SHOW_GUIDES_STORAGE_KEY = 'craft-show-guides';
|
||||||
|
|
||||||
|
function loadShowGuides(): boolean {
|
||||||
|
try {
|
||||||
|
const stored = window.localStorage.getItem(SHOW_GUIDES_STORAGE_KEY);
|
||||||
|
return stored === null ? true : stored === '1';
|
||||||
|
} catch {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
export const EditorShell: React.FC = () => {
|
export const EditorShell: React.FC = () => {
|
||||||
const [device, setDevice] = useState<DeviceMode>('desktop');
|
const [device, setDevice] = useState<DeviceMode>('desktop');
|
||||||
|
// Item 10: canvas dashed "guide" outlines toggle -- default ON, persisted
|
||||||
|
// so the choice survives a reload. Lifted here (rather than owned by
|
||||||
|
// TopBar or Canvas alone) because the toggle button lives in TopBar but
|
||||||
|
// the `.guides-off` class it drives is applied to Canvas's
|
||||||
|
// `.canvas-device-frame`, mirroring how `device` is already lifted for
|
||||||
|
// the same reason.
|
||||||
|
const [showGuides, setShowGuidesState] = useState<boolean>(loadShowGuides);
|
||||||
|
const setShowGuides = useCallback((next: boolean) => {
|
||||||
|
setShowGuidesState(next);
|
||||||
|
try {
|
||||||
|
window.localStorage.setItem(SHOW_GUIDES_STORAGE_KEY, next ? '1' : '0');
|
||||||
|
} catch {
|
||||||
|
// Storage unavailable (private browsing, etc.) -- in-memory state still works.
|
||||||
|
}
|
||||||
|
}, []);
|
||||||
const { menuState, show: showMenu, hide: hideMenu } = useContextMenu();
|
const { menuState, show: showMenu, hide: hideMenu } = useContextMenu();
|
||||||
const { query } = useEditor();
|
const { query } = useEditor();
|
||||||
|
|
||||||
@@ -34,11 +60,16 @@ export const EditorShell: React.FC = () => {
|
|||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="editor-app">
|
<div className="editor-app">
|
||||||
<TopBar device={device} onDeviceChange={setDevice} />
|
<TopBar
|
||||||
|
device={device}
|
||||||
|
onDeviceChange={setDevice}
|
||||||
|
showGuides={showGuides}
|
||||||
|
onToggleGuides={() => setShowGuides(!showGuides)}
|
||||||
|
/>
|
||||||
<div className="editor-container">
|
<div className="editor-container">
|
||||||
<LeftPanel />
|
<LeftPanel />
|
||||||
<div onContextMenu={handleContextMenu} style={{ flex: 1, display: 'flex', minWidth: 0 }}>
|
<div onContextMenu={handleContextMenu} style={{ flex: 1, display: 'flex', minWidth: 0 }}>
|
||||||
<Canvas device={device} />
|
<Canvas device={device} showGuides={showGuides} />
|
||||||
</div>
|
</div>
|
||||||
<RightPanel />
|
<RightPanel />
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -10,9 +10,11 @@ import { act } from 'react-dom/test-utils';
|
|||||||
let mockNode: {
|
let mockNode: {
|
||||||
id: string;
|
id: string;
|
||||||
selected: boolean;
|
selected: boolean;
|
||||||
|
hovered: boolean;
|
||||||
dom: HTMLElement | null;
|
dom: HTMLElement | null;
|
||||||
displayName: string;
|
displayName: string;
|
||||||
parent: string | null;
|
parent: string | null;
|
||||||
|
isCanvas: boolean;
|
||||||
};
|
};
|
||||||
const selectNodeSpy = vi.fn();
|
const selectNodeSpy = vi.fn();
|
||||||
|
|
||||||
@@ -20,9 +22,14 @@ vi.mock('@craftjs/core', () => ({
|
|||||||
useEditor: () => ({ actions: { selectNode: selectNodeSpy } }),
|
useEditor: () => ({ actions: { selectNode: selectNodeSpy } }),
|
||||||
useNode: (collect?: (node: any) => any) => {
|
useNode: (collect?: (node: any) => any) => {
|
||||||
const node = {
|
const node = {
|
||||||
events: { selected: mockNode.selected },
|
events: { selected: mockNode.selected, hovered: mockNode.hovered },
|
||||||
dom: mockNode.dom,
|
dom: mockNode.dom,
|
||||||
data: { custom: {}, displayName: mockNode.displayName, parent: mockNode.parent },
|
data: {
|
||||||
|
custom: {},
|
||||||
|
displayName: mockNode.displayName,
|
||||||
|
parent: mockNode.parent,
|
||||||
|
isCanvas: mockNode.isCanvas,
|
||||||
|
},
|
||||||
};
|
};
|
||||||
return { id: mockNode.id, ...(collect ? collect(node) : {}) };
|
return { id: mockNode.id, ...(collect ? collect(node) : {}) };
|
||||||
},
|
},
|
||||||
@@ -46,7 +53,15 @@ function render(ui: React.ReactElement) {
|
|||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
nodeDom = document.createElement('div');
|
nodeDom = document.createElement('div');
|
||||||
document.body.appendChild(nodeDom);
|
document.body.appendChild(nodeDom);
|
||||||
mockNode = { id: 'node-1', selected: false, dom: nodeDom, displayName: 'Heading', parent: 'ROOT' };
|
mockNode = {
|
||||||
|
id: 'node-1',
|
||||||
|
selected: false,
|
||||||
|
hovered: false,
|
||||||
|
dom: nodeDom,
|
||||||
|
displayName: 'Heading',
|
||||||
|
parent: 'ROOT',
|
||||||
|
isCanvas: false,
|
||||||
|
};
|
||||||
selectNodeSpy.mockClear();
|
selectNodeSpy.mockClear();
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -105,4 +120,50 @@ describe('RenderNode (Editor onRender override)', () => {
|
|||||||
nodeDom.remove();
|
nodeDom.remove();
|
||||||
document.querySelector('.component-indicator')?.remove();
|
document.querySelector('.component-indicator')?.remove();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('tags a droppable (isCanvas) node dom with data-craft-node', () => {
|
||||||
|
mockNode.isCanvas = true;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-node')).toBe(true);
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('does not tag a non-canvas (leaf) node dom with data-craft-node', () => {
|
||||||
|
mockNode.isCanvas = false;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-node')).toBe(false);
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('never tags ROOT with data-craft-node even though ROOT is a canvas', () => {
|
||||||
|
mockNode.id = 'ROOT';
|
||||||
|
mockNode.isCanvas = true;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-node')).toBe(false);
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('tags the dom with data-craft-hovered when the Craft hovered event is set (Layers panel hover sync)', () => {
|
||||||
|
mockNode.hovered = true;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-hovered')).toBe(true);
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('removes data-craft-hovered once the hovered event clears', () => {
|
||||||
|
mockNode.hovered = true;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-hovered')).toBe(true);
|
||||||
|
mockNode.hovered = false;
|
||||||
|
act(() => {
|
||||||
|
root.render(<RenderNode render={rendered} />);
|
||||||
|
});
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-hovered')).toBe(false);
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -14,14 +14,36 @@ interface RenderNodeProps {
|
|||||||
* straight through as a Fragment, so this never touches layout, never
|
* straight through as a Fragment, so this never touches layout, never
|
||||||
* appears in `toHtml` export (that walks the Craft node tree, not this
|
* appears in `toHtml` export (that walks the Craft node tree, not this
|
||||||
* portal), and doesn't wrap every node in extra DOM.
|
* portal), and doesn't wrap every node in extra DOM.
|
||||||
|
*
|
||||||
|
* It also imperatively tags each node's real DOM element with two
|
||||||
|
* editor-only data attributes (never part of `toHtml` export, which walks
|
||||||
|
* the Craft node tree, not the live DOM):
|
||||||
|
* - `data-craft-node`: set on actual Craft.js droppable containers
|
||||||
|
* (`node.data.isCanvas`, excluding ROOT). `editor.css`'s dashed "guide"
|
||||||
|
* outlines target this attribute instead of blanket tag selectors
|
||||||
|
* (div/section/header/...), so a component's own internal wrapper markup
|
||||||
|
* no longer picks up a guide outline it isn't a real drop target for.
|
||||||
|
* - `data-craft-hovered`: mirrors `node.events.hovered` (Craft's hover
|
||||||
|
* event set). Craft's own `connectors.connect()` (called by every
|
||||||
|
* component) wires a native mouseover/mouseleave listener to this event
|
||||||
|
* internally, so a plain mouse hover over any connected node sets it --
|
||||||
|
* this attribute is a real-mouse-hover canvas highlight. (The Layers
|
||||||
|
* panel's row-hover -> canvas-highlight sync, item 12, uses a sibling
|
||||||
|
* `data-layer-hovered` attribute written directly by LayersPanel.tsx
|
||||||
|
* instead of this event, since the action that would drive it here
|
||||||
|
* -- `actions.setNodeEvent` -- is stripped from the public `useEditor()`
|
||||||
|
* API at runtime.) editor.css matches both attributes for the same
|
||||||
|
* outline and suppresses both under `.guides-off`.
|
||||||
*/
|
*/
|
||||||
export const RenderNode: React.FC<RenderNodeProps> = ({ render }) => {
|
export const RenderNode: React.FC<RenderNodeProps> = ({ render }) => {
|
||||||
const { actions } = useEditor();
|
const { actions } = useEditor();
|
||||||
const { id, isSelected, dom, name, parent } = useNode((node) => ({
|
const { id, isSelected, dom, name, parent, isCanvas, isHovered } = useNode((node) => ({
|
||||||
isSelected: node.events.selected,
|
isSelected: node.events.selected,
|
||||||
|
isHovered: node.events.hovered,
|
||||||
dom: node.dom,
|
dom: node.dom,
|
||||||
name: (node.data.props?.aiName as string) || node.data.displayName,
|
name: (node.data.props?.aiName as string) || node.data.displayName,
|
||||||
parent: node.data.parent,
|
parent: node.data.parent,
|
||||||
|
isCanvas: node.data.isCanvas,
|
||||||
}));
|
}));
|
||||||
|
|
||||||
const badgeRef = useRef<HTMLDivElement>(null);
|
const badgeRef = useRef<HTMLDivElement>(null);
|
||||||
@@ -46,6 +68,24 @@ export const RenderNode: React.FC<RenderNodeProps> = ({ render }) => {
|
|||||||
};
|
};
|
||||||
}, [active, updatePosition]);
|
}, [active, updatePosition]);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!dom) return;
|
||||||
|
if (isCanvas && id !== 'ROOT') {
|
||||||
|
dom.setAttribute('data-craft-node', '');
|
||||||
|
} else {
|
||||||
|
dom.removeAttribute('data-craft-node');
|
||||||
|
}
|
||||||
|
}, [dom, isCanvas, id]);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!dom) return;
|
||||||
|
if (isHovered) {
|
||||||
|
dom.setAttribute('data-craft-hovered', '');
|
||||||
|
} else {
|
||||||
|
dom.removeAttribute('data-craft-hovered');
|
||||||
|
}
|
||||||
|
}, [dom, isHovered]);
|
||||||
|
|
||||||
if (!active) return <>{render}</>;
|
if (!active) return <>{render}</>;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
|
|||||||
@@ -1,14 +1,74 @@
|
|||||||
import React, { useCallback } from 'react';
|
import React, { useCallback, useEffect, useRef } from 'react';
|
||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import { clickableProps } from '../../utils/a11y';
|
import { clickableProps } from '../../utils/a11y';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Per-type icon lookup keyed by the component's `craft.displayName` (the
|
||||||
|
* same human label `LayerNode` already resolves and shows as the row text).
|
||||||
|
* Mirrors the icon choices in `BlocksPanel.tsx` where a block exists for the
|
||||||
|
* type; the remaining entries (Navbar, Container, Section, Columns,
|
||||||
|
* Background Section, Map, Video, Image, form fields, and the richer
|
||||||
|
* section blocks not draggable from the Basic/Sections categories) get a
|
||||||
|
* sensible FA4 icon of their own. Unknown/future types fall back to
|
||||||
|
* `DEFAULT_ICON`.
|
||||||
|
*/
|
||||||
|
const TYPE_ICONS: Record<string, string> = {
|
||||||
|
// Layout
|
||||||
|
Container: 'fa-square-o',
|
||||||
|
Section: 'fa-window-maximize',
|
||||||
|
Columns: 'fa-th-large',
|
||||||
|
'Background Section': 'fa-picture-o',
|
||||||
|
// Basic
|
||||||
|
Heading: 'fa-header',
|
||||||
|
Text: 'fa-paragraph',
|
||||||
|
Button: 'fa-square',
|
||||||
|
Logo: 'fa-bookmark',
|
||||||
|
Menu: 'fa-bars',
|
||||||
|
Navbar: 'fa-bars',
|
||||||
|
Footer: 'fa-window-minimize',
|
||||||
|
Divider: 'fa-minus',
|
||||||
|
Spacer: 'fa-arrows-v',
|
||||||
|
Icon: 'fa-star',
|
||||||
|
'Star Rating': 'fa-star-half-o',
|
||||||
|
'Social Links': 'fa-share-alt',
|
||||||
|
'Search Bar': 'fa-search',
|
||||||
|
HTML: 'fa-code',
|
||||||
|
// Media
|
||||||
|
Image: 'fa-image',
|
||||||
|
Video: 'fa-play-circle',
|
||||||
|
Map: 'fa-map-marker',
|
||||||
|
// Sections
|
||||||
|
Hero: 'fa-star-o',
|
||||||
|
'Features Grid': 'fa-th-large',
|
||||||
|
'CTA Section': 'fa-bullhorn',
|
||||||
|
'Call to Action': 'fa-bullhorn',
|
||||||
|
Countdown: 'fa-clock-o',
|
||||||
|
Testimonials: 'fa-quote-left',
|
||||||
|
'Content Slider': 'fa-sliders',
|
||||||
|
'Number Counter': 'fa-sort-numeric-asc',
|
||||||
|
Accordion: 'fa-list',
|
||||||
|
Tabs: 'fa-folder-o',
|
||||||
|
'Pricing Table': 'fa-usd',
|
||||||
|
Gallery: 'fa-th',
|
||||||
|
// Forms
|
||||||
|
Form: 'fa-wpforms',
|
||||||
|
Input: 'fa-i-cursor',
|
||||||
|
Textarea: 'fa-align-left',
|
||||||
|
'Submit Button': 'fa-paper-plane',
|
||||||
|
'Contact Form': 'fa-envelope',
|
||||||
|
'Subscribe Form': 'fa-paper-plane',
|
||||||
|
};
|
||||||
|
|
||||||
|
const DEFAULT_ICON = 'fa-cube';
|
||||||
|
const ROOT_ICON = 'fa-desktop';
|
||||||
|
|
||||||
interface LayerNodeProps {
|
interface LayerNodeProps {
|
||||||
nodeId: string;
|
nodeId: string;
|
||||||
depth: number;
|
depth: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
||||||
const { node, selectedId, actions } = useEditor((state) => {
|
const { node, selectedId, actions, query } = useEditor((state) => {
|
||||||
const n = state.nodes[nodeId];
|
const n = state.nodes[nodeId];
|
||||||
const selectedIds = state.events.selected;
|
const selectedIds = state.events.selected;
|
||||||
const selId = selectedIds ? Array.from(selectedIds)[0] : null;
|
const selId = selectedIds ? Array.from(selectedIds)[0] : null;
|
||||||
@@ -18,28 +78,76 @@ const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
|||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const isSelected = selectedId === nodeId;
|
||||||
|
|
||||||
const handleActivate = useCallback(() => {
|
const handleActivate = useCallback(() => {
|
||||||
actions.selectNode(nodeId);
|
actions.selectNode(nodeId);
|
||||||
}, [actions, nodeId]);
|
}, [actions, nodeId]);
|
||||||
|
|
||||||
|
// Layers-panel <-> canvas hover sync (Item 12): tags the target node's own
|
||||||
|
// DOM element (found via `query`) with `data-layer-hovered` directly.
|
||||||
|
// `RenderNode.tsx` mirrors Craft's *own* `hovered` node event onto
|
||||||
|
// `data-craft-hovered` for the (separate, mouse-driven) canvas hover
|
||||||
|
// outline -- editor.css's rule matches both attributes. This panel can't
|
||||||
|
// reuse that path: `setNodeEvent` is a private action that `useEditor()`
|
||||||
|
// strips from its `actions` return at runtime (see
|
||||||
|
// @craftjs/core/dist/esm's `xe()` action stripper, not just its TypeScript
|
||||||
|
// type), so calling it here throws. Writing our own attribute directly is
|
||||||
|
// a supported, version-stable way to get the same highlight.
|
||||||
|
const hoveredDomRef = useRef<HTMLElement | null>(null);
|
||||||
|
|
||||||
|
const handleMouseEnter = useCallback(
|
||||||
|
(e: React.MouseEvent<HTMLElement> | React.FocusEvent<HTMLElement>) => {
|
||||||
|
const dom = query.node(nodeId).get()?.dom;
|
||||||
|
if (dom) {
|
||||||
|
dom.setAttribute('data-layer-hovered', '');
|
||||||
|
hoveredDomRef.current = dom;
|
||||||
|
}
|
||||||
|
if (!isSelected) {
|
||||||
|
(e.currentTarget as HTMLElement).style.background = 'var(--color-bg-hover)';
|
||||||
|
}
|
||||||
|
},
|
||||||
|
[query, nodeId, isSelected],
|
||||||
|
);
|
||||||
|
|
||||||
|
const handleMouseLeave = useCallback(
|
||||||
|
(e: React.MouseEvent<HTMLElement> | React.FocusEvent<HTMLElement>) => {
|
||||||
|
hoveredDomRef.current?.removeAttribute('data-layer-hovered');
|
||||||
|
hoveredDomRef.current = null;
|
||||||
|
if (!isSelected) {
|
||||||
|
(e.currentTarget as HTMLElement).style.background = 'transparent';
|
||||||
|
}
|
||||||
|
},
|
||||||
|
[isSelected],
|
||||||
|
);
|
||||||
|
|
||||||
|
// Safety net: if this row unmounts (e.g. the user switches away from the
|
||||||
|
// Layers tab, or the tree re-shuffles) while still hovered, clear the
|
||||||
|
// attribute so it doesn't get stuck highlighted on the canvas forever.
|
||||||
|
useEffect(() => {
|
||||||
|
return () => {
|
||||||
|
hoveredDomRef.current?.removeAttribute('data-layer-hovered');
|
||||||
|
hoveredDomRef.current = null;
|
||||||
|
};
|
||||||
|
}, []);
|
||||||
|
|
||||||
if (!node) return null;
|
if (!node) return null;
|
||||||
|
|
||||||
const isSelected = selectedId === nodeId;
|
|
||||||
const nodeType = node.data.type;
|
|
||||||
const resolvedName = typeof nodeType === 'object' && nodeType !== null && 'resolvedName' in nodeType
|
|
||||||
? (nodeType as any).resolvedName
|
|
||||||
: typeof nodeType === 'string' ? nodeType : undefined;
|
|
||||||
const displayName = (node.data.props?.aiName as string) || node.data.displayName || (node.data.type as any)?.resolvedName || 'Node';
|
const displayName = (node.data.props?.aiName as string) || node.data.displayName || (node.data.type as any)?.resolvedName || 'Node';
|
||||||
const childNodeIds: string[] = node.data.nodes || [];
|
const childNodeIds: string[] = node.data.nodes || [];
|
||||||
const linkedNodeIds: string[] = Object.values(node.data.linkedNodes || {}) as string[];
|
const linkedNodeIds: string[] = Object.values(node.data.linkedNodes || {}) as string[];
|
||||||
const allChildren = [...childNodeIds, ...linkedNodeIds];
|
const allChildren = [...childNodeIds, ...linkedNodeIds];
|
||||||
const isRoot = nodeId === 'ROOT';
|
const isRoot = nodeId === 'ROOT';
|
||||||
|
const icon = isRoot ? ROOT_ICON : TYPE_ICONS[displayName] || DEFAULT_ICON;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div>
|
<div>
|
||||||
<div
|
<div
|
||||||
{...clickableProps(handleActivate)}
|
{...clickableProps(handleActivate)}
|
||||||
|
onMouseEnter={handleMouseEnter}
|
||||||
|
onMouseLeave={handleMouseLeave}
|
||||||
style={{
|
style={{
|
||||||
|
position: 'relative',
|
||||||
display: 'flex',
|
display: 'flex',
|
||||||
alignItems: 'center',
|
alignItems: 'center',
|
||||||
padding: '5px 8px',
|
padding: '5px 8px',
|
||||||
@@ -56,30 +164,53 @@ const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
|||||||
textOverflow: 'ellipsis',
|
textOverflow: 'ellipsis',
|
||||||
userSelect: 'none',
|
userSelect: 'none',
|
||||||
}}
|
}}
|
||||||
onMouseEnter={(e) => {
|
onFocus={handleMouseEnter}
|
||||||
if (!isSelected) {
|
onBlur={handleMouseLeave}
|
||||||
(e.currentTarget as HTMLElement).style.background = 'var(--color-bg-hover)';
|
|
||||||
}
|
|
||||||
}}
|
|
||||||
onMouseLeave={(e) => {
|
|
||||||
if (!isSelected) {
|
|
||||||
(e.currentTarget as HTMLElement).style.background = 'transparent';
|
|
||||||
}
|
|
||||||
}}
|
|
||||||
>
|
>
|
||||||
{/* Indentation indicator */}
|
{/* Indent guides: one vertical line per ancestor depth level,
|
||||||
{allChildren.length > 0 && (
|
aligned under each ancestor's disclosure/icon column so nested
|
||||||
<span style={{ marginRight: 4, fontSize: 8, color: 'var(--color-text-dim)' }}>
|
rows read as a tree instead of a flat, ever-further-indented list. */}
|
||||||
|
{Array.from({ length: depth }).map((_, level) => (
|
||||||
|
<span
|
||||||
|
key={level}
|
||||||
|
aria-hidden="true"
|
||||||
|
style={{
|
||||||
|
position: 'absolute',
|
||||||
|
left: `${8 + level * 16 + 4}px`,
|
||||||
|
top: 0,
|
||||||
|
bottom: 0,
|
||||||
|
width: 1,
|
||||||
|
background: 'var(--color-border)',
|
||||||
|
}}
|
||||||
|
/>
|
||||||
|
))}
|
||||||
|
|
||||||
|
{/* Indentation/disclosure indicator */}
|
||||||
|
{allChildren.length > 0 ? (
|
||||||
|
<span style={{ marginRight: 4, fontSize: 8, color: 'var(--color-text-dim)', flexShrink: 0 }}>
|
||||||
▼
|
▼
|
||||||
</span>
|
</span>
|
||||||
)}
|
) : (
|
||||||
{allChildren.length === 0 && (
|
<span style={{ marginRight: 4, fontSize: 8, color: 'transparent', flexShrink: 0 }}>
|
||||||
<span style={{ marginRight: 4, fontSize: 8, color: 'transparent' }}>
|
|
||||||
▼
|
▼
|
||||||
</span>
|
</span>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{/* Component type icon and name */}
|
{/* Component type icon */}
|
||||||
|
<i
|
||||||
|
className={`fa ${icon}`}
|
||||||
|
aria-hidden="true"
|
||||||
|
style={{
|
||||||
|
marginRight: 6,
|
||||||
|
fontSize: 11,
|
||||||
|
width: 12,
|
||||||
|
textAlign: 'center',
|
||||||
|
flexShrink: 0,
|
||||||
|
color: isSelected ? 'var(--color-accent)' : 'var(--color-text-dim)',
|
||||||
|
}}
|
||||||
|
/>
|
||||||
|
|
||||||
|
{/* Name */}
|
||||||
<span style={{ overflow: 'hidden', textOverflow: 'ellipsis' }}>
|
<span style={{ overflow: 'hidden', textOverflow: 'ellipsis' }}>
|
||||||
{isRoot ? 'Canvas (Root)' : displayName}
|
{isRoot ? 'Canvas (Root)' : displayName}
|
||||||
</span>
|
</span>
|
||||||
|
|||||||
@@ -13,9 +13,12 @@ import { useSitesmithModal } from '../../state/SitesmithContext';
|
|||||||
interface TopBarProps {
|
interface TopBarProps {
|
||||||
device: DeviceMode;
|
device: DeviceMode;
|
||||||
onDeviceChange: (device: DeviceMode) => void;
|
onDeviceChange: (device: DeviceMode) => void;
|
||||||
|
/** Item 10: canvas dashed guide outlines, default ON. */
|
||||||
|
showGuides: boolean;
|
||||||
|
onToggleGuides: () => void;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const TopBar: React.FC<TopBarProps> = ({ device, onDeviceChange }) => {
|
export const TopBar: React.FC<TopBarProps> = ({ device, onDeviceChange, showGuides, onToggleGuides }) => {
|
||||||
const { whpConfig, isWHP } = useEditorConfig();
|
const { whpConfig, isWHP } = useEditorConfig();
|
||||||
const { actions, query, canUndo, canRedo } = useEditor((_state, query) => ({
|
const { actions, query, canUndo, canRedo } = useEditor((_state, query) => ({
|
||||||
canUndo: query.history.canUndo(),
|
canUndo: query.history.canUndo(),
|
||||||
@@ -148,6 +151,16 @@ export const TopBar: React.FC<TopBarProps> = ({ device, onDeviceChange }) => {
|
|||||||
</button>
|
</button>
|
||||||
))}
|
))}
|
||||||
</div>
|
</div>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={`topbar-btn guides-toggle icon-only${showGuides ? ' active' : ''}`}
|
||||||
|
onClick={onToggleGuides}
|
||||||
|
aria-pressed={showGuides}
|
||||||
|
aria-label={showGuides ? 'Hide canvas guides' : 'Show canvas guides'}
|
||||||
|
data-tooltip={showGuides ? 'Hide guides' : 'Show guides'}
|
||||||
|
>
|
||||||
|
<i className={`fa ${showGuides ? 'fa-th' : 'fa-th-large'}`} aria-hidden />
|
||||||
|
</button>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<div className="topbar-right">
|
<div className="topbar-right">
|
||||||
@@ -161,10 +174,15 @@ export const TopBar: React.FC<TopBarProps> = ({ device, onDeviceChange }) => {
|
|||||||
<button className="topbar-btn" title="Templates" aria-label="Templates" onClick={() => setTemplateModalOpen(true)}>
|
<button className="topbar-btn" title="Templates" aria-label="Templates" onClick={() => setTemplateModalOpen(true)}>
|
||||||
<i className="fa fa-th-large" /> Templates
|
<i className="fa fa-th-large" /> Templates
|
||||||
</button>
|
</button>
|
||||||
<button className="topbar-btn" title="Custom Head Code" aria-label="Custom Head Code" onClick={() => setHeadCodeModalOpen(true)}>
|
<button
|
||||||
<i className="fa fa-code" /> Code
|
className="topbar-btn icon-only"
|
||||||
|
aria-label="Custom Head Code"
|
||||||
|
data-tooltip="Code"
|
||||||
|
onClick={() => setHeadCodeModalOpen(true)}
|
||||||
|
>
|
||||||
|
<i className="fa fa-code" />
|
||||||
</button>
|
</button>
|
||||||
<button className="topbar-btn" title="Preview" aria-label="Preview" onClick={() => {
|
<button className="topbar-btn icon-only" aria-label="Preview" data-tooltip="Preview" onClick={() => {
|
||||||
try {
|
try {
|
||||||
const serialized = query.serialize();
|
const serialized = query.serialize();
|
||||||
import('../../utils/html-export').then(({ exportToHtml, exportBodyHtml }) => {
|
import('../../utils/html-export').then(({ exportToHtml, exportBodyHtml }) => {
|
||||||
@@ -218,7 +236,7 @@ export const TopBar: React.FC<TopBarProps> = ({ device, onDeviceChange }) => {
|
|||||||
console.error('Preview failed:', e);
|
console.error('Preview failed:', e);
|
||||||
}
|
}
|
||||||
}}>
|
}}>
|
||||||
<i className="fa fa-eye" /> Preview
|
<i className="fa fa-eye" />
|
||||||
</button>
|
</button>
|
||||||
|
|
||||||
{/* Draft/Published status badge */}
|
{/* Draft/Published status badge */}
|
||||||
|
|||||||
+74
-41
@@ -136,7 +136,7 @@ body {
|
|||||||
color: var(--color-text);
|
color: var(--color-text);
|
||||||
background: transparent;
|
background: transparent;
|
||||||
border: 1px solid var(--color-border);
|
border: 1px solid var(--color-border);
|
||||||
border-radius: 20px;
|
border-radius: var(--radius-md);
|
||||||
cursor: pointer;
|
cursor: pointer;
|
||||||
white-space: nowrap;
|
white-space: nowrap;
|
||||||
transition: background var(--transition-fast), border-color var(--transition-fast),
|
transition: background var(--transition-fast), border-color var(--transition-fast),
|
||||||
@@ -198,6 +198,19 @@ body {
|
|||||||
margin: 0 4px;
|
margin: 0 4px;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Icon-only topbar buttons (Show Guides, Code, Preview) -- square-ish
|
||||||
|
footprint instead of the label+icon pill, tooltip via [data-tooltip]. */
|
||||||
|
.topbar-btn.icon-only {
|
||||||
|
gap: 0;
|
||||||
|
padding: 6px 8px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-btn.guides-toggle.active {
|
||||||
|
color: var(--color-accent);
|
||||||
|
background: var(--color-accent-subtle);
|
||||||
|
border-color: var(--color-accent);
|
||||||
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
Device Switcher
|
Device Switcher
|
||||||
-------------------------------------------------------------------------- */
|
-------------------------------------------------------------------------- */
|
||||||
@@ -1002,63 +1015,63 @@ body {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
Editor Visual Guides — dashed outlines for containers/columns/sections
|
Editor Visual Guides — dashed outlines for real drop targets only
|
||||||
-------------------------------------------------------------------------- */
|
-------------------------------------------------------------------------- */
|
||||||
|
|
||||||
/* All block-level elements in the canvas get a subtle dashed border */
|
/* Only actual Craft.js droppable containers get a guide outline -- these are
|
||||||
.canvas-device-frame div,
|
tagged with `data-craft-node` in RenderNode.tsx (the `<Editor onRender>`
|
||||||
.canvas-device-frame section,
|
override) based on `node.data.isCanvas`, not a blanket tag selector. A
|
||||||
.canvas-device-frame header,
|
component's own internal wrapper `<div>`s (e.g. Section's inner max-width
|
||||||
.canvas-device-frame footer,
|
container) are real DOM elements but not Craft nodes, so they never get
|
||||||
.canvas-device-frame main,
|
this attribute and never get a guide outline -- this is what stops
|
||||||
.canvas-device-frame article,
|
finished sections from showing 3-4 nested dashed boxes. */
|
||||||
.canvas-device-frame nav,
|
.canvas-device-frame [data-craft-node] {
|
||||||
.canvas-device-frame form {
|
|
||||||
outline: 1px dashed rgba(148, 163, 184, 0.2);
|
outline: 1px dashed rgba(148, 163, 184, 0.2);
|
||||||
outline-offset: -1px;
|
outline-offset: -1px;
|
||||||
transition: outline-color 0.15s;
|
transition: outline-color 0.15s;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Don't outline the outermost root wrapper or tiny utility divs */
|
|
||||||
.canvas-device-frame > div {
|
|
||||||
outline: none;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Rows (flex containers) get a slightly more visible border */
|
/* Rows (flex containers) get a slightly more visible border */
|
||||||
.canvas-device-frame div[style*="display: flex"],
|
.canvas-device-frame [data-craft-node][style*="display: flex"],
|
||||||
.canvas-device-frame div[style*="display:flex"] {
|
.canvas-device-frame [data-craft-node][style*="display:flex"] {
|
||||||
outline: 1px dashed rgba(148, 163, 184, 0.35);
|
outline: 1px dashed rgba(148, 163, 184, 0.35);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Empty containers: more visible + minimum height so they're clickable */
|
/* Empty containers: more visible + minimum height so they're clickable */
|
||||||
.canvas-device-frame div:empty,
|
.canvas-device-frame [data-craft-node]:empty {
|
||||||
.canvas-device-frame section:empty,
|
|
||||||
.canvas-device-frame main:empty,
|
|
||||||
.canvas-device-frame header:empty,
|
|
||||||
.canvas-device-frame footer:empty {
|
|
||||||
outline: 2px dashed rgba(148, 163, 184, 0.4);
|
outline: 2px dashed rgba(148, 163, 184, 0.4);
|
||||||
min-height: 60px;
|
min-height: 60px;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Hover highlights */
|
/* Hover highlights */
|
||||||
.canvas-device-frame div:hover,
|
.canvas-device-frame [data-craft-node]:hover {
|
||||||
.canvas-device-frame section:hover,
|
|
||||||
.canvas-device-frame header:hover,
|
|
||||||
.canvas-device-frame footer:hover,
|
|
||||||
.canvas-device-frame main:hover,
|
|
||||||
.canvas-device-frame nav:hover {
|
|
||||||
outline-color: rgba(59, 130, 246, 0.5);
|
outline-color: rgba(59, 130, 246, 0.5);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Header/footer zones get a distinct amber color */
|
/* `data-craft-hovered` is set (presence, no value) in RenderNode.tsx,
|
||||||
.canvas-device-frame [data-zone="header"],
|
mirroring Craft's own `hovered` node event. Craft.js's `connectors.connect()`
|
||||||
.canvas-device-frame [data-zone="footer"] {
|
(called by every component) wires that event to a native
|
||||||
outline: 1px dashed rgba(245, 158, 11, 0.4);
|
mouseover/mouseleave listener on each node's dom internally, so this
|
||||||
|
rule is a real mouse-hover highlight for any node (container or leaf).
|
||||||
|
`data-layer-hovered` is set directly by the Layers panel (LayersPanel.tsx)
|
||||||
|
on its own row hover/focus -- a separate producer (writing straight to the
|
||||||
|
target's dom rather than through Craft's `hovered` event, since the
|
||||||
|
action that drives it is stripped from the public `useEditor()` API at
|
||||||
|
runtime) that drives the identical highlight when hovering a layer row.
|
||||||
|
Both are scoped under `.canvas-device-frame` and suppressed by
|
||||||
|
`.guides-off` so "Show guides: off" stays airtight either way. */
|
||||||
|
.canvas-device-frame [data-craft-hovered],
|
||||||
|
.canvas-device-frame [data-layer-hovered] {
|
||||||
|
outline: 2px dashed var(--color-accent) !important;
|
||||||
|
outline-offset: -1px;
|
||||||
}
|
}
|
||||||
|
|
||||||
.canvas-device-frame [data-zone="header"]:hover,
|
/* "Show guides" topbar toggle (TopBar.tsx) -- flips this class on
|
||||||
.canvas-device-frame [data-zone="footer"]:hover {
|
.canvas-device-frame to hide every guide/hover outline at once. Default ON. */
|
||||||
outline-color: rgba(245, 158, 11, 0.7);
|
.canvas-device-frame.guides-off [data-craft-node],
|
||||||
|
.canvas-device-frame.guides-off [data-craft-hovered],
|
||||||
|
.canvas-device-frame.guides-off [data-layer-hovered] {
|
||||||
|
outline: none !important;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
@@ -1069,11 +1082,6 @@ body {
|
|||||||
outline-offset: -1px;
|
outline-offset: -1px;
|
||||||
}
|
}
|
||||||
|
|
||||||
.craftjs-renderer [data-hovered="true"] {
|
|
||||||
outline: 1px dashed var(--color-accent) !important;
|
|
||||||
outline-offset: -1px;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Component indicator badge (floats over the selected node via a portal --
|
/* Component indicator badge (floats over the selected node via a portal --
|
||||||
position/top/left are set inline per-node, see RenderNode.tsx) */
|
position/top/left are set inline per-node, see RenderNode.tsx) */
|
||||||
.component-indicator {
|
.component-indicator {
|
||||||
@@ -1153,6 +1161,21 @@ body {
|
|||||||
scrollbar-color: var(--color-border) transparent;
|
scrollbar-color: var(--color-border) transparent;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* --------------------------------------------------------------------------
|
||||||
|
Pages Panel — Header/Footer zone rows (Item 11)
|
||||||
|
Compact rows in the same neutral surface language as the page list, with
|
||||||
|
a pencil hint that only appears on hover instead of a permanently-loud
|
||||||
|
"Editing" pill.
|
||||||
|
-------------------------------------------------------------------------- */
|
||||||
|
.zone-row-pencil {
|
||||||
|
opacity: 0;
|
||||||
|
transition: opacity var(--transition-fast);
|
||||||
|
}
|
||||||
|
|
||||||
|
.zone-row:hover .zone-row-pencil {
|
||||||
|
opacity: 1;
|
||||||
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
Tooltip
|
Tooltip
|
||||||
-------------------------------------------------------------------------- */
|
-------------------------------------------------------------------------- */
|
||||||
@@ -1183,6 +1206,16 @@ body {
|
|||||||
opacity: 1;
|
opacity: 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Topbar sits flush against the top of the viewport (`body { overflow:
|
||||||
|
hidden }`), so the default "tooltip above the trigger" placement gets
|
||||||
|
clipped off-screen for topbar buttons -- flip those to render below
|
||||||
|
instead. Left-panel/canvas tooltips keep the default above placement,
|
||||||
|
which has room to render there. */
|
||||||
|
.topbar [data-tooltip]::after {
|
||||||
|
bottom: auto;
|
||||||
|
top: calc(100% + 6px);
|
||||||
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
Notifications / Toasts
|
Notifications / Toasts
|
||||||
-------------------------------------------------------------------------- */
|
-------------------------------------------------------------------------- */
|
||||||
|
|||||||
Reference in New Issue
Block a user