fix(builder): sanitize non-string style values + allowlist element tags (XSS)
Adversarial re-review found the C1 fix incomplete plus an adjacent
same-class XSS, both reachable via the AI update_props path and
deserialized saved state:
- cssPropsToString only ran sanitizeCssValue on typeof-string values, so a
non-string style value (array/object) with a valid key skipped
sanitization entirely and was template-coerced raw into style="...",
e.g. { color: ['red', '"><img src=x onerror=alert(1)>'] }. Now every
non-number value is coerced with String() and sanitized; numbers stay
raw. sanitizeBreakoutChars also now escapes < and > (previously only ;
and ") as defense-in-depth, since values can reach it from non-string
sources.
- props.tag (Container) and props.level (Heading) were interpolated raw
into the tag position of exported HTML (`<${tag}`, `<${level}`) with no
runtime validation, letting a malicious value break out of the tag
entirely. Both are now allowlisted/clamped against their known-safe sets
(div/section/article/header/footer/main; h1-h6), falling back to
div/h2. Applied in Container's live render + toHtml, Heading's live
render + toHtml, and the typeName==='div' fallback branch in
html-export.ts's renderNode (hit for unresolved/legacy node types).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
import { componentResolver } from '../components/resolver';
|
||||
import { cssPropsToString } from './style-helpers';
|
||||
import { escapeHtml, escapeAttr } from './escape';
|
||||
import { sanitizeContainerTag } from '../components/layout/Container';
|
||||
|
||||
export interface ExportOptions {
|
||||
title?: string;
|
||||
@@ -94,7 +95,11 @@ function renderNode(nodes: Record<string, any>, nodeId: string): { html: string
|
||||
// Fallback: wrap children in a div with inline styles
|
||||
if (typeName === 'Container' || typeName === 'div') {
|
||||
const styleStr = cssPropsToString(props.style);
|
||||
const tag = props.tag || 'div';
|
||||
// `props.tag` reaches this fallback the same way it reaches
|
||||
// `Container.toHtml` -- via AI `update_props` or deserialized saved
|
||||
// state, neither type-checked at runtime -- so it must be allowlisted
|
||||
// before hitting the `<${tag}` template position below.
|
||||
const tag = sanitizeContainerTag(props.tag);
|
||||
return {
|
||||
html: `<${tag}${dataAttrs}${styleStr ? ` style="${styleStr}"` : ''}>${allChildrenHtml}</${tag}>`,
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user