deterministic + unique ids in 6 components (node-derived scope)

Migrates Menu, ColumnLayout, Countdown, Gallery, Tabs, InputField, and
TextareaField from Math.random()/content-hash scope ids to the threaded
Craft node id (via scopeId()), keeping every emitted element id,
aria-controls/aria-labelledby/for, and inline <script> function
name/getElementById() call consistently scoped per component.

Resolves the two Important id-collision review findings:
- Tabs: tabId was djb2(anchorId||labels) -- two default Tabs instances
  produced identical aria-controls/aria-labelledby ids, so one instance's
  arrow-key script clobbered the other's tab/panel wiring.
- InputField/TextareaField: fieldId was `field-${name}` -- two fields
  sharing a (often default) name produced duplicate <label for>/<input
  id> pairs, breaking the for/id association for one of them.

Also eliminates the remaining Math.random() scope ids in Menu (hover CSS
class scope) and ColumnLayout (nth-child width CSS class scope), so no
export component is non-deterministic anymore.

All fall back to a stable content hash (never Math.random) for legacy
2-arg toHtml() call sites without a node id.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-07-12 14:35:12 -07:00
co-authored by Claude Opus 4.8
parent c2aac870e7
commit 8029126ab7
14 changed files with 291 additions and 53 deletions
@@ -51,3 +51,32 @@ describe('Tabs.toHtml accessibility (F1.2)', () => {
expect(html).toMatch(/ArrowLeft/);
});
});
describe('Tabs.toHtml deterministic + unique ids (thread node id, resolves id-collision finding)', () => {
test('same node id -> identical output across calls (deterministic, no Math.random)', () => {
const { html: html1 } = toHtml({ tabs }, '', 'node-tabs1');
const { html: html2 } = toHtml({ tabs }, '', 'node-tabs1');
expect(html1).toBe(html2);
});
test('two instances with IDENTICAL default tab content but different node ids do not collide', () => {
const { html: html1 } = toHtml({ tabs }, '', 'node-tabs1');
const { html: html2 } = toHtml({ tabs }, '', 'node-tabs2');
const id1 = html1.match(/role="tab"[^>]*aria-controls="([^"]+)"/)![1];
const id2 = html2.match(/role="tab"[^>]*aria-controls="([^"]+)"/)![1];
expect(id1).not.toBe(id2);
});
test('aria-controls still matches an existing panel id after the node-id change (internal consistency preserved)', () => {
const { html } = toHtml({ tabs }, '', 'node-tabs1');
const controlsMatch = html.match(/role="tab"[^>]*aria-controls="([^"]+)"/);
expect(controlsMatch).toBeTruthy();
expect(html).toContain(`id="${controlsMatch![1]}"`);
});
test('no nodeId (legacy 2-arg call): still deterministic across repeated calls, not random', () => {
const { html: html1 } = toHtml({ tabs }, '');
const { html: html2 } = toHtml({ tabs }, '');
expect(html1).toBe(html2);
});
});