feat(site-builder): page duplicate/reorder/set-landing + fix cross-page node copy/paste

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-07-14 07:36:00 -07:00
parent 204ea5e078
commit a698f014b0
9 changed files with 1040 additions and 108 deletions
+78 -12
View File
@@ -1,29 +1,95 @@
import { describe, test, expect, afterEach } from 'vitest'; import { describe, test, expect, afterEach } from 'vitest';
import { getClipboardNodeId, setClipboardNodeId } from './clipboard'; import type { NodeTree } from '@craftjs/core';
import { getClipboardTree, setClipboardTree } from './clipboard';
function makeTree(rootId: string, props: Record<string, unknown> = {}): NodeTree {
return {
rootNodeId: rootId,
nodes: {
[rootId]: {
id: rootId,
data: {
type: { resolvedName: 'Container' },
name: 'Container',
displayName: 'Container',
props,
custom: {},
isCanvas: false,
parent: 'wherever-it-originally-lived',
nodes: [],
linkedNodes: {},
hidden: false,
},
info: {},
events: { selected: false, dragged: false, hovered: false },
dom: null,
related: {},
rules: {},
_hydrationTimestamp: 0,
} as unknown as NodeTree['nodes'][string],
},
};
}
describe('clipboard', () => { describe('clipboard', () => {
afterEach(() => { afterEach(() => {
setClipboardNodeId(null); setClipboardTree(null);
}); });
test('starts empty', () => { test('starts empty', () => {
expect(getClipboardNodeId()).toBeNull(); expect(getClipboardTree()).toBeNull();
}); });
test('set then get returns the stored node id', () => { test('set then get returns a tree with the same root id and shape', () => {
setClipboardNodeId('node-123'); const tree = makeTree('node-123', { text: 'hello' });
expect(getClipboardNodeId()).toBe('node-123'); setClipboardTree(tree);
const got = getClipboardTree();
expect(got).not.toBeNull();
expect(got!.rootNodeId).toBe('node-123');
expect(got!.nodes['node-123'].data.props).toEqual({ text: 'hello' });
}); });
test('is a shared module-level store -- overwriting replaces the previous value', () => { test('is a shared module-level store -- overwriting replaces the previous value', () => {
setClipboardNodeId('first'); setClipboardTree(makeTree('first'));
setClipboardNodeId('second'); setClipboardTree(makeTree('second'));
expect(getClipboardNodeId()).toBe('second'); expect(getClipboardTree()!.rootNodeId).toBe('second');
}); });
test('can be cleared back to null', () => { test('can be cleared back to null', () => {
setClipboardNodeId('node-123'); setClipboardTree(makeTree('node-123'));
setClipboardNodeId(null); setClipboardTree(null);
expect(getClipboardNodeId()).toBeNull(); expect(getClipboardTree()).toBeNull();
});
test('deep-clones on set: mutating the original tree after set does not affect the stored snapshot', () => {
const original = makeTree('node-123', { text: 'original' });
setClipboardTree(original);
// Mutate the original tree's props object directly (as if the source
// node were edited, or the same live node got copied again).
(original.nodes['node-123'].data.props as Record<string, unknown>).text = 'mutated';
expect(getClipboardTree()!.nodes['node-123'].data.props).toEqual({ text: 'original' });
});
test('deep-clones nested props (arrays/objects), not just the top-level props object', () => {
const original = makeTree('node-123', { links: [{ url: 'https://example.com' }] });
setClipboardTree(original);
(original.nodes['node-123'].data.props as any).links[0].url = 'https://mutated.example.com';
expect((getClipboardTree()!.nodes['node-123'].data.props as any).links[0].url).toBe(
'https://example.com',
);
});
test('survives the original tree object being discarded entirely (detached copy, not a live reference)', () => {
let tree: NodeTree | null = makeTree('node-abc', { text: 'snapshot' });
setClipboardTree(tree);
tree = null; // simulate the original page's node/tree going away entirely
const got = getClipboardTree();
expect(got).not.toBeNull();
expect(got!.nodes['node-abc'].data.props).toEqual({ text: 'snapshot' });
}); });
}); });
+65 -7
View File
@@ -1,3 +1,5 @@
import type { Node, NodeId, NodeTree } from '@craftjs/core';
/** /**
* Tiny shared clipboard for canvas node copy/paste. * Tiny shared clipboard for canvas node copy/paste.
* *
@@ -9,15 +11,71 @@
* Deliberately not React state -- nothing in the UI needs to re-render * Deliberately not React state -- nothing in the UI needs to re-render
* reactively when the clipboard changes; consumers just read the current * reactively when the clipboard changes; consumers just read the current
* value at the moment they need it (on paste, or when a menu opens). * value at the moment they need it (on paste, or when a menu opens).
*
* Historical bug (cross-page copy/paste): this used to store only the copied
* node's bare id (`clipboardNodeId`) and re-resolve it via `query.node(id)`
* at paste time. That works fine same-page, but the moment the user switches
* pages the canvas is re-deserialized to the target page's Craft.js state --
* the copied id no longer exists in `query` at all -- so a cross-page paste
* silently no-op'd (or threw, caught, and swallowed). Storing a detached
* TREE SNAPSHOT at copy time instead means paste never needs to look the
* source id up again: it just hands the snapshot to `regenerateTreeIds` +
* `actions.addNodeTree`, which works identically regardless of which page's
* state is currently loaded on the canvas.
*/ */
let clipboardNodeId: string | null = null; let clipboardTree: NodeTree | null = null;
/** Returns the id of the node currently on the clipboard, or null if empty. */ /**
export function getClipboardNodeId(): string | null { * Deep, detached clone of a live Craft.js `NodeTree` (as returned by
return clipboardNodeId; * `query.node(id).toNodeTree()`).
*
* Not a plain `structuredClone(tree)`: for a REAL (live) Craft.js node,
* `data.type` is the actual component function/class reference (not a
* serializable `{resolvedName}` wrapper) -- `structuredClone` cannot clone a
* function and throws `DataCloneError` (see the identical note on
* `regenerateTreeIds` in `utils/craft-tree.ts`, which hit this exact bug
* historically). `type` is a stable reference shared by every node of that
* component across the whole app (it doesn't change per page), so it's safe
* to keep by reference -- only the mutable per-node data (`props`, `custom`,
* `nodes`, `linkedNodes`) needs an actual deep copy so a later mutation (a
* subsequent paste's `setProp`, or a fresh copy of the same live node)
* can never reach back into this stored snapshot.
*/
function cloneNodeTree(tree: NodeTree): NodeTree {
const nodes: Record<NodeId, Node> = {};
for (const [id, node] of Object.entries(tree.nodes)) {
nodes[id] = {
...node,
data: {
...node.data,
props: structuredClone(node.data.props),
custom: structuredClone(node.data.custom),
nodes: [...(node.data.nodes || [])],
linkedNodes: { ...(node.data.linkedNodes || {}) },
},
};
}
return { rootNodeId: tree.rootNodeId, nodes };
} }
/** Sets (or clears, with `null`) the node id on the clipboard. */ /**
export function setClipboardNodeId(nodeId: string | null): void { * Returns the tree snapshot currently on the clipboard, or null if empty.
clipboardNodeId = nodeId; * The returned tree is safe to hand straight to `regenerateTreeIds` --
* `regenerateTreeIds` never mutates its input, so repeated pastes of the
* same clipboard contents (including across a page switch) all work off the
* same untouched snapshot.
*/
export function getClipboardTree(): NodeTree | null {
return clipboardTree;
}
/**
* Sets (or clears, with `null`) the tree snapshot on the clipboard. The tree
* is deep-cloned before being stored (see `cloneNodeTree`) so it is fully
* detached from the live Craft.js node it was captured from -- it survives
* that node being deleted, mutated, or (the whole point) the canvas being
* re-deserialized to a different page entirely.
*/
export function setClipboardTree(tree: NodeTree | null): void {
clipboardTree = tree ? cloneNodeTree(tree) : null;
} }
+53 -17
View File
@@ -4,7 +4,7 @@ import { createRoot, Root } from 'react-dom/client';
import { act } from 'react-dom/test-utils'; import { act } from 'react-dom/test-utils';
import type { NodeTree, Node } from '@craftjs/core'; import type { NodeTree, Node } from '@craftjs/core';
import { useKeyboardShortcuts } from './useKeyboardShortcuts'; import { useKeyboardShortcuts } from './useKeyboardShortcuts';
import { getClipboardNodeId, setClipboardNodeId } from './clipboard'; import { getClipboardTree, setClipboardTree } from './clipboard';
/** /**
* Regression coverage: Ctrl/Cmd+V must run the copied subtree through * Regression coverage: Ctrl/Cmd+V must run the copied subtree through
@@ -15,6 +15,13 @@ import { getClipboardNodeId, setClipboardNodeId } from './clipboard';
* ROOT-fallback targeting, the empty-clipboard no-op, and the existing * ROOT-fallback targeting, the empty-clipboard no-op, and the existing
* input-focus guard. * input-focus guard.
* *
* Also covers the cross-page clipboard fix: copy stores a detached TREE
* SNAPSHOT (`setClipboardTree`), not a bare node id -- so paste never needs
* to re-resolve the original node via `query.node(id)`, which is exactly
* what breaks once the canvas has been re-deserialized to a different page
* (see `hooks/clipboard.ts` and the cross-page integration test in
* `test-utils/integration/duplicate-paste.integration.test.tsx`).
*
* Mock pattern mirrors PageContext.pure-updaters.test.tsx / * Mock pattern mirrors PageContext.pure-updaters.test.tsx /
* PageContext.slug.test.tsx: a fake `useEditor` exposing `query`/`actions`, * PageContext.slug.test.tsx: a fake `useEditor` exposing `query`/`actions`,
* mounted via a bare consumer component, with REAL `keydown` events * mounted via a bare consumer component, with REAL `keydown` events
@@ -27,6 +34,7 @@ import { getClipboardNodeId, setClipboardNodeId } from './clipboard';
*/ */
const addNodeTreeMock = vi.fn(); const addNodeTreeMock = vi.fn();
const selectNodeMock = vi.fn();
let selectedIds: string[] = []; let selectedIds: string[] = [];
function makeNode(id: string, parent: string | null, children: string[] = []): Node { function makeNode(id: string, parent: string | null, children: string[] = []): Node {
@@ -62,9 +70,10 @@ const COPIED_TREE: NodeTree = {
}, },
}; };
const nodeStore: Record<string, { data: { parent: string | null } }> = { const nodeStore: Record<string, { data: { parent: string | null; nodes?: string[] } }> = {
'selected-1': { data: { parent: 'parent-container-1' } }, 'selected-1': { data: { parent: 'parent-container-1' } },
ROOT: { data: { parent: null } }, 'parent-container-1': { data: { parent: null, nodes: ['other-sibling', 'selected-1'] } },
ROOT: { data: { parent: null, nodes: [] } },
'copied-root-1': { data: { parent: 'wherever-it-originally-lived' } }, 'copied-root-1': { data: { parent: 'wherever-it-originally-lived' } },
}; };
@@ -88,6 +97,7 @@ vi.mock('@craftjs/core', () => ({
}, },
actions: { actions: {
addNodeTree: addNodeTreeMock, addNodeTree: addNodeTreeMock,
selectNode: selectNodeMock,
history: { undo: vi.fn(), redo: vi.fn() }, history: { undo: vi.fn(), redo: vi.fn() },
delete: vi.fn(), delete: vi.fn(),
clearEvents: vi.fn(), clearEvents: vi.fn(),
@@ -145,44 +155,51 @@ const Consumer: React.FC = () => {
beforeEach(() => { beforeEach(() => {
selectedIds = []; selectedIds = [];
addNodeTreeMock.mockClear(); addNodeTreeMock.mockClear();
selectNodeMock.mockClear();
regenerateTreeIdsMock.mockClear(); regenerateTreeIdsMock.mockClear();
setClipboardNodeId(null); setClipboardTree(null);
}); });
afterEach(() => { afterEach(() => {
setClipboardNodeId(null); setClipboardTree(null);
if (root) unmount(); if (root) unmount();
}); });
describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => { describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => {
test('Ctrl+C copies the selected node id to the clipboard', () => { test('Ctrl+C copies the selected node`s subtree (a tree snapshot, not a bare id) to the clipboard', () => {
render(<Consumer />); render(<Consumer />);
selectedIds = ['selected-1']; selectedIds = ['copied-root-1'];
pressKey('c'); pressKey('c');
expect(getClipboardNodeId()).toBe('selected-1'); const clip = getClipboardTree();
expect(clip).not.toBeNull();
expect(clip!.rootNodeId).toBe('copied-root-1');
expect(Object.keys(clip!.nodes).sort()).toEqual(['copied-child-1', 'copied-root-1']);
}); });
test('Ctrl+V pastes as a sibling of the selection (selected node`s data.parent) with FRESH ids', () => { test('Ctrl+V pastes as a sibling of the selection, immediately after it, with FRESH ids', () => {
render(<Consumer />); render(<Consumer />);
selectedIds = ['copied-root-1']; selectedIds = ['copied-root-1'];
pressKey('c'); pressKey('c');
expect(getClipboardNodeId()).toBe('copied-root-1'); expect(getClipboardTree()!.rootNodeId).toBe('copied-root-1');
selectedIds = ['selected-1']; selectedIds = ['selected-1'];
pressKey('v'); pressKey('v');
// regenerateTreeIds actually ran before the tree was handed to Craft.js. // regenerateTreeIds actually ran before the tree was handed to Craft.js.
expect(regenerateTreeIdsMock).toHaveBeenCalledTimes(1); expect(regenerateTreeIdsMock).toHaveBeenCalledTimes(1);
expect(regenerateTreeIdsMock).toHaveBeenCalledWith(COPIED_TREE); expect(regenerateTreeIdsMock).toHaveBeenCalledWith(getClipboardTree());
expect(addNodeTreeMock).toHaveBeenCalledTimes(1); expect(addNodeTreeMock).toHaveBeenCalledTimes(1);
const [pastedTree, targetParent] = addNodeTreeMock.mock.calls[0]; const [pastedTree, targetParent, insertIndex] = addNodeTreeMock.mock.calls[0];
// Sibling of the current selection: selected-1's data.parent. // Sibling of the current selection: selected-1's data.parent.
expect(targetParent).toBe('parent-container-1'); expect(targetParent).toBe('parent-container-1');
// Immediately after selected-1 (index 1 among parent-container-1's
// children), matching duplicate()'s "insert right after" UX.
expect(insertIndex).toBe(2);
// The regression this guards: pasted ids must be fresh, never reuse the // The regression this guards: pasted ids must be fresh, never reuse the
// ids the copied node already occupies in the live Craft.js tree. // ids the copied node already occupies in the live Craft.js tree.
@@ -193,9 +210,12 @@ describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => {
for (const id of pastedIds) { for (const id of pastedIds) {
expect(originalIds.has(id)).toBe(false); expect(originalIds.has(id)).toBe(false);
} }
// The new copy is selected, same as duplicate()'s existing UX.
expect(selectNodeMock).toHaveBeenCalledWith(pastedTree.rootNodeId);
}); });
test('Ctrl+V with selection at ROOT falls back to ROOT as the insertion parent', () => { test('Ctrl+V with selection at ROOT falls back to appending into ROOT', () => {
render(<Consumer />); render(<Consumer />);
selectedIds = ['copied-root-1']; selectedIds = ['copied-root-1'];
@@ -205,8 +225,24 @@ describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => {
pressKey('v'); pressKey('v');
expect(addNodeTreeMock).toHaveBeenCalledTimes(1); expect(addNodeTreeMock).toHaveBeenCalledTimes(1);
const [, targetParent] = addNodeTreeMock.mock.calls[0]; const [, targetParent, insertIndex] = addNodeTreeMock.mock.calls[0];
expect(targetParent).toBe('ROOT'); expect(targetParent).toBe('ROOT');
expect(insertIndex).toBeUndefined();
});
test('Ctrl+V with nothing selected falls back to appending into ROOT', () => {
render(<Consumer />);
selectedIds = ['copied-root-1'];
pressKey('c');
selectedIds = [];
pressKey('v');
expect(addNodeTreeMock).toHaveBeenCalledTimes(1);
const [, targetParent, insertIndex] = addNodeTreeMock.mock.calls[0];
expect(targetParent).toBe('ROOT');
expect(insertIndex).toBeUndefined();
}); });
test('Ctrl+V with an empty clipboard is a no-op', () => { test('Ctrl+V with an empty clipboard is a no-op', () => {
@@ -229,9 +265,9 @@ describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => {
selectedIds = ['selected-1']; selectedIds = ['selected-1'];
pressKey('c'); pressKey('c');
expect(getClipboardNodeId()).toBeNull(); expect(getClipboardTree()).toBeNull();
setClipboardNodeId('copied-root-1'); setClipboardTree(COPIED_TREE);
pressKey('v'); pressKey('v');
expect(addNodeTreeMock).not.toHaveBeenCalled(); expect(addNodeTreeMock).not.toHaveBeenCalled();
@@ -252,7 +288,7 @@ describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => {
selectedIds = ['selected-1']; selectedIds = ['selected-1'];
pressKey('c'); pressKey('c');
expect(getClipboardNodeId()).toBeNull(); expect(getClipboardTree()).toBeNull();
activeElementSpy.mockRestore(); activeElementSpy.mockRestore();
}); });
+35 -13
View File
@@ -2,7 +2,7 @@ import { useEffect } from 'react';
import { useEditor } from '@craftjs/core'; import { useEditor } from '@craftjs/core';
import { findDeletableTarget } from '../utils/craft-helpers'; import { findDeletableTarget } from '../utils/craft-helpers';
import { regenerateTreeIds } from '../utils/craft-tree'; import { regenerateTreeIds } from '../utils/craft-tree';
import { getClipboardNodeId, setClipboardNodeId } from './clipboard'; import { getClipboardTree, setClipboardTree } from './clipboard';
function isInputFocused(): boolean { function isInputFocused(): boolean {
const el = document.activeElement; const el = document.activeElement;
@@ -86,13 +86,16 @@ export function useKeyboardShortcuts() {
return; return;
} }
// Ctrl+C: copy selected node id to the shared clipboard // Ctrl+C: copy the selected node's subtree (a detached snapshot, not
// just its id -- see clipboard.ts for why: an id-based clipboard can't
// survive a page switch, since the copied id no longer exists in
// `query` once the canvas is re-deserialized to a different page).
if (ctrl && (e.key === 'c' || e.key === 'C')) { if (ctrl && (e.key === 'c' || e.key === 'C')) {
e.preventDefault(); e.preventDefault();
try { try {
const selected = query.getEvent('selected').all(); const selected = query.getEvent('selected').all();
if (selected.length > 0 && selected[0] !== 'ROOT') { if (selected.length > 0 && selected[0] !== 'ROOT') {
setClipboardNodeId(selected[0]); setClipboardTree(query.node(selected[0]).toNodeTree());
} }
} catch (err) { } catch (err) {
console.error('Copy failed:', err); console.error('Copy failed:', err);
@@ -100,25 +103,44 @@ export function useKeyboardShortcuts() {
return; return;
} }
// Ctrl+V: paste the clipboard node as a sibling of the current selection // Ctrl+V: paste the clipboard tree as a sibling of the current
// selection (immediately after it, matching duplicate()'s UX), or
// append to ROOT when nothing is selected. Works regardless of which
// page is currently on the canvas -- the clipboard tree is a detached
// snapshot, not a reference to a node that may no longer exist here.
if (ctrl && (e.key === 'v' || e.key === 'V')) { if (ctrl && (e.key === 'v' || e.key === 'V')) {
e.preventDefault(); e.preventDefault();
try { try {
const sourceId = getClipboardNodeId(); const clip = getClipboardTree();
if (!sourceId || !query.node(sourceId).get()) return; if (!clip) return;
const selected = query.getEvent('selected').all(); const selected = query.getEvent('selected').all();
if (selected.length === 0) return; const selectedId = selected.length > 0 ? selected[0] : null;
const selectedId = selected[0];
let targetParent = 'ROOT'; let targetParentId = 'ROOT';
if (selectedId !== 'ROOT') { let insertIndex: number | undefined;
if (selectedId && selectedId !== 'ROOT') {
const node = query.node(selectedId).get(); const node = query.node(selectedId).get();
targetParent = node?.data?.parent || 'ROOT'; const parentId: string | null | undefined = node?.data?.parent;
if (parentId) {
targetParentId = parentId;
try {
const siblings: string[] = query.node(parentId).get()?.data?.nodes || [];
const idx = siblings.indexOf(selectedId);
if (idx !== -1) insertIndex = idx + 1;
} catch {
// Leave insertIndex undefined -- addNodeTree appends when omitted.
}
}
} }
const tree = regenerateTreeIds(query.node(sourceId).toNodeTree()); const tree = regenerateTreeIds(clip);
actions.addNodeTree(tree, targetParent); if (insertIndex !== undefined) {
actions.addNodeTree(tree, targetParentId, insertIndex);
} else {
actions.addNodeTree(tree, targetParentId);
}
actions.selectNode(tree.rootNodeId);
} catch (err) { } catch (err) {
console.error('Paste failed:', err); console.error('Paste failed:', err);
} }
+35 -16
View File
@@ -3,7 +3,7 @@ import { useEditor } from '@craftjs/core';
import { useSitesmithModal } from '../../state/SitesmithContext'; import { useSitesmithModal } from '../../state/SitesmithContext';
import { buildSitesmithTarget } from '../../utils/sitesmith-target'; import { buildSitesmithTarget } from '../../utils/sitesmith-target';
import { regenerateTreeIds } from '../../utils/craft-tree'; import { regenerateTreeIds } from '../../utils/craft-tree';
import { getClipboardNodeId, setClipboardNodeId } from '../../hooks/clipboard'; import { getClipboardTree, setClipboardTree } from '../../hooks/clipboard';
import { useNodeActions } from '../../hooks/useNodeActions'; import { useNodeActions } from '../../hooks/useNodeActions';
interface ContextMenuProps { interface ContextMenuProps {
@@ -79,35 +79,54 @@ export const ContextMenu: React.FC<ContextMenuProps> = ({
const copyNode = useCallback(() => { const copyNode = useCallback(() => {
if (!nodeId || nodeId === 'ROOT') return; if (!nodeId || nodeId === 'ROOT') return;
try { try {
setClipboardNodeId(nodeId); // Store a detached subtree snapshot, not just the id -- an id-based
// clipboard can't survive a page switch (the copied id no longer
// exists in `query` once the canvas is re-deserialized to a different
// page's Craft.js state). See clipboard.ts.
setClipboardTree(query.node(nodeId).toNodeTree());
} catch (e) { } catch (e) {
console.error('Copy failed:', e); console.error('Copy failed:', e);
} }
onClose(); onClose();
}, [nodeId, onClose]); }, [nodeId, query, onClose]);
const pasteNode = useCallback(() => { const pasteNode = useCallback(() => {
const sourceId = getClipboardNodeId(); const clip = getClipboardTree();
if (!sourceId) { if (!clip) {
onClose(); onClose();
return; return;
} }
try { try {
if (!query.node(sourceId).get()) { // Paste as a SIBLING of the right-clicked node (immediately after it,
onClose(); // matching duplicate()'s UX), not as its child -- using the clicked
return; // node itself as the parent throws when it's a leaf. Falls back to
} // appending into ROOT when nothing valid was right-clicked. This works
// regardless of which page is on the canvas -- the clipboard tree is a
// Paste as a SIBLING of the right-clicked node, not as its child -- // detached snapshot, not a reference to a node that may not exist here.
// using the clicked node itself as the parent throws when it's a leaf.
let targetParent = 'ROOT'; let targetParent = 'ROOT';
let insertIndex: number | undefined;
if (nodeId && nodeId !== 'ROOT') { if (nodeId && nodeId !== 'ROOT') {
const clickedNode = query.node(nodeId).get(); const clickedNode = query.node(nodeId).get();
targetParent = clickedNode?.data?.parent || 'ROOT'; const parentId: string | null | undefined = clickedNode?.data?.parent;
if (parentId) {
targetParent = parentId;
try {
const siblings: string[] = query.node(parentId).get()?.data?.nodes || [];
const idx = siblings.indexOf(nodeId);
if (idx !== -1) insertIndex = idx + 1;
} catch {
// Leave insertIndex undefined -- addNodeTree appends when omitted.
}
}
} }
const tree = regenerateTreeIds(query.node(sourceId).toNodeTree()); const tree = regenerateTreeIds(clip);
actions.addNodeTree(tree, targetParent); if (insertIndex !== undefined) {
actions.addNodeTree(tree, targetParent, insertIndex);
} else {
actions.addNodeTree(tree, targetParent);
}
actions.selectNode(tree.rootNodeId);
} catch (e) { } catch (e) {
console.error('Paste failed:', e); console.error('Paste failed:', e);
} }
@@ -176,7 +195,7 @@ export const ContextMenu: React.FC<ContextMenuProps> = ({
icon: 'clipboard', icon: 'clipboard',
shortcut: 'Ctrl+V', shortcut: 'Ctrl+V',
action: pasteNode, action: pasteNode,
disabled: !getClipboardNodeId(), disabled: !getClipboardTree(),
dividerAfter: true, dividerAfter: true,
}, },
{ {
+78 -40
View File
@@ -15,6 +15,9 @@ export const PagesPanel: React.FC = () => {
addPage, addPage,
deletePage, deletePage,
renamePage, renamePage,
duplicatePage,
movePage,
setLandingPage,
updatePageSeo, updatePageSeo,
} = usePages(); } = usePages();
const [isAdding, setIsAdding] = useState(false); const [isAdding, setIsAdding] = useState(false);
@@ -68,6 +71,33 @@ export const PagesPanel: React.FC = () => {
* differently-colored category. The active/editing state reuses the same * differently-colored category. The active/editing state reuses the same
* accent-outline treatment the page list already uses for the active page, * accent-outline treatment the page list already uses for the active page,
* so there's one consistent "this is what's currently open" affordance. */ * so there's one consistent "this is what's currently open" affordance. */
/* ---------- Per-page-row icon button ----------
* Shared 24x24 icon-button styling used by every action in the page row
* (SEO settings, rename, duplicate, reorder, set-as-home, delete) so a new
* action slots in looking identical to the pre-existing gear/pencil/trash
* buttons -- same dark-theme neutral treatment, `disabled` dims the icon
* (matching how `disabled` already reads elsewhere in this panel, e.g. the
* "Add Page" button), and `danger` reuses the existing delete-button
* accent color. */
const pageActionBtnStyle = (opts: { disabled?: boolean; danger?: boolean } = {}): React.CSSProperties => ({
width: 24,
height: 24,
display: 'inline-flex',
alignItems: 'center',
justifyContent: 'center',
fontSize: 11,
color: opts.disabled
? 'var(--color-text-dim)'
: opts.danger
? 'var(--color-danger)'
: 'var(--color-text-muted)',
background: 'transparent',
border: 'none',
borderRadius: 'var(--radius-sm)',
cursor: opts.disabled ? 'default' : 'pointer',
opacity: opts.disabled ? 0.5 : 1,
});
const zoneRowStyle = (isActive: boolean): React.CSSProperties => ({ const zoneRowStyle = (isActive: boolean): React.CSSProperties => ({
display: 'flex', display: 'flex',
alignItems: 'center', alignItems: 'center',
@@ -344,26 +374,58 @@ export const PagesPanel: React.FC = () => {
</div> </div>
</div> </div>
<div <div
style={{ display: 'flex', gap: 4, flexShrink: 0 }} style={{ display: 'flex', gap: 2, flexShrink: 0, flexWrap: 'wrap', justifyContent: 'flex-end', maxWidth: 96 }}
onClick={(e) => e.stopPropagation()} onClick={(e) => e.stopPropagation()}
> >
<button
onClick={() => movePage(page.id, 'up')}
disabled={pageIndex === 0}
data-tooltip="Move up"
aria-label={`Move ${page.name} up`}
style={pageActionBtnStyle({ disabled: pageIndex === 0 })}
>
<i className="fa fa-arrow-up" aria-hidden="true" />
</button>
<button
onClick={() => movePage(page.id, 'down')}
disabled={pageIndex === pages.length - 1}
data-tooltip="Move down"
aria-label={`Move ${page.name} down`}
style={pageActionBtnStyle({ disabled: pageIndex === pages.length - 1 })}
>
<i className="fa fa-arrow-down" aria-hidden="true" />
</button>
<button
onClick={() => duplicatePage(page.id)}
data-tooltip="Duplicate"
aria-label={`Duplicate ${page.name}`}
style={pageActionBtnStyle()}
>
<i className="fa fa-clone" aria-hidden="true" />
</button>
{isLanding ? (
<span
data-tooltip="This is the home page"
aria-label={`${page.name} is the home page`}
style={pageActionBtnStyle({ disabled: true })}
>
<i className="fa fa-home" aria-hidden="true" />
</span>
) : (
<button
onClick={() => setLandingPage(page.id)}
data-tooltip="Set as home page"
aria-label={`Set ${page.name} as the home page`}
style={pageActionBtnStyle()}
>
<i className="fa fa-home" aria-hidden="true" />
</button>
)}
<button <button
onClick={() => setSeoSettingsPageId(page.id)} onClick={() => setSeoSettingsPageId(page.id)}
data-tooltip="Page Settings (SEO)" data-tooltip="Page Settings (SEO)"
aria-label={`Page settings for ${page.name}`} aria-label={`Page settings for ${page.name}`}
style={{ style={pageActionBtnStyle()}
width: 24,
height: 24,
display: 'inline-flex',
alignItems: 'center',
justifyContent: 'center',
fontSize: 11,
color: 'var(--color-text-muted)',
background: 'transparent',
border: 'none',
borderRadius: 'var(--radius-sm)',
cursor: 'pointer',
}}
> >
<i className="fa fa-cog" aria-hidden="true" /> <i className="fa fa-cog" aria-hidden="true" />
</button> </button>
@@ -371,19 +433,7 @@ export const PagesPanel: React.FC = () => {
onClick={() => startEditing(page)} onClick={() => startEditing(page)}
data-tooltip="Rename" data-tooltip="Rename"
aria-label={`Rename ${page.name}`} aria-label={`Rename ${page.name}`}
style={{ style={pageActionBtnStyle()}
width: 24,
height: 24,
display: 'inline-flex',
alignItems: 'center',
justifyContent: 'center',
fontSize: 11,
color: 'var(--color-text-muted)',
background: 'transparent',
border: 'none',
borderRadius: 'var(--radius-sm)',
cursor: 'pointer',
}}
> >
<i className="fa fa-pencil" aria-hidden="true" /> <i className="fa fa-pencil" aria-hidden="true" />
</button> </button>
@@ -392,19 +442,7 @@ export const PagesPanel: React.FC = () => {
onClick={() => setDeleteConfirmId(page.id)} onClick={() => setDeleteConfirmId(page.id)}
data-tooltip="Delete" data-tooltip="Delete"
aria-label={`Delete ${page.name}`} aria-label={`Delete ${page.name}`}
style={{ style={pageActionBtnStyle({ danger: true })}
width: 24,
height: 24,
display: 'inline-flex',
alignItems: 'center',
justifyContent: 'center',
fontSize: 11,
color: 'var(--color-text-muted)',
background: 'transparent',
border: 'none',
borderRadius: 'var(--radius-sm)',
cursor: 'pointer',
}}
> >
<i className="fa fa-trash" aria-hidden="true" /> <i className="fa fa-trash" aria-hidden="true" />
</button> </button>
@@ -0,0 +1,427 @@
import { describe, test, expect, vi, beforeEach } from 'vitest';
import React from 'react';
import { createRoot, Root } from 'react-dom/client';
import { act } from 'react-dom/test-utils';
import { PageProvider, usePages, applyLandingInvariant } from './PageContext';
import { PageData } from '../types';
/**
* PKG-I: page duplicate / reorder / set-landing.
*
* The landing-page invariant is: `pages[0]` is the landing page, slug
* LOCKED to `'index'`; every other page gets a real, unique slug. This
* suite covers:
* - `applyLandingInvariant` as a pure function (unit tests, no provider).
* - `movePage`/`setLandingPage` re-establishing the invariant after
* reordering, via `PageProvider`.
* - `duplicatePage` inserting a copy right after the source with a copied
* craftState + seo and a unique slug, and switching the canvas to it.
*/
function makePage(overrides: Partial<PageData> & { id: string }): PageData {
return { name: overrides.id, slug: overrides.id, craftState: null, ...overrides };
}
describe('applyLandingInvariant (pure)', () => {
test('page at index 0 gets slug "index" even if it held a different slug', () => {
const pages = [
makePage({ id: 'a', name: 'About', slug: 'about' }),
makePage({ id: 'b', name: 'Home', slug: 'index' }),
];
const result = applyLandingInvariant(pages);
expect(result[0].slug).toBe('index');
expect(result[0].id).toBe('a');
});
test('demotes the old landing page (now at index > 0) to a unique real slug', () => {
const pages = [
makePage({ id: 'a', name: 'About', slug: 'about' }),
makePage({ id: 'b', name: 'Home', slug: 'index' }),
];
const result = applyLandingInvariant(pages);
const demoted = result.find((p) => p.id === 'b')!;
expect(demoted.slug).not.toBe('index');
expect(demoted.slug).toBe('home');
});
test('never produces two pages with slug "index"', () => {
const pages = [
makePage({ id: 'a', name: 'About', slug: 'about' }),
makePage({ id: 'b', name: 'Home', slug: 'index' }),
makePage({ id: 'c', name: 'Contact', slug: 'contact' }),
];
const result = applyLandingInvariant(pages);
const indexSlugs = result.filter((p) => p.slug === 'index');
expect(indexSlugs).toHaveLength(1);
expect(indexSlugs[0].id).toBe('a');
});
test('demoted page slug is deduped against a colliding existing slug elsewhere in the array', () => {
const pages = [
makePage({ id: 'a', name: 'About', slug: 'about' }),
makePage({ id: 'b', name: 'Home', slug: 'index' }), // demoted page, named "Home" -> slugifies to "home"
makePage({ id: 'c', name: 'HomePage', slug: 'home' }), // unrelated page already using slug "home"
];
const result = applyLandingInvariant(pages);
expect(result[0].slug).toBe('index');
const demoted = result.find((p) => p.id === 'b')!;
expect(demoted.slug).toBe('home-2');
const untouched = result.find((p) => p.id === 'c')!;
expect(untouched.slug).toBe('home');
const slugs = result.map((p) => p.slug);
expect(new Set(slugs).size).toBe(slugs.length);
});
test('non-landing pages that already have a real slug are left untouched', () => {
const pages = [
makePage({ id: 'a', name: 'Home', slug: 'index' }),
makePage({ id: 'b', name: 'About', slug: 'about' }),
makePage({ id: 'c', name: 'Contact', slug: 'contact' }),
];
const result = applyLandingInvariant(pages);
expect(result[1]).toEqual(pages[1]);
expect(result[2]).toEqual(pages[2]);
});
test('empty array is a no-op', () => {
expect(applyLandingInvariant([])).toEqual([]);
});
});
/* ---------- PageProvider-mounted coverage ---------- */
let serializeReturn = '{}';
const deserializeMock = vi.fn();
vi.mock('@craftjs/core', () => ({
useEditor: () => ({
query: { serialize: () => serializeReturn },
actions: { deserialize: deserializeMock },
}),
}));
let container: HTMLDivElement;
let root: Root;
function render(ui: React.ReactElement) {
container = document.createElement('div');
document.body.appendChild(container);
act(() => {
root = createRoot(container);
root.render(ui);
});
}
function unmount() {
act(() => {
root.unmount();
});
container.remove();
}
async function flushTimers() {
await act(async () => {
await new Promise((resolve) => setTimeout(resolve, 10));
});
}
beforeEach(() => {
serializeReturn = '{}';
deserializeMock.mockClear();
});
describe('PageContext.movePage', () => {
test('moves a page up, swapping with its neighbor', () => {
let ctx: ReturnType<typeof usePages> | null = null;
const Consumer: React.FC = () => {
ctx = usePages();
return null;
};
render(
<PageProvider>
<Consumer />
</PageProvider>,
);
act(() => ctx!.addPage('About', 'about'));
act(() => ctx!.addPage('Contact', 'contact'));
// pages: [Home(index0), About, Contact]
const contactId = ctx!.pages[2].id;
act(() => ctx!.movePage(contactId, 'up'));
expect(ctx!.pages.map((p) => p.name)).toEqual(['Home', 'Contact', 'About']);
// Landing invariant still holds -- Home untouched at index 0.
expect(ctx!.pages[0].slug).toBe('index');
unmount();
});
test('is a no-op at the top boundary', () => {
let ctx: ReturnType<typeof usePages> | null = null;
const Consumer: React.FC = () => {
ctx = usePages();
return null;
};
render(
<PageProvider>
<Consumer />
</PageProvider>,
);
act(() => ctx!.addPage('About', 'about'));
const homeId = ctx!.pages[0].id;
const before = ctx!.pages.map((p) => p.id);
act(() => ctx!.movePage(homeId, 'up'));
expect(ctx!.pages.map((p) => p.id)).toEqual(before);
unmount();
});
test('is a no-op at the bottom boundary', () => {
let ctx: ReturnType<typeof usePages> | null = null;
const Consumer: React.FC = () => {
ctx = usePages();
return null;
};
render(
<PageProvider>
<Consumer />
</PageProvider>,
);
act(() => ctx!.addPage('About', 'about'));
const aboutId = ctx!.pages[1].id;
const before = ctx!.pages.map((p) => p.id);
act(() => ctx!.movePage(aboutId, 'down'));
expect(ctx!.pages.map((p) => p.id)).toEqual(before);
unmount();
});
test('moving a non-landing page into index 0 promotes it and demotes the old landing page to a real slug', () => {
let ctx: ReturnType<typeof usePages> | null = null;
const Consumer: React.FC = () => {
ctx = usePages();
return null;
};
render(
<PageProvider>
<Consumer />
</PageProvider>,
);
act(() => ctx!.addPage('About', 'about'));
// pages: [Home(index0, slug index), About]
const aboutId = ctx!.pages[1].id;
const homeId = ctx!.pages[0].id;
act(() => ctx!.movePage(aboutId, 'up'));
// pages: [About, Home]
expect(ctx!.pages.map((p) => p.id)).toEqual([aboutId, homeId]);
expect(ctx!.pages[0].slug).toBe('index'); // About is now the landing page
const demotedHome = ctx!.pages.find((p) => p.id === homeId)!;
expect(demotedHome.slug).not.toBe('index');
expect(demotedHome.slug).toBe('home');
// Exactly one 'index' slug, always at index 0.
const indexPages = ctx!.pages.filter((p) => p.slug === 'index');
expect(indexPages).toHaveLength(1);
expect(ctx!.pages.indexOf(indexPages[0])).toBe(0);
// movePage does not touch the canvas.
expect(deserializeMock).not.toHaveBeenCalled();
unmount();
});
});
describe('PageContext.setLandingPage', () => {
test('promotes an arbitrary page to index 0 and demotes the old landing page', () => {
let ctx: ReturnType<typeof usePages> | null = null;
const Consumer: React.FC = () => {
ctx = usePages();
return null;
};
render(
<PageProvider>
<Consumer />
</PageProvider>,
);
act(() => ctx!.addPage('About', 'about'));
act(() => ctx!.addPage('Contact', 'contact'));
const homeId = ctx!.pages[0].id;
const contactId = ctx!.pages[2].id;
act(() => ctx!.setLandingPage(contactId));
expect(ctx!.pages[0].id).toBe(contactId);
expect(ctx!.pages[0].slug).toBe('index');
const demotedHome = ctx!.pages.find((p) => p.id === homeId)!;
expect(demotedHome.slug).toBe('home');
const indexPages = ctx!.pages.filter((p) => p.slug === 'index');
expect(indexPages).toHaveLength(1);
// setLandingPage does not touch the canvas.
expect(deserializeMock).not.toHaveBeenCalled();
unmount();
});
test('is a no-op when the page is already the landing page', () => {
let ctx: ReturnType<typeof usePages> | null = null;
const Consumer: React.FC = () => {
ctx = usePages();
return null;
};
render(
<PageProvider>
<Consumer />
</PageProvider>,
);
const homeId = ctx!.pages[0].id;
const before = ctx!.pages.map((p) => ({ ...p }));
act(() => ctx!.setLandingPage(homeId));
expect(ctx!.pages).toEqual(before);
unmount();
});
});
describe('PageContext.duplicatePage', () => {
test('inserts a copy immediately after the source with a copied craftState, seo, and a unique slug', async () => {
let ctx: ReturnType<typeof usePages> | null = null;
const Consumer: React.FC = () => {
ctx = usePages();
return null;
};
render(
<PageProvider>
<Consumer />
</PageProvider>,
);
act(() => ctx!.addPage('About', 'about'));
await flushTimers();
act(() => ctx!.addPage('Contact', 'contact'));
await flushTimers();
// pages: [Home, About, Contact]; Contact is currently active.
const aboutId = ctx!.pages[1].id;
act(() => ctx!.updatePageSeo(aboutId, { metaTitle: 'About Us' }));
act(() => ctx!.duplicatePage(aboutId));
await flushTimers();
const names = ctx!.pages.map((p) => p.name);
expect(names).toEqual(['Home', 'About', 'About copy', 'Contact']);
const copy = ctx!.pages[2];
expect(copy.name).toBe('About copy');
expect(copy.slug).toBe('about-copy');
expect(copy.seo).toEqual({ metaTitle: 'About Us' });
// Every slug in the array is unique.
const slugs = ctx!.pages.map((p) => p.slug);
expect(new Set(slugs).size).toBe(slugs.length);
// Landing invariant untouched -- copy is never index 0.
expect(ctx!.pages[0].slug).toBe('index');
unmount();
});
test('duplicating the ACTIVE page saves the live canvas into the copy (and the original)', async () => {
let ctx: ReturnType<typeof usePages> | null = null;
const Consumer: React.FC = () => {
ctx = usePages();
return null;
};
render(
<PageProvider>
<Consumer />
</PageProvider>,
);
// Home is active by default. Simulate the user having made live edits.
serializeReturn = '{"ROOT":{"live":"edit"}}';
act(() => ctx!.duplicatePage(ctx!.pages[0].id));
await flushTimers();
const copy = ctx!.pages[1];
expect(copy.name).toBe('Home copy');
expect(copy.craftState).toBe('{"ROOT":{"live":"edit"}}');
// Original page's stored state was also refreshed to the live canvas.
expect(ctx!.pages[0].craftState).toBe('{"ROOT":{"live":"edit"}}');
// The canvas switched to the new copy.
expect(ctx!.activePageId).toBe(copy.id);
unmount();
});
test('duplicating a non-active page copies its already-stored craftState (no live-canvas read)', async () => {
let ctx: ReturnType<typeof usePages> | null = null;
const Consumer: React.FC = () => {
ctx = usePages();
return null;
};
render(
<PageProvider>
<Consumer />
</PageProvider>,
);
act(() => ctx!.addPage('About', 'about'));
await flushTimers();
// Home is now inactive, stored with whatever it serialized to on switch.
const homeId = ctx!.pages[0].id;
const homeCraftState = ctx!.pages[0].craftState;
// Switch the live serialize() return to something else, to prove
// duplicating an inactive page does NOT read the live canvas.
serializeReturn = '{"ROOT":{"unrelated":"currently-active-page-content"}}';
act(() => ctx!.duplicatePage(homeId));
await flushTimers();
const copy = ctx!.pages.find((p) => p.name === 'Home copy')!;
expect(copy.craftState).toBe(homeCraftState);
unmount();
});
test('switches the canvas to the new copy (deserialize called with the copy craftState)', async () => {
let ctx: ReturnType<typeof usePages> | null = null;
const Consumer: React.FC = () => {
ctx = usePages();
return null;
};
render(
<PageProvider>
<Consumer />
</PageProvider>,
);
deserializeMock.mockClear();
act(() => ctx!.duplicatePage(ctx!.pages[0].id));
await flushTimers();
expect(deserializeMock).toHaveBeenCalled();
unmount();
});
});
+165
View File
@@ -18,6 +18,28 @@ interface PageContextValue {
addPage: (name: string, slug: string) => void; addPage: (name: string, slug: string) => void;
deletePage: (pageId: string) => void; deletePage: (pageId: string) => void;
renamePage: (pageId: string, name: string, slug: string) => void; renamePage: (pageId: string, name: string, slug: string) => void;
/**
* Duplicates `pageId`, inserting the copy immediately after the source in
* `pages` and switching the canvas to the new copy. If `pageId` is the
* active page, its current on-canvas state is saved first so the copy
* (and the original) both reflect what's actually on screen. The copy
* gets its own unique slug (never `'index'` -- it's never at index 0) and
* a name of `"<source name> copy"`; its `seo` is copied from the source.
*/
duplicatePage: (pageId: string) => void;
/**
* Reorders `pageId` one slot `'up'` or `'down'` within `pages` (swap with
* the adjacent page; no-op at either end). Does NOT touch the live
* canvas -- only list order changes. Re-applies the landing-page
* invariant afterward (see `applyLandingInvariant`) since a reorder can
* move a different page into/out of index 0.
*/
movePage: (pageId: string, direction: 'up' | 'down') => void;
/**
* Moves `pageId` to index 0 (making it the new landing page) and
* re-applies the landing-page invariant. Does NOT touch the live canvas.
*/
setLandingPage: (pageId: string) => void;
/** Merges `seo` fields onto the target page's existing `seo` (creating it if absent). */ /** Merges `seo` fields onto the target page's existing `seo` (creating it if absent). */
updatePageSeo: (pageId: string, seo: Partial<PageSeo>) => void; updatePageSeo: (pageId: string, seo: Partial<PageSeo>) => void;
setHeaderCraftState: (craftState: string) => void; setHeaderCraftState: (craftState: string) => void;
@@ -188,6 +210,9 @@ const PageContext = createContext<PageContextValue>({
addPage: () => {}, addPage: () => {},
deletePage: () => {}, deletePage: () => {},
renamePage: () => {}, renamePage: () => {},
duplicatePage: () => {},
movePage: () => {},
setLandingPage: () => {},
updatePageSeo: () => {}, updatePageSeo: () => {},
setHeaderCraftState: () => {}, setHeaderCraftState: () => {},
setFooterCraftState: () => {}, setFooterCraftState: () => {},
@@ -229,6 +254,52 @@ export function uniqueSlug(base: string, existingSlugs: string[]): string {
return `${base}-${i}`; return `${base}-${i}`;
} }
/**
* Re-establishes the landing-page invariant on a REORDERED pages array: the
* page now at index 0 is the landing page and its slug is locked to
* `'index'` (regardless of whatever slug it held before it was moved there);
* every other page keeps its slug UNLESS it's the page that previously held
* `'index'` and has now been demoted to index > 0 -- that page needs a real,
* unique slug of its own (derived from its name) since a page can no longer
* publish to `index.html` from anywhere but index 0.
*
* Pure function of the array -- used by both `movePage` (swap two adjacent
* pages) and `setLandingPage` (move an arbitrary page to index 0) as the
* shared "fix the invariant up after reordering" step, and directly
* unit-testable without mounting `PageProvider`.
*
* Assumes at most one page enters with slug `'index'` (true for any array
* that already satisfied the invariant before the reorder that produced this
* input) -- exactly the case both callers hand it.
*/
export function applyLandingInvariant(pages: PageData[]): PageData[] {
if (pages.length === 0) return pages;
// Slugs that are FIXED and must not be collided into: 'index' (reserved
// for whoever ends up at index 0) plus every non-landing page's existing
// slug except the demoted page's (it currently holds 'index' and is about
// to be given a new one). Computed upfront, over the WHOLE array, so the
// demoted page's new slug is checked against every other page regardless
// of array order -- checking only "slugs seen so far" while walking the
// array would miss a collision against a page that appears LATER in the
// list than the demoted one.
const fixedSlugs: string[] = ['index'];
for (let i = 1; i < pages.length; i++) {
if (pages[i].slug !== 'index') fixedSlugs.push(pages[i].slug);
}
return pages.map((page, i) => {
if (i === 0) {
return page.slug === 'index' ? page : { ...page, slug: 'index' };
}
if (page.slug === 'index') {
// Demoted landing page -- give it a real, unique slug of its own.
return { ...page, slug: uniqueSlug(slugify(page.name), fixedSlugs) };
}
return page;
});
}
const DEFAULT_PAGE: PageData = { const DEFAULT_PAGE: PageData = {
id: 'home', id: 'home',
name: 'Home', name: 'Home',
@@ -409,6 +480,97 @@ export const PageProvider: React.FC<{ children: ReactNode }> = ({ children }) =>
[loadState], [loadState],
); );
/**
* Duplicates `pageId`: inserts a copy immediately after the source in
* `pages` and switches the live canvas to it. See the doc comment on
* `PageContextValue.duplicatePage`.
*/
const duplicatePage = useCallback(
(pageId: string) => {
const isActive = pageId === activePageIdRef.current;
// If the source is the active page, persist its current on-canvas
// state back into `pages` first (same as switchPage/addPage do)
// so the ORIGINAL page isn't left with a stale craftState after
// this. `query.serialize()` below reads the live canvas directly
// rather than waiting on this (React state update timing aside,
// it's simplest to just ask Craft.js for the truth).
if (isActive) {
saveCurrentState();
}
const source = pagesRef.current.find((p) => p.id === pageId);
if (!source) return;
const sourceCraftState = isActive ? query.serialize() : source.craftState;
const otherSlugs = pagesRef.current.map((p) => p.slug);
const copyId = nextPageId();
const copyName = `${source.name} copy`;
// The copy is always inserted AFTER the source (index >= 1), so it
// never needs the reserved 'index' slug -- a normal unique slug always
// applies here regardless of whether the source itself is the landing
// page.
const copySlug = uniqueSlug(slugify(copyName), otherSlugs);
const copy: PageData = {
id: copyId,
name: copyName,
slug: copySlug,
craftState: sourceCraftState,
seo: source.seo ? { ...source.seo } : undefined,
};
setPages((prev) => {
const idx = prev.findIndex((p) => p.id === pageId);
if (idx === -1) return prev;
const next = [...prev];
next.splice(idx + 1, 0, copy);
return next;
});
// Switch the canvas to the new copy so the user lands on it, same as
// addPage switching to the freshly created page.
loadState(copy.craftState, EMPTY_CANVAS);
setActivePageId(copyId);
activePageIdRef.current = copyId;
},
[query, saveCurrentState, loadState],
);
/**
* Reorders `pageId` one slot up or down (swap with the adjacent page).
* Pure list-order change -- does not touch the live canvas. See the doc
* comment on `PageContextValue.movePage`.
*/
const movePage = useCallback((pageId: string, direction: 'up' | 'down') => {
setPages((prev) => {
const idx = prev.findIndex((p) => p.id === pageId);
if (idx === -1) return prev;
const swapIdx = direction === 'up' ? idx - 1 : idx + 1;
if (swapIdx < 0 || swapIdx >= prev.length) return prev; // no-op at the ends
const next = [...prev];
[next[idx], next[swapIdx]] = [next[swapIdx], next[idx]];
return applyLandingInvariant(next);
});
}, []);
/**
* Moves `pageId` to index 0, making it the new landing page. Pure list-
* order change -- does not touch the live canvas. See the doc comment on
* `PageContextValue.setLandingPage`.
*/
const setLandingPage = useCallback((pageId: string) => {
setPages((prev) => {
const idx = prev.findIndex((p) => p.id === pageId);
if (idx <= 0) return prev; // already the landing page, or not found
const next = [...prev];
const [moved] = next.splice(idx, 1);
next.unshift(moved);
return applyLandingInvariant(next);
});
}, []);
const renamePage = useCallback((pageId: string, name: string, slug: string) => { const renamePage = useCallback((pageId: string, name: string, slug: string) => {
setPages((prev) => setPages((prev) =>
prev.map((p, i) => { prev.map((p, i) => {
@@ -556,6 +718,9 @@ export const PageProvider: React.FC<{ children: ReactNode }> = ({ children }) =>
addPage, addPage,
deletePage, deletePage,
renamePage, renamePage,
duplicatePage,
movePage,
setLandingPage,
updatePageSeo, updatePageSeo,
setHeaderCraftState, setHeaderCraftState,
setFooterCraftState, setFooterCraftState,
@@ -3,7 +3,7 @@ import React from 'react';
import { renderEditorHarness, EditorHarness } from '../editorHarness'; import { renderEditorHarness, EditorHarness } from '../editorHarness';
import { useNodeActions, NodeActions } from '../../hooks/useNodeActions'; import { useNodeActions, NodeActions } from '../../hooks/useNodeActions';
import { useKeyboardShortcuts } from '../../hooks/useKeyboardShortcuts'; import { useKeyboardShortcuts } from '../../hooks/useKeyboardShortcuts';
import { getClipboardNodeId, setClipboardNodeId } from '../../hooks/clipboard'; import { getClipboardTree, setClipboardTree } from '../../hooks/clipboard';
/** /**
* Real-`@craftjs/core` integration coverage for duplicate/paste. * Real-`@craftjs/core` integration coverage for duplicate/paste.
@@ -67,10 +67,39 @@ const INITIAL_STATE = JSON.stringify({
}, },
}); });
// A second, independent "page" state -- distinct node ids from INITIAL_STATE,
// simulating what PageContext.switchPage does: `query.serialize()` the
// current page, then `actions.deserialize()` the target page's stored
// state, replacing the ENTIRE node map. `social-1` (copied from page A)
// does not exist anywhere in this state.
const PAGE_B_STATE = JSON.stringify({
ROOT: {
type: { resolvedName: 'Container' },
isCanvas: true,
props: { style: {}, tag: 'div' },
displayName: 'Container',
custom: {},
hidden: false,
nodes: ['page-b-heading-1'],
linkedNodes: {},
},
'page-b-heading-1': {
type: { resolvedName: 'Heading' },
isCanvas: false,
props: { text: 'Page B Heading', level: 'h2' },
displayName: 'Heading',
custom: {},
hidden: false,
parent: 'ROOT',
nodes: [],
linkedNodes: {},
},
});
let harness: EditorHarness | null = null; let harness: EditorHarness | null = null;
afterEach(() => { afterEach(() => {
setClipboardNodeId(null); setClipboardTree(null);
if (harness) { if (harness) {
harness.unmount(); harness.unmount();
harness = null; harness = null;
@@ -158,7 +187,7 @@ describe('duplicate/paste (real @craftjs/core editor)', () => {
new KeyboardEvent('keydown', { key: 'c', ctrlKey: true, bubbles: true, cancelable: true }), new KeyboardEvent('keydown', { key: 'c', ctrlKey: true, bubbles: true, cancelable: true }),
); );
}); });
expect(getClipboardNodeId()).toBe('social-1'); expect(getClipboardTree()!.rootNodeId).toBe('social-1');
// Select heading-1 (a sibling), then paste -- should land as a sibling // Select heading-1 (a sibling), then paste -- should land as a sibling
// of heading-1's parent (ROOT), with brand-new ids. // of heading-1's parent (ROOT), with brand-new ids.
@@ -190,4 +219,76 @@ describe('duplicate/paste (real @craftjs/core editor)', () => {
expect(pastedProps.links).not.toBe(originalProps.links); expect(pastedProps.links).not.toBe(originalProps.links);
expect(pastedProps).toEqual(originalProps); expect(pastedProps).toEqual(originalProps);
}); });
test('CROSS-PAGE copy/paste: copy on page A, switch to page B, paste -- the node appears on page B', () => {
harness = renderEditorHarness({ initialState: INITIAL_STATE });
const Consumer: React.FC = () => {
useKeyboardShortcuts();
return null;
};
harness.mountChild(<Consumer />);
// --- Page A: select + copy social-1. ---
harness.act(() => {
harness!.actions.selectNode('social-1');
});
harness.act(() => {
document.dispatchEvent(
new KeyboardEvent('keydown', { key: 'c', ctrlKey: true, bubbles: true, cancelable: true }),
);
});
expect(getClipboardTree()!.rootNodeId).toBe('social-1');
// --- Switch to page B: exactly what PageContext.switchPage does --
// serialize (discarded here, a real page switch would stash it) then
// deserialize the target page's state, replacing the ENTIRE node map.
// `social-1` no longer exists anywhere in `query` after this. ---
harness.act(() => {
harness!.actions.deserialize(PAGE_B_STATE);
});
expect(harness.query.getNodes()['social-1']).toBeUndefined();
// Select page B's only node, then paste.
harness.act(() => {
harness!.actions.selectNode('page-b-heading-1');
});
const beforePaste = Object.keys(harness.query.getNodes());
expect(() => {
harness!.act(() => {
document.dispatchEvent(
new KeyboardEvent('keydown', { key: 'v', ctrlKey: true, bubbles: true, cancelable: true }),
);
});
}).not.toThrow();
const afterPaste = Object.keys(harness.query.getNodes());
// The regression this guards against: with the old id-based clipboard,
// `query.node('social-1').get()` returns undefined once page B is
// loaded, so the paste handler's guard silently no-ops -- NOTHING gets
// added. With the tree-snapshot clipboard, the copied subtree is
// detached from any live query and pastes onto page B regardless.
expect(afterPaste.length).toBe(beforePaste.length + 1);
const pastedId = afterPaste.find((id) => !beforePaste.includes(id))!;
expect(pastedId).toBeDefined();
const pastedNode = harness.query.node(pastedId).get();
expect(pastedNode.data.displayName).toBe('Social Links');
expect(pastedNode.data.props.links).toEqual([
{ platform: 'facebook', url: 'https://facebook.com/original' },
]);
// Actually landed on page B's tree, as a sibling of the selected node.
const rootChildren: string[] = harness.query.node('ROOT').get().data.nodes;
expect(rootChildren).toContain(pastedId);
// Real DOM assertion: the pasted SocialLinks component is actually
// rendered on the (now page B) canvas.
expect(
harness.container.querySelectorAll('a[href="https://facebook.com/original"]'),
).toHaveLength(1);
});
}); });