Compare commits
34
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f00e4db3dc | ||
|
|
b9552faa30 | ||
|
|
77f35c4e9e | ||
|
|
2c8425ffb0 | ||
|
|
2a071bc7ab | ||
|
|
2a8a26687b | ||
|
|
979331b12d | ||
|
|
329a782052 | ||
|
|
da558fd52d | ||
|
|
8aeadefa88 | ||
|
|
2066059c35 | ||
|
|
473fe8d421 | ||
|
|
5d6ae7946b | ||
|
|
1c85ab93eb | ||
|
|
67228f24b4 | ||
|
|
613a44c4d4 | ||
|
|
5685670895 | ||
|
|
72f85a97e5 | ||
|
|
ab28ad8f2c | ||
|
|
05e00c572d | ||
|
|
458069afb6 | ||
|
|
b3e5009aec | ||
|
|
eeb0660d83 | ||
|
|
138e1a8273 | ||
|
|
1b12b79a0d | ||
|
|
621bb21d52 | ||
|
|
3f3c6fb851 | ||
|
|
802938ec1a | ||
|
|
3e43aee6e9 | ||
|
|
bf4a9f48eb | ||
|
|
86455413d0 | ||
|
|
0cbc58f8d1 | ||
|
|
92841e3f35 | ||
|
|
e892ee0e53 |
+1
-1
@@ -2,7 +2,7 @@
|
|||||||
<html lang="en">
|
<html lang="en">
|
||||||
<head>
|
<head>
|
||||||
<meta charset="UTF-8" />
|
<meta charset="UTF-8" />
|
||||||
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
|
<meta name="viewport" content="width=device-width, initial-scale=1.0, viewport-fit=cover" />
|
||||||
<title>Site Builder</title>
|
<title>Site Builder</title>
|
||||||
<link rel="preconnect" href="https://fonts.googleapis.com">
|
<link rel="preconnect" href="https://fonts.googleapis.com">
|
||||||
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
|
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
|
||||||
|
|||||||
+2
-1
@@ -1,6 +1,7 @@
|
|||||||
import React from 'react';
|
import React from 'react';
|
||||||
import { Editor } from '@craftjs/core';
|
import { Editor } from '@craftjs/core';
|
||||||
import { EditorShell } from './editor/EditorShell';
|
import { EditorShell } from './editor/EditorShell';
|
||||||
|
import { RenderNode } from './editor/RenderNode';
|
||||||
import { componentResolver } from './components/resolver';
|
import { componentResolver } from './components/resolver';
|
||||||
import { WhpConfig } from './types';
|
import { WhpConfig } from './types';
|
||||||
import { EditorConfigProvider } from './state/EditorConfigContext';
|
import { EditorConfigProvider } from './state/EditorConfigContext';
|
||||||
@@ -23,7 +24,7 @@ export const App: React.FC<AppProps> = ({ whpConfig }) => {
|
|||||||
return (
|
return (
|
||||||
<EditorConfigProvider config={whpConfig}>
|
<EditorConfigProvider config={whpConfig}>
|
||||||
<SiteDesignProvider>
|
<SiteDesignProvider>
|
||||||
<Editor resolver={componentResolver} enabled={true}>
|
<Editor resolver={componentResolver} enabled={true} onRender={RenderNode}>
|
||||||
<PageProvider>
|
<PageProvider>
|
||||||
<SitesmithProvider>
|
<SitesmithProvider>
|
||||||
<EditorShell />
|
<EditorShell />
|
||||||
|
|||||||
@@ -21,3 +21,46 @@ describe('purifyHtml', () => {
|
|||||||
expect(purifyHtml('<form><input name="x"></form>')).not.toContain('<form');
|
expect(purifyHtml('<form><input name="x"></form>')).not.toContain('<form');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('purifyHtml iframe sandboxing (M-6)', () => {
|
||||||
|
test('forces a restrictive sandbox attribute onto every iframe', () => {
|
||||||
|
const out = purifyHtml('<iframe src="https://example.com/"></iframe>');
|
||||||
|
expect(out).toMatch(/<iframe[^>]*\bsandbox="[^"]+"/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('sandbox value omits allow-top-navigation (no top-level nav escape)', () => {
|
||||||
|
const out = purifyHtml('<iframe src="https://example.com/"></iframe>');
|
||||||
|
const sandbox = out.match(/sandbox="([^"]*)"/)![1];
|
||||||
|
expect(sandbox).not.toMatch(/allow-top-navigation/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('legitimate embeds (YouTube) still work and get sandboxed too', () => {
|
||||||
|
const out = purifyHtml('<iframe src="https://www.youtube.com/embed/abc" allowfullscreen></iframe>');
|
||||||
|
expect(out).toContain('youtube.com/embed/abc');
|
||||||
|
expect(out).toMatch(/<iframe[^>]*\bsandbox="[^"]+"/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('adds referrerpolicy=no-referrer to iframes', () => {
|
||||||
|
const out = purifyHtml('<iframe src="https://example.com/"></iframe>');
|
||||||
|
expect(out).toContain('referrerpolicy="no-referrer"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('script/on* attributes are still stripped alongside the sandboxed iframe', () => {
|
||||||
|
const out = purifyHtml('<iframe src="https://example.com/" onload="alert(1)"></iframe><script>alert(2)</script>');
|
||||||
|
expect(out).not.toContain('onload');
|
||||||
|
expect(out).not.toContain('<script');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('repeated calls do not leak/accumulate the hook (no duplicate sandbox attr, no cross-call state)', () => {
|
||||||
|
purifyHtml('<iframe src="https://a.example/"></iframe>');
|
||||||
|
purifyHtml('<iframe src="https://b.example/"></iframe>');
|
||||||
|
const out = purifyHtml('<iframe src="https://c.example/"></iframe>');
|
||||||
|
const sandboxMatches = out.match(/sandbox="/g) || [];
|
||||||
|
expect(sandboxMatches.length).toBe(1);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a non-iframe element sanitized alongside an iframe is not touched by the hook', () => {
|
||||||
|
const out = purifyHtml('<p>hi</p><iframe src="https://example.com/"></iframe>');
|
||||||
|
expect(out).toContain('<p>hi</p>');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -24,14 +24,42 @@ const PURIFY_CONFIG = {
|
|||||||
'href','src','alt','title','target','rel',
|
'href','src','alt','title','target','rel',
|
||||||
'width','height','class',
|
'width','height','class',
|
||||||
'allowfullscreen','allow','frameborder',
|
'allowfullscreen','allow','frameborder',
|
||||||
|
'sandbox','referrerpolicy',
|
||||||
],
|
],
|
||||||
ALLOWED_URI_REGEXP: /^(?:(?:https?|mailto|tel|data:image\/[a-z]+;base64,):|[^a-z]|[a-z+.-]+(?:[^a-z+.\-:]|$))/i,
|
ALLOWED_URI_REGEXP: /^(?:(?:https?|mailto|tel|data:image\/[a-z]+;base64,):|[^a-z]|[a-z+.-]+(?:[^a-z+.\-:]|$))/i,
|
||||||
FORBID_TAGS: ['script','style','object','embed','link','meta','form','input','button','select','textarea'],
|
FORBID_TAGS: ['script','style','object','embed','link','meta','form','input','button','select','textarea'],
|
||||||
FORBID_ATTR: [/^on/i],
|
FORBID_ATTR: [/^on/i],
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// M-6: `<iframe>` is allowed (maps/video embeds are a legitimate use case)
|
||||||
|
// but an iframe with a `src` and NO `sandbox` attribute is a clickjacking/
|
||||||
|
// phishing vector (DOMPurify already strips <script>/on*=, but an
|
||||||
|
// unsandboxed iframe still gets full script execution, same-origin-ish
|
||||||
|
// access via document.domain tricks, top-level navigation, etc., inside
|
||||||
|
// itself). This hook force-sets a restrictive sandbox on every iframe that
|
||||||
|
// survives sanitization, keeping `allow-scripts`/`allow-same-origin`/
|
||||||
|
// `allow-popups`/`allow-forms` (needed for interactive maps/video/oauth
|
||||||
|
// popups) but deliberately omitting `allow-top-navigation` so an embedded
|
||||||
|
// page can never redirect/hijack the parent tab.
|
||||||
|
const IFRAME_SANDBOX_HOOK = (node: Element): void => {
|
||||||
|
if (node.nodeName === 'IFRAME') {
|
||||||
|
node.setAttribute('sandbox', 'allow-scripts allow-same-origin allow-popups allow-forms');
|
||||||
|
node.setAttribute('referrerpolicy', 'no-referrer');
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
export function purifyHtml(input: string): string {
|
export function purifyHtml(input: string): string {
|
||||||
|
// Hook is added immediately before sanitize() and removed immediately
|
||||||
|
// after, scoped tightly to this single call -- so it can never leak onto
|
||||||
|
// (or accumulate duplicate copies across) any other DOMPurify.sanitize()
|
||||||
|
// call elsewhere in the app, and repeated purifyHtml() calls never stack
|
||||||
|
// multiple copies of the same hook.
|
||||||
|
DOMPurify.addHook('afterSanitizeAttributes', IFRAME_SANDBOX_HOOK);
|
||||||
|
try {
|
||||||
return DOMPurify.sanitize(input || '', PURIFY_CONFIG as any) as unknown as string;
|
return DOMPurify.sanitize(input || '', PURIFY_CONFIG as any) as unknown as string;
|
||||||
|
} finally {
|
||||||
|
DOMPurify.removeHook('afterSanitizeAttributes', IFRAME_SANDBOX_HOOK as any);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
export const HtmlBlock: UserComponent<HtmlBlockProps> = ({ code = '', style = {} }) => {
|
export const HtmlBlock: UserComponent<HtmlBlockProps> = ({ code = '', style = {} }) => {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@ import React, { CSSProperties } from 'react';
|
|||||||
import { useNode, UserComponent } from '@craftjs/core';
|
import { useNode, UserComponent } from '@craftjs/core';
|
||||||
import { cssPropsToString } from '../../utils/style-helpers';
|
import { cssPropsToString } from '../../utils/style-helpers';
|
||||||
import { useSiteDesign } from '../../state/SiteDesignContext';
|
import { useSiteDesign } from '../../state/SiteDesignContext';
|
||||||
import { escapeHtml, escapeAttr, safeUrl } from '../../utils/escape';
|
import { escapeHtml, escapeAttr, safeUrl, safeImageUrl } from '../../utils/escape';
|
||||||
|
|
||||||
/* ---------- Types ---------- */
|
/* ---------- Types ---------- */
|
||||||
|
|
||||||
@@ -104,7 +104,7 @@ Logo.craft = {
|
|||||||
let innerHtml: string;
|
let innerHtml: string;
|
||||||
if (props.type === 'image' && props.imageSrc) {
|
if (props.type === 'image' && props.imageSrc) {
|
||||||
const imgStyle = cssPropsToString({ width: props.imageWidth || '120px', height: 'auto', display: 'block' });
|
const imgStyle = cssPropsToString({ width: props.imageWidth || '120px', height: 'auto', display: 'block' });
|
||||||
innerHtml = `<img src="${escapeAttr(safeUrl(props.imageSrc))}" alt="${escapeAttr(props.text || 'Logo')}"${imgStyle ? ` style="${imgStyle}"` : ''} />`;
|
innerHtml = `<img src="${escapeAttr(safeImageUrl(props.imageSrc))}" alt="${escapeAttr(props.text || 'Logo')}"${imgStyle ? ` style="${imgStyle}"` : ''} />`;
|
||||||
} else {
|
} else {
|
||||||
const spanStyle = cssPropsToString({
|
const spanStyle = cssPropsToString({
|
||||||
fontWeight: props.fontWeight || '700',
|
fontWeight: props.fontWeight || '700',
|
||||||
|
|||||||
@@ -5,28 +5,84 @@ const toHtml = (Navbar as any).toHtml;
|
|||||||
|
|
||||||
describe('Navbar.toHtml hamburger accessibility (F2.3)', () => {
|
describe('Navbar.toHtml hamburger accessibility (F2.3)', () => {
|
||||||
test('mobile toggle button has an accessible name, aria-expanded, and aria-controls', () => {
|
test('mobile toggle button has an accessible name, aria-expanded, and aria-controls', () => {
|
||||||
const { html } = toHtml({ showMobileMenu: true }, '');
|
const { html } = toHtml({ showMobileMenu: true }, '', 'node-nav1');
|
||||||
expect(html).toMatch(/class="navbar-hamburger"[^>]*aria-label="Toggle navigation menu"/);
|
expect(html).toMatch(/class="navbar-hamburger"[^>]*aria-label="Toggle navigation menu"/);
|
||||||
expect(html).toMatch(/aria-expanded="false"/);
|
expect(html).toMatch(/aria-expanded="false"/);
|
||||||
expect(html).toMatch(/aria-controls="navbar-links"/);
|
expect(html).toMatch(/aria-controls="[^"]+"/);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('aria-controls target id exists on the links container', () => {
|
test('aria-controls target id exists on the links container', () => {
|
||||||
const { html } = toHtml({ showMobileMenu: true }, '');
|
const { html } = toHtml({ showMobileMenu: true }, '', 'node-nav1');
|
||||||
expect(html).toContain('id="navbar-links"');
|
const controls = html.match(/aria-controls="([^"]+)"/)![1];
|
||||||
|
expect(html).toContain(`id="${controls}"`);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('toggle script flips aria-expanded on click', () => {
|
test('toggle script flips aria-expanded on click', () => {
|
||||||
const { html } = toHtml({ showMobileMenu: true }, '');
|
const { html } = toHtml({ showMobileMenu: true }, '', 'node-nav1');
|
||||||
expect(html).toMatch(/setAttribute\(['"]aria-expanded['"]/);
|
expect(html).toMatch(/setAttribute\(['"]aria-expanded['"]/);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('no mobile menu: no hamburger button emitted', () => {
|
test('no mobile menu: no hamburger button emitted', () => {
|
||||||
const { html } = toHtml({ showMobileMenu: false }, '');
|
const { html } = toHtml({ showMobileMenu: false }, '', 'node-nav1');
|
||||||
expect(html).not.toContain('navbar-hamburger');
|
expect(html).not.toContain('navbar-hamburger');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('Navbar.toHtml node-scoped ids/hover styles (M-1: two navbars must not collide)', () => {
|
||||||
|
test('no bare unscoped id="navbar-links" is emitted', () => {
|
||||||
|
const { html } = toHtml({ showMobileMenu: true }, '', 'node-nav1');
|
||||||
|
expect(html).not.toContain('id="navbar-links"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('two different node ids produce different links-container ids', () => {
|
||||||
|
const { html: html1 } = toHtml({ showMobileMenu: true }, '', 'node-nav1');
|
||||||
|
const { html: html2 } = toHtml({ showMobileMenu: true }, '', 'node-nav2');
|
||||||
|
const id1 = html1.match(/id="([^"]+)"/)![1];
|
||||||
|
const id2 = html2.match(/id="([^"]+)"/)![1];
|
||||||
|
expect(id1).not.toBe(id2);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('aria-controls always equals the actual links-container id', () => {
|
||||||
|
const { html } = toHtml({ showMobileMenu: true }, '', 'node-nav1');
|
||||||
|
const controls = html.match(/aria-controls="([^"]+)"/)![1];
|
||||||
|
const linksId = html.match(/id="([^"]+)"/)![1];
|
||||||
|
expect(controls).toBe(linksId);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('hover style selectors are scoped per-instance, not bare .navbar-link/.navbar-cta', () => {
|
||||||
|
const { html } = toHtml({ hoverColor: '#ff0000' }, '', 'node-nav1');
|
||||||
|
// A selector rule that STARTS the line with .navbar-link:hover (i.e. not
|
||||||
|
// preceded by a per-instance ancestor class) would be the old, unscoped,
|
||||||
|
// globally-colliding form.
|
||||||
|
expect(html).not.toMatch(/^\s*\.navbar-link:hover/m);
|
||||||
|
expect(html).not.toMatch(/^\s*\.navbar-cta:hover/m);
|
||||||
|
// still present, just scoped under a per-instance ancestor class
|
||||||
|
expect(html).toMatch(/\.navbar-link:hover/);
|
||||||
|
expect(html).toMatch(/\.[\w-]+ \.navbar-link:hover/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('two navbars with different hoverColor do not leak style onto each other (scoped selectors differ)', () => {
|
||||||
|
const { html: html1 } = toHtml({ hoverColor: '#ff0000' }, '', 'node-nav1');
|
||||||
|
const { html: html2 } = toHtml({ hoverColor: '#00ff00' }, '', 'node-nav2');
|
||||||
|
const scope1 = html1.match(/<style>\s*\.([\w-]+)\s/)![1];
|
||||||
|
const scope2 = html2.match(/<style>\s*\.([\w-]+)\s/)![1];
|
||||||
|
expect(scope1).not.toBe(scope2);
|
||||||
|
expect(html1).toContain(`.${scope1} .navbar-link:hover`);
|
||||||
|
expect(html2).toContain(`.${scope2} .navbar-link:hover`);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a normal single navbar still renders its hover style (visual output preserved)', () => {
|
||||||
|
const { html } = toHtml({ hoverColor: '#ff0000' }, '', 'node-nav1');
|
||||||
|
expect(html).toMatch(/:hover\s*\{\s*color:\s*#ff0000/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('same node id -> identical output across calls (deterministic)', () => {
|
||||||
|
const { html: html1 } = toHtml({ showMobileMenu: true }, '', 'node-nav1');
|
||||||
|
const { html: html2 } = toHtml({ showMobileMenu: true }, '', 'node-nav1');
|
||||||
|
expect(html1).toBe(html2);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe('Navbar.toHtml XSS hardening (hoverColor/backgroundColor/ctaColor into <style>)', () => {
|
describe('Navbar.toHtml XSS hardening (hoverColor/backgroundColor/ctaColor into <style>)', () => {
|
||||||
test('a hoverColor value containing </style><script> is neutralized in the hover <style> block', () => {
|
test('a hoverColor value containing </style><script> is neutralized in the hover <style> block', () => {
|
||||||
const malicious = '#fff}</style><script>alert(1)</script><style>{';
|
const malicious = '#fff}</style><script>alert(1)</script><style>{';
|
||||||
|
|||||||
@@ -2,7 +2,7 @@ import React, { CSSProperties, useState } from 'react';
|
|||||||
import { useNode, UserComponent } from '@craftjs/core';
|
import { useNode, UserComponent } from '@craftjs/core';
|
||||||
import { cssPropsToString } from '../../utils/style-helpers';
|
import { cssPropsToString } from '../../utils/style-helpers';
|
||||||
import { useSiteDesign } from '../../state/SiteDesignContext';
|
import { useSiteDesign } from '../../state/SiteDesignContext';
|
||||||
import { escapeHtml, escapeAttr, safeUrl, cssValue } from '../../utils/escape';
|
import { escapeHtml, escapeAttr, safeUrl, safeImageUrl, cssValue, scopeId } from '../../utils/escape';
|
||||||
|
|
||||||
/* ---------- Types ---------- */
|
/* ---------- Types ---------- */
|
||||||
|
|
||||||
@@ -210,7 +210,7 @@ Navbar.craft = {
|
|||||||
|
|
||||||
/* ---------- HTML export ---------- */
|
/* ---------- HTML export ---------- */
|
||||||
|
|
||||||
(Navbar as any).toHtml = (props: NavbarProps, _childrenHtml: string) => {
|
(Navbar as any).toHtml = (props: NavbarProps, _childrenHtml: string, nodeId?: string) => {
|
||||||
// Sanitized once here -- these are raw string-interpolation sinks below
|
// Sanitized once here -- these are raw string-interpolation sinks below
|
||||||
// (hoverCol/bgColor go into a <style> block, the worst case: </style>
|
// (hoverCol/bgColor go into a <style> block, the worst case: </style>
|
||||||
// breakout -> arbitrary <script>), see task-cssxss-brief.md.
|
// breakout -> arbitrary <script>), see task-cssxss-brief.md.
|
||||||
@@ -224,6 +224,19 @@ Navbar.craft = {
|
|||||||
const sticky = props.isSticky;
|
const sticky = props.isSticky;
|
||||||
const mobile = props.showMobileMenu;
|
const mobile = props.showMobileMenu;
|
||||||
const logoUrl = props.logoUrl || '/';
|
const logoUrl = props.logoUrl || '/';
|
||||||
|
const links0 = props.links || defaultLinks;
|
||||||
|
|
||||||
|
// M-1: deterministic AND unique per-instance scope, keyed on the Craft
|
||||||
|
// node id. Two Navbars on the same page previously emitted an identical
|
||||||
|
// fixed id="navbar-links" (invalid duplicate-id HTML, ambiguous
|
||||||
|
// aria-controls target) and unscoped `.navbar-link:hover`/`.navbar-cta:hover`
|
||||||
|
// rules in each instance's own <style> block -- since both blocks target
|
||||||
|
// the SAME global selector, the later one in the DOM silently overrides
|
||||||
|
// the earlier one's hover color/behavior for BOTH navbars. Scoping the
|
||||||
|
// links-container id and adding a per-instance class on the <nav> root
|
||||||
|
// (used to prefix the hover selectors) eliminates both collisions.
|
||||||
|
const scope = scopeId(nodeId, JSON.stringify(links0) + alignment + pad, 'nav');
|
||||||
|
const linksId = `${scope}_links`;
|
||||||
|
|
||||||
const navStyle = cssPropsToString({
|
const navStyle = cssPropsToString({
|
||||||
display: 'flex',
|
display: 'flex',
|
||||||
@@ -239,7 +252,7 @@ Navbar.craft = {
|
|||||||
let logoHtml: string;
|
let logoHtml: string;
|
||||||
if (props.logoType === 'image' && props.logoImage) {
|
if (props.logoType === 'image' && props.logoImage) {
|
||||||
const imgStyle = cssPropsToString({ width: props.logoWidth || '120px', height: 'auto', display: 'block' });
|
const imgStyle = cssPropsToString({ width: props.logoWidth || '120px', height: 'auto', display: 'block' });
|
||||||
logoHtml = `<a href="${escapeAttr(safeUrl(logoUrl))}" style="text-decoration:none;display:flex;align-items:center;flex-shrink:0"><img src="${escapeAttr(safeUrl(props.logoImage))}" alt="${escapeAttr(props.logoText || 'Logo')}"${imgStyle ? ` style="${imgStyle}"` : ''} /></a>`;
|
logoHtml = `<a href="${escapeAttr(safeUrl(logoUrl))}" style="text-decoration:none;display:flex;align-items:center;flex-shrink:0"><img src="${escapeAttr(safeImageUrl(props.logoImage))}" alt="${escapeAttr(props.logoText || 'Logo')}"${imgStyle ? ` style="${imgStyle}"` : ''} /></a>`;
|
||||||
} else {
|
} else {
|
||||||
const logoStyle = cssPropsToString({
|
const logoStyle = cssPropsToString({
|
||||||
fontWeight: '700',
|
fontWeight: '700',
|
||||||
@@ -272,21 +285,23 @@ Navbar.craft = {
|
|||||||
// via aria-expanded, kept in sync with the .navbar-open class by the
|
// via aria-expanded, kept in sync with the .navbar-open class by the
|
||||||
// inline onclick handler.
|
// inline onclick handler.
|
||||||
const hamburgerHtml = mobile
|
const hamburgerHtml = mobile
|
||||||
? `\n <button class="navbar-hamburger" aria-label="Toggle navigation menu" aria-expanded="false" aria-controls="navbar-links" onclick="var m=this.parentElement.querySelector('.navbar-links');var open=m.classList.toggle('navbar-open');this.setAttribute('aria-expanded', open ? 'true' : 'false');" style="display:none;background:none;border:none;cursor:pointer;padding:4px;flex-direction:column;gap:4px">
|
? `\n <button class="navbar-hamburger" aria-label="Toggle navigation menu" aria-expanded="false" aria-controls="${escapeAttr(linksId)}" onclick="var m=document.getElementById('${linksId}');var open=m.classList.toggle('navbar-open');this.setAttribute('aria-expanded', open ? 'true' : 'false');" style="display:none;background:none;border:none;cursor:pointer;padding:4px;flex-direction:column;gap:4px">
|
||||||
<span style="display:block;width:24px;height:2px;background-color:${escapeAttr(textCol)}"></span>
|
<span style="display:block;width:24px;height:2px;background-color:${escapeAttr(textCol)}"></span>
|
||||||
<span style="display:block;width:24px;height:2px;background-color:${escapeAttr(textCol)}"></span>
|
<span style="display:block;width:24px;height:2px;background-color:${escapeAttr(textCol)}"></span>
|
||||||
<span style="display:block;width:24px;height:2px;background-color:${escapeAttr(textCol)}"></span>
|
<span style="display:block;width:24px;height:2px;background-color:${escapeAttr(textCol)}"></span>
|
||||||
</button>`
|
</button>`
|
||||||
: '';
|
: '';
|
||||||
|
|
||||||
// Hover CSS
|
// Hover CSS -- scoped under `.${scope}` (a class on the <nav> root, added
|
||||||
|
// below) so it can only ever match THIS instance's links/CTA, never bleed
|
||||||
|
// into or get overridden by another Navbar instance's rules.
|
||||||
const hoverCss = `<style>
|
const hoverCss = `<style>
|
||||||
.navbar-link:hover { color: ${hoverCol} !important; }
|
.${scope} .navbar-link:hover { color: ${hoverCol} !important; }
|
||||||
.navbar-cta:hover { filter: brightness(1.1); }${mobile ? `
|
.${scope} .navbar-cta:hover { filter: brightness(1.1); }${mobile ? `
|
||||||
@media (max-width: 768px) {
|
@media (max-width: 768px) {
|
||||||
.navbar-hamburger { display: flex !important; }
|
.${scope} .navbar-hamburger { display: flex !important; }
|
||||||
.navbar-links { display: none !important; position: absolute; top: 100%; left: 0; right: 0; flex-direction: column !important; background-color: ${bgColor}; padding: 12px 24px; gap: 12px !important; box-shadow: 0 4px 12px rgba(0,0,0,0.1); }
|
.${scope} .navbar-links { display: none !important; position: absolute; top: 100%; left: 0; right: 0; flex-direction: column !important; background-color: ${bgColor}; padding: 12px 24px; gap: 12px !important; box-shadow: 0 4px 12px rgba(0,0,0,0.1); }
|
||||||
.navbar-links.navbar-open { display: flex !important; }
|
.${scope} .navbar-links.navbar-open { display: flex !important; }
|
||||||
}` : ''}
|
}` : ''}
|
||||||
</style>`;
|
</style>`;
|
||||||
|
|
||||||
@@ -309,9 +324,9 @@ Navbar.craft = {
|
|||||||
|
|
||||||
return {
|
return {
|
||||||
html: `${hoverCss}
|
html: `${hoverCss}
|
||||||
<nav${navStyle ? ` style="${navStyle}${mobile ? ';position:relative' : ''}"` : ''}>
|
<nav class="${scope}"${navStyle ? ` style="${navStyle}${mobile ? ';position:relative' : ''}"` : ''}>
|
||||||
${logoHtml}${hamburgerHtml}
|
${logoHtml}${hamburgerHtml}
|
||||||
<div class="navbar-links" id="navbar-links" style="display:flex;align-items:center;gap:24px">
|
<div class="navbar-links" id="${linksId}" style="display:flex;align-items:center;gap:24px">
|
||||||
${linksHtmlWithClass}
|
${linksHtmlWithClass}
|
||||||
</div>
|
</div>
|
||||||
</nav>`,
|
</nav>`,
|
||||||
|
|||||||
@@ -0,0 +1,62 @@
|
|||||||
|
import { describe, test, expect, vi, beforeEach } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
|
||||||
|
/* ImageBlock only needs useNode from @craftjs/core. Mock it following the
|
||||||
|
DOM-harness pattern in src/components/basic/Footer.editguard.test.tsx (no
|
||||||
|
@testing-library/react in this repo) so we can render the real component
|
||||||
|
tree and inspect the emitted <img src> without a real <Editor>. */
|
||||||
|
vi.mock('@craftjs/core', () => ({
|
||||||
|
useNode: (collect?: (node: any) => any) => {
|
||||||
|
const node = { events: { selected: false } };
|
||||||
|
return {
|
||||||
|
connectors: { connect: (el: any) => el, drag: (el: any) => el },
|
||||||
|
actions: { setProp: vi.fn() },
|
||||||
|
...(collect ? collect(node) : {}),
|
||||||
|
};
|
||||||
|
},
|
||||||
|
}));
|
||||||
|
|
||||||
|
import { ImageBlock } from './ImageBlock';
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
|
||||||
|
function render(ui: React.ReactElement) {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(ui);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
vi.clearAllMocks();
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('ImageBlock render falls back to the placeholder for an explicit empty src (Bug 1)', () => {
|
||||||
|
test('src="" (explicit, overrides the default parameter) still renders a non-empty placeholder src', () => {
|
||||||
|
render(<ImageBlock src="" alt="Image" />);
|
||||||
|
const img = container.querySelector('img')!;
|
||||||
|
expect(img.getAttribute('src')).not.toBe('');
|
||||||
|
expect(img.getAttribute('src')).toMatch(/^data:image\/svg\+xml/);
|
||||||
|
container.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('src=undefined (default parameter path) still renders the placeholder (unchanged behavior)', () => {
|
||||||
|
render(<ImageBlock alt="Image" />);
|
||||||
|
const img = container.querySelector('img')!;
|
||||||
|
expect(img.getAttribute('src')).not.toBe('');
|
||||||
|
expect(img.getAttribute('src')).toMatch(/^data:image\/svg\+xml/);
|
||||||
|
container.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a real src is rendered unchanged', () => {
|
||||||
|
render(<ImageBlock src="https://example.com/photo.jpg" alt="A photo" />);
|
||||||
|
const img = container.querySelector('img')!;
|
||||||
|
expect(img.getAttribute('src')).toBe('https://example.com/photo.jpg');
|
||||||
|
container.remove();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -1,9 +1,9 @@
|
|||||||
import React, { CSSProperties, useCallback, useRef } from 'react';
|
import React, { CSSProperties, useCallback, useRef } from 'react';
|
||||||
import { useNode, UserComponent } from '@craftjs/core';
|
import { useNode, UserComponent } from '@craftjs/core';
|
||||||
import { cssPropsToString } from '../../utils/style-helpers';
|
import { cssPropsToString } from '../../utils/style-helpers';
|
||||||
import { escapeAttr, safeUrl } from '../../utils/escape';
|
import { escapeAttr, safeImageUrl } from '../../utils/escape';
|
||||||
|
|
||||||
const PLACEHOLDER_SRC = "data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='400' height='300'%3E%3Cdefs%3E%3ClinearGradient id='bg' x1='0' y1='0' x2='0' y2='1'%3E%3Cstop offset='0%25' stop-color='%23f1f5f9'/%3E%3Cstop offset='100%25' stop-color='%23e2e8f0'/%3E%3C/linearGradient%3E%3C/defs%3E%3Crect fill='url(%23bg)' width='400' height='300' rx='12'/%3E%3Crect x='2' y='2' width='396' height='296' rx='10' fill='none' stroke='%23cbd5e1' stroke-width='2' stroke-dasharray='8 4'/%3E%3Cg transform='translate(200,110)'%3E%3Crect x='-28' y='-28' width='56' height='56' rx='12' fill='%23cbd5e1' opacity='0.5'/%3E%3Cpath d='M-12 8 L-4 -2 L2 4 L8 -6 L16 8Z' fill='%2394a3b8'/%3E%3Ccircle cx='-6' cy='-10' r='5' fill='%2394a3b8'/%3E%3C/g%3E%3Ctext x='200' y='160' text-anchor='middle' fill='%2364748b' font-family='Inter,sans-serif' font-size='15' font-weight='500'%3EDrop image here%3C/text%3E%3Ctext x='200' y='182' text-anchor='middle' fill='%2394a3b8' font-family='Inter,sans-serif' font-size='12'%3Eor click to upload%3C/text%3E%3C/svg%3E";
|
export const PLACEHOLDER_SRC = "data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='400' height='300'%3E%3Cdefs%3E%3ClinearGradient id='bg' x1='0' y1='0' x2='0' y2='1'%3E%3Cstop offset='0%25' stop-color='%23f1f5f9'/%3E%3Cstop offset='100%25' stop-color='%23e2e8f0'/%3E%3C/linearGradient%3E%3C/defs%3E%3Crect fill='url(%23bg)' width='400' height='300' rx='12'/%3E%3Crect x='2' y='2' width='396' height='296' rx='10' fill='none' stroke='%23cbd5e1' stroke-width='2' stroke-dasharray='8 4'/%3E%3Cg transform='translate(200,110)'%3E%3Crect x='-28' y='-28' width='56' height='56' rx='12' fill='%23cbd5e1' opacity='0.5'/%3E%3Cpath d='M-12 8 L-4 -2 L2 4 L8 -6 L16 8Z' fill='%2394a3b8'/%3E%3Ccircle cx='-6' cy='-10' r='5' fill='%2394a3b8'/%3E%3C/g%3E%3Ctext x='200' y='160' text-anchor='middle' fill='%2364748b' font-family='Inter,sans-serif' font-size='15' font-weight='500'%3EDrop image here%3C/text%3E%3Ctext x='200' y='182' text-anchor='middle' fill='%2394a3b8' font-family='Inter,sans-serif' font-size='12'%3Eor click to upload%3C/text%3E%3C/svg%3E";
|
||||||
|
|
||||||
interface ImageBlockProps {
|
interface ImageBlockProps {
|
||||||
src?: string;
|
src?: string;
|
||||||
@@ -66,7 +66,7 @@ export const ImageBlock: UserComponent<ImageBlockProps> = ({
|
|||||||
imgRef.current = ref;
|
imgRef.current = ref;
|
||||||
if (ref) connect(drag(ref));
|
if (ref) connect(drag(ref));
|
||||||
}}
|
}}
|
||||||
src={src}
|
src={src || PLACEHOLDER_SRC}
|
||||||
alt={alt || 'Image'}
|
alt={alt || 'Image'}
|
||||||
onDrop={handleDrop}
|
onDrop={handleDrop}
|
||||||
onDragOver={handleDragOver}
|
onDragOver={handleDragOver}
|
||||||
@@ -95,5 +95,5 @@ ImageBlock.craft = {
|
|||||||
}
|
}
|
||||||
const s = cssPropsToString({ display: 'block', maxWidth: '100%', ...props.style });
|
const s = cssPropsToString({ display: 'block', maxWidth: '100%', ...props.style });
|
||||||
const alt = props.alt ? ` alt="${escapeAttr(props.alt)}"` : ' alt=""';
|
const alt = props.alt ? ` alt="${escapeAttr(props.alt)}"` : ' alt=""';
|
||||||
return { html: `<img src="${escapeAttr(safeUrl(src))}"${alt}${s ? ` style="${s}"` : ''} />` };
|
return { html: `<img src="${escapeAttr(safeImageUrl(src))}"${alt}${s ? ` style="${s}"` : ''} />` };
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -109,6 +109,15 @@ describe('ContentSlider.toHtml renders slide.imageSrc as a background-image (INT
|
|||||||
expect(html).not.toContain('background-image:url(');
|
expect(html).not.toContain('background-image:url(');
|
||||||
expect(html).toContain('background-color:#123456');
|
expect(html).toContain('background-color:#123456');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('a slide with a data:image/svg+xml imageSrc exports a non-empty background-image url (safeImageUrl, not safeUrl)', () => {
|
||||||
|
const svgDataUri = 'data:image/svg+xml,%3Csvg%2F%3E';
|
||||||
|
const slidesWithSvg = [
|
||||||
|
{ type: 'image' as const, imageSrc: svgDataUri, heading: 'One' },
|
||||||
|
];
|
||||||
|
const { html } = toHtml({ slides: slidesWithSvg }, '');
|
||||||
|
expect(html).toContain(`background-image:url('${svgDataUri}')`);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('ContentSlider.toHtml interval is NOT runtime-type-checked -- must be coerced before it reaches the inline <script> numeric context', () => {
|
describe('ContentSlider.toHtml interval is NOT runtime-type-checked -- must be coerced before it reaches the inline <script> numeric context', () => {
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
import React, { CSSProperties, useState, useEffect, useRef, useCallback } from 'react';
|
import React, { CSSProperties, useState, useEffect, useRef, useCallback } from 'react';
|
||||||
import { useNode, UserComponent } from '@craftjs/core';
|
import { useNode, UserComponent } from '@craftjs/core';
|
||||||
import { cssPropsToString } from '../../utils/style-helpers';
|
import { cssPropsToString } from '../../utils/style-helpers';
|
||||||
import { escapeHtml, escapeAttr, safeUrl, scopeId, cssValue } from '../../utils/escape';
|
import { escapeHtml, escapeAttr, safeUrl, safeImageUrl, scopeId, cssValue } from '../../utils/escape';
|
||||||
|
|
||||||
interface Slide {
|
interface Slide {
|
||||||
type: 'image' | 'content';
|
type: 'image' | 'content';
|
||||||
@@ -283,7 +283,7 @@ ContentSlider.craft = {
|
|||||||
// sink (a malicious value could break out of the style="..." attribute).
|
// sink (a malicious value could break out of the style="..." attribute).
|
||||||
const safeBgColor = cssValue(slide.bgColor) || '#3b82f6';
|
const safeBgColor = cssValue(slide.bgColor) || '#3b82f6';
|
||||||
const bgStyle = hasBgImage
|
const bgStyle = hasBgImage
|
||||||
? `background-image:url('${escapeAttr(safeUrl(slide.imageSrc!))}');background-size:cover;background-position:center`
|
? `background-image:url('${escapeAttr(safeImageUrl(slide.imageSrc!))}');background-size:cover;background-position:center`
|
||||||
: slide.bgColor?.startsWith('linear-gradient')
|
: slide.bgColor?.startsWith('linear-gradient')
|
||||||
? `background-image:${safeBgColor}`
|
? `background-image:${safeBgColor}`
|
||||||
: `background-color:${safeBgColor}`;
|
: `background-color:${safeBgColor}`;
|
||||||
|
|||||||
@@ -0,0 +1,23 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import { FeaturesGrid } from './FeaturesGrid';
|
||||||
|
|
||||||
|
const toHtml = (FeaturesGrid as any).toHtml;
|
||||||
|
|
||||||
|
describe('FeaturesGrid.toHtml image sink uses safeImageUrl (data:image/svg+xml allowed)', () => {
|
||||||
|
test('feat.image as a data:image/svg+xml value emits a non-empty <img src>', () => {
|
||||||
|
const svgDataUri = 'data:image/svg+xml,%3Csvg%2F%3E';
|
||||||
|
const features = [
|
||||||
|
{ title: 'Feature', description: 'Desc', icon: '⚡', image: svgDataUri, imageAlt: 'alt' },
|
||||||
|
];
|
||||||
|
const { html } = toHtml({ features }, '');
|
||||||
|
expect(html).toContain(`<img src="${svgDataUri}"`);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('feat.buttonUrl stays on safeUrl (data:image/svg+xml blocked as a navigation target)', () => {
|
||||||
|
const features = [
|
||||||
|
{ title: 'Feature', description: 'Desc', icon: '⚡', buttonText: 'Go', buttonUrl: 'data:image/svg+xml,<svg onload=alert(1)>' },
|
||||||
|
];
|
||||||
|
const { html } = toHtml({ features }, '');
|
||||||
|
expect(html).toMatch(/<a href=""/);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -1,7 +1,7 @@
|
|||||||
import React, { CSSProperties } from 'react';
|
import React, { CSSProperties } from 'react';
|
||||||
import { useNode, UserComponent } from '@craftjs/core';
|
import { useNode, UserComponent } from '@craftjs/core';
|
||||||
import { cssPropsToString } from '../../utils/style-helpers';
|
import { cssPropsToString } from '../../utils/style-helpers';
|
||||||
import { escapeHtml, escapeAttr, safeUrl } from '../../utils/escape';
|
import { escapeHtml, escapeAttr, safeUrl, safeImageUrl } from '../../utils/escape';
|
||||||
|
|
||||||
interface FeatureItem {
|
interface FeatureItem {
|
||||||
title: string;
|
title: string;
|
||||||
@@ -116,7 +116,7 @@ FeaturesGrid.craft = {
|
|||||||
const idAttr = props.anchorId ? ` id="${escapeAttr(props.anchorId)}"` : '';
|
const idAttr = props.anchorId ? ` id="${escapeAttr(props.anchorId)}"` : '';
|
||||||
const cards = (props.features || defaultFeatures).map((feat) => {
|
const cards = (props.features || defaultFeatures).map((feat) => {
|
||||||
const media = feat.image
|
const media = feat.image
|
||||||
? `<img src="${escapeAttr(safeUrl(feat.image))}" alt="${escapeAttr(feat.imageAlt || feat.title || '')}" style="max-width:100%;height:auto;margin-bottom:16px;border-radius:8px">`
|
? `<img src="${escapeAttr(safeImageUrl(feat.image))}" alt="${escapeAttr(feat.imageAlt || feat.title || '')}" style="max-width:100%;height:auto;margin-bottom:16px;border-radius:8px">`
|
||||||
: `<div style="font-size:36px;margin-bottom:16px">${escapeHtml(feat.icon)}</div>`;
|
: `<div style="font-size:36px;margin-bottom:16px">${escapeHtml(feat.icon)}</div>`;
|
||||||
const button = feat.buttonText
|
const button = feat.buttonText
|
||||||
? `\n <a href="${escapeAttr(safeUrl(feat.buttonUrl || '#'))}" style="display:inline-block;margin-top:16px;padding:10px 24px;background:#3b82f6;color:#fff;border-radius:8px;text-decoration:none;font-size:14px;font-weight:600">${escapeHtml(feat.buttonText)}</a>`
|
? `\n <a href="${escapeAttr(safeUrl(feat.buttonUrl || '#'))}" style="display:inline-block;margin-top:16px;padding:10px 24px;background:#3b82f6;color:#fff;border-radius:8px;text-decoration:none;font-size:14px;font-weight:600">${escapeHtml(feat.buttonText)}</a>`
|
||||||
|
|||||||
@@ -93,3 +93,59 @@ describe('Gallery.toHtml deterministic + unique scope ids (thread node id, no Ma
|
|||||||
expect(html1).toBe(html2);
|
expect(html1).toBe(html2);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('Gallery.toHtml default SVG placeholder images survive export (Bug 2 regression)', () => {
|
||||||
|
test('a default data:image/svg+xml image emits a non-empty img src, not src=""', () => {
|
||||||
|
const { html } = toHtml({}, ''); // no images prop -> component default SVG placeholders
|
||||||
|
expect(html).not.toContain('src=""');
|
||||||
|
expect(html).toMatch(/src="data:image\/svg\+xml[^"]*"/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('an explicit data:image/svg+xml gallery image src is preserved (not stripped to empty)', () => {
|
||||||
|
const svg = 'data:image/svg+xml,%3Csvg%2F%3E';
|
||||||
|
const { html } = toHtml({ images: [{ src: svg, alt: 'a' }] }, '');
|
||||||
|
expect(html).toContain(`src="${svg}"`);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('lightbox data-lb-src also preserves data:image/svg+xml (still an image context)', () => {
|
||||||
|
const svg = 'data:image/svg+xml,%3Csvg%2F%3E';
|
||||||
|
const { html } = toHtml({ images: [{ src: svg, alt: 'a' }], lightbox: true }, '');
|
||||||
|
expect(html).toContain(`data-lb-src="${svg}"`);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a javascript: gallery image src still yields an empty src (safeImageUrl still blocks it)', () => {
|
||||||
|
const { html } = toHtml({ images: [{ src: 'javascript:alert(1)', alt: 'a' }] }, '');
|
||||||
|
expect(html).toContain('src=""');
|
||||||
|
expect(html).not.toContain('javascript:');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Gallery.toHtml lightbox focus management (M-2)', () => {
|
||||||
|
const props = { images: [{ src: '/a.jpg', alt: 'a' }], lightbox: true };
|
||||||
|
|
||||||
|
test('overlay includes a focusable close control with an accessible name and tabindex', () => {
|
||||||
|
const { html } = toHtml(props, '', 'node-gal1');
|
||||||
|
// A close control: a button (or the dialog container) with an accessible
|
||||||
|
// name (aria-label) and an explicit tabindex so it's keyboard-focusable.
|
||||||
|
expect(html).toMatch(/aria-label="[^"]*[Cc]lose[^"]*"[^>]*tabindex="-?\d+"|tabindex="-?\d+"[^>]*aria-label="[^"]*[Cc]lose[^"]*"/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('script saves document.activeElement on open (for focus restore)', () => {
|
||||||
|
const { html } = toHtml(props, '', 'node-gal1');
|
||||||
|
expect(html).toMatch(/document\.activeElement/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('script moves focus to the close control / dialog on open', () => {
|
||||||
|
const { html } = toHtml(props, '', 'node-gal1');
|
||||||
|
expect(html).toMatch(/\.focus\(\)/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('script restores the previously-saved focus on close', () => {
|
||||||
|
const { html } = toHtml(props, '', 'node-gal1');
|
||||||
|
// The close function references a stored "last focused element" variable
|
||||||
|
// and calls .focus() on it, not just moving focus INTO the dialog.
|
||||||
|
const closeFnMatch = html.match(/function\s+\w+_close\s*\(\)\s*\{[^}]*\}/);
|
||||||
|
expect(closeFnMatch).not.toBeNull();
|
||||||
|
expect(closeFnMatch![0]).toMatch(/\.focus\(\)/);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
import React, { CSSProperties } from 'react';
|
import React, { CSSProperties } from 'react';
|
||||||
import { useNode, UserComponent } from '@craftjs/core';
|
import { useNode, UserComponent } from '@craftjs/core';
|
||||||
import { cssPropsToString } from '../../utils/style-helpers';
|
import { cssPropsToString } from '../../utils/style-helpers';
|
||||||
import { escapeHtml, escapeAttr, safeUrl, scopeId, cssValue } from '../../utils/escape';
|
import { escapeHtml, escapeAttr, safeImageUrl, scopeId, cssValue } from '../../utils/escape';
|
||||||
|
|
||||||
interface GalleryImage {
|
interface GalleryImage {
|
||||||
src: string;
|
src: string;
|
||||||
@@ -154,10 +154,10 @@ Gallery.craft = {
|
|||||||
// inline onclick with an interpolated src -- a single delegated click
|
// inline onclick with an interpolated src -- a single delegated click
|
||||||
// listener below reads it, so a src containing a quote can't break out
|
// listener below reads it, so a src containing a quote can't break out
|
||||||
// of a per-item event-handler string.
|
// of a per-item event-handler string.
|
||||||
const lbAttr = lightbox ? ` data-lb-src="${escapeAttr(safeUrl(img.src || ''))}" role="button" tabindex="0"` : '';
|
const lbAttr = lightbox ? ` data-lb-src="${escapeAttr(safeImageUrl(img.src || ''))}" role="button" tabindex="0"` : '';
|
||||||
const itemStyle = lightbox ? 'cursor:pointer;position:relative;overflow:hidden;border-radius:8px' : 'position:relative;overflow:hidden;border-radius:8px';
|
const itemStyle = lightbox ? 'cursor:pointer;position:relative;overflow:hidden;border-radius:8px' : 'position:relative;overflow:hidden;border-radius:8px';
|
||||||
return `<div${lbAttr} style="${itemStyle}">
|
return `<div${lbAttr} style="${itemStyle}">
|
||||||
<img src="${escapeAttr(safeUrl(img.src || ''))}" alt="${escapeAttr(img.alt)}" style="width:100%;height:200px;object-fit:cover;display:block;border-radius:8px;background-color:#f1f5f9" />
|
<img src="${escapeAttr(safeImageUrl(img.src || ''))}" alt="${escapeAttr(img.alt)}" style="width:100%;height:200px;object-fit:cover;display:block;border-radius:8px;background-color:#f1f5f9" />
|
||||||
${caption}
|
${caption}
|
||||||
</div>`;
|
</div>`;
|
||||||
}).join('\n ');
|
}).join('\n ');
|
||||||
@@ -166,16 +166,37 @@ Gallery.craft = {
|
|||||||
let gridIdAttr = '';
|
let gridIdAttr = '';
|
||||||
if (lightbox) {
|
if (lightbox) {
|
||||||
gridIdAttr = ` id="${galleryId}_grid"`;
|
gridIdAttr = ` id="${galleryId}_grid"`;
|
||||||
|
// M-2: focus management for the lightbox dialog.
|
||||||
|
// - OPEN: stash `document.activeElement` (the thumbnail that triggered
|
||||||
|
// the open) in a module-scoped var, then move focus onto the close
|
||||||
|
// button -- so a screen-reader/keyboard user lands inside the dialog
|
||||||
|
// instead of focus staying on (or silently falling back to <body>)
|
||||||
|
// behind the now-visible overlay.
|
||||||
|
// - Tab trap: while the overlay is open, every Tab keypress is
|
||||||
|
// intercepted and refocuses the close button (the dialog's only
|
||||||
|
// focusable control besides Escape/click-to-close), so focus can
|
||||||
|
// never wander out into the page content hidden behind the overlay.
|
||||||
|
// - CLOSE (Escape, backdrop click, or the close button): restore focus
|
||||||
|
// to the element stashed on open.
|
||||||
lightboxHtml = `
|
lightboxHtml = `
|
||||||
<div id="${galleryId}_overlay" role="dialog" aria-modal="true" aria-label="Image preview" onclick="${galleryId}_close()" style="display:none;position:fixed;top:0;left:0;width:100%;height:100%;background:rgba(0,0,0,0.9);z-index:9999;justify-content:center;align-items:center;cursor:pointer">
|
<div id="${galleryId}_overlay" role="dialog" aria-modal="true" aria-label="Image preview" onclick="${galleryId}_close()" style="display:none;position:fixed;top:0;left:0;width:100%;height:100%;background:rgba(0,0,0,0.9);z-index:9999;justify-content:center;align-items:center;cursor:pointer">
|
||||||
|
<button type="button" id="${galleryId}_closebtn" aria-label="Close preview" tabindex="-1" onclick="event.stopPropagation();${galleryId}_close()" style="position:absolute;top:16px;right:16px;width:36px;height:36px;border-radius:50%;border:none;background:rgba(255,255,255,0.15);color:#ffffff;font-size:20px;line-height:1;cursor:pointer;display:flex;align-items:center;justify-content:center">×</button>
|
||||||
<img id="${galleryId}_img" src="" alt="" style="max-width:90%;max-height:90%;object-fit:contain;border-radius:8px" />
|
<img id="${galleryId}_img" src="" alt="" style="max-width:90%;max-height:90%;object-fit:contain;border-radius:8px" />
|
||||||
</div>
|
</div>
|
||||||
<script>
|
<script>
|
||||||
function ${galleryId}_close(){document.getElementById('${galleryId}_overlay').style.display='none';}
|
var ${galleryId}_lastFocus = null;
|
||||||
|
function ${galleryId}_close(){
|
||||||
|
document.getElementById('${galleryId}_overlay').style.display='none';
|
||||||
|
if(${galleryId}_lastFocus && ${galleryId}_lastFocus.focus) ${galleryId}_lastFocus.focus();
|
||||||
|
${galleryId}_lastFocus = null;
|
||||||
|
}
|
||||||
function ${galleryId}_open(src){
|
function ${galleryId}_open(src){
|
||||||
|
${galleryId}_lastFocus = document.activeElement;
|
||||||
var o = document.getElementById('${galleryId}_overlay');
|
var o = document.getElementById('${galleryId}_overlay');
|
||||||
document.getElementById('${galleryId}_img').src = src;
|
document.getElementById('${galleryId}_img').src = src;
|
||||||
o.style.display = 'flex';
|
o.style.display = 'flex';
|
||||||
|
var c = document.getElementById('${galleryId}_closebtn');
|
||||||
|
if(c) c.focus();
|
||||||
}
|
}
|
||||||
document.getElementById('${galleryId}_grid').addEventListener('click', function(e){
|
document.getElementById('${galleryId}_grid').addEventListener('click', function(e){
|
||||||
var t = e.target.closest('[data-lb-src]');
|
var t = e.target.closest('[data-lb-src]');
|
||||||
@@ -190,7 +211,14 @@ document.getElementById('${galleryId}_grid').addEventListener('keydown', functio
|
|||||||
${galleryId}_open(t.getAttribute('data-lb-src'));
|
${galleryId}_open(t.getAttribute('data-lb-src'));
|
||||||
});
|
});
|
||||||
document.addEventListener('keydown', function(e){
|
document.addEventListener('keydown', function(e){
|
||||||
if(e.key==='Escape'){ ${galleryId}_close(); }
|
var o = document.getElementById('${galleryId}_overlay');
|
||||||
|
if(!o || o.style.display==='none') return;
|
||||||
|
if(e.key==='Escape'){ ${galleryId}_close(); return; }
|
||||||
|
if(e.key==='Tab'){
|
||||||
|
e.preventDefault();
|
||||||
|
var c = document.getElementById('${galleryId}_closebtn');
|
||||||
|
if(c) c.focus();
|
||||||
|
}
|
||||||
});
|
});
|
||||||
</script>`;
|
</script>`;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,13 +1,17 @@
|
|||||||
import React, { useMemo, useRef, useEffect } from 'react';
|
import React, { useMemo, useRef, useEffect } from 'react';
|
||||||
import { Frame, Element } from '@craftjs/core';
|
import { Frame, Element, useEditor } from '@craftjs/core';
|
||||||
import { Container } from '../components/layout/Container';
|
import { Container } from '../components/layout/Container';
|
||||||
import { usePages } from '../state/PageContext';
|
import { usePages } from '../state/PageContext';
|
||||||
import { DeviceMode } from '../types';
|
import { DeviceMode } from '../types';
|
||||||
import { DEVICE_WIDTHS } from '../constants/presets';
|
import { DEVICE_WIDTHS } from '../constants/presets';
|
||||||
import { exportBodyHtml } from '../utils/html-export';
|
import { exportBodyHtml } from '../utils/html-export';
|
||||||
|
import { useIsMobile } from '../hooks/useIsMobile';
|
||||||
|
import { useMobileChrome } from '../state/MobileChromeContext';
|
||||||
|
|
||||||
interface CanvasProps {
|
interface CanvasProps {
|
||||||
device: DeviceMode;
|
device: DeviceMode;
|
||||||
|
/** Item 10: when false, applies `.guides-off` to hide the dashed drop-target guides. */
|
||||||
|
showGuides: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -81,24 +85,93 @@ const ZonePreview: React.FC<{ craftState: string | null; zone: 'header' | 'foote
|
|||||||
<div
|
<div
|
||||||
ref={containerRef}
|
ref={containerRef}
|
||||||
data-zone-preview={zone}
|
data-zone-preview={zone}
|
||||||
|
className="zone-preview-sep"
|
||||||
style={{
|
style={{
|
||||||
width: '100%',
|
width: '100%',
|
||||||
position: 'relative',
|
position: 'relative',
|
||||||
pointerEvents: 'none',
|
pointerEvents: 'none',
|
||||||
userSelect: 'none',
|
userSelect: 'none',
|
||||||
borderBottom: zone === 'header' ? '1px dashed rgba(245,158,11,0.3)' : 'none',
|
borderBottom: zone === 'header' ? '1px dashed rgba(148,163,184,0.25)' : 'none',
|
||||||
borderTop: zone === 'footer' ? '1px dashed rgba(245,158,11,0.3)' : 'none',
|
borderTop: zone === 'footer' ? '1px dashed rgba(148,163,184,0.25)' : 'none',
|
||||||
}}
|
}}
|
||||||
/>
|
/>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
export const Canvas: React.FC<CanvasProps> = ({ device }) => {
|
/**
|
||||||
|
* First-run hint shown over the canvas drop area once the current page's
|
||||||
|
* root node exists and has no children yet. Hidden the instant something
|
||||||
|
* is dropped in, and while a drag is in progress (so it never fights the
|
||||||
|
* drop-target UI). `pointer-events: none` (see .empty-canvas-hint in
|
||||||
|
* editor.css) keeps it from intercepting clicks/drops meant for the
|
||||||
|
* underlying empty canvas.
|
||||||
|
*/
|
||||||
|
export const EmptyCanvasHint: React.FC = () => {
|
||||||
|
const { isEmpty, isDragging } = useEditor((state) => {
|
||||||
|
const root = state.nodes['ROOT'];
|
||||||
|
return {
|
||||||
|
isEmpty: !!root && root.data.nodes.length === 0,
|
||||||
|
isDragging: state.events.dragged.size > 0,
|
||||||
|
};
|
||||||
|
});
|
||||||
|
const isMobile = useIsMobile();
|
||||||
|
|
||||||
|
if (!isEmpty || isDragging) return null;
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div className="empty-canvas-hint">
|
||||||
|
<i className="fa fa-cubes" aria-hidden />
|
||||||
|
<span>
|
||||||
|
{isMobile
|
||||||
|
? <>Tap <strong>Blocks</strong> below to add content, or pick a Template to start.</>
|
||||||
|
: 'Drag blocks from the left panel, or pick a Template to start.'}
|
||||||
|
</span>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
export const Canvas: React.FC<CanvasProps> = ({ device, showGuides }) => {
|
||||||
const width = DEVICE_WIDTHS[device];
|
const width = DEVICE_WIDTHS[device];
|
||||||
const { isEditingHeader, isEditingFooter, headerPage, footerPage } = usePages();
|
const { isEditingHeader, isEditingFooter, headerPage, footerPage } = usePages();
|
||||||
|
|
||||||
const isEditingRegularPage = !isEditingHeader && !isEditingFooter;
|
const isEditingRegularPage = !isEditingHeader && !isEditingFooter;
|
||||||
|
|
||||||
|
// Fast-follow item 4: while `MobileSelectionToolbar` is up (fixed, ~53px
|
||||||
|
// tall, just above the tab bar), it covers whatever content was at the
|
||||||
|
// very bottom of the canvas's own scroll area -- on a short page, the
|
||||||
|
// last section could sit permanently under the toolbar with no way to
|
||||||
|
// scroll past it. Mirrors that toolbar's own visibility condition
|
||||||
|
// (`selectedId && activeSheet === null`) exactly, computed independently
|
||||||
|
// here since Canvas has no other reason to depend on the toolbar
|
||||||
|
// component itself.
|
||||||
|
const isMobile = useIsMobile();
|
||||||
|
const { activeSheet } = useMobileChrome();
|
||||||
|
const { selectedId } = useEditor((state) => {
|
||||||
|
const selected = state.events.selected;
|
||||||
|
const id = selected && selected.size > 0 ? (Array.from(selected)[0] as string) : null;
|
||||||
|
return { selectedId: id && id !== 'ROOT' ? id : null };
|
||||||
|
});
|
||||||
|
const mobileToolbarVisible = isMobile && !!selectedId && activeSheet === null;
|
||||||
|
|
||||||
|
// Fast-follow item 3: `MobileSelectionToolbar`'s "Style" tap scrolls the
|
||||||
|
// selected node up towards the top of the canvas so it stays visible
|
||||||
|
// above the Styles sheet (~65dvh tall) -- but that scroll is still bound
|
||||||
|
// by the canvas's own natural scroll range. For a selected node near the
|
||||||
|
// END of the content (very plausibly the last section on the page --
|
||||||
|
// exactly the kind of node someone just added/duplicated and wants to
|
||||||
|
// style), there may not be enough scrollable distance below it to bring
|
||||||
|
// its top all the way up to the visible band above the sheet; the browser
|
||||||
|
// simply clamps at its existing max scrollTop, leaving the node's top
|
||||||
|
// stuck behind the sheet with nothing anyone can do about it (verified
|
||||||
|
// live: the last section of a page landed under the sheet even after the
|
||||||
|
// scroll-into-view ran). Pad the canvas with a full extra viewport's
|
||||||
|
// worth of scroll room while the sheet is open with a selection, exactly
|
||||||
|
// as `has-mobile-selection-toolbar` (item 4) already pads it for the
|
||||||
|
// fixed toolbar -- generous enough that ANY node, including the very
|
||||||
|
// last one, can always be scrolled with its top reaching the very top of
|
||||||
|
// the canvas (comfortably within the "top ~30%" target).
|
||||||
|
const mobileStylesSheetPad = isMobile && !!selectedId && activeSheet === 'styles';
|
||||||
|
|
||||||
const frameStyle = isEditingHeader
|
const frameStyle = isEditingHeader
|
||||||
? { minHeight: '60px', backgroundColor: '#ffffff', padding: '12px 24px', display: 'flex', alignItems: 'center' }
|
? { minHeight: '60px', backgroundColor: '#ffffff', padding: '12px 24px', display: 'flex', alignItems: 'center' }
|
||||||
: isEditingFooter
|
: isEditingFooter
|
||||||
@@ -108,9 +181,13 @@ export const Canvas: React.FC<CanvasProps> = ({ device }) => {
|
|||||||
const frameTag = isEditingHeader ? 'header' : isEditingFooter ? 'footer' : 'div';
|
const frameTag = isEditingHeader ? 'header' : isEditingFooter ? 'footer' : 'div';
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="editor-canvas">
|
|
||||||
<div
|
<div
|
||||||
className="canvas-device-frame"
|
className={`editor-canvas${mobileToolbarVisible ? ' has-mobile-selection-toolbar' : ''}${
|
||||||
|
mobileStylesSheetPad ? ' has-mobile-styles-sheet' : ''
|
||||||
|
}`}
|
||||||
|
>
|
||||||
|
<div
|
||||||
|
className={`canvas-device-frame${showGuides ? '' : ' guides-off'}`}
|
||||||
style={{
|
style={{
|
||||||
width,
|
width,
|
||||||
maxWidth: '100%',
|
maxWidth: '100%',
|
||||||
@@ -140,6 +217,7 @@ export const Canvas: React.FC<CanvasProps> = ({ device }) => {
|
|||||||
<ZonePreview craftState={headerPage.craftState} zone="header" />
|
<ZonePreview craftState={headerPage.craftState} zone="header" />
|
||||||
)}
|
)}
|
||||||
|
|
||||||
|
<div style={{ position: 'relative' }}>
|
||||||
<Frame>
|
<Frame>
|
||||||
<Element
|
<Element
|
||||||
is={Container}
|
is={Container}
|
||||||
@@ -148,6 +226,8 @@ export const Canvas: React.FC<CanvasProps> = ({ device }) => {
|
|||||||
style={frameStyle}
|
style={frameStyle}
|
||||||
/>
|
/>
|
||||||
</Frame>
|
</Frame>
|
||||||
|
{isEditingRegularPage && <EmptyCanvasHint />}
|
||||||
|
</div>
|
||||||
|
|
||||||
{isEditingRegularPage && (
|
{isEditingRegularPage && (
|
||||||
<ZonePreview craftState={footerPage.craftState} zone="footer" />
|
<ZonePreview craftState={footerPage.craftState} zone="footer" />
|
||||||
|
|||||||
@@ -1,16 +1,60 @@
|
|||||||
import React, { useState, useCallback } from 'react';
|
import React, { useState, useCallback, useEffect, useRef } from 'react';
|
||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import { TopBar } from '../panels/topbar/TopBar';
|
import { TopBar } from '../panels/topbar/TopBar';
|
||||||
import { LeftPanel } from '../panels/left/LeftPanel';
|
import { LeftPanel } from '../panels/left/LeftPanel';
|
||||||
import { RightPanel } from '../panels/right/RightPanel';
|
import { RightPanel } from '../panels/right/RightPanel';
|
||||||
|
import { MobilePanelBar } from '../panels/mobile/MobilePanelBar';
|
||||||
|
import { MobileSelectionToolbar } from '../panels/mobile/MobileSelectionToolbar';
|
||||||
import { Canvas } from './Canvas';
|
import { Canvas } from './Canvas';
|
||||||
import { ContextMenu } from '../panels/context-menu/ContextMenu';
|
import { ContextMenu } from '../panels/context-menu/ContextMenu';
|
||||||
import { useContextMenu } from '../hooks/useContextMenu';
|
import { useContextMenu } from '../hooks/useContextMenu';
|
||||||
import { useKeyboardShortcuts } from '../hooks/useKeyboardShortcuts';
|
import { useKeyboardShortcuts } from '../hooks/useKeyboardShortcuts';
|
||||||
|
import { useIsMobile } from '../hooks/useIsMobile';
|
||||||
|
import { MobileChromeProvider } from '../state/MobileChromeContext';
|
||||||
import { DeviceMode } from '../types';
|
import { DeviceMode } from '../types';
|
||||||
|
|
||||||
|
const SHOW_GUIDES_STORAGE_KEY = 'craft-show-guides';
|
||||||
|
|
||||||
|
function loadShowGuides(): boolean {
|
||||||
|
try {
|
||||||
|
const stored = window.localStorage.getItem(SHOW_GUIDES_STORAGE_KEY);
|
||||||
|
return stored === null ? true : stored === '1';
|
||||||
|
} catch {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
export const EditorShell: React.FC = () => {
|
export const EditorShell: React.FC = () => {
|
||||||
|
const isMobile = useIsMobile();
|
||||||
const [device, setDevice] = useState<DeviceMode>('desktop');
|
const [device, setDevice] = useState<DeviceMode>('desktop');
|
||||||
|
// Phase A: default the canvas to the "mobile" preview width the first
|
||||||
|
// time we detect a mobile viewport, so the frame fits without the user
|
||||||
|
// having to reach for the device switcher (now tucked in TopBar's
|
||||||
|
// overflow menu on mobile). Only fires once, and only if the device is
|
||||||
|
// still at its initial default -- it must not fight a device the user
|
||||||
|
// has already picked (e.g. from the overflow menu) on a later re-render.
|
||||||
|
const mobileDeviceAppliedRef = useRef(false);
|
||||||
|
useEffect(() => {
|
||||||
|
if (isMobile && !mobileDeviceAppliedRef.current) {
|
||||||
|
mobileDeviceAppliedRef.current = true;
|
||||||
|
setDevice((current) => (current === 'desktop' ? 'mobile' : current));
|
||||||
|
}
|
||||||
|
}, [isMobile]);
|
||||||
|
// Item 10: canvas dashed "guide" outlines toggle -- default ON, persisted
|
||||||
|
// so the choice survives a reload. Lifted here (rather than owned by
|
||||||
|
// TopBar or Canvas alone) because the toggle button lives in TopBar but
|
||||||
|
// the `.guides-off` class it drives is applied to Canvas's
|
||||||
|
// `.canvas-device-frame`, mirroring how `device` is already lifted for
|
||||||
|
// the same reason.
|
||||||
|
const [showGuides, setShowGuidesState] = useState<boolean>(loadShowGuides);
|
||||||
|
const setShowGuides = useCallback((next: boolean) => {
|
||||||
|
setShowGuidesState(next);
|
||||||
|
try {
|
||||||
|
window.localStorage.setItem(SHOW_GUIDES_STORAGE_KEY, next ? '1' : '0');
|
||||||
|
} catch {
|
||||||
|
// Storage unavailable (private browsing, etc.) -- in-memory state still works.
|
||||||
|
}
|
||||||
|
}, []);
|
||||||
const { menuState, show: showMenu, hide: hideMenu } = useContextMenu();
|
const { menuState, show: showMenu, hide: hideMenu } = useContextMenu();
|
||||||
const { query } = useEditor();
|
const { query } = useEditor();
|
||||||
|
|
||||||
@@ -33,15 +77,28 @@ export const EditorShell: React.FC = () => {
|
|||||||
}, [query, showMenu]);
|
}, [query, showMenu]);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
|
// Mobile-A2: shared sheet/modal-open state (see MobileChromeContext) --
|
||||||
|
// provided around the whole shell so TopBar's Templates/Head Code modal
|
||||||
|
// state and MobilePanelBar's sheet state live in one place. Desktop
|
||||||
|
// doesn't render MobilePanelBar and TopBar's desktop branch behaves
|
||||||
|
// identically to before (same booleans, just sourced from context).
|
||||||
|
<MobileChromeProvider>
|
||||||
<div className="editor-app">
|
<div className="editor-app">
|
||||||
<TopBar device={device} onDeviceChange={setDevice} />
|
<TopBar
|
||||||
|
device={device}
|
||||||
|
onDeviceChange={setDevice}
|
||||||
|
showGuides={showGuides}
|
||||||
|
onToggleGuides={() => setShowGuides(!showGuides)}
|
||||||
|
/>
|
||||||
<div className="editor-container">
|
<div className="editor-container">
|
||||||
<LeftPanel />
|
{!isMobile && <LeftPanel />}
|
||||||
<div onContextMenu={handleContextMenu} style={{ flex: 1, display: 'flex', minWidth: 0 }}>
|
<div onContextMenu={handleContextMenu} style={{ flex: 1, display: 'flex', minWidth: 0 }}>
|
||||||
<Canvas device={device} />
|
<Canvas device={device} showGuides={showGuides} />
|
||||||
</div>
|
</div>
|
||||||
<RightPanel />
|
{!isMobile && <RightPanel />}
|
||||||
</div>
|
</div>
|
||||||
|
{isMobile && <MobilePanelBar />}
|
||||||
|
{isMobile && <MobileSelectionToolbar />}
|
||||||
<ContextMenu
|
<ContextMenu
|
||||||
visible={menuState.visible}
|
visible={menuState.visible}
|
||||||
x={menuState.x}
|
x={menuState.x}
|
||||||
@@ -50,5 +107,6 @@ export const EditorShell: React.FC = () => {
|
|||||||
onClose={hideMenu}
|
onClose={hideMenu}
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
|
</MobileChromeProvider>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -0,0 +1,67 @@
|
|||||||
|
import { describe, test, expect, vi, beforeEach } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
|
||||||
|
/* Same DOM-harness pattern as Footer.editguard.test.tsx: mock @craftjs/core's
|
||||||
|
useEditor so we can drive editor state without a real <Editor> tree. */
|
||||||
|
let mockNodes: Record<string, { data: { nodes: string[] } }> = {};
|
||||||
|
let mockDraggedSize = 0;
|
||||||
|
|
||||||
|
vi.mock('@craftjs/core', () => ({
|
||||||
|
useEditor: (collect: (state: any) => any) =>
|
||||||
|
collect({
|
||||||
|
nodes: mockNodes,
|
||||||
|
events: { dragged: { size: mockDraggedSize } },
|
||||||
|
}),
|
||||||
|
}));
|
||||||
|
|
||||||
|
import { EmptyCanvasHint } from './Canvas';
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
|
||||||
|
function render(ui: React.ReactElement) {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(ui);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
mockNodes = {};
|
||||||
|
mockDraggedSize = 0;
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('EmptyCanvasHint', () => {
|
||||||
|
test('renders nothing before ROOT has mounted (no root node yet)', () => {
|
||||||
|
render(<EmptyCanvasHint />);
|
||||||
|
expect(container.querySelector('.empty-canvas-hint')).toBeNull();
|
||||||
|
container.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('renders the hint once ROOT exists with zero children', () => {
|
||||||
|
mockNodes = { ROOT: { data: { nodes: [] } } };
|
||||||
|
render(<EmptyCanvasHint />);
|
||||||
|
expect(container.querySelector('.empty-canvas-hint')).not.toBeNull();
|
||||||
|
expect(container.textContent).toContain('Drag blocks from the left panel');
|
||||||
|
container.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('hides once the page has content', () => {
|
||||||
|
mockNodes = { ROOT: { data: { nodes: ['node-1'] } } };
|
||||||
|
render(<EmptyCanvasHint />);
|
||||||
|
expect(container.querySelector('.empty-canvas-hint')).toBeNull();
|
||||||
|
container.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('hides while a drag is in progress, even on an empty root', () => {
|
||||||
|
mockNodes = { ROOT: { data: { nodes: [] } } };
|
||||||
|
mockDraggedSize = 1;
|
||||||
|
render(<EmptyCanvasHint />);
|
||||||
|
expect(container.querySelector('.empty-canvas-hint')).toBeNull();
|
||||||
|
container.remove();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,169 @@
|
|||||||
|
import { describe, test, expect, vi, beforeEach } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
|
||||||
|
/* Same DOM-harness pattern as Footer.editguard.test.tsx: mock @craftjs/core
|
||||||
|
so RenderNode (the <Editor onRender> override) can be driven without a
|
||||||
|
real Editor tree. document.body doubles as the portal target, same as
|
||||||
|
the component itself uses. */
|
||||||
|
let mockNode: {
|
||||||
|
id: string;
|
||||||
|
selected: boolean;
|
||||||
|
hovered: boolean;
|
||||||
|
dom: HTMLElement | null;
|
||||||
|
displayName: string;
|
||||||
|
parent: string | null;
|
||||||
|
isCanvas: boolean;
|
||||||
|
};
|
||||||
|
const selectNodeSpy = vi.fn();
|
||||||
|
|
||||||
|
vi.mock('@craftjs/core', () => ({
|
||||||
|
useEditor: () => ({ actions: { selectNode: selectNodeSpy } }),
|
||||||
|
useNode: (collect?: (node: any) => any) => {
|
||||||
|
const node = {
|
||||||
|
events: { selected: mockNode.selected, hovered: mockNode.hovered },
|
||||||
|
dom: mockNode.dom,
|
||||||
|
data: {
|
||||||
|
custom: {},
|
||||||
|
displayName: mockNode.displayName,
|
||||||
|
parent: mockNode.parent,
|
||||||
|
isCanvas: mockNode.isCanvas,
|
||||||
|
},
|
||||||
|
};
|
||||||
|
return { id: mockNode.id, ...(collect ? collect(node) : {}) };
|
||||||
|
},
|
||||||
|
}));
|
||||||
|
|
||||||
|
import { RenderNode } from './RenderNode';
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
let nodeDom: HTMLElement;
|
||||||
|
|
||||||
|
function render(ui: React.ReactElement) {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(ui);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
nodeDom = document.createElement('div');
|
||||||
|
document.body.appendChild(nodeDom);
|
||||||
|
mockNode = {
|
||||||
|
id: 'node-1',
|
||||||
|
selected: false,
|
||||||
|
hovered: false,
|
||||||
|
dom: nodeDom,
|
||||||
|
displayName: 'Heading',
|
||||||
|
parent: 'ROOT',
|
||||||
|
isCanvas: false,
|
||||||
|
};
|
||||||
|
selectNodeSpy.mockClear();
|
||||||
|
});
|
||||||
|
|
||||||
|
const rendered = <span data-testid="inner">hello</span>;
|
||||||
|
|
||||||
|
describe('RenderNode (Editor onRender override)', () => {
|
||||||
|
test('passes render through untouched when not selected', () => {
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(container.querySelector('[data-testid="inner"]')).not.toBeNull();
|
||||||
|
expect(document.querySelector('.component-indicator')).toBeNull();
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('shows the badge with the displayName when selected', () => {
|
||||||
|
mockNode.selected = true;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
const badge = document.querySelector('.component-indicator');
|
||||||
|
expect(badge).not.toBeNull();
|
||||||
|
expect(badge?.textContent).toContain('Heading');
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
document.querySelector('.component-indicator')?.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('never shows a badge for ROOT even if "selected"', () => {
|
||||||
|
mockNode.selected = true;
|
||||||
|
mockNode.id = 'ROOT';
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(document.querySelector('.component-indicator')).toBeNull();
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('chevron click selects the parent node', () => {
|
||||||
|
mockNode.selected = true;
|
||||||
|
mockNode.parent = 'parent-42';
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
const chevron = document.querySelector('.component-indicator-parent-btn') as HTMLElement;
|
||||||
|
expect(chevron).not.toBeNull();
|
||||||
|
act(() => {
|
||||||
|
chevron.dispatchEvent(new MouseEvent('mousedown', { bubbles: true }));
|
||||||
|
});
|
||||||
|
expect(selectNodeSpy).toHaveBeenCalledWith('parent-42');
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
document.querySelector('.component-indicator')?.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('no chevron when there is no parent', () => {
|
||||||
|
mockNode.selected = true;
|
||||||
|
mockNode.parent = null;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(document.querySelector('.component-indicator-parent-btn')).toBeNull();
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
document.querySelector('.component-indicator')?.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('tags a droppable (isCanvas) node dom with data-craft-node', () => {
|
||||||
|
mockNode.isCanvas = true;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-node')).toBe(true);
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('does not tag a non-canvas (leaf) node dom with data-craft-node', () => {
|
||||||
|
mockNode.isCanvas = false;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-node')).toBe(false);
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('never tags ROOT with data-craft-node even though ROOT is a canvas', () => {
|
||||||
|
mockNode.id = 'ROOT';
|
||||||
|
mockNode.isCanvas = true;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-node')).toBe(false);
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('tags the dom with data-craft-hovered when the Craft hovered event is set (Layers panel hover sync)', () => {
|
||||||
|
mockNode.hovered = true;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-hovered')).toBe(true);
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('removes data-craft-hovered once the hovered event clears', () => {
|
||||||
|
mockNode.hovered = true;
|
||||||
|
render(<RenderNode render={rendered} />);
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-hovered')).toBe(true);
|
||||||
|
mockNode.hovered = false;
|
||||||
|
act(() => {
|
||||||
|
root.render(<RenderNode render={rendered} />);
|
||||||
|
});
|
||||||
|
expect(nodeDom.hasAttribute('data-craft-hovered')).toBe(false);
|
||||||
|
container.remove();
|
||||||
|
nodeDom.remove();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,116 @@
|
|||||||
|
import React, { useCallback, useEffect, useRef } from 'react';
|
||||||
|
import { createPortal } from 'react-dom';
|
||||||
|
import { useEditor, useNode } from '@craftjs/core';
|
||||||
|
|
||||||
|
interface RenderNodeProps {
|
||||||
|
render: React.ReactElement;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Craft.js `<Editor onRender>` override -- wraps every node's render output.
|
||||||
|
* For the currently-selected node it portals a floating badge (component
|
||||||
|
* displayName + a "select parent" chevron) positioned over the node's real
|
||||||
|
* DOM element. Non-selected nodes (the overwhelming majority) and ROOT pass
|
||||||
|
* straight through as a Fragment, so this never touches layout, never
|
||||||
|
* appears in `toHtml` export (that walks the Craft node tree, not this
|
||||||
|
* portal), and doesn't wrap every node in extra DOM.
|
||||||
|
*
|
||||||
|
* It also imperatively tags each node's real DOM element with two
|
||||||
|
* editor-only data attributes (never part of `toHtml` export, which walks
|
||||||
|
* the Craft node tree, not the live DOM):
|
||||||
|
* - `data-craft-node`: set on actual Craft.js droppable containers
|
||||||
|
* (`node.data.isCanvas`, excluding ROOT). `editor.css`'s dashed "guide"
|
||||||
|
* outlines target this attribute instead of blanket tag selectors
|
||||||
|
* (div/section/header/...), so a component's own internal wrapper markup
|
||||||
|
* no longer picks up a guide outline it isn't a real drop target for.
|
||||||
|
* - `data-craft-hovered`: mirrors `node.events.hovered` (Craft's hover
|
||||||
|
* event set). Craft's own `connectors.connect()` (called by every
|
||||||
|
* component) wires a native mouseover/mouseleave listener to this event
|
||||||
|
* internally, so a plain mouse hover over any connected node sets it --
|
||||||
|
* this attribute is a real-mouse-hover canvas highlight. (The Layers
|
||||||
|
* panel's row-hover -> canvas-highlight sync, item 12, uses a sibling
|
||||||
|
* `data-layer-hovered` attribute written directly by LayersPanel.tsx
|
||||||
|
* instead of this event, since the action that would drive it here
|
||||||
|
* -- `actions.setNodeEvent` -- is stripped from the public `useEditor()`
|
||||||
|
* API at runtime.) editor.css matches both attributes for the same
|
||||||
|
* outline and suppresses both under `.guides-off`.
|
||||||
|
*/
|
||||||
|
export const RenderNode: React.FC<RenderNodeProps> = ({ render }) => {
|
||||||
|
const { actions } = useEditor();
|
||||||
|
const { id, isSelected, dom, name, parent, isCanvas, isHovered } = useNode((node) => ({
|
||||||
|
isSelected: node.events.selected,
|
||||||
|
isHovered: node.events.hovered,
|
||||||
|
dom: node.dom,
|
||||||
|
name: (node.data.props?.aiName as string) || node.data.displayName,
|
||||||
|
parent: node.data.parent,
|
||||||
|
isCanvas: node.data.isCanvas,
|
||||||
|
}));
|
||||||
|
|
||||||
|
const badgeRef = useRef<HTMLDivElement>(null);
|
||||||
|
const active = isSelected && id !== 'ROOT' && !!dom;
|
||||||
|
|
||||||
|
const updatePosition = useCallback(() => {
|
||||||
|
if (!dom || !badgeRef.current) return;
|
||||||
|
const rect = dom.getBoundingClientRect();
|
||||||
|
const badgeHeight = 22;
|
||||||
|
badgeRef.current.style.left = `${Math.max(rect.left, 0)}px`;
|
||||||
|
badgeRef.current.style.top = `${Math.max(rect.top - badgeHeight, 0)}px`;
|
||||||
|
}, [dom]);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!active) return;
|
||||||
|
updatePosition();
|
||||||
|
window.addEventListener('resize', updatePosition);
|
||||||
|
document.addEventListener('scroll', updatePosition, true);
|
||||||
|
return () => {
|
||||||
|
window.removeEventListener('resize', updatePosition);
|
||||||
|
document.removeEventListener('scroll', updatePosition, true);
|
||||||
|
};
|
||||||
|
}, [active, updatePosition]);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!dom) return;
|
||||||
|
if (isCanvas && id !== 'ROOT') {
|
||||||
|
dom.setAttribute('data-craft-node', '');
|
||||||
|
} else {
|
||||||
|
dom.removeAttribute('data-craft-node');
|
||||||
|
}
|
||||||
|
}, [dom, isCanvas, id]);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!dom) return;
|
||||||
|
if (isHovered) {
|
||||||
|
dom.setAttribute('data-craft-hovered', '');
|
||||||
|
} else {
|
||||||
|
dom.removeAttribute('data-craft-hovered');
|
||||||
|
}
|
||||||
|
}, [dom, isHovered]);
|
||||||
|
|
||||||
|
if (!active) return <>{render}</>;
|
||||||
|
|
||||||
|
return (
|
||||||
|
<>
|
||||||
|
{render}
|
||||||
|
{createPortal(
|
||||||
|
<div ref={badgeRef} className="component-indicator" style={{ position: 'fixed' }}>
|
||||||
|
<span>{name}</span>
|
||||||
|
{parent && (
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className="component-indicator-parent-btn"
|
||||||
|
title="Select parent"
|
||||||
|
aria-label={`Select parent of ${name}`}
|
||||||
|
onMouseDown={(e) => {
|
||||||
|
e.stopPropagation();
|
||||||
|
actions.selectNode(parent);
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<i className="fa fa-chevron-up" aria-hidden />
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
</div>,
|
||||||
|
document.body
|
||||||
|
)}
|
||||||
|
</>
|
||||||
|
);
|
||||||
|
};
|
||||||
@@ -0,0 +1,153 @@
|
|||||||
|
import { describe, test, expect, vi, beforeEach, afterEach } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
import { useIsMobile } from './useIsMobile';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Mobile-A2 (review item 5): useIsMobile is the single source of truth every
|
||||||
|
* mobile-only branch (bottom tab bar, collapsed topbar, bottom sheets) reads
|
||||||
|
* from, so it needs direct coverage of: (a) it reflects matchMedia's
|
||||||
|
* `matches`, (b) the `change` listener is registered AND cleaned up on
|
||||||
|
* unmount (a leaked listener would keep re-rendering an unmounted tree /
|
||||||
|
* leak the component instance), and (c) the legacy Safari<14
|
||||||
|
* addListener/removeListener fallback is used when addEventListener isn't
|
||||||
|
* available.
|
||||||
|
*
|
||||||
|
* DOM-harness pattern mirrors PageContext.pure-updaters.test.tsx /
|
||||||
|
* useKeyboardShortcuts.test.tsx: bare createRoot + act, no @testing-library
|
||||||
|
* (not a project dependency).
|
||||||
|
*/
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
let originalMatchMedia: typeof window.matchMedia;
|
||||||
|
|
||||||
|
function render(ui: React.ReactElement) {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(ui);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function unmount() {
|
||||||
|
act(() => {
|
||||||
|
root.unmount();
|
||||||
|
});
|
||||||
|
container.remove();
|
||||||
|
}
|
||||||
|
|
||||||
|
/** A minimal fake MediaQueryList. `mode` picks which listener API it
|
||||||
|
* exposes, so tests can force the legacy fallback path. */
|
||||||
|
function makeMql(matches: boolean, mode: 'modern' | 'legacy' = 'modern') {
|
||||||
|
const listeners: Array<() => void> = [];
|
||||||
|
const mql: any = {
|
||||||
|
matches,
|
||||||
|
media: '(max-width: 768px)',
|
||||||
|
};
|
||||||
|
if (mode === 'modern') {
|
||||||
|
mql.addEventListener = vi.fn((_type: string, fn: () => void) => listeners.push(fn));
|
||||||
|
mql.removeEventListener = vi.fn((_type: string, fn: () => void) => {
|
||||||
|
const i = listeners.indexOf(fn);
|
||||||
|
if (i !== -1) listeners.splice(i, 1);
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
mql.addListener = vi.fn((fn: () => void) => listeners.push(fn));
|
||||||
|
mql.removeListener = vi.fn((fn: () => void) => {
|
||||||
|
const i = listeners.indexOf(fn);
|
||||||
|
if (i !== -1) listeners.splice(i, 1);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
return { mql, fire: () => listeners.forEach((fn) => fn()), listenerCount: () => listeners.length };
|
||||||
|
}
|
||||||
|
|
||||||
|
let probedValue: boolean | null = null;
|
||||||
|
const Probe: React.FC = () => {
|
||||||
|
probedValue = useIsMobile();
|
||||||
|
return <span data-value={String(probedValue)} />;
|
||||||
|
};
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
originalMatchMedia = window.matchMedia;
|
||||||
|
probedValue = null;
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
window.matchMedia = originalMatchMedia;
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('useIsMobile', () => {
|
||||||
|
test('returns true when the mobile media query matches', () => {
|
||||||
|
const { mql } = makeMql(true);
|
||||||
|
window.matchMedia = vi.fn(() => mql) as any;
|
||||||
|
|
||||||
|
render(<Probe />);
|
||||||
|
expect(probedValue).toBe(true);
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('returns false when the mobile media query does not match', () => {
|
||||||
|
const { mql } = makeMql(false);
|
||||||
|
window.matchMedia = vi.fn(() => mql) as any;
|
||||||
|
|
||||||
|
render(<Probe />);
|
||||||
|
expect(probedValue).toBe(false);
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('registers the change listener via addEventListener and updates on change', () => {
|
||||||
|
const { mql, fire, listenerCount } = makeMql(false);
|
||||||
|
window.matchMedia = vi.fn(() => mql) as any;
|
||||||
|
|
||||||
|
render(<Probe />);
|
||||||
|
expect(probedValue).toBe(false);
|
||||||
|
expect(mql.addEventListener).toHaveBeenCalledWith('change', expect.any(Function));
|
||||||
|
expect(listenerCount()).toBe(1);
|
||||||
|
|
||||||
|
// Flip the query result and fire the registered 'change' listener --
|
||||||
|
// the hook must re-read mql.matches, not just toggle blindly.
|
||||||
|
mql.matches = true;
|
||||||
|
act(() => {
|
||||||
|
fire();
|
||||||
|
});
|
||||||
|
expect(probedValue).toBe(true);
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('cleans up the addEventListener listener on unmount', () => {
|
||||||
|
const { mql, listenerCount } = makeMql(true);
|
||||||
|
window.matchMedia = vi.fn(() => mql) as any;
|
||||||
|
|
||||||
|
render(<Probe />);
|
||||||
|
expect(listenerCount()).toBe(1);
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
|
||||||
|
expect(mql.removeEventListener).toHaveBeenCalledWith('change', expect.any(Function));
|
||||||
|
expect(listenerCount()).toBe(0);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('falls back to legacy addListener/removeListener when addEventListener is unavailable', () => {
|
||||||
|
const { mql, fire, listenerCount } = makeMql(false, 'legacy');
|
||||||
|
window.matchMedia = vi.fn(() => mql) as any;
|
||||||
|
|
||||||
|
render(<Probe />);
|
||||||
|
expect(probedValue).toBe(false);
|
||||||
|
expect(mql.addListener).toHaveBeenCalledWith(expect.any(Function));
|
||||||
|
expect(listenerCount()).toBe(1);
|
||||||
|
|
||||||
|
mql.matches = true;
|
||||||
|
act(() => {
|
||||||
|
fire();
|
||||||
|
});
|
||||||
|
expect(probedValue).toBe(true);
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
|
||||||
|
expect(mql.removeListener).toHaveBeenCalledWith(expect.any(Function));
|
||||||
|
expect(listenerCount()).toBe(0);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,72 @@
|
|||||||
|
import { useEffect, useState } from 'react';
|
||||||
|
|
||||||
|
/** Mobile breakpoint for the editor chrome (Phase A). Keep in sync with the
|
||||||
|
* `@media (max-width: 768px)` block in `src/styles/editor.css` -- both the
|
||||||
|
* CSS and this hook must agree on where mobile chrome kicks in. */
|
||||||
|
export const MOBILE_BREAKPOINT_PX = 768;
|
||||||
|
const MOBILE_QUERY = `(max-width: ${MOBILE_BREAKPOINT_PX}px)`;
|
||||||
|
|
||||||
|
function computeIsMobile(): boolean {
|
||||||
|
if (typeof window === 'undefined') return false;
|
||||||
|
if (typeof window.matchMedia === 'function') {
|
||||||
|
try {
|
||||||
|
return window.matchMedia(MOBILE_QUERY).matches;
|
||||||
|
} catch {
|
||||||
|
// Fall through to the width check below (e.g. some older/embedded
|
||||||
|
// WebViews expose a matchMedia that throws instead of omitting it).
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return window.innerWidth <= MOBILE_BREAKPOINT_PX;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Reports whether the viewport is at or below the mobile editor breakpoint.
|
||||||
|
* Drives every mobile-only branch introduced in Phase A (bottom tab bar,
|
||||||
|
* collapsed topbar, bottom sheets) -- desktop rendering must stay identical
|
||||||
|
* above the breakpoint, so this is the single source of truth both React
|
||||||
|
* and (via the matching CSS media query) plain CSS use to agree on "mobile".
|
||||||
|
*
|
||||||
|
* Falls back to a `resize` listener + `window.innerWidth` when
|
||||||
|
* `matchMedia` isn't available (e.g. some test/JSDOM environments), so the
|
||||||
|
* hook degrades gracefully rather than throwing.
|
||||||
|
*/
|
||||||
|
export function useIsMobile(): boolean {
|
||||||
|
const [isMobile, setIsMobile] = useState<boolean>(computeIsMobile);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (typeof window === 'undefined') return;
|
||||||
|
|
||||||
|
if (typeof window.matchMedia === 'function') {
|
||||||
|
let mql: MediaQueryList | null = null;
|
||||||
|
try {
|
||||||
|
mql = window.matchMedia(MOBILE_QUERY);
|
||||||
|
} catch {
|
||||||
|
mql = null;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (mql) {
|
||||||
|
const handleChange = () => setIsMobile(mql!.matches);
|
||||||
|
handleChange();
|
||||||
|
|
||||||
|
if (typeof mql.addEventListener === 'function') {
|
||||||
|
mql.addEventListener('change', handleChange);
|
||||||
|
return () => mql!.removeEventListener('change', handleChange);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Safari < 14 only supports the deprecated addListener/removeListener pair.
|
||||||
|
const legacyMql = mql as MediaQueryList & {
|
||||||
|
addListener?: (listener: () => void) => void;
|
||||||
|
removeListener?: (listener: () => void) => void;
|
||||||
|
};
|
||||||
|
legacyMql.addListener?.(handleChange);
|
||||||
|
return () => legacyMql.removeListener?.(handleChange);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
const handleResize = () => setIsMobile(window.innerWidth <= MOBILE_BREAKPOINT_PX);
|
||||||
|
window.addEventListener('resize', handleResize);
|
||||||
|
return () => window.removeEventListener('resize', handleResize);
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
return isMobile;
|
||||||
|
}
|
||||||
@@ -0,0 +1,258 @@
|
|||||||
|
import { describe, test, expect, vi, beforeEach, afterEach } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
import type { NodeTree, Node } from '@craftjs/core';
|
||||||
|
import { useNodeActions, type NodeActions } from './useNodeActions';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Phase B, item 1: `useNodeActions` was extracted out of `ContextMenu.tsx` so
|
||||||
|
* the desktop right-click menu and the mobile selection toolbar
|
||||||
|
* (`MobileSelectionToolbar`) share one implementation. This suite exercises
|
||||||
|
* the hook directly (mocking `@craftjs/core`'s `useEditor`, mirroring the
|
||||||
|
* pattern in `useKeyboardShortcuts.test.tsx`), covering:
|
||||||
|
* - moveUp/moveDown call `actions.move` with the right target index, and
|
||||||
|
* are no-ops at the respective boundary
|
||||||
|
* - canMoveUp/canMoveDown reflect the node's position among its siblings
|
||||||
|
* - duplicate regenerates ids, inserts the copy IMMEDIATELY AFTER the
|
||||||
|
* source node (`actions.addNodeTree(tree, parentId, sourceIndex + 1)`),
|
||||||
|
* and selects the new copy (`actions.selectNode(tree.rootNodeId)`) --
|
||||||
|
* Phase B fast-follow: the previous append-at-end behavior left the copy
|
||||||
|
* off-screen with the ORIGINAL still selected, so users couldn't see
|
||||||
|
* what "Duplicate" had just done.
|
||||||
|
* - selectParent calls `actions.selectNode` with the parent id
|
||||||
|
* - canSelectParent reflects whether the node's parent is itself real
|
||||||
|
* (not ROOT/missing) -- false at a top-level section, true one level in
|
||||||
|
* - deleteNode routes through `findDeletableTarget` (also covering the
|
||||||
|
* "no deletable target" no-op)
|
||||||
|
* - ROOT/null nodeId disables every action safely (no-ops, all
|
||||||
|
* canMoveUp/canMoveDown/canDelete/canSelectParent false)
|
||||||
|
*/
|
||||||
|
|
||||||
|
const moveMock = vi.fn();
|
||||||
|
const addNodeTreeMock = vi.fn();
|
||||||
|
const selectNodeMock = vi.fn();
|
||||||
|
const deleteMock = vi.fn();
|
||||||
|
|
||||||
|
interface FakeNodeData {
|
||||||
|
parent: string | null;
|
||||||
|
nodes: string[];
|
||||||
|
}
|
||||||
|
|
||||||
|
let fakeNodes: Record<string, { data: FakeNodeData }> = {};
|
||||||
|
|
||||||
|
const COPIED_TREE: NodeTree = {
|
||||||
|
rootNodeId: 'child-1',
|
||||||
|
nodes: {
|
||||||
|
'child-1': {
|
||||||
|
id: 'child-1',
|
||||||
|
data: { props: {}, type: { resolvedName: 'Container' }, name: 'Container', displayName: 'Container', isCanvas: false, parent: 'parent-1', linkedNodes: {}, nodes: [], hidden: false },
|
||||||
|
info: {},
|
||||||
|
events: { selected: false, dragged: false, hovered: false },
|
||||||
|
dom: null,
|
||||||
|
related: {},
|
||||||
|
rules: {},
|
||||||
|
_hydrationTimestamp: 0,
|
||||||
|
} as unknown as Node,
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
function makeQuery() {
|
||||||
|
return {
|
||||||
|
node: (id: string) => ({
|
||||||
|
get: () => fakeNodes[id] ?? null,
|
||||||
|
toNodeTree: () => {
|
||||||
|
if (id !== 'child-1') throw new Error(`unexpected toNodeTree() for "${id}"`);
|
||||||
|
return COPIED_TREE;
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
vi.mock('@craftjs/core', () => ({
|
||||||
|
useEditor: (collector?: (state: any, query: any) => any) => {
|
||||||
|
const state = {
|
||||||
|
nodes: Object.fromEntries(Object.entries(fakeNodes).map(([id, n]) => [id, n])),
|
||||||
|
};
|
||||||
|
const query = makeQuery();
|
||||||
|
const collected = collector ? collector(state, query) : {};
|
||||||
|
return {
|
||||||
|
...collected,
|
||||||
|
actions: {
|
||||||
|
move: moveMock,
|
||||||
|
addNodeTree: addNodeTreeMock,
|
||||||
|
selectNode: selectNodeMock,
|
||||||
|
delete: deleteMock,
|
||||||
|
},
|
||||||
|
query,
|
||||||
|
};
|
||||||
|
},
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock('../utils/craft-tree', async (importOriginal) => {
|
||||||
|
const actual = await importOriginal<typeof import('../utils/craft-tree')>();
|
||||||
|
return { ...actual, regenerateTreeIds: vi.fn(actual.regenerateTreeIds) };
|
||||||
|
});
|
||||||
|
|
||||||
|
import { regenerateTreeIds } from '../utils/craft-tree';
|
||||||
|
const regenerateTreeIdsMock = vi.mocked(regenerateTreeIds);
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
let captured: NodeActions | null = null;
|
||||||
|
|
||||||
|
const Probe: React.FC<{ nodeId: string | null }> = ({ nodeId }) => {
|
||||||
|
captured = useNodeActions(nodeId);
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
|
function render(nodeId: string | null) {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(<Probe nodeId={nodeId} />);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function rerender(nodeId: string | null) {
|
||||||
|
act(() => {
|
||||||
|
root.render(<Probe nodeId={nodeId} />);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function unmount() {
|
||||||
|
act(() => {
|
||||||
|
root.unmount();
|
||||||
|
});
|
||||||
|
container.remove();
|
||||||
|
}
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
moveMock.mockClear();
|
||||||
|
addNodeTreeMock.mockClear();
|
||||||
|
selectNodeMock.mockClear();
|
||||||
|
deleteMock.mockClear();
|
||||||
|
regenerateTreeIdsMock.mockClear();
|
||||||
|
captured = null;
|
||||||
|
fakeNodes = {
|
||||||
|
ROOT: { data: { parent: null, nodes: ['parent-1'] } },
|
||||||
|
'parent-1': { data: { parent: 'ROOT', nodes: ['child-0', 'child-1', 'child-2'] } },
|
||||||
|
'child-0': { data: { parent: 'parent-1', nodes: [] } },
|
||||||
|
'child-1': { data: { parent: 'parent-1', nodes: [] } },
|
||||||
|
'child-2': { data: { parent: 'parent-1', nodes: [] } },
|
||||||
|
};
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
if (root) unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('useNodeActions', () => {
|
||||||
|
test('a middle child can move both up and down', () => {
|
||||||
|
render('child-1');
|
||||||
|
expect(captured!.canMoveUp).toBe(true);
|
||||||
|
expect(captured!.canMoveDown).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the first child cannot move up, but can move down', () => {
|
||||||
|
render('child-0');
|
||||||
|
expect(captured!.canMoveUp).toBe(false);
|
||||||
|
expect(captured!.canMoveDown).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the last child can move up, but not down', () => {
|
||||||
|
render('child-2');
|
||||||
|
expect(captured!.canMoveUp).toBe(true);
|
||||||
|
expect(captured!.canMoveDown).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('moveUp calls actions.move with idx - 1, moveDown with idx + 2 (Craft.js index semantics)', () => {
|
||||||
|
render('child-1');
|
||||||
|
act(() => captured!.moveUp());
|
||||||
|
expect(moveMock).toHaveBeenCalledWith('child-1', 'parent-1', 0);
|
||||||
|
|
||||||
|
moveMock.mockClear();
|
||||||
|
act(() => captured!.moveDown());
|
||||||
|
expect(moveMock).toHaveBeenCalledWith('child-1', 'parent-1', 3);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('moveUp/moveDown at a boundary are no-ops', () => {
|
||||||
|
render('child-0');
|
||||||
|
act(() => captured!.moveUp());
|
||||||
|
expect(moveMock).not.toHaveBeenCalled();
|
||||||
|
|
||||||
|
rerender('child-2');
|
||||||
|
act(() => captured!.moveDown());
|
||||||
|
expect(moveMock).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('duplicate inserts the copy immediately after the source (parentId, sourceIndex + 1) and selects it', () => {
|
||||||
|
render('child-1');
|
||||||
|
let returned: string | null | undefined;
|
||||||
|
act(() => {
|
||||||
|
returned = captured!.duplicate();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(regenerateTreeIdsMock).toHaveBeenCalledTimes(1);
|
||||||
|
expect(addNodeTreeMock).toHaveBeenCalledTimes(1);
|
||||||
|
const [tree, parentId, index] = addNodeTreeMock.mock.calls[0];
|
||||||
|
// child-1 is at index 1 among ['child-0', 'child-1', 'child-2'] -> insert at 2.
|
||||||
|
expect(parentId).toBe('parent-1');
|
||||||
|
expect(index).toBe(2);
|
||||||
|
expect(tree.rootNodeId).not.toBe(COPIED_TREE.rootNodeId);
|
||||||
|
|
||||||
|
expect(selectNodeMock).toHaveBeenCalledTimes(1);
|
||||||
|
expect(selectNodeMock).toHaveBeenCalledWith(tree.rootNodeId);
|
||||||
|
expect(returned).toBe(tree.rootNodeId);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('selectParent calls actions.selectNode with the parent id', () => {
|
||||||
|
render('child-1');
|
||||||
|
act(() => captured!.selectParent());
|
||||||
|
expect(selectNodeMock).toHaveBeenCalledWith('parent-1');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('canSelectParent is false at a top-level node (parent is ROOT), true one level deeper', () => {
|
||||||
|
render('parent-1'); // parent-1's own parent is 'ROOT'
|
||||||
|
expect(captured!.canSelectParent).toBe(false);
|
||||||
|
|
||||||
|
rerender('child-1'); // child-1's parent is 'parent-1', a real node
|
||||||
|
expect(captured!.canSelectParent).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('deleteNode calls actions.delete with the node id when deletable', () => {
|
||||||
|
render('child-1');
|
||||||
|
expect(captured!.canDelete).toBe(true);
|
||||||
|
act(() => captured!.deleteNode());
|
||||||
|
expect(deleteMock).toHaveBeenCalledWith('child-1');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('ROOT nodeId disables every action and is a safe no-op', () => {
|
||||||
|
render('ROOT');
|
||||||
|
expect(captured!.canMoveUp).toBe(false);
|
||||||
|
expect(captured!.canMoveDown).toBe(false);
|
||||||
|
expect(captured!.canDelete).toBe(false);
|
||||||
|
expect(captured!.canSelectParent).toBe(false);
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
captured!.moveUp();
|
||||||
|
captured!.moveDown();
|
||||||
|
captured!.duplicate();
|
||||||
|
captured!.selectParent();
|
||||||
|
captured!.deleteNode();
|
||||||
|
});
|
||||||
|
expect(moveMock).not.toHaveBeenCalled();
|
||||||
|
expect(addNodeTreeMock).not.toHaveBeenCalled();
|
||||||
|
expect(selectNodeMock).not.toHaveBeenCalled();
|
||||||
|
expect(deleteMock).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('null nodeId disables every action and is a safe no-op', () => {
|
||||||
|
render(null);
|
||||||
|
expect(captured!.canMoveUp).toBe(false);
|
||||||
|
expect(captured!.canMoveDown).toBe(false);
|
||||||
|
expect(captured!.canDelete).toBe(false);
|
||||||
|
expect(captured!.canSelectParent).toBe(false);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,221 @@
|
|||||||
|
import { useEditor } from '@craftjs/core';
|
||||||
|
import { regenerateTreeIds } from '../utils/craft-tree';
|
||||||
|
import { findDeletableTarget } from '../utils/craft-helpers';
|
||||||
|
|
||||||
|
export interface NodeActions {
|
||||||
|
moveUp: () => void;
|
||||||
|
moveDown: () => void;
|
||||||
|
/** Duplicates `nodeId`, inserting the copy immediately after the source in
|
||||||
|
* the parent's children and selecting it. Returns the new node's id (so
|
||||||
|
* callers -- e.g. `MobileSelectionToolbar` -- can scroll it into view),
|
||||||
|
* or null if the duplicate could not be performed (no-op for ROOT/null,
|
||||||
|
* or a caught error). */
|
||||||
|
duplicate: () => string | null;
|
||||||
|
deleteNode: () => void;
|
||||||
|
selectParent: () => void;
|
||||||
|
/** True if `nodeId` has an earlier sibling under the same parent (so
|
||||||
|
* `moveUp` would actually move it). False for ROOT/null/no-parent. */
|
||||||
|
canMoveUp: boolean;
|
||||||
|
/** True if `nodeId` has a later sibling under the same parent (so
|
||||||
|
* `moveDown` would actually move it). False for ROOT/null/no-parent. */
|
||||||
|
canMoveDown: boolean;
|
||||||
|
/** True if `findDeletableTarget` resolves to a real, deletable node (either
|
||||||
|
* `nodeId` itself, or an ancestor when `nodeId` is an empty linked-node
|
||||||
|
* slot whose siblings are all also empty -- see `craft-helpers.ts`). */
|
||||||
|
canDelete: boolean;
|
||||||
|
/** True if `nodeId` has a real parent to select -- i.e. the parent is
|
||||||
|
* neither ROOT nor missing. `selectParent` on a top-level section (whose
|
||||||
|
* parent IS 'ROOT') would only select the page-wide ROOT node, which has
|
||||||
|
* no on-canvas outline and no toolbar of its own -- a dead end for a
|
||||||
|
* mobile user with no way back. False for ROOT/null/no-parent too. */
|
||||||
|
canSelectParent: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Shared node-action logic (move up/down, duplicate, delete, select parent)
|
||||||
|
* extracted from `ContextMenu.tsx` (Phase B) so both the desktop right-click
|
||||||
|
* menu AND the mobile on-canvas selection toolbar (`MobileSelectionToolbar`)
|
||||||
|
* drive the exact same behavior from one place instead of two independent
|
||||||
|
* copies drifting apart.
|
||||||
|
*
|
||||||
|
* IMPORTANT gotcha this hook works around: `@craftjs/core`'s `useEditor`
|
||||||
|
* collector (`@craftjs/utils`' `useCollector`) only synchronously computes
|
||||||
|
* the collector function ONCE, on this hook's very first mount. After that,
|
||||||
|
* it updates purely in reaction to the underlying store's OWN change
|
||||||
|
* notifications, invoking whatever collector closure is current AT THAT
|
||||||
|
* NOTIFICATION -- so a collector that closes over `nodeId` (an argument that
|
||||||
|
* changes across renders of the SAME mounted hook instance, e.g. every time
|
||||||
|
* `MobileSelectionToolbar` re-renders with a newly-selected node) goes stale
|
||||||
|
* for exactly one render: the cached value from the last store notification
|
||||||
|
* (computed against the PREVIOUS nodeId) is what gets returned, until some
|
||||||
|
* unrelated store event happens to trigger a fresh computation. An earlier
|
||||||
|
* version of this hook computed `canMoveUp`/`canMoveDown`/`canDelete` inside
|
||||||
|
* such a collector and was caught showing the PREVIOUS selection's move
|
||||||
|
* boundaries in the mobile toolbar for one render after tapping a new node
|
||||||
|
* (verified with real Playwright touch taps against a real Craft.js
|
||||||
|
* document -- a plain mocked `useEditor` in a unit test doesn't reproduce
|
||||||
|
* this, since a hand-rolled mock has no reason to replicate the real
|
||||||
|
* library's caching).
|
||||||
|
*
|
||||||
|
* The fix: get `actions`/`query` from a collector-FREE `useEditor()` call
|
||||||
|
* (an always-live reference, same pattern `ContextMenu.tsx` used before this
|
||||||
|
* extraction) and compute `canMoveUp`/`canMoveDown`/`canDelete` as plain
|
||||||
|
* synchronous code during render using that live `query` -- never cached.
|
||||||
|
*
|
||||||
|
* That still leaves one gap: `nodeId` staying the SAME across renders while
|
||||||
|
* its position changes (e.g. tapping "Move Up" repeatedly on the same
|
||||||
|
* still-selected node) needs SOMETHING to trigger a re-render so the boundary
|
||||||
|
* flags below get recomputed. An earlier version of this hook forced that
|
||||||
|
* via a second `useEditor((state) => ({ _: state.nodes }))` subscription --
|
||||||
|
* but subscribing to the WHOLE node map reacts to every `dom` ref
|
||||||
|
* assignment too (Craft's `connectors.connect(ref)` calls `actions.setDOM`
|
||||||
|
* synchronously from a React ref callback during COMMIT, i.e. while some
|
||||||
|
* OTHER component is still mounting), which trips React's "Cannot update a
|
||||||
|
* component while rendering a different component" warning the moment a
|
||||||
|
* freshly-added container with children mounts. Callers that need
|
||||||
|
* `canMoveUp`/`canMoveDown` to refresh after a move they themselves
|
||||||
|
* triggered (`MobileSelectionToolbar`) should instead bump their OWN local
|
||||||
|
* state right after calling `moveUp`/`moveDown` -- a plain, local,
|
||||||
|
* event-handler-triggered re-render, not a store-wide subscription.
|
||||||
|
*/
|
||||||
|
export function useNodeActions(nodeId: string | null | undefined): NodeActions {
|
||||||
|
const { actions, query } = useEditor();
|
||||||
|
|
||||||
|
const isRootOrNull = !nodeId || nodeId === 'ROOT';
|
||||||
|
|
||||||
|
let canMoveUp = false;
|
||||||
|
let canMoveDown = false;
|
||||||
|
let canSelectParent = false;
|
||||||
|
if (!isRootOrNull) {
|
||||||
|
try {
|
||||||
|
const node = query.node(nodeId).get();
|
||||||
|
const parentId: string | null | undefined = node?.data?.parent;
|
||||||
|
if (parentId) {
|
||||||
|
canSelectParent = parentId !== 'ROOT';
|
||||||
|
const siblings: string[] = query.node(parentId).get()?.data?.nodes || [];
|
||||||
|
const idx = siblings.indexOf(nodeId);
|
||||||
|
canMoveUp = idx > 0;
|
||||||
|
canMoveDown = idx !== -1 && idx < siblings.length - 1;
|
||||||
|
}
|
||||||
|
} catch {
|
||||||
|
// Node no longer exists (e.g. deleted out from under a stale
|
||||||
|
// reference) -- leave both false.
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
const canDelete = !isRootOrNull && !!findDeletableTarget(query, nodeId);
|
||||||
|
|
||||||
|
const getParentId = (): string | null => {
|
||||||
|
if (!nodeId) return null;
|
||||||
|
try {
|
||||||
|
const node = query.node(nodeId).get();
|
||||||
|
return node?.data?.parent || null;
|
||||||
|
} catch {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const duplicate = (): string | null => {
|
||||||
|
if (!nodeId || nodeId === 'ROOT') return null;
|
||||||
|
try {
|
||||||
|
const parentId = getParentId();
|
||||||
|
if (!parentId) return null;
|
||||||
|
|
||||||
|
const tree = regenerateTreeIds(query.node(nodeId).toNodeTree());
|
||||||
|
|
||||||
|
// Insert the copy IMMEDIATELY AFTER the source node, not appended at
|
||||||
|
// the end of the parent -- on a top-level section, "append at end"
|
||||||
|
// landed the copy at the bottom of the page, off-screen, with the
|
||||||
|
// ORIGINAL still selected, so a duplicate looked like nothing had
|
||||||
|
// happened at all. Resolve the source's index among its siblings so
|
||||||
|
// the copy lands right next to what it was copied from; if that can't
|
||||||
|
// be resolved for any reason, fall back to the old append behavior
|
||||||
|
// rather than guessing at an index (or throwing).
|
||||||
|
let insertIndex: number | undefined;
|
||||||
|
try {
|
||||||
|
const siblings: string[] = query.node(parentId).get()?.data?.nodes || [];
|
||||||
|
const sourceIndex = siblings.indexOf(nodeId);
|
||||||
|
if (sourceIndex !== -1) insertIndex = sourceIndex + 1;
|
||||||
|
} catch {
|
||||||
|
// Leave insertIndex undefined -- addNodeTree appends when omitted.
|
||||||
|
}
|
||||||
|
|
||||||
|
if (insertIndex !== undefined) {
|
||||||
|
actions.addNodeTree(tree, parentId, insertIndex);
|
||||||
|
} else {
|
||||||
|
actions.addNodeTree(tree, parentId);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Select the new copy (not the original) so the toolbar/context menu
|
||||||
|
// and any on-canvas outline immediately reflect what was just created.
|
||||||
|
actions.selectNode(tree.rootNodeId);
|
||||||
|
|
||||||
|
return tree.rootNodeId;
|
||||||
|
} catch (e) {
|
||||||
|
console.error('Duplicate failed:', e);
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const moveUp = () => {
|
||||||
|
if (!nodeId || nodeId === 'ROOT') return;
|
||||||
|
try {
|
||||||
|
const parentId = getParentId();
|
||||||
|
if (!parentId) return;
|
||||||
|
const parent = query.node(parentId).get();
|
||||||
|
const children = parent.data.nodes || [];
|
||||||
|
const idx = children.indexOf(nodeId);
|
||||||
|
if (idx > 0) {
|
||||||
|
actions.move(nodeId, parentId, idx - 1);
|
||||||
|
}
|
||||||
|
} catch (e) {
|
||||||
|
console.error('Move up failed:', e);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const moveDown = () => {
|
||||||
|
if (!nodeId || nodeId === 'ROOT') return;
|
||||||
|
try {
|
||||||
|
const parentId = getParentId();
|
||||||
|
if (!parentId) return;
|
||||||
|
const parent = query.node(parentId).get();
|
||||||
|
const children = parent.data.nodes || [];
|
||||||
|
const idx = children.indexOf(nodeId);
|
||||||
|
if (idx < children.length - 1) {
|
||||||
|
actions.move(nodeId, parentId, idx + 2);
|
||||||
|
}
|
||||||
|
} catch (e) {
|
||||||
|
console.error('Move down failed:', e);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const selectParent = () => {
|
||||||
|
if (!nodeId || nodeId === 'ROOT') return;
|
||||||
|
const parentId = getParentId();
|
||||||
|
if (parentId) {
|
||||||
|
actions.selectNode(parentId);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const deleteNode = () => {
|
||||||
|
const target = findDeletableTarget(query, nodeId);
|
||||||
|
if (!target) return;
|
||||||
|
try {
|
||||||
|
actions.delete(target);
|
||||||
|
} catch (e) {
|
||||||
|
console.error('Delete failed:', e);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
return {
|
||||||
|
moveUp,
|
||||||
|
moveDown,
|
||||||
|
duplicate,
|
||||||
|
deleteNode,
|
||||||
|
selectParent,
|
||||||
|
canMoveUp,
|
||||||
|
canMoveDown,
|
||||||
|
canDelete,
|
||||||
|
canSelectParent,
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -0,0 +1,146 @@
|
|||||||
|
import { describe, test, expect, vi, beforeEach, afterEach } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
import { useVisualViewportInsets } from './useVisualViewport';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Fast-follow coverage for `useVisualViewportInsets` (BottomSheet's
|
||||||
|
* keyboard-avoidance source of truth). Mirrors the bare createRoot + act
|
||||||
|
* harness `useIsMobile.test.tsx` uses (no @testing-library/react in this
|
||||||
|
* repo). Covers:
|
||||||
|
* - the no-`visualViewport` fallback (older WebViews) returns
|
||||||
|
* `{ height: window.innerHeight, keyboardInset: 0 }` AND registers no
|
||||||
|
* listener (there's nothing to listen to).
|
||||||
|
* - the keyboard-open math: `keyboardInset = innerHeight - (vv.height +
|
||||||
|
* vv.offsetTop)`, recomputed when the mocked vv fires `resize`.
|
||||||
|
* - both `resize` and `scroll` listeners are added on mount and the SAME
|
||||||
|
* handler is removed for both on unmount (a leaked listener would keep
|
||||||
|
* reacting after the owning component -- e.g. BottomSheet -- is gone).
|
||||||
|
*/
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
let originalInnerHeight: number;
|
||||||
|
let originalVisualViewport: VisualViewport | null;
|
||||||
|
|
||||||
|
function render(ui: React.ReactElement) {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(ui);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function unmount() {
|
||||||
|
act(() => {
|
||||||
|
root.unmount();
|
||||||
|
});
|
||||||
|
container.remove();
|
||||||
|
}
|
||||||
|
|
||||||
|
/** A minimal fake `visualViewport`: just enough surface for the hook
|
||||||
|
* (`height`, `offsetTop`, `addEventListener`/`removeEventListener`). */
|
||||||
|
function makeVisualViewport(height: number, offsetTop: number) {
|
||||||
|
const listeners: Record<string, Array<() => void>> = { resize: [], scroll: [] };
|
||||||
|
const vv: any = {
|
||||||
|
height,
|
||||||
|
offsetTop,
|
||||||
|
addEventListener: vi.fn((type: string, fn: () => void) => {
|
||||||
|
listeners[type].push(fn);
|
||||||
|
}),
|
||||||
|
removeEventListener: vi.fn((type: string, fn: () => void) => {
|
||||||
|
const i = listeners[type].indexOf(fn);
|
||||||
|
if (i !== -1) listeners[type].splice(i, 1);
|
||||||
|
}),
|
||||||
|
};
|
||||||
|
return {
|
||||||
|
vv,
|
||||||
|
fire: (type: 'resize' | 'scroll') => listeners[type].forEach((fn) => fn()),
|
||||||
|
listenerCount: (type: 'resize' | 'scroll') => listeners[type].length,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
let probed: { height: number; keyboardInset: number } | null = null;
|
||||||
|
const Probe: React.FC = () => {
|
||||||
|
probed = useVisualViewportInsets();
|
||||||
|
return <span data-height={probed.height} data-inset={probed.keyboardInset} />;
|
||||||
|
};
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
originalInnerHeight = window.innerHeight;
|
||||||
|
originalVisualViewport = window.visualViewport;
|
||||||
|
probed = null;
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
Object.defineProperty(window, 'innerHeight', {
|
||||||
|
value: originalInnerHeight,
|
||||||
|
configurable: true,
|
||||||
|
writable: true,
|
||||||
|
});
|
||||||
|
Object.defineProperty(window, 'visualViewport', {
|
||||||
|
value: originalVisualViewport,
|
||||||
|
configurable: true,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('useVisualViewportInsets', () => {
|
||||||
|
test('falls back to innerHeight/0 and registers no listener when visualViewport is undefined', () => {
|
||||||
|
Object.defineProperty(window, 'innerHeight', { value: 800, configurable: true, writable: true });
|
||||||
|
Object.defineProperty(window, 'visualViewport', { value: undefined, configurable: true });
|
||||||
|
|
||||||
|
render(<Probe />);
|
||||||
|
|
||||||
|
expect(probed).toEqual({ height: 800, keyboardInset: 0 });
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('computes keyboardInset from visualViewport and recomputes on resize', () => {
|
||||||
|
Object.defineProperty(window, 'innerHeight', { value: 800, configurable: true, writable: true });
|
||||||
|
const { vv, fire } = makeVisualViewport(800, 0);
|
||||||
|
Object.defineProperty(window, 'visualViewport', { value: vv, configurable: true });
|
||||||
|
|
||||||
|
render(<Probe />);
|
||||||
|
|
||||||
|
// No keyboard open: vv fills the layout viewport exactly.
|
||||||
|
expect(probed).toEqual({ height: 800, keyboardInset: 0 });
|
||||||
|
|
||||||
|
// Simulate the on-screen keyboard opening: the visual viewport shrinks.
|
||||||
|
vv.height = 500;
|
||||||
|
vv.offsetTop = 0;
|
||||||
|
act(() => {
|
||||||
|
fire('resize');
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(probed).toEqual({ height: 500, keyboardInset: 300 });
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('registers resize and scroll listeners on mount and removes both (same handler) on unmount', () => {
|
||||||
|
Object.defineProperty(window, 'innerHeight', { value: 800, configurable: true, writable: true });
|
||||||
|
const { vv, listenerCount } = makeVisualViewport(800, 0);
|
||||||
|
Object.defineProperty(window, 'visualViewport', { value: vv, configurable: true });
|
||||||
|
|
||||||
|
render(<Probe />);
|
||||||
|
|
||||||
|
expect(vv.addEventListener).toHaveBeenCalledWith('resize', expect.any(Function));
|
||||||
|
expect(vv.addEventListener).toHaveBeenCalledWith('scroll', expect.any(Function));
|
||||||
|
expect(listenerCount('resize')).toBe(1);
|
||||||
|
expect(listenerCount('scroll')).toBe(1);
|
||||||
|
|
||||||
|
const resizeHandler = vv.addEventListener.mock.calls.find((c: any[]) => c[0] === 'resize')[1];
|
||||||
|
const scrollHandler = vv.addEventListener.mock.calls.find((c: any[]) => c[0] === 'scroll')[1];
|
||||||
|
expect(resizeHandler).toBe(scrollHandler);
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
|
||||||
|
expect(vv.removeEventListener).toHaveBeenCalledWith('resize', resizeHandler);
|
||||||
|
expect(vv.removeEventListener).toHaveBeenCalledWith('scroll', scrollHandler);
|
||||||
|
expect(listenerCount('resize')).toBe(0);
|
||||||
|
expect(listenerCount('scroll')).toBe(0);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,55 @@
|
|||||||
|
import { useEffect, useState } from 'react';
|
||||||
|
|
||||||
|
export interface VisualViewportInsets {
|
||||||
|
/** The visual viewport's current height (shrinks when the on-screen
|
||||||
|
* keyboard opens). Falls back to `window.innerHeight` when
|
||||||
|
* `visualViewport` isn't supported. */
|
||||||
|
height: number;
|
||||||
|
/** Extra inset a `position: fixed`, bottom-anchored element should add to
|
||||||
|
* its own `bottom` offset to stay clear of the on-screen keyboard --
|
||||||
|
* `window.innerHeight` minus the visual viewport's bottom edge (its
|
||||||
|
* height + offsetTop). Zero whenever no keyboard is open, or
|
||||||
|
* `visualViewport` isn't supported (a safe no-op fallback). */
|
||||||
|
keyboardInset: number;
|
||||||
|
}
|
||||||
|
|
||||||
|
const ZERO_INSETS: VisualViewportInsets = { height: 0, keyboardInset: 0 };
|
||||||
|
|
||||||
|
function computeInsets(): VisualViewportInsets {
|
||||||
|
if (typeof window === 'undefined') return ZERO_INSETS;
|
||||||
|
const vv = window.visualViewport;
|
||||||
|
if (!vv) return { height: window.innerHeight, keyboardInset: 0 };
|
||||||
|
const keyboardInset = Math.max(0, window.innerHeight - (vv.height + vv.offsetTop));
|
||||||
|
return { height: vv.height, keyboardInset };
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Tracks `window.visualViewport`'s height/offset (item 5, Phase B) so
|
||||||
|
* `BottomSheet` can stay clear of the on-screen keyboard. `position: fixed`
|
||||||
|
* elements are positioned against the LAYOUT viewport, which does NOT shrink
|
||||||
|
* when a mobile keyboard opens -- only the visual viewport does -- so a
|
||||||
|
* bottom-anchored sheet's inputs can otherwise end up hidden underneath the
|
||||||
|
* keyboard with no visual indication anything is wrong.
|
||||||
|
*
|
||||||
|
* Guards for browsers without `visualViewport` (older WebViews): falls back
|
||||||
|
* to `{ height: window.innerHeight, keyboardInset: 0 }`, i.e. a no-op, so
|
||||||
|
* the sheet just keeps its existing (keyboard-unaware) sizing there.
|
||||||
|
*/
|
||||||
|
export function useVisualViewportInsets(): VisualViewportInsets {
|
||||||
|
const [insets, setInsets] = useState<VisualViewportInsets>(computeInsets);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (typeof window === 'undefined' || !window.visualViewport) return;
|
||||||
|
const vv = window.visualViewport;
|
||||||
|
const handleChange = () => setInsets(computeInsets());
|
||||||
|
handleChange();
|
||||||
|
vv.addEventListener('resize', handleChange);
|
||||||
|
vv.addEventListener('scroll', handleChange);
|
||||||
|
return () => {
|
||||||
|
vv.removeEventListener('resize', handleChange);
|
||||||
|
vv.removeEventListener('scroll', handleChange);
|
||||||
|
};
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
return insets;
|
||||||
|
}
|
||||||
@@ -1,6 +1,7 @@
|
|||||||
import { describe, test, expect } from 'vitest';
|
import { describe, test, expect } from 'vitest';
|
||||||
import { buildSavePayload } from './useWhpApi';
|
import { buildSavePayload } from './useWhpApi';
|
||||||
import { PageData } from '../types';
|
import { PageData } from '../types';
|
||||||
|
import { DEFAULT_SITE_DESIGN } from '../state/SiteDesignContext';
|
||||||
|
|
||||||
const pageA: PageData = { id: 'home', name: 'Home', slug: 'index', craftState: 'STORED_HOME' };
|
const pageA: PageData = { id: 'home', name: 'Home', slug: 'index', craftState: 'STORED_HOME' };
|
||||||
const pageB: PageData = { id: 'page_2', name: 'About', slug: 'about', craftState: 'STORED_ABOUT' };
|
const pageB: PageData = { id: 'page_2', name: 'About', slug: 'about', craftState: 'STORED_ABOUT' };
|
||||||
@@ -19,6 +20,8 @@ describe('buildSavePayload', () => {
|
|||||||
activePageId: '__header__',
|
activePageId: '__header__',
|
||||||
isEditingHeader: true,
|
isEditingHeader: true,
|
||||||
isEditingFooter: false,
|
isEditingFooter: false,
|
||||||
|
headCode: DEFAULT_SITE_DESIGN.headCode,
|
||||||
|
design: DEFAULT_SITE_DESIGN,
|
||||||
});
|
});
|
||||||
|
|
||||||
// The fresh live canvas must be reflected in header_craft_state, not the stale stored one.
|
// The fresh live canvas must be reflected in header_craft_state, not the stale stored one.
|
||||||
@@ -52,6 +55,8 @@ describe('buildSavePayload', () => {
|
|||||||
activePageId: '__footer__',
|
activePageId: '__footer__',
|
||||||
isEditingHeader: false,
|
isEditingHeader: false,
|
||||||
isEditingFooter: true,
|
isEditingFooter: true,
|
||||||
|
headCode: DEFAULT_SITE_DESIGN.headCode,
|
||||||
|
design: DEFAULT_SITE_DESIGN,
|
||||||
});
|
});
|
||||||
|
|
||||||
expect(payload.footer_craft_state).toBe('LIVE_FOOTER');
|
expect(payload.footer_craft_state).toBe('LIVE_FOOTER');
|
||||||
@@ -75,6 +80,8 @@ describe('buildSavePayload', () => {
|
|||||||
activePageId: 'home',
|
activePageId: 'home',
|
||||||
isEditingHeader: false,
|
isEditingHeader: false,
|
||||||
isEditingFooter: false,
|
isEditingFooter: false,
|
||||||
|
headCode: DEFAULT_SITE_DESIGN.headCode,
|
||||||
|
design: DEFAULT_SITE_DESIGN,
|
||||||
});
|
});
|
||||||
|
|
||||||
// Live canvas goes to the active page and top-level slots.
|
// Live canvas goes to the active page and top-level slots.
|
||||||
@@ -105,6 +112,8 @@ describe('buildSavePayload', () => {
|
|||||||
activePageId: 'home',
|
activePageId: 'home',
|
||||||
isEditingHeader: false,
|
isEditingHeader: false,
|
||||||
isEditingFooter: false,
|
isEditingFooter: false,
|
||||||
|
headCode: DEFAULT_SITE_DESIGN.headCode,
|
||||||
|
design: DEFAULT_SITE_DESIGN,
|
||||||
});
|
});
|
||||||
|
|
||||||
// The live edit must land in pages_craft_state[0] (index.html slot),
|
// The live edit must land in pages_craft_state[0] (index.html slot),
|
||||||
@@ -116,4 +125,26 @@ describe('buildSavePayload', () => {
|
|||||||
// The other page is untouched.
|
// The other page is untouched.
|
||||||
expect(payload.pages_craft_state.find((p) => p.id === 'p2')?.craftState).toBe('STORED_ABOUT_2');
|
expect(payload.pages_craft_state.find((p) => p.id === 'p2')?.craftState).toBe('STORED_ABOUT_2');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('head code + design tokens are included in the save payload', () => {
|
||||||
|
const design = { ...DEFAULT_SITE_DESIGN, headCode: '<meta name="x">' };
|
||||||
|
|
||||||
|
const payload = buildSavePayload({
|
||||||
|
siteId: 1,
|
||||||
|
siteName: 'Test Site',
|
||||||
|
liveCraftState: 'LIVE_PAGE_HOME',
|
||||||
|
pages: [pageA, pageB],
|
||||||
|
headerPage,
|
||||||
|
footerPage,
|
||||||
|
activePageId: 'home',
|
||||||
|
isEditingHeader: false,
|
||||||
|
isEditingFooter: false,
|
||||||
|
headCode: '<meta name="x">',
|
||||||
|
design,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(payload.head_code).toBe('<meta name="x">');
|
||||||
|
expect(payload.design).toEqual(design);
|
||||||
|
expect(payload.design.headCode).toBe('<meta name="x">');
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -2,6 +2,7 @@ import { useCallback } from 'react';
|
|||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import { useEditorConfig } from '../state/EditorConfigContext';
|
import { useEditorConfig } from '../state/EditorConfigContext';
|
||||||
import { usePages } from '../state/PageContext';
|
import { usePages } from '../state/PageContext';
|
||||||
|
import { useSiteDesign, SiteDesign } from '../state/SiteDesignContext';
|
||||||
import { exportBodyHtml } from '../utils/html-export';
|
import { exportBodyHtml } from '../utils/html-export';
|
||||||
import { PageData } from '../types';
|
import { PageData } from '../types';
|
||||||
|
|
||||||
@@ -18,6 +19,10 @@ export interface BuildSavePayloadInput {
|
|||||||
isEditingHeader: boolean;
|
isEditingHeader: boolean;
|
||||||
/** True when the live canvas is showing the footer zone (activePageId === '__footer__'). */
|
/** True when the live canvas is showing the footer zone (activePageId === '__footer__'). */
|
||||||
isEditingFooter: boolean;
|
isEditingFooter: boolean;
|
||||||
|
/** Site-wide custom `<head>` code (also present on `design.headCode`). */
|
||||||
|
headCode: string;
|
||||||
|
/** Full site design tokens object -- lets load() restore colors/fonts/headCode. */
|
||||||
|
design: SiteDesign;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -45,6 +50,8 @@ export function buildSavePayload(input: BuildSavePayloadInput) {
|
|||||||
activePageId,
|
activePageId,
|
||||||
isEditingHeader,
|
isEditingHeader,
|
||||||
isEditingFooter,
|
isEditingFooter,
|
||||||
|
headCode,
|
||||||
|
design,
|
||||||
} = input;
|
} = input;
|
||||||
|
|
||||||
const isPageActive = !isEditingHeader && !isEditingFooter;
|
const isPageActive = !isEditingHeader && !isEditingFooter;
|
||||||
@@ -173,6 +180,8 @@ export function buildSavePayload(input: BuildSavePayloadInput) {
|
|||||||
header_craft_state: headerCraftState,
|
header_craft_state: headerCraftState,
|
||||||
footer_craft_state: footerCraftState,
|
footer_craft_state: footerCraftState,
|
||||||
pages_craft_state: pagesGrapesjs,
|
pages_craft_state: pagesGrapesjs,
|
||||||
|
head_code: headCode,
|
||||||
|
design,
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -191,6 +200,7 @@ export function useWhpApi() {
|
|||||||
setPagesCraftState,
|
setPagesCraftState,
|
||||||
setActivePageIdDirect,
|
setActivePageIdDirect,
|
||||||
} = usePages();
|
} = usePages();
|
||||||
|
const { design, updateDesign } = useSiteDesign();
|
||||||
|
|
||||||
const save = useCallback(async () => {
|
const save = useCallback(async () => {
|
||||||
if (!isWHP || !whpConfig) return null;
|
if (!isWHP || !whpConfig) return null;
|
||||||
@@ -210,6 +220,8 @@ export function useWhpApi() {
|
|||||||
activePageId,
|
activePageId,
|
||||||
isEditingHeader,
|
isEditingHeader,
|
||||||
isEditingFooter,
|
isEditingFooter,
|
||||||
|
headCode: design.headCode,
|
||||||
|
design,
|
||||||
});
|
});
|
||||||
|
|
||||||
const resp = await fetch(`${whpConfig.apiUrl}?action=save`, {
|
const resp = await fetch(`${whpConfig.apiUrl}?action=save`, {
|
||||||
@@ -221,7 +233,7 @@ export function useWhpApi() {
|
|||||||
body: JSON.stringify(payload),
|
body: JSON.stringify(payload),
|
||||||
});
|
});
|
||||||
return resp.json();
|
return resp.json();
|
||||||
}, [isWHP, whpConfig, query, pages, activePageId, headerPage, footerPage, isEditingHeader, isEditingFooter]);
|
}, [isWHP, whpConfig, query, pages, activePageId, headerPage, footerPage, isEditingHeader, isEditingFooter, design]);
|
||||||
|
|
||||||
const publish = useCallback(async () => {
|
const publish = useCallback(async () => {
|
||||||
if (!isWHP || !whpConfig) return null;
|
if (!isWHP || !whpConfig) return null;
|
||||||
@@ -255,6 +267,17 @@ export function useWhpApi() {
|
|||||||
if (data.success && data.project) {
|
if (data.success && data.project) {
|
||||||
const proj = data.project;
|
const proj = data.project;
|
||||||
|
|
||||||
|
// Restore site design tokens (colors/fonts/headCode) so the editor
|
||||||
|
// reflects what was last saved. Prefer the full `design` object when
|
||||||
|
// present; fall back to just `head_code` for older project.json files
|
||||||
|
// saved before this field existed (backward-compatible: defaults for
|
||||||
|
// everything else).
|
||||||
|
if (proj.design && typeof proj.design === 'object') {
|
||||||
|
updateDesign(proj.design);
|
||||||
|
} else if (typeof proj.head_code === 'string') {
|
||||||
|
updateDesign({ headCode: proj.head_code });
|
||||||
|
}
|
||||||
|
|
||||||
// Restore header craft state
|
// Restore header craft state
|
||||||
if (proj.header_craft_state) {
|
if (proj.header_craft_state) {
|
||||||
setHeaderCraftState(typeof proj.header_craft_state === 'string'
|
setHeaderCraftState(typeof proj.header_craft_state === 'string'
|
||||||
@@ -300,7 +323,7 @@ export function useWhpApi() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
return data;
|
return data;
|
||||||
}, [isWHP, whpConfig, actions, setHeaderCraftState, setFooterCraftState, setPagesCraftState, setActivePageIdDirect, isEditingHeader, isEditingFooter]);
|
}, [isWHP, whpConfig, actions, setHeaderCraftState, setFooterCraftState, setPagesCraftState, setActivePageIdDirect, isEditingHeader, isEditingFooter, updateDesign]);
|
||||||
|
|
||||||
const uploadAsset = useCallback(
|
const uploadAsset = useCallback(
|
||||||
async (file: File) => {
|
async (file: File) => {
|
||||||
|
|||||||
@@ -1,10 +1,10 @@
|
|||||||
import React, { useEffect, useCallback, useRef } from 'react';
|
import React, { useEffect, useCallback, useRef } from 'react';
|
||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import { findDeletableTarget } from '../../utils/craft-helpers';
|
|
||||||
import { useSitesmithModal } from '../../state/SitesmithContext';
|
import { useSitesmithModal } from '../../state/SitesmithContext';
|
||||||
import { buildSitesmithTarget } from '../../utils/sitesmith-target';
|
import { buildSitesmithTarget } from '../../utils/sitesmith-target';
|
||||||
import { regenerateTreeIds } from '../../utils/craft-tree';
|
import { regenerateTreeIds } from '../../utils/craft-tree';
|
||||||
import { getClipboardNodeId, setClipboardNodeId } from '../../hooks/clipboard';
|
import { getClipboardNodeId, setClipboardNodeId } from '../../hooks/clipboard';
|
||||||
|
import { useNodeActions } from '../../hooks/useNodeActions';
|
||||||
|
|
||||||
interface ContextMenuProps {
|
interface ContextMenuProps {
|
||||||
visible: boolean;
|
visible: boolean;
|
||||||
@@ -16,6 +16,8 @@ interface ContextMenuProps {
|
|||||||
|
|
||||||
interface MenuItem {
|
interface MenuItem {
|
||||||
label: string;
|
label: string;
|
||||||
|
/** Font Awesome icon suffix (e.g. 'magic' for fa-magic), rendered before the label. */
|
||||||
|
icon?: string;
|
||||||
shortcut?: string;
|
shortcut?: string;
|
||||||
action: () => void;
|
action: () => void;
|
||||||
danger?: boolean;
|
danger?: boolean;
|
||||||
@@ -63,19 +65,16 @@ export const ContextMenu: React.FC<ContextMenuProps> = ({
|
|||||||
}
|
}
|
||||||
}, [nodeId, query]);
|
}, [nodeId, query]);
|
||||||
|
|
||||||
const duplicate = useCallback(() => {
|
// Shared move/duplicate/delete/select-parent logic (item 1, Phase B) --
|
||||||
if (!nodeId || nodeId === 'ROOT') return;
|
// extracted into `useNodeActions` so the mobile selection toolbar drives
|
||||||
try {
|
// the exact same behavior. Wrapped here purely to also `onClose()` the
|
||||||
const parentId = getParentId();
|
// menu after each action, same as before the extraction.
|
||||||
if (!parentId) return;
|
const nodeActions = useNodeActions(nodeId);
|
||||||
|
|
||||||
const tree = regenerateTreeIds(query.node(nodeId).toNodeTree());
|
const duplicate = useCallback(() => {
|
||||||
actions.addNodeTree(tree, parentId);
|
nodeActions.duplicate();
|
||||||
} catch (e) {
|
|
||||||
console.error('Duplicate failed:', e);
|
|
||||||
}
|
|
||||||
onClose();
|
onClose();
|
||||||
}, [nodeId, actions, query, getParentId, onClose]);
|
}, [nodeActions, onClose]);
|
||||||
|
|
||||||
const copyNode = useCallback(() => {
|
const copyNode = useCallback(() => {
|
||||||
if (!nodeId || nodeId === 'ROOT') return;
|
if (!nodeId || nodeId === 'ROOT') return;
|
||||||
@@ -116,47 +115,19 @@ export const ContextMenu: React.FC<ContextMenuProps> = ({
|
|||||||
}, [nodeId, actions, query, onClose]);
|
}, [nodeId, actions, query, onClose]);
|
||||||
|
|
||||||
const moveUp = useCallback(() => {
|
const moveUp = useCallback(() => {
|
||||||
if (!nodeId || nodeId === 'ROOT') return;
|
nodeActions.moveUp();
|
||||||
try {
|
|
||||||
const parentId = getParentId();
|
|
||||||
if (!parentId) return;
|
|
||||||
const parent = query.node(parentId).get();
|
|
||||||
const children = parent.data.nodes || [];
|
|
||||||
const idx = children.indexOf(nodeId);
|
|
||||||
if (idx > 0) {
|
|
||||||
actions.move(nodeId, parentId, idx - 1);
|
|
||||||
}
|
|
||||||
} catch (e) {
|
|
||||||
console.error('Move up failed:', e);
|
|
||||||
}
|
|
||||||
onClose();
|
onClose();
|
||||||
}, [nodeId, actions, query, getParentId, onClose]);
|
}, [nodeActions, onClose]);
|
||||||
|
|
||||||
const moveDown = useCallback(() => {
|
const moveDown = useCallback(() => {
|
||||||
if (!nodeId || nodeId === 'ROOT') return;
|
nodeActions.moveDown();
|
||||||
try {
|
|
||||||
const parentId = getParentId();
|
|
||||||
if (!parentId) return;
|
|
||||||
const parent = query.node(parentId).get();
|
|
||||||
const children = parent.data.nodes || [];
|
|
||||||
const idx = children.indexOf(nodeId);
|
|
||||||
if (idx < children.length - 1) {
|
|
||||||
actions.move(nodeId, parentId, idx + 2);
|
|
||||||
}
|
|
||||||
} catch (e) {
|
|
||||||
console.error('Move down failed:', e);
|
|
||||||
}
|
|
||||||
onClose();
|
onClose();
|
||||||
}, [nodeId, actions, query, getParentId, onClose]);
|
}, [nodeActions, onClose]);
|
||||||
|
|
||||||
const selectParent = useCallback(() => {
|
const selectParent = useCallback(() => {
|
||||||
if (!nodeId || nodeId === 'ROOT') return;
|
nodeActions.selectParent();
|
||||||
const parentId = getParentId();
|
|
||||||
if (parentId) {
|
|
||||||
actions.selectNode(parentId);
|
|
||||||
}
|
|
||||||
onClose();
|
onClose();
|
||||||
}, [nodeId, actions, getParentId, onClose]);
|
}, [nodeActions, onClose]);
|
||||||
|
|
||||||
const askSitesmith = useCallback(() => {
|
const askSitesmith = useCallback(() => {
|
||||||
if (!nodeId || nodeId === 'ROOT') return;
|
if (!nodeId || nodeId === 'ROOT') return;
|
||||||
@@ -170,18 +141,9 @@ export const ContextMenu: React.FC<ContextMenuProps> = ({
|
|||||||
}, [nodeId, query, openSitesmith, onClose]);
|
}, [nodeId, query, openSitesmith, onClose]);
|
||||||
|
|
||||||
const deleteNode = useCallback(() => {
|
const deleteNode = useCallback(() => {
|
||||||
const target = findDeletableTarget(query, nodeId);
|
nodeActions.deleteNode();
|
||||||
if (!target) {
|
|
||||||
onClose();
|
onClose();
|
||||||
return;
|
}, [nodeActions, onClose]);
|
||||||
}
|
|
||||||
try {
|
|
||||||
actions.delete(target);
|
|
||||||
} catch (e) {
|
|
||||||
console.error('Delete failed:', e);
|
|
||||||
}
|
|
||||||
onClose();
|
|
||||||
}, [nodeId, actions, query, onClose]);
|
|
||||||
|
|
||||||
if (!visible) return null;
|
if (!visible) return null;
|
||||||
|
|
||||||
@@ -189,25 +151,29 @@ export const ContextMenu: React.FC<ContextMenuProps> = ({
|
|||||||
|
|
||||||
const items: MenuItem[] = [
|
const items: MenuItem[] = [
|
||||||
{
|
{
|
||||||
label: '✨ Ask Sitesmith',
|
label: 'Ask Sitesmith',
|
||||||
|
icon: 'magic',
|
||||||
action: askSitesmith,
|
action: askSitesmith,
|
||||||
disabled: isRoot,
|
disabled: isRoot,
|
||||||
dividerAfter: true,
|
dividerAfter: true,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: 'Duplicate',
|
label: 'Duplicate',
|
||||||
|
icon: 'clone',
|
||||||
shortcut: 'Ctrl+D',
|
shortcut: 'Ctrl+D',
|
||||||
action: duplicate,
|
action: duplicate,
|
||||||
disabled: isRoot,
|
disabled: isRoot,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: 'Copy',
|
label: 'Copy',
|
||||||
|
icon: 'files-o',
|
||||||
shortcut: 'Ctrl+C',
|
shortcut: 'Ctrl+C',
|
||||||
action: copyNode,
|
action: copyNode,
|
||||||
disabled: isRoot,
|
disabled: isRoot,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: 'Paste',
|
label: 'Paste',
|
||||||
|
icon: 'clipboard',
|
||||||
shortcut: 'Ctrl+V',
|
shortcut: 'Ctrl+V',
|
||||||
action: pasteNode,
|
action: pasteNode,
|
||||||
disabled: !getClipboardNodeId(),
|
disabled: !getClipboardNodeId(),
|
||||||
@@ -215,22 +181,31 @@ export const ContextMenu: React.FC<ContextMenuProps> = ({
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: 'Move Up',
|
label: 'Move Up',
|
||||||
|
icon: 'arrow-up',
|
||||||
action: moveUp,
|
action: moveUp,
|
||||||
disabled: isRoot,
|
disabled: isRoot,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: 'Move Down',
|
label: 'Move Down',
|
||||||
|
icon: 'arrow-down',
|
||||||
action: moveDown,
|
action: moveDown,
|
||||||
disabled: isRoot,
|
disabled: isRoot,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: 'Select Parent',
|
label: 'Select Parent',
|
||||||
|
icon: 'level-up',
|
||||||
action: selectParent,
|
action: selectParent,
|
||||||
disabled: isRoot,
|
// Not just `isRoot`: the real dead-end is when nodeId's PARENT is
|
||||||
|
// ROOT (selecting a top-level section -> Select Parent would only
|
||||||
|
// select the page-wide, un-editable ROOT -- no outline, no toolbar).
|
||||||
|
// `canSelectParent` (useNodeActions) already encodes that and matches
|
||||||
|
// the mobile selection toolbar's identical guard.
|
||||||
|
disabled: !nodeActions.canSelectParent,
|
||||||
dividerAfter: true,
|
dividerAfter: true,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: 'Delete',
|
label: 'Delete',
|
||||||
|
icon: 'trash',
|
||||||
shortcut: 'Del',
|
shortcut: 'Del',
|
||||||
action: deleteNode,
|
action: deleteNode,
|
||||||
danger: true,
|
danger: true,
|
||||||
@@ -291,7 +266,10 @@ export const ContextMenu: React.FC<ContextMenuProps> = ({
|
|||||||
(e.target as HTMLElement).style.background = 'transparent';
|
(e.target as HTMLElement).style.background = 'transparent';
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
<span>{item.label}</span>
|
<span>
|
||||||
|
{item.icon && <i className={`fa fa-${item.icon}`} style={{ marginRight: 6, width: 12 }} />}
|
||||||
|
{item.label}
|
||||||
|
</span>
|
||||||
{item.shortcut && (
|
{item.shortcut && (
|
||||||
<span
|
<span
|
||||||
style={{
|
style={{
|
||||||
|
|||||||
@@ -2,12 +2,14 @@ import React, { useEffect, useRef, useState, useCallback } from 'react';
|
|||||||
import { useAssets } from '../../hooks/useAssets';
|
import { useAssets } from '../../hooks/useAssets';
|
||||||
import { clickableProps } from '../../utils/a11y';
|
import { clickableProps } from '../../utils/a11y';
|
||||||
import { copyToClipboard } from '../../utils/clipboard';
|
import { copyToClipboard } from '../../utils/clipboard';
|
||||||
|
import { useIsMobile } from '../../hooks/useIsMobile';
|
||||||
|
|
||||||
/** How long the "Delete?" confirm state stays armed before auto-resetting. */
|
/** How long the "Delete?" confirm state stays armed before auto-resetting. */
|
||||||
const DELETE_CONFIRM_TIMEOUT_MS = 4000;
|
const DELETE_CONFIRM_TIMEOUT_MS = 4000;
|
||||||
|
|
||||||
export const AssetsPanel: React.FC = () => {
|
export const AssetsPanel: React.FC = () => {
|
||||||
const { assets, loading, error, loadAssets, uploadAsset, deleteAsset } = useAssets();
|
const { assets, loading, error, loadAssets, uploadAsset, deleteAsset } = useAssets();
|
||||||
|
const isMobile = useIsMobile();
|
||||||
const fileInputRef = useRef<HTMLInputElement>(null);
|
const fileInputRef = useRef<HTMLInputElement>(null);
|
||||||
const [isDragOver, setIsDragOver] = useState(false);
|
const [isDragOver, setIsDragOver] = useState(false);
|
||||||
const [copiedUrl, setCopiedUrl] = useState<string | null>(null);
|
const [copiedUrl, setCopiedUrl] = useState<string | null>(null);
|
||||||
@@ -107,23 +109,41 @@ export const AssetsPanel: React.FC = () => {
|
|||||||
{loading ? 'Uploading...' : 'Upload File'}
|
{loading ? 'Uploading...' : 'Upload File'}
|
||||||
</button>
|
</button>
|
||||||
|
|
||||||
{/* Drop zone */}
|
{/* Drop zone -- a single element that doubles as the empty state.
|
||||||
|
Previously this was a small always-visible dropzone PLUS a
|
||||||
|
separate italic "No assets uploaded yet" line stacked underneath
|
||||||
|
it when empty; merged into one tall dropzone (icon + copy,
|
||||||
|
click-or-drag) so the empty state isn't two redundant messages.
|
||||||
|
Once assets exist it collapses back to a slim persistent drop
|
||||||
|
target above the grid. */}
|
||||||
<div
|
<div
|
||||||
onDrop={handleDrop}
|
onDrop={handleDrop}
|
||||||
onDragOver={handleDragOver}
|
onDragOver={handleDragOver}
|
||||||
onDragLeave={handleDragLeave}
|
onDragLeave={handleDragLeave}
|
||||||
|
{...(assets.length === 0 ? clickableProps(() => fileInputRef.current?.click()) : {})}
|
||||||
style={{
|
style={{
|
||||||
padding: 20,
|
display: 'flex',
|
||||||
|
flexDirection: 'column',
|
||||||
|
alignItems: 'center',
|
||||||
|
justifyContent: 'center',
|
||||||
|
gap: 8,
|
||||||
|
padding: assets.length === 0 ? '36px 20px' : 16,
|
||||||
border: `2px dashed ${isDragOver ? 'var(--color-accent)' : 'var(--color-border)'}`,
|
border: `2px dashed ${isDragOver ? 'var(--color-accent)' : 'var(--color-border)'}`,
|
||||||
borderRadius: 'var(--radius-md)',
|
borderRadius: 'var(--radius-md)',
|
||||||
background: isDragOver ? 'var(--color-accent-subtle)' : 'transparent',
|
background: isDragOver ? 'var(--color-accent-subtle)' : 'transparent',
|
||||||
textAlign: 'center',
|
textAlign: 'center',
|
||||||
color: isDragOver ? 'var(--color-accent)' : 'var(--color-text-dim)',
|
color: isDragOver ? 'var(--color-accent)' : 'var(--color-text-dim)',
|
||||||
fontSize: 11,
|
fontSize: 11,
|
||||||
|
cursor: assets.length === 0 ? 'pointer' : 'default',
|
||||||
transition: 'all var(--transition-fast)',
|
transition: 'all var(--transition-fast)',
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
Drop files here to upload
|
{assets.length === 0 && (
|
||||||
|
<i className="fa fa-cloud-upload" aria-hidden style={{ fontSize: 28, opacity: 0.5 }} />
|
||||||
|
)}
|
||||||
|
{assets.length === 0
|
||||||
|
? (isMobile ? 'Tap to upload images' : 'Drag images here or click to upload')
|
||||||
|
: 'Drop files here to upload'}
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{/* Error message */}
|
{/* Error message */}
|
||||||
@@ -143,20 +163,6 @@ export const AssetsPanel: React.FC = () => {
|
|||||||
)}
|
)}
|
||||||
|
|
||||||
{/* Asset grid */}
|
{/* Asset grid */}
|
||||||
{assets.length === 0 && !loading && (
|
|
||||||
<div
|
|
||||||
style={{
|
|
||||||
textAlign: 'center',
|
|
||||||
padding: 20,
|
|
||||||
color: 'var(--color-text-dim)',
|
|
||||||
fontSize: 12,
|
|
||||||
fontStyle: 'italic',
|
|
||||||
}}
|
|
||||||
>
|
|
||||||
No assets uploaded yet
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
|
|
||||||
<div
|
<div
|
||||||
style={{
|
style={{
|
||||||
display: 'grid',
|
display: 'grid',
|
||||||
@@ -296,7 +302,7 @@ export const AssetsPanel: React.FC = () => {
|
|||||||
cursor: 'pointer',
|
cursor: 'pointer',
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
✕
|
<i className="fa fa-times" aria-hidden />
|
||||||
</button>
|
</button>
|
||||||
</div>
|
</div>
|
||||||
) : (
|
) : (
|
||||||
@@ -328,7 +334,7 @@ export const AssetsPanel: React.FC = () => {
|
|||||||
onMouseEnter={(e) => { (e.target as HTMLElement).style.opacity = '1'; }}
|
onMouseEnter={(e) => { (e.target as HTMLElement).style.opacity = '1'; }}
|
||||||
onMouseLeave={(e) => { (e.target as HTMLElement).style.opacity = '0.7'; }}
|
onMouseLeave={(e) => { (e.target as HTMLElement).style.opacity = '0.7'; }}
|
||||||
>
|
>
|
||||||
✕
|
<i className="fa fa-times" aria-hidden />
|
||||||
</button>
|
</button>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -1,5 +1,7 @@
|
|||||||
import React, { useState } from 'react';
|
import React, { useCallback, useState } from 'react';
|
||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
|
import { useIsMobile } from '../../hooks/useIsMobile';
|
||||||
|
import { useMobileChrome } from '../../state/MobileChromeContext';
|
||||||
import { Container } from '../../components/layout/Container';
|
import { Container } from '../../components/layout/Container';
|
||||||
import { Section } from '../../components/layout/Section';
|
import { Section } from '../../components/layout/Section';
|
||||||
import { ColumnLayout } from '../../components/layout/ColumnLayout';
|
import { ColumnLayout } from '../../components/layout/ColumnLayout';
|
||||||
@@ -123,7 +125,7 @@ const categories: CategoryDef[] = [
|
|||||||
label: 'Media',
|
label: 'Media',
|
||||||
blocks: [
|
blocks: [
|
||||||
{ id: 'image', label: 'Image', icon: 'fa-image',
|
{ id: 'image', label: 'Image', icon: 'fa-image',
|
||||||
component: <ImageBlock src="" alt="Image" style={{ maxWidth: '100%', height: 'auto', display: 'block', borderRadius: '8px' }} /> },
|
component: <ImageBlock alt="Image" style={{ maxWidth: '100%', height: 'auto', display: 'block', borderRadius: '8px' }} /> },
|
||||||
{ id: 'video', label: 'Video', icon: 'fa-play-circle',
|
{ id: 'video', label: 'Video', icon: 'fa-play-circle',
|
||||||
component: <VideoBlock videoUrl="" isBackground={false} /> },
|
component: <VideoBlock videoUrl="" isBackground={false} /> },
|
||||||
{ id: 'map-embed', label: 'Map', icon: 'fa-map-marker',
|
{ id: 'map-embed', label: 'Map', icon: 'fa-map-marker',
|
||||||
@@ -146,6 +148,8 @@ const categories: CategoryDef[] = [
|
|||||||
|
|
||||||
export const BlocksPanel: React.FC = () => {
|
export const BlocksPanel: React.FC = () => {
|
||||||
const { connectors, actions, query } = useEditor();
|
const { connectors, actions, query } = useEditor();
|
||||||
|
const isMobile = useIsMobile();
|
||||||
|
const { closeSheet } = useMobileChrome();
|
||||||
const [collapsed, setCollapsed] = useState<Record<string, boolean>>(() => {
|
const [collapsed, setCollapsed] = useState<Record<string, boolean>>(() => {
|
||||||
const initial: Record<string, boolean> = {};
|
const initial: Record<string, boolean> = {};
|
||||||
categories.forEach((cat, index) => {
|
categories.forEach((cat, index) => {
|
||||||
@@ -158,6 +162,101 @@ export const BlocksPanel: React.FC = () => {
|
|||||||
setCollapsed((prev) => ({ ...prev, [categoryId]: !prev[categoryId] }));
|
setCollapsed((prev) => ({ ...prev, [categoryId]: !prev[categoryId] }));
|
||||||
};
|
};
|
||||||
|
|
||||||
|
/** Default insertion target when there's no usable selection to anchor
|
||||||
|
* to: the first real Craft.js canvas in the document (falls back to
|
||||||
|
* ROOT). Extracted from the pre-existing onDoubleClick handler so
|
||||||
|
* tap-to-add (mobile, item 3) and double-click (desktop, unchanged) share
|
||||||
|
* the exact same fallback. */
|
||||||
|
const findDefaultCanvasId = useCallback((): string => {
|
||||||
|
try {
|
||||||
|
const serialized = JSON.parse(query.serialize());
|
||||||
|
const nodeIds = Object.keys(serialized);
|
||||||
|
for (const id of nodeIds) {
|
||||||
|
if (serialized[id].isCanvas && id !== 'ROOT') return id;
|
||||||
|
}
|
||||||
|
} catch {
|
||||||
|
// Fall through to ROOT below.
|
||||||
|
}
|
||||||
|
return 'ROOT';
|
||||||
|
}, [query]);
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Builds a fresh node tree for `block` and inserts it into the canvas,
|
||||||
|
* returning the new node's id (or null on failure). Shared by desktop's
|
||||||
|
* double-click (unchanged behavior/position: always appended to
|
||||||
|
* `findDefaultCanvasId()`) and mobile's tap-to-add (item 3), which instead
|
||||||
|
* prefers inserting as a sibling right after the current selection --
|
||||||
|
* `insertAfterSelection: true` only from the mobile tap handler below.
|
||||||
|
*/
|
||||||
|
const addBlockNode = useCallback((block: BlockDef, insertAfterSelection: boolean): string | null => {
|
||||||
|
try {
|
||||||
|
const tree = query.parseReactElement(React.cloneElement(block.component)).toNodeTree();
|
||||||
|
|
||||||
|
let inserted = false;
|
||||||
|
if (insertAfterSelection) {
|
||||||
|
try {
|
||||||
|
const selectedIds = query.getEvent('selected').all();
|
||||||
|
const selectedId = selectedIds.length > 0 ? selectedIds[0] : null;
|
||||||
|
if (selectedId && selectedId !== 'ROOT') {
|
||||||
|
const selectedNode = query.node(selectedId).get();
|
||||||
|
const parentId = selectedNode?.data?.parent;
|
||||||
|
if (parentId) {
|
||||||
|
const parent = query.node(parentId).get();
|
||||||
|
const siblings: string[] = parent?.data?.nodes || [];
|
||||||
|
const idx = siblings.indexOf(selectedId);
|
||||||
|
if (idx !== -1) {
|
||||||
|
actions.addNodeTree(tree, parentId, idx + 1);
|
||||||
|
inserted = true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} catch {
|
||||||
|
// Selection isn't a valid sibling target (e.g. lives in a
|
||||||
|
// linkedNodes slot) -- fall through to the default canvas below.
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!inserted) {
|
||||||
|
actions.addNodeTree(tree, findDefaultCanvasId());
|
||||||
|
}
|
||||||
|
|
||||||
|
return tree.rootNodeId;
|
||||||
|
} catch (e) {
|
||||||
|
console.error('Failed to add block:', e);
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
}, [query, actions, findDefaultCanvasId]);
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Mobile tap-to-add (item 3): a single tap on a block tile inserts it,
|
||||||
|
* closes the Blocks sheet, then selects the new node and scrolls it into
|
||||||
|
* view so the user immediately sees it (and gets the selection toolbar).
|
||||||
|
* The select/scroll step is deferred two animation frames past the
|
||||||
|
* `addNodeTree` call -- Craft.js's own state update (and thus the new
|
||||||
|
* node's real DOM element) lands asynchronously after this handler
|
||||||
|
* returns, so `query.node(id).get().dom` isn't populated yet if read
|
||||||
|
* synchronously here.
|
||||||
|
*/
|
||||||
|
const handleTapToAdd = useCallback((block: BlockDef) => {
|
||||||
|
const newId = addBlockNode(block, true);
|
||||||
|
closeSheet();
|
||||||
|
if (!newId) return;
|
||||||
|
requestAnimationFrame(() => {
|
||||||
|
try {
|
||||||
|
actions.selectNode(newId);
|
||||||
|
} catch {
|
||||||
|
// Node may have failed to mount -- nothing to select.
|
||||||
|
}
|
||||||
|
requestAnimationFrame(() => {
|
||||||
|
try {
|
||||||
|
query.node(newId).get()?.dom?.scrollIntoView({ behavior: 'smooth', block: 'center' });
|
||||||
|
} catch {
|
||||||
|
// Best-effort scroll -- not fatal if the node/DOM isn't found.
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
}, [addBlockNode, closeSheet, actions, query]);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div>
|
<div>
|
||||||
{categories.map((category) => {
|
{categories.map((category) => {
|
||||||
@@ -178,24 +277,9 @@ export const BlocksPanel: React.FC = () => {
|
|||||||
key={block.id}
|
key={block.id}
|
||||||
className="block-item"
|
className="block-item"
|
||||||
ref={(ref) => { if (ref) connectors.create(ref, block.component); }}
|
ref={(ref) => { if (ref) connectors.create(ref, block.component); }}
|
||||||
onDoubleClick={() => {
|
onDoubleClick={() => addBlockNode(block, false)}
|
||||||
try {
|
onClick={isMobile ? () => handleTapToAdd(block) : undefined}
|
||||||
const serialized = JSON.parse(query.serialize());
|
title={isMobile ? `Tap to add ${block.label}` : `Drag or double-click to add ${block.label}`}
|
||||||
const nodeIds = Object.keys(serialized);
|
|
||||||
let canvasId = 'ROOT';
|
|
||||||
for (const nodeId of nodeIds) {
|
|
||||||
if (serialized[nodeId].isCanvas && nodeId !== 'ROOT') {
|
|
||||||
canvasId = nodeId;
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
const tree = query.parseReactElement(React.cloneElement(block.component)).toNodeTree();
|
|
||||||
actions.addNodeTree(tree, canvasId);
|
|
||||||
} catch (e) {
|
|
||||||
console.error('Failed to add block:', e);
|
|
||||||
}
|
|
||||||
}}
|
|
||||||
title={`Drag or double-click to add ${block.label}`}
|
|
||||||
>
|
>
|
||||||
<i className={`fa ${block.icon} block-item-icon`} />
|
<i className={`fa ${block.icon} block-item-icon`} />
|
||||||
<span className="block-item-label">{block.label}</span>
|
<span className="block-item-label">{block.label}</span>
|
||||||
|
|||||||
@@ -1,14 +1,74 @@
|
|||||||
import React, { useCallback } from 'react';
|
import React, { useCallback, useEffect, useRef } from 'react';
|
||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import { clickableProps } from '../../utils/a11y';
|
import { clickableProps } from '../../utils/a11y';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Per-type icon lookup keyed by the component's `craft.displayName` (the
|
||||||
|
* same human label `LayerNode` already resolves and shows as the row text).
|
||||||
|
* Mirrors the icon choices in `BlocksPanel.tsx` where a block exists for the
|
||||||
|
* type; the remaining entries (Navbar, Container, Section, Columns,
|
||||||
|
* Background Section, Map, Video, Image, form fields, and the richer
|
||||||
|
* section blocks not draggable from the Basic/Sections categories) get a
|
||||||
|
* sensible FA4 icon of their own. Unknown/future types fall back to
|
||||||
|
* `DEFAULT_ICON`.
|
||||||
|
*/
|
||||||
|
const TYPE_ICONS: Record<string, string> = {
|
||||||
|
// Layout
|
||||||
|
Container: 'fa-square-o',
|
||||||
|
Section: 'fa-window-maximize',
|
||||||
|
Columns: 'fa-th-large',
|
||||||
|
'Background Section': 'fa-picture-o',
|
||||||
|
// Basic
|
||||||
|
Heading: 'fa-header',
|
||||||
|
Text: 'fa-paragraph',
|
||||||
|
Button: 'fa-square',
|
||||||
|
Logo: 'fa-bookmark',
|
||||||
|
Menu: 'fa-bars',
|
||||||
|
Navbar: 'fa-bars',
|
||||||
|
Footer: 'fa-window-minimize',
|
||||||
|
Divider: 'fa-minus',
|
||||||
|
Spacer: 'fa-arrows-v',
|
||||||
|
Icon: 'fa-star',
|
||||||
|
'Star Rating': 'fa-star-half-o',
|
||||||
|
'Social Links': 'fa-share-alt',
|
||||||
|
'Search Bar': 'fa-search',
|
||||||
|
HTML: 'fa-code',
|
||||||
|
// Media
|
||||||
|
Image: 'fa-image',
|
||||||
|
Video: 'fa-play-circle',
|
||||||
|
Map: 'fa-map-marker',
|
||||||
|
// Sections
|
||||||
|
Hero: 'fa-star-o',
|
||||||
|
'Features Grid': 'fa-th-large',
|
||||||
|
'CTA Section': 'fa-bullhorn',
|
||||||
|
'Call to Action': 'fa-bullhorn',
|
||||||
|
Countdown: 'fa-clock-o',
|
||||||
|
Testimonials: 'fa-quote-left',
|
||||||
|
'Content Slider': 'fa-sliders',
|
||||||
|
'Number Counter': 'fa-sort-numeric-asc',
|
||||||
|
Accordion: 'fa-list',
|
||||||
|
Tabs: 'fa-folder-o',
|
||||||
|
'Pricing Table': 'fa-usd',
|
||||||
|
Gallery: 'fa-th',
|
||||||
|
// Forms
|
||||||
|
Form: 'fa-wpforms',
|
||||||
|
Input: 'fa-i-cursor',
|
||||||
|
Textarea: 'fa-align-left',
|
||||||
|
'Submit Button': 'fa-paper-plane',
|
||||||
|
'Contact Form': 'fa-envelope',
|
||||||
|
'Subscribe Form': 'fa-paper-plane',
|
||||||
|
};
|
||||||
|
|
||||||
|
const DEFAULT_ICON = 'fa-cube';
|
||||||
|
const ROOT_ICON = 'fa-desktop';
|
||||||
|
|
||||||
interface LayerNodeProps {
|
interface LayerNodeProps {
|
||||||
nodeId: string;
|
nodeId: string;
|
||||||
depth: number;
|
depth: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
||||||
const { node, selectedId, actions } = useEditor((state) => {
|
const { node, selectedId, actions, query } = useEditor((state) => {
|
||||||
const n = state.nodes[nodeId];
|
const n = state.nodes[nodeId];
|
||||||
const selectedIds = state.events.selected;
|
const selectedIds = state.events.selected;
|
||||||
const selId = selectedIds ? Array.from(selectedIds)[0] : null;
|
const selId = selectedIds ? Array.from(selectedIds)[0] : null;
|
||||||
@@ -18,28 +78,77 @@ const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
|||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const isSelected = selectedId === nodeId;
|
||||||
|
|
||||||
const handleActivate = useCallback(() => {
|
const handleActivate = useCallback(() => {
|
||||||
actions.selectNode(nodeId);
|
actions.selectNode(nodeId);
|
||||||
}, [actions, nodeId]);
|
}, [actions, nodeId]);
|
||||||
|
|
||||||
|
// Layers-panel <-> canvas hover sync (Item 12): tags the target node's own
|
||||||
|
// DOM element (found via `query`) with `data-layer-hovered` directly.
|
||||||
|
// `RenderNode.tsx` mirrors Craft's *own* `hovered` node event onto
|
||||||
|
// `data-craft-hovered` for the (separate, mouse-driven) canvas hover
|
||||||
|
// outline -- editor.css's rule matches both attributes. This panel can't
|
||||||
|
// reuse that path: `setNodeEvent` is a private action that `useEditor()`
|
||||||
|
// strips from its `actions` return at runtime (see
|
||||||
|
// @craftjs/core/dist/esm's `xe()` action stripper, not just its TypeScript
|
||||||
|
// type), so calling it here throws. Writing our own attribute directly is
|
||||||
|
// a supported, version-stable way to get the same highlight.
|
||||||
|
const hoveredDomRef = useRef<HTMLElement | null>(null);
|
||||||
|
|
||||||
|
const handleMouseEnter = useCallback(
|
||||||
|
(e: React.MouseEvent<HTMLElement> | React.FocusEvent<HTMLElement>) => {
|
||||||
|
const dom = query.node(nodeId).get()?.dom;
|
||||||
|
if (dom) {
|
||||||
|
dom.setAttribute('data-layer-hovered', '');
|
||||||
|
hoveredDomRef.current = dom;
|
||||||
|
}
|
||||||
|
if (!isSelected) {
|
||||||
|
(e.currentTarget as HTMLElement).style.background = 'var(--color-bg-hover)';
|
||||||
|
}
|
||||||
|
},
|
||||||
|
[query, nodeId, isSelected],
|
||||||
|
);
|
||||||
|
|
||||||
|
const handleMouseLeave = useCallback(
|
||||||
|
(e: React.MouseEvent<HTMLElement> | React.FocusEvent<HTMLElement>) => {
|
||||||
|
hoveredDomRef.current?.removeAttribute('data-layer-hovered');
|
||||||
|
hoveredDomRef.current = null;
|
||||||
|
if (!isSelected) {
|
||||||
|
(e.currentTarget as HTMLElement).style.background = 'transparent';
|
||||||
|
}
|
||||||
|
},
|
||||||
|
[isSelected],
|
||||||
|
);
|
||||||
|
|
||||||
|
// Safety net: if this row unmounts (e.g. the user switches away from the
|
||||||
|
// Layers tab, or the tree re-shuffles) while still hovered, clear the
|
||||||
|
// attribute so it doesn't get stuck highlighted on the canvas forever.
|
||||||
|
useEffect(() => {
|
||||||
|
return () => {
|
||||||
|
hoveredDomRef.current?.removeAttribute('data-layer-hovered');
|
||||||
|
hoveredDomRef.current = null;
|
||||||
|
};
|
||||||
|
}, []);
|
||||||
|
|
||||||
if (!node) return null;
|
if (!node) return null;
|
||||||
|
|
||||||
const isSelected = selectedId === nodeId;
|
|
||||||
const nodeType = node.data.type;
|
|
||||||
const resolvedName = typeof nodeType === 'object' && nodeType !== null && 'resolvedName' in nodeType
|
|
||||||
? (nodeType as any).resolvedName
|
|
||||||
: typeof nodeType === 'string' ? nodeType : undefined;
|
|
||||||
const displayName = (node.data.props?.aiName as string) || node.data.displayName || (node.data.type as any)?.resolvedName || 'Node';
|
const displayName = (node.data.props?.aiName as string) || node.data.displayName || (node.data.type as any)?.resolvedName || 'Node';
|
||||||
const childNodeIds: string[] = node.data.nodes || [];
|
const childNodeIds: string[] = node.data.nodes || [];
|
||||||
const linkedNodeIds: string[] = Object.values(node.data.linkedNodes || {}) as string[];
|
const linkedNodeIds: string[] = Object.values(node.data.linkedNodes || {}) as string[];
|
||||||
const allChildren = [...childNodeIds, ...linkedNodeIds];
|
const allChildren = [...childNodeIds, ...linkedNodeIds];
|
||||||
const isRoot = nodeId === 'ROOT';
|
const isRoot = nodeId === 'ROOT';
|
||||||
|
const icon = isRoot ? ROOT_ICON : TYPE_ICONS[displayName] || DEFAULT_ICON;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div>
|
<div>
|
||||||
<div
|
<div
|
||||||
{...clickableProps(handleActivate)}
|
{...clickableProps(handleActivate)}
|
||||||
|
onMouseEnter={handleMouseEnter}
|
||||||
|
onMouseLeave={handleMouseLeave}
|
||||||
|
className="layer-node-row"
|
||||||
style={{
|
style={{
|
||||||
|
position: 'relative',
|
||||||
display: 'flex',
|
display: 'flex',
|
||||||
alignItems: 'center',
|
alignItems: 'center',
|
||||||
padding: '5px 8px',
|
padding: '5px 8px',
|
||||||
@@ -56,30 +165,53 @@ const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
|||||||
textOverflow: 'ellipsis',
|
textOverflow: 'ellipsis',
|
||||||
userSelect: 'none',
|
userSelect: 'none',
|
||||||
}}
|
}}
|
||||||
onMouseEnter={(e) => {
|
onFocus={handleMouseEnter}
|
||||||
if (!isSelected) {
|
onBlur={handleMouseLeave}
|
||||||
(e.currentTarget as HTMLElement).style.background = 'var(--color-bg-hover)';
|
|
||||||
}
|
|
||||||
}}
|
|
||||||
onMouseLeave={(e) => {
|
|
||||||
if (!isSelected) {
|
|
||||||
(e.currentTarget as HTMLElement).style.background = 'transparent';
|
|
||||||
}
|
|
||||||
}}
|
|
||||||
>
|
>
|
||||||
{/* Indentation indicator */}
|
{/* Indent guides: one vertical line per ancestor depth level,
|
||||||
{allChildren.length > 0 && (
|
aligned under each ancestor's disclosure/icon column so nested
|
||||||
<span style={{ marginRight: 4, fontSize: 8, color: 'var(--color-text-dim)' }}>
|
rows read as a tree instead of a flat, ever-further-indented list. */}
|
||||||
|
{Array.from({ length: depth }).map((_, level) => (
|
||||||
|
<span
|
||||||
|
key={level}
|
||||||
|
aria-hidden="true"
|
||||||
|
style={{
|
||||||
|
position: 'absolute',
|
||||||
|
left: `${8 + level * 16 + 4}px`,
|
||||||
|
top: 0,
|
||||||
|
bottom: 0,
|
||||||
|
width: 1,
|
||||||
|
background: 'var(--color-border)',
|
||||||
|
}}
|
||||||
|
/>
|
||||||
|
))}
|
||||||
|
|
||||||
|
{/* Indentation/disclosure indicator */}
|
||||||
|
{allChildren.length > 0 ? (
|
||||||
|
<span style={{ marginRight: 4, fontSize: 8, color: 'var(--color-text-dim)', flexShrink: 0 }}>
|
||||||
▼
|
▼
|
||||||
</span>
|
</span>
|
||||||
)}
|
) : (
|
||||||
{allChildren.length === 0 && (
|
<span style={{ marginRight: 4, fontSize: 8, color: 'transparent', flexShrink: 0 }}>
|
||||||
<span style={{ marginRight: 4, fontSize: 8, color: 'transparent' }}>
|
|
||||||
▼
|
▼
|
||||||
</span>
|
</span>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{/* Component type icon and name */}
|
{/* Component type icon */}
|
||||||
|
<i
|
||||||
|
className={`fa ${icon}`}
|
||||||
|
aria-hidden="true"
|
||||||
|
style={{
|
||||||
|
marginRight: 6,
|
||||||
|
fontSize: 11,
|
||||||
|
width: 12,
|
||||||
|
textAlign: 'center',
|
||||||
|
flexShrink: 0,
|
||||||
|
color: isSelected ? 'var(--color-accent)' : 'var(--color-text-dim)',
|
||||||
|
}}
|
||||||
|
/>
|
||||||
|
|
||||||
|
{/* Name */}
|
||||||
<span style={{ overflow: 'hidden', textOverflow: 'ellipsis' }}>
|
<span style={{ overflow: 'hidden', textOverflow: 'ellipsis' }}>
|
||||||
{isRoot ? 'Canvas (Root)' : displayName}
|
{isRoot ? 'Canvas (Root)' : displayName}
|
||||||
</span>
|
</span>
|
||||||
|
|||||||
@@ -58,18 +58,23 @@ export const PagesPanel: React.FC = () => {
|
|||||||
.replace(/-+/g, '-');
|
.replace(/-+/g, '-');
|
||||||
};
|
};
|
||||||
|
|
||||||
/* ---------- Zone button style ---------- */
|
/* ---------- Zone row style ----------
|
||||||
const zoneButtonStyle = (isActive: boolean): React.CSSProperties => ({
|
* Same neutral surface language as the page-list rows below (Item 11) --
|
||||||
|
* header/footer are just two more items in the tree, not a louder,
|
||||||
|
* differently-colored category. The active/editing state reuses the same
|
||||||
|
* accent-outline treatment the page list already uses for the active page,
|
||||||
|
* so there's one consistent "this is what's currently open" affordance. */
|
||||||
|
const zoneRowStyle = (isActive: boolean): React.CSSProperties => ({
|
||||||
display: 'flex',
|
display: 'flex',
|
||||||
alignItems: 'center',
|
alignItems: 'center',
|
||||||
gap: 8,
|
gap: 8,
|
||||||
width: '100%',
|
width: '100%',
|
||||||
padding: '10px 12px',
|
padding: '7px 10px',
|
||||||
fontSize: 12,
|
fontSize: 12,
|
||||||
fontWeight: 600,
|
fontWeight: isActive ? 600 : 500,
|
||||||
color: isActive ? '#f59e0b' : '#fbbf24',
|
color: isActive ? 'var(--color-accent)' : 'var(--color-text-muted)',
|
||||||
background: isActive ? 'rgba(245, 158, 11, 0.15)' : 'rgba(245, 158, 11, 0.06)',
|
background: isActive ? 'var(--color-accent-subtle)' : 'var(--color-bg-elevated)',
|
||||||
border: `1px solid ${isActive ? 'rgba(245, 158, 11, 0.5)' : 'rgba(245, 158, 11, 0.2)'}`,
|
border: `1px solid ${isActive ? 'var(--color-accent)' : 'var(--color-border)'}`,
|
||||||
borderRadius: 'var(--radius-md)',
|
borderRadius: 'var(--radius-md)',
|
||||||
cursor: 'pointer',
|
cursor: 'pointer',
|
||||||
transition: 'all var(--transition-fast)',
|
transition: 'all var(--transition-fast)',
|
||||||
@@ -78,57 +83,35 @@ export const PagesPanel: React.FC = () => {
|
|||||||
|
|
||||||
return (
|
return (
|
||||||
<div style={{ display: 'flex', flexDirection: 'column', gap: 8 }}>
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 8 }}>
|
||||||
{/* Header/Footer zone buttons */}
|
{/* Header/Footer zone rows */}
|
||||||
<div style={{ display: 'flex', flexDirection: 'column', gap: 6, marginBottom: 8 }}>
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 6, marginBottom: 8 }}>
|
||||||
<button
|
<button
|
||||||
onClick={editHeader}
|
onClick={editHeader}
|
||||||
style={zoneButtonStyle(isEditingHeader)}
|
className="zone-row"
|
||||||
|
style={zoneRowStyle(isEditingHeader)}
|
||||||
|
title="Appears on all pages"
|
||||||
>
|
>
|
||||||
<i className="fa fa-window-maximize" style={{ fontSize: 13 }} />
|
<i className="fa fa-window-maximize" style={{ fontSize: 12, width: 14, textAlign: 'center', flexShrink: 0 }} />
|
||||||
<div style={{ flex: 1 }}>
|
<span style={{ flex: 1 }}>Header</span>
|
||||||
<div>Edit Header</div>
|
{isEditingHeader ? (
|
||||||
<div style={{ fontSize: 10, opacity: 0.7, fontWeight: 400, marginTop: 1 }}>
|
<i className="fa fa-check-circle" style={{ fontSize: 11 }} aria-hidden />
|
||||||
Appears on all pages
|
) : (
|
||||||
</div>
|
<i className="fa fa-pencil zone-row-pencil" style={{ fontSize: 11 }} aria-hidden />
|
||||||
</div>
|
|
||||||
{isEditingHeader && (
|
|
||||||
<span style={{
|
|
||||||
fontSize: 9,
|
|
||||||
fontWeight: 700,
|
|
||||||
textTransform: 'uppercase',
|
|
||||||
letterSpacing: '0.5px',
|
|
||||||
background: 'rgba(245, 158, 11, 0.25)',
|
|
||||||
padding: '2px 6px',
|
|
||||||
borderRadius: 'var(--radius-sm)',
|
|
||||||
}}>
|
|
||||||
Editing
|
|
||||||
</span>
|
|
||||||
)}
|
)}
|
||||||
</button>
|
</button>
|
||||||
|
|
||||||
<button
|
<button
|
||||||
onClick={editFooter}
|
onClick={editFooter}
|
||||||
style={zoneButtonStyle(isEditingFooter)}
|
className="zone-row"
|
||||||
|
style={zoneRowStyle(isEditingFooter)}
|
||||||
|
title="Appears on all pages"
|
||||||
>
|
>
|
||||||
<i className="fa fa-window-minimize" style={{ fontSize: 13 }} />
|
<i className="fa fa-window-minimize" style={{ fontSize: 12, width: 14, textAlign: 'center', flexShrink: 0 }} />
|
||||||
<div style={{ flex: 1 }}>
|
<span style={{ flex: 1 }}>Footer</span>
|
||||||
<div>Edit Footer</div>
|
{isEditingFooter ? (
|
||||||
<div style={{ fontSize: 10, opacity: 0.7, fontWeight: 400, marginTop: 1 }}>
|
<i className="fa fa-check-circle" style={{ fontSize: 11 }} aria-hidden />
|
||||||
Appears on all pages
|
) : (
|
||||||
</div>
|
<i className="fa fa-pencil zone-row-pencil" style={{ fontSize: 11 }} aria-hidden />
|
||||||
</div>
|
|
||||||
{isEditingFooter && (
|
|
||||||
<span style={{
|
|
||||||
fontSize: 9,
|
|
||||||
fontWeight: 700,
|
|
||||||
textTransform: 'uppercase',
|
|
||||||
letterSpacing: '0.5px',
|
|
||||||
background: 'rgba(245, 158, 11, 0.25)',
|
|
||||||
padding: '2px 6px',
|
|
||||||
borderRadius: 'var(--radius-sm)',
|
|
||||||
}}>
|
|
||||||
Editing
|
|
||||||
</span>
|
|
||||||
)}
|
)}
|
||||||
</button>
|
</button>
|
||||||
</div>
|
</div>
|
||||||
@@ -328,18 +311,21 @@ export const PagesPanel: React.FC = () => {
|
|||||||
title="This is the landing page — published as the root URL (index.html)"
|
title="This is the landing page — published as the root URL (index.html)"
|
||||||
style={{
|
style={{
|
||||||
fontSize: 9,
|
fontSize: 9,
|
||||||
fontWeight: 700,
|
fontWeight: 600,
|
||||||
textTransform: 'uppercase',
|
letterSpacing: '0.3px',
|
||||||
letterSpacing: '0.5px',
|
color: 'var(--color-text-muted)',
|
||||||
color: '#fbbf24',
|
background: 'transparent',
|
||||||
background: 'rgba(245, 158, 11, 0.15)',
|
border: '1px solid var(--color-border-light)',
|
||||||
border: '1px solid rgba(245, 158, 11, 0.35)',
|
|
||||||
padding: '1px 5px',
|
padding: '1px 5px',
|
||||||
borderRadius: 'var(--radius-sm)',
|
borderRadius: 'var(--radius-sm)',
|
||||||
flexShrink: 0,
|
flexShrink: 0,
|
||||||
|
display: 'inline-flex',
|
||||||
|
alignItems: 'center',
|
||||||
|
gap: 4,
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
<i className="fa fa-home" style={{ marginRight: 3 }} />Landing
|
<i className="fa fa-home" aria-hidden="true" style={{ fontSize: 8, color: 'inherit' }} />
|
||||||
|
Landing
|
||||||
</span>
|
</span>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
@@ -359,7 +345,8 @@ export const PagesPanel: React.FC = () => {
|
|||||||
>
|
>
|
||||||
<button
|
<button
|
||||||
onClick={() => startEditing(page)}
|
onClick={() => startEditing(page)}
|
||||||
title="Rename"
|
data-tooltip="Rename"
|
||||||
|
aria-label={`Rename ${page.name}`}
|
||||||
style={{
|
style={{
|
||||||
width: 24,
|
width: 24,
|
||||||
height: 24,
|
height: 24,
|
||||||
@@ -374,12 +361,13 @@ export const PagesPanel: React.FC = () => {
|
|||||||
cursor: 'pointer',
|
cursor: 'pointer',
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
✎
|
<i className="fa fa-pencil" aria-hidden="true" />
|
||||||
</button>
|
</button>
|
||||||
{pages.length > 1 && !isLanding && (
|
{pages.length > 1 && !isLanding && (
|
||||||
<button
|
<button
|
||||||
onClick={() => setDeleteConfirmId(page.id)}
|
onClick={() => setDeleteConfirmId(page.id)}
|
||||||
title="Delete"
|
data-tooltip="Delete"
|
||||||
|
aria-label={`Delete ${page.name}`}
|
||||||
style={{
|
style={{
|
||||||
width: 24,
|
width: 24,
|
||||||
height: 24,
|
height: 24,
|
||||||
@@ -394,7 +382,7 @@ export const PagesPanel: React.FC = () => {
|
|||||||
cursor: 'pointer',
|
cursor: 'pointer',
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
✕
|
<i className="fa fa-trash" aria-hidden="true" />
|
||||||
</button>
|
</button>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -0,0 +1,184 @@
|
|||||||
|
import React, { useCallback, useEffect, useRef, useState } from 'react';
|
||||||
|
import { useVisualViewportInsets } from '../../hooks/useVisualViewport';
|
||||||
|
|
||||||
|
export interface BottomSheetProps {
|
||||||
|
open: boolean;
|
||||||
|
onClose: () => void;
|
||||||
|
title: string;
|
||||||
|
children: React.ReactNode;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Vertical drag distance (px) past which releasing the handle/header
|
||||||
|
* commits to closing the sheet, rather than snapping back open. */
|
||||||
|
const SWIPE_DISMISS_THRESHOLD_PX = 80;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Mobile-only bottom sheet (Phase A). Slides up from the bottom of the
|
||||||
|
* viewport to host one of the existing side-panel components
|
||||||
|
* (BlocksPanel/PagesPanel/LayersPanel/AssetsPanel/GuidedStyles) unchanged,
|
||||||
|
* as the mobile replacement for the desktop fixed left/right panel columns.
|
||||||
|
* See `MobilePanelBar`, which owns which sheet (if any) is open.
|
||||||
|
*
|
||||||
|
* Deliberately NOT a generic replacement for `src/ui/Modal.tsx` (centered
|
||||||
|
* dialog chrome) -- this is anchored to the bottom, sized to ~65dvh, and
|
||||||
|
* has its own drag-handle affordance + internally scrollable body, all of
|
||||||
|
* which Modal doesn't need for its centered use cases.
|
||||||
|
*
|
||||||
|
* Phase B adds two more deferred behaviors on top of Phase A's static sheet:
|
||||||
|
* - **Swipe-to-dismiss**: a touchstart/move/end drag tracked on the handle
|
||||||
|
* row + header (not the scrollable body, so it never fights a panel's own
|
||||||
|
* vertical scroll) that follows the finger while dragging down and either
|
||||||
|
* commits to `onClose()` past `SWIPE_DISMISS_THRESHOLD_PX` or snaps back
|
||||||
|
* with a short transition otherwise.
|
||||||
|
* - **On-screen-keyboard clearance**: `useVisualViewportInsets` reports how
|
||||||
|
* much the visual viewport has shrunk from the bottom (i.e. the
|
||||||
|
* keyboard's height); that's surfaced as a `--keyboard-inset` CSS custom
|
||||||
|
* property (see editor.css) which both lifts the whole backdrop/sheet
|
||||||
|
* clear of the keyboard AND caps the sheet's own max-height so it never
|
||||||
|
* extends into the space the keyboard occupies. A `focusin` listener also
|
||||||
|
* scrolls the newly-focused input into view once the keyboard has had a
|
||||||
|
* moment to animate in, as a second line of defense for a field that's
|
||||||
|
* still off-screen after the resize alone (e.g. deep in a long panel).
|
||||||
|
*/
|
||||||
|
export const BottomSheet: React.FC<BottomSheetProps> = ({ open, onClose, title, children }) => {
|
||||||
|
useEffect(() => {
|
||||||
|
if (!open) return;
|
||||||
|
const handleKeyDown = (e: KeyboardEvent) => {
|
||||||
|
if (e.key === 'Escape') onClose();
|
||||||
|
};
|
||||||
|
window.addEventListener('keydown', handleKeyDown);
|
||||||
|
|
||||||
|
const prevOverflow = document.body.style.overflow;
|
||||||
|
document.body.style.overflow = 'hidden';
|
||||||
|
return () => {
|
||||||
|
window.removeEventListener('keydown', handleKeyDown);
|
||||||
|
document.body.style.overflow = prevOverflow;
|
||||||
|
};
|
||||||
|
}, [open, onClose]);
|
||||||
|
|
||||||
|
const { keyboardInset } = useVisualViewportInsets();
|
||||||
|
|
||||||
|
const bodyRef = useRef<HTMLDivElement>(null);
|
||||||
|
useEffect(() => {
|
||||||
|
if (!open) return;
|
||||||
|
const bodyEl = bodyRef.current;
|
||||||
|
if (!bodyEl) return;
|
||||||
|
const handleFocusIn = (e: FocusEvent) => {
|
||||||
|
const target = e.target as HTMLElement | null;
|
||||||
|
if (!target) return;
|
||||||
|
const tag = target.tagName;
|
||||||
|
if (tag === 'INPUT' || tag === 'TEXTAREA' || tag === 'SELECT' || target.isContentEditable) {
|
||||||
|
// Give the on-screen keyboard a moment to finish animating in
|
||||||
|
// before scrolling -- doing it immediately measures the pre-keyboard
|
||||||
|
// layout and can undershoot.
|
||||||
|
window.setTimeout(() => {
|
||||||
|
target.scrollIntoView({ block: 'center', behavior: 'smooth' });
|
||||||
|
}, 300);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
bodyEl.addEventListener('focusin', handleFocusIn);
|
||||||
|
return () => bodyEl.removeEventListener('focusin', handleFocusIn);
|
||||||
|
}, [open]);
|
||||||
|
|
||||||
|
// Swipe-to-dismiss: tracked only on the handle row + header (never the
|
||||||
|
// scrollable `.mobile-sheet-body`, which needs its own vertical touch
|
||||||
|
// scrolling to keep working unimpeded).
|
||||||
|
//
|
||||||
|
// The authoritative drag distance lives in a REF (`dragOffsetRef`),
|
||||||
|
// updated synchronously and imperatively on every touchmove -- NOT solely
|
||||||
|
// in the `dragOffset` state used for rendering the drag transform. Two
|
||||||
|
// touchmoves can fire back-to-back inside the same synchronous event
|
||||||
|
// dispatch (e.g. a fast real swipe, or synthetic touch events fired
|
||||||
|
// without a yield between them), and React batches their `setDragOffset`
|
||||||
|
// calls into a single pending update that hasn't committed yet by the
|
||||||
|
// time `touchend` runs in that same tick -- reading the `dragOffset`
|
||||||
|
// STATE value directly in `handleTouchEnd` would then see a stale
|
||||||
|
// (pre-drag) value and wrongly decide the swipe didn't clear the
|
||||||
|
// threshold. The ref sidesteps that entirely (plain synchronous mutation,
|
||||||
|
// no batching). Relatedly, `onClose()` mutates an ANCESTOR component's
|
||||||
|
// state (MobileChromeContext's `closeSheet`) -- it must be called as a
|
||||||
|
// plain statement in the event handler, never from inside a `setState`
|
||||||
|
// functional updater (that runs during this component's own render phase
|
||||||
|
// and trips React's "Cannot update a component while rendering a
|
||||||
|
// different component" warning).
|
||||||
|
const dragStartYRef = useRef<number | null>(null);
|
||||||
|
const dragOffsetRef = useRef(0);
|
||||||
|
const [dragOffset, setDragOffset] = useState(0);
|
||||||
|
|
||||||
|
const handleTouchStart = useCallback((e: React.TouchEvent) => {
|
||||||
|
if (e.touches.length !== 1) return;
|
||||||
|
dragStartYRef.current = e.touches[0].clientY;
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
const handleTouchMove = useCallback((e: React.TouchEvent) => {
|
||||||
|
if (dragStartYRef.current === null) return;
|
||||||
|
const delta = e.touches[0].clientY - dragStartYRef.current;
|
||||||
|
// Only follow downward drags -- dragging up shouldn't do anything (the
|
||||||
|
// sheet is already fully open; there's no "expand further" state).
|
||||||
|
const next = Math.max(0, delta);
|
||||||
|
dragOffsetRef.current = next;
|
||||||
|
setDragOffset(next);
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
const handleTouchEnd = useCallback(() => {
|
||||||
|
dragStartYRef.current = null;
|
||||||
|
const finalOffset = dragOffsetRef.current;
|
||||||
|
dragOffsetRef.current = 0;
|
||||||
|
setDragOffset(0);
|
||||||
|
if (finalOffset > SWIPE_DISMISS_THRESHOLD_PX) onClose();
|
||||||
|
}, [onClose]);
|
||||||
|
|
||||||
|
if (!open) return null;
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div
|
||||||
|
className="mobile-sheet-backdrop"
|
||||||
|
onClick={(e) => {
|
||||||
|
if (e.target === e.currentTarget) onClose();
|
||||||
|
}}
|
||||||
|
style={{ ['--keyboard-inset' as any]: `${keyboardInset}px` }}
|
||||||
|
>
|
||||||
|
{/* Deliberately NOT aria-modal: the tab bar stays reachable/operable
|
||||||
|
while a sheet is open (tapping another tab swaps sheets directly),
|
||||||
|
so the rest of the screen must not be marked inert to assistive
|
||||||
|
tech the way a true modal dialog would be. */}
|
||||||
|
<div
|
||||||
|
className="mobile-sheet"
|
||||||
|
role="dialog"
|
||||||
|
aria-label={title}
|
||||||
|
style={{
|
||||||
|
transform: dragOffset ? `translateY(${dragOffset}px)` : undefined,
|
||||||
|
transition: dragOffset ? 'none' : 'transform 0.2s ease',
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<div
|
||||||
|
className="mobile-sheet-handle-row"
|
||||||
|
onTouchStart={handleTouchStart}
|
||||||
|
onTouchMove={handleTouchMove}
|
||||||
|
onTouchEnd={handleTouchEnd}
|
||||||
|
onTouchCancel={handleTouchEnd}
|
||||||
|
>
|
||||||
|
<span className="mobile-sheet-handle" aria-hidden="true" />
|
||||||
|
</div>
|
||||||
|
<div
|
||||||
|
className="mobile-sheet-header"
|
||||||
|
onTouchStart={handleTouchStart}
|
||||||
|
onTouchMove={handleTouchMove}
|
||||||
|
onTouchEnd={handleTouchEnd}
|
||||||
|
onTouchCancel={handleTouchEnd}
|
||||||
|
>
|
||||||
|
<span className="mobile-sheet-title">{title}</span>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className="mobile-sheet-close"
|
||||||
|
onClick={onClose}
|
||||||
|
aria-label={`Close ${title}`}
|
||||||
|
>
|
||||||
|
<i className="fa fa-times" aria-hidden="true" />
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
<div className="mobile-sheet-body" ref={bodyRef}>{children}</div>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
};
|
||||||
@@ -0,0 +1,145 @@
|
|||||||
|
import { describe, test, expect, vi } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
import { MobilePanelBar } from './MobilePanelBar';
|
||||||
|
import { MobileChromeProvider } from '../../state/MobileChromeContext';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Mobile-A2 (review item 5): the real BlocksPanel/PagesPanel/LayersPanel/
|
||||||
|
* AssetsPanel/GuidedStyles all pull in Craft.js's `useEditor` and other
|
||||||
|
* heavy dependencies not relevant here, so they're stubbed out -- this
|
||||||
|
* suite is only exercising MobilePanelBar's OWN wiring: tapping a tab opens
|
||||||
|
* that tab's sheet with only its panel rendered, tapping the active tab
|
||||||
|
* again closes it, and (mirroring MobileChromeContext.test.tsx) only one
|
||||||
|
* sheet's content is ever mounted at once.
|
||||||
|
*/
|
||||||
|
vi.mock('../left/BlocksPanel', () => ({ BlocksPanel: () => <div data-testid="panel-blocks" /> }));
|
||||||
|
vi.mock('../left/PagesPanel', () => ({ PagesPanel: () => <div data-testid="panel-pages" /> }));
|
||||||
|
vi.mock('../left/LayersPanel', () => ({ LayersPanel: () => <div data-testid="panel-layers" /> }));
|
||||||
|
vi.mock('../left/AssetsPanel', () => ({ AssetsPanel: () => <div data-testid="panel-assets" /> }));
|
||||||
|
vi.mock('../right/GuidedStyles', () => ({ GuidedStyles: () => <div data-testid="panel-styles" /> }));
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
|
||||||
|
function render(ui: React.ReactElement) {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(ui);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function unmount() {
|
||||||
|
act(() => {
|
||||||
|
root.unmount();
|
||||||
|
});
|
||||||
|
container.remove();
|
||||||
|
}
|
||||||
|
|
||||||
|
function tabButton(label: string): HTMLButtonElement {
|
||||||
|
const buttons = Array.from(container.querySelectorAll('.mobile-tab-btn')) as HTMLButtonElement[];
|
||||||
|
const btn = buttons.find((b) => b.textContent?.includes(label));
|
||||||
|
if (!btn) throw new Error(`No tab button found for "${label}"`);
|
||||||
|
return btn;
|
||||||
|
}
|
||||||
|
|
||||||
|
function openPanelIds(): string[] {
|
||||||
|
return Array.from(container.querySelectorAll('[data-testid^="panel-"]')).map(
|
||||||
|
(el) => (el as HTMLElement).dataset.testid!,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('MobilePanelBar', () => {
|
||||||
|
test('no sheet is open initially', () => {
|
||||||
|
render(
|
||||||
|
<MobileChromeProvider>
|
||||||
|
<MobilePanelBar />
|
||||||
|
</MobileChromeProvider>,
|
||||||
|
);
|
||||||
|
expect(container.querySelector('.mobile-sheet-backdrop')).toBeNull();
|
||||||
|
expect(openPanelIds()).toEqual([]);
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('tapping a tab opens exactly that tab\'s panel', () => {
|
||||||
|
render(
|
||||||
|
<MobileChromeProvider>
|
||||||
|
<MobilePanelBar />
|
||||||
|
</MobileChromeProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
tabButton('Blocks').click();
|
||||||
|
});
|
||||||
|
expect(openPanelIds()).toEqual(['panel-blocks']);
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('switching tabs replaces the open sheet -- only one panel mounted at a time', () => {
|
||||||
|
render(
|
||||||
|
<MobileChromeProvider>
|
||||||
|
<MobilePanelBar />
|
||||||
|
</MobileChromeProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
tabButton('Blocks').click();
|
||||||
|
});
|
||||||
|
expect(openPanelIds()).toEqual(['panel-blocks']);
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
tabButton('Styles').click();
|
||||||
|
});
|
||||||
|
expect(openPanelIds()).toEqual(['panel-styles']);
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
tabButton('Assets').click();
|
||||||
|
});
|
||||||
|
expect(openPanelIds()).toEqual(['panel-assets']);
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('tapping the active tab again closes the sheet', () => {
|
||||||
|
render(
|
||||||
|
<MobileChromeProvider>
|
||||||
|
<MobilePanelBar />
|
||||||
|
</MobileChromeProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
tabButton('Pages').click();
|
||||||
|
});
|
||||||
|
expect(openPanelIds()).toEqual(['panel-pages']);
|
||||||
|
expect(container.querySelector('.mobile-sheet-backdrop')).not.toBeNull();
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
tabButton('Pages').click();
|
||||||
|
});
|
||||||
|
expect(openPanelIds()).toEqual([]);
|
||||||
|
expect(container.querySelector('.mobile-sheet-backdrop')).toBeNull();
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('active tab button carries aria-pressed=true only for the open sheet', () => {
|
||||||
|
render(
|
||||||
|
<MobileChromeProvider>
|
||||||
|
<MobilePanelBar />
|
||||||
|
</MobileChromeProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
tabButton('Layers').click();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(tabButton('Layers').getAttribute('aria-pressed')).toBe('true');
|
||||||
|
expect(tabButton('Blocks').getAttribute('aria-pressed')).toBe('false');
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,74 @@
|
|||||||
|
import React from 'react';
|
||||||
|
import { BottomSheet } from './BottomSheet';
|
||||||
|
import { BlocksPanel } from '../left/BlocksPanel';
|
||||||
|
import { PagesPanel } from '../left/PagesPanel';
|
||||||
|
import { LayersPanel } from '../left/LayersPanel';
|
||||||
|
import { AssetsPanel } from '../left/AssetsPanel';
|
||||||
|
import { GuidedStyles } from '../right/GuidedStyles';
|
||||||
|
import { useMobileChrome, MobileSheetTab } from '../../state/MobileChromeContext';
|
||||||
|
|
||||||
|
const TABS: { id: MobileSheetTab; label: string; icon: string }[] = [
|
||||||
|
{ id: 'blocks', label: 'Blocks', icon: 'fa-cube' },
|
||||||
|
{ id: 'pages', label: 'Pages', icon: 'fa-file-o' },
|
||||||
|
{ id: 'layers', label: 'Layers', icon: 'fa-sitemap' },
|
||||||
|
{ id: 'assets', label: 'Assets', icon: 'fa-image' },
|
||||||
|
{ id: 'styles', label: 'Styles', icon: 'fa-paint-brush' },
|
||||||
|
];
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Mobile replacement for the desktop LeftPanel/RightPanel column layout
|
||||||
|
* (Phase A). A fixed bottom tab bar (Blocks/Pages/Layers/Assets/Styles)
|
||||||
|
* toggles a single `BottomSheet` at a time, hosting the SAME panel
|
||||||
|
* component the desktop side panels use -- unchanged, so behavior/state
|
||||||
|
* stays identical, only the chrome around it differs. Tapping the active
|
||||||
|
* tab again, tapping the backdrop, the sheet's close button, or Escape all
|
||||||
|
* close the open sheet.
|
||||||
|
*
|
||||||
|
* "Styles" hosts `GuidedStyles`, which already falls back to the
|
||||||
|
* site-design panel when nothing is selected and switches to the
|
||||||
|
* per-type style panel once something is -- this is the natural place to
|
||||||
|
* edit a tapped element's styling (Phase B deepens the tap-to-select flow;
|
||||||
|
* this component only wires up the sheet, per the Phase A brief).
|
||||||
|
*
|
||||||
|
* Sheet-open state itself lives in `MobileChromeContext` (Mobile-A2), not
|
||||||
|
* a private `useState`, so Phase B can open/close a sheet from elsewhere
|
||||||
|
* (e.g. a canvas selection toolbar). The toggle-to-close-on-repeat-tap
|
||||||
|
* behavior is local to this click handler -- `openSheet` always opens.
|
||||||
|
*/
|
||||||
|
export const MobilePanelBar: React.FC = () => {
|
||||||
|
const { activeSheet, openSheet, closeSheet } = useMobileChrome();
|
||||||
|
|
||||||
|
const handleTabClick = (tab: MobileSheetTab) => {
|
||||||
|
if (activeSheet === tab) closeSheet();
|
||||||
|
else openSheet(tab);
|
||||||
|
};
|
||||||
|
|
||||||
|
const activeLabel = TABS.find((t) => t.id === activeSheet)?.label ?? '';
|
||||||
|
|
||||||
|
return (
|
||||||
|
<>
|
||||||
|
<BottomSheet open={activeSheet !== null} onClose={closeSheet} title={activeLabel}>
|
||||||
|
{activeSheet === 'blocks' && <BlocksPanel />}
|
||||||
|
{activeSheet === 'pages' && <PagesPanel />}
|
||||||
|
{activeSheet === 'layers' && <LayersPanel />}
|
||||||
|
{activeSheet === 'assets' && <AssetsPanel />}
|
||||||
|
{activeSheet === 'styles' && <GuidedStyles />}
|
||||||
|
</BottomSheet>
|
||||||
|
|
||||||
|
<nav className="mobile-tab-bar" aria-label="Editor panels">
|
||||||
|
{TABS.map((tab) => (
|
||||||
|
<button
|
||||||
|
key={tab.id}
|
||||||
|
type="button"
|
||||||
|
className={`mobile-tab-btn${activeSheet === tab.id ? ' active' : ''}`}
|
||||||
|
onClick={() => handleTabClick(tab.id)}
|
||||||
|
aria-pressed={activeSheet === tab.id}
|
||||||
|
>
|
||||||
|
<i className={`fa ${tab.icon}`} aria-hidden="true" />
|
||||||
|
<span>{tab.label}</span>
|
||||||
|
</button>
|
||||||
|
))}
|
||||||
|
</nav>
|
||||||
|
</>
|
||||||
|
);
|
||||||
|
};
|
||||||
@@ -0,0 +1,213 @@
|
|||||||
|
import React, { useCallback, useEffect, useRef, useState } from 'react';
|
||||||
|
import { useEditor } from '@craftjs/core';
|
||||||
|
import { useNodeActions } from '../../hooks/useNodeActions';
|
||||||
|
import { useMobileChrome } from '../../state/MobileChromeContext';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Phase B mobile selection toolbar -- the on-canvas action bar that makes a
|
||||||
|
* tap-selected node actually EDITABLE by touch (reorder/duplicate/delete/
|
||||||
|
* select-parent/edit-styles), mirroring the desktop right-click ContextMenu.
|
||||||
|
* Both share the exact same behavior via `useNodeActions` (item 1).
|
||||||
|
*
|
||||||
|
* Mounted ONCE (in `EditorShell`'s mobile branch), reading the current
|
||||||
|
* selection from `useEditor` directly -- NOT per-node -- and positioned
|
||||||
|
* bottom-fixed just above the tab bar (simplest, robust; a node-anchored
|
||||||
|
* floating toolbar would have to constantly reposition as the canvas
|
||||||
|
* scrolls, and risks being clipped at the viewport edge for a node near the
|
||||||
|
* top or bottom of a tall page). This is a deliberate design call: see the
|
||||||
|
* report for the alternative (floating over the node) that was passed over.
|
||||||
|
*
|
||||||
|
* Hidden whenever a bottom sheet is open (`activeSheet !== null`) -- the
|
||||||
|
* sheet supersedes it, and the two must never visually stack.
|
||||||
|
*
|
||||||
|
* Delete is a two-tap in-app confirm (tap once -> the button becomes
|
||||||
|
* "Confirm?" for a few seconds; tap again within that window commits the
|
||||||
|
* delete; selecting something else cancels it) rather than a native
|
||||||
|
* `confirm()`, matching the project's no-native-dialogs rule.
|
||||||
|
*/
|
||||||
|
const DELETE_CONFIRM_TIMEOUT_MS = 3000;
|
||||||
|
|
||||||
|
export const MobileSelectionToolbar: React.FC = () => {
|
||||||
|
const { activeSheet, openSheet } = useMobileChrome();
|
||||||
|
const { selectedId } = useEditor((state) => {
|
||||||
|
const selected = state.events.selected;
|
||||||
|
const id = selected && selected.size > 0 ? (Array.from(selected)[0] as string) : null;
|
||||||
|
return { selectedId: id && id !== 'ROOT' ? id : null };
|
||||||
|
});
|
||||||
|
// Collector-free -- an always-live reference (same pattern as
|
||||||
|
// GuidedStyles.tsx/BlocksPanel.tsx), used only for imperative DOM lookups
|
||||||
|
// below (scroll-into-view), never for anything that needs to react to
|
||||||
|
// store changes on its own.
|
||||||
|
const { query } = useEditor();
|
||||||
|
|
||||||
|
const nodeActions = useNodeActions(selectedId);
|
||||||
|
const [confirmingDelete, setConfirmingDelete] = useState(false);
|
||||||
|
const confirmTimeoutRef = useRef<ReturnType<typeof setTimeout> | null>(null);
|
||||||
|
|
||||||
|
// `useNodeActions` computes canMoveUp/canMoveDown/canDelete synchronously
|
||||||
|
// from a live (never-cached) Craft.js query -- see that hook's doc comment
|
||||||
|
// for why it deliberately does NOT hold its own store subscription to force
|
||||||
|
// a refresh. Moving/duplicating/deleting via THIS toolbar changes the
|
||||||
|
// selected node's position/siblings WITHOUT changing `selectedId` itself
|
||||||
|
// (the node stays selected), so nothing else would otherwise trigger a
|
||||||
|
// re-render of this component to pick up the new boundary flags after,
|
||||||
|
// say, tapping "Move Up" until the node reaches the top. Bumping a plain
|
||||||
|
// local tick from these buttons' own click handlers -- an ordinary,
|
||||||
|
// locally-owned re-render -- covers exactly that, without the broader
|
||||||
|
// store-wide subscription that was found to trip React's "setState while
|
||||||
|
// rendering a different component" warning whenever some unrelated
|
||||||
|
// container mounts (see useNodeActions.ts).
|
||||||
|
const [, forceRefresh] = useState(0);
|
||||||
|
const bumpTick = useCallback(() => forceRefresh((n) => n + 1), []);
|
||||||
|
|
||||||
|
const clearConfirmTimeout = useCallback(() => {
|
||||||
|
if (confirmTimeoutRef.current) {
|
||||||
|
clearTimeout(confirmTimeoutRef.current);
|
||||||
|
confirmTimeoutRef.current = null;
|
||||||
|
}
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
// Reset the two-tap delete confirmation whenever the selection changes
|
||||||
|
// (including being cleared) so a stale "Confirm?" state never lingers onto
|
||||||
|
// a different node.
|
||||||
|
const prevSelectedRef = useRef(selectedId);
|
||||||
|
useEffect(() => {
|
||||||
|
if (prevSelectedRef.current !== selectedId) {
|
||||||
|
prevSelectedRef.current = selectedId;
|
||||||
|
clearConfirmTimeout();
|
||||||
|
setConfirmingDelete(false);
|
||||||
|
}
|
||||||
|
}, [selectedId, clearConfirmTimeout]);
|
||||||
|
|
||||||
|
useEffect(() => clearConfirmTimeout, [clearConfirmTimeout]);
|
||||||
|
|
||||||
|
// Fast-follow item 3: the Styles bottom sheet covers the bottom ~65dvh of
|
||||||
|
// the canvas, so a selected node sitting anywhere in that band goes
|
||||||
|
// invisible the instant the sheet opens -- live style edits then have no
|
||||||
|
// visible effect until the user closes the sheet to check. Whenever the
|
||||||
|
// sheet becomes 'styles' (however it got opened -- currently only this
|
||||||
|
// toolbar's own "Style" button, but this is keyed on the sheet/selection
|
||||||
|
// state rather than the button tap so it stays correct if another entry
|
||||||
|
// point is added later) scroll the selected node to the top of the
|
||||||
|
// canvas's scroll area, into the sliver of screen the sheet leaves clear.
|
||||||
|
useEffect(() => {
|
||||||
|
if (activeSheet !== 'styles' || !selectedId) return;
|
||||||
|
try {
|
||||||
|
query.node(selectedId).get()?.dom?.scrollIntoView({ behavior: 'smooth', block: 'start' });
|
||||||
|
} catch {
|
||||||
|
// Best-effort -- not fatal if the node/DOM isn't found.
|
||||||
|
}
|
||||||
|
}, [activeSheet, selectedId, query]);
|
||||||
|
|
||||||
|
const handleDeleteTap = useCallback(() => {
|
||||||
|
if (confirmingDelete) {
|
||||||
|
clearConfirmTimeout();
|
||||||
|
setConfirmingDelete(false);
|
||||||
|
nodeActions.deleteNode();
|
||||||
|
bumpTick();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
setConfirmingDelete(true);
|
||||||
|
clearConfirmTimeout();
|
||||||
|
confirmTimeoutRef.current = setTimeout(() => setConfirmingDelete(false), DELETE_CONFIRM_TIMEOUT_MS);
|
||||||
|
}, [confirmingDelete, clearConfirmTimeout, nodeActions, bumpTick]);
|
||||||
|
|
||||||
|
const handleEditStyles = useCallback(() => {
|
||||||
|
openSheet('styles');
|
||||||
|
}, [openSheet]);
|
||||||
|
|
||||||
|
const handleMoveUp = useCallback(() => {
|
||||||
|
nodeActions.moveUp();
|
||||||
|
bumpTick();
|
||||||
|
}, [nodeActions, bumpTick]);
|
||||||
|
|
||||||
|
const handleMoveDown = useCallback(() => {
|
||||||
|
nodeActions.moveDown();
|
||||||
|
bumpTick();
|
||||||
|
}, [nodeActions, bumpTick]);
|
||||||
|
|
||||||
|
const handleDuplicate = useCallback(() => {
|
||||||
|
const newId = nodeActions.duplicate();
|
||||||
|
bumpTick();
|
||||||
|
if (!newId) return;
|
||||||
|
// Mirror BlocksPanel's tap-to-add pattern: the new node's real DOM
|
||||||
|
// element isn't attached yet the instant `duplicate()` returns (Craft.js
|
||||||
|
// mounts it asynchronously after this handler's synchronous state
|
||||||
|
// update), so defer two animation frames before reading `.dom` off the
|
||||||
|
// query, same as `handleTapToAdd` does.
|
||||||
|
requestAnimationFrame(() => {
|
||||||
|
requestAnimationFrame(() => {
|
||||||
|
try {
|
||||||
|
query.node(newId).get()?.dom?.scrollIntoView({ behavior: 'smooth', block: 'center' });
|
||||||
|
} catch {
|
||||||
|
// Best-effort scroll -- not fatal if the node/DOM isn't found.
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
}, [nodeActions, bumpTick, query]);
|
||||||
|
|
||||||
|
if (!selectedId || activeSheet !== null) return null;
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div className="mobile-selection-toolbar" role="toolbar" aria-label="Selected element actions">
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className="mobile-selection-toolbar-btn"
|
||||||
|
onClick={handleMoveUp}
|
||||||
|
disabled={!nodeActions.canMoveUp}
|
||||||
|
aria-label="Move up"
|
||||||
|
>
|
||||||
|
<i className="fa fa-arrow-up" aria-hidden="true" />
|
||||||
|
<span>Up</span>
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className="mobile-selection-toolbar-btn"
|
||||||
|
onClick={handleMoveDown}
|
||||||
|
disabled={!nodeActions.canMoveDown}
|
||||||
|
aria-label="Move down"
|
||||||
|
>
|
||||||
|
<i className="fa fa-arrow-down" aria-hidden="true" />
|
||||||
|
<span>Down</span>
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className="mobile-selection-toolbar-btn"
|
||||||
|
onClick={handleDuplicate}
|
||||||
|
aria-label="Duplicate"
|
||||||
|
>
|
||||||
|
<i className="fa fa-clone" aria-hidden="true" />
|
||||||
|
<span>Copy</span>
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className="mobile-selection-toolbar-btn"
|
||||||
|
onClick={nodeActions.selectParent}
|
||||||
|
disabled={!nodeActions.canSelectParent}
|
||||||
|
aria-label="Select parent"
|
||||||
|
>
|
||||||
|
<i className="fa fa-level-up" aria-hidden="true" />
|
||||||
|
<span>Parent</span>
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className="mobile-selection-toolbar-btn"
|
||||||
|
onClick={handleEditStyles}
|
||||||
|
aria-label="Edit styles"
|
||||||
|
>
|
||||||
|
<i className="fa fa-paint-brush" aria-hidden="true" />
|
||||||
|
<span>Style</span>
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={`mobile-selection-toolbar-btn danger${confirmingDelete ? ' confirming' : ''}`}
|
||||||
|
onClick={handleDeleteTap}
|
||||||
|
disabled={!nodeActions.canDelete}
|
||||||
|
aria-label={confirmingDelete ? 'Tap again to confirm delete' : 'Delete'}
|
||||||
|
>
|
||||||
|
<i className="fa fa-trash" aria-hidden="true" />
|
||||||
|
<span>{confirmingDelete ? 'Confirm?' : 'Delete'}</span>
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
};
|
||||||
@@ -11,6 +11,7 @@ import {
|
|||||||
useNodeProp,
|
useNodeProp,
|
||||||
} from './shared';
|
} from './shared';
|
||||||
import { AssetPicker } from '../../../ui/AssetPicker';
|
import { AssetPicker } from '../../../ui/AssetPicker';
|
||||||
|
import { PLACEHOLDER_SRC } from '../../../components/media/ImageBlock';
|
||||||
|
|
||||||
/* ---------- IMAGE (with upload/browse/drop) ---------- */
|
/* ---------- IMAGE (with upload/browse/drop) ---------- */
|
||||||
export const ImageStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodeProps }) => {
|
export const ImageStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodeProps }) => {
|
||||||
@@ -33,7 +34,7 @@ export const ImageStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodePro
|
|||||||
<SectionLabel>Image Source</SectionLabel>
|
<SectionLabel>Image Source</SectionLabel>
|
||||||
<AssetPicker
|
<AssetPicker
|
||||||
value={nodeProps.src || ''}
|
value={nodeProps.src || ''}
|
||||||
onChange={(url) => actions.setProp(selectedId, (props: any) => { props.src = url; })}
|
onChange={(url) => actions.setProp(selectedId, (props: any) => { props.src = url || PLACEHOLDER_SRC; })}
|
||||||
variant="full"
|
variant="full"
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -0,0 +1,38 @@
|
|||||||
|
import { describe, it, expect } from 'vitest';
|
||||||
|
import { defaultPresetGridColumns } from './shared';
|
||||||
|
import { RADIUS_PRESETS, SPACING_PRESETS, IMAGE_RADIUS_PRESETS, FONT_WEIGHTS, TEXT_SIZES, FONT_FAMILIES } from '../../../constants/presets';
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Regression: 5-item preset sets (RADIUS_PRESETS, SPACING_PRESETS,
|
||||||
|
* IMAGE_RADIUS_PRESETS, FONT_WEIGHTS, and NavStylePanel's ad-hoc
|
||||||
|
* GAP_PRESETS) left a lone orphan button on its own row under the old
|
||||||
|
* fixed 4-column .preset-grid. PresetButtonGrid now derives a column
|
||||||
|
* count from the preset length instead.
|
||||||
|
*/
|
||||||
|
describe('defaultPresetGridColumns', () => {
|
||||||
|
it('gives 5-item sets their own single row (no orphan)', () => {
|
||||||
|
expect(defaultPresetGridColumns(RADIUS_PRESETS.length)).toBe(5);
|
||||||
|
expect(defaultPresetGridColumns(SPACING_PRESETS.length)).toBe(5);
|
||||||
|
expect(defaultPresetGridColumns(IMAGE_RADIUS_PRESETS.length)).toBe(5);
|
||||||
|
expect(defaultPresetGridColumns(FONT_WEIGHTS.length)).toBe(5);
|
||||||
|
expect(defaultPresetGridColumns(5)).toBe(5); // NavStylePanel's GAP_PRESETS
|
||||||
|
});
|
||||||
|
|
||||||
|
it('splits 6-item sets into two even rows of 3 (was 4+2 uneven)', () => {
|
||||||
|
expect(defaultPresetGridColumns(TEXT_SIZES.length)).toBe(3);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('keeps the classic 4-column grid for sets that already divide evenly', () => {
|
||||||
|
expect(defaultPresetGridColumns(FONT_FAMILIES.length)).toBe(4); // 8 items
|
||||||
|
expect(defaultPresetGridColumns(4)).toBe(4);
|
||||||
|
expect(defaultPresetGridColumns(3)).toBe(4);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('never leaves a single orphan on the final row for any count 1-12', () => {
|
||||||
|
for (let n = 1; n <= 12; n++) {
|
||||||
|
const cols = defaultPresetGridColumns(n);
|
||||||
|
const isLoneOrphan = n > cols && n % cols === 1;
|
||||||
|
expect(isLoneOrphan).toBe(false);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -84,9 +84,30 @@ interface PresetButtonGridProps {
|
|||||||
presets: { label: string; value: string }[];
|
presets: { label: string; value: string }[];
|
||||||
activeValue: string | undefined;
|
activeValue: string | undefined;
|
||||||
onSelect: (value: string) => void;
|
onSelect: (value: string) => void;
|
||||||
|
/** Explicit column count. When omitted, a column count is derived from
|
||||||
|
* `presets.length` (see `defaultPresetGridColumns`) so odd-sized preset
|
||||||
|
* sets (5, 6, ...) don't leave a lone orphan button dangling on its own
|
||||||
|
* row under the fixed 4-column grid. */
|
||||||
|
columns?: number;
|
||||||
}
|
}
|
||||||
export const PresetButtonGrid: React.FC<PresetButtonGridProps> = ({ presets, activeValue, onSelect }) => (
|
|
||||||
<div className="preset-grid">
|
/** Picks a column count that avoids a single orphan on the last row.
|
||||||
|
* 4-or-fewer presets keep the classic single row of 4. 5 gets its own
|
||||||
|
* row (5 cols). 6 splits into two even rows of 3. Anything else falls
|
||||||
|
* back to a 4- or 3-column grid depending on which divides evenly. */
|
||||||
|
export function defaultPresetGridColumns(count: number): number {
|
||||||
|
if (count <= 4) return 4;
|
||||||
|
if (count === 5) return 5;
|
||||||
|
if (count === 6) return 3;
|
||||||
|
if (count % 4 === 0) return 4;
|
||||||
|
if (count % 3 === 0) return 3;
|
||||||
|
return 4;
|
||||||
|
}
|
||||||
|
|
||||||
|
export const PresetButtonGrid: React.FC<PresetButtonGridProps> = ({ presets, activeValue, onSelect, columns }) => {
|
||||||
|
const cols = columns ?? defaultPresetGridColumns(presets.length);
|
||||||
|
return (
|
||||||
|
<div className="preset-grid" style={{ gridTemplateColumns: `repeat(${cols}, 1fr)` }}>
|
||||||
{presets.map((p) => (
|
{presets.map((p) => (
|
||||||
<button
|
<button
|
||||||
key={p.value}
|
key={p.value}
|
||||||
@@ -97,7 +118,8 @@ export const PresetButtonGrid: React.FC<PresetButtonGridProps> = ({ presets, act
|
|||||||
</button>
|
</button>
|
||||||
))}
|
))}
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
|
};
|
||||||
|
|
||||||
interface GradientSwatchGridProps {
|
interface GradientSwatchGridProps {
|
||||||
activeValue: string | undefined;
|
activeValue: string | undefined;
|
||||||
|
|||||||
@@ -10,6 +10,7 @@ export const ChatInput: React.FC<Props> = ({ disabled, placeholder, onSend }) =>
|
|||||||
<div style={{ display: 'flex', gap: 8, padding: '8px 0' }}>
|
<div style={{ display: 'flex', gap: 8, padding: '8px 0' }}>
|
||||||
<textarea value={v} onChange={(e) => setV(e.target.value)} onKeyDown={onKey} rows={2} disabled={disabled}
|
<textarea value={v} onChange={(e) => setV(e.target.value)} onKeyDown={onKey} rows={2} disabled={disabled}
|
||||||
placeholder={placeholder || 'Describe what you want...'}
|
placeholder={placeholder || 'Describe what you want...'}
|
||||||
|
className="sitesmith-textarea"
|
||||||
style={{
|
style={{
|
||||||
flex: 1, background: disabled ? '#1f1f24' : '#0f0f17', color: '#e5e7eb',
|
flex: 1, background: disabled ? '#1f1f24' : '#0f0f17', color: '#e5e7eb',
|
||||||
border: '1px solid #3f3f46', borderRadius: 6, padding: 10, fontSize: 14, resize: 'none',
|
border: '1px solid #3f3f46', borderRadius: 6, padding: 10, fontSize: 14, resize: 'none',
|
||||||
|
|||||||
@@ -21,8 +21,8 @@ export const SitesmithButton: React.FC<Props> = ({ onClick }) => {
|
|||||||
color: '#fff', border: 'none', padding: '6px 12px', borderRadius: 6, cursor: 'pointer', fontWeight: 500,
|
color: '#fff', border: 'none', padding: '6px 12px', borderRadius: 6, cursor: 'pointer', fontWeight: 500,
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
✨ Sitesmith
|
<i className="fa fa-magic" aria-hidden style={{ marginRight: 6 }} /> Sitesmith
|
||||||
{locked && <span aria-hidden style={{ marginLeft: 6, fontSize: 12 }}>🔒</span>}
|
{locked && <i className="fa fa-lock" aria-hidden style={{ marginLeft: 6, fontSize: 12 }} />}
|
||||||
{capped && !locked && <span aria-hidden style={{ marginLeft: 6, fontSize: 11, opacity: 0.85 }}>(cap)</span>}
|
{capped && !locked && <span aria-hidden style={{ marginLeft: 6, fontSize: 11, opacity: 0.85 }}>(cap)</span>}
|
||||||
</button>
|
</button>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -98,12 +98,15 @@ export const SitesmithModal: React.FC<Props> = ({ onClose, target }) => {
|
|||||||
onClose={onClose}
|
onClose={onClose}
|
||||||
closeOnEscape={false}
|
closeOnEscape={false}
|
||||||
closeOnBackdropClick={false}
|
closeOnBackdropClick={false}
|
||||||
backdropStyle={{ backgroundColor: 'rgba(0,0,0,0.8)', zIndex: 9000 }}
|
backdropStyle={{ backgroundColor: 'rgba(0,0,0,0.8)' }}
|
||||||
backdropProps={{ role: 'dialog', 'aria-modal': true }}
|
backdropProps={{ role: 'dialog', 'aria-modal': true }}
|
||||||
>
|
>
|
||||||
<div style={panel}>
|
<div style={panel}>
|
||||||
<div style={header}>
|
<div style={header}>
|
||||||
<div style={{ fontWeight: 600, color: '#fff' }}>✨ Sitesmith</div>
|
<div style={{ fontWeight: 600, color: '#fff' }}>
|
||||||
|
<i className="fa fa-magic" aria-hidden style={{ marginRight: 6 }} />
|
||||||
|
Sitesmith
|
||||||
|
</div>
|
||||||
{summary && summary.enabled && (
|
{summary && summary.enabled && (
|
||||||
<div style={{ fontSize: 12, color: '#a1a1aa', marginLeft: 16 }}>
|
<div style={{ fontSize: 12, color: '#a1a1aa', marginLeft: 16 }}>
|
||||||
{summary.monthly_used} / {summary.monthly_cap} this month
|
{summary.monthly_used} / {summary.monthly_cap} this month
|
||||||
@@ -136,7 +139,7 @@ export const SitesmithModal: React.FC<Props> = ({ onClose, target }) => {
|
|||||||
</button>
|
</button>
|
||||||
)
|
)
|
||||||
)}
|
)}
|
||||||
<button onClick={onClose} aria-label="Close" style={closeBtn}>✕</button>
|
<button onClick={onClose} aria-label="Close" style={closeBtn}><i className="fa fa-times" aria-hidden /></button>
|
||||||
</div>
|
</div>
|
||||||
<div style={body}>
|
<div style={body}>
|
||||||
<UpgradeBanner summary={summary} />
|
<UpgradeBanner summary={summary} />
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
import React from 'react';
|
import React from 'react';
|
||||||
|
import { createPortal } from 'react-dom';
|
||||||
import { useSiteDesign } from '../../state/SiteDesignContext';
|
import { useSiteDesign } from '../../state/SiteDesignContext';
|
||||||
import { Modal } from '../../ui/Modal';
|
import { Modal } from '../../ui/Modal';
|
||||||
|
|
||||||
@@ -10,7 +11,15 @@ interface HeadCodeModalProps {
|
|||||||
export const HeadCodeModal: React.FC<HeadCodeModalProps> = ({ open, onClose }) => {
|
export const HeadCodeModal: React.FC<HeadCodeModalProps> = ({ open, onClose }) => {
|
||||||
const { design, updateDesign } = useSiteDesign();
|
const { design, updateDesign } = useSiteDesign();
|
||||||
|
|
||||||
return (
|
// Mobile-A2/Phase B: portaled to `document.body` -- same fix TemplateModal
|
||||||
|
// already got (see its comment). TopBar.tsx mounts this modal as a child
|
||||||
|
// of `.topbar`, which (as a flex item with its own z-index) forms its own
|
||||||
|
// stacking context; that trapped the modal's fixed-position backdrop
|
||||||
|
// underneath the mobile tab bar (z-index: var(--z-tabbar)) no matter how
|
||||||
|
// high the modal's own z-index was set. Portaling escapes that stacking
|
||||||
|
// context entirely so `--z-modal` (editor.css) is evaluated at the
|
||||||
|
// document root, same as TemplateModal/SitesmithModal.
|
||||||
|
return createPortal(
|
||||||
<Modal open={open} onClose={onClose}>
|
<Modal open={open} onClose={onClose}>
|
||||||
<div style={modalStyle} onClick={(e) => e.stopPropagation()}>
|
<div style={modalStyle} onClick={(e) => e.stopPropagation()}>
|
||||||
{/* Header */}
|
{/* Header */}
|
||||||
@@ -82,7 +91,8 @@ export const HeadCodeModal: React.FC<HeadCodeModalProps> = ({ open, onClose }) =
|
|||||||
</button>
|
</button>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
</Modal>
|
</Modal>,
|
||||||
|
document.body,
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
import React, { useState, useCallback, useMemo, useEffect, useRef } from 'react';
|
import React, { useState, useCallback, useMemo, useEffect, useRef } from 'react';
|
||||||
|
import { createPortal } from 'react-dom';
|
||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import { usePages } from '../../state/PageContext';
|
import { usePages } from '../../state/PageContext';
|
||||||
import { useSiteDesign } from '../../state/SiteDesignContext';
|
import { useSiteDesign } from '../../state/SiteDesignContext';
|
||||||
@@ -8,9 +9,10 @@ import {
|
|||||||
TemplateComponent,
|
TemplateComponent,
|
||||||
TemplateCategory,
|
TemplateCategory,
|
||||||
} from '../../templates';
|
} from '../../templates';
|
||||||
import { componentResolver } from '../../components/resolver';
|
|
||||||
import { clickableProps } from '../../utils/a11y';
|
import { clickableProps } from '../../utils/a11y';
|
||||||
import { Modal } from '../../ui/Modal';
|
import { Modal } from '../../ui/Modal';
|
||||||
|
import { buildNodeTree } from '../../utils/craft-tree';
|
||||||
|
import { templateComponentToTreeNode } from '../../templates/apply-template';
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
// Types
|
// Types
|
||||||
@@ -77,28 +79,31 @@ export const TemplateModal: React.FC<TemplateModalProps> = ({ open, onClose }) =
|
|||||||
return allTemplates.filter((t) => t.category === activeTab);
|
return allTemplates.filter((t) => t.category === activeTab);
|
||||||
}, [activeTab]);
|
}, [activeTab]);
|
||||||
|
|
||||||
// Resolve a TemplateComponent type name to its React component
|
|
||||||
const resolverMap = componentResolver as Record<string, React.ComponentType<any>>;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Add all components from a template definition onto the current (empty) canvas ROOT.
|
* Add all components from a template definition onto the current (empty) canvas ROOT.
|
||||||
* Uses Craft.js parseReactElement + addNodeTree which correctly builds valid node structures.
|
* Converts each `TemplateComponent` (the plain `{type, props, children?}`
|
||||||
|
* shape templates author) to a `SerializedTreeNode` and runs it through
|
||||||
|
* `buildNodeTree` (sanitize -> flatten -> materialize), the same tree pipeline
|
||||||
|
* already used for AI-generated content. This recurses into nested
|
||||||
|
* `children` (e.g. a header/footer `Container` wrapping `Logo`/`Menu`, or a
|
||||||
|
* page `Section` wrapping a `Heading`) AND correctly routes them through a
|
||||||
|
* component's SHELL_INNER linked canvas / linked columns where needed --
|
||||||
|
* see `templates/apply-template.ts` for the two bugs this fixes (dropped
|
||||||
|
* children, and a naive `parseReactElement` tree crashing `Section`/
|
||||||
|
* `BackgroundSection`/`FormContainer`/`ColumnLayout`).
|
||||||
*/
|
*/
|
||||||
const addTemplateComponents = useCallback(
|
const addTemplateComponents = useCallback(
|
||||||
(components: TemplateComponent[]) => {
|
(components: TemplateComponent[]) => {
|
||||||
for (const comp of components) {
|
for (const comp of components) {
|
||||||
const Component = resolverMap[comp.type];
|
try {
|
||||||
if (!Component) {
|
const tree = buildNodeTree(query, templateComponentToTreeNode(comp));
|
||||||
console.warn(`Template references unknown component type: ${comp.type}`);
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
const element = React.createElement(Component, comp.props);
|
|
||||||
const tree = query.parseReactElement(element).toNodeTree();
|
|
||||||
actions.addNodeTree(tree, 'ROOT');
|
actions.addNodeTree(tree, 'ROOT');
|
||||||
|
} catch (e) {
|
||||||
|
console.warn(`Failed to build template component tree for type "${comp.type}":`, e);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
[query, actions, resolverMap],
|
[query, actions],
|
||||||
);
|
);
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -234,7 +239,14 @@ export const TemplateModal: React.FC<TemplateModalProps> = ({ open, onClose }) =
|
|||||||
}
|
}
|
||||||
}, [confirmTemplate, applyDesign, pages, addPage, switchPage, deletePage, updateDesign, addTemplateComponents, clearCanvas, applyHeaderFooter, wait, onClose]);
|
}, [confirmTemplate, applyDesign, pages, addPage, switchPage, deletePage, updateDesign, addTemplateComponents, clearCanvas, applyHeaderFooter, wait, onClose]);
|
||||||
|
|
||||||
return (
|
// Mobile-A2: portaled to `document.body` -- TopBar.tsx mounts this modal
|
||||||
|
// as a child of `.topbar`, which (as a flex item with its own z-index)
|
||||||
|
// forms its own stacking context. That trapped the modal's fixed-position
|
||||||
|
// backdrop underneath the mobile tab bar (z-index: var(--z-tabbar)) no
|
||||||
|
// matter how high the modal's own z-index was set. Portaling escapes that
|
||||||
|
// stacking context entirely so `--z-modal` (see editor.css) is evaluated
|
||||||
|
// at the document root, same as SitesmithModal.
|
||||||
|
return createPortal(
|
||||||
<Modal open={open} onClose={handleModalClose}>
|
<Modal open={open} onClose={handleModalClose}>
|
||||||
<div style={modalStyle}>
|
<div style={modalStyle}>
|
||||||
{/* Header */}
|
{/* Header */}
|
||||||
@@ -247,21 +259,39 @@ export const TemplateModal: React.FC<TemplateModalProps> = ({ open, onClose }) =
|
|||||||
Choose a template to get started quickly
|
Choose a template to get started quickly
|
||||||
</p>
|
</p>
|
||||||
</div>
|
</div>
|
||||||
<button onClick={onClose} style={closeButtonStyle} title="Close">
|
<button
|
||||||
✕
|
onClick={onClose}
|
||||||
|
className="template-modal-close-btn"
|
||||||
|
style={closeButtonStyle}
|
||||||
|
title="Close"
|
||||||
|
aria-label="Close"
|
||||||
|
onMouseEnter={(e) => { (e.currentTarget as HTMLElement).style.background = 'var(--color-bg-hover)'; (e.currentTarget as HTMLElement).style.color = 'var(--color-text)'; }}
|
||||||
|
onMouseLeave={(e) => { (e.currentTarget as HTMLElement).style.background = 'transparent'; (e.currentTarget as HTMLElement).style.color = '#71717a'; }}
|
||||||
|
>
|
||||||
|
<i className="fa fa-times" aria-hidden />
|
||||||
</button>
|
</button>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{/* Filter Tabs */}
|
{/* Filter Tabs -- horizontally scrollable (tabBarStyle sets
|
||||||
<div style={tabBarStyle}>
|
overflowX: 'auto') so the row never wraps/overflows the modal at
|
||||||
|
narrow widths; template-modal-tab-btn below keeps each tab from
|
||||||
|
shrinking below a comfortable touch target on mobile. */}
|
||||||
|
<div className="template-modal-tabbar" style={tabBarStyle}>
|
||||||
{TABS.map((tab) => (
|
{TABS.map((tab) => (
|
||||||
<button
|
<button
|
||||||
key={tab.value}
|
key={tab.value}
|
||||||
|
className="template-modal-tab-btn"
|
||||||
onClick={() => setActiveTab(tab.value)}
|
onClick={() => setActiveTab(tab.value)}
|
||||||
style={{
|
style={{
|
||||||
...tabStyle,
|
...tabStyle,
|
||||||
...(activeTab === tab.value ? tabActiveStyle : {}),
|
...(activeTab === tab.value ? tabActiveStyle : {}),
|
||||||
}}
|
}}
|
||||||
|
onMouseEnter={(e) => {
|
||||||
|
if (activeTab !== tab.value) (e.currentTarget as HTMLElement).style.background = 'var(--color-bg-hover)';
|
||||||
|
}}
|
||||||
|
onMouseLeave={(e) => {
|
||||||
|
if (activeTab !== tab.value) (e.currentTarget as HTMLElement).style.background = 'transparent';
|
||||||
|
}}
|
||||||
>
|
>
|
||||||
{tab.label}
|
{tab.label}
|
||||||
</button>
|
</button>
|
||||||
@@ -359,7 +389,8 @@ export const TemplateModal: React.FC<TemplateModalProps> = ({ open, onClose }) =
|
|||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
</Modal>
|
</Modal>,
|
||||||
|
document.body,
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -4,18 +4,24 @@ import { useEditorConfig } from '../../state/EditorConfigContext';
|
|||||||
import { useWhpApi } from '../../hooks/useWhpApi';
|
import { useWhpApi } from '../../hooks/useWhpApi';
|
||||||
import { usePages } from '../../state/PageContext';
|
import { usePages } from '../../state/PageContext';
|
||||||
import { useSiteDesign } from '../../state/SiteDesignContext';
|
import { useSiteDesign } from '../../state/SiteDesignContext';
|
||||||
|
import { useIsMobile } from '../../hooks/useIsMobile';
|
||||||
|
import { useMobileChrome } from '../../state/MobileChromeContext';
|
||||||
import { DeviceMode } from '../../types';
|
import { DeviceMode } from '../../types';
|
||||||
import { TemplateModal } from './TemplateModal';
|
import { TemplateModal } from './TemplateModal';
|
||||||
import { HeadCodeModal } from './HeadCodeModal';
|
import { HeadCodeModal } from './HeadCodeModal';
|
||||||
|
import { TopBarOverflowMenu } from './TopBarOverflowMenu';
|
||||||
import { SitesmithButton } from '../sitesmith/SitesmithButton';
|
import { SitesmithButton } from '../sitesmith/SitesmithButton';
|
||||||
import { useSitesmithModal } from '../../state/SitesmithContext';
|
import { useSitesmithModal } from '../../state/SitesmithContext';
|
||||||
|
|
||||||
interface TopBarProps {
|
interface TopBarProps {
|
||||||
device: DeviceMode;
|
device: DeviceMode;
|
||||||
onDeviceChange: (device: DeviceMode) => void;
|
onDeviceChange: (device: DeviceMode) => void;
|
||||||
|
/** Item 10: canvas dashed guide outlines, default ON. */
|
||||||
|
showGuides: boolean;
|
||||||
|
onToggleGuides: () => void;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const TopBar: React.FC<TopBarProps> = ({ device, onDeviceChange }) => {
|
export const TopBar: React.FC<TopBarProps> = ({ device, onDeviceChange, showGuides, onToggleGuides }) => {
|
||||||
const { whpConfig, isWHP } = useEditorConfig();
|
const { whpConfig, isWHP } = useEditorConfig();
|
||||||
const { actions, query, canUndo, canRedo } = useEditor((_state, query) => ({
|
const { actions, query, canUndo, canRedo } = useEditor((_state, query) => ({
|
||||||
canUndo: query.history.canUndo(),
|
canUndo: query.history.canUndo(),
|
||||||
@@ -28,8 +34,11 @@ export const TopBar: React.FC<TopBarProps> = ({ device, onDeviceChange }) => {
|
|||||||
const [saveStatus, setSaveStatus] = useState<'idle' | 'saving' | 'saved' | 'error'>('idle');
|
const [saveStatus, setSaveStatus] = useState<'idle' | 'saving' | 'saved' | 'error'>('idle');
|
||||||
const [publishStatus, setPublishStatus] = useState<'idle' | 'publishing' | 'published' | 'error'>('idle');
|
const [publishStatus, setPublishStatus] = useState<'idle' | 'publishing' | 'published' | 'error'>('idle');
|
||||||
const [isDraft, setIsDraft] = useState(false);
|
const [isDraft, setIsDraft] = useState(false);
|
||||||
const [templateModalOpen, setTemplateModalOpen] = useState(false);
|
// Mobile-A2: lifted from private useState into MobileChromeContext so
|
||||||
const [headCodeModalOpen, setHeadCodeModalOpen] = useState(false);
|
// opening a mobile sheet can close these modals (item 3) -- behavior is
|
||||||
|
// otherwise identical for both the desktop and mobile branches below.
|
||||||
|
const { templateModalOpen, setTemplateModalOpen, headCodeModalOpen, setHeadCodeModalOpen, overflowOpen, setOverflowOpen } = useMobileChrome();
|
||||||
|
const isMobile = useIsMobile();
|
||||||
const { open: openSitesmith } = useSitesmithModal();
|
const { open: openSitesmith } = useSitesmithModal();
|
||||||
const saveTimeoutRef = useRef<ReturnType<typeof setTimeout> | null>(null);
|
const saveTimeoutRef = useRef<ReturnType<typeof setTimeout> | null>(null);
|
||||||
const publishTimeoutRef = useRef<ReturnType<typeof setTimeout> | null>(null);
|
const publishTimeoutRef = useRef<ReturnType<typeof setTimeout> | null>(null);
|
||||||
@@ -119,52 +128,9 @@ export const TopBar: React.FC<TopBarProps> = ({ device, onDeviceChange }) => {
|
|||||||
};
|
};
|
||||||
}, []);
|
}, []);
|
||||||
|
|
||||||
return (
|
// Extracted so both the desktop inline Preview button and the mobile
|
||||||
<nav className="topbar">
|
// overflow-menu "Preview" item can trigger the exact same flow.
|
||||||
<div className="topbar-left">
|
const handlePreview = useCallback(() => {
|
||||||
{isWHP && (
|
|
||||||
<a href={whpConfig!.backUrl} className="topbar-btn back-btn" aria-label="Back to Panel">
|
|
||||||
<i className="fa fa-arrow-left" /> Back to Panel
|
|
||||||
</a>
|
|
||||||
)}
|
|
||||||
<span className="topbar-title">Site Builder</span>
|
|
||||||
{isWHP && (
|
|
||||||
<span className="topbar-domain">{whpConfig!.siteDomain}</span>
|
|
||||||
)}
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div className="topbar-center">
|
|
||||||
<div className="device-switcher">
|
|
||||||
{(['desktop', 'tablet', 'mobile'] as DeviceMode[]).map((d) => (
|
|
||||||
<button
|
|
||||||
key={d}
|
|
||||||
className={`device-btn ${device === d ? 'active' : ''}`}
|
|
||||||
onClick={() => onDeviceChange(d)}
|
|
||||||
title={d.charAt(0).toUpperCase() + d.slice(1)}
|
|
||||||
aria-label={d.charAt(0).toUpperCase() + d.slice(1)}
|
|
||||||
aria-pressed={device === d}
|
|
||||||
>
|
|
||||||
<i className={`fa ${d === 'desktop' ? 'fa-desktop' : d === 'tablet' ? 'fa-tablet' : 'fa-mobile'}`} />
|
|
||||||
</button>
|
|
||||||
))}
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div className="topbar-right">
|
|
||||||
<button className="topbar-btn" onClick={() => actions.history.undo()} disabled={!canUndo} title="Undo" aria-label="Undo">
|
|
||||||
<i className="fa fa-undo" />
|
|
||||||
</button>
|
|
||||||
<button className="topbar-btn" onClick={() => actions.history.redo()} disabled={!canRedo} title="Redo" aria-label="Redo">
|
|
||||||
<i className="fa fa-repeat" />
|
|
||||||
</button>
|
|
||||||
<span className="topbar-divider" />
|
|
||||||
<button className="topbar-btn" title="Templates" aria-label="Templates" onClick={() => setTemplateModalOpen(true)}>
|
|
||||||
<i className="fa fa-th-large" /> Templates
|
|
||||||
</button>
|
|
||||||
<button className="topbar-btn" title="Custom Head Code" aria-label="Custom Head Code" onClick={() => setHeadCodeModalOpen(true)}>
|
|
||||||
<i className="fa fa-code" /> Code
|
|
||||||
</button>
|
|
||||||
<button className="topbar-btn" title="Preview" aria-label="Preview" onClick={() => {
|
|
||||||
try {
|
try {
|
||||||
const serialized = query.serialize();
|
const serialized = query.serialize();
|
||||||
import('../../utils/html-export').then(({ exportToHtml, exportBodyHtml }) => {
|
import('../../utils/html-export').then(({ exportToHtml, exportBodyHtml }) => {
|
||||||
@@ -217,8 +183,163 @@ export const TopBar: React.FC<TopBarProps> = ({ device, onDeviceChange }) => {
|
|||||||
} catch (e) {
|
} catch (e) {
|
||||||
console.error('Preview failed:', e);
|
console.error('Preview failed:', e);
|
||||||
}
|
}
|
||||||
}}>
|
}, [query, headerPage, footerPage, whpConfig, design]);
|
||||||
<i className="fa fa-eye" /> Preview
|
|
||||||
|
// Phase A: at ≤768px the topbar collapses to only the essentials --
|
||||||
|
// back arrow, Undo/Redo, Save (+Publish) -- with Templates, Sitesmith,
|
||||||
|
// Preview, Head Code, the guides toggle, and the device switcher moved
|
||||||
|
// into the "⋯" overflow menu. This keeps desktop's JSX/behavior below
|
||||||
|
// completely untouched.
|
||||||
|
if (isMobile) {
|
||||||
|
return (
|
||||||
|
<nav className="topbar topbar-mobile">
|
||||||
|
<div className="topbar-left">
|
||||||
|
{isWHP && (
|
||||||
|
<a
|
||||||
|
href={whpConfig!.backUrl}
|
||||||
|
className="topbar-btn icon-only back-btn"
|
||||||
|
aria-label="Back to Panel"
|
||||||
|
data-tooltip="Back"
|
||||||
|
>
|
||||||
|
<i className="fa fa-arrow-left" />
|
||||||
|
</a>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div className="topbar-right">
|
||||||
|
<button
|
||||||
|
className="topbar-btn icon-only"
|
||||||
|
onClick={() => actions.history.undo()}
|
||||||
|
disabled={!canUndo}
|
||||||
|
aria-label="Undo"
|
||||||
|
data-tooltip="Undo"
|
||||||
|
>
|
||||||
|
<i className="fa fa-undo" />
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
className="topbar-btn icon-only"
|
||||||
|
onClick={() => actions.history.redo()}
|
||||||
|
disabled={!canRedo}
|
||||||
|
aria-label="Redo"
|
||||||
|
data-tooltip="Redo"
|
||||||
|
>
|
||||||
|
<i className="fa fa-repeat" />
|
||||||
|
</button>
|
||||||
|
<span className="topbar-divider" />
|
||||||
|
<button
|
||||||
|
className="topbar-btn icon-only primary"
|
||||||
|
onClick={handleSave}
|
||||||
|
disabled={saveStatus === 'saving'}
|
||||||
|
aria-label="Save Draft"
|
||||||
|
data-tooltip="Save"
|
||||||
|
>
|
||||||
|
<i className={`fa ${saveStatus === 'saving' ? 'fa-spinner fa-spin' : 'fa-save'}`} />
|
||||||
|
</button>
|
||||||
|
{isWHP && (
|
||||||
|
<button
|
||||||
|
className="topbar-btn icon-only publish"
|
||||||
|
onClick={handlePublish}
|
||||||
|
disabled={publishStatus === 'publishing' || saveStatus === 'saving'}
|
||||||
|
aria-label="Publish to live site"
|
||||||
|
data-tooltip="Publish"
|
||||||
|
>
|
||||||
|
<i className={`fa ${publishStatus === 'publishing' ? 'fa-spinner fa-spin' : 'fa-globe'}`} />
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={`topbar-btn icon-only overflow-toggle${overflowOpen ? ' active' : ''}`}
|
||||||
|
onClick={() => setOverflowOpen(!overflowOpen)}
|
||||||
|
aria-label="More options"
|
||||||
|
aria-expanded={overflowOpen}
|
||||||
|
aria-haspopup="menu"
|
||||||
|
data-tooltip="More"
|
||||||
|
>
|
||||||
|
<i className="fa fa-ellipsis-h" />
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<TopBarOverflowMenu
|
||||||
|
open={overflowOpen}
|
||||||
|
onClose={() => setOverflowOpen(false)}
|
||||||
|
device={device}
|
||||||
|
onDeviceChange={onDeviceChange}
|
||||||
|
showGuides={showGuides}
|
||||||
|
onToggleGuides={onToggleGuides}
|
||||||
|
onOpenTemplates={() => setTemplateModalOpen(true)}
|
||||||
|
onOpenHeadCode={() => setHeadCodeModalOpen(true)}
|
||||||
|
onPreview={handlePreview}
|
||||||
|
sitesmithNode={<SitesmithButton onClick={() => openSitesmith()} />}
|
||||||
|
/>
|
||||||
|
|
||||||
|
<TemplateModal open={templateModalOpen} onClose={() => setTemplateModalOpen(false)} />
|
||||||
|
<HeadCodeModal open={headCodeModalOpen} onClose={() => setHeadCodeModalOpen(false)} />
|
||||||
|
</nav>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
return (
|
||||||
|
<nav className="topbar">
|
||||||
|
<div className="topbar-left">
|
||||||
|
{isWHP && (
|
||||||
|
<a href={whpConfig!.backUrl} className="topbar-btn back-btn" aria-label="Back to Panel">
|
||||||
|
<i className="fa fa-arrow-left" /> Back to Panel
|
||||||
|
</a>
|
||||||
|
)}
|
||||||
|
<span className="topbar-title">Site Builder</span>
|
||||||
|
{isWHP && (
|
||||||
|
<span className="topbar-domain">{whpConfig!.siteDomain}</span>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div className="topbar-center">
|
||||||
|
<div className="device-switcher">
|
||||||
|
{(['desktop', 'tablet', 'mobile'] as DeviceMode[]).map((d) => (
|
||||||
|
<button
|
||||||
|
key={d}
|
||||||
|
className={`device-btn ${device === d ? 'active' : ''}`}
|
||||||
|
onClick={() => onDeviceChange(d)}
|
||||||
|
title={d.charAt(0).toUpperCase() + d.slice(1)}
|
||||||
|
aria-label={d.charAt(0).toUpperCase() + d.slice(1)}
|
||||||
|
aria-pressed={device === d}
|
||||||
|
>
|
||||||
|
<i className={`fa ${d === 'desktop' ? 'fa-desktop' : d === 'tablet' ? 'fa-tablet' : 'fa-mobile'}`} />
|
||||||
|
</button>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={`topbar-btn guides-toggle icon-only${showGuides ? ' active' : ''}`}
|
||||||
|
onClick={onToggleGuides}
|
||||||
|
aria-pressed={showGuides}
|
||||||
|
aria-label={showGuides ? 'Hide canvas guides' : 'Show canvas guides'}
|
||||||
|
data-tooltip={showGuides ? 'Hide guides' : 'Show guides'}
|
||||||
|
>
|
||||||
|
<i className={`fa ${showGuides ? 'fa-th' : 'fa-th-large'}`} aria-hidden />
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div className="topbar-right">
|
||||||
|
<button className="topbar-btn" onClick={() => actions.history.undo()} disabled={!canUndo} title="Undo" aria-label="Undo">
|
||||||
|
<i className="fa fa-undo" />
|
||||||
|
</button>
|
||||||
|
<button className="topbar-btn" onClick={() => actions.history.redo()} disabled={!canRedo} title="Redo" aria-label="Redo">
|
||||||
|
<i className="fa fa-repeat" />
|
||||||
|
</button>
|
||||||
|
<span className="topbar-divider" />
|
||||||
|
<button className="topbar-btn" title="Templates" aria-label="Templates" onClick={() => setTemplateModalOpen(true)}>
|
||||||
|
<i className="fa fa-th-large" /> Templates
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
className="topbar-btn icon-only"
|
||||||
|
aria-label="Custom Head Code"
|
||||||
|
data-tooltip="Code"
|
||||||
|
onClick={() => setHeadCodeModalOpen(true)}
|
||||||
|
>
|
||||||
|
<i className="fa fa-code" />
|
||||||
|
</button>
|
||||||
|
<button className="topbar-btn icon-only" aria-label="Preview" data-tooltip="Preview" onClick={handlePreview}>
|
||||||
|
<i className="fa fa-eye" />
|
||||||
</button>
|
</button>
|
||||||
|
|
||||||
{/* Draft/Published status badge */}
|
{/* Draft/Published status badge */}
|
||||||
|
|||||||
@@ -0,0 +1,110 @@
|
|||||||
|
import React, { useEffect, useRef } from 'react';
|
||||||
|
import { DeviceMode } from '../../types';
|
||||||
|
|
||||||
|
export interface TopBarOverflowMenuProps {
|
||||||
|
open: boolean;
|
||||||
|
onClose: () => void;
|
||||||
|
device: DeviceMode;
|
||||||
|
onDeviceChange: (device: DeviceMode) => void;
|
||||||
|
showGuides: boolean;
|
||||||
|
onToggleGuides: () => void;
|
||||||
|
onOpenTemplates: () => void;
|
||||||
|
onOpenHeadCode: () => void;
|
||||||
|
onPreview: () => void;
|
||||||
|
/** Rendered `<SitesmithButton onClick={...} />` -- passed in rather than
|
||||||
|
* re-implemented here so the mobile menu reuses the exact same
|
||||||
|
* lock/cap-aware button the desktop topbar shows. */
|
||||||
|
sitesmithNode: React.ReactNode;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Mobile topbar "⋯" overflow menu (Phase A). At ≤768px, TopBar collapses to
|
||||||
|
* just the back arrow, Undo/Redo, Save/Publish, and this menu -- everything
|
||||||
|
* else that's inline on desktop (Templates, Sitesmith, Preview, Head Code,
|
||||||
|
* the guides toggle, and the device-width switcher) moves in here so the
|
||||||
|
* collapsed bar never overlaps or pushes controls off-screen.
|
||||||
|
*/
|
||||||
|
export const TopBarOverflowMenu: React.FC<TopBarOverflowMenuProps> = ({
|
||||||
|
open,
|
||||||
|
onClose,
|
||||||
|
device,
|
||||||
|
onDeviceChange,
|
||||||
|
showGuides,
|
||||||
|
onToggleGuides,
|
||||||
|
onOpenTemplates,
|
||||||
|
onOpenHeadCode,
|
||||||
|
onPreview,
|
||||||
|
sitesmithNode,
|
||||||
|
}) => {
|
||||||
|
const menuRef = useRef<HTMLDivElement>(null);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!open) return;
|
||||||
|
const handleClick = (e: MouseEvent) => {
|
||||||
|
if (menuRef.current && !menuRef.current.contains(e.target as Node)) onClose();
|
||||||
|
};
|
||||||
|
const handleEsc = (e: KeyboardEvent) => {
|
||||||
|
if (e.key === 'Escape') onClose();
|
||||||
|
};
|
||||||
|
document.addEventListener('mousedown', handleClick);
|
||||||
|
document.addEventListener('keydown', handleEsc);
|
||||||
|
return () => {
|
||||||
|
document.removeEventListener('mousedown', handleClick);
|
||||||
|
document.removeEventListener('keydown', handleEsc);
|
||||||
|
};
|
||||||
|
}, [open, onClose]);
|
||||||
|
|
||||||
|
if (!open) return null;
|
||||||
|
|
||||||
|
const runAndClose = (fn: () => void) => () => {
|
||||||
|
fn();
|
||||||
|
onClose();
|
||||||
|
};
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div ref={menuRef} className="topbar-overflow-menu" role="menu">
|
||||||
|
<div className="topbar-overflow-section">
|
||||||
|
<span className="topbar-overflow-label">Preview width</span>
|
||||||
|
<div className="device-switcher">
|
||||||
|
{(['desktop', 'tablet', 'mobile'] as DeviceMode[]).map((d) => (
|
||||||
|
<button
|
||||||
|
key={d}
|
||||||
|
type="button"
|
||||||
|
className={`device-btn ${device === d ? 'active' : ''}`}
|
||||||
|
onClick={() => onDeviceChange(d)}
|
||||||
|
title={d.charAt(0).toUpperCase() + d.slice(1)}
|
||||||
|
aria-label={d.charAt(0).toUpperCase() + d.slice(1)}
|
||||||
|
aria-pressed={device === d}
|
||||||
|
>
|
||||||
|
<i className={`fa ${d === 'desktop' ? 'fa-desktop' : d === 'tablet' ? 'fa-tablet' : 'fa-mobile'}`} />
|
||||||
|
</button>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<button type="button" className="topbar-overflow-item" role="menuitem" onClick={runAndClose(onOpenTemplates)}>
|
||||||
|
<i className="fa fa-th-large" aria-hidden="true" /> Templates
|
||||||
|
</button>
|
||||||
|
<button type="button" className="topbar-overflow-item" role="menuitem" onClick={runAndClose(onPreview)}>
|
||||||
|
<i className="fa fa-eye" aria-hidden="true" /> Preview
|
||||||
|
</button>
|
||||||
|
<button type="button" className="topbar-overflow-item" role="menuitem" onClick={runAndClose(onOpenHeadCode)}>
|
||||||
|
<i className="fa fa-code" aria-hidden="true" /> Head Code
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={`topbar-overflow-item${showGuides ? ' active' : ''}`}
|
||||||
|
role="menuitem"
|
||||||
|
onClick={runAndClose(onToggleGuides)}
|
||||||
|
aria-pressed={showGuides}
|
||||||
|
>
|
||||||
|
<i className={`fa ${showGuides ? 'fa-th' : 'fa-th-large'}`} aria-hidden="true" />
|
||||||
|
{' '}{showGuides ? 'Hide Guides' : 'Show Guides'}
|
||||||
|
</button>
|
||||||
|
|
||||||
|
<div className="topbar-overflow-sitesmith" onClick={onClose}>
|
||||||
|
{sitesmithNode}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
};
|
||||||
@@ -0,0 +1,162 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
import { Editor, useEditor } from '@craftjs/core';
|
||||||
|
import { componentResolver } from '../../components/resolver';
|
||||||
|
import { allTemplates } from '../../templates';
|
||||||
|
import { buildNodeTree } from '../../utils/craft-tree';
|
||||||
|
import { templateComponentToTreeNode } from '../../templates/apply-template';
|
||||||
|
import { exportBodyHtml } from '../../utils/html-export';
|
||||||
|
import { DEFAULT_HEADER_STATE } from '../../state/PageContext';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Regression test for: loading a template makes the header/footer ZONE
|
||||||
|
* PREVIEW (`ZonePreview` in `editor/Canvas.tsx`, which calls
|
||||||
|
* `exportBodyHtml(craftState)`) render as an empty strip -- no nav links, no
|
||||||
|
* logo, no footer text -- and (a second bug found while fixing the first)
|
||||||
|
* makes a template page's `Section`-wrapped content crash the live editor
|
||||||
|
* entirely.
|
||||||
|
*
|
||||||
|
* This drives the EXACT same path `TemplateModal.tsx`'s `applyZone` /
|
||||||
|
* `addTemplateComponents` uses to load a template's header/footer/page
|
||||||
|
* content onto the live Craft.js canvas (`buildNodeTree` +
|
||||||
|
* `actions.addNodeTree(tree, 'ROOT')`), then serializes it
|
||||||
|
* (`query.serialize()`, exactly what `PageContext`'s `switchPage` /
|
||||||
|
* `saveCurrentState` do right after `TemplateModal` finishes applying a
|
||||||
|
* zone/page) and feeds the result through `exportBodyHtml` -- the same
|
||||||
|
* function `ZonePreview` calls, and the same function `handlePublish` uses
|
||||||
|
* to compose the published header/footer HTML. So this also covers whether
|
||||||
|
* published output is affected (it was).
|
||||||
|
*/
|
||||||
|
let api: any;
|
||||||
|
function Harness() {
|
||||||
|
const { actions, query } = useEditor();
|
||||||
|
api = { actions, query };
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
function mount() {
|
||||||
|
const container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
let root!: Root;
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(
|
||||||
|
<Editor resolver={componentResolver}>
|
||||||
|
<Harness />
|
||||||
|
</Editor>,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
return {
|
||||||
|
container,
|
||||||
|
unmount: () => {
|
||||||
|
act(() => {
|
||||||
|
root.unmount();
|
||||||
|
});
|
||||||
|
container.remove();
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Mirrors TemplateModal.tsx's addTemplateComponents(). */
|
||||||
|
function addTemplateComponents(components: any[]) {
|
||||||
|
for (const comp of components) {
|
||||||
|
const tree = buildNodeTree(api.query, templateComponentToTreeNode(comp));
|
||||||
|
api.actions.addNodeTree(tree, 'ROOT');
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
const EMPTY_HEADER_ROOT =
|
||||||
|
'{"ROOT":{"type":{"resolvedName":"Container"},"isCanvas":true,"props":{"style":{},"tag":"header"},"displayName":"Container","custom":{},"hidden":false,"nodes":[],"linkedNodes":{}}}';
|
||||||
|
|
||||||
|
const EMPTY_CANVAS_ROOT =
|
||||||
|
'{"ROOT":{"type":{"resolvedName":"Container"},"isCanvas":true,"props":{"style":{},"tag":"div"},"displayName":"Container","custom":{},"hidden":false,"nodes":[],"linkedNodes":{}}}';
|
||||||
|
|
||||||
|
describe('template header/footer zone export (loading a template)', () => {
|
||||||
|
test('sanity check: the DEFAULT header (fresh project, no template) exports its content', () => {
|
||||||
|
const { html } = exportBodyHtml(DEFAULT_HEADER_STATE);
|
||||||
|
expect(html).toContain('MySite');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a template header (SaaS Landing) exports its real nav/logo content -- not an empty strip', () => {
|
||||||
|
const tpl = allTemplates.find((t) => t.id === 'saas-landing');
|
||||||
|
expect(tpl).toBeDefined();
|
||||||
|
expect(tpl!.header.components.length).toBeGreaterThan(0);
|
||||||
|
|
||||||
|
const { unmount } = mount();
|
||||||
|
act(() => {
|
||||||
|
api.actions.deserialize(EMPTY_HEADER_ROOT);
|
||||||
|
});
|
||||||
|
act(() => {
|
||||||
|
addTemplateComponents(tpl!.header.components);
|
||||||
|
});
|
||||||
|
|
||||||
|
const serialized = api.query.serialize();
|
||||||
|
const { html } = exportBodyHtml(serialized);
|
||||||
|
|
||||||
|
// The template's logo text and a real nav link -- if these are missing,
|
||||||
|
// the header rendered as an empty strip (the reported bug).
|
||||||
|
expect(html).toContain('FlowStack');
|
||||||
|
expect(html).toContain('Features');
|
||||||
|
expect(html).toContain('Start Free');
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a template footer (SaaS Landing) exports its real copyright/tagline content -- not an empty strip', () => {
|
||||||
|
const tpl = allTemplates.find((t) => t.id === 'saas-landing');
|
||||||
|
expect(tpl).toBeDefined();
|
||||||
|
expect(tpl!.footer.components.length).toBeGreaterThan(0);
|
||||||
|
|
||||||
|
const { unmount } = mount();
|
||||||
|
act(() => {
|
||||||
|
api.actions.deserialize(
|
||||||
|
'{"ROOT":{"type":{"resolvedName":"Container"},"isCanvas":true,"props":{"style":{},"tag":"footer"},"displayName":"Container","custom":{},"hidden":false,"nodes":[],"linkedNodes":{}}}',
|
||||||
|
);
|
||||||
|
});
|
||||||
|
act(() => {
|
||||||
|
addTemplateComponents(tpl!.footer.components);
|
||||||
|
});
|
||||||
|
|
||||||
|
const serialized = api.query.serialize();
|
||||||
|
const { html } = exportBodyHtml(serialized);
|
||||||
|
|
||||||
|
expect(html).toContain('FlowStack, Inc.');
|
||||||
|
expect(html).toContain('Ship products faster');
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a template page Section with nested children (SaaS Landing Home) builds + exports without crashing', () => {
|
||||||
|
// Regression for the SECOND bug surfaced while fixing the first: naively
|
||||||
|
// rebuilding nested children via React.createElement + parseReactElement
|
||||||
|
// crashes any component with an internal SHELL_INNER linked canvas
|
||||||
|
// (Section/BackgroundSection/FormContainer) or linked columns
|
||||||
|
// (ColumnLayout). The SaaS Landing home page's second component is a
|
||||||
|
// `Section` wrapping a `Heading` ("Trusted by 10,000+ development
|
||||||
|
// teams...") -- exactly this shape.
|
||||||
|
const tpl = allTemplates.find((t) => t.id === 'saas-landing');
|
||||||
|
const homePage = tpl!.pages[0];
|
||||||
|
const sectionComp = homePage.content.components.find((c) => c.type === 'Section');
|
||||||
|
expect(sectionComp).toBeDefined();
|
||||||
|
expect(sectionComp!.children?.length).toBeGreaterThan(0);
|
||||||
|
|
||||||
|
const { unmount } = mount();
|
||||||
|
act(() => {
|
||||||
|
api.actions.deserialize(EMPTY_CANVAS_ROOT);
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(() => {
|
||||||
|
act(() => {
|
||||||
|
addTemplateComponents([sectionComp!]);
|
||||||
|
});
|
||||||
|
}).not.toThrow();
|
||||||
|
|
||||||
|
const serialized = api.query.serialize();
|
||||||
|
const { html } = exportBodyHtml(serialized);
|
||||||
|
expect(html).toContain('Trusted by 10,000+ development teams');
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,152 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
import { MobileChromeProvider, useMobileChrome, MobileSheetTab } from './MobileChromeContext';
|
||||||
|
import { SitesmithProvider, useSitesmithModal } from './SitesmithContext';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Mobile-A2 (review item 5): covers the two invariants item 3 depends on --
|
||||||
|
* (1) only one sheet is ever open ("tab-bar-always-wins", Phase A's existing
|
||||||
|
* behavior, now backed by the shared context instead of a private
|
||||||
|
* useState), and (2) opening a sheet closes any open full-screen modal
|
||||||
|
* (Templates / Head Code / Sitesmith), so a sheet is never shown stacked
|
||||||
|
* underneath one.
|
||||||
|
*
|
||||||
|
* DOM-harness pattern mirrors PageContext.pure-updaters.test.tsx: bare
|
||||||
|
* createRoot + act, a Consumer component that stashes the hook result on an
|
||||||
|
* outer variable so assertions can run outside of render.
|
||||||
|
*/
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
|
||||||
|
function render(ui: React.ReactElement) {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(ui);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function unmount() {
|
||||||
|
act(() => {
|
||||||
|
root.unmount();
|
||||||
|
});
|
||||||
|
container.remove();
|
||||||
|
}
|
||||||
|
|
||||||
|
let chrome: ReturnType<typeof useMobileChrome> | null = null;
|
||||||
|
let sitesmith: ReturnType<typeof useSitesmithModal> | null = null;
|
||||||
|
|
||||||
|
const Consumer: React.FC = () => {
|
||||||
|
chrome = useMobileChrome();
|
||||||
|
sitesmith = useSitesmithModal();
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
|
function renderProviders() {
|
||||||
|
render(
|
||||||
|
<SitesmithProvider>
|
||||||
|
<MobileChromeProvider>
|
||||||
|
<Consumer />
|
||||||
|
</MobileChromeProvider>
|
||||||
|
</SitesmithProvider>,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('MobileChromeContext', () => {
|
||||||
|
test('only one sheet is ever open at a time', () => {
|
||||||
|
renderProviders();
|
||||||
|
|
||||||
|
act(() => chrome!.openSheet('blocks'));
|
||||||
|
expect(chrome!.activeSheet).toBe('blocks');
|
||||||
|
|
||||||
|
// Opening a different sheet replaces the previous one -- never both.
|
||||||
|
act(() => chrome!.openSheet('styles'));
|
||||||
|
expect(chrome!.activeSheet).toBe('styles');
|
||||||
|
|
||||||
|
act(() => chrome!.closeSheet());
|
||||||
|
expect(chrome!.activeSheet).toBeNull();
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('openSheet is idempotent-safe: opening the same tab twice stays open (caller owns toggle-to-close)', () => {
|
||||||
|
renderProviders();
|
||||||
|
|
||||||
|
act(() => chrome!.openSheet('pages'));
|
||||||
|
expect(chrome!.activeSheet).toBe('pages');
|
||||||
|
|
||||||
|
act(() => chrome!.openSheet('pages'));
|
||||||
|
expect(chrome!.activeSheet).toBe('pages');
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('openSheet closes an open Templates modal', () => {
|
||||||
|
renderProviders();
|
||||||
|
|
||||||
|
act(() => chrome!.setTemplateModalOpen(true));
|
||||||
|
expect(chrome!.templateModalOpen).toBe(true);
|
||||||
|
|
||||||
|
act(() => chrome!.openSheet('blocks'));
|
||||||
|
expect(chrome!.templateModalOpen).toBe(false);
|
||||||
|
expect(chrome!.activeSheet).toBe('blocks');
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('openSheet closes an open Head Code modal', () => {
|
||||||
|
renderProviders();
|
||||||
|
|
||||||
|
act(() => chrome!.setHeadCodeModalOpen(true));
|
||||||
|
expect(chrome!.headCodeModalOpen).toBe(true);
|
||||||
|
|
||||||
|
act(() => chrome!.openSheet('assets'));
|
||||||
|
expect(chrome!.headCodeModalOpen).toBe(false);
|
||||||
|
expect(chrome!.activeSheet).toBe('assets');
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('openSheet closes an open Sitesmith modal', () => {
|
||||||
|
renderProviders();
|
||||||
|
|
||||||
|
act(() => sitesmith!.open());
|
||||||
|
expect(sitesmith!.isOpen).toBe(true);
|
||||||
|
|
||||||
|
act(() => chrome!.openSheet('layers'));
|
||||||
|
|
||||||
|
// sitesmith is a stale snapshot from before the re-render the `act`
|
||||||
|
// above triggered; re-read via the live ref after settling.
|
||||||
|
expect(sitesmith!.isOpen).toBe(false);
|
||||||
|
expect(chrome!.activeSheet).toBe('layers');
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('closeSheet does not disturb modal state', () => {
|
||||||
|
renderProviders();
|
||||||
|
|
||||||
|
act(() => chrome!.openSheet('styles'));
|
||||||
|
act(() => chrome!.closeSheet());
|
||||||
|
|
||||||
|
expect(chrome!.activeSheet).toBeNull();
|
||||||
|
expect(chrome!.templateModalOpen).toBe(false);
|
||||||
|
expect(chrome!.headCodeModalOpen).toBe(false);
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('sheet tabs are exactly the five mobile panels', () => {
|
||||||
|
const tabs: MobileSheetTab[] = ['blocks', 'pages', 'layers', 'assets', 'styles'];
|
||||||
|
renderProviders();
|
||||||
|
tabs.forEach((tab) => {
|
||||||
|
act(() => chrome!.openSheet(tab));
|
||||||
|
expect(chrome!.activeSheet).toBe(tab);
|
||||||
|
});
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,104 @@
|
|||||||
|
import React, { createContext, useCallback, useContext, useMemo, useState } from 'react';
|
||||||
|
import { useSitesmithModal } from './SitesmithContext';
|
||||||
|
|
||||||
|
/** Mobile bottom-sheet tabs (Phase A: Blocks/Pages/Layers/Assets/Styles).
|
||||||
|
* Exported so Phase B can open a specific sheet from outside
|
||||||
|
* `MobilePanelBar` -- e.g. the selection toolbar's "Edit styles" action
|
||||||
|
* opening 'styles', or tap-to-add closing 'blocks' after inserting a
|
||||||
|
* block on the canvas. */
|
||||||
|
export type MobileSheetTab = 'blocks' | 'pages' | 'layers' | 'assets' | 'styles';
|
||||||
|
|
||||||
|
interface MobileChromeContextValue {
|
||||||
|
/** Which bottom sheet (if any) is open. Only one at a time -- this is a
|
||||||
|
* single value by construction, not a set, so "one sheet open" is an
|
||||||
|
* invariant of the type, not something callers have to maintain. */
|
||||||
|
activeSheet: MobileSheetTab | null;
|
||||||
|
/** Opens `tab`'s sheet (replacing whatever sheet, if any, was open).
|
||||||
|
* Per item 3 (no accidental overlay stacking), this also closes any
|
||||||
|
* open full-screen modal -- Templates, Head Code, Sitesmith -- so a
|
||||||
|
* sheet is never shown stacked underneath one. Toggle-to-close is the
|
||||||
|
* CALLER's job (see MobilePanelBar's tab click handler): this function
|
||||||
|
* always opens, so Phase B can call it unconditionally. */
|
||||||
|
openSheet: (tab: MobileSheetTab) => void;
|
||||||
|
/** Closes the open sheet, if any. No-op otherwise. */
|
||||||
|
closeSheet: () => void;
|
||||||
|
|
||||||
|
/** Mobile topbar "..." overflow menu open state -- lifted here too
|
||||||
|
* ("+ the overflow-menu open state if convenient" per the brief) so
|
||||||
|
* Phase B can close it alongside sheets/modals from one place. */
|
||||||
|
overflowOpen: boolean;
|
||||||
|
setOverflowOpen: (open: boolean) => void;
|
||||||
|
|
||||||
|
/** Templates / Head Code modal open state, lifted out of TopBar so
|
||||||
|
* `openSheet` can close them directly (see above). Behavior is
|
||||||
|
* otherwise identical to the private useState these replaced. */
|
||||||
|
templateModalOpen: boolean;
|
||||||
|
setTemplateModalOpen: (open: boolean) => void;
|
||||||
|
|
||||||
|
headCodeModalOpen: boolean;
|
||||||
|
setHeadCodeModalOpen: (open: boolean) => void;
|
||||||
|
}
|
||||||
|
|
||||||
|
const noop = () => {};
|
||||||
|
|
||||||
|
/** Default value mirrors the other state contexts in this codebase
|
||||||
|
* (EditorConfigContext, PageContext, SiteDesignContext): a harmless no-op
|
||||||
|
* stub rather than throwing, so a consumer rendered outside the provider
|
||||||
|
* (e.g. in a narrower test) degrades quietly instead of crashing. */
|
||||||
|
const MobileChromeContext = createContext<MobileChromeContextValue>({
|
||||||
|
activeSheet: null,
|
||||||
|
openSheet: noop,
|
||||||
|
closeSheet: noop,
|
||||||
|
overflowOpen: false,
|
||||||
|
setOverflowOpen: noop,
|
||||||
|
templateModalOpen: false,
|
||||||
|
setTemplateModalOpen: noop,
|
||||||
|
headCodeModalOpen: false,
|
||||||
|
setHeadCodeModalOpen: noop,
|
||||||
|
});
|
||||||
|
|
||||||
|
export const useMobileChrome = () => useContext(MobileChromeContext);
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Shared mobile editor-chrome state (Phase A hardening / Phase B prep).
|
||||||
|
* Previously `activeTab`/sheet-open state lived as a private `useState`
|
||||||
|
* inside `MobilePanelBar`, which meant only a tap on the tab bar itself
|
||||||
|
* could open or close a sheet. Phase B needs to drive this from elsewhere
|
||||||
|
* (a canvas selection toolbar, tap-to-add, etc.), so it's lifted into this
|
||||||
|
* context, provided once in `EditorShell.tsx` around the whole mobile+
|
||||||
|
* desktop tree (harmless on desktop -- nothing there consumes it except
|
||||||
|
* `TopBar`'s Templates/Head Code modal state, which behaves identically to
|
||||||
|
* the private `useState` it replaced).
|
||||||
|
*/
|
||||||
|
export const MobileChromeProvider: React.FC<{ children: React.ReactNode }> = ({ children }) => {
|
||||||
|
const [activeSheet, setActiveSheet] = useState<MobileSheetTab | null>(null);
|
||||||
|
const [overflowOpen, setOverflowOpen] = useState(false);
|
||||||
|
const [templateModalOpen, setTemplateModalOpen] = useState(false);
|
||||||
|
const [headCodeModalOpen, setHeadCodeModalOpen] = useState(false);
|
||||||
|
const { close: closeSitesmith } = useSitesmithModal();
|
||||||
|
|
||||||
|
const openSheet = useCallback((tab: MobileSheetTab) => {
|
||||||
|
setActiveSheet(tab);
|
||||||
|
// Item 3: a sheet and a full-screen modal must never stack -- opening
|
||||||
|
// a sheet always wins over whatever modal was open.
|
||||||
|
setTemplateModalOpen(false);
|
||||||
|
setHeadCodeModalOpen(false);
|
||||||
|
closeSitesmith();
|
||||||
|
}, [closeSitesmith]);
|
||||||
|
|
||||||
|
const closeSheet = useCallback(() => setActiveSheet(null), []);
|
||||||
|
|
||||||
|
const value = useMemo<MobileChromeContextValue>(() => ({
|
||||||
|
activeSheet,
|
||||||
|
openSheet,
|
||||||
|
closeSheet,
|
||||||
|
overflowOpen,
|
||||||
|
setOverflowOpen,
|
||||||
|
templateModalOpen,
|
||||||
|
setTemplateModalOpen,
|
||||||
|
headCodeModalOpen,
|
||||||
|
setHeadCodeModalOpen,
|
||||||
|
}), [activeSheet, openSheet, closeSheet, overflowOpen, templateModalOpen, headCodeModalOpen]);
|
||||||
|
|
||||||
|
return <MobileChromeContext.Provider value={value}>{children}</MobileChromeContext.Provider>;
|
||||||
|
};
|
||||||
@@ -2,7 +2,7 @@ import { describe, test, expect, vi, beforeEach, afterEach } from 'vitest';
|
|||||||
import React from 'react';
|
import React from 'react';
|
||||||
import { createRoot, Root } from 'react-dom/client';
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
import { act } from 'react-dom/test-utils';
|
import { act } from 'react-dom/test-utils';
|
||||||
import { PageProvider, usePages, uniqueSlug } from './PageContext';
|
import { PageProvider, usePages, uniqueSlug, nextPageId } from './PageContext';
|
||||||
|
|
||||||
/* PageContext only needs `useEditor` from @craftjs/core (for query.serialize /
|
/* PageContext only needs `useEditor` from @craftjs/core (for query.serialize /
|
||||||
actions.deserialize during page switches) — mock just that so PageProvider
|
actions.deserialize during page switches) — mock just that so PageProvider
|
||||||
@@ -15,11 +15,10 @@ vi.mock('@craftjs/core', () => ({
|
|||||||
}),
|
}),
|
||||||
}));
|
}));
|
||||||
|
|
||||||
/* addPage mints ids from `Date.now()`. Two adds inside the same test can land
|
/* addPage mints ids via nextPageId() (timestamp + monotonic counter, M-3),
|
||||||
in the same millisecond and collide on id, which is an existing, unrelated
|
so same-millisecond calls no longer collide on id. Date.now() is still
|
||||||
bug (id collision, not slug collision) — out of scope here but it makes
|
pinned/advanced here for determinism across the slug-dedupe assertions
|
||||||
these tests flaky since a colliding id defeats the "other pages" slug
|
below, independent of wall-clock timing. */
|
||||||
lookup. Force distinct ids so the slug-dedupe assertions below are stable. */
|
|
||||||
let dateNowSpy: ReturnType<typeof vi.spyOn>;
|
let dateNowSpy: ReturnType<typeof vi.spyOn>;
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
let counter = 1_700_000_000_000;
|
let counter = 1_700_000_000_000;
|
||||||
@@ -48,6 +47,23 @@ function unmount() {
|
|||||||
container.remove();
|
container.remove();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
describe('nextPageId (M-3: no same-millisecond id collision)', () => {
|
||||||
|
test('two calls yield distinct ids even when Date.now() is pinned to a constant', () => {
|
||||||
|
const spy = vi.spyOn(Date, 'now').mockReturnValue(1_700_000_000_000);
|
||||||
|
try {
|
||||||
|
const id1 = nextPageId();
|
||||||
|
const id2 = nextPageId();
|
||||||
|
expect(id1).not.toBe(id2);
|
||||||
|
} finally {
|
||||||
|
spy.mockRestore();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test('ids are prefixed with "page_"', () => {
|
||||||
|
expect(nextPageId()).toMatch(/^page_/);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe('uniqueSlug', () => {
|
describe('uniqueSlug', () => {
|
||||||
test('returns base unchanged when no collision', () => {
|
test('returns base unchanged when no collision', () => {
|
||||||
expect(uniqueSlug('about', ['index', 'contact'])).toBe('about');
|
expect(uniqueSlug('about', ['index', 'contact'])).toBe('about');
|
||||||
|
|||||||
@@ -43,6 +43,20 @@ interface PageContextValue {
|
|||||||
const HEADER_ID = '__header__';
|
const HEADER_ID = '__header__';
|
||||||
const FOOTER_ID = '__footer__';
|
const FOOTER_ID = '__footer__';
|
||||||
|
|
||||||
|
// M-3: `page_${Date.now()}` alone collides when two pages are minted inside
|
||||||
|
// the same millisecond (addPage called twice in quick succession, or two AI
|
||||||
|
// replaceAllPages entries) -- then rename/delete/save operate on both pages
|
||||||
|
// at once since they share an id. A module-scoped monotonic counter,
|
||||||
|
// combined with the timestamp, guarantees uniqueness regardless of how many
|
||||||
|
// ids are minted within the same millisecond. This is state/id-minting code
|
||||||
|
// (not toHtml/export), so Date.now() here is fine -- see task-minors-brief.md.
|
||||||
|
let pageIdCounter = 0;
|
||||||
|
|
||||||
|
/** Mints a unique page id: timestamp (base36) + a monotonic per-process counter (base36). */
|
||||||
|
export function nextPageId(): string {
|
||||||
|
return 'page_' + Date.now().toString(36) + '_' + (++pageIdCounter).toString(36);
|
||||||
|
}
|
||||||
|
|
||||||
const EMPTY_CANVAS =
|
const EMPTY_CANVAS =
|
||||||
'{"ROOT":{"type":{"resolvedName":"Container"},"isCanvas":true,"props":{"style":{"minHeight":"100vh","backgroundColor":"#ffffff"},"tag":"div"},"displayName":"Container","custom":{},"hidden":false,"nodes":[],"linkedNodes":{}}}';
|
'{"ROOT":{"type":{"resolvedName":"Container"},"isCanvas":true,"props":{"style":{"minHeight":"100vh","backgroundColor":"#ffffff"},"tag":"div"},"displayName":"Container","custom":{},"hidden":false,"nodes":[],"linkedNodes":{}}}';
|
||||||
|
|
||||||
@@ -105,6 +119,13 @@ export function treeToCraftState(tree: SerializedTreeNode): string {
|
|||||||
// Container), so there was no menu to edit and the empty zone rendered as a
|
// Container), so there was no menu to edit and the empty zone rendered as a
|
||||||
// stray band above the page. Seeding a real Navbar gives every new site an
|
// stray band above the page. Seeding a real Navbar gives every new site an
|
||||||
// editable menu-with-links out of the box (and removes the empty-header gap).
|
// editable menu-with-links out of the box (and removes the empty-header gap).
|
||||||
|
//
|
||||||
|
// Item 15: the nav used to link Home/About/Services/Contact, but a brand
|
||||||
|
// new site only has a "Home" page -- About/Services/Contact were dead links
|
||||||
|
// on first click. Rather than seeding three empty placeholder pages nobody
|
||||||
|
// asked for, the simpler default is a nav with just the one real page (Home)
|
||||||
|
// plus a CTA button, which is inert (`href: '#'`) rather than pointing at a
|
||||||
|
// page that doesn't exist. Users add pages/links as their site grows.
|
||||||
// Node shape matches treeToCraftState() / Craft's actions.deserialize().
|
// Node shape matches treeToCraftState() / Craft's actions.deserialize().
|
||||||
export const DEFAULT_HEADER_STATE = JSON.stringify({
|
export const DEFAULT_HEADER_STATE = JSON.stringify({
|
||||||
ROOT: {
|
ROOT: {
|
||||||
@@ -130,9 +151,7 @@ export const DEFAULT_HEADER_STATE = JSON.stringify({
|
|||||||
logoFontSize: '20px',
|
logoFontSize: '20px',
|
||||||
links: [
|
links: [
|
||||||
{ text: 'Home', href: '/' },
|
{ text: 'Home', href: '/' },
|
||||||
{ text: 'About', href: '#about' },
|
{ text: 'Get Started', href: '#', isCta: true },
|
||||||
{ text: 'Services', href: '#services' },
|
|
||||||
{ text: 'Contact', href: '#contact', isCta: true },
|
|
||||||
],
|
],
|
||||||
backgroundColor: '#ffffff',
|
backgroundColor: '#ffffff',
|
||||||
textColor: '#3f3f46',
|
textColor: '#3f3f46',
|
||||||
@@ -338,7 +357,7 @@ export const PageProvider: React.FC<{ children: ReactNode }> = ({ children }) =>
|
|||||||
const addPage = useCallback(
|
const addPage = useCallback(
|
||||||
(name: string, slug: string) => {
|
(name: string, slug: string) => {
|
||||||
const requestedSlug = slug || slugify(name);
|
const requestedSlug = slug || slugify(name);
|
||||||
const id = `page_${Date.now()}`;
|
const id = nextPageId();
|
||||||
|
|
||||||
// Save current page first
|
// Save current page first
|
||||||
saveCurrentState();
|
saveCurrentState();
|
||||||
@@ -452,7 +471,7 @@ export const PageProvider: React.FC<{ children: ReactNode }> = ({ children }) =>
|
|||||||
const slug = i === 0 ? 'index' : uniqueSlug(slugify(p.name), seenSlugs);
|
const slug = i === 0 ? 'index' : uniqueSlug(slugify(p.name), seenSlugs);
|
||||||
seenSlugs.push(slug);
|
seenSlugs.push(slug);
|
||||||
return {
|
return {
|
||||||
id: i === 0 ? 'home' : `page_${Date.now()}_${i}`,
|
id: i === 0 ? 'home' : nextPageId(),
|
||||||
name: p.name,
|
name: p.name,
|
||||||
slug,
|
slug,
|
||||||
craftState: treeToCraftState(p.tree),
|
craftState: treeToCraftState(p.tree),
|
||||||
|
|||||||
@@ -23,8 +23,14 @@ describe('DEFAULT_HEADER_STATE seed', () => {
|
|||||||
const { html } = exportBodyHtml(DEFAULT_HEADER_STATE);
|
const { html } = exportBodyHtml(DEFAULT_HEADER_STATE);
|
||||||
expect(html).toContain('<nav');
|
expect(html).toContain('<nav');
|
||||||
expect(html).toContain('MySite');
|
expect(html).toContain('MySite');
|
||||||
for (const link of ['Home', 'About', 'Services', 'Contact']) {
|
// Item 15: the default nav only links pages/anchors that actually exist
|
||||||
|
// on a brand new site (just "Home") plus an inert CTA -- no dead links
|
||||||
|
// to About/Services/Contact pages that were never seeded.
|
||||||
|
for (const link of ['Home', 'Get Started']) {
|
||||||
expect(html).toContain(link);
|
expect(html).toContain(link);
|
||||||
}
|
}
|
||||||
|
expect(html).not.toContain('About');
|
||||||
|
expect(html).not.toContain('Services');
|
||||||
|
expect(html).not.toContain('Contact');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
+628
-50
@@ -16,8 +16,8 @@
|
|||||||
--color-border: #2d2d3a;
|
--color-border: #2d2d3a;
|
||||||
--color-border-light: #3f3f46;
|
--color-border-light: #3f3f46;
|
||||||
--color-text: #e4e4e7;
|
--color-text: #e4e4e7;
|
||||||
--color-text-muted: #71717a;
|
--color-text-muted: #8b8b96;
|
||||||
--color-text-dim: #52525b;
|
--color-text-dim: #6e6e78;
|
||||||
--color-accent: #3b82f6;
|
--color-accent: #3b82f6;
|
||||||
--color-accent-hover: #2563eb;
|
--color-accent-hover: #2563eb;
|
||||||
--color-accent-subtle: rgba(59, 130, 246, 0.12);
|
--color-accent-subtle: rgba(59, 130, 246, 0.12);
|
||||||
@@ -31,6 +31,32 @@
|
|||||||
--radius-lg: 8px;
|
--radius-lg: 8px;
|
||||||
--transition-fast: 0.15s ease;
|
--transition-fast: 0.15s ease;
|
||||||
--transition-normal: 0.25s ease;
|
--transition-normal: 0.25s ease;
|
||||||
|
/* Phase A (mobile): fixed bottom tab bar height, used to size
|
||||||
|
.editor-container and the safe-area padding math below. */
|
||||||
|
--mobile-tabbar-height: 58px;
|
||||||
|
/* Phase B fast-follow item 4: rendered height of `.mobile-selection-toolbar`
|
||||||
|
(44px min-height content + 4px top/bottom padding + 1px border) -- used
|
||||||
|
to pad the canvas scroll area clear of it while it's visible, see
|
||||||
|
`.editor-canvas.has-mobile-selection-toolbar` below. */
|
||||||
|
--mobile-selection-toolbar-height: 53px;
|
||||||
|
|
||||||
|
/* Mobile-A2: explicit overlay layer scale (was ad-hoc numbers scattered
|
||||||
|
across the mobile block + Modal.tsx, causing accidental stacking --
|
||||||
|
e.g. the Templates modal getting trapped under the tab bar inside
|
||||||
|
.topbar's own stacking context). Higher = closer to the user.
|
||||||
|
--z-selection-toolbar is reserved for Phase B's selection toolbar. */
|
||||||
|
--z-sheet-backdrop: 400;
|
||||||
|
--z-tabbar: 500;
|
||||||
|
--z-selection-toolbar: 600;
|
||||||
|
--z-modal: 5000;
|
||||||
|
--z-overflow: 10000;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* --------------------------------------------------------------------------
|
||||||
|
Modals (shared by Modal.tsx -- TemplateModal, HeadCodeModal, SitesmithModal)
|
||||||
|
-------------------------------------------------------------------------- */
|
||||||
|
.modal-backdrop {
|
||||||
|
z-index: var(--z-modal);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
@@ -136,7 +162,7 @@ body {
|
|||||||
color: var(--color-text);
|
color: var(--color-text);
|
||||||
background: transparent;
|
background: transparent;
|
||||||
border: 1px solid var(--color-border);
|
border: 1px solid var(--color-border);
|
||||||
border-radius: 20px;
|
border-radius: var(--radius-md);
|
||||||
cursor: pointer;
|
cursor: pointer;
|
||||||
white-space: nowrap;
|
white-space: nowrap;
|
||||||
transition: background var(--transition-fast), border-color var(--transition-fast),
|
transition: background var(--transition-fast), border-color var(--transition-fast),
|
||||||
@@ -198,6 +224,19 @@ body {
|
|||||||
margin: 0 4px;
|
margin: 0 4px;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Icon-only topbar buttons (Show Guides, Code, Preview) -- square-ish
|
||||||
|
footprint instead of the label+icon pill, tooltip via [data-tooltip]. */
|
||||||
|
.topbar-btn.icon-only {
|
||||||
|
gap: 0;
|
||||||
|
padding: 6px 8px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-btn.guides-toggle.active {
|
||||||
|
color: var(--color-accent);
|
||||||
|
background: var(--color-accent-subtle);
|
||||||
|
border-color: var(--color-accent);
|
||||||
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
Device Switcher
|
Device Switcher
|
||||||
-------------------------------------------------------------------------- */
|
-------------------------------------------------------------------------- */
|
||||||
@@ -704,7 +743,7 @@ body {
|
|||||||
}
|
}
|
||||||
|
|
||||||
.block-item-icon {
|
.block-item-icon {
|
||||||
font-size: 18px;
|
font-size: 20px;
|
||||||
color: var(--color-text-muted);
|
color: var(--color-text-muted);
|
||||||
transition: color var(--transition-fast);
|
transition: color var(--transition-fast);
|
||||||
}
|
}
|
||||||
@@ -714,7 +753,7 @@ body {
|
|||||||
}
|
}
|
||||||
|
|
||||||
.block-item-label {
|
.block-item-label {
|
||||||
font-size: 10px;
|
font-size: 11px;
|
||||||
font-weight: 500;
|
font-weight: 500;
|
||||||
color: var(--color-text-muted);
|
color: var(--color-text-muted);
|
||||||
text-align: center;
|
text-align: center;
|
||||||
@@ -1002,63 +1041,80 @@ body {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
Editor Visual Guides — dashed outlines for containers/columns/sections
|
Editor Visual Guides — dashed outlines for real drop targets only
|
||||||
-------------------------------------------------------------------------- */
|
-------------------------------------------------------------------------- */
|
||||||
|
|
||||||
/* All block-level elements in the canvas get a subtle dashed border */
|
/* Only actual Craft.js droppable containers get a guide outline -- these are
|
||||||
.canvas-device-frame div,
|
tagged with `data-craft-node` in RenderNode.tsx (the `<Editor onRender>`
|
||||||
.canvas-device-frame section,
|
override) based on `node.data.isCanvas`, not a blanket tag selector. A
|
||||||
.canvas-device-frame header,
|
component's own internal wrapper `<div>`s (e.g. Section's inner max-width
|
||||||
.canvas-device-frame footer,
|
container) are real DOM elements but not Craft nodes, so they never get
|
||||||
.canvas-device-frame main,
|
this attribute and never get a guide outline -- this is what stops
|
||||||
.canvas-device-frame article,
|
finished sections from showing 3-4 nested dashed boxes. */
|
||||||
.canvas-device-frame nav,
|
.canvas-device-frame [data-craft-node] {
|
||||||
.canvas-device-frame form {
|
|
||||||
outline: 1px dashed rgba(148, 163, 184, 0.2);
|
outline: 1px dashed rgba(148, 163, 184, 0.2);
|
||||||
outline-offset: -1px;
|
outline-offset: -1px;
|
||||||
transition: outline-color 0.15s;
|
transition: outline-color 0.15s;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Don't outline the outermost root wrapper or tiny utility divs */
|
|
||||||
.canvas-device-frame > div {
|
|
||||||
outline: none;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Rows (flex containers) get a slightly more visible border */
|
/* Rows (flex containers) get a slightly more visible border */
|
||||||
.canvas-device-frame div[style*="display: flex"],
|
.canvas-device-frame [data-craft-node][style*="display: flex"],
|
||||||
.canvas-device-frame div[style*="display:flex"] {
|
.canvas-device-frame [data-craft-node][style*="display:flex"] {
|
||||||
outline: 1px dashed rgba(148, 163, 184, 0.35);
|
outline: 1px dashed rgba(148, 163, 184, 0.35);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Empty containers: more visible + minimum height so they're clickable */
|
/* Empty containers: more visible + minimum height so they're clickable */
|
||||||
.canvas-device-frame div:empty,
|
.canvas-device-frame [data-craft-node]:empty {
|
||||||
.canvas-device-frame section:empty,
|
|
||||||
.canvas-device-frame main:empty,
|
|
||||||
.canvas-device-frame header:empty,
|
|
||||||
.canvas-device-frame footer:empty {
|
|
||||||
outline: 2px dashed rgba(148, 163, 184, 0.4);
|
outline: 2px dashed rgba(148, 163, 184, 0.4);
|
||||||
min-height: 60px;
|
min-height: 60px;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Hover highlights */
|
/* Hover highlights */
|
||||||
.canvas-device-frame div:hover,
|
.canvas-device-frame [data-craft-node]:hover {
|
||||||
.canvas-device-frame section:hover,
|
|
||||||
.canvas-device-frame header:hover,
|
|
||||||
.canvas-device-frame footer:hover,
|
|
||||||
.canvas-device-frame main:hover,
|
|
||||||
.canvas-device-frame nav:hover {
|
|
||||||
outline-color: rgba(59, 130, 246, 0.5);
|
outline-color: rgba(59, 130, 246, 0.5);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Header/footer zones get a distinct amber color */
|
/* `data-craft-hovered` is set (presence, no value) in RenderNode.tsx,
|
||||||
.canvas-device-frame [data-zone="header"],
|
mirroring Craft's own `hovered` node event. Craft.js's `connectors.connect()`
|
||||||
.canvas-device-frame [data-zone="footer"] {
|
(called by every component) wires that event to a native
|
||||||
outline: 1px dashed rgba(245, 158, 11, 0.4);
|
mouseover/mouseleave listener on each node's dom internally, so this
|
||||||
|
rule is a real mouse-hover highlight for any node (container or leaf).
|
||||||
|
Scoped under `.canvas-device-frame` and suppressed by `.guides-off` so
|
||||||
|
"Show guides: off" stays airtight. */
|
||||||
|
.canvas-device-frame [data-craft-hovered] {
|
||||||
|
outline: 2px dashed var(--color-accent) !important;
|
||||||
|
outline-offset: -1px;
|
||||||
}
|
}
|
||||||
|
|
||||||
.canvas-device-frame [data-zone="header"]:hover,
|
/* `data-layer-hovered` is set directly by the Layers panel (LayersPanel.tsx)
|
||||||
.canvas-device-frame [data-zone="footer"]:hover {
|
on its own row hover/focus -- a separate producer (writing straight to the
|
||||||
outline-color: rgba(245, 158, 11, 0.7);
|
target's dom rather than through Craft's `hovered` event, since the
|
||||||
|
action that drives it is stripped from the public `useEditor()` API at
|
||||||
|
runtime) that drives a highlight when hovering a layer row. This is a
|
||||||
|
deliberate locator action (not a structural drop-target guide), so it
|
||||||
|
uses a SOLID outline -- visually distinct from the dashed structural
|
||||||
|
guides -- and is intentionally NOT suppressed by `.guides-off`: hiding
|
||||||
|
guides shouldn't blind the Layers-panel hover→canvas locator. */
|
||||||
|
.canvas-device-frame [data-layer-hovered] {
|
||||||
|
outline: 2px solid var(--color-accent) !important;
|
||||||
|
outline-offset: -1px;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* "Show guides" topbar toggle (TopBar.tsx) -- flips this class on
|
||||||
|
.canvas-device-frame to hide structural drop-target guides and the
|
||||||
|
mouse-hover highlight at once. Default ON. `[data-layer-hovered]` is
|
||||||
|
deliberately excluded -- see rule above. */
|
||||||
|
.canvas-device-frame.guides-off [data-craft-node],
|
||||||
|
.canvas-device-frame.guides-off [data-craft-hovered] {
|
||||||
|
outline: none !important;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Header/footer zone-preview separator (Canvas.tsx ZonePreview) -- a neutral
|
||||||
|
dashed rule marking where the editable page meets the read-only
|
||||||
|
header/footer preview. It's a structural guide, so it hides with the
|
||||||
|
rest when "Show guides" is off. */
|
||||||
|
.canvas-device-frame.guides-off .zone-preview-sep {
|
||||||
|
border-color: transparent !important;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
@@ -1069,17 +1125,16 @@ body {
|
|||||||
outline-offset: -1px;
|
outline-offset: -1px;
|
||||||
}
|
}
|
||||||
|
|
||||||
.craftjs-renderer [data-hovered="true"] {
|
/* Component indicator badge (floats over the selected node via a portal --
|
||||||
outline: 1px dashed var(--color-accent) !important;
|
position/top/left are set inline per-node, see RenderNode.tsx) */
|
||||||
outline-offset: -1px;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Component indicator badge */
|
|
||||||
.component-indicator {
|
.component-indicator {
|
||||||
position: absolute;
|
position: absolute;
|
||||||
top: -22px;
|
top: -22px;
|
||||||
left: 0;
|
left: 0;
|
||||||
padding: 2px 8px;
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 6px;
|
||||||
|
padding: 2px 6px 2px 8px;
|
||||||
font-size: 10px;
|
font-size: 10px;
|
||||||
font-weight: 600;
|
font-weight: 600;
|
||||||
color: #ffffff;
|
color: #ffffff;
|
||||||
@@ -1090,6 +1145,28 @@ body {
|
|||||||
z-index: 10;
|
z-index: 10;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.component-indicator-parent-btn {
|
||||||
|
display: inline-flex;
|
||||||
|
align-items: center;
|
||||||
|
justify-content: center;
|
||||||
|
width: 14px;
|
||||||
|
height: 14px;
|
||||||
|
padding: 0;
|
||||||
|
border: none;
|
||||||
|
border-radius: 2px;
|
||||||
|
background: rgba(255, 255, 255, 0.2);
|
||||||
|
color: #ffffff;
|
||||||
|
font-size: 8px;
|
||||||
|
line-height: 1;
|
||||||
|
cursor: pointer;
|
||||||
|
pointer-events: auto;
|
||||||
|
transition: background var(--transition-fast);
|
||||||
|
}
|
||||||
|
|
||||||
|
.component-indicator-parent-btn:hover {
|
||||||
|
background: rgba(255, 255, 255, 0.4);
|
||||||
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
Scrollbar Styling
|
Scrollbar Styling
|
||||||
-------------------------------------------------------------------------- */
|
-------------------------------------------------------------------------- */
|
||||||
@@ -1127,6 +1204,21 @@ body {
|
|||||||
scrollbar-color: var(--color-border) transparent;
|
scrollbar-color: var(--color-border) transparent;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* --------------------------------------------------------------------------
|
||||||
|
Pages Panel — Header/Footer zone rows (Item 11)
|
||||||
|
Compact rows in the same neutral surface language as the page list, with
|
||||||
|
a pencil hint that only appears on hover instead of a permanently-loud
|
||||||
|
"Editing" pill.
|
||||||
|
-------------------------------------------------------------------------- */
|
||||||
|
.zone-row-pencil {
|
||||||
|
opacity: 0;
|
||||||
|
transition: opacity var(--transition-fast);
|
||||||
|
}
|
||||||
|
|
||||||
|
.zone-row:hover .zone-row-pencil {
|
||||||
|
opacity: 1;
|
||||||
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
Tooltip
|
Tooltip
|
||||||
-------------------------------------------------------------------------- */
|
-------------------------------------------------------------------------- */
|
||||||
@@ -1157,6 +1249,16 @@ body {
|
|||||||
opacity: 1;
|
opacity: 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Topbar sits flush against the top of the viewport (`body { overflow:
|
||||||
|
hidden }`), so the default "tooltip above the trigger" placement gets
|
||||||
|
clipped off-screen for topbar buttons -- flip those to render below
|
||||||
|
instead. Left-panel/canvas tooltips keep the default above placement,
|
||||||
|
which has room to render there. */
|
||||||
|
.topbar [data-tooltip]::after {
|
||||||
|
bottom: auto;
|
||||||
|
top: calc(100% + 6px);
|
||||||
|
}
|
||||||
|
|
||||||
/* --------------------------------------------------------------------------
|
/* --------------------------------------------------------------------------
|
||||||
Notifications / Toasts
|
Notifications / Toasts
|
||||||
-------------------------------------------------------------------------- */
|
-------------------------------------------------------------------------- */
|
||||||
@@ -1225,6 +1327,8 @@ body {
|
|||||||
Empty Canvas State
|
Empty Canvas State
|
||||||
-------------------------------------------------------------------------- */
|
-------------------------------------------------------------------------- */
|
||||||
.empty-canvas-hint {
|
.empty-canvas-hint {
|
||||||
|
position: absolute;
|
||||||
|
inset: 0;
|
||||||
display: flex;
|
display: flex;
|
||||||
flex-direction: column;
|
flex-direction: column;
|
||||||
align-items: center;
|
align-items: center;
|
||||||
@@ -1234,6 +1338,9 @@ body {
|
|||||||
font-size: 13px;
|
font-size: 13px;
|
||||||
text-align: center;
|
text-align: center;
|
||||||
gap: 12px;
|
gap: 12px;
|
||||||
|
/* Overlays the drop area without intercepting drags/clicks meant for the
|
||||||
|
underlying (empty) canvas root -- see Canvas.tsx. */
|
||||||
|
pointer-events: none;
|
||||||
}
|
}
|
||||||
|
|
||||||
.empty-canvas-hint i {
|
.empty-canvas-hint i {
|
||||||
@@ -1296,13 +1403,484 @@ body {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@media (max-width: 768px) {
|
@media (max-width: 768px) {
|
||||||
|
/* ------------------------------------------------------------------------
|
||||||
|
Phase A -- Mobile Editor Chrome
|
||||||
|
Gated entirely behind this breakpoint; desktop styles above are
|
||||||
|
untouched. See useIsMobile() (same 768px breakpoint) for the React-side
|
||||||
|
equivalent that swaps LeftPanel/RightPanel for MobilePanelBar, and
|
||||||
|
collapses TopBar.
|
||||||
|
------------------------------------------------------------------------ */
|
||||||
|
|
||||||
|
/* Side panels are not rendered on mobile (EditorShell swaps them for the
|
||||||
|
bottom tab bar) -- kept as a defensive fallback in case either is ever
|
||||||
|
mounted at this width. */
|
||||||
.panel-left,
|
.panel-left,
|
||||||
.panel-right {
|
.panel-right {
|
||||||
display: none;
|
display: none;
|
||||||
}
|
}
|
||||||
|
|
||||||
.topbar-btn span,
|
/* --------------------------------------------------------------------
|
||||||
.topbar-domain {
|
Viewport sizing -- dynamic viewport height accounts for mobile
|
||||||
display: none;
|
browsers' collapsing URL bar; the unconditional 100vh set earlier in
|
||||||
|
this file is the fallback for browsers without dvh support.
|
||||||
|
-------------------------------------------------------------------- */
|
||||||
|
.editor-app {
|
||||||
|
height: 100vh;
|
||||||
|
height: 100dvh;
|
||||||
|
padding-top: env(safe-area-inset-top, 0px);
|
||||||
|
padding-left: env(safe-area-inset-left, 0px);
|
||||||
|
padding-right: env(safe-area-inset-right, 0px);
|
||||||
|
}
|
||||||
|
|
||||||
|
.editor-container {
|
||||||
|
height: calc(100vh - var(--topbar-height) - var(--mobile-tabbar-height) - env(safe-area-inset-bottom, 0px));
|
||||||
|
height: calc(100dvh - var(--topbar-height) - var(--mobile-tabbar-height) - env(safe-area-inset-bottom, 0px));
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Full-width canvas, safe-area-aware bottom padding so content never
|
||||||
|
sits flush against the fixed bottom tab bar. */
|
||||||
|
.editor-canvas {
|
||||||
|
padding: 12px;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* --------------------------------------------------------------------
|
||||||
|
Topbar collapse (TopBar.tsx renders a distinct `.topbar-mobile` markup
|
||||||
|
branch -- this is purely the styling for it)
|
||||||
|
-------------------------------------------------------------------- */
|
||||||
|
.topbar-mobile {
|
||||||
|
padding: 0 8px;
|
||||||
|
padding-left: calc(8px + env(safe-area-inset-left, 0px));
|
||||||
|
padding-right: calc(8px + env(safe-area-inset-right, 0px));
|
||||||
|
gap: 4px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-mobile .topbar-left {
|
||||||
|
flex: 0 0 auto;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-mobile .topbar-right {
|
||||||
|
flex: 1;
|
||||||
|
justify-content: flex-end;
|
||||||
|
gap: 4px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-mobile .topbar-btn.icon-only {
|
||||||
|
width: 44px;
|
||||||
|
height: 44px;
|
||||||
|
padding: 0;
|
||||||
|
justify-content: center;
|
||||||
|
touch-action: manipulation;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-mobile .topbar-divider {
|
||||||
|
margin: 0 2px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-btn.overflow-toggle.active {
|
||||||
|
color: var(--color-accent);
|
||||||
|
background: var(--color-accent-subtle);
|
||||||
|
border-color: var(--color-accent);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* --------------------------------------------------------------------
|
||||||
|
Full-screen modals (Modal.tsx -- TemplateModal/HeadCodeModal/
|
||||||
|
SitesmithModal share `.modal-backdrop`). Same tab-bar cutout as
|
||||||
|
`.mobile-sheet-backdrop` below, and for the same reason: without it,
|
||||||
|
the backdrop's default `inset: 0` sits ABOVE the tab bar (--z-modal >
|
||||||
|
--z-tabbar) and swallows every tap there, so "open Templates -> tap a
|
||||||
|
bottom tab" would silently just close Templates (a tap on the
|
||||||
|
backdrop) instead of ALSO opening the tapped sheet. `!important`
|
||||||
|
because Modal.tsx sets `bottom` via an inline style, which otherwise
|
||||||
|
beats this class rule. The modal's own content still sits above the
|
||||||
|
tab bar (it's a commit/cancel moment) -- only the dismiss-affordance
|
||||||
|
backdrop stops short, exactly like the sheet backdrop.
|
||||||
|
-------------------------------------------------------------------- */
|
||||||
|
.modal-backdrop {
|
||||||
|
bottom: calc(var(--mobile-tabbar-height) + env(safe-area-inset-bottom, 0px)) !important;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* --------------------------------------------------------------------
|
||||||
|
"⋯" overflow menu (TopBarOverflowMenu.tsx)
|
||||||
|
-------------------------------------------------------------------- */
|
||||||
|
.topbar-overflow-menu {
|
||||||
|
position: fixed;
|
||||||
|
top: calc(var(--topbar-height) + env(safe-area-inset-top, 0px) + 6px);
|
||||||
|
right: calc(8px + env(safe-area-inset-right, 0px));
|
||||||
|
z-index: var(--z-overflow);
|
||||||
|
min-width: 220px;
|
||||||
|
max-width: calc(100vw - 16px);
|
||||||
|
max-height: calc(100dvh - var(--topbar-height) - 24px);
|
||||||
|
overflow-y: auto;
|
||||||
|
background: var(--color-bg-elevated);
|
||||||
|
border: 1px solid var(--color-border);
|
||||||
|
border-radius: var(--radius-lg);
|
||||||
|
box-shadow: 0 8px 28px rgba(0, 0, 0, 0.5);
|
||||||
|
padding: 8px;
|
||||||
|
display: flex;
|
||||||
|
flex-direction: column;
|
||||||
|
gap: 4px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-overflow-section {
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
justify-content: space-between;
|
||||||
|
gap: 10px;
|
||||||
|
padding: 6px 8px 10px;
|
||||||
|
border-bottom: 1px solid var(--color-border);
|
||||||
|
margin-bottom: 4px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-overflow-label {
|
||||||
|
font-size: 12px;
|
||||||
|
color: var(--color-text-muted);
|
||||||
|
white-space: nowrap;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-overflow-section .device-switcher {
|
||||||
|
height: 44px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-overflow-section .device-btn {
|
||||||
|
width: 44px;
|
||||||
|
height: 42px;
|
||||||
|
touch-action: manipulation;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-overflow-item {
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 10px;
|
||||||
|
width: 100%;
|
||||||
|
min-height: 44px;
|
||||||
|
padding: 8px 10px;
|
||||||
|
font-size: 13px;
|
||||||
|
font-weight: 500;
|
||||||
|
color: var(--color-text);
|
||||||
|
background: transparent;
|
||||||
|
border: none;
|
||||||
|
border-radius: var(--radius-md);
|
||||||
|
cursor: pointer;
|
||||||
|
text-align: left;
|
||||||
|
touch-action: manipulation;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-overflow-item:hover,
|
||||||
|
.topbar-overflow-item:active {
|
||||||
|
background: var(--color-bg-hover);
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-overflow-item.active {
|
||||||
|
color: var(--color-accent);
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-overflow-sitesmith {
|
||||||
|
padding: 6px 4px 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
.topbar-overflow-sitesmith .sitesmith-btn {
|
||||||
|
width: 100%;
|
||||||
|
justify-content: center;
|
||||||
|
min-height: 44px;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* --------------------------------------------------------------------
|
||||||
|
Bottom tab bar (MobilePanelBar.tsx)
|
||||||
|
-------------------------------------------------------------------- */
|
||||||
|
.mobile-tab-bar {
|
||||||
|
position: fixed;
|
||||||
|
left: 0;
|
||||||
|
right: 0;
|
||||||
|
bottom: 0;
|
||||||
|
/* Above .mobile-sheet-backdrop (400) -- the tab bar must stay clickable
|
||||||
|
even while a sheet is open so tapping a different tab swaps sheets
|
||||||
|
directly, instead of requiring a close-then-reopen round trip. The
|
||||||
|
backdrop itself stops short of the tab bar (see its `bottom` offset
|
||||||
|
below) so this is mostly belt-and-suspenders for the boundary. */
|
||||||
|
z-index: var(--z-tabbar);
|
||||||
|
display: flex;
|
||||||
|
height: calc(var(--mobile-tabbar-height) + env(safe-area-inset-bottom, 0px));
|
||||||
|
background: var(--color-bg-surface);
|
||||||
|
border-top: 1px solid var(--color-border);
|
||||||
|
padding-bottom: env(safe-area-inset-bottom, 0px);
|
||||||
|
padding-left: env(safe-area-inset-left, 0px);
|
||||||
|
padding-right: env(safe-area-inset-right, 0px);
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-tab-btn {
|
||||||
|
flex: 1;
|
||||||
|
display: flex;
|
||||||
|
flex-direction: column;
|
||||||
|
align-items: center;
|
||||||
|
justify-content: center;
|
||||||
|
gap: 3px;
|
||||||
|
min-height: 44px;
|
||||||
|
font-size: 10px;
|
||||||
|
font-weight: 600;
|
||||||
|
color: var(--color-text-muted);
|
||||||
|
background: transparent;
|
||||||
|
border: none;
|
||||||
|
touch-action: manipulation;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-tab-btn i {
|
||||||
|
font-size: 17px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-tab-btn.active {
|
||||||
|
color: var(--color-accent);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* --------------------------------------------------------------------
|
||||||
|
Mobile selection toolbar (MobileSelectionToolbar.tsx, Phase B item 2)
|
||||||
|
Bottom-fixed just above the tab bar -- simplest, robust positioning
|
||||||
|
that never has to track a scrolling/resizing node's DOM rect. Sits at
|
||||||
|
--z-selection-toolbar (600), above the tab bar (500) and sheet backdrop
|
||||||
|
(400) so it's never occluded by either, but well below --z-modal
|
||||||
|
(5000). Hidden entirely (component returns null) whenever a sheet is
|
||||||
|
open, so it never has to fight the sheet for the same screen space.
|
||||||
|
-------------------------------------------------------------------- */
|
||||||
|
.mobile-selection-toolbar {
|
||||||
|
position: fixed;
|
||||||
|
left: 0;
|
||||||
|
right: 0;
|
||||||
|
bottom: calc(var(--mobile-tabbar-height) + env(safe-area-inset-bottom, 0px));
|
||||||
|
z-index: var(--z-selection-toolbar);
|
||||||
|
display: flex;
|
||||||
|
background: var(--color-bg-elevated);
|
||||||
|
border-top: 1px solid var(--color-border);
|
||||||
|
box-shadow: 0 -4px 16px rgba(0, 0, 0, 0.35);
|
||||||
|
padding: 4px calc(2px + env(safe-area-inset-right, 0px)) 4px calc(2px + env(safe-area-inset-left, 0px));
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-selection-toolbar-btn {
|
||||||
|
flex: 1;
|
||||||
|
display: flex;
|
||||||
|
flex-direction: column;
|
||||||
|
align-items: center;
|
||||||
|
justify-content: center;
|
||||||
|
gap: 2px;
|
||||||
|
min-height: 44px;
|
||||||
|
padding: 4px 2px;
|
||||||
|
font-size: 9px;
|
||||||
|
font-weight: 600;
|
||||||
|
line-height: 1;
|
||||||
|
color: var(--color-text);
|
||||||
|
background: transparent;
|
||||||
|
border: none;
|
||||||
|
border-radius: var(--radius-md);
|
||||||
|
cursor: pointer;
|
||||||
|
touch-action: manipulation;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-selection-toolbar-btn i {
|
||||||
|
font-size: 15px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-selection-toolbar-btn:disabled {
|
||||||
|
color: var(--color-text-dim);
|
||||||
|
opacity: 0.4;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-selection-toolbar-btn.danger {
|
||||||
|
color: var(--color-danger);
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-selection-toolbar-btn.danger.confirming {
|
||||||
|
background: rgba(239, 68, 68, 0.15);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Fast-follow item 4: while the toolbar above is visible, give the canvas
|
||||||
|
scroll area enough extra bottom padding to clear it (on top of the
|
||||||
|
regular 12px `.editor-canvas` padding, not replacing it), so the last
|
||||||
|
section of a short page is still reachable by scrolling instead of
|
||||||
|
sitting permanently underneath the fixed toolbar. */
|
||||||
|
.editor-canvas.has-mobile-selection-toolbar {
|
||||||
|
padding-bottom: calc(12px + var(--mobile-selection-toolbar-height));
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Fast-follow item 3: while the Styles sheet is open with a node selected,
|
||||||
|
`MobileSelectionToolbar`'s scroll-into-view effect needs somewhere to
|
||||||
|
scroll THE NODE TO even when it's the last thing on the page -- without
|
||||||
|
extra room below it, the canvas is already at its max scrollTop and the
|
||||||
|
node's top can't be brought up past wherever it naturally landed
|
||||||
|
(verified live: the last section stayed stuck under the sheet). A full
|
||||||
|
extra viewport's worth of bottom padding guarantees any node's top can
|
||||||
|
always reach the very top of the canvas. Temporary/cosmetic cost (a
|
||||||
|
stretch of blank canvas below the real content while this is active) is
|
||||||
|
an acceptable trade for the node never being permanently unreachable.
|
||||||
|
-------------------------------------------------------------------- */
|
||||||
|
.editor-canvas.has-mobile-styles-sheet {
|
||||||
|
padding-bottom: 100vh;
|
||||||
|
padding-bottom: 100dvh;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* --------------------------------------------------------------------
|
||||||
|
Bottom sheet (BottomSheet.tsx)
|
||||||
|
-------------------------------------------------------------------- */
|
||||||
|
.mobile-sheet-backdrop {
|
||||||
|
position: fixed;
|
||||||
|
top: 0;
|
||||||
|
left: 0;
|
||||||
|
right: 0;
|
||||||
|
/* Stop above the bottom tab bar (rather than a full-viewport `inset: 0`)
|
||||||
|
so the tab bar is never covered/blocked by the backdrop -- tapping a
|
||||||
|
different tab while a sheet is open swaps sheets directly instead of
|
||||||
|
being swallowed by the overlay sitting on top of it.
|
||||||
|
`--keyboard-inset` (item 5, Phase B) is set inline by BottomSheet.tsx
|
||||||
|
from `useVisualViewportInsets` -- 0px when no on-screen keyboard is
|
||||||
|
open (the default below is the no-JS/unsupported-browser fallback),
|
||||||
|
otherwise the keyboard's height, so the whole sheet lifts clear of it
|
||||||
|
instead of the keyboard covering its lower portion. */
|
||||||
|
bottom: calc(var(--mobile-tabbar-height) + env(safe-area-inset-bottom, 0px) + var(--keyboard-inset, 0px));
|
||||||
|
background: rgba(0, 0, 0, 0.5);
|
||||||
|
z-index: var(--z-sheet-backdrop);
|
||||||
|
display: flex;
|
||||||
|
align-items: flex-end;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-sheet {
|
||||||
|
width: 100%;
|
||||||
|
/* Capped a second time by the keyboard inset so the sheet's own
|
||||||
|
max-height shrinks along with the lifted backdrop -- without this the
|
||||||
|
sheet could still try to be 65dvh tall from its new (higher) bottom
|
||||||
|
edge and overflow off the top of the screen. */
|
||||||
|
max-height: calc(65vh - var(--keyboard-inset, 0px));
|
||||||
|
max-height: calc(65dvh - var(--keyboard-inset, 0px));
|
||||||
|
background: var(--color-bg-surface);
|
||||||
|
border-top-left-radius: 16px;
|
||||||
|
border-top-right-radius: 16px;
|
||||||
|
border: 1px solid var(--color-border);
|
||||||
|
border-bottom: none;
|
||||||
|
display: flex;
|
||||||
|
flex-direction: column;
|
||||||
|
overflow: hidden;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-sheet-handle-row {
|
||||||
|
display: flex;
|
||||||
|
justify-content: center;
|
||||||
|
padding: 8px 0 4px;
|
||||||
|
flex-shrink: 0;
|
||||||
|
/* Swipe-to-dismiss (item 4, Phase B) tracks its own touchmove here --
|
||||||
|
`none` stops the browser's native scroll/rubber-band gesture from
|
||||||
|
competing with it. */
|
||||||
|
touch-action: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-sheet-handle {
|
||||||
|
width: 36px;
|
||||||
|
height: 4px;
|
||||||
|
border-radius: 2px;
|
||||||
|
background: var(--color-border-light);
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-sheet-header {
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
justify-content: space-between;
|
||||||
|
padding: 4px 12px 10px 16px;
|
||||||
|
border-bottom: 1px solid var(--color-border);
|
||||||
|
flex-shrink: 0;
|
||||||
|
/* Swipe-to-dismiss (item 4, Phase B) -- see .mobile-sheet-handle-row. */
|
||||||
|
touch-action: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-sheet-title {
|
||||||
|
font-size: 14px;
|
||||||
|
font-weight: 600;
|
||||||
|
color: var(--color-text);
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-sheet-close {
|
||||||
|
width: 44px;
|
||||||
|
height: 44px;
|
||||||
|
display: inline-flex;
|
||||||
|
align-items: center;
|
||||||
|
justify-content: center;
|
||||||
|
font-size: 16px;
|
||||||
|
color: var(--color-text-muted);
|
||||||
|
background: transparent;
|
||||||
|
border: none;
|
||||||
|
border-radius: var(--radius-md);
|
||||||
|
cursor: pointer;
|
||||||
|
touch-action: manipulation;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-sheet-body {
|
||||||
|
flex: 1;
|
||||||
|
overflow-y: auto;
|
||||||
|
-webkit-overflow-scrolling: touch;
|
||||||
|
padding: 12px 16px;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* --------------------------------------------------------------------
|
||||||
|
Touch ergonomics inside sheets -- 16px inputs kill iOS's auto-zoom on
|
||||||
|
focus; touch-action speeds up tap response on chrome that doesn't need
|
||||||
|
native scroll-gesture handling.
|
||||||
|
|
||||||
|
`!important` is required here: GuidedStyles/StylePanel inputs (see
|
||||||
|
`inputStyle` in `panels/right/styles/shared.tsx`) carry an INLINE
|
||||||
|
`font-size: 12px`, which otherwise beats this class rule on the
|
||||||
|
Styles sheet -- the most-used mobile surface -- and iOS zooms in on
|
||||||
|
focus. `.sitesmith-textarea` (ChatInput.tsx, inline font-size: 14)
|
||||||
|
has the same problem even though the Sitesmith modal isn't a sheet.
|
||||||
|
-------------------------------------------------------------------- */
|
||||||
|
.mobile-sheet-body button,
|
||||||
|
.mobile-sheet-body .block-item {
|
||||||
|
touch-action: manipulation;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-sheet-body input,
|
||||||
|
.mobile-sheet-body select,
|
||||||
|
.mobile-sheet-body textarea,
|
||||||
|
.guided-input,
|
||||||
|
.control-input,
|
||||||
|
.control-select,
|
||||||
|
.topbar input,
|
||||||
|
.topbar textarea,
|
||||||
|
.topbar select,
|
||||||
|
.sitesmith-textarea {
|
||||||
|
font-size: 16px !important;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-sheet-body .settings-tabs button {
|
||||||
|
min-height: 44px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mobile-sheet-body .color-preset {
|
||||||
|
width: 40px;
|
||||||
|
height: 40px;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Layers panel rows (item 4) -- the reliable fallback selection path when
|
||||||
|
a node is hard to hit precisely on the canvas by touch. Bumped to the
|
||||||
|
44px touch-target minimum; tapping a row already selects (LayerNode's
|
||||||
|
`handleActivate`), unchanged. */
|
||||||
|
.mobile-sheet-body .layer-node-row {
|
||||||
|
min-height: 44px;
|
||||||
|
touch-action: manipulation;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* --------------------------------------------------------------------
|
||||||
|
Templates modal: category tabs stay horizontally scrollable and never
|
||||||
|
shrink below a comfortable touch target; close button enlarged to the
|
||||||
|
44px minimum (overriding its 32px inline style).
|
||||||
|
-------------------------------------------------------------------- */
|
||||||
|
.template-modal-tabbar {
|
||||||
|
gap: 8px;
|
||||||
|
-webkit-overflow-scrolling: touch;
|
||||||
|
}
|
||||||
|
|
||||||
|
.template-modal-tab-btn {
|
||||||
|
flex-shrink: 0;
|
||||||
|
min-height: 44px;
|
||||||
|
padding: 8px 16px !important;
|
||||||
|
touch-action: manipulation;
|
||||||
|
}
|
||||||
|
|
||||||
|
.template-modal-close-btn {
|
||||||
|
width: 44px !important;
|
||||||
|
height: 44px !important;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,51 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import { templateComponentToTreeNode } from './apply-template';
|
||||||
|
|
||||||
|
describe('templateComponentToTreeNode', () => {
|
||||||
|
test('converts a childless TemplateComponent to a SerializedTreeNode with an empty `nodes` array', () => {
|
||||||
|
const node = templateComponentToTreeNode({ type: 'Heading', props: { text: 'Hi' } });
|
||||||
|
expect(node).toEqual({
|
||||||
|
type: { resolvedName: 'Heading' },
|
||||||
|
props: { text: 'Hi' },
|
||||||
|
nodes: [],
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test('regression: recursively converts nested `children` into `nodes` (previously dropped entirely)', () => {
|
||||||
|
const node = templateComponentToTreeNode({
|
||||||
|
type: 'Container',
|
||||||
|
props: { tag: 'header' },
|
||||||
|
children: [
|
||||||
|
{ type: 'Logo', props: { text: 'FlowStack' } },
|
||||||
|
{ type: 'Menu', props: { links: [] } },
|
||||||
|
],
|
||||||
|
});
|
||||||
|
expect(node.nodes).toHaveLength(2);
|
||||||
|
expect(node.nodes![0]).toEqual({ type: { resolvedName: 'Logo' }, props: { text: 'FlowStack' }, nodes: [] });
|
||||||
|
expect(node.nodes![1]).toEqual({ type: { resolvedName: 'Menu' }, props: { links: [] }, nodes: [] });
|
||||||
|
});
|
||||||
|
|
||||||
|
test('recurses more than one level deep', () => {
|
||||||
|
const node = templateComponentToTreeNode({
|
||||||
|
type: 'Section',
|
||||||
|
props: {},
|
||||||
|
children: [
|
||||||
|
{
|
||||||
|
type: 'ColumnLayout',
|
||||||
|
props: { columns: 1 },
|
||||||
|
children: [{ type: 'TextBlock', props: { text: 'deep' } }],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
});
|
||||||
|
const col = node.nodes![0];
|
||||||
|
expect(col.type.resolvedName).toBe('ColumnLayout');
|
||||||
|
expect(col.nodes![0]).toEqual({ type: { resolvedName: 'TextBlock' }, props: { text: 'deep' }, nodes: [] });
|
||||||
|
});
|
||||||
|
|
||||||
|
test('does not mutate the input TemplateComponent', () => {
|
||||||
|
const comp = { type: 'Heading', props: { text: 'Hi' } };
|
||||||
|
const frozen = JSON.parse(JSON.stringify(comp));
|
||||||
|
templateComponentToTreeNode(comp);
|
||||||
|
expect(comp).toEqual(frozen);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,49 @@
|
|||||||
|
import type { SerializedTreeNode } from '../types/sitesmith';
|
||||||
|
import { TemplateComponent } from './definitions';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Converts a template's `TemplateComponent` tree (the plain
|
||||||
|
* `{ type, props, children? }` shape authored in `templates/definitions.ts`)
|
||||||
|
* into a `SerializedTreeNode` (the shape `craft-tree.ts`'s `buildNodeTree` /
|
||||||
|
* `sanitizeAiTree` / `flattenTreeForCraft` pipeline already knows how to
|
||||||
|
* materialize into a real Craft.js `NodeTree`).
|
||||||
|
*
|
||||||
|
* Bug this fixes: `TemplateModal`'s `addTemplateComponents` used to call
|
||||||
|
* `React.createElement(Component, comp.props)` with no children argument,
|
||||||
|
* which silently dropped every nested `children` array authored in
|
||||||
|
* definitions.ts -- e.g. `makeHeader()`'s `Container > Logo + Menu`,
|
||||||
|
* `makeFooterContent()`'s `Container > TextBlock...`, or a page `Section`
|
||||||
|
* wrapping a `Heading`/`TextBlock`/`ButtonLink`. The resulting Craft.js node
|
||||||
|
* ended up with `nodes: []`, so the header/footer zone preview
|
||||||
|
* (`ZonePreview` in `editor/Canvas.tsx`, via `exportBodyHtml`) -- and the
|
||||||
|
* same-path published HTML (`handlePublish` composes header/footer HTML
|
||||||
|
* from the same serialized state) -- rendered as an empty strip instead of
|
||||||
|
* the real nav/footer/section content.
|
||||||
|
*
|
||||||
|
* A follow-up attempt fixed that by building a real nested React element
|
||||||
|
* tree (`React.createElement(Component, props, ...children)`) and handing
|
||||||
|
* it to `query.parseReactElement(...).toNodeTree()`. That approach breaks
|
||||||
|
* for any component with an internal SHELL_INNER-style linked canvas
|
||||||
|
* (`Section`, `BackgroundSection`, `FormContainer` -- see `SHELL_INNER` in
|
||||||
|
* `craft-tree.ts`) or linked columns (`ColumnLayout`): `parseReactElement`
|
||||||
|
* statically walks the JSX tree and has no way to know that e.g. `Section`
|
||||||
|
* routes its `children` into a nested `<Element id="section-inner" canvas>`
|
||||||
|
* at render time, not directly under itself. Feeding it raw nested children
|
||||||
|
* produces a tree where Craft.js has to auto-materialize that linked node on
|
||||||
|
* first render -- which stores the wrong `type` and crashes with "component
|
||||||
|
* type (undefined) does not exist in the resolver" the moment the section
|
||||||
|
* renders (reproduced live: loading the SaaS Landing template crashed the
|
||||||
|
* whole editor on its "Trusted by 10,000+ development teams" `Section`).
|
||||||
|
*
|
||||||
|
* Converting to `SerializedTreeNode` and reusing `buildNodeTree` sidesteps
|
||||||
|
* both bugs at once: it's the same tree-building pipeline already used (and
|
||||||
|
* tested) for AI-generated content in `apply-ai-response.ts`, which already
|
||||||
|
* knows how to route content through SHELL_INNER / linked columns correctly.
|
||||||
|
*/
|
||||||
|
export function templateComponentToTreeNode(comp: TemplateComponent): SerializedTreeNode {
|
||||||
|
return {
|
||||||
|
type: { resolvedName: comp.type },
|
||||||
|
props: { ...comp.props },
|
||||||
|
nodes: (comp.children || []).map(templateComponentToTreeNode),
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -31,7 +31,10 @@ const defaultBackdropStyle: React.CSSProperties = {
|
|||||||
display: 'flex',
|
display: 'flex',
|
||||||
alignItems: 'center',
|
alignItems: 'center',
|
||||||
justifyContent: 'center',
|
justifyContent: 'center',
|
||||||
zIndex: 10000,
|
/* z-index comes from the `.modal-backdrop` class (--z-modal in the
|
||||||
|
shared layer scale, editor.css) rather than an inline value, so every
|
||||||
|
Modal consumer -- including ones that pass a custom `backdropStyle`
|
||||||
|
without a zIndex, like SitesmithModal -- lands on the same layer. */
|
||||||
};
|
};
|
||||||
|
|
||||||
/* ---------- Shared modal chrome ----------
|
/* ---------- Shared modal chrome ----------
|
||||||
@@ -77,6 +80,7 @@ export const Modal: React.FC<ModalProps> = ({
|
|||||||
|
|
||||||
return (
|
return (
|
||||||
<div
|
<div
|
||||||
|
className="modal-backdrop"
|
||||||
{...backdropProps}
|
{...backdropProps}
|
||||||
style={backdropStyle ? { ...defaultBackdropStyle, ...backdropStyle } : defaultBackdropStyle}
|
style={backdropStyle ? { ...defaultBackdropStyle, ...backdropStyle } : defaultBackdropStyle}
|
||||||
onClick={(e) => {
|
onClick={(e) => {
|
||||||
|
|||||||
@@ -1,14 +1,14 @@
|
|||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import type { NodeTree } from '@craftjs/core';
|
|
||||||
import { usePages } from '../state/PageContext';
|
import { usePages } from '../state/PageContext';
|
||||||
import { SitesmithResponse, SerializedTreeNode, SitesmithPatchOp } from '../types/sitesmith';
|
import { SitesmithResponse, SerializedTreeNode, SitesmithPatchOp } from '../types/sitesmith';
|
||||||
import { sanitizeAiTree, flattenTreeForCraft } from './craft-tree';
|
import { sanitizeAiTree, buildNodeTree } from './craft-tree';
|
||||||
|
|
||||||
// Re-exported for existing callers/tests that import sanitizeAiTree from
|
// Re-exported for existing callers/tests that import sanitizeAiTree/
|
||||||
// this module — the implementation now lives in craft-tree.ts alongside the
|
// buildNodeTree from this module — the implementation lives in craft-tree.ts
|
||||||
// shared flattener, since treeToState (PageContext.tsx) needs the same
|
// alongside the shared flattener: `templates/apply-template.ts` needs the
|
||||||
// validation this module pioneered.
|
// exact same tree-materialization logic to load template header/footer/page
|
||||||
export { sanitizeAiTree };
|
// content (see the doc comment on `buildNodeTree` in craft-tree.ts).
|
||||||
|
export { sanitizeAiTree, buildNodeTree };
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* update_props may never touch these keys, regardless of what the AI sends.
|
* update_props may never touch these keys, regardless of what the AI sends.
|
||||||
@@ -18,52 +18,6 @@ export { sanitizeAiTree };
|
|||||||
*/
|
*/
|
||||||
const PROTECTED_UPDATE_PROPS_KEYS = new Set<string>(['node_id']);
|
const PROTECTED_UPDATE_PROPS_KEYS = new Set<string>(['node_id']);
|
||||||
|
|
||||||
/**
|
|
||||||
* Build a Craft.js `NodeTree` from a `SerializedTreeNode` using `query.parseFreshNode`.
|
|
||||||
* This is the correct way to construct a tree for `actions.addNodeTree()` when
|
|
||||||
* inserting/replacing sections or individual nodes.
|
|
||||||
*/
|
|
||||||
function buildNodeTree(query: any, tree: SerializedTreeNode): NodeTree {
|
|
||||||
// Validate + sanitize at the AI boundary before touching Craft.js at all:
|
|
||||||
// unknown resolvedNames are dropped (never reach parseFreshNode/addNodeTree,
|
|
||||||
// which would throw), and ids are repaired ('ROOT'/empty/colliding →
|
|
||||||
// regenerated) against the live document's existing node ids so a new
|
|
||||||
// AI-supplied id can never clobber or duplicate one already on the canvas.
|
|
||||||
const existingIds = new Set<string>(
|
|
||||||
typeof query?.getNodes === 'function' ? Object.keys(query.getNodes()) : [],
|
|
||||||
);
|
|
||||||
const sanitized = sanitizeAiTree(tree, existingIds);
|
|
||||||
if (!sanitized) {
|
|
||||||
throw new Error('sitesmith: AI tree root has an unknown/invalid component type; nothing to build');
|
|
||||||
}
|
|
||||||
|
|
||||||
// sanitizeAiTree() has already guaranteed every node has a valid, unique,
|
|
||||||
// non-'ROOT' node_id and a registered resolvedName — the shared flattener
|
|
||||||
// just needs to do the structural walk (linkedNodes/SHELL_INNER/style
|
|
||||||
// normalization) common to every tree-flattening caller in this codebase.
|
|
||||||
const flat = flattenTreeForCraft(sanitized);
|
|
||||||
|
|
||||||
const craftNodes: Record<string, any> = {};
|
|
||||||
for (const [id, flatNode] of Object.entries(flat.nodes)) {
|
|
||||||
if (flat.syntheticIds.has(id)) {
|
|
||||||
// The SHELL_INNER wrapper Container is synthesized by the flattener,
|
|
||||||
// not present in the AI's tree — build it directly rather than
|
|
||||||
// through query.parseFreshNode(), which would merge in Container's
|
|
||||||
// default `craft.props` (e.g. default padding) and change its look.
|
|
||||||
craftNodes[id] = {
|
|
||||||
id,
|
|
||||||
data: { ...flatNode },
|
|
||||||
events: { selected: false, hovered: false, dragged: false },
|
|
||||||
rules: { canDrag: () => true, canMoveIn: () => true, canMoveOut: () => true, canDrop: () => true },
|
|
||||||
};
|
|
||||||
} else {
|
|
||||||
craftNodes[id] = (query.parseFreshNode({ id, data: { ...flatNode } }) as any).toNode();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
return { rootNodeId: flat.rootNodeId, nodes: craftNodes };
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Find the Craft.js node id that corresponds to an AI node_id value.
|
* Find the Craft.js node id that corresponds to an AI node_id value.
|
||||||
* Checks `data.props.node_id` first, then falls back to raw id equality.
|
* Checks `data.props.node_id` first, then falls back to raw id equality.
|
||||||
|
|||||||
@@ -147,6 +147,37 @@ describe('regenerateTreeIds', () => {
|
|||||||
|
|
||||||
expect(input.nodes['root-1'].data.props).toEqual({ alignment: 'left' });
|
expect(input.nodes['root-1'].data.props).toEqual({ alignment: 'left' });
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// Regression test (found via real-browser Playwright touch verification,
|
||||||
|
// Phase B): a LIVE Craft.js node's `data.type` is the actual component
|
||||||
|
// function reference (not the `{resolvedName}` string wrapper used only
|
||||||
|
// in SERIALIZED state) -- `query.node(id).toNodeTree()` returns nodes
|
||||||
|
// shaped exactly like this. The previous implementation ran
|
||||||
|
// `structuredClone(oldNode.data)` on the WHOLE data object, which throws
|
||||||
|
// `DataCloneError` the instant `data.type` is a function, silently
|
||||||
|
// breaking Duplicate (ContextMenu.tsx / useNodeActions.ts) and Ctrl+V
|
||||||
|
// Paste (useKeyboardShortcuts.ts) for every real node in the app --
|
||||||
|
// masked by every other test in this suite using a plain string `type`
|
||||||
|
// ('div'), and by unit tests elsewhere that mock `@craftjs/core` entirely
|
||||||
|
// (so `toNodeTree()` never actually returns a function there).
|
||||||
|
test('does not throw when data.type is a live component function reference', () => {
|
||||||
|
const ButtonLikeComponent = (props: { text?: string }) => props.text;
|
||||||
|
const input = makeTree();
|
||||||
|
input.nodes['root-1'].data.type = ButtonLikeComponent as unknown as Node['data']['type'];
|
||||||
|
input.nodes['root-1'].data.props = { text: 'Click Me' };
|
||||||
|
|
||||||
|
expect(() => regenerateTreeIds(input)).not.toThrow();
|
||||||
|
|
||||||
|
const output = regenerateTreeIds(input);
|
||||||
|
const outputRoot = output.nodes[output.rootNodeId];
|
||||||
|
// The component reference itself is preserved (shared, not cloned --
|
||||||
|
// it's a stable reference, not mutable data).
|
||||||
|
expect(outputRoot.data.type).toBe(ButtonLikeComponent);
|
||||||
|
// Props are still genuinely deep-cloned (the actual bug fix's point).
|
||||||
|
expect(outputRoot.data.props).toEqual({ text: 'Click Me' });
|
||||||
|
(outputRoot.data.props as { text: string }).text = 'changed';
|
||||||
|
expect(input.nodes['root-1'].data.props).toEqual({ text: 'Click Me' });
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('flattenTreeForCraft', () => {
|
describe('flattenTreeForCraft', () => {
|
||||||
|
|||||||
@@ -225,6 +225,105 @@ export function flattenTreeForCraft(tree: SerializedTreeNode): FlattenTreeResult
|
|||||||
return { rootNodeId, nodes, syntheticIds };
|
return { rootNodeId, nodes, syntheticIds };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Build a Craft.js `NodeTree` from a `SerializedTreeNode` using
|
||||||
|
* `query.parseFreshNode`. This is the correct way to construct a tree for
|
||||||
|
* `actions.addNodeTree()` when inserting/replacing sections, individual
|
||||||
|
* nodes, or (via `templates/apply-template.ts`) a template's header/footer/
|
||||||
|
* page content -- anything whose input isn't already a live Craft.js state.
|
||||||
|
*
|
||||||
|
* Originally lived in `apply-ai-response.ts` (the AI-response path pioneered
|
||||||
|
* it); moved here alongside `sanitizeAiTree`/`flattenTreeForCraft` once
|
||||||
|
* `templates/apply-template.ts` needed the exact same tree-materialization
|
||||||
|
* logic — building a node tree by hand via `React.createElement` +
|
||||||
|
* `query.parseReactElement` does NOT correctly route content through a
|
||||||
|
* `Section`/`BackgroundSection`/`FormContainer`'s internal SHELL_INNER
|
||||||
|
* linked canvas or `ColumnLayout`'s linked columns (see the `SHELL_INNER`
|
||||||
|
* comment above): Craft.js would auto-materialize that linked node at
|
||||||
|
* render time with a botched `type` field and crash `toNodeTree` with
|
||||||
|
* "component type (undefined) does not exist in the resolver". Going through
|
||||||
|
* `sanitizeAiTree` + `flattenTreeForCraft` (as this function does) avoids
|
||||||
|
* that entirely.
|
||||||
|
*/
|
||||||
|
export function buildNodeTree(query: any, tree: SerializedTreeNode): NodeTree {
|
||||||
|
// Validate + sanitize at the boundary before touching Craft.js at all:
|
||||||
|
// unknown resolvedNames are dropped (never reach parseFreshNode/addNodeTree,
|
||||||
|
// which would throw), and ids are repaired ('ROOT'/empty/colliding →
|
||||||
|
// regenerated) against the live document's existing node ids so a new
|
||||||
|
// caller-supplied id can never clobber or duplicate one already on the canvas.
|
||||||
|
const existingIds = new Set<string>(
|
||||||
|
typeof query?.getNodes === 'function' ? Object.keys(query.getNodes()) : [],
|
||||||
|
);
|
||||||
|
const sanitized = sanitizeAiTree(tree, existingIds);
|
||||||
|
if (!sanitized) {
|
||||||
|
throw new Error('craft-tree: tree root has an unknown/invalid component type; nothing to build');
|
||||||
|
}
|
||||||
|
|
||||||
|
// sanitizeAiTree() has already guaranteed every node has a valid, unique,
|
||||||
|
// non-'ROOT' node_id and a registered resolvedName — flattenTreeForCraft
|
||||||
|
// just needs to do the structural walk (linkedNodes/SHELL_INNER/style
|
||||||
|
// normalization) common to every tree-flattening caller in this codebase.
|
||||||
|
const flat = flattenTreeForCraft(sanitized);
|
||||||
|
|
||||||
|
const craftNodes: Record<string, any> = {};
|
||||||
|
for (const [id, flatNode] of Object.entries(flat.nodes)) {
|
||||||
|
// Live Craft.js nodes need `data.type` to be the ACTUAL component
|
||||||
|
// reference (the function/class from `componentResolver`) -- not the
|
||||||
|
// `{ resolvedName }` wrapper object `flattenTreeForCraft` produces (that
|
||||||
|
// wrapper is the *serialized* form used by `actions.deserialize()`/
|
||||||
|
// `query.serialize()`, a different Craft.js entry point), and not a
|
||||||
|
// plain resolvedName string either.
|
||||||
|
//
|
||||||
|
// A plain string passes `parseFreshNode`'s own validation (it special-
|
||||||
|
// cases strings) AND `actions.addNodeTree`'s, so that alone looks fine --
|
||||||
|
// but it's wrong for RENDERING: Craft.js's node renderer does
|
||||||
|
// `React.createElement(data.type, props)` directly, so a string type
|
||||||
|
// makes React treat e.g. "Section" as a literal (invalid, lowercase-
|
||||||
|
// expected) HTML tag name instead of resolving it to the real `Section`
|
||||||
|
// component. Symptom: "is using incorrect casing" console warnings and
|
||||||
|
// the component's own render logic (and thus its content) never runs --
|
||||||
|
// reproduced live by loading a template: the header/footer rendered fine
|
||||||
|
// but the page canvas went blank. The `{ resolvedName }` wrapper object
|
||||||
|
// fails even earlier, at `parseFreshNode`/`addNodeTree`'s own validation
|
||||||
|
// ("component type (undefined) does not exist in the resolver"), because
|
||||||
|
// their resolution only accepts a string or a component reference.
|
||||||
|
//
|
||||||
|
// None of this was caught by the pre-existing mocked test for this
|
||||||
|
// function (in apply-ai-response.test.ts) because its fake
|
||||||
|
// `parseFreshNode` just echoes the input back unchanged rather than
|
||||||
|
// exercising Craft.js's real validation/rendering.
|
||||||
|
const resolvedComponent = (componentResolver as Record<string, unknown>)[flatNode.type.resolvedName];
|
||||||
|
|
||||||
|
if (flat.syntheticIds.has(id)) {
|
||||||
|
// The SHELL_INNER wrapper Container is synthesized by the flattener,
|
||||||
|
// not present in the input tree — build it directly rather than
|
||||||
|
// through query.parseFreshNode(), which would merge in Container's
|
||||||
|
// default `craft.props` (e.g. default padding) and change its look.
|
||||||
|
//
|
||||||
|
// `actions.addNodeTree`'s own validation for a non-string `data.type`
|
||||||
|
// checks `resolver[data.name]` (NOT a reverse lookup from `data.type`
|
||||||
|
// like `parseFreshNode` does) -- so `data.name` must be set to the
|
||||||
|
// resolvedName string here too, or this synthetic node fails that
|
||||||
|
// check with "component type (Container) does not exist in the
|
||||||
|
// resolver" the moment `addNodeTree` runs, even though `resolvedComponent`
|
||||||
|
// itself is perfectly valid.
|
||||||
|
craftNodes[id] = {
|
||||||
|
id,
|
||||||
|
data: { ...flatNode, type: resolvedComponent, name: flatNode.type.resolvedName },
|
||||||
|
events: { selected: false, hovered: false, dragged: false },
|
||||||
|
rules: { canDrag: () => true, canMoveIn: () => true, canMoveOut: () => true, canDrop: () => true },
|
||||||
|
};
|
||||||
|
} else {
|
||||||
|
craftNodes[id] = (query.parseFreshNode({
|
||||||
|
id,
|
||||||
|
data: { ...flatNode, type: resolvedComponent },
|
||||||
|
}) as any).toNode();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return { rootNodeId: flat.rootNodeId, nodes: craftNodes };
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Returns a deep-cloned NodeTree where every node id in the tree
|
* Returns a deep-cloned NodeTree where every node id in the tree
|
||||||
* (rootNodeId, the `nodes` map keys, each `node.id`, each internal
|
* (rootNodeId, the `nodes` map keys, each `node.id`, each internal
|
||||||
@@ -267,12 +366,27 @@ export function regenerateTreeIds(tree: NodeTree): NodeTree {
|
|||||||
newLinkedNodes[slot] = remapId(linkedId);
|
newLinkedNodes[slot] = remapId(linkedId);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Deep-clone data so mutable sub-objects (props, custom, etc.) are never
|
// Deep-clone only the mutable sub-objects (props, custom) so they're
|
||||||
// shared by reference between the original node and its regenerated
|
// never shared by reference between the original node and its
|
||||||
// copy. Craft.js's setProp mutates data.props in place, so a shallow
|
// regenerated copy -- Craft.js's setProp mutates data.props in place, so
|
||||||
// copy here would let edits to the duplicate silently corrupt the
|
// a shallow copy here would let edits to the duplicate silently corrupt
|
||||||
// original.
|
// the original.
|
||||||
const clonedData = structuredClone(oldNode.data);
|
//
|
||||||
|
// Deliberately NOT `structuredClone(oldNode.data)` as a whole: for a
|
||||||
|
// LIVE Craft.js node (as opposed to a plain serialized one), `data.type`
|
||||||
|
// is the actual component function/class reference (see the long
|
||||||
|
// comment on `buildNodeTree` above) -- `structuredClone` cannot clone a
|
||||||
|
// function and throws `DataCloneError`, which silently broke EVERY
|
||||||
|
// duplicate/paste in the real app (masked in unit tests that mock
|
||||||
|
// `@craftjs/core` with plain-data fake nodes, so `toNodeTree()` never
|
||||||
|
// actually returns a function there). `type` is a stable reference that
|
||||||
|
// both the original and the duplicate should point at unchanged, so it
|
||||||
|
// never needed cloning in the first place.
|
||||||
|
const clonedData = {
|
||||||
|
...oldNode.data,
|
||||||
|
props: structuredClone(oldNode.data.props),
|
||||||
|
custom: structuredClone(oldNode.data.custom),
|
||||||
|
};
|
||||||
|
|
||||||
const newNode: Node = {
|
const newNode: Node = {
|
||||||
...oldNode,
|
...oldNode,
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
import { describe, test, expect } from 'vitest';
|
import { describe, test, expect } from 'vitest';
|
||||||
import { escapeHtml, escapeAttr, safeUrl, stableHash, scopeId, sanitizeFormMethod, sanitizeInputType } from './escape';
|
import { escapeHtml, escapeAttr, safeUrl, safeImageUrl, stableHash, scopeId, sanitizeFormMethod, sanitizeInputType } from './escape';
|
||||||
|
|
||||||
describe('escapeHtml', () => {
|
describe('escapeHtml', () => {
|
||||||
test('escapes &, <, >, "', () => {
|
test('escapes &, <, >, "', () => {
|
||||||
@@ -71,6 +71,24 @@ describe('safeUrl', () => {
|
|||||||
expect(safeUrl(s)).toBe(s);
|
expect(safeUrl(s)).toBe(s);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('M-5: blocks data:image/svg+xml (can execute script when navigated to directly)', () => {
|
||||||
|
expect(safeUrl('data:image/svg+xml,<svg onload=alert(1)>')).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('M-5: blocks data:image/svg+xml;base64 variant', () => {
|
||||||
|
expect(safeUrl('data:image/svg+xml;base64,PHN2ZyBvbmxvYWQ9YWxlcnQoMSk+')).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('M-5: blocks obfuscated (whitespace/case) data:image/svg+xml', () => {
|
||||||
|
expect(safeUrl(' DATA:IMAGE/SVG+XML,<svg onload=alert(1)>')).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('M-5: still allows other data:image/* types unchanged', () => {
|
||||||
|
expect(safeUrl('data:image/jpeg;base64,/9j/4AAQ')).toBe('data:image/jpeg;base64,/9j/4AAQ');
|
||||||
|
expect(safeUrl('data:image/gif;base64,R0lGOD')).toBe('data:image/gif;base64,R0lGOD');
|
||||||
|
expect(safeUrl('data:image/webp;base64,UklGR')).toBe('data:image/webp;base64,UklGR');
|
||||||
|
});
|
||||||
|
|
||||||
test.each([
|
test.each([
|
||||||
'https://x.com/a?b=1&c=2',
|
'https://x.com/a?b=1&c=2',
|
||||||
'http://x',
|
'http://x',
|
||||||
@@ -94,6 +112,73 @@ describe('safeUrl', () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('safeImageUrl (Bug 2: image-context sink -- data:image/svg+xml is safe as an <img>/CSS url() target)', () => {
|
||||||
|
test('allows data:image/svg+xml (a raw, non-base64 SVG data URI, as Gallery/ImageBlock placeholders use)', () => {
|
||||||
|
const s = 'data:image/svg+xml,<svg/>';
|
||||||
|
expect(safeImageUrl(s)).toBe(s);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('allows data:image/svg+xml;base64 variant', () => {
|
||||||
|
const s = 'data:image/svg+xml;base64,PHN2Zy8+';
|
||||||
|
expect(safeImageUrl(s)).toBe(s);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('allows other data:image/* types unchanged', () => {
|
||||||
|
expect(safeImageUrl('data:image/png;base64,x')).toBe('data:image/png;base64,x');
|
||||||
|
expect(safeImageUrl('data:image/jpeg;base64,x')).toBe('data:image/jpeg;base64,x');
|
||||||
|
expect(safeImageUrl('data:image/webp;base64,x')).toBe('data:image/webp;base64,x');
|
||||||
|
expect(safeImageUrl('data:image/gif;base64,x')).toBe('data:image/gif;base64,x');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('still blocks javascript: scheme', () => {
|
||||||
|
expect(safeImageUrl('javascript:alert(1)')).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('still blocks vbscript: scheme', () => {
|
||||||
|
expect(safeImageUrl('vbscript:msgbox(1)')).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('still blocks data:text/html', () => {
|
||||||
|
expect(safeImageUrl('data:text/html,x')).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('still blocks non-image data: types generally (e.g. data:application/...)', () => {
|
||||||
|
expect(safeImageUrl('data:application/javascript,alert(1)')).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('blocks obfuscated (whitespace/case) javascript: scheme, same as safeUrl', () => {
|
||||||
|
expect(safeImageUrl(' JavaScript:alert(1)')).toBe('');
|
||||||
|
expect(safeImageUrl('java\tscript:alert(1)')).toBe('');
|
||||||
|
expect(safeImageUrl('javascript:alert(1)')).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('allows ordinary http(s)/relative urls unchanged, same as safeUrl', () => {
|
||||||
|
expect(safeImageUrl('https://example.com/photo.jpg')).toBe('https://example.com/photo.jpg');
|
||||||
|
expect(safeImageUrl('/assets/photo.jpg')).toBe('/assets/photo.jpg');
|
||||||
|
expect(safeImageUrl('')).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('coerces non-string to empty string', () => {
|
||||||
|
expect(safeImageUrl(null as any)).toBe('');
|
||||||
|
expect(safeImageUrl(undefined as any)).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('tightened allowlist: blocks a bogus MIME that merely starts with "image" but has no slash (e.g. data:imagehtml/...)', () => {
|
||||||
|
expect(safeImageUrl('data:imagehtml/svg+xml,x')).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('tightened allowlist: still allows legit data:image/* subtypes', () => {
|
||||||
|
expect(safeImageUrl('data:image/png;base64,x')).toBe('data:image/png;base64,x');
|
||||||
|
expect(safeImageUrl('data:image/svg+xml,<svg/>')).toBe('data:image/svg+xml,<svg/>');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('safeUrl still blocks data:image/svg+xml (href/iframe/navigation context unchanged by safeImageUrl addition)', () => {
|
||||||
|
test('safeUrl(data:image/svg+xml,...) is still blocked', () => {
|
||||||
|
expect(safeUrl('data:image/svg+xml,<svg onload=alert(1)>')).toBe('');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe('stableHash', () => {
|
describe('stableHash', () => {
|
||||||
test('same input always produces the same output', () => {
|
test('same input always produces the same output', () => {
|
||||||
expect(stableHash('hello')).toBe(stableHash('hello'));
|
expect(stableHash('hello')).toBe(stableHash('hello'));
|
||||||
@@ -120,8 +205,24 @@ describe('scopeId', () => {
|
|||||||
expect(id1).not.toBe(id2);
|
expect(id1).not.toBe(id2);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('node id is slugified (non-alphanumeric characters stripped, lowercased)', () => {
|
test('output is a valid CSS ident: prefix_hash', () => {
|
||||||
expect(scopeId('Node ID! 123', 'seed', 'sb')).toBe('sb_nodeid123');
|
expect(scopeId('Node ID! 123', 'seed', 'sb')).toMatch(/^sb_[a-z0-9]+$/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('M-4: case-differing node ids do not collapse to the same scope (no case-fold collision)', () => {
|
||||||
|
expect(scopeId('AbC', 'seed', 'sb')).not.toBe(scopeId('abc', 'seed', 'sb'));
|
||||||
|
});
|
||||||
|
|
||||||
|
test('M-4: punctuation-differing node ids do not collapse to the same scope', () => {
|
||||||
|
expect(scopeId('a-b', 'seed', 'sb')).not.toBe(scopeId('ab', 'seed', 'sb'));
|
||||||
|
});
|
||||||
|
|
||||||
|
test('M-4: same input always yields the identical scope id', () => {
|
||||||
|
expect(scopeId('some-node-id', 'seed', 'sb')).toBe(scopeId('some-node-id', 'seed', 'sb'));
|
||||||
|
});
|
||||||
|
|
||||||
|
test('M-4: output always matches a valid CSS ident pattern', () => {
|
||||||
|
expect(scopeId('Weird!! Node--ID__123', 'seed', 'sb')).toMatch(/^[a-z]+_[a-z0-9]+$/i);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('no nodeId (legacy 2-arg call sites) falls back to a deterministic hash of the seed, not Math.random', () => {
|
test('no nodeId (legacy 2-arg call sites) falls back to a deterministic hash of the seed, not Math.random', () => {
|
||||||
|
|||||||
+72
-17
@@ -36,7 +36,14 @@ export function escapeAttr(s: string): string {
|
|||||||
// Dangerous scheme prefixes, checked against a normalized copy with all
|
// Dangerous scheme prefixes, checked against a normalized copy with all
|
||||||
// colons removed (see safeUrl) so that colon-splicing obfuscation like
|
// colons removed (see safeUrl) so that colon-splicing obfuscation like
|
||||||
// "java:script:alert(1)" can't slip past a literal "javascript:" check.
|
// "java:script:alert(1)" can't slip past a literal "javascript:" check.
|
||||||
const DANGEROUS_SCHEME_PREFIXES = ['javascript', 'vbscript', 'datatext/html'];
|
// M-5: `data:image/svg+xml` is blocked alongside `data:text/html` -- an SVG
|
||||||
|
// document can carry an inline <script>/onload= just like an HTML document,
|
||||||
|
// so it executes script when loaded as a document/navigation target (e.g. an
|
||||||
|
// <a href> or window.open), even though it's nominally an "image" MIME type.
|
||||||
|
// Other `data:image/*` types (png/jpeg/gif/webp, ...) stay allowed below --
|
||||||
|
// only this specific scriptable subtype is blocked, regardless of a
|
||||||
|
// trailing `;base64` or other parameters.
|
||||||
|
const DANGEROUS_SCHEME_PREFIXES = ['javascript', 'vbscript', 'datatext/html', 'dataimage/svg+xml'];
|
||||||
|
|
||||||
/** Decodes &#NN; and &#xNN; numeric HTML entities (used to obfuscate scheme names). */
|
/** Decodes &#NN; and &#xNN; numeric HTML entities (used to obfuscate scheme names). */
|
||||||
function decodeNumericEntities(s: string): string {
|
function decodeNumericEntities(s: string): string {
|
||||||
@@ -57,20 +64,7 @@ export function safeUrl(s: string): string {
|
|||||||
const trimmed = s.trim();
|
const trimmed = s.trim();
|
||||||
if (trimmed === '') return '';
|
if (trimmed === '') return '';
|
||||||
|
|
||||||
// Build a normalized copy for scheme detection only: decode numeric HTML
|
const collapsed = normalizeForSchemeCheck(trimmed);
|
||||||
// entities (catches e.g. j -> 'j'), strip whitespace/control chars,
|
|
||||||
// and lowercase.
|
|
||||||
const normalized = decodeNumericEntities(trimmed)
|
|
||||||
.replace(/[\x00-\x20]+/g, '')
|
|
||||||
.toLowerCase();
|
|
||||||
|
|
||||||
// Strip any colons before matching the scheme prefix. This defeats
|
|
||||||
// obfuscation that splices extra colons into the scheme name itself
|
|
||||||
// (e.g. decoding : mid-word produces "java:script:alert(1)", which
|
|
||||||
// would otherwise dodge a literal "^javascript:" check) while still
|
|
||||||
// reliably catching the real "javascript:"/"vbscript:"/"data:text/html"
|
|
||||||
// prefixes once their own colon is removed.
|
|
||||||
const collapsed = normalized.replace(/:/g, '');
|
|
||||||
|
|
||||||
if (DANGEROUS_SCHEME_PREFIXES.some((prefix) => collapsed.startsWith(prefix))) {
|
if (DANGEROUS_SCHEME_PREFIXES.some((prefix) => collapsed.startsWith(prefix))) {
|
||||||
return '';
|
return '';
|
||||||
@@ -79,6 +73,61 @@ export function safeUrl(s: string): string {
|
|||||||
return trimmed;
|
return trimmed;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Image-context variant of `safeUrl` for IMAGE sinks only (`<img src>`, CSS
|
||||||
|
* `url(...)` backgrounds). `data:image/svg+xml` is safe here -- loaded as an
|
||||||
|
* image, an SVG is rasterized and never executes an inline <script>/onload=
|
||||||
|
* the way it would as a navigation/iframe document -- so, unlike `safeUrl`,
|
||||||
|
* this ALLOWS every `data:image/*` subtype (svg+xml, png, jpeg, gif, webp,
|
||||||
|
* ..., with or without `;base64`).
|
||||||
|
*
|
||||||
|
* Still blocks `javascript:` / `vbscript:` (same obfuscation-resistant
|
||||||
|
* normalization as `safeUrl`), and -- because this is an image sink, not a
|
||||||
|
* general-purpose URL sink -- treats `data:` as an ALLOWLIST rather than a
|
||||||
|
* blocklist: any `data:` URI whose type is NOT `image/*` (`data:text/html`,
|
||||||
|
* `data:application/javascript`, `data:text/javascript`, etc.) is blocked
|
||||||
|
* too, since none of those are legitimate image sources.
|
||||||
|
*
|
||||||
|
* Do NOT use this for href/iframe/form-action/navigation sinks -- keep
|
||||||
|
* those on `safeUrl`, which still blocks `data:image/svg+xml`.
|
||||||
|
*/
|
||||||
|
export function safeImageUrl(s: unknown): string {
|
||||||
|
if (typeof s !== 'string') return '';
|
||||||
|
|
||||||
|
const trimmed = s.trim();
|
||||||
|
if (trimmed === '') return '';
|
||||||
|
|
||||||
|
const collapsed = normalizeForSchemeCheck(trimmed);
|
||||||
|
|
||||||
|
if (collapsed.startsWith('javascript') || collapsed.startsWith('vbscript')) {
|
||||||
|
return '';
|
||||||
|
}
|
||||||
|
if (collapsed.startsWith('data') && !collapsed.startsWith('dataimage/')) {
|
||||||
|
// A data: URI whose MIME type isn't image/* -- e.g. data:text/html,
|
||||||
|
// data:application/javascript, data:text/javascript. No legitimate
|
||||||
|
// image source needs these; block unconditionally.
|
||||||
|
return '';
|
||||||
|
}
|
||||||
|
|
||||||
|
return trimmed;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Normalizes a trimmed URL string for scheme-prefix matching only: decodes
|
||||||
|
// numeric HTML entities (catches e.g. j -> 'j'), strips whitespace /
|
||||||
|
// control chars, lowercases, then strips every colon. Stripping colons
|
||||||
|
// defeats obfuscation that splices extra colons into the scheme name itself
|
||||||
|
// (e.g. decoding : mid-word produces "java:script:alert(1)", which would
|
||||||
|
// otherwise dodge a literal "^javascript:" check) while still reliably
|
||||||
|
// catching the real "javascript:"/"vbscript:"/"data:..." prefixes once their
|
||||||
|
// own colon is removed. Used for prefix `.startsWith()` checks only -- the
|
||||||
|
// original (non-collapsed) string is always what gets returned/emitted.
|
||||||
|
function normalizeForSchemeCheck(trimmed: string): string {
|
||||||
|
return decodeNumericEntities(trimmed)
|
||||||
|
.replace(/[\x00-\x20]+/g, '')
|
||||||
|
.toLowerCase()
|
||||||
|
.replace(/:/g, '');
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Neutralizes CSS-context breakout for a single design-token value (color,
|
* Neutralizes CSS-context breakout for a single design-token value (color,
|
||||||
* length, gradient, etc.) so it is safe to interpolate RAW into either CSS
|
* length, gradient, etc.) so it is safe to interpolate RAW into either CSS
|
||||||
@@ -151,8 +200,14 @@ export function stableHash(seed: string): string {
|
|||||||
* available.
|
* available.
|
||||||
*/
|
*/
|
||||||
export function scopeId(nodeId: string | undefined, fallbackSeed: string, prefix: string): string {
|
export function scopeId(nodeId: string | undefined, fallbackSeed: string, prefix: string): string {
|
||||||
const slug = (nodeId || '').toString().toLowerCase().replace(/[^a-z0-9]+/g, '');
|
// M-4: hash the raw node id (via the same djb2 `stableHash` used for the
|
||||||
return `${prefix}_${slug || stableHash(fallbackSeed)}`;
|
// fallback path below) rather than lowercasing + stripping punctuation
|
||||||
|
// into a slug. A slug collapses distinct ids that differ only by
|
||||||
|
// case/punctuation (e.g. "AbC" and "abc", or "a-b" and "ab") onto the same
|
||||||
|
// scope; hashing the untouched string keeps them distinct while staying
|
||||||
|
// deterministic and producing a valid CSS ident (prefix + '_' + [a-z0-9]+).
|
||||||
|
const seed = (nodeId || '').toString();
|
||||||
|
return `${prefix}_${stableHash(seed || fallbackSeed)}`;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Shared enum allowlists for `toHtml` attribute sinks fed by props that are
|
// Shared enum allowlists for `toHtml` attribute sinks fed by props that are
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
import { CSSProperties } from 'react';
|
import { CSSProperties } from 'react';
|
||||||
import { escapeAttr, safeUrl } from './escape';
|
import { escapeAttr, safeImageUrl } from './escape';
|
||||||
|
|
||||||
const camelToKebab = (str: string): string =>
|
const camelToKebab = (str: string): string =>
|
||||||
str.replace(/[A-Z]/g, (m) => '-' + m.toLowerCase());
|
str.replace(/[A-Z]/g, (m) => '-' + m.toLowerCase());
|
||||||
@@ -41,8 +41,12 @@ function sanitizeCssValue(raw: string): string {
|
|||||||
// Neutralize the url(...) reference: validate/strip the scheme and
|
// Neutralize the url(...) reference: validate/strip the scheme and
|
||||||
// re-wrap in single quotes with the contents escaped for attribute
|
// re-wrap in single quotes with the contents escaped for attribute
|
||||||
// safety. This is already fully safe, `;` and all.
|
// safety. This is already fully safe, `;` and all.
|
||||||
|
// Image-context sink (background/mask/border-image url()): use
|
||||||
|
// safeImageUrl, not safeUrl -- a data:image/svg+xml background is safe
|
||||||
|
// (rasterized, never executed as a document) and must survive here, the
|
||||||
|
// same way it must survive on an <img src>.
|
||||||
const inner = m[2];
|
const inner = m[2];
|
||||||
out += `url('${escapeAttr(safeUrl(inner.trim()))}')`;
|
out += `url('${escapeAttr(safeImageUrl(inner.trim()))}')`;
|
||||||
lastIndex = URL_RE.lastIndex;
|
lastIndex = URL_RE.lastIndex;
|
||||||
}
|
}
|
||||||
out += sanitizeBreakoutChars(raw.slice(lastIndex));
|
out += sanitizeBreakoutChars(raw.slice(lastIndex));
|
||||||
|
|||||||
Reference in New Issue
Block a user