cloud-hosting-platform/site-builder
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: entrance-animation delay no-op (coerce bare number to valid CSS time) #24

Merged
jknapp merged 1 commits from fix-animation-delay into main 2026-07-14 19:36:51 +00:00
Conversation 0 Commits 1 Files Changed 2
+17 -1
jknapp commented 2026-07-14 19:36:50 +00:00
Owner
Copy Link
Copy Source

data-animation-delay is stored as a plain seconds string ("2"); the reveal script assigned it raw to el.style.animationDelay = invalid CSS = no-op. Suffix s onto bare numbers ("2"->"2s"), leaving "2s"/"200ms" alone. Byte-identical change in the backend generateCompiledHTML reveal script. 895 tests.

🤖 Generated with Claude Code

data-animation-delay is stored as a plain seconds string ("2"); the reveal script assigned it raw to el.style.animationDelay = invalid CSS = no-op. Suffix s onto bare numbers ("2"->"2s"), leaving "2s"/"200ms" alone. Byte-identical change in the backend generateCompiledHTML reveal script. 895 tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
jknapp added 1 commit 2026-07-14 19:36:50 +00:00
fix(site-builder): coerce bare-number animation delay to a valid CSS time (2 -> 2s) 25dfcbb725 
data-animation-delay is stored as a plain seconds string (e.g. '2'); the reveal
script assigned it raw to el.style.animationDelay, which is invalid CSS and no-ops.
Suffix 's' onto bare numbers (leaving '2s'/'200ms' alone) so entrance-animation
delays actually apply. Backend generateCompiledHTML gets the byte-identical change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jknapp merged commit 2ac62c4e9e into main 2026-07-14 19:36:51 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jknapp whmcs-sam whp-cicd-user whp-deploy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cloud-hosting-platform/site-builder#24
Delete Branch "fix-animation-delay"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?