cloud-hosting-platform/site-builder
6
0 Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

Autosave must not run until a load succeeded #28

New Issue
Closed
opened 2026-10-07 16:47:16 +00:00 by jknapp · 1 comment
jknapp commented 2026-10-07 16:47:16 +00:00
Owner
Copy link
Copy source

Tier: Fix first · Order: 1 of 35 · Effort: S · Impact: high

What

If the editor can't load your site, it must never silently save a blank canvas over it. Show a blocking “Couldn't load site — Retry” screen and keep autosave off until a load completes.

Why

Confirmed by code read: TopBar.tsx:51-58 only console.warns on load failure; the 30s autosave (TopBar.tsx:61-81) runs anyway; save() would ship the default empty page; handleSave (site-builder.php:625-756) writes project.json unconditionally with no backup. A brief 5xx or network blip on load can wipe a site 30 seconds later.

Today

Load failure = console.warn; autosave timer independent of load result; backend accepts any payload.

Design notes

Frontend: a loadedOk flag gates autosave and manual save. Backend backstop: refuse a save where every page is empty while the existing project.json has content, unless force=true (sent only after an explicit “Start over” confirm).

Depends on

None

From the 2026-10-07 site-builder research (competitor review, user sentiment, code audit, Fable prioritization). Roadmap: https://claude.ai/artifact/QpQcSCk21z6SN7LPSm8tKE · id autosave-load-guard

**Tier:** Fix first · **Order:** 1 of 35 · **Effort:** S · **Impact:** high ## What If the editor can't load your site, it must never silently save a blank canvas over it. Show a blocking “Couldn't load site — Retry” screen and keep autosave off until a load completes. ## Why Confirmed by code read: TopBar.tsx:51-58 only console.warns on load failure; the 30s autosave (TopBar.tsx:61-81) runs anyway; save() would ship the default empty page; handleSave (site-builder.php:625-756) writes project.json unconditionally with no backup. A brief 5xx or network blip on load can wipe a site 30 seconds later. ## Today Load failure = console.warn; autosave timer independent of load result; backend accepts any payload. ## Design notes Frontend: a loadedOk flag gates autosave and manual save. Backend backstop: refuse a save where every page is empty while the existing project.json has content, unless force=true (sent only after an explicit “Start over” confirm). ## Depends on None --- From the 2026-10-07 site-builder research (competitor review, user sentiment, code audit, Fable prioritization). Roadmap: https://claude.ai/artifact/QpQcSCk21z6SN7LPSm8tKE · id `autosave-load-guard`
jknapp added the tier: fix-firsteffort: Simpact: high labels 2026-10-07 16:47:16 +00:00
jknapp commented 2026-10-07 21:36:58 +00:00
Author
Owner
Copy link
Copy source

Shipped in WHP release 2026.10.3 (site-builder main bdb4789, deployed fleet-wide 2026-10-07). Implemented, reviewed and verified as part of the editor-polish batch.

Shipped in WHP release **2026.10.3** (site-builder `main` bdb4789, deployed fleet-wide 2026-10-07). Implemented, reviewed and verified as part of the editor-polish batch.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
effort: L
effort: M
effort: S
effort: XL
impact: high
impact: low
impact: med
tier: bigger-bet
Larger differentiating features
 tier: core-polish
Makes it feel like a modern editor
 tier: fix-first
Data-safety and trust bugs
 tier: quick-win
Small changes that remove clunkiness now
No labels effort: S impact: high tier: fix-first
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hub-agent Bot jknapp renovate-bot (Renovate Bot) whmcs-sam whp-cicd-user whp-deploy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cloud-hosting-platform/site-builder#28