- TextStylePanel (Heading/TextBlock): line-height/letter-spacing presets,
text-transform (none/uppercase/lowercase/capitalize), italic + underline
toggles (fontStyle/textDecoration), and a custom NumericUnitInput
font-size alongside the existing preset row. All write to component
`style`; no toHtml changes needed (style already flows through
cssPropsToString for both components).
- ButtonStylePanel/ButtonLink: "Open in new tab" checkbox writes the
existing `target` prop ('_self'/'_blank' -- toHtml already emitted
rel="noopener noreferrer" for _blank). New Hover State section
(hoverBg/hoverColor via ColorPickerField) renders a scoped
`<style>.btn_<hash>:hover{...}</style>` block before the `<a>` in
toHtml, scoped per-node via scopeId (same pattern as Navbar/Menu) so
two buttons on one page don't collide; both values sanitized through
cssValue against <style>-element breakout. Editor canvas gets a live
hover preview via onMouseEnter/onMouseLeave local state (mirrors Menu's
approach), since there's no way to preview a CSS :hover rule directly
on an inline-styled React element.
- Heading/TextBlock/ButtonLink: added margin(per-side)/padding(per-side,
Text only)/border/box-shadow/opacity style defaults + AnimationControl/
VisibilityControl-backed animation/animationDelay/hideOnDesktop/
hideOnTablet/hideOnMobile props, each panel gaining collapsible
Spacing / Border & Effects / Animation & Visibility sections. Button
keeps its existing padding-shorthand preset row rather than adding a
redundant per-side padding control; only margin got the new
per-side SpacingControl.
- Tests: extended all three *.toHtml.test.ts files -- typography style
emission (line-height/letter-spacing/text-transform/font-style/
text-decoration/custom font-size), button target+rel, scoped hover
style emission + two adversarial style-breakout cases (</style><script>
and rule-injection via `;}selector{`), and craft.props assertions for
every new prop on all three components. 674 tests green, tsc + vite
build clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
110 lines
4.3 KiB
TypeScript
110 lines
4.3 KiB
TypeScript
import { describe, test, expect } from 'vitest';
|
|
import { Heading } from './Heading';
|
|
|
|
const toHtml = (Heading as any).toHtml;
|
|
|
|
describe('Heading.toHtml level allowlist (adversarial re-review, same class as C1)', () => {
|
|
test('a malicious level value clamps to h2 -- no injected <img>, no broken-out tag', () => {
|
|
const { html } = toHtml({ text: 'x', level: 'h2><img src=x onerror=alert(1)' }, '');
|
|
expect(html).not.toContain('<img');
|
|
expect(html).not.toContain('onerror');
|
|
expect(html.startsWith('<h2')).toBe(true);
|
|
expect(html.endsWith('</h2>')).toBe(true);
|
|
});
|
|
|
|
test('a numeric out-of-range level (99) clamps to h2', () => {
|
|
const { html } = toHtml({ text: 'x', level: 99 as any }, '');
|
|
expect(html.startsWith('<h2')).toBe(true);
|
|
expect(html.endsWith('</h2>')).toBe(true);
|
|
});
|
|
|
|
test('a non-heading string level clamps to h2', () => {
|
|
const { html } = toHtml({ text: 'x', level: 'script' as any }, '');
|
|
expect(html.startsWith('<h2')).toBe(true);
|
|
expect(html).not.toContain('<script');
|
|
});
|
|
|
|
test('a normal valid level (h4) still emits <h4', () => {
|
|
const { html } = toHtml({ text: 'x', level: 'h4' }, '');
|
|
expect(html).toContain('<h4');
|
|
expect(html).toContain('</h4>');
|
|
});
|
|
|
|
test('all valid levels h1-h6 still work', () => {
|
|
for (const level of ['h1', 'h2', 'h3', 'h4', 'h5', 'h6']) {
|
|
const { html } = toHtml({ text: 'x', level }, '');
|
|
expect(html.startsWith(`<${level}`)).toBe(true);
|
|
expect(html.endsWith(`</${level}>`)).toBe(true);
|
|
}
|
|
});
|
|
});
|
|
|
|
describe('Heading.toHtml text escaping (attacker-controlled `text` prop)', () => {
|
|
test('a tag-breakout attempt in text is neutralized (no injected element)', () => {
|
|
const { html } = toHtml({ text: '</h2><img src=x onerror=alert(1)>', level: 'h2' }, '');
|
|
expect(html).not.toContain('<img');
|
|
expect(html).toContain('<img');
|
|
});
|
|
|
|
test('ampersand is escaped for well-formed text content (consistency with escapeHtml)', () => {
|
|
const { html } = toHtml({ text: 'Fish & Chips', level: 'h2' }, '');
|
|
expect(html).toContain('Fish & Chips');
|
|
});
|
|
|
|
test('a normal text value still renders unchanged', () => {
|
|
const { html } = toHtml({ text: 'Hello world', level: 'h2' }, '');
|
|
expect(html).toBe('<h2>Hello world</h2>');
|
|
});
|
|
});
|
|
|
|
describe('Heading.toHtml typography depth (line-height/letter-spacing/transform/style/decoration)', () => {
|
|
test('line-height, letter-spacing, text-transform all flow into the style attribute', () => {
|
|
const { html } = toHtml({
|
|
text: 'x',
|
|
level: 'h2',
|
|
style: { lineHeight: '1.25', letterSpacing: '0.05em', textTransform: 'uppercase' },
|
|
}, '');
|
|
expect(html).toContain('line-height:1.25');
|
|
expect(html).toContain('letter-spacing:0.05em');
|
|
expect(html).toContain('text-transform:uppercase');
|
|
});
|
|
|
|
test('italic + underline toggles emit font-style and text-decoration', () => {
|
|
const { html } = toHtml({
|
|
text: 'x',
|
|
level: 'h2',
|
|
style: { fontStyle: 'italic', textDecoration: 'underline' },
|
|
}, '');
|
|
expect(html).toContain('font-style:italic');
|
|
expect(html).toContain('text-decoration:underline');
|
|
});
|
|
|
|
test('a custom font-size (not one of the presets) still flows through', () => {
|
|
const { html } = toHtml({ text: 'x', level: 'h2', style: { fontSize: '42px' } }, '');
|
|
expect(html).toContain('font-size:42px');
|
|
});
|
|
});
|
|
|
|
describe('Heading.craft.props exposes the box-model + animation/visibility rollout', () => {
|
|
test('animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
|
const props = (Heading as any).craft.props;
|
|
expect(props.animation).toBe('');
|
|
expect(props.animationDelay).toBe('0');
|
|
expect(props.hideOnDesktop).toBe(false);
|
|
expect(props.hideOnTablet).toBe(false);
|
|
expect(props.hideOnMobile).toBe(false);
|
|
});
|
|
|
|
test('style carries blank/default box-model + typography-depth keys', () => {
|
|
const style = (Heading as any).craft.props.style;
|
|
expect(style).toHaveProperty('marginTop');
|
|
expect(style).toHaveProperty('paddingTop');
|
|
expect(style).toHaveProperty('lineHeight');
|
|
expect(style).toHaveProperty('letterSpacing');
|
|
expect(style).toHaveProperty('textTransform');
|
|
expect(style.border).toBe('none');
|
|
expect(style.boxShadow).toBe('none');
|
|
expect(style.opacity).toBe('1');
|
|
});
|
|
});
|