shadowdaoandClaude Opus 4.8
591a51dcc2
An adversarial pass found 5 Critical XSS sinks where props declared number/enum in TypeScript were interpolated raw into exported HTML attribute values, trusting the type — but nothing enforces it at runtime (AI update_props only validates node_id; deserialized saved state is untyped JSON). Fixed all 5 (NumberCounter data-target, StarRating aria-label, FormContainer method, ContactForm/InputField input type) plus 6 sibling sinks found by an exhaustive audit of every attribute-value interpolation across src/components: a JS-source injection into ContentSlider's inline setInterval script, a prototype-pollution-adjacent allowlist gap in Section's divider-shape lookup, TextareaField rows, Testimonials rating aria-label, HeroSimple textAlign, and MapEmbed zoom. Adds shared sanitizeFormMethod/sanitizeInputType allowlist helpers to utils/escape.ts alongside the existing escapeAttr/safeUrl/cssValue primitives. Every fix is TDD'd: a malicious-value test reproduces the raw injection against the pre-fix code, then passes after the fix. 502 tests green (npx vitest run), tsc + vite build green (npm run build). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
36 lines
1.5 KiB
TypeScript
36 lines
1.5 KiB
TypeScript
import { describe, test, expect } from 'vitest';
|
|
import { HeroSimple } from './HeroSimple';
|
|
|
|
const toHtml = (HeroSimple as any).toHtml;
|
|
|
|
describe('HeroSimple.toHtml textAlign enum sink (attacker-controlled prop, not enforced at runtime)', () => {
|
|
test('malicious textAlign value cannot break out of the content div style attribute', () => {
|
|
const { html } = toHtml({
|
|
heading: 'Hi',
|
|
subtitle: 'There',
|
|
textAlign: 'center;"><script>alert(1)</script>',
|
|
}, '');
|
|
expect(html).not.toContain('<script>alert(1)</script>');
|
|
expect(html).not.toContain('center;">');
|
|
});
|
|
|
|
test('unrecognized textAlign value falls back to a safe default rather than being echoed raw', () => {
|
|
const { html } = toHtml({ heading: 'Hi', subtitle: 'There', textAlign: 'not-a-real-value' as any }, '');
|
|
expect(html).not.toContain('text-align:not-a-real-value');
|
|
});
|
|
|
|
test('valid textAlign values are preserved', () => {
|
|
const { html: left } = toHtml({ heading: 'Hi', subtitle: 'There', textAlign: 'left' }, '');
|
|
expect(left).toContain('text-align:left');
|
|
const { html: right } = toHtml({ heading: 'Hi', subtitle: 'There', textAlign: 'right' }, '');
|
|
expect(right).toContain('text-align:right');
|
|
});
|
|
|
|
test('normal default render is sane', () => {
|
|
const { html } = toHtml({ heading: 'Welcome', subtitle: 'Sub text' }, '');
|
|
expect(html).toContain('Welcome');
|
|
expect(html).toContain('Sub text');
|
|
expect(html).toContain('text-align:center');
|
|
});
|
|
});
|