shadowdaoandClaude Opus 4.8
591a51dcc2
An adversarial pass found 5 Critical XSS sinks where props declared number/enum in TypeScript were interpolated raw into exported HTML attribute values, trusting the type — but nothing enforces it at runtime (AI update_props only validates node_id; deserialized saved state is untyped JSON). Fixed all 5 (NumberCounter data-target, StarRating aria-label, FormContainer method, ContactForm/InputField input type) plus 6 sibling sinks found by an exhaustive audit of every attribute-value interpolation across src/components: a JS-source injection into ContentSlider's inline setInterval script, a prototype-pollution-adjacent allowlist gap in Section's divider-shape lookup, TextareaField rows, Testimonials rating aria-label, HeroSimple textAlign, and MapEmbed zoom. Adds shared sanitizeFormMethod/sanitizeInputType allowlist helpers to utils/escape.ts alongside the existing escapeAttr/safeUrl/cssValue primitives. Every fix is TDD'd: a malicious-value test reproduces the raw injection against the pre-fix code, then passes after the fix. 502 tests green (npx vitest run), tsc + vite build green (npm run build). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
87 lines
2.1 KiB
TypeScript
87 lines
2.1 KiB
TypeScript
import React, { CSSProperties } from 'react';
|
|
import { useNode, UserComponent } from '@craftjs/core';
|
|
import { cssPropsToString } from '../../utils/style-helpers';
|
|
import { escapeHtml, escapeAttr, safeUrl } from '../../utils/escape';
|
|
|
|
interface ButtonLinkProps {
|
|
text?: string;
|
|
href?: string;
|
|
target?: '_self' | '_blank';
|
|
style?: CSSProperties;
|
|
}
|
|
|
|
export const ButtonLink: UserComponent<ButtonLinkProps> = ({
|
|
text = 'Click Me',
|
|
href = '#',
|
|
target = '_self',
|
|
style = {},
|
|
}) => {
|
|
const {
|
|
connectors: { connect, drag },
|
|
selected,
|
|
} = useNode((node) => ({
|
|
selected: node.events.selected,
|
|
}));
|
|
|
|
return (
|
|
<a
|
|
ref={(ref: HTMLAnchorElement | null) => { if (ref) connect(drag(ref)); }}
|
|
href={href}
|
|
target={target}
|
|
onClick={(e) => {
|
|
// Prevent navigation inside editor
|
|
e.preventDefault();
|
|
}}
|
|
style={{
|
|
display: 'inline-block',
|
|
textDecoration: 'none',
|
|
cursor: 'pointer',
|
|
outline: selected ? '2px solid #3b82f6' : 'none',
|
|
...style,
|
|
}}
|
|
>
|
|
{text}
|
|
</a>
|
|
);
|
|
};
|
|
|
|
/* ---------- Craft config ---------- */
|
|
|
|
ButtonLink.craft = {
|
|
displayName: 'Button',
|
|
props: {
|
|
text: 'Click Me',
|
|
href: '#',
|
|
target: '_self',
|
|
style: {
|
|
backgroundColor: '#3b82f6',
|
|
color: '#ffffff',
|
|
padding: '12px 24px',
|
|
borderRadius: '8px',
|
|
fontWeight: '600',
|
|
fontSize: '16px',
|
|
border: 'none',
|
|
},
|
|
},
|
|
rules: {
|
|
canDrag: () => true,
|
|
canMoveIn: () => false,
|
|
canMoveOut: () => true,
|
|
},
|
|
};
|
|
|
|
/* ---------- HTML export ---------- */
|
|
|
|
(ButtonLink as any).toHtml = (props: ButtonLinkProps, _childrenHtml: string) => {
|
|
const styleStr = cssPropsToString({
|
|
display: 'inline-block',
|
|
textDecoration: 'none',
|
|
...props.style,
|
|
});
|
|
const escapedText = escapeHtml(props.text || '');
|
|
const targetAttr = props.target === '_blank' ? ' target="_blank" rel="noopener noreferrer"' : '';
|
|
return {
|
|
html: `<a href="${escapeAttr(safeUrl(props.href || '#'))}"${targetAttr}${styleStr ? ` style="${styleStr}"` : ''}>${escapedText}</a>`,
|
|
};
|
|
};
|