shadowdaoandClaude Opus 4.8
591a51dcc2
An adversarial pass found 5 Critical XSS sinks where props declared number/enum in TypeScript were interpolated raw into exported HTML attribute values, trusting the type — but nothing enforces it at runtime (AI update_props only validates node_id; deserialized saved state is untyped JSON). Fixed all 5 (NumberCounter data-target, StarRating aria-label, FormContainer method, ContactForm/InputField input type) plus 6 sibling sinks found by an exhaustive audit of every attribute-value interpolation across src/components: a JS-source injection into ContentSlider's inline setInterval script, a prototype-pollution-adjacent allowlist gap in Section's divider-shape lookup, TextareaField rows, Testimonials rating aria-label, HeroSimple textAlign, and MapEmbed zoom. Adds shared sanitizeFormMethod/sanitizeInputType allowlist helpers to utils/escape.ts alongside the existing escapeAttr/safeUrl/cssValue primitives. Every fix is TDD'd: a malicious-value test reproduces the raw injection against the pre-fix code, then passes after the fix. 502 tests green (npx vitest run), tsc + vite build green (npm run build). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
23 lines
920 B
TypeScript
23 lines
920 B
TypeScript
import { describe, test, expect } from 'vitest';
|
|
import { Footer } from './Footer';
|
|
|
|
const toHtml = (Footer as any).toHtml;
|
|
|
|
describe('Footer.toHtml text escaping (attacker-controlled `text` prop)', () => {
|
|
test('a tag-breakout attempt in text is neutralized (no injected element)', () => {
|
|
const { html } = toHtml({ text: '</footer><img src=x onerror=alert(1)>' }, '');
|
|
expect(html).not.toContain('<img');
|
|
expect(html).toContain('<img');
|
|
});
|
|
|
|
test('ampersand is escaped for well-formed text content (consistency with escapeHtml)', () => {
|
|
const { html } = toHtml({ text: 'Terms & Conditions' }, '');
|
|
expect(html).toContain('Terms & Conditions');
|
|
});
|
|
|
|
test('a normal copyright text value still renders unchanged', () => {
|
|
const { html } = toHtml({ text: '© 2026 MySite. All rights reserved.' }, '');
|
|
expect(html).toContain('© 2026 MySite. All rights reserved.');
|
|
});
|
|
});
|