shadowdao
591a51dcc2
An adversarial pass found 5 Critical XSS sinks where props declared number/enum in TypeScript were interpolated raw into exported HTML attribute values, trusting the type — but nothing enforces it at runtime (AI update_props only validates node_id; deserialized saved state is untyped JSON). Fixed all 5 (NumberCounter data-target, StarRating aria-label, FormContainer method, ContactForm/InputField input type) plus 6 sibling sinks found by an exhaustive audit of every attribute-value interpolation across src/components: a JS-source injection into ContentSlider's inline setInterval script, a prototype-pollution-adjacent allowlist gap in Section's divider-shape lookup, TextareaField rows, Testimonials rating aria-label, HeroSimple textAlign, and MapEmbed zoom. Adds shared sanitizeFormMethod/sanitizeInputType allowlist helpers to utils/escape.ts alongside the existing escapeAttr/safeUrl/cssValue primitives. Every fix is TDD'd: a malicious-value test reproduces the raw injection against the pre-fix code, then passes after the fix. 502 tests green (npx vitest run), tsc + vite build green (npm run build). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
83 lines
1.9 KiB
TypeScript
83 lines
1.9 KiB
TypeScript
import React, { CSSProperties } from 'react';
|
|
import { useNode, UserComponent } from '@craftjs/core';
|
|
import { cssPropsToString } from '../../utils/style-helpers';
|
|
import { escapeHtml } from '../../utils/escape';
|
|
|
|
interface FormButtonProps {
|
|
text?: string;
|
|
style?: CSSProperties;
|
|
}
|
|
|
|
export const FormButton: UserComponent<FormButtonProps> = ({
|
|
text = 'Submit',
|
|
style = {},
|
|
}) => {
|
|
const {
|
|
connectors: { connect, drag },
|
|
selected,
|
|
} = useNode((node) => ({
|
|
selected: node.events.selected,
|
|
}));
|
|
|
|
return (
|
|
<button
|
|
ref={(ref: HTMLButtonElement | null): void => { if (ref) connect(drag(ref)); }}
|
|
type="submit"
|
|
onClick={(e) => e.preventDefault()}
|
|
style={{
|
|
padding: '12px 32px',
|
|
backgroundColor: '#3b82f6',
|
|
color: '#ffffff',
|
|
border: 'none',
|
|
borderRadius: '6px',
|
|
fontSize: '16px',
|
|
fontWeight: '600',
|
|
cursor: 'pointer',
|
|
outline: selected ? '2px solid #3b82f6' : 'none',
|
|
outlineOffset: selected ? '2px' : '0',
|
|
...style,
|
|
}}
|
|
>
|
|
{text}
|
|
</button>
|
|
);
|
|
};
|
|
|
|
/* ---------- Craft config ---------- */
|
|
|
|
FormButton.craft = {
|
|
displayName: 'Submit Button',
|
|
props: {
|
|
text: 'Submit',
|
|
style: {
|
|
backgroundColor: '#3b82f6',
|
|
color: '#ffffff',
|
|
padding: '12px 32px',
|
|
borderRadius: '6px',
|
|
fontWeight: '600',
|
|
fontSize: '16px',
|
|
border: 'none',
|
|
},
|
|
},
|
|
rules: {
|
|
canDrag: () => true,
|
|
canMoveIn: () => false,
|
|
canMoveOut: () => true,
|
|
},
|
|
};
|
|
|
|
/* ---------- HTML export ---------- */
|
|
|
|
(FormButton as any).toHtml = (props: FormButtonProps, _childrenHtml: string) => {
|
|
const styleStr = cssPropsToString({
|
|
padding: '12px 32px',
|
|
border: 'none',
|
|
cursor: 'pointer',
|
|
...props.style,
|
|
});
|
|
const escapedText = escapeHtml(props.text || 'Submit');
|
|
return {
|
|
html: `<button type="submit"${styleStr ? ` style="${styleStr}"` : ''}>${escapedText}</button>`,
|
|
};
|
|
};
|