8f51b5144a
Both panels had a ~90-line near-byte-identical per-item field editor (boolean->checkbox, number->number, /color/->color, long->textarea, else text, fields derived from Object.keys(items[0])). Moved into a new ArrayItemFieldsEditor component in ArrayItemFields.tsx used by both. SectionTypePanel keeps its own FeaturesGrid special-case (key === 'features' -> FeaturesEditor) and its empty-array guard ahead of the shared call. Behavior-preserving (task E4.2). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
128 lines
6.2 KiB
TypeScript
128 lines
6.2 KiB
TypeScript
import React from 'react';
|
|
import { useEditor } from '@craftjs/core';
|
|
import { CollapsibleSection, ArrayPropEditor, smallInputStyle } from './shared';
|
|
|
|
/* ---------- Shared array-item field editor ----------
|
|
Extracted from SectionTypePanel and GenericPropsEditor, which both had a
|
|
near-byte-identical per-item field renderer for generic array props
|
|
(features/items/plans/testimonials/etc.). Infers an input type per field:
|
|
boolean -> checkbox, number -> number, /color/ -> color swatch, long
|
|
string -> textarea, else text. Fields are derived from Object.keys(items[0]).
|
|
Callers keep their own special-casing (e.g. SectionTypePanel routes
|
|
key === 'features' to FeaturesEditor instead of using this component). */
|
|
export const ArrayItemFieldsEditor: React.FC<{ selectedId: string; propKey: string; items: any[] }> = ({
|
|
selectedId, propKey, items,
|
|
}) => {
|
|
const { actions } = useEditor();
|
|
const arrayItems = items;
|
|
const sampleItem = arrayItems[0] || {};
|
|
const itemFields = typeof sampleItem === 'object' && sampleItem !== null ? Object.keys(sampleItem) : [];
|
|
|
|
return (
|
|
<CollapsibleSection title={propKey.replace(/([A-Z])/g, ' $1').trim()}>
|
|
<ArrayPropEditor
|
|
selectedId={selectedId}
|
|
propKey={propKey}
|
|
items={arrayItems}
|
|
renderItem={(item: any, index: number) => {
|
|
if (typeof item !== 'object' || item === null) {
|
|
return (
|
|
<input
|
|
type="text"
|
|
value={String(item)}
|
|
onChange={(e) => {
|
|
actions.setProp(selectedId, (props: any) => {
|
|
const updated = [...(props[propKey] || [])];
|
|
updated[index] = e.target.value;
|
|
props[propKey] = updated;
|
|
});
|
|
}}
|
|
style={smallInputStyle}
|
|
/>
|
|
);
|
|
}
|
|
return (
|
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 3 }}>
|
|
{itemFields.map((field) => {
|
|
const fieldVal = item[field];
|
|
if (typeof fieldVal === 'boolean') {
|
|
return (
|
|
<label key={field} style={{ fontSize: 10, color: '#71717a', display: 'flex', alignItems: 'center', gap: 4, cursor: 'pointer' }}>
|
|
<input type="checkbox" checked={fieldVal} onChange={(e) => {
|
|
actions.setProp(selectedId, (props: any) => {
|
|
const updated = [...(props[propKey] || [])];
|
|
updated[index] = { ...updated[index], [field]: e.target.checked };
|
|
props[propKey] = updated;
|
|
});
|
|
}} />
|
|
{field}
|
|
</label>
|
|
);
|
|
}
|
|
if (typeof fieldVal === 'number') {
|
|
return (
|
|
<div key={field}>
|
|
<label style={{ fontSize: 9, color: '#52525b', textTransform: 'capitalize' }}>{field}</label>
|
|
<input type="number" value={fieldVal} onChange={(e) => {
|
|
actions.setProp(selectedId, (props: any) => {
|
|
const updated = [...(props[propKey] || [])];
|
|
updated[index] = { ...updated[index], [field]: parseFloat(e.target.value) || 0 };
|
|
props[propKey] = updated;
|
|
});
|
|
}} style={smallInputStyle} />
|
|
</div>
|
|
);
|
|
}
|
|
// color fields
|
|
if (/color/i.test(field) && typeof fieldVal === 'string') {
|
|
return (
|
|
<div key={field} style={{ display: 'flex', alignItems: 'center', gap: 4 }}>
|
|
<label style={{ fontSize: 9, color: '#52525b', textTransform: 'capitalize', width: 50 }}>{field}</label>
|
|
<input type="color" value={fieldVal || '#000000'} onChange={(e) => {
|
|
actions.setProp(selectedId, (props: any) => {
|
|
const updated = [...(props[propKey] || [])];
|
|
updated[index] = { ...updated[index], [field]: e.target.value };
|
|
props[propKey] = updated;
|
|
});
|
|
}} style={{ width: 24, height: 20, border: 'none', cursor: 'pointer', background: 'none', padding: 0 }} />
|
|
</div>
|
|
);
|
|
}
|
|
// long text
|
|
const strVal = String(fieldVal ?? '');
|
|
const isLongField = strVal.length > 50 || field === 'description' || field === 'text' || field === 'content';
|
|
return (
|
|
<div key={field}>
|
|
<label style={{ fontSize: 9, color: '#52525b', textTransform: 'capitalize' }}>{field}</label>
|
|
{isLongField ? (
|
|
<textarea value={strVal} onChange={(e) => {
|
|
actions.setProp(selectedId, (props: any) => {
|
|
const updated = [...(props[propKey] || [])];
|
|
updated[index] = { ...updated[index], [field]: e.target.value };
|
|
props[propKey] = updated;
|
|
});
|
|
}} rows={2} style={{ ...smallInputStyle, resize: 'vertical' }} />
|
|
) : (
|
|
<input type="text" value={strVal} onChange={(e) => {
|
|
actions.setProp(selectedId, (props: any) => {
|
|
const updated = [...(props[propKey] || [])];
|
|
updated[index] = { ...updated[index], [field]: e.target.value };
|
|
props[propKey] = updated;
|
|
});
|
|
}} style={smallInputStyle} />
|
|
)}
|
|
</div>
|
|
);
|
|
})}
|
|
</div>
|
|
);
|
|
}}
|
|
emptyItem={typeof sampleItem === 'object' && sampleItem !== null
|
|
? Object.fromEntries(itemFields.map((f) => [f, typeof sampleItem[f] === 'number' ? 0 : typeof sampleItem[f] === 'boolean' ? false : '']))
|
|
: ''
|
|
}
|
|
/>
|
|
</CollapsibleSection>
|
|
);
|
|
};
|