54572f648a
NavStylePanel (Navbar/Menu/Logo/Footer):
- LinkPicker: dropdown of the site's pages (read-only via usePages()) plus
manual URL / #anchor / tel: / mailto: entry, wired into every link-href
field (standalone Logo href, Navbar logoUrl, Navbar/Menu link items).
- "Sync links with Pages" button in the Links section: repopulates the
links array from the current pages list (label = page name, href = '/'
for the landing page else '/{slug}'), preserving any existing CTA link.
Regression-fix vs the legacy GrapesJS builder, which had this.
- `download` checkbox per link (Navbar/Menu links, standalone Logo href)
emits the `download` attribute on export for links to files.
- Links/Colors sections now gate on the component actually carrying a
`links`/color prop, so Footer (no links array) no longer shows a dead
"Add Link" editor.
- Box-model (Margin/Padding via SpacingControl, Border & Effects via
BorderControl + box-shadow presets + opacity), AnimationControl, and
VisibilityControl added for all four owned components, backed by new
animation/animationDelay/hideOnDesktop/hideOnTablet/hideOnMobile props
(with blank/default values in each component's .craft.props).
Tests: NavStylePanel.test.tsx (new, 17 tests: LinkPicker modes, sync
preserves CTA, download toggle, box-model/animation/visibility wiring) +
extended Navbar/Menu/Logo/Footer .toHtml.test.ts (download attribute,
craft.props defaults). Full suite: 683/683 passing. `npm run build` green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
86 lines
3.8 KiB
TypeScript
86 lines
3.8 KiB
TypeScript
import { describe, test, expect } from 'vitest';
|
|
import { Logo } from './Logo';
|
|
|
|
/*
|
|
* Regression coverage for Logo.toHtml -- audited during the toHtml
|
|
* attribute-XSS sweep (see task-cssxss-brief.md) and found already fully
|
|
* sanitized (href/src via escapeAttr(safeUrl()), alt/text via escapeAttr /
|
|
* escapeHtml, imageWidth/fontSize/etc. routed through cssPropsToString which
|
|
* sanitizes every value regardless of declared type). No fix was required;
|
|
* these tests lock that behavior in against regressions.
|
|
*/
|
|
const toHtml = (Logo as any).toHtml;
|
|
|
|
describe('Logo.toHtml href sanitization (attacker-controlled `href` prop)', () => {
|
|
test('a javascript: URL is neutralized', () => {
|
|
const { html } = toHtml({ href: 'javascript:alert(1)' }, '');
|
|
expect(html).not.toContain('javascript:alert');
|
|
});
|
|
|
|
test('a quote-breakout href does not escape the anchor attribute', () => {
|
|
const malicious = '"><script>alert(1)</script>';
|
|
const { html } = toHtml({ href: malicious }, '');
|
|
expect(html).not.toContain('<script>alert(1)</script>');
|
|
});
|
|
});
|
|
|
|
describe('Logo.toHtml image src/alt sanitization (type="image")', () => {
|
|
test('a javascript: imageSrc is neutralized', () => {
|
|
const { html } = toHtml({ type: 'image', imageSrc: 'javascript:alert(1)', text: 'Logo' }, '');
|
|
expect(html).not.toContain('javascript:alert');
|
|
});
|
|
|
|
test('a quote-breakout alt (from `text`) does not escape the img attribute', () => {
|
|
const malicious = '"><script>alert(1)</script>';
|
|
const { html } = toHtml({ type: 'image', imageSrc: 'https://example.com/logo.png', text: malicious }, '');
|
|
expect(html).not.toContain('<script>alert(1)</script>');
|
|
});
|
|
|
|
test('a non-numeric imageWidth (attribute-breakout attempt) does not escape the style attribute', () => {
|
|
const malicious = '1"><script>alert(1)</script>';
|
|
const { html } = toHtml({ type: 'image', imageSrc: 'https://example.com/logo.png', imageWidth: malicious }, '');
|
|
expect(html).not.toContain('<script>alert(1)</script>');
|
|
});
|
|
});
|
|
|
|
describe('Logo.toHtml download attribute (F3: link-to-file toggle)', () => {
|
|
test('download:true emits the download attribute', () => {
|
|
const { html } = toHtml({ href: '/resume.pdf', download: true, text: 'Resume' }, '');
|
|
expect(html).toMatch(/<a href="\/resume\.pdf" download/);
|
|
});
|
|
|
|
test('no download prop -> no download attribute emitted', () => {
|
|
const { html } = toHtml({ href: '/', text: 'MySite' }, '');
|
|
expect(html).not.toContain('download');
|
|
});
|
|
});
|
|
|
|
describe('Logo (F4: box-model + animation + visibility props on craft.props)', () => {
|
|
test('craft.props includes animation/visibility defaults so the panel controls always render', () => {
|
|
const craftProps = (Logo as any).craft.props;
|
|
expect(craftProps).toHaveProperty('animation', 'none');
|
|
expect(craftProps).toHaveProperty('animationDelay', '0');
|
|
expect(craftProps).toHaveProperty('hideOnDesktop', false);
|
|
expect(craftProps).toHaveProperty('hideOnTablet', false);
|
|
expect(craftProps).toHaveProperty('hideOnMobile', false);
|
|
});
|
|
});
|
|
|
|
describe('Logo.toHtml text-logo styling sanitization', () => {
|
|
test('a quote-breakout color does not escape the span style attribute', () => {
|
|
const malicious = 'red" onmouseover="alert(1)';
|
|
const { html } = toHtml({ type: 'text', text: 'MySite', color: malicious }, '');
|
|
// The raw `"` must never survive un-escaped inside the style attribute
|
|
// value -- if it did, `onmouseover` would land as a REAL new HTML
|
|
// attribute (breakout) rather than being inert CSS-value garbage inside
|
|
// a properly-escaped style="...".
|
|
expect(html).not.toMatch(/style="[^"]*"[^>]*onmouseover/);
|
|
});
|
|
|
|
test('a normal logo renders as expected', () => {
|
|
const { html } = toHtml({ type: 'text', text: 'MySite', href: '/' }, '');
|
|
expect(html).toContain('href="/"');
|
|
expect(html).toContain('MySite');
|
|
});
|
|
});
|