rho_n
/
hpr_generator
4
2
Fork 1
Code Issues 34 Pull Requests Projects 1 Releases Wiki Activity

Call for shows section shown inappropriately #160

New Issue
Closed
opened 2023-08-27 14:01:19 +00:00 by davmo · 2 comments
davmo commented 2023-08-27 14:01:19 +00:00
Collaborator
Copy Link

The section marked 'Call for shows' on the Home or Index page is displayed when there's no need.

There appears to be an error in the database query which turns this on and off.

The section marked 'Call for shows' on the [Home or Index page](https://hackerpublicradio.org/index.html) is displayed when there's no need. There appears to be an error in the database query which turns this on and off.
davmo added the
Bug Found
 label 2023-08-27 14:01:31 +00:00
davmo commented 2023-08-27 15:31:14 +00:00
Author
Collaborator
Copy Link

The algorithm seems to be to look forward 10 days and count the number of shows in that time. If it is less than the minimum possible, then there's a gap within that period and the "Call for shows" message needs to be displayed.

The original algorithm is wrong; the alert message is displayed when there are 25 days to the next free slot!

It's not entirely obvious how many weekdays (Mon-Fri) there are in a random set of 10 days. A small Perl script was written to sample this and the results were:

$ ./count_weekdays
Weekdays between 2023-08-25 and 2023-09-04 = 6
Weekdays between 2023-08-26 and 2023-09-05 = 7
Weekdays between 2023-08-27 and 2023-09-06 = 8
Weekdays between 2023-08-28 and 2023-09-07 = 8
Weekdays between 2023-08-29 and 2023-09-08 = 8
Weekdays between 2023-08-30 and 2023-09-09 = 7
Weekdays between 2023-08-31 and 2023-09-10 = 6
Weekdays between 2023-09-01 and 2023-09-11 = 6
Weekdays between 2023-09-02 and 2023-09-12 = 7
Weekdays between 2023-09-03 and 2023-09-13 = 8
Weekdays between 2023-09-04 and 2023-09-14 = 8

The trigger value in the queries (MySQL and SQLite) needs to be reduced from 7 to 6. Anything below 6 means there is an imminent gap.

A pull request has been generated to correct this.

The algorithm seems to be to look forward 10 days and count the number of shows in that time. If it is less than the minimum possible, then there's a gap within that period and the "Call for shows" message needs to be displayed. The original algorithm is wrong; the alert message is displayed when there are 25 days to the next free slot! It's not entirely obvious how many weekdays (Mon-Fri) there are in a random set of 10 days. A small Perl script was written to sample this and the results were: ``` $ ./count_weekdays Weekdays between 2023-08-25 and 2023-09-04 = 6 Weekdays between 2023-08-26 and 2023-09-05 = 7 Weekdays between 2023-08-27 and 2023-09-06 = 8 Weekdays between 2023-08-28 and 2023-09-07 = 8 Weekdays between 2023-08-29 and 2023-09-08 = 8 Weekdays between 2023-08-30 and 2023-09-09 = 7 Weekdays between 2023-08-31 and 2023-09-10 = 6 Weekdays between 2023-09-01 and 2023-09-11 = 6 Weekdays between 2023-09-02 and 2023-09-12 = 7 Weekdays between 2023-09-03 and 2023-09-13 = 8 Weekdays between 2023-09-04 and 2023-09-14 = 8 ``` The trigger value in the queries (MySQL and SQLite) needs to be reduced from 7 to 6. Anything below 6 means there is an imminent gap. A pull request has been generated to correct this.
davmo commented 2023-08-27 17:22:13 +00:00
Author
Collaborator
Copy Link

Pull request merged.

Closing the issue.

Pull request merged. Closing the issue.
davmo closed this issue 2023-08-27 17:22:13 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
167_Several_templates_use_non-existent_absolute_url
I145_Various_bug_fixes
I123_Future_episodes_are_not_being_produced
I30-Series_name_for_filename
2023-03
2023-02
Labels
Clear labels   
Bug Found

For issues related to the code or the content of the created HTML files

  
Feature Request

   
General Discussion

For discussing HPR site generation in general

  
Help Request

For issues running or installing the site-generator

No Label
Bug Found
Feature Request
General Discussion
Help Request
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rho_n/hpr_generator#160
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?