CyberCoveLLC/threshold-plugin-aws
1
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #5 from hashicorp/vancluever-remove-testing-todo

Browse Source 
plugin: Remove TODO from E2E test covering rotated -> not rotated
This commit is contained in:
Chris Marchesi authored and GitHub committed 2021-11-16 09:39:52 -08:00
2 parents 756bc0960a 38bcd34baf
commit 85626c6dd4
1 file changed
+3 -5
Download Patch File Download Diff File Expand all files Collapse all files
plugin/e2e_test.go
+3 -5
View File
@@ -358,11 +358,9 @@ func testPluginOnUpdateCatalog(
case newAccessKeyId == "" && rotated && !rotate:
// No new credentials have been provided, and we have previously
// rotated the credentials. This is actually an error.
//
// TODO: validate this scenario through unit testing. For now if
// we for some reason try to test this with this function, return
// an error.
// rotated the credentials. This is actually an error, but we
// don't test it here; it's covered in unit testing (see
// plugin_test.go).
require.FailNow("testing rotated-to-not-rotated scenario not implemented by this helper")
case newAccessKeyId == "" && !rotated && rotate: