Merge pull request #824 from hashicorp/tweak-toolbar

Tweak toolbar

addons/core/translations/actions/en-us.yaml

@@ -35,5 +35,3 @@ close: Close
 toggle-secret: Toggle secret visibility
 minimize: Minimize
 fullscreen: Fullscreen
-filter: 
- status: status

addons/rose/addon/components/rose/toolbar/index.js

@@ -1,8 +0,0 @@
-import Component from '@glimmer/component';
-import { generateComponentID } from '../../../utilities/component-auto-id';
-
-export default class RoseToolbarComponent extends Component {
-  // =attributes
-
-  id = generateComponentID();
-}

addons/rose/tests/integration/components/rose/toolbar-test.js

@@ -7,12 +7,13 @@ module('Integration | Component | rose/toolbar', function (hooks) {
   setupRenderingTest(hooks);
 
   test('it renders', async function (assert) {
+    assert.expect(1);
     await render(hbs`<Rose::Toolbar />`);
-    assert.ok(find('div'));
     assert.ok(find('.rose-toolbar'));
   });
 
   test('it renders with attributes', async function (assert) {
+    assert.expect(1);
     await render(hbs`<Rose::Toolbar id="toolbar"/>`);
     assert.ok(find('#toolbar'));
   });

ui/admin/app/templates/scopes/scope/sessions/index.hbs

@@ -17,25 +17,23 @@
     {{#if @model}}
       {{#if (feature-flag 'filter')}}
         <Rose::Toolbar>
-          <Rose::Form class='full-width' as |form|>
-            <section>
-              <Rose::Dropdown
-                @text={{t 'actions.filter.status'}}
-                @ignoreClickInside={{true}}
-                as |dropdown|
-              >
-                <form.checkboxGroup @name='status' as |checkboxGroup|>
-                  {{#each this.availableSessions as |session|}}
-                    <dropdown.item>
-                      <checkboxGroup.checkbox
-                        @checked={{session.isCancelable}}
-                        @label={{session.status}}
-                      />
-                    </dropdown.item>
-                  {{/each}}
-                </form.checkboxGroup>
-              </Rose::Dropdown>
-            </section>
+          <Rose::Form as |form|>
+            <Rose::Dropdown
+              @text={{t 'form.status.label'}}
+              @ignoreClickInside={{true}}
+              as |dropdown|
+            >
+              <form.checkboxGroup @name='status' as |checkboxGroup|>
+                {{#each this.availableSessions as |session|}}
+                  <dropdown.item>
+                    <checkboxGroup.checkbox
+                      @checked={{session.isCancelable}}
+                      @label={{session.status}}
+                    />
+                  </dropdown.item>
+                {{/each}}
+              </form.checkboxGroup>
+            </Rose::Dropdown>
           </Rose::Form>
         </Rose::Toolbar>
       {{/if}}

yarn.lock

@@ -7670,7 +7670,7 @@ caniuse-api@^3.0.0:
     lodash.memoize "^4.1.2"
     lodash.uniq "^4.5.0"
 
-caniuse-lite@^1.0.0, caniuse-lite@^1.0.30001109, caniuse-lite@^1.0.30001157, caniuse-lite@^1.0.30001271:
+caniuse-lite@^1.0.0, caniuse-lite@^1.0.30001109, caniuse-lite@^1.0.30001157, caniuse-lite@^1.0.30001265:
   version "1.0.30001271"
   resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001271.tgz#0dda0c9bcae2cf5407cd34cac304186616cc83e8"
   integrity sha512-BBruZFWmt3HFdVPS8kceTBIguKxu4f99n5JNp06OlPD/luoAMIaIK5ieV5YjnBLH3Nysai9sxj9rpJj4ZisXOA==
@@ -9510,10 +9510,10 @@ electron-rebuild@^2.0.3:
     tar "^6.0.5"
     yargs "^16.0.0"
 
-electron-to-chromium@^1.3.878:
-  version "1.3.878"
-  resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.878.tgz#baa9fb5c24b9b580f08fb245cbb52a22f8fc8fa8"
-  integrity sha512-O6yxWCN9ph2AdspAIszBnd9v8s11hQx8ub9w4UGApzmNRnoKhbulOWqbO8THEQec/aEHtvy+donHZMlh6l1rbA==
+electron-to-chromium@^1.3.867:
+  version "1.3.883"
+  resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.883.tgz#cc409921469b3aa6ab6efd65cc2a4375128bb703"
+  integrity sha512-goyjNx4wB9j911PBteb+AXNbErug7rJVkmDXWdw5SCVn2JlARBwsqucPkvp1h5mXWxHUbBRK3bwXTrqSxSiAIQ==
 
 element-resize-detector@^1.2.2:
   version "1.2.3"
@@ -17059,7 +17059,7 @@ node-pre-gyp@^0.11.0:
     semver "^5.3.0"
     tar "^4"
 
-node-releases@^2.0.1:
+node-releases@^2.0.0:
   version "2.0.1"
   resolved "https://registry.yarnpkg.com/node-releases/-/node-releases-2.0.1.tgz#3d1d395f204f1f2f29a54358b9fb678765ad2fc5"
   integrity sha512-CqyzN6z7Q6aMeF/ktcMVTzhAHCEpf8SOarwpzpf8pNBY2k5/oM34UHldUwp8VKI7uxct2HxSRdJjBaZeESzcxA==