refactor: 💡 convert message component to nested structure

This commit is contained in:
Randall Morey committed 2020-09-24 12:56:45 -04:00
1 parent fa8353e90e
commit 644a4db908
6 files changed
+10 -14

No files matched your search

@@ -1,7 +0,0 @@
import Component from '@ember/component';
import layout from '../../templates/components/rose/message';
export default Component.extend({
layout,
tagName: '',
});
@@ -0,0 +1,3 @@
import Component from '@glimmer/component';
export default class RoseMessageComponent extends Component {}
+1 -1
View File
@@ -1,6 +1,6 @@
<Rose::Message
@title={{t (concat "errors." this.messageCode ".title")}}
@subtitle={{concat (t "errors.generic.title") " " this.status}}
@subtitle={{concat (t "errors.generic.title") " " @status}}
@icon={{this.icon}}
as |message|>
<message.description>{{t (concat "errors." this.messageCode ".description")}}</message.description>
+6 -6
View File
@@ -1,4 +1,4 @@
import Message from 'rose/components/rose/message';
import MessageComponent from 'rose/components/rose/message';
import { computed } from '@ember/object';
/*
@@ -17,16 +17,16 @@ import { computed } from '@ember/object';
const statuses = ['401', '403', '404', '500'];
export default class ErrorMessageComponent extends Message {
export default class ErrorMessageComponent extends MessageComponent {
// =methods
/**
* Returns an icon for error status.
* @return {string}
*/
@computed('status')
@computed('args.status')
get icon() {
switch (this.status) {
switch (this.args.status) {
case '401':
case '403':
return 'disabled';
@@ -51,9 +51,9 @@ export default class ErrorMessageComponent extends Message {
* isn't part of predefined statuses.
* @return {string}
*/
@computed('status')
@computed('args.status')
get messageCode() {
let messageCode = this.status;
let messageCode = this.args.status;
if(!statuses.includes(messageCode)) messageCode = 'unknown';
return messageCode;
}