refact: RegisterUpstreamMessageHandler stop returning dup err

Stop returning an error if RegisterUpstreamMessageHandler is called
multiple times, since it provides little/no value and creates
invalid errors when more than one test controller is started across
all the unit tests.
This commit is contained in:
Jim authored and Timothy Messier committed 2023-05-31 12:18:10 +00:00
1 parent ff9b3b0873
commit 9f01e1b3c1
1 file changed
+1 -4
@@ -55,10 +55,7 @@ func RegisterUpstreamMessageHandler(ctx context.Context, msgType pbs.MsgType, h
case util.IsNil(h):
return errors.New(ctx, errors.InvalidParameter, op, "missing handler")
}
if _, loaded := upstreamMessageHandler.LoadOrStore(msgType, h); loaded {
return errors.New(ctx, errors.InvalidParameter, op, "handler already registered for msg type")
}
upstreamMessageHandler.Store(msgType, h)
return nil
}