cloud-hosting-platform/cloud-apache-container
6
0 Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(pkg-cache): no | while read pipelines under pipefail (Shell-Checks) #32

Merged
jknapp merged 1 commits from fix/pkg-cache-shellcheck-pipefail into trunk 2026-10-21 23:48:22 +00:00
Conversation 0 Commits 1 Files Changed 1
+6 -2
jknapp commented 2026-10-21 23:48:18 +00:00
Owner
Copy link
Copy source

Shell-Checks on cb0cecb (PR #31) failed its structural scan on two cmd | while read loops in scripts/pkg-cache-repos.sh. This reads the lists with mapfile from a process substitution instead, so there is no pipeline.

Verified locally:

  • scripts/tests/lsphp-info-probe.test.sh passes 36/0.
  • shellcheck -S warning is clean.
  • In an AL10 container the restore tests behave as before: a new cache-referencing file is removed, and a leftover reference fails with FATAL.

🤖 Generated with Claude Code

Shell-Checks on cb0cecb (PR #31) failed its structural scan on two `cmd | while read` loops in `scripts/pkg-cache-repos.sh`. This reads the lists with `mapfile` from a process substitution instead, so there is no pipeline. Verified locally: - `scripts/tests/lsphp-info-probe.test.sh` passes 36/0. - `shellcheck -S warning` is clean. - In an AL10 container the restore tests behave as before: a new cache-referencing file is removed, and a leftover reference fails with FATAL. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
jknapp added 1 commit 2026-10-21 23:48:18 +00:00
fix(pkg-cache): no | while read pipelines under pipefail 472fdcbc4d 
Shell-Checks' structural scan (scripts/tests/lsphp-info-probe.test.sh)
flagged two `cmd | while read` loops in pkg-cache-repos.sh restore.
Read the lists with mapfile from a process substitution instead, so
there is no pipeline. The test now passes locally (36/0), shellcheck is
clean, and the restore tests (new cache-referencing file removed,
leftover reference -> FATAL) behave as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jknapp merged commit fc60ac5ef3 into trunk 2026-10-21 23:48:22 +00:00
jknapp deleted branch fix/pkg-cache-shellcheck-pipefail 2026-10-21 23:48:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hub-agent Bot jknapp renovate-bot (Renovate Bot) whmcs-sam whp-cicd-user whp-deploy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cloud-hosting-platform/cloud-apache-container#32