Compare commits
63
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
69e61ab4b2 | ||
|
|
3dd6b54a35 | ||
|
|
d7eeff3a68 | ||
|
|
f43a1ef872 | ||
|
|
fd7f883d6a | ||
|
|
4cfcccd272 | ||
|
|
024f9fdd46 | ||
|
|
fc8918c1f9 | ||
|
|
9be71e8fd1 | ||
|
|
aba0d187d7 | ||
|
|
1a01834068 | ||
|
|
bfcf6278e9 | ||
|
|
e5fd74d63d | ||
|
|
cf38fdb245 | ||
|
|
2438777462 | ||
|
|
f9561c8c54 | ||
|
|
f30fc6efec | ||
|
|
eb4290a45e | ||
|
|
38c8d22e5d | ||
|
|
9885b37af5 | ||
|
|
86aacbe1a8 | ||
|
|
f0a1508acd | ||
|
|
66db1db507 | ||
|
|
b670b436c3 | ||
|
|
d89930e218 | ||
|
|
45ee004672 | ||
|
|
536e4e9f86 | ||
|
|
51f3fe81b6 | ||
|
|
321a193b83 | ||
|
|
4ac57e1c4c | ||
|
|
0d0d722dd7 | ||
|
|
a30e82accf | ||
|
|
6791345f77 | ||
|
|
fb68fa6485 | ||
|
|
c6840db0bb | ||
|
|
f5d2a23a5f | ||
|
|
c712a69c4a | ||
|
|
d460e8ac33 | ||
|
|
2b1569202a | ||
|
|
5c44dd545c | ||
|
|
2ac62c4e9e | ||
|
|
25dfcbb725 | ||
|
|
9bf78fd72d | ||
|
|
2dcc2b4d21 | ||
|
|
4e0fc78a30 | ||
|
|
85dfe181aa | ||
|
|
a698f014b0 | ||
|
|
204ea5e078 | ||
|
|
0291ddce9a | ||
|
|
f7da654c11 | ||
|
|
d6666f6f79 | ||
|
|
4a426e3513 | ||
|
|
6e628d68dd | ||
|
|
8f17b74e2b | ||
|
|
8bf525c600 | ||
|
|
d07bc7789d | ||
|
|
b03425ac39 | ||
|
|
9750a6c2bf | ||
|
|
5b19ae97af | ||
|
|
88df4f2888 | ||
|
|
e1b4ab735c | ||
|
|
ff1e8fc096 | ||
|
|
0419291259 |
+1
-1
@@ -2,7 +2,7 @@
|
|||||||
|
|
||||||
## Overview
|
## Overview
|
||||||
|
|
||||||
This site builder integrates with WHP (Web Hosting Panel) to provide users with a visual site building interface. Users can create HTML pages using a drag-and-drop editor and save them directly to their web hosting account.
|
This site builder integrates with WHP (Web Hosting Platform) to provide users with a visual site building interface. Users can create HTML pages using a drag-and-drop editor and save them directly to their web hosting account.
|
||||||
|
|
||||||
## Architecture
|
## Architecture
|
||||||
|
|
||||||
|
|||||||
@@ -52,3 +52,69 @@ describe('ButtonLink.toHtml text escaping (attacker-controlled `text` prop)', ()
|
|||||||
expect(html).toContain('>Click Me</a>');
|
expect(html).toContain('>Click Me</a>');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('ButtonLink.toHtml hover state (scoped <style> block)', () => {
|
||||||
|
test('no hover props -- no <style> block, no class added', () => {
|
||||||
|
const { html } = toHtml({ href: '#', text: 'x' }, '', 'node-1');
|
||||||
|
expect(html).not.toContain('<style>');
|
||||||
|
expect(html).not.toContain('class=');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('hoverBg/hoverColor emit a scoped :hover rule scoped to the node id', () => {
|
||||||
|
const { html } = toHtml({ href: '#', text: 'x', hoverBg: '#111111', hoverColor: '#eeeeee' }, '', 'node-42');
|
||||||
|
expect(html).toMatch(/<style>\.btn_[a-z0-9]+:hover\{background-color:#111111;color:#eeeeee\}<\/style>/);
|
||||||
|
expect(html).toMatch(/class="btn_[a-z0-9]+"/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('two different node ids produce different scope classes (no collision)', () => {
|
||||||
|
const a = toHtml({ href: '#', text: 'x', hoverBg: '#111111' }, '', 'node-a').html;
|
||||||
|
const b = toHtml({ href: '#', text: 'x', hoverBg: '#111111' }, '', 'node-b').html;
|
||||||
|
const scopeOf = (html: string) => html.match(/btn_[a-z0-9]+/)?.[0];
|
||||||
|
expect(scopeOf(a)).toBeTruthy();
|
||||||
|
expect(scopeOf(a)).not.toBe(scopeOf(b));
|
||||||
|
});
|
||||||
|
|
||||||
|
test('an XSS breakout attempt in hoverBg cannot close the <style> element', () => {
|
||||||
|
const malicious = '</style><script>alert(1)</script>';
|
||||||
|
const { html } = toHtml({ href: '#', text: 'x', hoverBg: malicious }, '', 'node-1');
|
||||||
|
expect(html).not.toContain('</style><script>');
|
||||||
|
expect(html).not.toContain('<script>alert(1)</script>');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a rule-breakout attempt in hoverColor cannot inject a second selector/rule', () => {
|
||||||
|
const malicious = 'red;}body{background:red';
|
||||||
|
const { html } = toHtml({ href: '#', text: 'x', hoverColor: malicious }, '', 'node-1');
|
||||||
|
expect(html).not.toContain('}body{');
|
||||||
|
expect(html).not.toContain(';}');
|
||||||
|
// The whole export is still exactly one <style> element -- no new rule
|
||||||
|
// or element was opened by the malicious value.
|
||||||
|
expect((html.match(/<style>/g) || []).length).toBe(1);
|
||||||
|
expect((html.match(/<\/style>/g) || []).length).toBe(1);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('ButtonLink.craft.props exposes target + hover + box-model + animation/visibility', () => {
|
||||||
|
test('target defaults to _self, hoverBg/hoverColor blank', () => {
|
||||||
|
const props = (ButtonLink as any).craft.props;
|
||||||
|
expect(props.target).toBe('_self');
|
||||||
|
expect(props.hoverBg).toBe('');
|
||||||
|
expect(props.hoverColor).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
||||||
|
const props = (ButtonLink as any).craft.props;
|
||||||
|
expect(props.animation).toBe('');
|
||||||
|
expect(props.animationDelay).toBe('0');
|
||||||
|
expect(props.hideOnDesktop).toBe(false);
|
||||||
|
expect(props.hideOnTablet).toBe(false);
|
||||||
|
expect(props.hideOnMobile).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style carries blank/default box-model keys', () => {
|
||||||
|
const style = (ButtonLink as any).craft.props.style;
|
||||||
|
expect(style).toHaveProperty('marginTop');
|
||||||
|
expect(style.border).toBe('none');
|
||||||
|
expect(style.boxShadow).toBe('none');
|
||||||
|
expect(style.opacity).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -1,13 +1,24 @@
|
|||||||
import React, { CSSProperties } from 'react';
|
import React, { CSSProperties } from 'react';
|
||||||
import { useNode, UserComponent } from '@craftjs/core';
|
import { useNode, UserComponent } from '@craftjs/core';
|
||||||
import { cssPropsToString } from '../../utils/style-helpers';
|
import { cssPropsToString } from '../../utils/style-helpers';
|
||||||
import { escapeHtml, escapeAttr, safeUrl } from '../../utils/escape';
|
import { escapeHtml, escapeAttr, safeUrl, cssValue, scopeId } from '../../utils/escape';
|
||||||
|
|
||||||
interface ButtonLinkProps {
|
interface ButtonLinkProps {
|
||||||
text?: string;
|
text?: string;
|
||||||
href?: string;
|
href?: string;
|
||||||
target?: '_self' | '_blank';
|
target?: '_self' | '_blank';
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
/** Background color applied on `:hover` via a scoped `<style>` block
|
||||||
|
* (editor preview does not show hover state -- only the published
|
||||||
|
* export). Blank means "no hover background override". */
|
||||||
|
hoverBg?: string;
|
||||||
|
/** Text color applied on `:hover`, same scoped `<style>` block. */
|
||||||
|
hoverColor?: string;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const ButtonLink: UserComponent<ButtonLinkProps> = ({
|
export const ButtonLink: UserComponent<ButtonLinkProps> = ({
|
||||||
@@ -15,6 +26,8 @@ export const ButtonLink: UserComponent<ButtonLinkProps> = ({
|
|||||||
href = '#',
|
href = '#',
|
||||||
target = '_self',
|
target = '_self',
|
||||||
style = {},
|
style = {},
|
||||||
|
hoverBg = '',
|
||||||
|
hoverColor = '',
|
||||||
}) => {
|
}) => {
|
||||||
const {
|
const {
|
||||||
connectors: { connect, drag },
|
connectors: { connect, drag },
|
||||||
@@ -23,6 +36,8 @@ export const ButtonLink: UserComponent<ButtonLinkProps> = ({
|
|||||||
selected: node.events.selected,
|
selected: node.events.selected,
|
||||||
}));
|
}));
|
||||||
|
|
||||||
|
const [hovered, setHovered] = React.useState(false);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<a
|
<a
|
||||||
ref={(ref: HTMLAnchorElement | null) => { if (ref) connect(drag(ref)); }}
|
ref={(ref: HTMLAnchorElement | null) => { if (ref) connect(drag(ref)); }}
|
||||||
@@ -32,12 +47,16 @@ export const ButtonLink: UserComponent<ButtonLinkProps> = ({
|
|||||||
// Prevent navigation inside editor
|
// Prevent navigation inside editor
|
||||||
e.preventDefault();
|
e.preventDefault();
|
||||||
}}
|
}}
|
||||||
|
onMouseEnter={() => setHovered(true)}
|
||||||
|
onMouseLeave={() => setHovered(false)}
|
||||||
style={{
|
style={{
|
||||||
display: 'inline-block',
|
display: 'inline-block',
|
||||||
textDecoration: 'none',
|
textDecoration: 'none',
|
||||||
cursor: 'pointer',
|
cursor: 'pointer',
|
||||||
outline: selected ? '2px solid #3b82f6' : 'none',
|
outline: selected ? '2px solid #3b82f6' : 'none',
|
||||||
...style,
|
...style,
|
||||||
|
...(hovered && hoverBg ? { backgroundColor: hoverBg } : {}),
|
||||||
|
...(hovered && hoverColor ? { color: hoverColor } : {}),
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
{text}
|
{text}
|
||||||
@@ -53,6 +72,8 @@ ButtonLink.craft = {
|
|||||||
text: 'Click Me',
|
text: 'Click Me',
|
||||||
href: '#',
|
href: '#',
|
||||||
target: '_self',
|
target: '_self',
|
||||||
|
hoverBg: '',
|
||||||
|
hoverColor: '',
|
||||||
style: {
|
style: {
|
||||||
backgroundColor: '#3b82f6',
|
backgroundColor: '#3b82f6',
|
||||||
color: '#ffffff',
|
color: '#ffffff',
|
||||||
@@ -61,7 +82,15 @@ ButtonLink.craft = {
|
|||||||
fontWeight: '600',
|
fontWeight: '600',
|
||||||
fontSize: '16px',
|
fontSize: '16px',
|
||||||
border: 'none',
|
border: 'none',
|
||||||
|
marginTop: '', marginRight: '', marginBottom: '', marginLeft: '',
|
||||||
|
boxShadow: 'none',
|
||||||
|
opacity: '1',
|
||||||
},
|
},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '0',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
@@ -72,7 +101,7 @@ ButtonLink.craft = {
|
|||||||
|
|
||||||
/* ---------- HTML export ---------- */
|
/* ---------- HTML export ---------- */
|
||||||
|
|
||||||
(ButtonLink as any).toHtml = (props: ButtonLinkProps, _childrenHtml: string) => {
|
(ButtonLink as any).toHtml = (props: ButtonLinkProps, _childrenHtml: string, nodeId?: string) => {
|
||||||
const styleStr = cssPropsToString({
|
const styleStr = cssPropsToString({
|
||||||
display: 'inline-block',
|
display: 'inline-block',
|
||||||
textDecoration: 'none',
|
textDecoration: 'none',
|
||||||
@@ -80,7 +109,28 @@ ButtonLink.craft = {
|
|||||||
});
|
});
|
||||||
const escapedText = escapeHtml(props.text || '');
|
const escapedText = escapeHtml(props.text || '');
|
||||||
const targetAttr = props.target === '_blank' ? ' target="_blank" rel="noopener noreferrer"' : '';
|
const targetAttr = props.target === '_blank' ? ' target="_blank" rel="noopener noreferrer"' : '';
|
||||||
|
|
||||||
|
// Scoped hover style -- same pattern as Navbar/Menu: a deterministic,
|
||||||
|
// per-node class (via scopeId) avoids two ButtonLink instances on the
|
||||||
|
// same page colliding on a shared `.btn-link:hover` rule. hoverBg/
|
||||||
|
// hoverColor are sanitized through cssValue -- they land inside a
|
||||||
|
// `<style>` element, the worst-case XSS sink (an unescaped `<`/`>` or
|
||||||
|
// `{`/`}` could close the rule/element and open a `<script>`).
|
||||||
|
const hoverBg = cssValue(props.hoverBg);
|
||||||
|
const hoverColor = cssValue(props.hoverColor);
|
||||||
|
let hoverCss = '';
|
||||||
|
let cls = '';
|
||||||
|
if (hoverBg || hoverColor) {
|
||||||
|
const scope = scopeId(nodeId, (props.href || '') + (props.text || ''), 'btn');
|
||||||
|
cls = ` class="${scope}"`;
|
||||||
|
const decls = [
|
||||||
|
hoverBg ? `background-color:${hoverBg}` : '',
|
||||||
|
hoverColor ? `color:${hoverColor}` : '',
|
||||||
|
].filter(Boolean).join(';');
|
||||||
|
hoverCss = `<style>.${scope}:hover{${decls}}</style>`;
|
||||||
|
}
|
||||||
|
|
||||||
return {
|
return {
|
||||||
html: `<a href="${escapeAttr(safeUrl(props.href || '#'))}"${targetAttr}${styleStr ? ` style="${styleStr}"` : ''}>${escapedText}</a>`,
|
html: `${hoverCss}<a href="${escapeAttr(safeUrl(props.href || '#'))}"${targetAttr}${cls}${styleStr ? ` style="${styleStr}"` : ''}>${escapedText}</a>`,
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -56,3 +56,54 @@ describe('Heading.toHtml text escaping (attacker-controlled `text` prop)', () =>
|
|||||||
expect(html).toBe('<h2>Hello world</h2>');
|
expect(html).toBe('<h2>Hello world</h2>');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('Heading.toHtml typography depth (line-height/letter-spacing/transform/style/decoration)', () => {
|
||||||
|
test('line-height, letter-spacing, text-transform all flow into the style attribute', () => {
|
||||||
|
const { html } = toHtml({
|
||||||
|
text: 'x',
|
||||||
|
level: 'h2',
|
||||||
|
style: { lineHeight: '1.25', letterSpacing: '0.05em', textTransform: 'uppercase' },
|
||||||
|
}, '');
|
||||||
|
expect(html).toContain('line-height:1.25');
|
||||||
|
expect(html).toContain('letter-spacing:0.05em');
|
||||||
|
expect(html).toContain('text-transform:uppercase');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('italic + underline toggles emit font-style and text-decoration', () => {
|
||||||
|
const { html } = toHtml({
|
||||||
|
text: 'x',
|
||||||
|
level: 'h2',
|
||||||
|
style: { fontStyle: 'italic', textDecoration: 'underline' },
|
||||||
|
}, '');
|
||||||
|
expect(html).toContain('font-style:italic');
|
||||||
|
expect(html).toContain('text-decoration:underline');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a custom font-size (not one of the presets) still flows through', () => {
|
||||||
|
const { html } = toHtml({ text: 'x', level: 'h2', style: { fontSize: '42px' } }, '');
|
||||||
|
expect(html).toContain('font-size:42px');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Heading.craft.props exposes the box-model + animation/visibility rollout', () => {
|
||||||
|
test('animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
||||||
|
const props = (Heading as any).craft.props;
|
||||||
|
expect(props.animation).toBe('');
|
||||||
|
expect(props.animationDelay).toBe('0');
|
||||||
|
expect(props.hideOnDesktop).toBe(false);
|
||||||
|
expect(props.hideOnTablet).toBe(false);
|
||||||
|
expect(props.hideOnMobile).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style carries blank/default box-model + typography-depth keys', () => {
|
||||||
|
const style = (Heading as any).craft.props.style;
|
||||||
|
expect(style).toHaveProperty('marginTop');
|
||||||
|
expect(style).toHaveProperty('paddingTop');
|
||||||
|
expect(style).toHaveProperty('lineHeight');
|
||||||
|
expect(style).toHaveProperty('letterSpacing');
|
||||||
|
expect(style).toHaveProperty('textTransform');
|
||||||
|
expect(style.border).toBe('none');
|
||||||
|
expect(style.boxShadow).toBe('none');
|
||||||
|
expect(style.opacity).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -100,7 +100,22 @@ Heading.craft = {
|
|||||||
fontFamily: 'Inter, sans-serif',
|
fontFamily: 'Inter, sans-serif',
|
||||||
color: '#1f2937',
|
color: '#1f2937',
|
||||||
marginBottom: '16px',
|
marginBottom: '16px',
|
||||||
|
lineHeight: '',
|
||||||
|
letterSpacing: '',
|
||||||
|
textTransform: '' as CSSProperties['textTransform'],
|
||||||
|
fontStyle: '' as CSSProperties['fontStyle'],
|
||||||
|
textDecoration: '',
|
||||||
|
marginTop: '', marginRight: '', marginLeft: '',
|
||||||
|
paddingTop: '', paddingRight: '', paddingBottom: '', paddingLeft: '',
|
||||||
|
border: 'none',
|
||||||
|
boxShadow: 'none',
|
||||||
|
opacity: '1',
|
||||||
},
|
},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '0',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -0,0 +1,51 @@
|
|||||||
|
import { describe, test, expect, vi } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
|
||||||
|
vi.mock('@craftjs/core', () => ({
|
||||||
|
useNode: (collect?: (node: any) => any) => {
|
||||||
|
const node = { events: { selected: false } };
|
||||||
|
return {
|
||||||
|
connectors: { connect: (el: any) => el, drag: (el: any) => el },
|
||||||
|
actions: { setProp: vi.fn() },
|
||||||
|
...(collect ? collect(node) : {}),
|
||||||
|
};
|
||||||
|
},
|
||||||
|
}));
|
||||||
|
|
||||||
|
import { HtmlBlock } from './HtmlBlock';
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
|
||||||
|
function render(ui: React.ReactElement) {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(ui);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('HtmlBlock render ignores the style prop (matches toHtml)', () => {
|
||||||
|
test('a stored backgroundColor/color/padding is NOT applied to the wrapper', () => {
|
||||||
|
render(
|
||||||
|
React.createElement(HtmlBlock as any, {
|
||||||
|
code: '<p>hello</p>',
|
||||||
|
style: { backgroundColor: 'rgb(255, 0, 0)', color: 'rgb(0, 0, 255)', padding: '40px' },
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
const wrapper = container.firstElementChild as HTMLElement;
|
||||||
|
expect(wrapper.style.backgroundColor).toBe('');
|
||||||
|
expect(wrapper.style.color).toBe('');
|
||||||
|
expect(wrapper.style.padding).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the editor affordances survive: minHeight is kept, content still renders', () => {
|
||||||
|
render(React.createElement(HtmlBlock as any, { code: '<p>hello</p>', style: {} }));
|
||||||
|
const wrapper = container.firstElementChild as HTMLElement;
|
||||||
|
expect(wrapper.style.minHeight).toBe('40px');
|
||||||
|
expect(wrapper.innerHTML).toContain('hello');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -22,6 +22,41 @@ describe('purifyHtml', () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('purifyHtml markup path (C1 review finding)', () => {
|
||||||
|
test('a style attribute survives sanitization (colour picker output must not be silently dropped)', () => {
|
||||||
|
const out = purifyHtml('<p style="color: #ff0000">red text</p>');
|
||||||
|
expect(out).toBe('<p style="color: #ff0000">red text</p>');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('an id attribute survives sanitization (anchor targets)', () => {
|
||||||
|
const out = purifyHtml('<a href="#section" id="section">link</a>');
|
||||||
|
expect(out).toContain('id="section"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a pasted table survives sanitization', () => {
|
||||||
|
const input = '<table><thead><tr><th>Head</th></tr></thead><tbody><tr><td>Cell</td></tr></tbody></table>';
|
||||||
|
expect(purifyHtml(input)).toBe(input);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('script tags still do not survive alongside a style attribute', () => {
|
||||||
|
const out = purifyHtml('<p style="color:#ff0000">ok</p><script>alert(1)</script>');
|
||||||
|
expect(out).not.toContain('<script');
|
||||||
|
expect(out).toContain('style="color:#ff0000"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('on* handlers still do not survive on an element that also carries style', () => {
|
||||||
|
const out = purifyHtml('<p style="color:#ff0000" onclick="bad()">x</p>');
|
||||||
|
expect(out).not.toContain('onclick');
|
||||||
|
expect(out).toContain('style="color:#ff0000"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('javascript: URLs still do not survive on an element that also carries style', () => {
|
||||||
|
const out = purifyHtml('<a style="color:#ff0000" href="javascript:void(0)">x</a>');
|
||||||
|
expect(out).not.toContain('javascript:');
|
||||||
|
expect(out).toContain('style="color:#ff0000"');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe('purifyHtml iframe sandboxing (M-6)', () => {
|
describe('purifyHtml iframe sandboxing (M-6)', () => {
|
||||||
test('forces a restrictive sandbox attribute onto every iframe', () => {
|
test('forces a restrictive sandbox attribute onto every iframe', () => {
|
||||||
const out = purifyHtml('<iframe src="https://example.com/"></iframe>');
|
const out = purifyHtml('<iframe src="https://example.com/"></iframe>');
|
||||||
|
|||||||
@@ -23,3 +23,26 @@ describe('HtmlBlock.toHtml sanitizes raw code (A4.1)', () => {
|
|||||||
expect(html).toBe('<p>hi</p>');
|
expect(html).toBe('<p>hi</p>');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('toHtml never emits the style prop (the other half of the render/export contract)', () => {
|
||||||
|
const out = (HtmlBlock as any).toHtml(
|
||||||
|
{ code: '<p>hi</p>', style: { backgroundColor: '#ff0000', padding: '40px' } },
|
||||||
|
'',
|
||||||
|
);
|
||||||
|
expect(out.html).toBe('<p>hi</p>');
|
||||||
|
expect(out.html).not.toContain('background');
|
||||||
|
expect(out.html).not.toContain('40px');
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('HtmlBlock.toHtml markup path (C1 review finding)', () => {
|
||||||
|
test('a style attribute inside `code` (e.g. from the toolbar colour picker) reaches exported output', () => {
|
||||||
|
const { html } = toHtml({ code: '<p style="color: #ff0000">red text</p>' }, '');
|
||||||
|
expect(html).toBe('<p style="color: #ff0000">red text</p>');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a table inside `code` reaches exported output', () => {
|
||||||
|
const code = '<table><tbody><tr><td>Cell</td></tr></tbody></table>';
|
||||||
|
const { html } = toHtml({ code }, '');
|
||||||
|
expect(html).toBe(code);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -19,10 +19,17 @@ const PURIFY_CONFIG = {
|
|||||||
'blockquote','code','pre',
|
'blockquote','code','pre',
|
||||||
'img','figure','figcaption',
|
'img','figure','figcaption',
|
||||||
'iframe',
|
'iframe',
|
||||||
|
// Tables: pasted content commonly includes these; dropping them
|
||||||
|
// silently ate customer-pasted tables (see C1 review finding).
|
||||||
|
'table','thead','tbody','tfoot','tr','td','th','caption','colgroup','col',
|
||||||
],
|
],
|
||||||
|
// NOTE: supplying ALLOWED_ATTR replaces DOMPurify's own default attribute
|
||||||
|
// allowlist rather than extending it, so anything the product needs
|
||||||
|
// (style, id, ...) must be listed explicitly here even though DOMPurify
|
||||||
|
// would allow it by default.
|
||||||
ALLOWED_ATTR: [
|
ALLOWED_ATTR: [
|
||||||
'href','src','alt','title','target','rel',
|
'href','src','alt','title','target','rel',
|
||||||
'width','height','class',
|
'width','height','class','id','style',
|
||||||
'allowfullscreen','allow','frameborder',
|
'allowfullscreen','allow','frameborder',
|
||||||
'sandbox','referrerpolicy',
|
'sandbox','referrerpolicy',
|
||||||
],
|
],
|
||||||
@@ -62,16 +69,21 @@ export function purifyHtml(input: string): string {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
export const HtmlBlock: UserComponent<HtmlBlockProps> = ({ code = '', style = {} }) => {
|
export const HtmlBlock: UserComponent<HtmlBlockProps> = ({ code = '' }) => {
|
||||||
const { connectors: { connect, drag }, selected } = useNode((node) => ({ selected: node.events.selected }));
|
const { connectors: { connect, drag }, selected } = useNode((node) => ({ selected: node.events.selected }));
|
||||||
const clean = useMemo(() => purifyHtml(code), [code]);
|
const clean = useMemo(() => purifyHtml(code), [code]);
|
||||||
const setRef = (ref: HTMLElement | null): void => { if (ref) connect(drag(ref)); };
|
const setRef = (ref: HTMLElement | null): void => { if (ref) connect(drag(ref)); };
|
||||||
|
// The `style` prop is deliberately NOT applied. `toHtml()` emits only the
|
||||||
|
// purified `code`, so anything styled here would show in the editor and
|
||||||
|
// vanish on the live page -- the exact bug this block was reported for.
|
||||||
|
// Wrapper styling belongs in the user's own markup (see the Edit HTML
|
||||||
|
// toolbar's colour control). `style` stays on the props interface so
|
||||||
|
// already-saved sites keep deserializing cleanly.
|
||||||
return React.createElement('div', {
|
return React.createElement('div', {
|
||||||
ref: setRef,
|
ref: setRef,
|
||||||
style: {
|
style: {
|
||||||
minHeight: '40px',
|
minHeight: '40px',
|
||||||
outline: selected ? '2px solid #3b82f6' : 'none',
|
outline: selected ? '2px solid #3b82f6' : 'none',
|
||||||
...style,
|
|
||||||
},
|
},
|
||||||
dangerouslySetInnerHTML: { __html: clean },
|
dangerouslySetInnerHTML: { __html: clean },
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -44,3 +44,29 @@ describe('Icon.toHtml XSS hardening', () => {
|
|||||||
expect(html).not.toMatch(/"\s+onclick="/);
|
expect(html).not.toMatch(/"\s+onclick="/);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('Icon.toHtml bgShape/bgColor/bgSize rendering (built but, until this panel update, unexposed)', () => {
|
||||||
|
test('bgShape="circle" + bgColor render a colored 50%-radius background box', () => {
|
||||||
|
const { html } = toHtml({ icon: 'fa-star', bgShape: 'circle', bgColor: '#3b82f6', bgSize: '64px' }, '');
|
||||||
|
expect(html).toContain('background-color:#3b82f6');
|
||||||
|
expect(html).toContain('border-radius:50%');
|
||||||
|
expect(html).toContain('width:64px');
|
||||||
|
expect(html).toContain('height:64px');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('bgShape="none" (default) renders the bare icon with no background wrapper', () => {
|
||||||
|
const { html } = toHtml({ icon: 'fa-star' }, '');
|
||||||
|
expect(html).not.toContain('background-color');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Icon.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (Icon as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -12,6 +12,11 @@ interface IconProps {
|
|||||||
bgSize?: string;
|
bgSize?: string;
|
||||||
link?: string;
|
link?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
function getBgBorderRadius(shape: string): string {
|
function getBgBorderRadius(shape: string): string {
|
||||||
@@ -96,6 +101,11 @@ Icon.craft = {
|
|||||||
bgSize: '56px',
|
bgSize: '56px',
|
||||||
link: '',
|
link: '',
|
||||||
style: {},
|
style: {},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -30,3 +30,46 @@ describe('SearchBar.toHtml XSS hardening (placeholder/buttonText/showButton)', (
|
|||||||
expect(html).toMatch(/border-radius:(8px 0 0 8px|8px)/);
|
expect(html).toMatch(/border-radius:(8px 0 0 8px|8px)/);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// F2: SearchBar was purely decorative -- no action/method/input name, so
|
||||||
|
// submitting did nothing. It now emits a real GET form.
|
||||||
|
describe('SearchBar.toHtml is a functional GET search form (not decorative)', () => {
|
||||||
|
test('defaults to a GET form action="/" with the query input named "q"', () => {
|
||||||
|
const { html } = toHtml({}, '');
|
||||||
|
expect(html).toMatch(/<form role="search" action="\/" method="GET"/);
|
||||||
|
expect(html).toContain('<input type="search" name="q"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a configured action (real search-results page) is used verbatim', () => {
|
||||||
|
const { html } = toHtml({ action: '/search' }, '');
|
||||||
|
expect(html).toContain('action="/search"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a javascript: action is blocked via safeUrl and falls back to "/"', () => {
|
||||||
|
const { html } = toHtml({ action: 'javascript:alert(1)' }, '');
|
||||||
|
expect(html).toContain('action="/"');
|
||||||
|
expect(html).not.toContain('javascript:');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('an empty/whitespace action falls back to "/"', () => {
|
||||||
|
const { html } = toHtml({ action: ' ' }, '');
|
||||||
|
expect(html).toContain('action="/"');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('SearchBar.toHtml box-model style passthrough', () => {
|
||||||
|
test('margin/border/box-shadow/opacity flow through via the style prop', () => {
|
||||||
|
const { html } = toHtml({ style: { marginBottom: '14px', border: '1px solid #aaa', boxShadow: '0 1px 4px rgba(0,0,0,.1)', opacity: '0.9' } }, '');
|
||||||
|
expect(html).toContain('margin-bottom:14px');
|
||||||
|
expect(html).toContain('border:1px solid #aaa');
|
||||||
|
expect(html).toContain('opacity:0.9');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('SearchBar.craft.props includes animation/visibility defaults', () => {
|
||||||
|
test('has blank/false defaults', () => {
|
||||||
|
expect(SearchBar.craft!.props).toMatchObject({
|
||||||
|
animation: '', animationDelay: '', hideOnDesktop: false, hideOnTablet: false, hideOnMobile: false,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -1,19 +1,29 @@
|
|||||||
import React, { CSSProperties } from 'react';
|
import React, { CSSProperties } from 'react';
|
||||||
import { useNode, UserComponent } from '@craftjs/core';
|
import { useNode, UserComponent } from '@craftjs/core';
|
||||||
import { cssPropsToString } from '../../utils/style-helpers';
|
import { cssPropsToString } from '../../utils/style-helpers';
|
||||||
import { escapeHtml, escapeAttr } from '../../utils/escape';
|
import { escapeHtml, escapeAttr, safeUrl } from '../../utils/escape';
|
||||||
|
|
||||||
interface SearchBarProps {
|
interface SearchBarProps {
|
||||||
placeholder?: string;
|
placeholder?: string;
|
||||||
buttonText?: string;
|
buttonText?: string;
|
||||||
showButton?: boolean;
|
showButton?: boolean;
|
||||||
|
/** Where the search GET request is submitted -- a real search-results page
|
||||||
|
* if the site has one, or '/' (site root) by default. The query is sent
|
||||||
|
* as `?q=...`, the conventional param name search-results pages look for. */
|
||||||
|
action?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const SearchBar: UserComponent<SearchBarProps> = ({
|
export const SearchBar: UserComponent<SearchBarProps> = ({
|
||||||
placeholder = 'Search...',
|
placeholder = 'Search...',
|
||||||
buttonText = 'Search',
|
buttonText = 'Search',
|
||||||
showButton = true,
|
showButton = true,
|
||||||
|
action = '/',
|
||||||
style = {},
|
style = {},
|
||||||
}) => {
|
}) => {
|
||||||
const {
|
const {
|
||||||
@@ -27,6 +37,8 @@ export const SearchBar: UserComponent<SearchBarProps> = ({
|
|||||||
<form
|
<form
|
||||||
ref={(ref: HTMLFormElement | null): void => { if (ref) connect(drag(ref)); }}
|
ref={(ref: HTMLFormElement | null): void => { if (ref) connect(drag(ref)); }}
|
||||||
role="search"
|
role="search"
|
||||||
|
action={action}
|
||||||
|
method="GET"
|
||||||
onSubmit={(e) => e.preventDefault()}
|
onSubmit={(e) => e.preventDefault()}
|
||||||
style={{
|
style={{
|
||||||
display: 'flex',
|
display: 'flex',
|
||||||
@@ -51,6 +63,7 @@ export const SearchBar: UserComponent<SearchBarProps> = ({
|
|||||||
/>
|
/>
|
||||||
<input
|
<input
|
||||||
type="search"
|
type="search"
|
||||||
|
name="q"
|
||||||
placeholder={placeholder}
|
placeholder={placeholder}
|
||||||
style={{
|
style={{
|
||||||
width: '100%',
|
width: '100%',
|
||||||
@@ -101,7 +114,13 @@ SearchBar.craft = {
|
|||||||
placeholder: 'Search...',
|
placeholder: 'Search...',
|
||||||
buttonText: 'Search',
|
buttonText: 'Search',
|
||||||
showButton: true,
|
showButton: true,
|
||||||
|
action: '/',
|
||||||
style: {},
|
style: {},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
@@ -117,6 +136,7 @@ SearchBar.craft = {
|
|||||||
placeholder = 'Search...',
|
placeholder = 'Search...',
|
||||||
buttonText = 'Search',
|
buttonText = 'Search',
|
||||||
showButton = true,
|
showButton = true,
|
||||||
|
action = '/',
|
||||||
style = {},
|
style = {},
|
||||||
} = props;
|
} = props;
|
||||||
|
|
||||||
@@ -133,11 +153,19 @@ SearchBar.craft = {
|
|||||||
? `<button type="submit" style="padding:12px 20px;font-size:15px;font-weight:600;font-family:Inter,sans-serif;color:#ffffff;background-color:#3b82f6;border:none;border-radius:0 8px 8px 0;cursor:pointer;white-space:nowrap;display:flex;align-items:center;gap:6px"><i class="fa fa-search" style="font-size:13px" aria-hidden="true"></i>${escapeHtml(buttonText)}</button>`
|
? `<button type="submit" style="padding:12px 20px;font-size:15px;font-weight:600;font-family:Inter,sans-serif;color:#ffffff;background-color:#3b82f6;border:none;border-radius:0 8px 8px 0;cursor:pointer;white-space:nowrap;display:flex;align-items:center;gap:6px"><i class="fa fa-search" style="font-size:13px" aria-hidden="true"></i>${escapeHtml(buttonText)}</button>`
|
||||||
: '';
|
: '';
|
||||||
|
|
||||||
|
// F2: previously a purely decorative <form> -- no action/method/input
|
||||||
|
// name at all, so submitting did nothing. A real GET to `action` with the
|
||||||
|
// query in the conventional `q` param makes this a functioning search
|
||||||
|
// form on publish (routes to a real search-results page if the site has
|
||||||
|
// one, or reloads '/' with ?q=... by default). `safeUrl` blocks
|
||||||
|
// javascript:/vbscript:/data:text/html breakout via the action attribute.
|
||||||
|
const actionAttr = escapeAttr(safeUrl(action) || '/');
|
||||||
|
|
||||||
return {
|
return {
|
||||||
html: `<form role="search"${formStyle ? ` style="${formStyle}"` : ''}>
|
html: `<form role="search" action="${actionAttr}" method="GET"${formStyle ? ` style="${formStyle}"` : ''}>
|
||||||
<div style="position:relative;flex:1">
|
<div style="position:relative;flex:1">
|
||||||
<i class="fa fa-search" style="position:absolute;left:14px;top:50%;transform:translateY(-50%);color:#9ca3af;font-size:14px;pointer-events:none" aria-hidden="true"></i>
|
<i class="fa fa-search" style="position:absolute;left:14px;top:50%;transform:translateY(-50%);color:#9ca3af;font-size:14px;pointer-events:none" aria-hidden="true"></i>
|
||||||
<input type="search" placeholder="${escapeAttr(placeholder)}" style="${inputStyleStr}" />
|
<input type="search" name="q" placeholder="${escapeAttr(placeholder)}" style="${inputStyleStr}" />
|
||||||
</div>
|
</div>
|
||||||
${btnHtml}
|
${btnHtml}
|
||||||
</form>`,
|
</form>`,
|
||||||
|
|||||||
@@ -51,3 +51,43 @@ describe('SocialLinks.toHtml XSS hardening (iconSize/iconColor/iconBgColor/gap i
|
|||||||
expect(html).not.toContain('javascript:alert(1)');
|
expect(html).not.toContain('javascript:alert(1)');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('SocialLinks.toHtml iconShape/gap emission (previously built but unexposed in SocialStylePanel)', () => {
|
||||||
|
test('iconShape="circle" emits a 50% border-radius on the wrapping <a>', () => {
|
||||||
|
const { html } = toHtml({ links: [{ platform: 'facebook', url: '#' }], iconShape: 'circle' }, '');
|
||||||
|
expect(html).toMatch(/<a[^>]*style="[^"]*border-radius:50%[^"]*"/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('iconShape="square" emits border-radius:0', () => {
|
||||||
|
const { html } = toHtml({ links: [{ platform: 'facebook', url: '#' }], iconShape: 'square' }, '');
|
||||||
|
expect(html).toMatch(/<a[^>]*style="[^"]*border-radius:0[^"]*"/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('iconShape="rounded" emits a 6px border-radius', () => {
|
||||||
|
const { html } = toHtml({ links: [{ platform: 'facebook', url: '#' }], iconShape: 'rounded' }, '');
|
||||||
|
expect(html).toMatch(/<a[^>]*style="[^"]*border-radius:6px[^"]*"/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('iconShape="none" omits the background box entirely (transparent bg, no fixed box size)', () => {
|
||||||
|
const { html } = toHtml({ links: [{ platform: 'facebook', url: '#' }], iconShape: 'none' }, '');
|
||||||
|
const aTag = html.match(/<a[^>]*>/)![0];
|
||||||
|
expect(aTag).toContain('background-color:transparent');
|
||||||
|
expect(aTag).not.toContain('border-radius');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('gap emits on the wrapper <div> style', () => {
|
||||||
|
const { html } = toHtml({ links: [{ platform: 'facebook', url: '#' }], gap: '24px' }, '');
|
||||||
|
expect(html).toMatch(/<div[^>]*style="[^"]*gap:24px[^"]*"/);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('SocialLinks.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (SocialLinks as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -17,6 +17,11 @@ interface SocialLinksProps {
|
|||||||
gap?: string;
|
gap?: string;
|
||||||
alignment?: 'left' | 'center' | 'right';
|
alignment?: 'left' | 'center' | 'right';
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const platformIcons: Record<string, string> = {
|
const platformIcons: Record<string, string> = {
|
||||||
@@ -151,6 +156,11 @@ SocialLinks.craft = {
|
|||||||
gap: '10px',
|
gap: '10px',
|
||||||
alignment: 'center',
|
alignment: 'center',
|
||||||
style: {},
|
style: {},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -75,3 +75,14 @@ describe('StarRating.toHtml XSS hardening (rating/maxStars into aria-label, F2.2
|
|||||||
expect(html).toMatch(/<span role="img" aria-label="Rating: 4\.5 out of 5"/);
|
expect(html).toMatch(/<span role="img" aria-label="Rating: 4\.5 out of 5"/);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('StarRating.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (StarRating as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -10,6 +10,11 @@ interface StarRatingProps {
|
|||||||
filledColor?: string;
|
filledColor?: string;
|
||||||
emptyColor?: string;
|
emptyColor?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const StarRating: UserComponent<StarRatingProps> = ({
|
export const StarRating: UserComponent<StarRatingProps> = ({
|
||||||
@@ -87,6 +92,11 @@ StarRating.craft = {
|
|||||||
filledColor: '#f59e0b',
|
filledColor: '#f59e0b',
|
||||||
emptyColor: '#d1d5db',
|
emptyColor: '#d1d5db',
|
||||||
style: {},
|
style: {},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -20,3 +20,48 @@ describe('TextBlock.toHtml text escaping (attacker-controlled `text` prop)', ()
|
|||||||
expect(html).toBe('<p>Hello world</p>');
|
expect(html).toBe('<p>Hello world</p>');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('TextBlock.toHtml typography depth (line-height/letter-spacing/transform/style/decoration)', () => {
|
||||||
|
test('line-height, letter-spacing, text-transform all flow into the style attribute', () => {
|
||||||
|
const { html } = toHtml({
|
||||||
|
text: 'x',
|
||||||
|
style: { lineHeight: '1.75', letterSpacing: '-0.02em', textTransform: 'capitalize' },
|
||||||
|
}, '');
|
||||||
|
expect(html).toContain('line-height:1.75');
|
||||||
|
expect(html).toContain('letter-spacing:-0.02em');
|
||||||
|
expect(html).toContain('text-transform:capitalize');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('italic + underline toggles emit font-style and text-decoration', () => {
|
||||||
|
const { html } = toHtml({ text: 'x', style: { fontStyle: 'italic', textDecoration: 'underline' } }, '');
|
||||||
|
expect(html).toContain('font-style:italic');
|
||||||
|
expect(html).toContain('text-decoration:underline');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a custom font-size (not one of the presets) still flows through', () => {
|
||||||
|
const { html } = toHtml({ text: 'x', style: { fontSize: '19px' } }, '');
|
||||||
|
expect(html).toContain('font-size:19px');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('TextBlock.craft.props exposes the box-model + animation/visibility rollout', () => {
|
||||||
|
test('animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
||||||
|
const props = (TextBlock as any).craft.props;
|
||||||
|
expect(props.animation).toBe('');
|
||||||
|
expect(props.animationDelay).toBe('0');
|
||||||
|
expect(props.hideOnDesktop).toBe(false);
|
||||||
|
expect(props.hideOnTablet).toBe(false);
|
||||||
|
expect(props.hideOnMobile).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style carries blank/default box-model + typography-depth keys', () => {
|
||||||
|
const style = (TextBlock as any).craft.props.style;
|
||||||
|
expect(style).toHaveProperty('marginTop');
|
||||||
|
expect(style).toHaveProperty('paddingTop');
|
||||||
|
expect(style).toHaveProperty('letterSpacing');
|
||||||
|
expect(style).toHaveProperty('textTransform');
|
||||||
|
expect(style.border).toBe('none');
|
||||||
|
expect(style.boxShadow).toBe('none');
|
||||||
|
expect(style.opacity).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -83,7 +83,21 @@ TextBlock.craft = {
|
|||||||
fontSize: '16px',
|
fontSize: '16px',
|
||||||
lineHeight: '1.6',
|
lineHeight: '1.6',
|
||||||
color: '#3f3f46',
|
color: '#3f3f46',
|
||||||
|
letterSpacing: '',
|
||||||
|
textTransform: '' as CSSProperties['textTransform'],
|
||||||
|
fontStyle: '' as CSSProperties['fontStyle'],
|
||||||
|
textDecoration: '',
|
||||||
|
marginTop: '', marginRight: '', marginBottom: '', marginLeft: '',
|
||||||
|
paddingTop: '', paddingRight: '', paddingBottom: '', paddingLeft: '',
|
||||||
|
border: 'none',
|
||||||
|
boxShadow: 'none',
|
||||||
|
opacity: '1',
|
||||||
},
|
},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '0',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -126,3 +126,73 @@ describe('ContactForm.toHtml field type attribute sanitization', () => {
|
|||||||
expect(html).toContain('type="email"');
|
expect(html).toContain('type="email"');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// F1: the field editor (FormStylePanel) can now create fields of every type
|
||||||
|
// in sanitizeInputType's allowlist, plus textarea/select. Verify each
|
||||||
|
// renders with the right control, label/for association, and required flag.
|
||||||
|
describe('ContactForm.toHtml renders every configured field type/label/required', () => {
|
||||||
|
const cases: { type: string; tag: string }[] = [
|
||||||
|
{ type: 'text', tag: 'input' },
|
||||||
|
{ type: 'email', tag: 'input' },
|
||||||
|
{ type: 'tel', tag: 'input' },
|
||||||
|
{ type: 'number', tag: 'input' },
|
||||||
|
{ type: 'password', tag: 'input' },
|
||||||
|
{ type: 'url', tag: 'input' },
|
||||||
|
{ type: 'search', tag: 'input' },
|
||||||
|
{ type: 'date', tag: 'input' },
|
||||||
|
{ type: 'checkbox', tag: 'input' },
|
||||||
|
{ type: 'radio', tag: 'input' },
|
||||||
|
];
|
||||||
|
|
||||||
|
test.each(cases)('type=$type renders a sanitized <$tag type="$type"> with label + for/id wiring', ({ type, tag }) => {
|
||||||
|
const fields = [{ type: type as any, label: `Field ${type}`, name: `f_${type}`, placeholder: '', required: true }];
|
||||||
|
const { html } = toHtml({ fields }, '');
|
||||||
|
expect(html).toContain(`<${tag}`);
|
||||||
|
expect(html).toContain(`type="${type}"`);
|
||||||
|
expect(html).toContain(`Field ${type}`);
|
||||||
|
// required renders the input attribute AND the visual asterisk
|
||||||
|
expect(html).toMatch(/ required/);
|
||||||
|
expect(html).toContain('*</span>');
|
||||||
|
const labelFor = html.match(/<label for="([^"]+)"/)![1];
|
||||||
|
expect(html).toContain(`id="${labelFor}"`);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('type=textarea renders a <textarea>, not an <input>', () => {
|
||||||
|
const fields = [{ type: 'textarea' as const, label: 'Message', name: 'message', placeholder: '', required: false }];
|
||||||
|
const { html } = toHtml({ fields }, '');
|
||||||
|
expect(html).toMatch(/<textarea[^>]*name="message"/);
|
||||||
|
expect(html).not.toMatch(/<input[^>]*name="message"/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('type=select renders a <select> with escaped <option> values from field.options', () => {
|
||||||
|
const fields = [{ type: 'select' as const, label: 'Plan', name: 'plan', placeholder: 'Choose one', required: false, options: ['Basic', 'Pro', '"><script>alert(1)</script>'] }];
|
||||||
|
const { html } = toHtml({ fields }, '');
|
||||||
|
expect(html).toMatch(/<select[^>]*name="plan"/);
|
||||||
|
expect(html).toContain('<option value="Basic">Basic</option>');
|
||||||
|
expect(html).toContain('<option value="Pro">Pro</option>');
|
||||||
|
expect(html).not.toContain('<script>alert(1)</script>');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a non-required field omits both the required attribute and the asterisk', () => {
|
||||||
|
const fields = [{ type: 'text' as const, label: 'Nickname', name: 'nickname', placeholder: '', required: false }];
|
||||||
|
const { html } = toHtml({ fields }, '');
|
||||||
|
expect(html).not.toMatch(/ required/);
|
||||||
|
expect(html).not.toContain('*</span>');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
// Box-model / animation / visibility rollout (common enh-batch pattern):
|
||||||
|
// these are top-level props consumed generically by the export's
|
||||||
|
// buildDataAttrs() -- this just confirms the defaults are present on
|
||||||
|
// craft.props so the panel controls render and the props survive save/load.
|
||||||
|
describe('ContactForm.craft.props includes animation/visibility defaults', () => {
|
||||||
|
test('has blank/false defaults for animation, animationDelay, hideOnDesktop/Tablet/Mobile', () => {
|
||||||
|
expect(ContactForm.craft!.props).toMatchObject({
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -4,8 +4,17 @@ import { cssPropsToString } from '../../utils/style-helpers';
|
|||||||
import { relayFormWiring } from '../../utils/form-relay-wiring';
|
import { relayFormWiring } from '../../utils/form-relay-wiring';
|
||||||
import { escapeHtml, escapeAttr, slugId, cssValue, sanitizeInputType } from '../../utils/escape';
|
import { escapeHtml, escapeAttr, slugId, cssValue, sanitizeInputType } from '../../utils/escape';
|
||||||
|
|
||||||
|
// The allowlist enforced at export time lives in `sanitizeInputType`
|
||||||
|
// (utils/escape.ts) -- this union is a superset (it also covers 'textarea'
|
||||||
|
// and 'select', which take their own render branches instead of an
|
||||||
|
// `<input type>`), kept in sync by hand since TS unions can't import a
|
||||||
|
// runtime array.
|
||||||
|
export type ContactFormFieldType =
|
||||||
|
| 'text' | 'email' | 'tel' | 'number' | 'password' | 'url' | 'search' | 'date'
|
||||||
|
| 'checkbox' | 'radio' | 'textarea' | 'select';
|
||||||
|
|
||||||
interface ContactFormField {
|
interface ContactFormField {
|
||||||
type: 'text' | 'email' | 'tel' | 'textarea' | 'select';
|
type: ContactFormFieldType;
|
||||||
label: string;
|
label: string;
|
||||||
name: string;
|
name: string;
|
||||||
placeholder: string;
|
placeholder: string;
|
||||||
@@ -25,6 +34,11 @@ interface ContactFormProps {
|
|||||||
inputBorder?: string;
|
inputBorder?: string;
|
||||||
recipientEmail?: string;
|
recipientEmail?: string;
|
||||||
thankYouUrl?: string;
|
thankYouUrl?: string;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const defaultFields: ContactFormField[] = [
|
const defaultFields: ContactFormField[] = [
|
||||||
@@ -157,6 +171,11 @@ ContactForm.craft = {
|
|||||||
inputBorder: '#d1d5db',
|
inputBorder: '#d1d5db',
|
||||||
recipientEmail: '',
|
recipientEmail: '',
|
||||||
thankYouUrl: '',
|
thankYouUrl: '',
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -22,4 +22,19 @@ describe('FormButton.toHtml', () => {
|
|||||||
expect(html).toContain('&');
|
expect(html).toContain('&');
|
||||||
expect(html).toContain('"quoted"');
|
expect(html).toContain('"quoted"');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('box-model style (margin/border/box-shadow/opacity) flows through via the style prop', () => {
|
||||||
|
const { html } = toHtml({ text: 'Submit', style: { marginTop: '12px', border: '2px solid #000', boxShadow: '0 2px 4px rgba(0,0,0,.2)', opacity: '0.8' } }, '');
|
||||||
|
expect(html).toContain('margin-top:12px');
|
||||||
|
expect(html).toContain('border:2px solid #000');
|
||||||
|
expect(html).toContain('opacity:0.8');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('FormButton.craft.props includes animation/visibility defaults', () => {
|
||||||
|
test('has blank/false defaults', () => {
|
||||||
|
expect(FormButton.craft!.props).toMatchObject({
|
||||||
|
animation: '', animationDelay: '', hideOnDesktop: false, hideOnTablet: false, hideOnMobile: false,
|
||||||
|
});
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -6,6 +6,11 @@ import { escapeHtml } from '../../utils/escape';
|
|||||||
interface FormButtonProps {
|
interface FormButtonProps {
|
||||||
text?: string;
|
text?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const FormButton: UserComponent<FormButtonProps> = ({
|
export const FormButton: UserComponent<FormButtonProps> = ({
|
||||||
@@ -58,6 +63,11 @@ FormButton.craft = {
|
|||||||
fontSize: '16px',
|
fontSize: '16px',
|
||||||
border: 'none',
|
border: 'none',
|
||||||
},
|
},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -52,3 +52,20 @@ describe('FormContainer.toHtml method attribute sanitization', () => {
|
|||||||
expect(html).toContain('method="GET"');
|
expect(html).toContain('method="GET"');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('FormContainer.toHtml box-model style passthrough', () => {
|
||||||
|
test('margin/border/box-shadow/opacity flow through via the style prop', () => {
|
||||||
|
const { html } = toHtml({ action: '/legacy', style: { marginTop: '20px', border: '3px dashed #ccc', boxShadow: '0 4px 8px rgba(0,0,0,.2)', opacity: '0.95' } }, '');
|
||||||
|
expect(html).toContain('margin-top:20px');
|
||||||
|
expect(html).toContain('border:3px dashed #ccc');
|
||||||
|
expect(html).toContain('opacity:0.95');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('FormContainer.craft.props includes animation/visibility defaults', () => {
|
||||||
|
test('has blank/false defaults', () => {
|
||||||
|
expect(FormContainer.craft!.props).toMatchObject({
|
||||||
|
animation: '', animationDelay: '', hideOnDesktop: false, hideOnTablet: false, hideOnMobile: false,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -12,6 +12,11 @@ interface FormContainerProps {
|
|||||||
thankYouUrl?: string;
|
thankYouUrl?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
children?: React.ReactNode;
|
children?: React.ReactNode;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const FormContainer: UserComponent<FormContainerProps> = ({
|
export const FormContainer: UserComponent<FormContainerProps> = ({
|
||||||
@@ -59,6 +64,11 @@ FormContainer.craft = {
|
|||||||
borderRadius: '8px',
|
borderRadius: '8px',
|
||||||
border: '1px solid #e4e4e7',
|
border: '1px solid #e4e4e7',
|
||||||
},
|
},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -72,3 +72,20 @@ describe('InputField.toHtml type attribute sanitization', () => {
|
|||||||
expect(html).toContain('type="number"');
|
expect(html).toContain('type="number"');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('InputField.toHtml box-model style passthrough', () => {
|
||||||
|
test('margin/border/box-shadow/opacity flow through via the style prop', () => {
|
||||||
|
const { html } = toHtml({ label: 'Name', name: 'name', style: { marginBottom: '8px', border: '1px solid #333', boxShadow: '0 1px 2px rgba(0,0,0,.1)', opacity: '0.9' } }, '');
|
||||||
|
expect(html).toContain('margin-bottom:8px');
|
||||||
|
expect(html).toContain('border:1px solid #333');
|
||||||
|
expect(html).toContain('opacity:0.9');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('InputField.craft.props includes animation/visibility defaults', () => {
|
||||||
|
test('has blank/false defaults', () => {
|
||||||
|
expect(InputField.craft!.props).toMatchObject({
|
||||||
|
animation: '', animationDelay: '', hideOnDesktop: false, hideOnTablet: false, hideOnMobile: false,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -10,6 +10,11 @@ interface InputFieldProps {
|
|||||||
placeholder?: string;
|
placeholder?: string;
|
||||||
required?: boolean;
|
required?: boolean;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const InputField: UserComponent<InputFieldProps> = ({
|
export const InputField: UserComponent<InputFieldProps> = ({
|
||||||
@@ -77,6 +82,11 @@ InputField.craft = {
|
|||||||
placeholder: 'Enter your name',
|
placeholder: 'Enter your name',
|
||||||
required: false,
|
required: false,
|
||||||
style: {},
|
style: {},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -6,7 +6,7 @@ const toHtml = (SubscribeForm as any).toHtml;
|
|||||||
describe('SubscribeForm.toHtml hardcoded attributes stay hardcoded (no raw prop breakout)', () => {
|
describe('SubscribeForm.toHtml hardcoded attributes stay hardcoded (no raw prop breakout)', () => {
|
||||||
test('form method is always POST regardless of any injected props', () => {
|
test('form method is always POST regardless of any injected props', () => {
|
||||||
const { html } = toHtml({ heading: 'Join us', method: 'GET"><script>alert(1)</script>' } as any, '');
|
const { html } = toHtml({ heading: 'Join us', method: 'GET"><script>alert(1)</script>' } as any, '');
|
||||||
expect(html).toContain('<form method="POST"');
|
expect(html).toMatch(/<form action="[^"]*" method="POST"/);
|
||||||
expect(html).not.toContain('<script');
|
expect(html).not.toContain('<script');
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -37,3 +37,45 @@ describe('SubscribeForm.toHtml hardcoded attributes stay hardcoded (no raw prop
|
|||||||
expect(html).toContain('>Go<');
|
expect(html).toContain('>Go<');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// F1: SubscribeForm previously emitted `<form method="POST">` with no action
|
||||||
|
// at all -- a published subscribe form silently did nothing on submit.
|
||||||
|
// Wired through the same relay contract as ContactForm/FormContainer
|
||||||
|
// (utils/form-relay-wiring.ts) so setting a recipient makes it functional.
|
||||||
|
describe('SubscribeForm.toHtml is functional (not a dead POST)', () => {
|
||||||
|
test('without a recipient: still has a real (non-empty) action -- "#" fallback, not a bare method="POST"', () => {
|
||||||
|
const { html } = toHtml({}, '');
|
||||||
|
expect(html).toMatch(/<form action="#" method="POST"/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('with recipientEmail: emits the relay marker, placeholder action, and honeypot -- a working submission path', () => {
|
||||||
|
const { html } = toHtml({ recipientEmail: 'news@example.com', thankYouUrl: '/thanks' }, '', 'node-sub1');
|
||||||
|
expect(html).toMatch(/<!--WHP-FORM id="F_[0-9a-z]+" recipient="news@example.com" thankyou="\/thanks"-->/);
|
||||||
|
expect(html).toMatch(/action="__WHP_FORM_ACTION__F_[0-9a-z]+__"/);
|
||||||
|
expect(html).toContain('name="_gotcha"');
|
||||||
|
const mid = html.match(/id="(F_[0-9a-z]+)"/)![1];
|
||||||
|
expect(html).toContain(`__WHP_FORM_ACTION__${mid}__`);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the email input keeps its name="email" so the relay receives it', () => {
|
||||||
|
const { html } = toHtml({ recipientEmail: 'news@example.com' }, '', 'node-sub2');
|
||||||
|
expect(html).toContain('name="email"');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('SubscribeForm.toHtml box-model style passthrough', () => {
|
||||||
|
test('margin/border/box-shadow/opacity flow through via the style prop', () => {
|
||||||
|
const { html } = toHtml({ style: { marginTop: '16px', border: '1px solid #ddd', boxShadow: '0 2px 6px rgba(0,0,0,.15)', opacity: '0.85' } }, '');
|
||||||
|
expect(html).toContain('margin-top:16px');
|
||||||
|
expect(html).toContain('border:1px solid #ddd');
|
||||||
|
expect(html).toContain('opacity:0.85');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('SubscribeForm.craft.props includes animation/visibility defaults', () => {
|
||||||
|
test('has blank/false defaults', () => {
|
||||||
|
expect(SubscribeForm.craft!.props).toMatchObject({
|
||||||
|
animation: '', animationDelay: '', hideOnDesktop: false, hideOnTablet: false, hideOnMobile: false,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
import React, { CSSProperties } from 'react';
|
import React, { CSSProperties } from 'react';
|
||||||
import { useNode, UserComponent } from '@craftjs/core';
|
import { useNode, UserComponent } from '@craftjs/core';
|
||||||
import { cssPropsToString } from '../../utils/style-helpers';
|
import { cssPropsToString } from '../../utils/style-helpers';
|
||||||
|
import { relayFormWiring } from '../../utils/form-relay-wiring';
|
||||||
import { escapeHtml, escapeAttr } from '../../utils/escape';
|
import { escapeHtml, escapeAttr } from '../../utils/escape';
|
||||||
|
|
||||||
interface SubscribeFormProps {
|
interface SubscribeFormProps {
|
||||||
@@ -10,6 +11,17 @@ interface SubscribeFormProps {
|
|||||||
buttonColor?: string;
|
buttonColor?: string;
|
||||||
layout?: 'inline' | 'stacked';
|
layout?: 'inline' | 'stacked';
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
/** "Send submissions to" address -- same relay contract as ContactForm/
|
||||||
|
* FormContainer (see utils/form-relay-wiring.ts). Blank = no relay; the
|
||||||
|
* published form then has no working action at all, which is the bug
|
||||||
|
* this prop exists to fix. */
|
||||||
|
recipientEmail?: string;
|
||||||
|
thankYouUrl?: string;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const SubscribeForm: UserComponent<SubscribeFormProps> = ({
|
export const SubscribeForm: UserComponent<SubscribeFormProps> = ({
|
||||||
@@ -110,6 +122,13 @@ SubscribeForm.craft = {
|
|||||||
buttonColor: '#3b82f6',
|
buttonColor: '#3b82f6',
|
||||||
layout: 'inline',
|
layout: 'inline',
|
||||||
style: { backgroundColor: '#f8fafc' },
|
style: { backgroundColor: '#f8fafc' },
|
||||||
|
recipientEmail: '',
|
||||||
|
thankYouUrl: '',
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
@@ -120,7 +139,7 @@ SubscribeForm.craft = {
|
|||||||
|
|
||||||
/* ---------- HTML export ---------- */
|
/* ---------- HTML export ---------- */
|
||||||
|
|
||||||
(SubscribeForm as any).toHtml = (props: SubscribeFormProps, _childrenHtml: string) => {
|
(SubscribeForm as any).toHtml = (props: SubscribeFormProps, _childrenHtml: string, nodeId?: string) => {
|
||||||
const {
|
const {
|
||||||
heading = 'Subscribe to our newsletter',
|
heading = 'Subscribe to our newsletter',
|
||||||
placeholder = 'Enter your email',
|
placeholder = 'Enter your email',
|
||||||
@@ -166,11 +185,21 @@ SubscribeForm.craft = {
|
|||||||
whiteSpace: 'nowrap',
|
whiteSpace: 'nowrap',
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// Same relay contract as ContactForm/FormContainer: a recipientEmail wires
|
||||||
|
// the form through the WHP form-sender relay (marker + placeholder action
|
||||||
|
// + honeypot, provisioned/rewritten at publish time). Previously this form
|
||||||
|
// always emitted `<form method="POST">` with NO action at all -- a
|
||||||
|
// published subscribe form silently did nothing on submit. Falling back to
|
||||||
|
// `formAction`-less relay wiring (fallbackAction undefined -> '#') keeps
|
||||||
|
// the old no-recipient case visually identical (action="#") while making
|
||||||
|
// the relay path actually functional once an admin sets an email.
|
||||||
|
const { marker, actionAttr, honeypot } = relayFormWiring(props.recipientEmail, props.thankYouUrl, undefined, nodeId);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
html: `<div${wrapperStyle ? ` style="${wrapperStyle}"` : ''}>
|
html: `${marker}<div${wrapperStyle ? ` style="${wrapperStyle}"` : ''}>
|
||||||
${headingHtml}
|
${headingHtml}
|
||||||
<form method="POST"${formStyle ? ` style="${formStyle}"` : ''}>
|
<form action="${actionAttr}" method="POST"${formStyle ? ` style="${formStyle}"` : ''}>
|
||||||
<input type="email" name="email" placeholder="${escapeAttr(placeholder)}" required style="${inputStyleStr}" />
|
${honeypot ? ` ${honeypot}\n` : ''} <input type="email" name="email" placeholder="${escapeAttr(placeholder)}" required style="${inputStyleStr}" />
|
||||||
<button type="submit"${btnStyle ? ` style="${btnStyle}"` : ''}>${escapeHtml(buttonText)}</button>
|
<button type="submit"${btnStyle ? ` style="${btnStyle}"` : ''}>${escapeHtml(buttonText)}</button>
|
||||||
</form>
|
</form>
|
||||||
</div>`,
|
</div>`,
|
||||||
|
|||||||
@@ -63,3 +63,20 @@ describe('TextareaField.toHtml rows attribute sanitization', () => {
|
|||||||
expect(html).toContain('rows="8"');
|
expect(html).toContain('rows="8"');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('TextareaField.toHtml box-model style passthrough', () => {
|
||||||
|
test('margin/border/box-shadow/opacity flow through via the style prop', () => {
|
||||||
|
const { html } = toHtml({ label: 'Message', name: 'message', style: { marginTop: '10px', border: '1px solid #555', boxShadow: '0 1px 3px rgba(0,0,0,.15)', opacity: '0.7' } }, '');
|
||||||
|
expect(html).toContain('margin-top:10px');
|
||||||
|
expect(html).toContain('border:1px solid #555');
|
||||||
|
expect(html).toContain('opacity:0.7');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('TextareaField.craft.props includes animation/visibility defaults', () => {
|
||||||
|
test('has blank/false defaults', () => {
|
||||||
|
expect(TextareaField.craft!.props).toMatchObject({
|
||||||
|
animation: '', animationDelay: '', hideOnDesktop: false, hideOnTablet: false, hideOnMobile: false,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -10,6 +10,11 @@ interface TextareaFieldProps {
|
|||||||
rows?: number;
|
rows?: number;
|
||||||
required?: boolean;
|
required?: boolean;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const TextareaField: UserComponent<TextareaFieldProps> = ({
|
export const TextareaField: UserComponent<TextareaFieldProps> = ({
|
||||||
@@ -79,6 +84,11 @@ TextareaField.craft = {
|
|||||||
rows: 4,
|
rows: 4,
|
||||||
required: false,
|
required: false,
|
||||||
style: {},
|
style: {},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -80,3 +80,56 @@ describe('ColumnLayout.toHtml XSS hardening (gap into <style>)', () => {
|
|||||||
expect(html).toMatch(/calc\(50% - 24px\)/);
|
expect(html).toMatch(/calc\(50% - 24px\)/);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('ColumnLayout.toHtml vertical alignment (align-items on the flex row)', () => {
|
||||||
|
test('style.alignItems flows into the emitted style attribute (aligns uneven columns)', () => {
|
||||||
|
const { html } = toHtml({ columns: 2, split: '50-50', gap: '16px', style: { alignItems: 'center' } }, '<div>A</div><div>B</div>');
|
||||||
|
expect(html).toContain('align-items:center');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('ColumnLayout.toHtml box-model styles (margin/padding/border/shadow/opacity)', () => {
|
||||||
|
test('margin/padding/border/box-shadow/opacity all flow into the emitted style attribute', () => {
|
||||||
|
const { html } = toHtml(
|
||||||
|
{
|
||||||
|
columns: 2,
|
||||||
|
split: '50-50',
|
||||||
|
gap: '16px',
|
||||||
|
style: {
|
||||||
|
marginTop: '10px', marginRight: '10px', marginBottom: '10px', marginLeft: '10px',
|
||||||
|
paddingTop: '5px',
|
||||||
|
border: '2px solid #ff0000',
|
||||||
|
boxShadow: '0 4px 8px rgba(0,0,0,0.12)',
|
||||||
|
opacity: '0.8',
|
||||||
|
},
|
||||||
|
},
|
||||||
|
'<div>A</div><div>B</div>',
|
||||||
|
);
|
||||||
|
expect(html).toContain('margin-top:10px');
|
||||||
|
expect(html).toContain('padding-top:5px');
|
||||||
|
expect(html).toContain('border:2px solid #ff0000');
|
||||||
|
expect(html).toContain('box-shadow:0 4px 8px rgba(0,0,0,0.12)');
|
||||||
|
expect(html).toContain('opacity:0.8');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('ColumnLayout.craft.props exposes the vertical-alignment/box-model/animation/visibility rollout', () => {
|
||||||
|
test('animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
||||||
|
const props = (ColumnLayout as any).craft.props;
|
||||||
|
expect(props.animation).toBe('');
|
||||||
|
expect(props.animationDelay).toBe('0');
|
||||||
|
expect(props.hideOnDesktop).toBe(false);
|
||||||
|
expect(props.hideOnTablet).toBe(false);
|
||||||
|
expect(props.hideOnMobile).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style carries blank/default alignItems and box-model keys', () => {
|
||||||
|
const style = (ColumnLayout as any).craft.props.style;
|
||||||
|
expect(style).toHaveProperty('alignItems');
|
||||||
|
expect(style).toHaveProperty('marginTop');
|
||||||
|
expect(style).toHaveProperty('paddingTop');
|
||||||
|
expect(style.border).toBe('none');
|
||||||
|
expect(style.boxShadow).toBe('none');
|
||||||
|
expect(style.opacity).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -20,6 +20,11 @@ interface ColumnLayoutProps {
|
|||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
children?: React.ReactNode;
|
children?: React.ReactNode;
|
||||||
anchorId?: string;
|
anchorId?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
const splitToWidths: Record<string, string[]> = {
|
const splitToWidths: Record<string, string[]> = {
|
||||||
@@ -102,8 +107,20 @@ ColumnLayout.craft = {
|
|||||||
columns: 2,
|
columns: 2,
|
||||||
split: '50-50',
|
split: '50-50',
|
||||||
gap: '16px',
|
gap: '16px',
|
||||||
style: {},
|
style: {
|
||||||
|
alignItems: '',
|
||||||
|
marginTop: '', marginRight: '', marginBottom: '', marginLeft: '',
|
||||||
|
paddingTop: '', paddingRight: '', paddingBottom: '', paddingLeft: '',
|
||||||
|
border: 'none',
|
||||||
|
boxShadow: 'none',
|
||||||
|
opacity: '1',
|
||||||
|
},
|
||||||
anchorId: '',
|
anchorId: '',
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '0',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -63,3 +63,88 @@ describe('Container.toHtml tag allowlist (adversarial re-review, same class as C
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('Container.toHtml vertical alignment (justify-content + min-height)', () => {
|
||||||
|
// Regression lock: Container/Section must NOT unconditionally become a
|
||||||
|
// flex container. Flex-blockifies in-flow children, forcing components
|
||||||
|
// that deliberately render display:inline-block (ButtonLink, Icon) to
|
||||||
|
// stack vertically instead of sitting side-by-side -- a real visual
|
||||||
|
// regression for existing published pages that never touch vertical
|
||||||
|
// alignment.
|
||||||
|
test('does NOT become a flex container when no vertical alignment is set (plain block flow preserved)', () => {
|
||||||
|
const { html } = toHtml({}, 'child');
|
||||||
|
expect(html).not.toContain('display:flex');
|
||||||
|
expect(html).not.toContain('flex-direction');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('does NOT become a flex container from min-height alone (min-height must not itself trigger flex)', () => {
|
||||||
|
const { html } = toHtml({ style: { minHeight: '400px' } }, 'child');
|
||||||
|
expect(html).not.toContain('display:flex');
|
||||||
|
expect(html).not.toContain('flex-direction');
|
||||||
|
expect(html).toContain('min-height:400px');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('becomes a column flex container when style.justifyContent is set (feature still works)', () => {
|
||||||
|
const { html } = toHtml({ style: { justifyContent: 'center' } }, 'child');
|
||||||
|
expect(html).toContain('display:flex');
|
||||||
|
expect(html).toContain('flex-direction:column');
|
||||||
|
expect(html).toContain('justify-content:center');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style.minHeight flows into the emitted style attribute', () => {
|
||||||
|
const { html } = toHtml({ style: { minHeight: '400px' } }, 'child');
|
||||||
|
expect(html).toContain('min-height:400px');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('justify-content and min-height still flow through in boxed (contentWidth) mode', () => {
|
||||||
|
const { html } = toHtml({ contentWidth: 'boxed', style: { justifyContent: 'flex-end', minHeight: '500px' } }, 'child');
|
||||||
|
expect(html).toContain('display:flex');
|
||||||
|
expect(html).toContain('flex-direction:column');
|
||||||
|
expect(html).toContain('justify-content:flex-end');
|
||||||
|
expect(html).toContain('min-height:500px');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Container.toHtml box-model styles (margin/padding/border/shadow/opacity)', () => {
|
||||||
|
test('margin/padding/border/box-shadow/opacity all flow into the emitted style attribute', () => {
|
||||||
|
const { html } = toHtml(
|
||||||
|
{
|
||||||
|
style: {
|
||||||
|
marginTop: '10px', marginRight: '10px', marginBottom: '10px', marginLeft: '10px',
|
||||||
|
paddingTop: '5px',
|
||||||
|
border: '2px solid #ff0000',
|
||||||
|
boxShadow: '0 4px 8px rgba(0,0,0,0.12)',
|
||||||
|
opacity: '0.8',
|
||||||
|
},
|
||||||
|
},
|
||||||
|
'child',
|
||||||
|
);
|
||||||
|
expect(html).toContain('margin-top:10px');
|
||||||
|
expect(html).toContain('padding-top:5px');
|
||||||
|
expect(html).toContain('border:2px solid #ff0000');
|
||||||
|
expect(html).toContain('box-shadow:0 4px 8px rgba(0,0,0,0.12)');
|
||||||
|
expect(html).toContain('opacity:0.8');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Container.craft.props exposes the vertical-alignment/box-model/animation/visibility rollout', () => {
|
||||||
|
test('animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
||||||
|
const props = (Container as any).craft.props;
|
||||||
|
expect(props.animation).toBe('');
|
||||||
|
expect(props.animationDelay).toBe('0');
|
||||||
|
expect(props.hideOnDesktop).toBe(false);
|
||||||
|
expect(props.hideOnTablet).toBe(false);
|
||||||
|
expect(props.hideOnMobile).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style carries blank/default vertical-alignment and box-model keys', () => {
|
||||||
|
const style = (Container as any).craft.props.style;
|
||||||
|
expect(style).toHaveProperty('justifyContent');
|
||||||
|
expect(style).toHaveProperty('minHeight');
|
||||||
|
expect(style).toHaveProperty('marginTop');
|
||||||
|
expect(style).toHaveProperty('paddingTop');
|
||||||
|
expect(style.border).toBe('none');
|
||||||
|
expect(style.boxShadow).toBe('none');
|
||||||
|
expect(style.opacity).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -43,6 +43,20 @@ const flexAlignFromTextAlign = (textAlign: CSSProperties['textAlign']): CSSPrope
|
|||||||
return {};
|
return {};
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Container only becomes display:flex/flex-direction:column at its root
|
||||||
|
// (both in the editor render below and in toHtml) when the user has
|
||||||
|
// actually set `style.justifyContent` (the Vertical Alignment control,
|
||||||
|
// paired with `style.minHeight`) -- i.e. the flex conversion is gated on
|
||||||
|
// vertical-align actually being in use, not unconditional. In-flow children
|
||||||
|
// of a flex container get CSS-blockified, which would force components that
|
||||||
|
// deliberately render `display:inline-block` (ButtonLink, Icon) to stack
|
||||||
|
// vertically instead of sitting side-by-side -- a real visual regression for
|
||||||
|
// any container/section that never touches vertical alignment, not a no-op.
|
||||||
|
// So plain block flow (no `display`/`flex-direction` at all) is preserved
|
||||||
|
// unless vertical-align is set. `flexAlignFromTextAlign` above still
|
||||||
|
// supplies its own conditional flex conversion (cross-axis alignItems from
|
||||||
|
// `textAlign`) independently -- unrelated to this gate.
|
||||||
|
|
||||||
export const Container: UserComponent<ContainerProps> = ({
|
export const Container: UserComponent<ContainerProps> = ({
|
||||||
style = {},
|
style = {},
|
||||||
tag = 'div',
|
tag = 'div',
|
||||||
@@ -58,10 +72,12 @@ export const Container: UserComponent<ContainerProps> = ({
|
|||||||
const safeTag = sanitizeContainerTag(tag);
|
const safeTag = sanitizeContainerTag(tag);
|
||||||
const needsBoxedWrapper = contentWidth === 'boxed';
|
const needsBoxedWrapper = contentWidth === 'boxed';
|
||||||
const flexStyles = flexAlignFromTextAlign(style.textAlign);
|
const flexStyles = flexAlignFromTextAlign(style.textAlign);
|
||||||
|
const hasVerticalAlign = !!style.justifyContent;
|
||||||
|
|
||||||
const outerStyle: CSSProperties = {
|
const outerStyle: CSSProperties = {
|
||||||
minHeight: '40px',
|
minHeight: '40px',
|
||||||
...style,
|
...style,
|
||||||
|
...(hasVerticalAlign ? { display: 'flex', flexDirection: 'column' } : {}),
|
||||||
...(fullWidth ? { width: '100vw', marginLeft: 'calc(-50vw + 50%)' } : {}),
|
...(fullWidth ? { width: '100vw', marginLeft: 'calc(-50vw + 50%)' } : {}),
|
||||||
...(needsBoxedWrapper ? {} : flexStyles),
|
...(needsBoxedWrapper ? {} : flexStyles),
|
||||||
};
|
};
|
||||||
@@ -93,13 +109,27 @@ export const Container: UserComponent<ContainerProps> = ({
|
|||||||
Container.craft = {
|
Container.craft = {
|
||||||
displayName: 'Container',
|
displayName: 'Container',
|
||||||
props: {
|
props: {
|
||||||
style: { padding: '20px', minHeight: '100px' },
|
style: {
|
||||||
|
padding: '20px',
|
||||||
|
minHeight: '100px',
|
||||||
|
justifyContent: '',
|
||||||
|
marginTop: '', marginRight: '', marginBottom: '', marginLeft: '',
|
||||||
|
paddingTop: '', paddingRight: '', paddingBottom: '', paddingLeft: '',
|
||||||
|
border: 'none',
|
||||||
|
boxShadow: 'none',
|
||||||
|
opacity: '1',
|
||||||
|
},
|
||||||
tag: 'div',
|
tag: 'div',
|
||||||
fullWidth: false,
|
fullWidth: false,
|
||||||
contentWidth: 'full',
|
contentWidth: 'full',
|
||||||
anchorId: '',
|
anchorId: '',
|
||||||
cssId: '',
|
cssId: '',
|
||||||
cssClass: '',
|
cssClass: '',
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '0',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
@@ -114,9 +144,11 @@ Container.craft = {
|
|||||||
const tag = sanitizeContainerTag(props.tag);
|
const tag = sanitizeContainerTag(props.tag);
|
||||||
const isBoxed = props.contentWidth === 'boxed';
|
const isBoxed = props.contentWidth === 'boxed';
|
||||||
const flexStyles = flexAlignFromTextAlign(props.style?.textAlign);
|
const flexStyles = flexAlignFromTextAlign(props.style?.textAlign);
|
||||||
|
const hasVerticalAlign = !!props.style?.justifyContent;
|
||||||
|
|
||||||
const outerCss: CSSProperties = {
|
const outerCss: CSSProperties = {
|
||||||
...props.style,
|
...props.style,
|
||||||
|
...(hasVerticalAlign ? { display: 'flex', flexDirection: 'column' } : {}),
|
||||||
...(isBoxed ? {} : flexStyles),
|
...(isBoxed ? {} : flexStyles),
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -73,3 +73,78 @@ describe('Section.toHtml shape divider color/height XSS hardening', () => {
|
|||||||
expect(html).not.toContain('<svg');
|
expect(html).not.toContain('<svg');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('Section.toHtml vertical alignment (justify-content + min-height)', () => {
|
||||||
|
// Regression lock: same rationale as Container -- see Container.toHtml.test.ts.
|
||||||
|
// Section must not unconditionally become a flex container, or it
|
||||||
|
// blockifies inline-block children (ButtonLink, Icon) that are meant to
|
||||||
|
// sit side-by-side in existing published sections.
|
||||||
|
test('does NOT become a flex container when no vertical alignment is set (plain block flow preserved)', () => {
|
||||||
|
const { html } = toHtml({}, 'child');
|
||||||
|
expect(html).not.toContain('display:flex');
|
||||||
|
expect(html).not.toContain('flex-direction');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('does NOT become a flex container from min-height alone (min-height must not itself trigger flex)', () => {
|
||||||
|
const { html } = toHtml({ style: { minHeight: '600px' } }, 'child');
|
||||||
|
expect(html).not.toContain('display:flex');
|
||||||
|
expect(html).not.toContain('flex-direction');
|
||||||
|
expect(html).toContain('min-height:600px');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('becomes a column flex container when style.justifyContent is set (feature still works)', () => {
|
||||||
|
const { html } = toHtml({ style: { justifyContent: 'center' } }, 'child');
|
||||||
|
expect(html).toContain('display:flex');
|
||||||
|
expect(html).toContain('flex-direction:column');
|
||||||
|
expect(html).toContain('justify-content:center');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style.minHeight flows into the emitted style attribute', () => {
|
||||||
|
const { html } = toHtml({ style: { minHeight: '600px' } }, 'child');
|
||||||
|
expect(html).toContain('min-height:600px');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Section.toHtml box-model styles (margin/padding/border/shadow/opacity)', () => {
|
||||||
|
test('margin/padding/border/box-shadow/opacity all flow into the emitted style attribute', () => {
|
||||||
|
const { html } = toHtml(
|
||||||
|
{
|
||||||
|
style: {
|
||||||
|
marginTop: '10px', marginRight: '10px', marginBottom: '10px', marginLeft: '10px',
|
||||||
|
paddingTop: '5px',
|
||||||
|
border: '2px solid #ff0000',
|
||||||
|
boxShadow: '0 4px 8px rgba(0,0,0,0.12)',
|
||||||
|
opacity: '0.8',
|
||||||
|
},
|
||||||
|
},
|
||||||
|
'child',
|
||||||
|
);
|
||||||
|
expect(html).toContain('margin-top:10px');
|
||||||
|
expect(html).toContain('padding-top:5px');
|
||||||
|
expect(html).toContain('border:2px solid #ff0000');
|
||||||
|
expect(html).toContain('box-shadow:0 4px 8px rgba(0,0,0,0.12)');
|
||||||
|
expect(html).toContain('opacity:0.8');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Section.craft.props exposes the vertical-alignment/box-model/animation/visibility rollout', () => {
|
||||||
|
test('animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
||||||
|
const props = (Section as any).craft.props;
|
||||||
|
expect(props.animation).toBe('');
|
||||||
|
expect(props.animationDelay).toBe('0');
|
||||||
|
expect(props.hideOnDesktop).toBe(false);
|
||||||
|
expect(props.hideOnTablet).toBe(false);
|
||||||
|
expect(props.hideOnMobile).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style carries blank/default vertical-alignment and box-model keys', () => {
|
||||||
|
const style = (Section as any).craft.props.style;
|
||||||
|
expect(style).toHaveProperty('justifyContent');
|
||||||
|
expect(style).toHaveProperty('minHeight');
|
||||||
|
expect(style).toHaveProperty('marginTop');
|
||||||
|
expect(style).toHaveProperty('paddingTop');
|
||||||
|
expect(style.border).toBe('none');
|
||||||
|
expect(style.boxShadow).toBe('none');
|
||||||
|
expect(style.opacity).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -27,6 +27,11 @@ interface SectionProps {
|
|||||||
bottomDividerColor?: string;
|
bottomDividerColor?: string;
|
||||||
bottomDividerHeight?: string;
|
bottomDividerHeight?: string;
|
||||||
anchorId?: string;
|
anchorId?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* ---------- Divider renderer ---------- */
|
/* ---------- Divider renderer ---------- */
|
||||||
@@ -98,6 +103,13 @@ export const Section: UserComponent<SectionProps> = ({
|
|||||||
|
|
||||||
const hasTopDivider = topDivider && topDivider !== 'none';
|
const hasTopDivider = topDivider && topDivider !== 'none';
|
||||||
const hasBottomDivider = bottomDivider && bottomDivider !== 'none';
|
const hasBottomDivider = bottomDivider && bottomDivider !== 'none';
|
||||||
|
// Section's root only becomes a column flex container when the user has
|
||||||
|
// actually set `style.justifyContent` (Vertical Alignment control, paired
|
||||||
|
// with `style.minHeight`) -- see the matching note in Container.tsx for
|
||||||
|
// why an unconditional conversion is a real regression (blockifies
|
||||||
|
// deliberately inline-block children like ButtonLink/Icon) rather than a
|
||||||
|
// no-op, so plain block flow is preserved unless vertical-align is set.
|
||||||
|
const hasVerticalAlign = !!style.justifyContent;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<section
|
<section
|
||||||
@@ -107,6 +119,7 @@ export const Section: UserComponent<SectionProps> = ({
|
|||||||
width: '100%',
|
width: '100%',
|
||||||
position: (hasTopDivider || hasBottomDivider) ? 'relative' : undefined,
|
position: (hasTopDivider || hasBottomDivider) ? 'relative' : undefined,
|
||||||
...style,
|
...style,
|
||||||
|
...(hasVerticalAlign ? { display: 'flex', flexDirection: 'column' } : {}),
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
{hasTopDivider && (
|
{hasTopDivider && (
|
||||||
@@ -143,7 +156,17 @@ export const Section: UserComponent<SectionProps> = ({
|
|||||||
Section.craft = {
|
Section.craft = {
|
||||||
displayName: 'Section',
|
displayName: 'Section',
|
||||||
props: {
|
props: {
|
||||||
style: { padding: '40px 0', backgroundColor: '#ffffff' },
|
style: {
|
||||||
|
padding: '40px 0',
|
||||||
|
backgroundColor: '#ffffff',
|
||||||
|
minHeight: '',
|
||||||
|
justifyContent: '',
|
||||||
|
marginTop: '', marginRight: '', marginBottom: '', marginLeft: '',
|
||||||
|
paddingTop: '', paddingRight: '', paddingBottom: '', paddingLeft: '',
|
||||||
|
border: 'none',
|
||||||
|
boxShadow: 'none',
|
||||||
|
opacity: '1',
|
||||||
|
},
|
||||||
innerMaxWidth: '1200px',
|
innerMaxWidth: '1200px',
|
||||||
topDivider: 'none',
|
topDivider: 'none',
|
||||||
topDividerColor: '#ffffff',
|
topDividerColor: '#ffffff',
|
||||||
@@ -152,6 +175,11 @@ Section.craft = {
|
|||||||
bottomDividerColor: '#ffffff',
|
bottomDividerColor: '#ffffff',
|
||||||
bottomDividerHeight: '50px',
|
bottomDividerHeight: '50px',
|
||||||
anchorId: '',
|
anchorId: '',
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '0',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
@@ -199,11 +227,13 @@ function buildDividerHtml(
|
|||||||
(Section as any).toHtml = (props: SectionProps, childrenHtml: string) => {
|
(Section as any).toHtml = (props: SectionProps, childrenHtml: string) => {
|
||||||
const hasTopDivider = props.topDivider && props.topDivider !== 'none';
|
const hasTopDivider = props.topDivider && props.topDivider !== 'none';
|
||||||
const hasBottomDivider = props.bottomDivider && props.bottomDivider !== 'none';
|
const hasBottomDivider = props.bottomDivider && props.bottomDivider !== 'none';
|
||||||
|
const hasVerticalAlign = !!props.style?.justifyContent;
|
||||||
|
|
||||||
const outerStyle = cssPropsToString({
|
const outerStyle = cssPropsToString({
|
||||||
width: '100%',
|
width: '100%',
|
||||||
position: (hasTopDivider || hasBottomDivider) ? 'relative' : undefined,
|
position: (hasTopDivider || hasBottomDivider) ? 'relative' : undefined,
|
||||||
...props.style,
|
...props.style,
|
||||||
|
...(hasVerticalAlign ? { display: 'flex', flexDirection: 'column' } : {}),
|
||||||
});
|
});
|
||||||
const innerStyle = cssPropsToString({
|
const innerStyle = cssPropsToString({
|
||||||
maxWidth: props.innerMaxWidth || '1200px',
|
maxWidth: props.innerMaxWidth || '1200px',
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
import { describe, test, expect } from 'vitest';
|
import { describe, test, expect } from 'vitest';
|
||||||
import { ImageBlock } from './ImageBlock';
|
import { ImageBlock, pxAttr } from './ImageBlock';
|
||||||
|
|
||||||
const toHtml = (ImageBlock as any).toHtml;
|
const toHtml = (ImageBlock as any).toHtml;
|
||||||
|
|
||||||
@@ -32,3 +32,95 @@ describe('ImageBlock.toHtml src/alt XSS hardening', () => {
|
|||||||
expect(html).toContain('alt="A photo"');
|
expect(html).toContain('alt="A photo"');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('ImageBlock.toHtml perf attributes (always emitted)', () => {
|
||||||
|
test('loading="lazy" and decoding="async" are always present', () => {
|
||||||
|
const { html } = toHtml({ src: 'https://example.com/photo.jpg' }, '');
|
||||||
|
expect(html).toContain('loading="lazy"');
|
||||||
|
expect(html).toContain('decoding="async"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('width/height attributes are emitted when the style has plain px values', () => {
|
||||||
|
const { html } = toHtml({ src: 'https://example.com/photo.jpg', style: { width: '400px', height: '300px' } }, '');
|
||||||
|
expect(html).toContain('width="400"');
|
||||||
|
expect(html).toContain('height="300"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('width/height attributes are omitted when the style value is not a plain px length', () => {
|
||||||
|
const { html } = toHtml({ src: 'https://example.com/photo.jpg', style: { width: '50%', height: 'auto' } }, '');
|
||||||
|
expect(html).not.toMatch(/\swidth="/);
|
||||||
|
expect(html).not.toMatch(/\sheight="/);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('pxAttr', () => {
|
||||||
|
test('extracts the numeric portion of a plain px length', () => {
|
||||||
|
expect(pxAttr('400px')).toBe('400');
|
||||||
|
expect(pxAttr('12.5px')).toBe('12.5');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('returns undefined for non-px units, non-string, or unset values', () => {
|
||||||
|
expect(pxAttr('50%')).toBeUndefined();
|
||||||
|
expect(pxAttr('auto')).toBeUndefined();
|
||||||
|
expect(pxAttr(undefined)).toBeUndefined();
|
||||||
|
expect(pxAttr(400)).toBeUndefined();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('ImageBlock.toHtml CSS framing crop (aspect-ratio + object-fit + object-position)', () => {
|
||||||
|
test('style.aspectRatio, objectFit, objectPosition all flow into the emitted style attribute', () => {
|
||||||
|
const { html } = toHtml(
|
||||||
|
{ src: 'https://example.com/photo.jpg', style: { aspectRatio: '16 / 9', objectFit: 'cover', objectPosition: 'center top' } },
|
||||||
|
''
|
||||||
|
);
|
||||||
|
expect(html).toContain('aspect-ratio:16 / 9');
|
||||||
|
expect(html).toContain('object-fit:cover');
|
||||||
|
expect(html).toContain('object-position:center top');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('ImageBlock.toHtml box-model styles (margin/padding/border/shadow/opacity)', () => {
|
||||||
|
test('margin/padding/border/box-shadow/opacity all flow into the emitted style attribute', () => {
|
||||||
|
const { html } = toHtml(
|
||||||
|
{
|
||||||
|
src: 'https://example.com/photo.jpg',
|
||||||
|
style: {
|
||||||
|
marginTop: '10px', marginRight: '10px', marginBottom: '10px', marginLeft: '10px',
|
||||||
|
paddingTop: '5px',
|
||||||
|
border: '2px solid #ff0000',
|
||||||
|
boxShadow: '0 4px 8px rgba(0,0,0,0.12)',
|
||||||
|
opacity: '0.8',
|
||||||
|
},
|
||||||
|
},
|
||||||
|
''
|
||||||
|
);
|
||||||
|
expect(html).toContain('margin-top:10px');
|
||||||
|
expect(html).toContain('padding-top:5px');
|
||||||
|
expect(html).toContain('border:2px solid #ff0000');
|
||||||
|
expect(html).toContain('box-shadow:0 4px 8px rgba(0,0,0,0.12)');
|
||||||
|
expect(html).toContain('opacity:0.8');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('ImageBlock.craft.props exposes the box-model/animation/visibility rollout', () => {
|
||||||
|
test('animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
||||||
|
const props = (ImageBlock as any).craft.props;
|
||||||
|
expect(props.animation).toBe('');
|
||||||
|
expect(props.animationDelay).toBe('0');
|
||||||
|
expect(props.hideOnDesktop).toBe(false);
|
||||||
|
expect(props.hideOnTablet).toBe(false);
|
||||||
|
expect(props.hideOnMobile).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style carries blank/default box-model and crop keys', () => {
|
||||||
|
const style = (ImageBlock as any).craft.props.style;
|
||||||
|
expect(style).toHaveProperty('aspectRatio');
|
||||||
|
expect(style).toHaveProperty('objectFit');
|
||||||
|
expect(style).toHaveProperty('objectPosition');
|
||||||
|
expect(style).toHaveProperty('marginTop');
|
||||||
|
expect(style).toHaveProperty('paddingTop');
|
||||||
|
expect(style.border).toBe('none');
|
||||||
|
expect(style.boxShadow).toBe('none');
|
||||||
|
expect(style.opacity).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -9,6 +9,23 @@ interface ImageBlockProps {
|
|||||||
src?: string;
|
src?: string;
|
||||||
alt?: string;
|
alt?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Extracts the numeric portion of a plain "<n>px" CSS length string, for
|
||||||
|
* emitting real `width`/`height` HTML attributes on the exported `<img>`
|
||||||
|
* (helps the browser reserve layout space before the image loads --
|
||||||
|
* avoiding CLS -- something a CSS-only width/height can't do on its own).
|
||||||
|
* Returns undefined for any other unit ('%', 'auto', '', etc.) so the
|
||||||
|
* attribute is simply omitted when the pixel size isn't known. */
|
||||||
|
export function pxAttr(v: unknown): string | undefined {
|
||||||
|
if (typeof v !== 'string') return undefined;
|
||||||
|
const m = v.trim().match(/^(\d+(?:\.\d+)?)px$/);
|
||||||
|
return m ? m[1] : undefined;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Helper: upload a file to the WHP API and return the proxy URL
|
// Helper: upload a file to the WHP API and return the proxy URL
|
||||||
@@ -83,7 +100,27 @@ export const ImageBlock: UserComponent<ImageBlockProps> = ({
|
|||||||
|
|
||||||
ImageBlock.craft = {
|
ImageBlock.craft = {
|
||||||
displayName: 'Image',
|
displayName: 'Image',
|
||||||
props: { src: PLACEHOLDER_SRC, alt: '', style: { width: '100%', height: 'auto' } },
|
props: {
|
||||||
|
src: PLACEHOLDER_SRC,
|
||||||
|
alt: '',
|
||||||
|
style: {
|
||||||
|
width: '100%',
|
||||||
|
height: 'auto',
|
||||||
|
aspectRatio: '',
|
||||||
|
objectFit: '' as CSSProperties['objectFit'],
|
||||||
|
objectPosition: '',
|
||||||
|
marginTop: '', marginRight: '', marginBottom: '', marginLeft: '',
|
||||||
|
paddingTop: '', paddingRight: '', paddingBottom: '', paddingLeft: '',
|
||||||
|
border: 'none',
|
||||||
|
boxShadow: 'none',
|
||||||
|
opacity: '1',
|
||||||
|
},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '0',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
|
},
|
||||||
rules: { canDrag: () => true, canMoveIn: () => false, canMoveOut: () => true },
|
rules: { canDrag: () => true, canMoveIn: () => false, canMoveOut: () => true },
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -95,5 +132,8 @@ ImageBlock.craft = {
|
|||||||
}
|
}
|
||||||
const s = cssPropsToString({ display: 'block', maxWidth: '100%', ...props.style });
|
const s = cssPropsToString({ display: 'block', maxWidth: '100%', ...props.style });
|
||||||
const alt = props.alt ? ` alt="${escapeAttr(props.alt)}"` : ' alt=""';
|
const alt = props.alt ? ` alt="${escapeAttr(props.alt)}"` : ' alt=""';
|
||||||
return { html: `<img src="${escapeAttr(safeImageUrl(src))}"${alt}${s ? ` style="${s}"` : ''} />` };
|
const widthAttr = pxAttr((props.style as any)?.width);
|
||||||
|
const heightAttr = pxAttr((props.style as any)?.height);
|
||||||
|
const dims = `${widthAttr ? ` width="${widthAttr}"` : ''}${heightAttr ? ` height="${heightAttr}"` : ''}`;
|
||||||
|
return { html: `<img src="${escapeAttr(safeImageUrl(src))}"${alt}${dims} loading="lazy" decoding="async"${s ? ` style="${s}"` : ''} />` };
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -28,6 +28,49 @@ describe('MapEmbed.toHtml iframe src ampersand encoding (F-export review Minor)'
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('MapEmbed.toHtml box-model styles (margin/padding/border/shadow/opacity)', () => {
|
||||||
|
test('margin/padding/border/box-shadow/opacity all flow into the wrapper style attribute', () => {
|
||||||
|
const { html } = toHtml(
|
||||||
|
{
|
||||||
|
address: 'New York, NY',
|
||||||
|
style: {
|
||||||
|
marginTop: '16px',
|
||||||
|
paddingRight: '4px',
|
||||||
|
border: '1px solid #cccccc',
|
||||||
|
boxShadow: '0 4px 8px rgba(0,0,0,0.12)',
|
||||||
|
opacity: '0.95',
|
||||||
|
},
|
||||||
|
},
|
||||||
|
''
|
||||||
|
);
|
||||||
|
expect(html).toContain('margin-top:16px');
|
||||||
|
expect(html).toContain('padding-right:4px');
|
||||||
|
expect(html).toContain('border:1px solid #cccccc');
|
||||||
|
expect(html).toContain('box-shadow:0 4px 8px rgba(0,0,0,0.12)');
|
||||||
|
expect(html).toContain('opacity:0.95');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('MapEmbed.craft.props exposes the animation/visibility rollout', () => {
|
||||||
|
test('animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
||||||
|
const props = (MapEmbed as any).craft.props;
|
||||||
|
expect(props.animation).toBe('');
|
||||||
|
expect(props.animationDelay).toBe('0');
|
||||||
|
expect(props.hideOnDesktop).toBe(false);
|
||||||
|
expect(props.hideOnTablet).toBe(false);
|
||||||
|
expect(props.hideOnMobile).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style carries blank/default box-model keys', () => {
|
||||||
|
const style = (MapEmbed as any).craft.props.style;
|
||||||
|
expect(style).toHaveProperty('marginTop');
|
||||||
|
expect(style).toHaveProperty('paddingTop');
|
||||||
|
expect(style.border).toBe('none');
|
||||||
|
expect(style.boxShadow).toBe('none');
|
||||||
|
expect(style.opacity).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe('MapEmbed.toHtml address/zoom/height XSS hardening', () => {
|
describe('MapEmbed.toHtml address/zoom/height XSS hardening', () => {
|
||||||
test('a malicious address cannot break out of the src or title attribute', () => {
|
test('a malicious address cannot break out of the src or title attribute', () => {
|
||||||
const malicious = 'X" onerror="alert(1)';
|
const malicious = 'X" onerror="alert(1)';
|
||||||
|
|||||||
@@ -8,6 +8,11 @@ interface MapEmbedProps {
|
|||||||
zoom?: number;
|
zoom?: number;
|
||||||
height?: string;
|
height?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
function buildMapUrl(address: string, zoom: number): string {
|
function buildMapUrl(address: string, zoom: number): string {
|
||||||
@@ -70,7 +75,18 @@ MapEmbed.craft = {
|
|||||||
address: 'New York, NY',
|
address: 'New York, NY',
|
||||||
zoom: 14,
|
zoom: 14,
|
||||||
height: '400px',
|
height: '400px',
|
||||||
style: {},
|
style: {
|
||||||
|
marginTop: '', marginRight: '', marginBottom: '', marginLeft: '',
|
||||||
|
paddingTop: '', paddingRight: '', paddingBottom: '', paddingLeft: '',
|
||||||
|
border: 'none',
|
||||||
|
boxShadow: 'none',
|
||||||
|
opacity: '1',
|
||||||
|
},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '0',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -118,3 +118,75 @@ describe('VideoBlock.toHtml iframe src ampersand encoding (F-export review Minor
|
|||||||
expect(srcMatch![1]).not.toMatch(/&(?!amp;)/);
|
expect(srcMatch![1]).not.toMatch(/&(?!amp;)/);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('VideoBlock.toHtml size + aspect ratio (frame honors style props, not a hardcoded 16:9)', () => {
|
||||||
|
test('direct file: style.width flows to the wrapper, style.aspectRatio flows to the <video>', () => {
|
||||||
|
const { html } = toHtml({ videoUrl: 'https://example.com/clip.mp4', style: { width: '50%', aspectRatio: '4 / 3' } }, '');
|
||||||
|
expect(html).toMatch(/<div style="[^"]*width:50%[^"]*"/);
|
||||||
|
expect(html).toMatch(/<video[^>]*style="[^"]*aspect-ratio:4 \/ 3[^"]*"/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('direct file: no aspectRatio set -- no aspect-ratio declaration is forced onto the <video>', () => {
|
||||||
|
const { html } = toHtml({ videoUrl: 'https://example.com/clip.mp4' }, '');
|
||||||
|
const videoTag = html.match(/<video[^>]*>/)![0];
|
||||||
|
expect(videoTag).not.toContain('aspect-ratio');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('YouTube/Vimeo: style.aspectRatio overrides the 16:9 default on the iframe container', () => {
|
||||||
|
const { html } = toHtml({ videoUrl: 'https://vimeo.com/123456789', style: { aspectRatio: '1 / 1' } }, '');
|
||||||
|
expect(html).toMatch(/<div[^>]*style="[^"]*aspect-ratio:1 \/ 1[^"]*"[^>]*><iframe/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('YouTube/Vimeo: defaults to 16 / 9 when no aspectRatio style is set', () => {
|
||||||
|
const { html } = toHtml({ videoUrl: 'https://vimeo.com/123456789' }, '');
|
||||||
|
expect(html).toMatch(/<div[^>]*style="[^"]*aspect-ratio:16 \/ 9[^"]*"[^>]*><iframe/);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('VideoBlock.toHtml poster + preload (file type)', () => {
|
||||||
|
test('poster attribute is emitted (escaped) and preload="metadata" is always present on a direct file', () => {
|
||||||
|
const { html } = toHtml({ videoUrl: 'https://example.com/clip.mp4', poster: 'https://example.com/poster.jpg' }, '');
|
||||||
|
expect(html).toContain('poster="https://example.com/poster.jpg"');
|
||||||
|
expect(html).toContain('preload="metadata"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('no poster prop -- no poster attribute is emitted, but preload="metadata" still is', () => {
|
||||||
|
const { html } = toHtml({ videoUrl: 'https://example.com/clip.mp4' }, '');
|
||||||
|
expect(html).not.toContain('poster=');
|
||||||
|
expect(html).toContain('preload="metadata"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a malicious poster (javascript: scheme) is blocked by safeImageUrl', () => {
|
||||||
|
const { html } = toHtml({ videoUrl: 'https://example.com/clip.mp4', poster: 'javascript:alert(1)' }, '');
|
||||||
|
expect(html).not.toContain('javascript:');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a poster value cannot break out of the poster attribute', () => {
|
||||||
|
const malicious = 'https://example.com/x.jpg" onerror="alert(1)';
|
||||||
|
const { html } = toHtml({ videoUrl: 'https://example.com/clip.mp4', poster: malicious }, '');
|
||||||
|
expect(html).not.toContain('onerror="alert(1)"');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('VideoBlock.craft.props exposes the box-model/animation/visibility rollout', () => {
|
||||||
|
test('poster, animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
||||||
|
const props = (VideoBlock as any).craft.props;
|
||||||
|
expect(props.poster).toBe('');
|
||||||
|
expect(props.animation).toBe('');
|
||||||
|
expect(props.animationDelay).toBe('0');
|
||||||
|
expect(props.hideOnDesktop).toBe(false);
|
||||||
|
expect(props.hideOnTablet).toBe(false);
|
||||||
|
expect(props.hideOnMobile).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style carries blank/default box-model + size/aspect keys', () => {
|
||||||
|
const style = (VideoBlock as any).craft.props.style;
|
||||||
|
expect(style).toHaveProperty('width');
|
||||||
|
expect(style).toHaveProperty('aspectRatio');
|
||||||
|
expect(style).toHaveProperty('marginTop');
|
||||||
|
expect(style).toHaveProperty('paddingTop');
|
||||||
|
expect(style.border).toBe('none');
|
||||||
|
expect(style.boxShadow).toBe('none');
|
||||||
|
expect(style.opacity).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -2,7 +2,7 @@ import React, { CSSProperties } from 'react';
|
|||||||
import { useNode, Element, UserComponent } from '@craftjs/core';
|
import { useNode, Element, UserComponent } from '@craftjs/core';
|
||||||
import { Container } from '../layout/Container';
|
import { Container } from '../layout/Container';
|
||||||
import { cssPropsToString } from '../../utils/style-helpers';
|
import { cssPropsToString } from '../../utils/style-helpers';
|
||||||
import { escapeAttr, safeUrl } from '../../utils/escape';
|
import { escapeAttr, safeUrl, safeImageUrl } from '../../utils/escape';
|
||||||
|
|
||||||
/* ---------- Types ---------- */
|
/* ---------- Types ---------- */
|
||||||
|
|
||||||
@@ -12,6 +12,7 @@ interface VideoBlockProps {
|
|||||||
videoUrl?: string;
|
videoUrl?: string;
|
||||||
videoType?: VideoType;
|
videoType?: VideoType;
|
||||||
embedUrl?: string;
|
embedUrl?: string;
|
||||||
|
poster?: string;
|
||||||
autoplay?: boolean;
|
autoplay?: boolean;
|
||||||
muted?: boolean;
|
muted?: boolean;
|
||||||
loop?: boolean;
|
loop?: boolean;
|
||||||
@@ -22,6 +23,11 @@ interface VideoBlockProps {
|
|||||||
innerMaxWidth?: string;
|
innerMaxWidth?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
children?: React.ReactNode;
|
children?: React.ReactNode;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* ---------- URL detection ---------- */
|
/* ---------- URL detection ---------- */
|
||||||
@@ -120,6 +126,7 @@ export const VideoBlock: UserComponent<VideoBlockProps> = ({
|
|||||||
videoUrl = '',
|
videoUrl = '',
|
||||||
videoType: _videoTypeProp,
|
videoType: _videoTypeProp,
|
||||||
embedUrl: _embedUrlProp,
|
embedUrl: _embedUrlProp,
|
||||||
|
poster = '',
|
||||||
autoplay = false,
|
autoplay = false,
|
||||||
muted = true,
|
muted = true,
|
||||||
loop = false,
|
loop = false,
|
||||||
@@ -259,8 +266,7 @@ export const VideoBlock: UserComponent<VideoBlockProps> = ({
|
|||||||
<div
|
<div
|
||||||
style={{
|
style={{
|
||||||
position: 'relative',
|
position: 'relative',
|
||||||
paddingBottom: '56.25%',
|
aspectRatio: (style as any)?.aspectRatio || '16 / 9',
|
||||||
height: 0,
|
|
||||||
overflow: 'hidden',
|
overflow: 'hidden',
|
||||||
borderRadius: (style as any)?.borderRadius || undefined,
|
borderRadius: (style as any)?.borderRadius || undefined,
|
||||||
}}
|
}}
|
||||||
@@ -269,8 +275,7 @@ export const VideoBlock: UserComponent<VideoBlockProps> = ({
|
|||||||
src={buildEmbedParams(embedUrl, { autoplay, muted, loop, controls })}
|
src={buildEmbedParams(embedUrl, { autoplay, muted, loop, controls })}
|
||||||
style={{
|
style={{
|
||||||
position: 'absolute',
|
position: 'absolute',
|
||||||
top: 0,
|
inset: 0,
|
||||||
left: 0,
|
|
||||||
width: '100%',
|
width: '100%',
|
||||||
height: '100%',
|
height: '100%',
|
||||||
border: 'none',
|
border: 'none',
|
||||||
@@ -284,14 +289,18 @@ export const VideoBlock: UserComponent<VideoBlockProps> = ({
|
|||||||
{type === 'file' && (
|
{type === 'file' && (
|
||||||
<video
|
<video
|
||||||
src={embedUrl}
|
src={embedUrl}
|
||||||
|
poster={poster || undefined}
|
||||||
autoPlay={autoplay}
|
autoPlay={autoplay}
|
||||||
muted={muted}
|
muted={muted}
|
||||||
loop={loop}
|
loop={loop}
|
||||||
controls={controls}
|
controls={controls}
|
||||||
|
preload="metadata"
|
||||||
playsInline
|
playsInline
|
||||||
style={{
|
style={{
|
||||||
display: 'block',
|
display: 'block',
|
||||||
width: '100%',
|
width: '100%',
|
||||||
|
aspectRatio: (style as any)?.aspectRatio || undefined,
|
||||||
|
objectFit: 'cover',
|
||||||
borderRadius: (style as any)?.borderRadius || undefined,
|
borderRadius: (style as any)?.borderRadius || undefined,
|
||||||
}}
|
}}
|
||||||
/>
|
/>
|
||||||
@@ -310,6 +319,7 @@ VideoBlock.craft = {
|
|||||||
videoUrl: '',
|
videoUrl: '',
|
||||||
videoType: 'none',
|
videoType: 'none',
|
||||||
embedUrl: '',
|
embedUrl: '',
|
||||||
|
poster: '',
|
||||||
autoplay: false,
|
autoplay: false,
|
||||||
muted: true,
|
muted: true,
|
||||||
loop: false,
|
loop: false,
|
||||||
@@ -318,7 +328,20 @@ VideoBlock.craft = {
|
|||||||
overlayColor: '#000000',
|
overlayColor: '#000000',
|
||||||
overlayOpacity: 50,
|
overlayOpacity: 50,
|
||||||
innerMaxWidth: '1200px',
|
innerMaxWidth: '1200px',
|
||||||
style: {},
|
style: {
|
||||||
|
width: '',
|
||||||
|
aspectRatio: '',
|
||||||
|
marginTop: '', marginRight: '', marginBottom: '', marginLeft: '',
|
||||||
|
paddingTop: '', paddingRight: '', paddingBottom: '', paddingLeft: '',
|
||||||
|
border: 'none',
|
||||||
|
boxShadow: 'none',
|
||||||
|
opacity: '1',
|
||||||
|
},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '0',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
@@ -334,6 +357,7 @@ VideoBlock.craft = {
|
|||||||
(VideoBlock as any).toHtml = (props: VideoBlockProps, childrenHtml: string) => {
|
(VideoBlock as any).toHtml = (props: VideoBlockProps, childrenHtml: string) => {
|
||||||
const {
|
const {
|
||||||
videoUrl = '',
|
videoUrl = '',
|
||||||
|
poster = '',
|
||||||
autoplay = false,
|
autoplay = false,
|
||||||
muted = true,
|
muted = true,
|
||||||
loop: doLoop = false,
|
loop: doLoop = false,
|
||||||
@@ -422,15 +446,13 @@ VideoBlock.craft = {
|
|||||||
const iframeSrc = buildEmbedParams(embedUrl, { autoplay, muted, loop: doLoop, controls });
|
const iframeSrc = buildEmbedParams(embedUrl, { autoplay, muted, loop: doLoop, controls });
|
||||||
const containerStyle = cssPropsToString({
|
const containerStyle = cssPropsToString({
|
||||||
position: 'relative',
|
position: 'relative',
|
||||||
paddingBottom: '56.25%',
|
aspectRatio: (style as any)?.aspectRatio || '16 / 9',
|
||||||
height: '0',
|
|
||||||
overflow: 'hidden',
|
overflow: 'hidden',
|
||||||
borderRadius: (style as any)?.borderRadius || undefined,
|
borderRadius: (style as any)?.borderRadius || undefined,
|
||||||
});
|
});
|
||||||
const iframeStyle = cssPropsToString({
|
const iframeStyle = cssPropsToString({
|
||||||
position: 'absolute',
|
position: 'absolute',
|
||||||
top: '0',
|
inset: '0',
|
||||||
left: '0',
|
|
||||||
width: '100%',
|
width: '100%',
|
||||||
height: '100%',
|
height: '100%',
|
||||||
border: 'none',
|
border: 'none',
|
||||||
@@ -447,13 +469,16 @@ VideoBlock.craft = {
|
|||||||
if (doLoop) vidAttrs.push('loop');
|
if (doLoop) vidAttrs.push('loop');
|
||||||
if (controls) vidAttrs.push('controls');
|
if (controls) vidAttrs.push('controls');
|
||||||
vidAttrs.push('playsinline');
|
vidAttrs.push('playsinline');
|
||||||
|
const posterAttr = poster ? ` poster="${escapeAttr(safeImageUrl(poster))}"` : '';
|
||||||
const vidStyle = cssPropsToString({
|
const vidStyle = cssPropsToString({
|
||||||
display: 'block',
|
display: 'block',
|
||||||
width: '100%',
|
width: '100%',
|
||||||
|
aspectRatio: (style as any)?.aspectRatio || undefined,
|
||||||
|
objectFit: 'cover',
|
||||||
borderRadius: (style as any)?.borderRadius || undefined,
|
borderRadius: (style as any)?.borderRadius || undefined,
|
||||||
});
|
});
|
||||||
|
|
||||||
return {
|
return {
|
||||||
html: `<div${wrapperStyle ? ` style="${wrapperStyle}"` : ''}><video src="${escapeAttr(safeUrl(embedUrl))}" ${vidAttrs.join(' ')}${vidStyle ? ` style="${vidStyle}"` : ''}></video></div>`,
|
html: `<div${wrapperStyle ? ` style="${wrapperStyle}"` : ''}><video src="${escapeAttr(safeUrl(embedUrl))}"${posterAttr} preload="metadata" ${vidAttrs.join(' ')}${vidStyle ? ` style="${vidStyle}"` : ''}></video></div>`,
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -0,0 +1,38 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import { Accordion } from './Accordion';
|
||||||
|
|
||||||
|
const toHtml = (Accordion as any).toHtml;
|
||||||
|
|
||||||
|
const items = [
|
||||||
|
{ title: 'Q1', content: 'A1', isOpen: true },
|
||||||
|
{ title: 'Q2', content: 'A2', isOpen: false },
|
||||||
|
];
|
||||||
|
|
||||||
|
describe('Accordion.toHtml basic export', () => {
|
||||||
|
test('renders a <details> per item with the open attribute honored', () => {
|
||||||
|
const { html } = toHtml({ items }, '');
|
||||||
|
const detailsBlocks = html.match(/<details[^>]*>/g) || [];
|
||||||
|
expect(detailsBlocks.length).toBe(2);
|
||||||
|
expect(detailsBlocks[0]).toContain(' open');
|
||||||
|
expect(detailsBlocks[1]).not.toContain(' open');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('headerBg/headerColor/contentBg/borderColor emit into the panel styles', () => {
|
||||||
|
const { html } = toHtml({ items, headerBg: '#111111', headerColor: '#222222', contentBg: '#333333', borderColor: '#444444' }, '');
|
||||||
|
expect(html).toContain('#111111');
|
||||||
|
expect(html).toContain('#222222');
|
||||||
|
expect(html).toContain('#333333');
|
||||||
|
expect(html).toContain('#444444');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Accordion.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (Accordion as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -17,6 +17,11 @@ interface AccordionProps {
|
|||||||
contentBg?: string;
|
contentBg?: string;
|
||||||
borderColor?: string;
|
borderColor?: string;
|
||||||
anchorId?: string;
|
anchorId?: string;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const defaultItems: AccordionItem[] = [
|
const defaultItems: AccordionItem[] = [
|
||||||
@@ -135,6 +140,11 @@ Accordion.craft = {
|
|||||||
contentBg: '#ffffff',
|
contentBg: '#ffffff',
|
||||||
borderColor: '#e2e8f0',
|
borderColor: '#e2e8f0',
|
||||||
anchorId: '',
|
anchorId: '',
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -0,0 +1,37 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import { CTASection } from './CTASection';
|
||||||
|
|
||||||
|
const toHtml = (CTASection as any).toHtml;
|
||||||
|
|
||||||
|
describe('CTASection.toHtml basic export', () => {
|
||||||
|
test('renders heading, description, and CTA buttons', () => {
|
||||||
|
const { html } = toHtml({ heading: 'Hi', description: 'Sub', ctas: [{ text: 'Go', href: '#', variant: 'primary' }] }, '');
|
||||||
|
expect(html).toContain('Hi');
|
||||||
|
expect(html).toContain('Sub');
|
||||||
|
expect(html).toContain('Go');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('box-model style props (margin/padding/border/boxShadow/opacity) flow through to the section style=""', () => {
|
||||||
|
const { html } = toHtml({
|
||||||
|
heading: 'Hi',
|
||||||
|
description: 'Sub',
|
||||||
|
style: { marginTop: '10px', paddingLeft: '5px', border: '1px solid #000', boxShadow: '0 1px 2px rgba(0,0,0,0.1)', opacity: '0.5' },
|
||||||
|
}, '');
|
||||||
|
expect(html).toContain('margin-top:10px');
|
||||||
|
expect(html).toContain('padding-left:5px');
|
||||||
|
expect(html).toContain('border:1px solid #000');
|
||||||
|
expect(html).toContain('box-shadow:0 1px 2px rgba(0,0,0,0.1)');
|
||||||
|
expect(html).toContain('opacity:0.5');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('CTASection.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (CTASection as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -14,6 +14,11 @@ interface CTASectionProps {
|
|||||||
gradient?: string;
|
gradient?: string;
|
||||||
anchorId?: string;
|
anchorId?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const defaultGradient = 'linear-gradient(135deg, #2563eb 0%, #7c3aed 100%)';
|
const defaultGradient = 'linear-gradient(135deg, #2563eb 0%, #7c3aed 100%)';
|
||||||
@@ -83,6 +88,11 @@ CTASection.craft = {
|
|||||||
gradient: defaultGradient,
|
gradient: defaultGradient,
|
||||||
anchorId: '',
|
anchorId: '',
|
||||||
style: {},
|
style: {},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -0,0 +1,37 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import { CallToAction } from './CallToAction';
|
||||||
|
|
||||||
|
const toHtml = (CallToAction as any).toHtml;
|
||||||
|
|
||||||
|
describe('CallToAction.toHtml basic export', () => {
|
||||||
|
test('renders heading, description, and CTA buttons', () => {
|
||||||
|
const { html } = toHtml({ heading: 'Hi', description: 'Sub', ctas: [{ text: 'Go', href: '#', variant: 'primary' }] }, '');
|
||||||
|
expect(html).toContain('Hi');
|
||||||
|
expect(html).toContain('Sub');
|
||||||
|
expect(html).toContain('Go');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('box-model style props (margin/padding/border/boxShadow/opacity) flow through to the section style=""', () => {
|
||||||
|
const { html } = toHtml({
|
||||||
|
heading: 'Hi',
|
||||||
|
description: 'Sub',
|
||||||
|
style: { marginBottom: '12px', paddingRight: '6px', border: '2px dashed #333', boxShadow: '0 4px 8px rgba(0,0,0,0.12)', opacity: '0.75' },
|
||||||
|
}, '');
|
||||||
|
expect(html).toContain('margin-bottom:12px');
|
||||||
|
expect(html).toContain('padding-right:6px');
|
||||||
|
expect(html).toContain('border:2px dashed #333');
|
||||||
|
expect(html).toContain('box-shadow:0 4px 8px rgba(0,0,0,0.12)');
|
||||||
|
expect(html).toContain('opacity:0.75');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('CallToAction.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (CallToAction as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -21,6 +21,11 @@ interface CallToActionProps {
|
|||||||
buttonColor?: string;
|
buttonColor?: string;
|
||||||
anchorId?: string;
|
anchorId?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const defaultGradient = 'linear-gradient(135deg, #2563eb 0%, #7c3aed 100%)';
|
const defaultGradient = 'linear-gradient(135deg, #2563eb 0%, #7c3aed 100%)';
|
||||||
@@ -131,6 +136,11 @@ CallToAction.craft = {
|
|||||||
textColor: '#ffffff',
|
textColor: '#ffffff',
|
||||||
buttonColor: '#ffffff',
|
buttonColor: '#ffffff',
|
||||||
style: {},
|
style: {},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -139,3 +139,46 @@ describe('ContentSlider.toHtml interval is NOT runtime-type-checked -- must be c
|
|||||||
expect(html).toMatch(/setInterval\(function\(\)\{show\(current\+1\);\},3000\);/);
|
expect(html).toMatch(/setInterval\(function\(\)\{show\(current\+1\);\},3000\);/);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('ContentSlider.toHtml box-model styles (margin/padding/border/shadow/opacity)', () => {
|
||||||
|
test('margin/padding/border/box-shadow/opacity all flow into the section style attribute', () => {
|
||||||
|
const { html } = toHtml(
|
||||||
|
{
|
||||||
|
slides,
|
||||||
|
style: {
|
||||||
|
marginBottom: '24px',
|
||||||
|
paddingTop: '8px',
|
||||||
|
border: '3px dashed #00ff00',
|
||||||
|
boxShadow: '0 10px 24px rgba(0,0,0,0.18)',
|
||||||
|
opacity: '0.75',
|
||||||
|
},
|
||||||
|
},
|
||||||
|
''
|
||||||
|
);
|
||||||
|
expect(html).toContain('margin-bottom:24px');
|
||||||
|
expect(html).toContain('padding-top:8px');
|
||||||
|
expect(html).toContain('border:3px dashed #00ff00');
|
||||||
|
expect(html).toContain('box-shadow:0 10px 24px rgba(0,0,0,0.18)');
|
||||||
|
expect(html).toContain('opacity:0.75');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('ContentSlider.craft.props exposes the animation/visibility rollout', () => {
|
||||||
|
test('animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
||||||
|
const props = (ContentSlider as any).craft.props;
|
||||||
|
expect(props.animation).toBe('');
|
||||||
|
expect(props.animationDelay).toBe('0');
|
||||||
|
expect(props.hideOnDesktop).toBe(false);
|
||||||
|
expect(props.hideOnTablet).toBe(false);
|
||||||
|
expect(props.hideOnMobile).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style carries blank/default box-model keys', () => {
|
||||||
|
const style = (ContentSlider as any).craft.props.style;
|
||||||
|
expect(style).toHaveProperty('marginTop');
|
||||||
|
expect(style).toHaveProperty('paddingTop');
|
||||||
|
expect(style.border).toBe('none');
|
||||||
|
expect(style.boxShadow).toBe('none');
|
||||||
|
expect(style.opacity).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -21,6 +21,11 @@ interface ContentSliderProps {
|
|||||||
showArrows?: boolean;
|
showArrows?: boolean;
|
||||||
height?: string;
|
height?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const defaultSlides: Slide[] = [
|
const defaultSlides: Slide[] = [
|
||||||
@@ -227,7 +232,18 @@ ContentSlider.craft = {
|
|||||||
showDots: true,
|
showDots: true,
|
||||||
showArrows: true,
|
showArrows: true,
|
||||||
height: '400px',
|
height: '400px',
|
||||||
style: {},
|
style: {
|
||||||
|
marginTop: '', marginRight: '', marginBottom: '', marginLeft: '',
|
||||||
|
paddingTop: '', paddingRight: '', paddingBottom: '', paddingLeft: '',
|
||||||
|
border: 'none',
|
||||||
|
boxShadow: 'none',
|
||||||
|
opacity: '1',
|
||||||
|
},
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '0',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -62,3 +62,14 @@ describe('Countdown.toHtml script nit: ticking interval stops at zero', () => {
|
|||||||
expect(html).toMatch(/if\s*\(\s*target\s*-\s*Date\.now\(\)\s*>\s*0\s*\)\s*\{/);
|
expect(html).toMatch(/if\s*\(\s*target\s*-\s*Date\.now\(\)\s*>\s*0\s*\)\s*\{/);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('Countdown.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (Countdown as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -11,6 +11,11 @@ interface CountdownProps {
|
|||||||
labelColor?: string;
|
labelColor?: string;
|
||||||
bgColor?: string;
|
bgColor?: string;
|
||||||
anchorId?: string;
|
anchorId?: string;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
interface TimeLeft {
|
interface TimeLeft {
|
||||||
@@ -139,6 +144,11 @@ Countdown.craft = {
|
|||||||
labelColor: 'rgba(255,255,255,0.7)',
|
labelColor: 'rgba(255,255,255,0.7)',
|
||||||
bgColor: '#18181b',
|
bgColor: '#18181b',
|
||||||
anchorId: '',
|
anchorId: '',
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -21,3 +21,14 @@ describe('FeaturesGrid.toHtml image sink uses safeImageUrl (data:image/svg+xml a
|
|||||||
expect(html).toMatch(/<a href=""/);
|
expect(html).toMatch(/<a href=""/);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('FeaturesGrid.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (FeaturesGrid as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -17,6 +17,11 @@ interface FeaturesGridProps {
|
|||||||
features?: FeatureItem[];
|
features?: FeatureItem[];
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
anchorId?: string;
|
anchorId?: string;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Keys image/imageAlt/buttonText/buttonUrl are present (blank) on the defaults so
|
// Keys image/imageAlt/buttonText/buttonUrl are present (blank) on the defaults so
|
||||||
@@ -98,6 +103,11 @@ FeaturesGrid.craft = {
|
|||||||
features: defaultFeatures,
|
features: defaultFeatures,
|
||||||
style: { backgroundColor: '#ffffff' },
|
style: { backgroundColor: '#ffffff' },
|
||||||
anchorId: '',
|
anchorId: '',
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -3,6 +3,73 @@ import { Gallery } from './Gallery';
|
|||||||
|
|
||||||
const toHtml = (Gallery as any).toHtml;
|
const toHtml = (Gallery as any).toHtml;
|
||||||
|
|
||||||
|
describe('Gallery.toHtml columns + lightbox controls (previously unexposed props)', () => {
|
||||||
|
test('columns drives the grid-template-columns repeat count', () => {
|
||||||
|
const { html } = toHtml({ images: [{ src: '/a.jpg', alt: 'a' }], columns: 5 }, '');
|
||||||
|
expect(html).toContain('grid-template-columns:repeat(5,1fr)');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('lightbox=true adds the delegated-listener overlay markup (columns unaffected)', () => {
|
||||||
|
const { html } = toHtml({ images: [{ src: '/a.jpg', alt: 'a' }], columns: 4, lightbox: true }, '');
|
||||||
|
expect(html).toContain('grid-template-columns:repeat(4,1fr)');
|
||||||
|
expect(html).toContain('role="dialog"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a non-numeric columns value falls back safely (Number() coercion, not NaN in the template)', () => {
|
||||||
|
const { html } = toHtml({ images: [{ src: '/a.jpg' }], columns: 'not-a-number' as any }, '');
|
||||||
|
expect(html).toContain('grid-template-columns:repeat(3,1fr)');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Gallery.toHtml box-model styles (margin/padding/border/shadow/opacity)', () => {
|
||||||
|
test('margin/padding/border/box-shadow/opacity all flow into the section style attribute', () => {
|
||||||
|
const { html } = toHtml(
|
||||||
|
{
|
||||||
|
images: [{ src: '/a.jpg', alt: 'a' }],
|
||||||
|
style: {
|
||||||
|
marginTop: '20px',
|
||||||
|
paddingLeft: '12px',
|
||||||
|
border: '1px solid #333333',
|
||||||
|
boxShadow: '0 1px 2px rgba(0,0,0,0.08)',
|
||||||
|
opacity: '0.9',
|
||||||
|
},
|
||||||
|
},
|
||||||
|
''
|
||||||
|
);
|
||||||
|
expect(html).toContain('margin-top:20px');
|
||||||
|
expect(html).toContain('padding-left:12px');
|
||||||
|
expect(html).toContain('border:1px solid #333333');
|
||||||
|
expect(html).toContain('box-shadow:0 1px 2px rgba(0,0,0,0.08)');
|
||||||
|
expect(html).toContain('opacity:0.9');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Gallery.craft.props exposes columns/lightbox + the animation/visibility rollout', () => {
|
||||||
|
test('columns and lightbox have their existing defaults', () => {
|
||||||
|
const props = (Gallery as any).craft.props;
|
||||||
|
expect(props.columns).toBe(3);
|
||||||
|
expect(props.lightbox).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('animation, animationDelay, hideOnDesktop/Tablet/Mobile are present with blank/false defaults', () => {
|
||||||
|
const props = (Gallery as any).craft.props;
|
||||||
|
expect(props.animation).toBe('');
|
||||||
|
expect(props.animationDelay).toBe('0');
|
||||||
|
expect(props.hideOnDesktop).toBe(false);
|
||||||
|
expect(props.hideOnTablet).toBe(false);
|
||||||
|
expect(props.hideOnMobile).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('style carries blank/default box-model keys', () => {
|
||||||
|
const style = (Gallery as any).craft.props.style;
|
||||||
|
expect(style).toHaveProperty('marginTop');
|
||||||
|
expect(style).toHaveProperty('paddingTop');
|
||||||
|
expect(style.border).toBe('none');
|
||||||
|
expect(style.boxShadow).toBe('none');
|
||||||
|
expect(style.opacity).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe('Gallery.toHtml lightbox uses a delegated listener, not per-item onclick (A4.3)', () => {
|
describe('Gallery.toHtml lightbox uses a delegated listener, not per-item onclick (A4.3)', () => {
|
||||||
test('no per-item inline onclick with interpolated src', () => {
|
test('no per-item inline onclick with interpolated src', () => {
|
||||||
const { html } = toHtml({ images: [{ src: '/a.jpg', alt: 'a' }], lightbox: true }, '');
|
const { html } = toHtml({ images: [{ src: '/a.jpg', alt: 'a' }], lightbox: true }, '');
|
||||||
|
|||||||
@@ -15,6 +15,11 @@ interface GalleryProps {
|
|||||||
gap?: string;
|
gap?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
lightbox?: boolean;
|
lightbox?: boolean;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const placeholderSvg = (index: number) => {
|
const placeholderSvg = (index: number) => {
|
||||||
@@ -112,8 +117,20 @@ Gallery.craft = {
|
|||||||
images: defaultImages,
|
images: defaultImages,
|
||||||
columns: 3,
|
columns: 3,
|
||||||
gap: '16px',
|
gap: '16px',
|
||||||
style: { backgroundColor: '#ffffff' },
|
style: {
|
||||||
|
backgroundColor: '#ffffff',
|
||||||
|
marginTop: '', marginRight: '', marginBottom: '', marginLeft: '',
|
||||||
|
paddingTop: '', paddingRight: '', paddingBottom: '', paddingLeft: '',
|
||||||
|
border: 'none',
|
||||||
|
boxShadow: 'none',
|
||||||
|
opacity: '1',
|
||||||
|
},
|
||||||
lightbox: false,
|
lightbox: false,
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '0',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -73,3 +73,14 @@ describe('NumberCounter.toHtml counter.number is NOT runtime-type-checked -- mus
|
|||||||
expect(html).toContain('data-target="150"');
|
expect(html).toContain('data-target="150"');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('NumberCounter.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (NumberCounter as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -16,6 +16,11 @@ interface NumberCounterProps {
|
|||||||
labelColor?: string;
|
labelColor?: string;
|
||||||
numberSize?: string;
|
numberSize?: string;
|
||||||
style?: CSSProperties;
|
style?: CSSProperties;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const defaultCounters: Counter[] = [
|
const defaultCounters: Counter[] = [
|
||||||
@@ -99,6 +104,11 @@ NumberCounter.craft = {
|
|||||||
labelColor: '#6b7280',
|
labelColor: '#6b7280',
|
||||||
numberSize: '48px',
|
numberSize: '48px',
|
||||||
style: { backgroundColor: '#ffffff' },
|
style: { backgroundColor: '#ffffff' },
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -0,0 +1,105 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import { PricingTable } from './PricingTable';
|
||||||
|
|
||||||
|
const toHtml = (PricingTable as any).toHtml;
|
||||||
|
|
||||||
|
const plans = [
|
||||||
|
{ name: 'Basic', price: '$9', period: '/month', features: ['Feature A'], buttonText: 'Buy', buttonHref: '#', isFeatured: false },
|
||||||
|
{ name: 'Pro', price: '$29', period: '/month', features: ['Feature B'], buttonText: 'Buy', buttonHref: '#', isFeatured: true },
|
||||||
|
];
|
||||||
|
|
||||||
|
describe('PricingTable.toHtml regular-card color overrides (previously hard-coded, now real props)', () => {
|
||||||
|
test('cardBg emits as the non-featured card background', () => {
|
||||||
|
const { html } = toHtml({ plans, cardBg: '#f0f0f0' }, '');
|
||||||
|
expect(html).toContain('background-color:#f0f0f0');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('textColor emits as the non-featured heading/price color', () => {
|
||||||
|
const { html } = toHtml({ plans, textColor: '#123456' }, '');
|
||||||
|
expect(html).toContain('color:#123456');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('subColor emits as the non-featured period text color', () => {
|
||||||
|
const { html } = toHtml({ plans, subColor: '#abcdef' }, '');
|
||||||
|
expect(html).toContain('color:#abcdef');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('featColor emits as the non-featured feature list text color', () => {
|
||||||
|
const { html } = toHtml({ plans, featColor: '#334455' }, '');
|
||||||
|
expect(html).toContain('color:#334455');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('checkColor emits as the non-featured bullet color', () => {
|
||||||
|
const { html } = toHtml({ plans, checkColor: '#00ff00' }, '');
|
||||||
|
expect(html).toContain('color:#00ff00');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('btnBg/btnColor emit as the non-featured button colors', () => {
|
||||||
|
const { html } = toHtml({ plans, btnBg: '#111111', btnColor: '#eeeeee' }, '');
|
||||||
|
expect(html).toContain('background-color:#111111');
|
||||||
|
expect(html).toContain('color:#eeeeee');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('unset overrides fall back to the exact prior literals (backward compatible)', () => {
|
||||||
|
const { html } = toHtml({ plans }, '');
|
||||||
|
// Regular (non-featured) card literals unchanged from before these props existed.
|
||||||
|
expect(html).toContain('background-color:#ffffff');
|
||||||
|
expect(html).toContain('color:#18181b');
|
||||||
|
expect(html).toContain('color:#64748b');
|
||||||
|
expect(html).toContain('color:#4b5563');
|
||||||
|
expect(html).toContain('color:#10b981');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('unset btnBg falls back to featuredBg (original derivation)', () => {
|
||||||
|
const { html } = toHtml({ plans, featuredBg: '#654321' }, '');
|
||||||
|
expect(html).toContain('background-color:#654321');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('PricingTable.toHtml XSS hardening (new card color props into style=)', () => {
|
||||||
|
test('a cardBg breakout string cannot escape style=""', () => {
|
||||||
|
const malicious = '#fff" onmouseover="alert(1)';
|
||||||
|
const { html } = toHtml({ plans, cardBg: malicious }, '');
|
||||||
|
expect(html).not.toMatch(/"\s+onmouseover="/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a textColor breakout string cannot escape style=""', () => {
|
||||||
|
const malicious = '#000" onmouseover="alert(1)';
|
||||||
|
const { html } = toHtml({ plans, textColor: malicious }, '');
|
||||||
|
expect(html).not.toMatch(/"\s+onmouseover="/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a btnBg breakout string cannot escape style=""', () => {
|
||||||
|
const malicious = '#000" onmouseover="alert(1)';
|
||||||
|
const { html } = toHtml({ plans, btnBg: malicious }, '');
|
||||||
|
expect(html).not.toMatch(/"\s+onmouseover="/);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a btnColor breakout string cannot escape style=""', () => {
|
||||||
|
const malicious = '#000" onmouseover="alert(1)';
|
||||||
|
const { html } = toHtml({ plans, btnColor: malicious }, '');
|
||||||
|
expect(html).not.toMatch(/"\s+onmouseover="/);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('PricingTable.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('the new regular-card color props are declared blank by default', () => {
|
||||||
|
const props = (PricingTable as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('cardBg', '');
|
||||||
|
expect(props).toHaveProperty('textColor', '');
|
||||||
|
expect(props).toHaveProperty('subColor', '');
|
||||||
|
expect(props).toHaveProperty('featColor', '');
|
||||||
|
expect(props).toHaveProperty('checkColor', '');
|
||||||
|
expect(props).toHaveProperty('btnBg', '');
|
||||||
|
expect(props).toHaveProperty('btnColor', '');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (PricingTable as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -19,6 +19,23 @@ interface PricingTableProps {
|
|||||||
featuredBg?: string;
|
featuredBg?: string;
|
||||||
bulletType?: string;
|
bulletType?: string;
|
||||||
anchorId?: string;
|
anchorId?: string;
|
||||||
|
/* ---- Regular (non-featured) card colors ----
|
||||||
|
All optional; each falls back to the exact literal the card was
|
||||||
|
previously hard-coded to (or, for the button, to featuredBg -- the
|
||||||
|
button's original derivation) when left unset, so existing saved
|
||||||
|
projects render pixel-identical until a color is explicitly picked. */
|
||||||
|
cardBg?: string;
|
||||||
|
textColor?: string;
|
||||||
|
subColor?: string;
|
||||||
|
featColor?: string;
|
||||||
|
checkColor?: string;
|
||||||
|
btnBg?: string;
|
||||||
|
btnColor?: string;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const bulletChars: Record<string, string> = {
|
const bulletChars: Record<string, string> = {
|
||||||
@@ -61,6 +78,13 @@ export const PricingTable: UserComponent<PricingTableProps> = ({
|
|||||||
featuredBg = '#3b82f6',
|
featuredBg = '#3b82f6',
|
||||||
bulletType = 'check',
|
bulletType = 'check',
|
||||||
anchorId,
|
anchorId,
|
||||||
|
cardBg,
|
||||||
|
textColor,
|
||||||
|
subColor,
|
||||||
|
featColor,
|
||||||
|
checkColor,
|
||||||
|
btnBg,
|
||||||
|
btnColor,
|
||||||
}) => {
|
}) => {
|
||||||
const {
|
const {
|
||||||
connectors: { connect, drag },
|
connectors: { connect, drag },
|
||||||
@@ -69,6 +93,14 @@ export const PricingTable: UserComponent<PricingTableProps> = ({
|
|||||||
selected: node.events.selected,
|
selected: node.events.selected,
|
||||||
}));
|
}));
|
||||||
|
|
||||||
|
const regCardBg = cardBg || '#ffffff';
|
||||||
|
const regTextColor = textColor || '#18181b';
|
||||||
|
const regSubColor = subColor || '#64748b';
|
||||||
|
const regFeatColor = featColor || '#4b5563';
|
||||||
|
const regCheckColor = checkColor || '#10b981';
|
||||||
|
const regBtnBg = btnBg || featuredBg;
|
||||||
|
const regBtnColor = btnColor || '#ffffff';
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<section
|
<section
|
||||||
ref={(ref: HTMLElement | null): void => { if (ref) connect(drag(ref)); }}
|
ref={(ref: HTMLElement | null): void => { if (ref) connect(drag(ref)); }}
|
||||||
@@ -95,7 +127,7 @@ export const PricingTable: UserComponent<PricingTableProps> = ({
|
|||||||
style={{
|
style={{
|
||||||
flex: '1 1 280px',
|
flex: '1 1 280px',
|
||||||
maxWidth: '360px',
|
maxWidth: '360px',
|
||||||
backgroundColor: plan.isFeatured ? featuredBg : '#ffffff',
|
backgroundColor: plan.isFeatured ? featuredBg : regCardBg,
|
||||||
border: plan.isFeatured ? 'none' : '1px solid #e2e8f0',
|
border: plan.isFeatured ? 'none' : '1px solid #e2e8f0',
|
||||||
borderRadius: '16px',
|
borderRadius: '16px',
|
||||||
padding: '40px 32px',
|
padding: '40px 32px',
|
||||||
@@ -127,7 +159,7 @@ export const PricingTable: UserComponent<PricingTableProps> = ({
|
|||||||
<h3 style={{
|
<h3 style={{
|
||||||
fontSize: '20px',
|
fontSize: '20px',
|
||||||
fontWeight: '600',
|
fontWeight: '600',
|
||||||
color: plan.isFeatured ? '#ffffff' : '#18181b',
|
color: plan.isFeatured ? '#ffffff' : regTextColor,
|
||||||
marginBottom: '8px',
|
marginBottom: '8px',
|
||||||
marginTop: plan.isFeatured ? '8px' : '0',
|
marginTop: plan.isFeatured ? '8px' : '0',
|
||||||
}}>
|
}}>
|
||||||
@@ -137,14 +169,14 @@ export const PricingTable: UserComponent<PricingTableProps> = ({
|
|||||||
<span style={{
|
<span style={{
|
||||||
fontSize: '48px',
|
fontSize: '48px',
|
||||||
fontWeight: '700',
|
fontWeight: '700',
|
||||||
color: plan.isFeatured ? '#ffffff' : '#18181b',
|
color: plan.isFeatured ? '#ffffff' : regTextColor,
|
||||||
lineHeight: '1',
|
lineHeight: '1',
|
||||||
}}>
|
}}>
|
||||||
{plan.price}
|
{plan.price}
|
||||||
</span>
|
</span>
|
||||||
<span style={{
|
<span style={{
|
||||||
fontSize: '16px',
|
fontSize: '16px',
|
||||||
color: plan.isFeatured ? 'rgba(255,255,255,0.8)' : '#64748b',
|
color: plan.isFeatured ? 'rgba(255,255,255,0.8)' : regSubColor,
|
||||||
}}>
|
}}>
|
||||||
{plan.period}
|
{plan.period}
|
||||||
</span>
|
</span>
|
||||||
@@ -161,12 +193,12 @@ export const PricingTable: UserComponent<PricingTableProps> = ({
|
|||||||
{(Array.isArray(plan.features) ? plan.features : []).map((feature, fi) => (
|
{(Array.isArray(plan.features) ? plan.features : []).map((feature, fi) => (
|
||||||
<li key={fi} style={{
|
<li key={fi} style={{
|
||||||
fontSize: '14px',
|
fontSize: '14px',
|
||||||
color: plan.isFeatured ? 'rgba(255,255,255,0.9)' : '#4b5563',
|
color: plan.isFeatured ? 'rgba(255,255,255,0.9)' : regFeatColor,
|
||||||
display: 'flex',
|
display: 'flex',
|
||||||
alignItems: 'center',
|
alignItems: 'center',
|
||||||
gap: '8px',
|
gap: '8px',
|
||||||
}}>
|
}}>
|
||||||
<span style={{ color: plan.isFeatured ? '#bbf7d0' : '#10b981', fontWeight: '700' }}>{bulletChars[bulletType] || '✓'}</span>
|
<span style={{ color: plan.isFeatured ? '#bbf7d0' : regCheckColor, fontWeight: '700' }}>{bulletChars[bulletType] || '✓'}</span>
|
||||||
{feature}
|
{feature}
|
||||||
</li>
|
</li>
|
||||||
))}
|
))}
|
||||||
@@ -178,8 +210,8 @@ export const PricingTable: UserComponent<PricingTableProps> = ({
|
|||||||
marginTop: 'auto',
|
marginTop: 'auto',
|
||||||
display: 'inline-block',
|
display: 'inline-block',
|
||||||
padding: '14px 32px',
|
padding: '14px 32px',
|
||||||
backgroundColor: plan.isFeatured ? '#ffffff' : featuredBg,
|
backgroundColor: plan.isFeatured ? '#ffffff' : regBtnBg,
|
||||||
color: plan.isFeatured ? featuredBg : '#ffffff',
|
color: plan.isFeatured ? featuredBg : regBtnColor,
|
||||||
textDecoration: 'none',
|
textDecoration: 'none',
|
||||||
borderRadius: '8px',
|
borderRadius: '8px',
|
||||||
fontWeight: '600',
|
fontWeight: '600',
|
||||||
@@ -207,6 +239,18 @@ PricingTable.craft = {
|
|||||||
featuredBg: '#3b82f6',
|
featuredBg: '#3b82f6',
|
||||||
bulletType: 'check',
|
bulletType: 'check',
|
||||||
anchorId: '',
|
anchorId: '',
|
||||||
|
cardBg: '',
|
||||||
|
textColor: '',
|
||||||
|
subColor: '',
|
||||||
|
featColor: '',
|
||||||
|
checkColor: '',
|
||||||
|
btnBg: '',
|
||||||
|
btnColor: '',
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
@@ -228,16 +272,28 @@ PricingTable.craft = {
|
|||||||
// Sanitized -- featuredBg is a raw string-interpolation sink below (drives
|
// Sanitized -- featuredBg is a raw string-interpolation sink below (drives
|
||||||
// cardBg/btnBg/btnColor, all raw-interpolated into style="...").
|
// cardBg/btnBg/btnColor, all raw-interpolated into style="...").
|
||||||
const featuredBg = cssValue(props.featuredBg) || '#3b82f6';
|
const featuredBg = cssValue(props.featuredBg) || '#3b82f6';
|
||||||
|
// Sanitized -- regular (non-featured) card color overrides, all raw
|
||||||
|
// string-interpolation sinks into style="..." below. Each falls back to
|
||||||
|
// the exact literal the card was previously hard-coded to (or, for the
|
||||||
|
// button, to featuredBg) when unset, so unmodified pricing tables render
|
||||||
|
// identically to before these props existed.
|
||||||
|
const regCardBg = cssValue(props.cardBg) || '#ffffff';
|
||||||
|
const regTextColor = cssValue(props.textColor) || '#18181b';
|
||||||
|
const regSubColor = cssValue(props.subColor) || '#64748b';
|
||||||
|
const regFeatColor = cssValue(props.featColor) || '#4b5563';
|
||||||
|
const regCheckColor = cssValue(props.checkColor) || '#10b981';
|
||||||
|
const regBtnBg = cssValue(props.btnBg) || featuredBg;
|
||||||
|
const regBtnColor = cssValue(props.btnColor) || '#ffffff';
|
||||||
|
|
||||||
const cards = plans.map((plan) => {
|
const cards = plans.map((plan) => {
|
||||||
const cardBg = plan.isFeatured ? featuredBg : '#ffffff';
|
const cardBg = plan.isFeatured ? featuredBg : regCardBg;
|
||||||
const cardBorder = plan.isFeatured ? 'border:none;' : 'border:1px solid #e2e8f0;';
|
const cardBorder = plan.isFeatured ? 'border:none;' : 'border:1px solid #e2e8f0;';
|
||||||
const textColor = plan.isFeatured ? '#ffffff' : '#18181b';
|
const textColor = plan.isFeatured ? '#ffffff' : regTextColor;
|
||||||
const subColor = plan.isFeatured ? 'rgba(255,255,255,0.8)' : '#64748b';
|
const subColor = plan.isFeatured ? 'rgba(255,255,255,0.8)' : regSubColor;
|
||||||
const featColor = plan.isFeatured ? 'rgba(255,255,255,0.9)' : '#4b5563';
|
const featColor = plan.isFeatured ? 'rgba(255,255,255,0.9)' : regFeatColor;
|
||||||
const checkColor = plan.isFeatured ? '#bbf7d0' : '#10b981';
|
const checkColor = plan.isFeatured ? '#bbf7d0' : regCheckColor;
|
||||||
const btnBg = plan.isFeatured ? '#ffffff' : featuredBg;
|
const btnBg = plan.isFeatured ? '#ffffff' : regBtnBg;
|
||||||
const btnColor = plan.isFeatured ? featuredBg : '#ffffff';
|
const btnColor = plan.isFeatured ? featuredBg : regBtnColor;
|
||||||
const scale = plan.isFeatured ? 'transform:scale(1.05);' : '';
|
const scale = plan.isFeatured ? 'transform:scale(1.05);' : '';
|
||||||
const shadow = plan.isFeatured ? 'box-shadow:0 20px 60px rgba(59,130,246,0.3);' : 'box-shadow:0 1px 3px rgba(0,0,0,0.06);';
|
const shadow = plan.isFeatured ? 'box-shadow:0 20px 60px rgba(59,130,246,0.3);' : 'box-shadow:0 1px 3px rgba(0,0,0,0.06);';
|
||||||
|
|
||||||
|
|||||||
@@ -80,3 +80,14 @@ describe('Tabs.toHtml deterministic + unique ids (thread node id, resolves id-co
|
|||||||
expect(html1).toBe(html2);
|
expect(html1).toBe(html2);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('Tabs.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (Tabs as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -17,6 +17,11 @@ interface TabsProps {
|
|||||||
inactiveTabColor?: string;
|
inactiveTabColor?: string;
|
||||||
contentBg?: string;
|
contentBg?: string;
|
||||||
anchorId?: string;
|
anchorId?: string;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const defaultTabs: TabItem[] = [
|
const defaultTabs: TabItem[] = [
|
||||||
@@ -114,6 +119,11 @@ Tabs.craft = {
|
|||||||
inactiveTabColor: '#64748b',
|
inactiveTabColor: '#64748b',
|
||||||
contentBg: '#ffffff',
|
contentBg: '#ffffff',
|
||||||
anchorId: '',
|
anchorId: '',
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -71,3 +71,14 @@ describe('Testimonials.toHtml rating aria-label sink (attacker-controlled `ratin
|
|||||||
expect(html).toContain('aria-label="Rating: 4 out of 5"');
|
expect(html).toContain('aria-label="Rating: 4 out of 5"');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('Testimonials.craft.props includes the box-model/animation/visibility rollout props', () => {
|
||||||
|
test('animation, animationDelay, and all 3 hideOn* flags are declared (blank/false defaults)', () => {
|
||||||
|
const props = (Testimonials as any).craft.props;
|
||||||
|
expect(props).toHaveProperty('animation', '');
|
||||||
|
expect(props).toHaveProperty('animationDelay', '');
|
||||||
|
expect(props).toHaveProperty('hideOnDesktop', false);
|
||||||
|
expect(props).toHaveProperty('hideOnTablet', false);
|
||||||
|
expect(props).toHaveProperty('hideOnMobile', false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -18,6 +18,11 @@ interface TestimonialsProps {
|
|||||||
cardBg?: string;
|
cardBg?: string;
|
||||||
starColor?: string;
|
starColor?: string;
|
||||||
anchorId?: string;
|
anchorId?: string;
|
||||||
|
animation?: string;
|
||||||
|
animationDelay?: string;
|
||||||
|
hideOnDesktop?: boolean;
|
||||||
|
hideOnTablet?: boolean;
|
||||||
|
hideOnMobile?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const defaultTestimonials: Testimonial[] = [
|
const defaultTestimonials: Testimonial[] = [
|
||||||
@@ -131,6 +136,11 @@ Testimonials.craft = {
|
|||||||
cardBg: '#f8fafc',
|
cardBg: '#f8fafc',
|
||||||
starColor: '#f59e0b',
|
starColor: '#f59e0b',
|
||||||
anchorId: '',
|
anchorId: '',
|
||||||
|
animation: '',
|
||||||
|
animationDelay: '',
|
||||||
|
hideOnDesktop: false,
|
||||||
|
hideOnTablet: false,
|
||||||
|
hideOnMobile: false,
|
||||||
},
|
},
|
||||||
rules: {
|
rules: {
|
||||||
canDrag: () => true,
|
canDrag: () => true,
|
||||||
|
|||||||
@@ -11,6 +11,7 @@ import { useContextMenu } from '../hooks/useContextMenu';
|
|||||||
import { useKeyboardShortcuts } from '../hooks/useKeyboardShortcuts';
|
import { useKeyboardShortcuts } from '../hooks/useKeyboardShortcuts';
|
||||||
import { useIsMobile } from '../hooks/useIsMobile';
|
import { useIsMobile } from '../hooks/useIsMobile';
|
||||||
import { MobileChromeProvider } from '../state/MobileChromeContext';
|
import { MobileChromeProvider } from '../state/MobileChromeContext';
|
||||||
|
import { LayerFocusProvider } from '../panels/left/LayerFocusContext';
|
||||||
import { DeviceMode } from '../types';
|
import { DeviceMode } from '../types';
|
||||||
|
|
||||||
const SHOW_GUIDES_STORAGE_KEY = 'craft-show-guides';
|
const SHOW_GUIDES_STORAGE_KEY = 'craft-show-guides';
|
||||||
@@ -83,30 +84,32 @@ export const EditorShell: React.FC = () => {
|
|||||||
// doesn't render MobilePanelBar and TopBar's desktop branch behaves
|
// doesn't render MobilePanelBar and TopBar's desktop branch behaves
|
||||||
// identically to before (same booleans, just sourced from context).
|
// identically to before (same booleans, just sourced from context).
|
||||||
<MobileChromeProvider>
|
<MobileChromeProvider>
|
||||||
<div className="editor-app">
|
<LayerFocusProvider>
|
||||||
<TopBar
|
<div className="editor-app">
|
||||||
device={device}
|
<TopBar
|
||||||
onDeviceChange={setDevice}
|
device={device}
|
||||||
showGuides={showGuides}
|
onDeviceChange={setDevice}
|
||||||
onToggleGuides={() => setShowGuides(!showGuides)}
|
showGuides={showGuides}
|
||||||
/>
|
onToggleGuides={() => setShowGuides(!showGuides)}
|
||||||
<div className="editor-container">
|
/>
|
||||||
{!isMobile && <LeftPanel />}
|
<div className="editor-container">
|
||||||
<div onContextMenu={handleContextMenu} style={{ flex: 1, display: 'flex', minWidth: 0 }}>
|
{!isMobile && <LeftPanel />}
|
||||||
<Canvas device={device} showGuides={showGuides} />
|
<div onContextMenu={handleContextMenu} style={{ flex: 1, display: 'flex', minWidth: 0 }}>
|
||||||
|
<Canvas device={device} showGuides={showGuides} />
|
||||||
|
</div>
|
||||||
|
{!isMobile && <RightPanel />}
|
||||||
</div>
|
</div>
|
||||||
{!isMobile && <RightPanel />}
|
{isMobile && <MobilePanelBar />}
|
||||||
|
{isMobile && <MobileSelectionToolbar />}
|
||||||
|
<ContextMenu
|
||||||
|
visible={menuState.visible}
|
||||||
|
x={menuState.x}
|
||||||
|
y={menuState.y}
|
||||||
|
nodeId={menuState.nodeId}
|
||||||
|
onClose={hideMenu}
|
||||||
|
/>
|
||||||
</div>
|
</div>
|
||||||
{isMobile && <MobilePanelBar />}
|
</LayerFocusProvider>
|
||||||
{isMobile && <MobileSelectionToolbar />}
|
|
||||||
<ContextMenu
|
|
||||||
visible={menuState.visible}
|
|
||||||
x={menuState.x}
|
|
||||||
y={menuState.y}
|
|
||||||
nodeId={menuState.nodeId}
|
|
||||||
onClose={hideMenu}
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
</MobileChromeProvider>
|
</MobileChromeProvider>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -1,29 +1,95 @@
|
|||||||
import { describe, test, expect, afterEach } from 'vitest';
|
import { describe, test, expect, afterEach } from 'vitest';
|
||||||
import { getClipboardNodeId, setClipboardNodeId } from './clipboard';
|
import type { NodeTree } from '@craftjs/core';
|
||||||
|
import { getClipboardTree, setClipboardTree } from './clipboard';
|
||||||
|
|
||||||
|
function makeTree(rootId: string, props: Record<string, unknown> = {}): NodeTree {
|
||||||
|
return {
|
||||||
|
rootNodeId: rootId,
|
||||||
|
nodes: {
|
||||||
|
[rootId]: {
|
||||||
|
id: rootId,
|
||||||
|
data: {
|
||||||
|
type: { resolvedName: 'Container' },
|
||||||
|
name: 'Container',
|
||||||
|
displayName: 'Container',
|
||||||
|
props,
|
||||||
|
custom: {},
|
||||||
|
isCanvas: false,
|
||||||
|
parent: 'wherever-it-originally-lived',
|
||||||
|
nodes: [],
|
||||||
|
linkedNodes: {},
|
||||||
|
hidden: false,
|
||||||
|
},
|
||||||
|
info: {},
|
||||||
|
events: { selected: false, dragged: false, hovered: false },
|
||||||
|
dom: null,
|
||||||
|
related: {},
|
||||||
|
rules: {},
|
||||||
|
_hydrationTimestamp: 0,
|
||||||
|
} as unknown as NodeTree['nodes'][string],
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
describe('clipboard', () => {
|
describe('clipboard', () => {
|
||||||
afterEach(() => {
|
afterEach(() => {
|
||||||
setClipboardNodeId(null);
|
setClipboardTree(null);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('starts empty', () => {
|
test('starts empty', () => {
|
||||||
expect(getClipboardNodeId()).toBeNull();
|
expect(getClipboardTree()).toBeNull();
|
||||||
});
|
});
|
||||||
|
|
||||||
test('set then get returns the stored node id', () => {
|
test('set then get returns a tree with the same root id and shape', () => {
|
||||||
setClipboardNodeId('node-123');
|
const tree = makeTree('node-123', { text: 'hello' });
|
||||||
expect(getClipboardNodeId()).toBe('node-123');
|
setClipboardTree(tree);
|
||||||
|
const got = getClipboardTree();
|
||||||
|
expect(got).not.toBeNull();
|
||||||
|
expect(got!.rootNodeId).toBe('node-123');
|
||||||
|
expect(got!.nodes['node-123'].data.props).toEqual({ text: 'hello' });
|
||||||
});
|
});
|
||||||
|
|
||||||
test('is a shared module-level store -- overwriting replaces the previous value', () => {
|
test('is a shared module-level store -- overwriting replaces the previous value', () => {
|
||||||
setClipboardNodeId('first');
|
setClipboardTree(makeTree('first'));
|
||||||
setClipboardNodeId('second');
|
setClipboardTree(makeTree('second'));
|
||||||
expect(getClipboardNodeId()).toBe('second');
|
expect(getClipboardTree()!.rootNodeId).toBe('second');
|
||||||
});
|
});
|
||||||
|
|
||||||
test('can be cleared back to null', () => {
|
test('can be cleared back to null', () => {
|
||||||
setClipboardNodeId('node-123');
|
setClipboardTree(makeTree('node-123'));
|
||||||
setClipboardNodeId(null);
|
setClipboardTree(null);
|
||||||
expect(getClipboardNodeId()).toBeNull();
|
expect(getClipboardTree()).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('deep-clones on set: mutating the original tree after set does not affect the stored snapshot', () => {
|
||||||
|
const original = makeTree('node-123', { text: 'original' });
|
||||||
|
setClipboardTree(original);
|
||||||
|
|
||||||
|
// Mutate the original tree's props object directly (as if the source
|
||||||
|
// node were edited, or the same live node got copied again).
|
||||||
|
(original.nodes['node-123'].data.props as Record<string, unknown>).text = 'mutated';
|
||||||
|
|
||||||
|
expect(getClipboardTree()!.nodes['node-123'].data.props).toEqual({ text: 'original' });
|
||||||
|
});
|
||||||
|
|
||||||
|
test('deep-clones nested props (arrays/objects), not just the top-level props object', () => {
|
||||||
|
const original = makeTree('node-123', { links: [{ url: 'https://example.com' }] });
|
||||||
|
setClipboardTree(original);
|
||||||
|
|
||||||
|
(original.nodes['node-123'].data.props as any).links[0].url = 'https://mutated.example.com';
|
||||||
|
|
||||||
|
expect((getClipboardTree()!.nodes['node-123'].data.props as any).links[0].url).toBe(
|
||||||
|
'https://example.com',
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('survives the original tree object being discarded entirely (detached copy, not a live reference)', () => {
|
||||||
|
let tree: NodeTree | null = makeTree('node-abc', { text: 'snapshot' });
|
||||||
|
setClipboardTree(tree);
|
||||||
|
tree = null; // simulate the original page's node/tree going away entirely
|
||||||
|
|
||||||
|
const got = getClipboardTree();
|
||||||
|
expect(got).not.toBeNull();
|
||||||
|
expect(got!.nodes['node-abc'].data.props).toEqual({ text: 'snapshot' });
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,3 +1,5 @@
|
|||||||
|
import type { Node, NodeId, NodeTree } from '@craftjs/core';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Tiny shared clipboard for canvas node copy/paste.
|
* Tiny shared clipboard for canvas node copy/paste.
|
||||||
*
|
*
|
||||||
@@ -9,15 +11,71 @@
|
|||||||
* Deliberately not React state -- nothing in the UI needs to re-render
|
* Deliberately not React state -- nothing in the UI needs to re-render
|
||||||
* reactively when the clipboard changes; consumers just read the current
|
* reactively when the clipboard changes; consumers just read the current
|
||||||
* value at the moment they need it (on paste, or when a menu opens).
|
* value at the moment they need it (on paste, or when a menu opens).
|
||||||
|
*
|
||||||
|
* Historical bug (cross-page copy/paste): this used to store only the copied
|
||||||
|
* node's bare id (`clipboardNodeId`) and re-resolve it via `query.node(id)`
|
||||||
|
* at paste time. That works fine same-page, but the moment the user switches
|
||||||
|
* pages the canvas is re-deserialized to the target page's Craft.js state --
|
||||||
|
* the copied id no longer exists in `query` at all -- so a cross-page paste
|
||||||
|
* silently no-op'd (or threw, caught, and swallowed). Storing a detached
|
||||||
|
* TREE SNAPSHOT at copy time instead means paste never needs to look the
|
||||||
|
* source id up again: it just hands the snapshot to `regenerateTreeIds` +
|
||||||
|
* `actions.addNodeTree`, which works identically regardless of which page's
|
||||||
|
* state is currently loaded on the canvas.
|
||||||
*/
|
*/
|
||||||
let clipboardNodeId: string | null = null;
|
let clipboardTree: NodeTree | null = null;
|
||||||
|
|
||||||
/** Returns the id of the node currently on the clipboard, or null if empty. */
|
/**
|
||||||
export function getClipboardNodeId(): string | null {
|
* Deep, detached clone of a live Craft.js `NodeTree` (as returned by
|
||||||
return clipboardNodeId;
|
* `query.node(id).toNodeTree()`).
|
||||||
|
*
|
||||||
|
* Not a plain `structuredClone(tree)`: for a REAL (live) Craft.js node,
|
||||||
|
* `data.type` is the actual component function/class reference (not a
|
||||||
|
* serializable `{resolvedName}` wrapper) -- `structuredClone` cannot clone a
|
||||||
|
* function and throws `DataCloneError` (see the identical note on
|
||||||
|
* `regenerateTreeIds` in `utils/craft-tree.ts`, which hit this exact bug
|
||||||
|
* historically). `type` is a stable reference shared by every node of that
|
||||||
|
* component across the whole app (it doesn't change per page), so it's safe
|
||||||
|
* to keep by reference -- only the mutable per-node data (`props`, `custom`,
|
||||||
|
* `nodes`, `linkedNodes`) needs an actual deep copy so a later mutation (a
|
||||||
|
* subsequent paste's `setProp`, or a fresh copy of the same live node)
|
||||||
|
* can never reach back into this stored snapshot.
|
||||||
|
*/
|
||||||
|
function cloneNodeTree(tree: NodeTree): NodeTree {
|
||||||
|
const nodes: Record<NodeId, Node> = {};
|
||||||
|
for (const [id, node] of Object.entries(tree.nodes)) {
|
||||||
|
nodes[id] = {
|
||||||
|
...node,
|
||||||
|
data: {
|
||||||
|
...node.data,
|
||||||
|
props: structuredClone(node.data.props),
|
||||||
|
custom: structuredClone(node.data.custom),
|
||||||
|
nodes: [...(node.data.nodes || [])],
|
||||||
|
linkedNodes: { ...(node.data.linkedNodes || {}) },
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
return { rootNodeId: tree.rootNodeId, nodes };
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Sets (or clears, with `null`) the node id on the clipboard. */
|
/**
|
||||||
export function setClipboardNodeId(nodeId: string | null): void {
|
* Returns the tree snapshot currently on the clipboard, or null if empty.
|
||||||
clipboardNodeId = nodeId;
|
* The returned tree is safe to hand straight to `regenerateTreeIds` --
|
||||||
|
* `regenerateTreeIds` never mutates its input, so repeated pastes of the
|
||||||
|
* same clipboard contents (including across a page switch) all work off the
|
||||||
|
* same untouched snapshot.
|
||||||
|
*/
|
||||||
|
export function getClipboardTree(): NodeTree | null {
|
||||||
|
return clipboardTree;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Sets (or clears, with `null`) the tree snapshot on the clipboard. The tree
|
||||||
|
* is deep-cloned before being stored (see `cloneNodeTree`) so it is fully
|
||||||
|
* detached from the live Craft.js node it was captured from -- it survives
|
||||||
|
* that node being deleted, mutated, or (the whole point) the canvas being
|
||||||
|
* re-deserialized to a different page entirely.
|
||||||
|
*/
|
||||||
|
export function setClipboardTree(tree: NodeTree | null): void {
|
||||||
|
clipboardTree = tree ? cloneNodeTree(tree) : null;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -4,7 +4,7 @@ import { createRoot, Root } from 'react-dom/client';
|
|||||||
import { act } from 'react-dom/test-utils';
|
import { act } from 'react-dom/test-utils';
|
||||||
import type { NodeTree, Node } from '@craftjs/core';
|
import type { NodeTree, Node } from '@craftjs/core';
|
||||||
import { useKeyboardShortcuts } from './useKeyboardShortcuts';
|
import { useKeyboardShortcuts } from './useKeyboardShortcuts';
|
||||||
import { getClipboardNodeId, setClipboardNodeId } from './clipboard';
|
import { getClipboardTree, setClipboardTree } from './clipboard';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Regression coverage: Ctrl/Cmd+V must run the copied subtree through
|
* Regression coverage: Ctrl/Cmd+V must run the copied subtree through
|
||||||
@@ -15,6 +15,13 @@ import { getClipboardNodeId, setClipboardNodeId } from './clipboard';
|
|||||||
* ROOT-fallback targeting, the empty-clipboard no-op, and the existing
|
* ROOT-fallback targeting, the empty-clipboard no-op, and the existing
|
||||||
* input-focus guard.
|
* input-focus guard.
|
||||||
*
|
*
|
||||||
|
* Also covers the cross-page clipboard fix: copy stores a detached TREE
|
||||||
|
* SNAPSHOT (`setClipboardTree`), not a bare node id -- so paste never needs
|
||||||
|
* to re-resolve the original node via `query.node(id)`, which is exactly
|
||||||
|
* what breaks once the canvas has been re-deserialized to a different page
|
||||||
|
* (see `hooks/clipboard.ts` and the cross-page integration test in
|
||||||
|
* `test-utils/integration/duplicate-paste.integration.test.tsx`).
|
||||||
|
*
|
||||||
* Mock pattern mirrors PageContext.pure-updaters.test.tsx /
|
* Mock pattern mirrors PageContext.pure-updaters.test.tsx /
|
||||||
* PageContext.slug.test.tsx: a fake `useEditor` exposing `query`/`actions`,
|
* PageContext.slug.test.tsx: a fake `useEditor` exposing `query`/`actions`,
|
||||||
* mounted via a bare consumer component, with REAL `keydown` events
|
* mounted via a bare consumer component, with REAL `keydown` events
|
||||||
@@ -27,6 +34,7 @@ import { getClipboardNodeId, setClipboardNodeId } from './clipboard';
|
|||||||
*/
|
*/
|
||||||
|
|
||||||
const addNodeTreeMock = vi.fn();
|
const addNodeTreeMock = vi.fn();
|
||||||
|
const selectNodeMock = vi.fn();
|
||||||
let selectedIds: string[] = [];
|
let selectedIds: string[] = [];
|
||||||
|
|
||||||
function makeNode(id: string, parent: string | null, children: string[] = []): Node {
|
function makeNode(id: string, parent: string | null, children: string[] = []): Node {
|
||||||
@@ -62,9 +70,10 @@ const COPIED_TREE: NodeTree = {
|
|||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
const nodeStore: Record<string, { data: { parent: string | null } }> = {
|
const nodeStore: Record<string, { data: { parent: string | null; nodes?: string[] } }> = {
|
||||||
'selected-1': { data: { parent: 'parent-container-1' } },
|
'selected-1': { data: { parent: 'parent-container-1' } },
|
||||||
ROOT: { data: { parent: null } },
|
'parent-container-1': { data: { parent: null, nodes: ['other-sibling', 'selected-1'] } },
|
||||||
|
ROOT: { data: { parent: null, nodes: [] } },
|
||||||
'copied-root-1': { data: { parent: 'wherever-it-originally-lived' } },
|
'copied-root-1': { data: { parent: 'wherever-it-originally-lived' } },
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -88,6 +97,7 @@ vi.mock('@craftjs/core', () => ({
|
|||||||
},
|
},
|
||||||
actions: {
|
actions: {
|
||||||
addNodeTree: addNodeTreeMock,
|
addNodeTree: addNodeTreeMock,
|
||||||
|
selectNode: selectNodeMock,
|
||||||
history: { undo: vi.fn(), redo: vi.fn() },
|
history: { undo: vi.fn(), redo: vi.fn() },
|
||||||
delete: vi.fn(),
|
delete: vi.fn(),
|
||||||
clearEvents: vi.fn(),
|
clearEvents: vi.fn(),
|
||||||
@@ -145,44 +155,51 @@ const Consumer: React.FC = () => {
|
|||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
selectedIds = [];
|
selectedIds = [];
|
||||||
addNodeTreeMock.mockClear();
|
addNodeTreeMock.mockClear();
|
||||||
|
selectNodeMock.mockClear();
|
||||||
regenerateTreeIdsMock.mockClear();
|
regenerateTreeIdsMock.mockClear();
|
||||||
setClipboardNodeId(null);
|
setClipboardTree(null);
|
||||||
});
|
});
|
||||||
|
|
||||||
afterEach(() => {
|
afterEach(() => {
|
||||||
setClipboardNodeId(null);
|
setClipboardTree(null);
|
||||||
if (root) unmount();
|
if (root) unmount();
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => {
|
describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => {
|
||||||
test('Ctrl+C copies the selected node id to the clipboard', () => {
|
test('Ctrl+C copies the selected node`s subtree (a tree snapshot, not a bare id) to the clipboard', () => {
|
||||||
render(<Consumer />);
|
render(<Consumer />);
|
||||||
selectedIds = ['selected-1'];
|
selectedIds = ['copied-root-1'];
|
||||||
|
|
||||||
pressKey('c');
|
pressKey('c');
|
||||||
|
|
||||||
expect(getClipboardNodeId()).toBe('selected-1');
|
const clip = getClipboardTree();
|
||||||
|
expect(clip).not.toBeNull();
|
||||||
|
expect(clip!.rootNodeId).toBe('copied-root-1');
|
||||||
|
expect(Object.keys(clip!.nodes).sort()).toEqual(['copied-child-1', 'copied-root-1']);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('Ctrl+V pastes as a sibling of the selection (selected node`s data.parent) with FRESH ids', () => {
|
test('Ctrl+V pastes as a sibling of the selection, immediately after it, with FRESH ids', () => {
|
||||||
render(<Consumer />);
|
render(<Consumer />);
|
||||||
|
|
||||||
selectedIds = ['copied-root-1'];
|
selectedIds = ['copied-root-1'];
|
||||||
pressKey('c');
|
pressKey('c');
|
||||||
expect(getClipboardNodeId()).toBe('copied-root-1');
|
expect(getClipboardTree()!.rootNodeId).toBe('copied-root-1');
|
||||||
|
|
||||||
selectedIds = ['selected-1'];
|
selectedIds = ['selected-1'];
|
||||||
pressKey('v');
|
pressKey('v');
|
||||||
|
|
||||||
// regenerateTreeIds actually ran before the tree was handed to Craft.js.
|
// regenerateTreeIds actually ran before the tree was handed to Craft.js.
|
||||||
expect(regenerateTreeIdsMock).toHaveBeenCalledTimes(1);
|
expect(regenerateTreeIdsMock).toHaveBeenCalledTimes(1);
|
||||||
expect(regenerateTreeIdsMock).toHaveBeenCalledWith(COPIED_TREE);
|
expect(regenerateTreeIdsMock).toHaveBeenCalledWith(getClipboardTree());
|
||||||
|
|
||||||
expect(addNodeTreeMock).toHaveBeenCalledTimes(1);
|
expect(addNodeTreeMock).toHaveBeenCalledTimes(1);
|
||||||
const [pastedTree, targetParent] = addNodeTreeMock.mock.calls[0];
|
const [pastedTree, targetParent, insertIndex] = addNodeTreeMock.mock.calls[0];
|
||||||
|
|
||||||
// Sibling of the current selection: selected-1's data.parent.
|
// Sibling of the current selection: selected-1's data.parent.
|
||||||
expect(targetParent).toBe('parent-container-1');
|
expect(targetParent).toBe('parent-container-1');
|
||||||
|
// Immediately after selected-1 (index 1 among parent-container-1's
|
||||||
|
// children), matching duplicate()'s "insert right after" UX.
|
||||||
|
expect(insertIndex).toBe(2);
|
||||||
|
|
||||||
// The regression this guards: pasted ids must be fresh, never reuse the
|
// The regression this guards: pasted ids must be fresh, never reuse the
|
||||||
// ids the copied node already occupies in the live Craft.js tree.
|
// ids the copied node already occupies in the live Craft.js tree.
|
||||||
@@ -193,9 +210,12 @@ describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => {
|
|||||||
for (const id of pastedIds) {
|
for (const id of pastedIds) {
|
||||||
expect(originalIds.has(id)).toBe(false);
|
expect(originalIds.has(id)).toBe(false);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// The new copy is selected, same as duplicate()'s existing UX.
|
||||||
|
expect(selectNodeMock).toHaveBeenCalledWith(pastedTree.rootNodeId);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('Ctrl+V with selection at ROOT falls back to ROOT as the insertion parent', () => {
|
test('Ctrl+V with selection at ROOT falls back to appending into ROOT', () => {
|
||||||
render(<Consumer />);
|
render(<Consumer />);
|
||||||
|
|
||||||
selectedIds = ['copied-root-1'];
|
selectedIds = ['copied-root-1'];
|
||||||
@@ -205,8 +225,24 @@ describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => {
|
|||||||
pressKey('v');
|
pressKey('v');
|
||||||
|
|
||||||
expect(addNodeTreeMock).toHaveBeenCalledTimes(1);
|
expect(addNodeTreeMock).toHaveBeenCalledTimes(1);
|
||||||
const [, targetParent] = addNodeTreeMock.mock.calls[0];
|
const [, targetParent, insertIndex] = addNodeTreeMock.mock.calls[0];
|
||||||
expect(targetParent).toBe('ROOT');
|
expect(targetParent).toBe('ROOT');
|
||||||
|
expect(insertIndex).toBeUndefined();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('Ctrl+V with nothing selected falls back to appending into ROOT', () => {
|
||||||
|
render(<Consumer />);
|
||||||
|
|
||||||
|
selectedIds = ['copied-root-1'];
|
||||||
|
pressKey('c');
|
||||||
|
|
||||||
|
selectedIds = [];
|
||||||
|
pressKey('v');
|
||||||
|
|
||||||
|
expect(addNodeTreeMock).toHaveBeenCalledTimes(1);
|
||||||
|
const [, targetParent, insertIndex] = addNodeTreeMock.mock.calls[0];
|
||||||
|
expect(targetParent).toBe('ROOT');
|
||||||
|
expect(insertIndex).toBeUndefined();
|
||||||
});
|
});
|
||||||
|
|
||||||
test('Ctrl+V with an empty clipboard is a no-op', () => {
|
test('Ctrl+V with an empty clipboard is a no-op', () => {
|
||||||
@@ -229,9 +265,9 @@ describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => {
|
|||||||
selectedIds = ['selected-1'];
|
selectedIds = ['selected-1'];
|
||||||
|
|
||||||
pressKey('c');
|
pressKey('c');
|
||||||
expect(getClipboardNodeId()).toBeNull();
|
expect(getClipboardTree()).toBeNull();
|
||||||
|
|
||||||
setClipboardNodeId('copied-root-1');
|
setClipboardTree(COPIED_TREE);
|
||||||
pressKey('v');
|
pressKey('v');
|
||||||
expect(addNodeTreeMock).not.toHaveBeenCalled();
|
expect(addNodeTreeMock).not.toHaveBeenCalled();
|
||||||
|
|
||||||
@@ -252,7 +288,7 @@ describe('useKeyboardShortcuts: Ctrl/Cmd+C / Ctrl/Cmd+V', () => {
|
|||||||
selectedIds = ['selected-1'];
|
selectedIds = ['selected-1'];
|
||||||
|
|
||||||
pressKey('c');
|
pressKey('c');
|
||||||
expect(getClipboardNodeId()).toBeNull();
|
expect(getClipboardTree()).toBeNull();
|
||||||
|
|
||||||
activeElementSpy.mockRestore();
|
activeElementSpy.mockRestore();
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -2,7 +2,7 @@ import { useEffect } from 'react';
|
|||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import { findDeletableTarget } from '../utils/craft-helpers';
|
import { findDeletableTarget } from '../utils/craft-helpers';
|
||||||
import { regenerateTreeIds } from '../utils/craft-tree';
|
import { regenerateTreeIds } from '../utils/craft-tree';
|
||||||
import { getClipboardNodeId, setClipboardNodeId } from './clipboard';
|
import { getClipboardTree, setClipboardTree } from './clipboard';
|
||||||
|
|
||||||
function isInputFocused(): boolean {
|
function isInputFocused(): boolean {
|
||||||
const el = document.activeElement;
|
const el = document.activeElement;
|
||||||
@@ -86,13 +86,16 @@ export function useKeyboardShortcuts() {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Ctrl+C: copy selected node id to the shared clipboard
|
// Ctrl+C: copy the selected node's subtree (a detached snapshot, not
|
||||||
|
// just its id -- see clipboard.ts for why: an id-based clipboard can't
|
||||||
|
// survive a page switch, since the copied id no longer exists in
|
||||||
|
// `query` once the canvas is re-deserialized to a different page).
|
||||||
if (ctrl && (e.key === 'c' || e.key === 'C')) {
|
if (ctrl && (e.key === 'c' || e.key === 'C')) {
|
||||||
e.preventDefault();
|
e.preventDefault();
|
||||||
try {
|
try {
|
||||||
const selected = query.getEvent('selected').all();
|
const selected = query.getEvent('selected').all();
|
||||||
if (selected.length > 0 && selected[0] !== 'ROOT') {
|
if (selected.length > 0 && selected[0] !== 'ROOT') {
|
||||||
setClipboardNodeId(selected[0]);
|
setClipboardTree(query.node(selected[0]).toNodeTree());
|
||||||
}
|
}
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
console.error('Copy failed:', err);
|
console.error('Copy failed:', err);
|
||||||
@@ -100,25 +103,44 @@ export function useKeyboardShortcuts() {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Ctrl+V: paste the clipboard node as a sibling of the current selection
|
// Ctrl+V: paste the clipboard tree as a sibling of the current
|
||||||
|
// selection (immediately after it, matching duplicate()'s UX), or
|
||||||
|
// append to ROOT when nothing is selected. Works regardless of which
|
||||||
|
// page is currently on the canvas -- the clipboard tree is a detached
|
||||||
|
// snapshot, not a reference to a node that may no longer exist here.
|
||||||
if (ctrl && (e.key === 'v' || e.key === 'V')) {
|
if (ctrl && (e.key === 'v' || e.key === 'V')) {
|
||||||
e.preventDefault();
|
e.preventDefault();
|
||||||
try {
|
try {
|
||||||
const sourceId = getClipboardNodeId();
|
const clip = getClipboardTree();
|
||||||
if (!sourceId || !query.node(sourceId).get()) return;
|
if (!clip) return;
|
||||||
|
|
||||||
const selected = query.getEvent('selected').all();
|
const selected = query.getEvent('selected').all();
|
||||||
if (selected.length === 0) return;
|
const selectedId = selected.length > 0 ? selected[0] : null;
|
||||||
const selectedId = selected[0];
|
|
||||||
|
|
||||||
let targetParent = 'ROOT';
|
let targetParentId = 'ROOT';
|
||||||
if (selectedId !== 'ROOT') {
|
let insertIndex: number | undefined;
|
||||||
|
if (selectedId && selectedId !== 'ROOT') {
|
||||||
const node = query.node(selectedId).get();
|
const node = query.node(selectedId).get();
|
||||||
targetParent = node?.data?.parent || 'ROOT';
|
const parentId: string | null | undefined = node?.data?.parent;
|
||||||
|
if (parentId) {
|
||||||
|
targetParentId = parentId;
|
||||||
|
try {
|
||||||
|
const siblings: string[] = query.node(parentId).get()?.data?.nodes || [];
|
||||||
|
const idx = siblings.indexOf(selectedId);
|
||||||
|
if (idx !== -1) insertIndex = idx + 1;
|
||||||
|
} catch {
|
||||||
|
// Leave insertIndex undefined -- addNodeTree appends when omitted.
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const tree = regenerateTreeIds(query.node(sourceId).toNodeTree());
|
const tree = regenerateTreeIds(clip);
|
||||||
actions.addNodeTree(tree, targetParent);
|
if (insertIndex !== undefined) {
|
||||||
|
actions.addNodeTree(tree, targetParentId, insertIndex);
|
||||||
|
} else {
|
||||||
|
actions.addNodeTree(tree, targetParentId);
|
||||||
|
}
|
||||||
|
actions.selectNode(tree.rootNodeId);
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
console.error('Paste failed:', err);
|
console.error('Paste failed:', err);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,159 @@
|
|||||||
|
import { describe, test, expect, vi, beforeEach, afterEach } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
import { EditorConfigProvider } from '../state/EditorConfigContext';
|
||||||
|
import { PageProvider, usePages } from '../state/PageContext';
|
||||||
|
import { SiteDesignProvider } from '../state/SiteDesignContext';
|
||||||
|
import { useWhpApi } from './useWhpApi';
|
||||||
|
import { WhpConfig } from '../types';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* PKG-H §5 round-trip coverage: `load()` must restore per-page `seo`
|
||||||
|
* (PageSeo) from `proj.pages_craft_state[].seo` back onto the reconstructed
|
||||||
|
* `PageData`, exactly like it already restores `craftState`. Mocks
|
||||||
|
* `@craftjs/core`'s `useEditor` (same pattern as
|
||||||
|
* `PageContext.pure-updaters.test.tsx`) since this test only needs
|
||||||
|
* `query.serialize`/`actions.deserialize` as inert stubs -- it drives
|
||||||
|
* `load()`, not the live canvas.
|
||||||
|
*/
|
||||||
|
const deserializeMock = vi.fn();
|
||||||
|
vi.mock('@craftjs/core', () => ({
|
||||||
|
useEditor: () => ({
|
||||||
|
query: { serialize: () => '{}' },
|
||||||
|
actions: { deserialize: deserializeMock },
|
||||||
|
}),
|
||||||
|
}));
|
||||||
|
|
||||||
|
const whpConfig: WhpConfig = {
|
||||||
|
user: 'testuser',
|
||||||
|
apiUrl: '/panel/api/site-builder',
|
||||||
|
csrfToken: 'tok',
|
||||||
|
siteId: 42,
|
||||||
|
siteDomain: 'example.com',
|
||||||
|
siteName: 'Test Site',
|
||||||
|
backUrl: '/panel/sites',
|
||||||
|
isRoot: false,
|
||||||
|
};
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
|
||||||
|
interface Captured {
|
||||||
|
load: ReturnType<typeof useWhpApi>['load'];
|
||||||
|
pages: ReturnType<typeof usePages>['pages'];
|
||||||
|
}
|
||||||
|
|
||||||
|
function render(): { get: () => Captured } {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
let captured: Captured | null = null;
|
||||||
|
|
||||||
|
const Consumer: React.FC = () => {
|
||||||
|
const { load } = useWhpApi();
|
||||||
|
const { pages } = usePages();
|
||||||
|
captured = { load, pages };
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(
|
||||||
|
<EditorConfigProvider config={whpConfig}>
|
||||||
|
<SiteDesignProvider>
|
||||||
|
<PageProvider>
|
||||||
|
<Consumer />
|
||||||
|
</PageProvider>
|
||||||
|
</SiteDesignProvider>
|
||||||
|
</EditorConfigProvider>,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
return { get: () => captured! };
|
||||||
|
}
|
||||||
|
|
||||||
|
function unmount() {
|
||||||
|
act(() => {
|
||||||
|
root.unmount();
|
||||||
|
});
|
||||||
|
container.remove();
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('useWhpApi load() restores PageData.seo (PKG-H §5)', () => {
|
||||||
|
beforeEach(() => {
|
||||||
|
deserializeMock.mockClear();
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
vi.unstubAllGlobals();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a saved project with per-page seo restores seo onto the reconstructed PageData', async () => {
|
||||||
|
const seoPayload = {
|
||||||
|
metaTitle: 'Custom Title',
|
||||||
|
metaDescription: 'A custom description.',
|
||||||
|
ogTitle: 'Custom OG Title',
|
||||||
|
ogImage: '/uploads/og.jpg',
|
||||||
|
twitterCard: 'summary_large_image' as const,
|
||||||
|
noindex: true,
|
||||||
|
};
|
||||||
|
|
||||||
|
const fetchMock = vi.fn().mockResolvedValue({
|
||||||
|
json: async () => ({
|
||||||
|
success: true,
|
||||||
|
project: {
|
||||||
|
design: null,
|
||||||
|
header_craft_state: null,
|
||||||
|
footer_craft_state: null,
|
||||||
|
pages_craft_state: [
|
||||||
|
{ id: 'home', name: 'Home', slug: 'index', craftState: '{"ROOT":{}}', seo: seoPayload },
|
||||||
|
{ id: 'page_2', name: 'About', slug: 'about', craftState: '{"ROOT":{}}' },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
});
|
||||||
|
vi.stubGlobal('fetch', fetchMock);
|
||||||
|
|
||||||
|
const harness = render();
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
await harness.get().load();
|
||||||
|
});
|
||||||
|
|
||||||
|
const { pages } = harness.get();
|
||||||
|
expect(pages.find((p) => p.id === 'home')?.seo).toEqual(seoPayload);
|
||||||
|
// A page with no seo in the payload stays undefined -- back-compat, not
|
||||||
|
// coerced into an empty object.
|
||||||
|
expect(pages.find((p) => p.id === 'page_2')?.seo).toBeUndefined();
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a legacy project with no seo on any page loads without adding seo fields', async () => {
|
||||||
|
const fetchMock = vi.fn().mockResolvedValue({
|
||||||
|
json: async () => ({
|
||||||
|
success: true,
|
||||||
|
project: {
|
||||||
|
design: null,
|
||||||
|
header_craft_state: null,
|
||||||
|
footer_craft_state: null,
|
||||||
|
pages_craft_state: [
|
||||||
|
{ id: 'home', name: 'Home', slug: 'index', craftState: '{"ROOT":{}}' },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
});
|
||||||
|
vi.stubGlobal('fetch', fetchMock);
|
||||||
|
|
||||||
|
const harness = render();
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
await harness.get().load();
|
||||||
|
});
|
||||||
|
|
||||||
|
const { pages } = harness.get();
|
||||||
|
expect(pages.find((p) => p.id === 'home')?.seo).toBeUndefined();
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,218 @@
|
|||||||
|
import { describe, test, expect, vi, beforeEach, afterEach } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
import { EditorConfigProvider } from '../state/EditorConfigContext';
|
||||||
|
import { EMPTY_CANVAS, PageProvider, usePages } from '../state/PageContext';
|
||||||
|
import { SiteDesignProvider } from '../state/SiteDesignContext';
|
||||||
|
import { useWhpApi } from './useWhpApi';
|
||||||
|
import { WhpConfig } from '../types';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Task 13b: `PageContext.loadState` runs every stored craft state through
|
||||||
|
* `repairOrphanNodes` before handing it to `actions.deserialize` -- that
|
||||||
|
* covers every page SWITCH (see `PageContext.orphan-repair-wiring.test.tsx`,
|
||||||
|
* the model for this file). But the INITIAL load -- `useWhpApi`'s `load()`,
|
||||||
|
* fired once on mount by `TopBar.tsx` -- used to call
|
||||||
|
* `actions.deserialize(state)` directly on the first page's stored
|
||||||
|
* `craftState`, bypassing repair entirely. A site whose saved state
|
||||||
|
* contains a node unreachable from ROOT would get it silently repaired on
|
||||||
|
* the NEXT page switch but not on the load that actually renders it first.
|
||||||
|
*
|
||||||
|
* This mocks `@craftjs/core` the same way `useWhpApi.load.test.tsx` and
|
||||||
|
* `PageContext.orphan-repair-wiring.test.tsx` do, and asserts on the exact
|
||||||
|
* string handed to the mocked `actions.deserialize` -- the orphan must be
|
||||||
|
* reattached to ROOT and a `console.error` must fire, exactly like the
|
||||||
|
* page-switch path (I5 review: this was `console.warn`, which
|
||||||
|
* console-buffer.ts -- feeding the in-builder issue reporter -- does not
|
||||||
|
* capture).
|
||||||
|
*/
|
||||||
|
const deserializeMock = vi.fn();
|
||||||
|
vi.mock('@craftjs/core', () => ({
|
||||||
|
useEditor: () => ({
|
||||||
|
query: { serialize: () => '{}' },
|
||||||
|
actions: { deserialize: deserializeMock },
|
||||||
|
}),
|
||||||
|
}));
|
||||||
|
|
||||||
|
const whpConfig: WhpConfig = {
|
||||||
|
user: 'testuser',
|
||||||
|
apiUrl: '/panel/api/site-builder',
|
||||||
|
csrfToken: 'tok',
|
||||||
|
siteId: 42,
|
||||||
|
siteDomain: 'example.com',
|
||||||
|
siteName: 'Test Site',
|
||||||
|
backUrl: '/panel/sites',
|
||||||
|
isRoot: false,
|
||||||
|
};
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
|
||||||
|
interface Captured {
|
||||||
|
load: ReturnType<typeof useWhpApi>['load'];
|
||||||
|
pages: ReturnType<typeof usePages>['pages'];
|
||||||
|
}
|
||||||
|
|
||||||
|
function render(): { get: () => Captured } {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
let captured: Captured | null = null;
|
||||||
|
|
||||||
|
const Consumer: React.FC = () => {
|
||||||
|
const { load } = useWhpApi();
|
||||||
|
const { pages } = usePages();
|
||||||
|
captured = { load, pages };
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(
|
||||||
|
<EditorConfigProvider config={whpConfig}>
|
||||||
|
<SiteDesignProvider>
|
||||||
|
<PageProvider>
|
||||||
|
<Consumer />
|
||||||
|
</PageProvider>
|
||||||
|
</SiteDesignProvider>
|
||||||
|
</EditorConfigProvider>,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
return { get: () => captured! };
|
||||||
|
}
|
||||||
|
|
||||||
|
function unmount() {
|
||||||
|
act(() => {
|
||||||
|
root.unmount();
|
||||||
|
});
|
||||||
|
container.remove();
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Same shape as `PageContext.orphan-repair-wiring.test.tsx`'s ORPHAN_STATE:
|
||||||
|
* a ROOT with no children plus an orphan ('stray') whose `parent` points at
|
||||||
|
* an id that doesn't exist in the tree, and which no node's `nodes`/
|
||||||
|
* `linkedNodes` lists -- unreachable by BFS from ROOT. */
|
||||||
|
const ORPHAN_STATE = JSON.stringify({
|
||||||
|
ROOT: {
|
||||||
|
type: { resolvedName: 'Container' },
|
||||||
|
isCanvas: true,
|
||||||
|
props: { style: {}, tag: 'div' },
|
||||||
|
displayName: 'Container',
|
||||||
|
custom: {}, hidden: false, nodes: [], linkedNodes: {}, parent: null,
|
||||||
|
},
|
||||||
|
stray: {
|
||||||
|
type: { resolvedName: 'HtmlBlock' },
|
||||||
|
isCanvas: false,
|
||||||
|
props: { code: '<p>stranded</p>', style: {} },
|
||||||
|
displayName: 'HTML',
|
||||||
|
custom: {}, hidden: false, nodes: [], linkedNodes: {}, parent: 'ghost',
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('useWhpApi load() repairs an orphaned node on the FIRST page before deserializing', () => {
|
||||||
|
beforeEach(() => {
|
||||||
|
deserializeMock.mockClear();
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
vi.unstubAllGlobals();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('initial load with an orphaned first-page craftState reattaches it and warns', async () => {
|
||||||
|
const fetchMock = vi.fn().mockResolvedValue({
|
||||||
|
json: async () => ({
|
||||||
|
success: true,
|
||||||
|
project: {
|
||||||
|
design: null,
|
||||||
|
header_craft_state: null,
|
||||||
|
footer_craft_state: null,
|
||||||
|
pages_craft_state: [
|
||||||
|
{ id: 'home', name: 'Home', slug: 'index', craftState: ORPHAN_STATE },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
});
|
||||||
|
vi.stubGlobal('fetch', fetchMock);
|
||||||
|
|
||||||
|
const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
|
||||||
|
const harness = render();
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
await harness.get().load();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(deserializeMock).toHaveBeenCalled();
|
||||||
|
const passedState = deserializeMock.mock.calls[deserializeMock.mock.calls.length - 1][0];
|
||||||
|
const parsed = JSON.parse(passedState);
|
||||||
|
// The orphan is now an ordinary, reachable child of ROOT.
|
||||||
|
expect(parsed.ROOT.nodes).toContain('stray');
|
||||||
|
expect(parsed.stray.parent).toBe('ROOT');
|
||||||
|
|
||||||
|
// The observable signal that repair actually ran, not just that the
|
||||||
|
// orphan happened to be absent for some unrelated reason. (React's own
|
||||||
|
// act()-environment warnings also go through console.error in this
|
||||||
|
// harness, so search all calls rather than assuming index 0.)
|
||||||
|
expect(errorSpy.mock.calls.some((call) => String(call[0]).includes('reattached'))).toBe(true);
|
||||||
|
|
||||||
|
errorSpy.mockRestore();
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
/**
|
||||||
|
* I5 (review): `PageContext.loadState`'s deserialize failure path logs via
|
||||||
|
* `console.error` AND falls back to `EMPTY_CANVAS` so the user always ends
|
||||||
|
* up with a working (if blank) editor. `useWhpApi.load()`'s equivalent path
|
||||||
|
* used to be `console.warn` with NO fallback deserialize -- the initial
|
||||||
|
* load, which decides whether the user sees a working editor at all, both
|
||||||
|
* failed harder (silently leaving the Frame undeserialized) and reported
|
||||||
|
* quieter than every subsequent page switch. This pins the aligned
|
||||||
|
* behaviour.
|
||||||
|
*/
|
||||||
|
describe('useWhpApi load() falls back to EMPTY_CANVAS when the first page state cannot be deserialized', () => {
|
||||||
|
beforeEach(() => {
|
||||||
|
deserializeMock.mockClear();
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
vi.unstubAllGlobals();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a deserialize failure on the first page logs console.error and retries with EMPTY_CANVAS', async () => {
|
||||||
|
const fetchMock = vi.fn().mockResolvedValue({
|
||||||
|
json: async () => ({
|
||||||
|
success: true,
|
||||||
|
project: {
|
||||||
|
design: null,
|
||||||
|
header_craft_state: null,
|
||||||
|
footer_craft_state: null,
|
||||||
|
pages_craft_state: [
|
||||||
|
{ id: 'home', name: 'Home', slug: 'index', craftState: '{"ROOT":{"broken":true}}' },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
});
|
||||||
|
vi.stubGlobal('fetch', fetchMock);
|
||||||
|
|
||||||
|
deserializeMock.mockImplementationOnce(() => {
|
||||||
|
throw new Error('malformed state');
|
||||||
|
});
|
||||||
|
|
||||||
|
const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
|
||||||
|
const harness = render();
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
await harness.get().load();
|
||||||
|
});
|
||||||
|
|
||||||
|
// First call (the broken state) threw; the second call is the fallback.
|
||||||
|
expect(deserializeMock).toHaveBeenCalledTimes(2);
|
||||||
|
expect(deserializeMock.mock.calls[1][0]).toBe(EMPTY_CANVAS);
|
||||||
|
|
||||||
|
expect(errorSpy).toHaveBeenCalledWith('Failed to load page state:', expect.any(Error));
|
||||||
|
|
||||||
|
errorSpy.mockRestore();
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -147,4 +147,63 @@ describe('buildSavePayload', () => {
|
|||||||
expect(payload.design).toEqual(design);
|
expect(payload.design).toEqual(design);
|
||||||
expect(payload.design.headCode).toBe('<meta name="x">');
|
expect(payload.design.headCode).toBe('<meta name="x">');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('PKG-H §5: per-page seo is included in both pages_craft_state and pages entries', () => {
|
||||||
|
const pageWithSeo: PageData = {
|
||||||
|
id: 'home',
|
||||||
|
name: 'Home',
|
||||||
|
slug: 'index',
|
||||||
|
craftState: 'STORED_HOME',
|
||||||
|
seo: {
|
||||||
|
metaTitle: 'Custom Title',
|
||||||
|
metaDescription: 'Custom description',
|
||||||
|
ogTitle: 'Custom OG',
|
||||||
|
ogImage: '/uploads/og.jpg',
|
||||||
|
twitterCard: 'summary_large_image',
|
||||||
|
noindex: true,
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
const payload = buildSavePayload({
|
||||||
|
siteId: 1,
|
||||||
|
siteName: 'Test Site',
|
||||||
|
liveCraftState: 'LIVE_PAGE_HOME',
|
||||||
|
pages: [pageWithSeo, pageB],
|
||||||
|
headerPage,
|
||||||
|
footerPage,
|
||||||
|
activePageId: 'home',
|
||||||
|
isEditingHeader: false,
|
||||||
|
isEditingFooter: false,
|
||||||
|
headCode: DEFAULT_SITE_DESIGN.headCode,
|
||||||
|
design: DEFAULT_SITE_DESIGN,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(payload.pages_craft_state.find((p) => p.id === 'home')?.seo).toEqual(pageWithSeo.seo);
|
||||||
|
expect(payload.pages.find((p) => p.filename === 'index.html')?.seo).toEqual(pageWithSeo.seo);
|
||||||
|
|
||||||
|
// A page with no seo overrides omits the field entirely (undefined),
|
||||||
|
// not an empty object -- back-compat with pre-PKG-H saved shapes.
|
||||||
|
expect(payload.pages_craft_state.find((p) => p.id === 'page_2')?.seo).toBeUndefined();
|
||||||
|
expect(payload.pages.find((p) => p.filename === 'about.html')?.seo).toBeUndefined();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('PKG-H §5: favicon flows through the design object already carried by the payload', () => {
|
||||||
|
const design = { ...DEFAULT_SITE_DESIGN, favicon: '/uploads/favicon.png' };
|
||||||
|
|
||||||
|
const payload = buildSavePayload({
|
||||||
|
siteId: 1,
|
||||||
|
siteName: 'Test Site',
|
||||||
|
liveCraftState: 'LIVE_PAGE_HOME',
|
||||||
|
pages: [pageA, pageB],
|
||||||
|
headerPage,
|
||||||
|
footerPage,
|
||||||
|
activePageId: 'home',
|
||||||
|
isEditingHeader: false,
|
||||||
|
isEditingFooter: false,
|
||||||
|
headCode: DEFAULT_SITE_DESIGN.headCode,
|
||||||
|
design,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(payload.design.favicon).toBe('/uploads/favicon.png');
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,9 +1,10 @@
|
|||||||
import { useCallback } from 'react';
|
import { useCallback } from 'react';
|
||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import { useEditorConfig } from '../state/EditorConfigContext';
|
import { useEditorConfig } from '../state/EditorConfigContext';
|
||||||
import { usePages } from '../state/PageContext';
|
import { usePages, EMPTY_CANVAS } from '../state/PageContext';
|
||||||
import { useSiteDesign, SiteDesign } from '../state/SiteDesignContext';
|
import { useSiteDesign, SiteDesign } from '../state/SiteDesignContext';
|
||||||
import { exportBodyHtml } from '../utils/html-export';
|
import { exportBodyHtml } from '../utils/html-export';
|
||||||
|
import { repairOrphanNodes } from '../utils/orphan-repair';
|
||||||
import { PageData } from '../types';
|
import { PageData } from '../types';
|
||||||
|
|
||||||
export interface BuildSavePayloadInput {
|
export interface BuildSavePayloadInput {
|
||||||
@@ -149,6 +150,12 @@ export function buildSavePayload(input: BuildSavePayloadInput) {
|
|||||||
filename,
|
filename,
|
||||||
title: page.name,
|
title: page.name,
|
||||||
html: pageHtml,
|
html: pageHtml,
|
||||||
|
// PKG-H §5: per-page SEO overrides, read by the backend's
|
||||||
|
// `handlePublish` (mirrors the existing `title` field above) to build
|
||||||
|
// the published <head> for this file. Omitted (undefined) when the
|
||||||
|
// page has no seo overrides -- JSON.stringify drops undefined keys,
|
||||||
|
// so legacy-shaped payloads round-trip unchanged.
|
||||||
|
seo: page.seo,
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -166,6 +173,9 @@ export function buildSavePayload(input: BuildSavePayloadInput) {
|
|||||||
// name.html) lines up with the file we just wrote (index.html).
|
// name.html) lines up with the file we just wrote (index.html).
|
||||||
slug: i === 0 ? 'index' : page.slug,
|
slug: i === 0 ? 'index' : page.slug,
|
||||||
craftState: (isPageActive && page.id === effectiveActivePageId) ? liveCraftState : (page.craftState || null),
|
craftState: (isPageActive && page.id === effectiveActivePageId) ? liveCraftState : (page.craftState || null),
|
||||||
|
// PKG-H §5: round-trips PageData.seo through save -> load() so the
|
||||||
|
// editor's SEO fields survive a reload (mirrors craftState above).
|
||||||
|
seo: page.seo,
|
||||||
}));
|
}));
|
||||||
|
|
||||||
return {
|
return {
|
||||||
@@ -292,19 +302,46 @@ export function useWhpApi() {
|
|||||||
|
|
||||||
// Restore pages and load the first page into the canvas
|
// Restore pages and load the first page into the canvas
|
||||||
if (proj.pages_craft_state && Array.isArray(proj.pages_craft_state) && proj.pages_craft_state.length > 0) {
|
if (proj.pages_craft_state && Array.isArray(proj.pages_craft_state) && proj.pages_craft_state.length > 0) {
|
||||||
setPagesCraftState(proj.pages_craft_state.map((p: { id: string; name: string; slug: string; craftState: string | null }) => ({
|
setPagesCraftState(proj.pages_craft_state.map((p: { id: string; name: string; slug: string; craftState: string | null; seo?: PageData['seo'] }) => ({
|
||||||
id: p.id, name: p.name, slug: p.slug, craftState: p.craftState || null,
|
id: p.id, name: p.name, slug: p.slug, craftState: p.craftState || null, seo: p.seo,
|
||||||
})));
|
})));
|
||||||
|
|
||||||
// Load the first page (home) into the canvas
|
// Load the first page (home) into the canvas. Routed through
|
||||||
|
// `repairOrphanNodes` first -- same as `PageContext.loadState` does
|
||||||
|
// for every subsequent page switch -- so a node that's unreachable
|
||||||
|
// from ROOT (invisible to Layers/selection) gets reattached here
|
||||||
|
// too, on the load that actually puts it on screen, rather than only
|
||||||
|
// on the next page switch. `repairOrphanNodes` never throws and
|
||||||
|
// returns the original string reference when nothing needed fixing,
|
||||||
|
// so this is cheap to run unconditionally.
|
||||||
const firstPage = proj.pages_craft_state[0];
|
const firstPage = proj.pages_craft_state[0];
|
||||||
if (firstPage.craftState) {
|
if (firstPage.craftState) {
|
||||||
try {
|
try {
|
||||||
const state = typeof firstPage.craftState === 'string'
|
const rawState = typeof firstPage.craftState === 'string'
|
||||||
? firstPage.craftState : JSON.stringify(firstPage.craftState);
|
? firstPage.craftState : JSON.stringify(firstPage.craftState);
|
||||||
|
const { state, repaired } = repairOrphanNodes(rawState);
|
||||||
|
if (repaired.length > 0) {
|
||||||
|
// I5: console-buffer.ts only patches console.error, and this
|
||||||
|
// reattach signal is the single most diagnostic clue for the
|
||||||
|
// still-unreproduced "elements drop off the canvas" report --
|
||||||
|
// it must reach the in-builder issue reporter's console buffer.
|
||||||
|
console.error(
|
||||||
|
`[site-builder] reattached ${repaired.length} unreachable node(s) to the page root:`,
|
||||||
|
repaired.join(', '),
|
||||||
|
);
|
||||||
|
}
|
||||||
actions.deserialize(state);
|
actions.deserialize(state);
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
console.warn('Failed to load page state:', e);
|
// I5: this is the initial load that decides whether the user
|
||||||
|
// sees a working editor at all -- align with `loadState`'s
|
||||||
|
// behaviour (console.error + a known-safe fallback) instead of
|
||||||
|
// warning quietly and leaving the Frame on whatever it last had.
|
||||||
|
console.error('Failed to load page state:', e);
|
||||||
|
try {
|
||||||
|
actions.deserialize(EMPTY_CANVAS);
|
||||||
|
} catch (_e2) {
|
||||||
|
// give up
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -2,8 +2,24 @@ import React from 'react';
|
|||||||
import ReactDOM from 'react-dom/client';
|
import ReactDOM from 'react-dom/client';
|
||||||
import { App } from './App';
|
import { App } from './App';
|
||||||
import { WhpConfig } from './types';
|
import { WhpConfig } from './types';
|
||||||
|
import { installConsoleErrorBuffer } from './utils/console-buffer';
|
||||||
|
import { editorBuild } from './utils/build-stamp';
|
||||||
import './styles/editor.css';
|
import './styles/editor.css';
|
||||||
|
|
||||||
|
// Installed before React mounts so errors thrown during the first render are
|
||||||
|
// captured too.
|
||||||
|
installConsoleErrorBuffer();
|
||||||
|
|
||||||
|
// Exposed on window (not logged -- no need to print this on every load for
|
||||||
|
// every customer) so support can ask someone to type __WHP_EDITOR_BUILD__
|
||||||
|
// in the console on request. This call is also load-bearing for bundling:
|
||||||
|
// it is currently the only reference to `editorBuild()`, which keeps the
|
||||||
|
// __EDITOR_BUILD__-reading module from being tree-shaken out of the bundle
|
||||||
|
// before Task 19 wires it into the report payload. Do not remove this line
|
||||||
|
// as a "stray global" cleanup -- doing so silently reverts every future
|
||||||
|
// bug report to showing 'dev' instead of a real build stamp.
|
||||||
|
(window as any).__WHP_EDITOR_BUILD__ = editorBuild();
|
||||||
|
|
||||||
// Read WHP_CONFIG injected by PHP wrapper (or null for standalone dev)
|
// Read WHP_CONFIG injected by PHP wrapper (or null for standalone dev)
|
||||||
const whpConfig: WhpConfig | null = (window as any).WHP_CONFIG || null;
|
const whpConfig: WhpConfig | null = (window as any).WHP_CONFIG || null;
|
||||||
|
|
||||||
|
|||||||
@@ -3,7 +3,7 @@ import { useEditor } from '@craftjs/core';
|
|||||||
import { useSitesmithModal } from '../../state/SitesmithContext';
|
import { useSitesmithModal } from '../../state/SitesmithContext';
|
||||||
import { buildSitesmithTarget } from '../../utils/sitesmith-target';
|
import { buildSitesmithTarget } from '../../utils/sitesmith-target';
|
||||||
import { regenerateTreeIds } from '../../utils/craft-tree';
|
import { regenerateTreeIds } from '../../utils/craft-tree';
|
||||||
import { getClipboardNodeId, setClipboardNodeId } from '../../hooks/clipboard';
|
import { getClipboardTree, setClipboardTree } from '../../hooks/clipboard';
|
||||||
import { useNodeActions } from '../../hooks/useNodeActions';
|
import { useNodeActions } from '../../hooks/useNodeActions';
|
||||||
|
|
||||||
interface ContextMenuProps {
|
interface ContextMenuProps {
|
||||||
@@ -79,35 +79,54 @@ export const ContextMenu: React.FC<ContextMenuProps> = ({
|
|||||||
const copyNode = useCallback(() => {
|
const copyNode = useCallback(() => {
|
||||||
if (!nodeId || nodeId === 'ROOT') return;
|
if (!nodeId || nodeId === 'ROOT') return;
|
||||||
try {
|
try {
|
||||||
setClipboardNodeId(nodeId);
|
// Store a detached subtree snapshot, not just the id -- an id-based
|
||||||
|
// clipboard can't survive a page switch (the copied id no longer
|
||||||
|
// exists in `query` once the canvas is re-deserialized to a different
|
||||||
|
// page's Craft.js state). See clipboard.ts.
|
||||||
|
setClipboardTree(query.node(nodeId).toNodeTree());
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
console.error('Copy failed:', e);
|
console.error('Copy failed:', e);
|
||||||
}
|
}
|
||||||
onClose();
|
onClose();
|
||||||
}, [nodeId, onClose]);
|
}, [nodeId, query, onClose]);
|
||||||
|
|
||||||
const pasteNode = useCallback(() => {
|
const pasteNode = useCallback(() => {
|
||||||
const sourceId = getClipboardNodeId();
|
const clip = getClipboardTree();
|
||||||
if (!sourceId) {
|
if (!clip) {
|
||||||
onClose();
|
onClose();
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
try {
|
try {
|
||||||
if (!query.node(sourceId).get()) {
|
// Paste as a SIBLING of the right-clicked node (immediately after it,
|
||||||
onClose();
|
// matching duplicate()'s UX), not as its child -- using the clicked
|
||||||
return;
|
// node itself as the parent throws when it's a leaf. Falls back to
|
||||||
}
|
// appending into ROOT when nothing valid was right-clicked. This works
|
||||||
|
// regardless of which page is on the canvas -- the clipboard tree is a
|
||||||
// Paste as a SIBLING of the right-clicked node, not as its child --
|
// detached snapshot, not a reference to a node that may not exist here.
|
||||||
// using the clicked node itself as the parent throws when it's a leaf.
|
|
||||||
let targetParent = 'ROOT';
|
let targetParent = 'ROOT';
|
||||||
|
let insertIndex: number | undefined;
|
||||||
if (nodeId && nodeId !== 'ROOT') {
|
if (nodeId && nodeId !== 'ROOT') {
|
||||||
const clickedNode = query.node(nodeId).get();
|
const clickedNode = query.node(nodeId).get();
|
||||||
targetParent = clickedNode?.data?.parent || 'ROOT';
|
const parentId: string | null | undefined = clickedNode?.data?.parent;
|
||||||
|
if (parentId) {
|
||||||
|
targetParent = parentId;
|
||||||
|
try {
|
||||||
|
const siblings: string[] = query.node(parentId).get()?.data?.nodes || [];
|
||||||
|
const idx = siblings.indexOf(nodeId);
|
||||||
|
if (idx !== -1) insertIndex = idx + 1;
|
||||||
|
} catch {
|
||||||
|
// Leave insertIndex undefined -- addNodeTree appends when omitted.
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const tree = regenerateTreeIds(query.node(sourceId).toNodeTree());
|
const tree = regenerateTreeIds(clip);
|
||||||
actions.addNodeTree(tree, targetParent);
|
if (insertIndex !== undefined) {
|
||||||
|
actions.addNodeTree(tree, targetParent, insertIndex);
|
||||||
|
} else {
|
||||||
|
actions.addNodeTree(tree, targetParent);
|
||||||
|
}
|
||||||
|
actions.selectNode(tree.rootNodeId);
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
console.error('Paste failed:', e);
|
console.error('Paste failed:', e);
|
||||||
}
|
}
|
||||||
@@ -176,7 +195,7 @@ export const ContextMenu: React.FC<ContextMenuProps> = ({
|
|||||||
icon: 'clipboard',
|
icon: 'clipboard',
|
||||||
shortcut: 'Ctrl+V',
|
shortcut: 'Ctrl+V',
|
||||||
action: pasteNode,
|
action: pasteNode,
|
||||||
disabled: !getClipboardNodeId(),
|
disabled: !getClipboardTree(),
|
||||||
dividerAfter: true,
|
dividerAfter: true,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -0,0 +1,59 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
import { LayerFocusProvider, useLayerFocus } from './LayerFocusContext';
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
|
||||||
|
const Probe: React.FC = () => {
|
||||||
|
const { focus, requestFocus } = useLayerFocus();
|
||||||
|
return (
|
||||||
|
<div>
|
||||||
|
<button onClick={() => requestFocus('n1', 'features', 2)}>request</button>
|
||||||
|
<span data-testid="state">{focus ? `${focus.nodeId}:${focus.prop}:${focus.index}:${focus.nonce}` : 'none'}</span>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
function render() {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(<LayerFocusProvider><Probe /></LayerFocusProvider>);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('LayerFocusContext', () => {
|
||||||
|
test('starts with no focus request', () => {
|
||||||
|
render();
|
||||||
|
expect(container.querySelector('[data-testid="state"]')!.textContent).toBe('none');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('requestFocus publishes the target', () => {
|
||||||
|
render();
|
||||||
|
act(() => { (container.querySelector('button') as HTMLButtonElement).click(); });
|
||||||
|
expect(container.querySelector('[data-testid="state"]')!.textContent).toBe('n1:features:2:1');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('repeating the same request bumps the nonce so consumers re-fire', () => {
|
||||||
|
render();
|
||||||
|
const btn = container.querySelector('button') as HTMLButtonElement;
|
||||||
|
act(() => { btn.click(); });
|
||||||
|
act(() => { btn.click(); });
|
||||||
|
expect(container.querySelector('[data-testid="state"]')!.textContent).toBe('n1:features:2:2');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('useLayerFocus outside a provider is inert rather than a crash', () => {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
expect(() => {
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(<Probe />);
|
||||||
|
});
|
||||||
|
}).not.toThrow();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,44 @@
|
|||||||
|
import React, { createContext, useCallback, useContext, useMemo, useRef, useState } from 'react';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Carries "the user clicked a virtual Layers row -- scroll that array item's
|
||||||
|
* card into view" from the Layers panel (left) to the array editors (right).
|
||||||
|
*
|
||||||
|
* Deliberately a request, not a command: consumers that don't implement
|
||||||
|
* scrolling simply ignore it. Selecting the parent node always happens in
|
||||||
|
* LayersPanel itself, so a click is useful even with no consumer at all.
|
||||||
|
*/
|
||||||
|
|
||||||
|
export interface LayerFocusRequest {
|
||||||
|
nodeId: string;
|
||||||
|
prop: string;
|
||||||
|
index: number;
|
||||||
|
/** Bumped on every request so an identical repeat still re-fires effects. */
|
||||||
|
nonce: number;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface LayerFocusValue {
|
||||||
|
focus: LayerFocusRequest | null;
|
||||||
|
requestFocus(nodeId: string, prop: string, index: number): void;
|
||||||
|
}
|
||||||
|
|
||||||
|
const LayerFocusContext = createContext<LayerFocusValue>({
|
||||||
|
focus: null,
|
||||||
|
requestFocus: () => {},
|
||||||
|
});
|
||||||
|
|
||||||
|
export const useLayerFocus = (): LayerFocusValue => useContext(LayerFocusContext);
|
||||||
|
|
||||||
|
export const LayerFocusProvider: React.FC<{ children: React.ReactNode }> = ({ children }) => {
|
||||||
|
const [focus, setFocus] = useState<LayerFocusRequest | null>(null);
|
||||||
|
const nonceRef = useRef(0);
|
||||||
|
|
||||||
|
const requestFocus = useCallback((nodeId: string, prop: string, index: number) => {
|
||||||
|
nonceRef.current += 1;
|
||||||
|
setFocus({ nodeId, prop, index, nonce: nonceRef.current });
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
const value = useMemo(() => ({ focus, requestFocus }), [focus, requestFocus]);
|
||||||
|
|
||||||
|
return <LayerFocusContext.Provider value={value}>{children}</LayerFocusContext.Provider>;
|
||||||
|
};
|
||||||
@@ -0,0 +1,102 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { renderEditorHarness } from '../../test-utils/editorHarness';
|
||||||
|
import { LayersPanel } from './LayersPanel';
|
||||||
|
import { LayerFocusProvider } from './LayerFocusContext';
|
||||||
|
|
||||||
|
function stateWith(extra: Record<string, any>, rootChildren: string[]) {
|
||||||
|
return JSON.stringify({
|
||||||
|
ROOT: {
|
||||||
|
type: { resolvedName: 'Container' }, isCanvas: true,
|
||||||
|
props: { style: {}, tag: 'div' }, displayName: 'Container',
|
||||||
|
custom: {}, hidden: false, nodes: rootChildren, linkedNodes: {}, parent: null,
|
||||||
|
},
|
||||||
|
...extra,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
const featuresNode = {
|
||||||
|
type: { resolvedName: 'FeaturesGrid' }, isCanvas: false,
|
||||||
|
props: { features: [{ title: 'Fast' }, { title: 'Secure' }] },
|
||||||
|
displayName: 'Features Grid',
|
||||||
|
custom: {}, hidden: false, nodes: [], linkedNodes: {}, parent: 'ROOT',
|
||||||
|
};
|
||||||
|
|
||||||
|
describe('LayersPanel', () => {
|
||||||
|
test('shows virtual rows for a Features Grid array prop', () => {
|
||||||
|
const harness = renderEditorHarness({ initialState: stateWith({ f1: featuresNode }, ['f1']) });
|
||||||
|
harness.mountChild(<LayerFocusProvider><LayersPanel /></LayerFocusProvider>);
|
||||||
|
|
||||||
|
// Scoped to `.layer-virtual-row` rather than the whole container:
|
||||||
|
// `FeaturesGrid` itself renders `feat.title` on the live canvas (which
|
||||||
|
// is also mounted inside `harness.container`, alongside the panel), so
|
||||||
|
// asserting on `container.textContent` alone would pass even if
|
||||||
|
// LayersPanel never rendered a single virtual row -- the "Fast"/"Secure"
|
||||||
|
// text would already be there from the canvas. Scoping to the virtual
|
||||||
|
// row elements themselves makes the assertion actually exercise
|
||||||
|
// LayersPanel's own rendering.
|
||||||
|
const virtualRows = harness.container.querySelectorAll('.layer-virtual-row');
|
||||||
|
expect(virtualRows).toHaveLength(2);
|
||||||
|
const virtualText = Array.from(virtualRows).map((el) => el.textContent).join(' | ');
|
||||||
|
expect(virtualText).toContain('Fast');
|
||||||
|
expect(virtualText).toContain('Secure');
|
||||||
|
|
||||||
|
// The real node row for the parent is still shown too.
|
||||||
|
const nodeRows = harness.container.querySelectorAll('.layer-node-row');
|
||||||
|
const nodeText = Array.from(nodeRows).map((el) => el.textContent).join(' | ');
|
||||||
|
expect(nodeText).toContain('Features Grid');
|
||||||
|
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('virtual rows are not rendered for a component with no registry entry', () => {
|
||||||
|
const heading = {
|
||||||
|
type: { resolvedName: 'Heading' }, isCanvas: false,
|
||||||
|
props: { text: 'Title', level: 2 }, displayName: 'Heading',
|
||||||
|
custom: {}, hidden: false, nodes: [], linkedNodes: {}, parent: 'ROOT',
|
||||||
|
};
|
||||||
|
const harness = renderEditorHarness({ initialState: stateWith({ h1: heading }, ['h1']) });
|
||||||
|
harness.mountChild(<LayerFocusProvider><LayersPanel /></LayerFocusProvider>);
|
||||||
|
expect(harness.container.querySelectorAll('.layer-virtual-row')).toHaveLength(0);
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the Unplaced group does not render for a healthy tree', () => {
|
||||||
|
const harness = renderEditorHarness({ initialState: stateWith({ f1: featuresNode }, ['f1']) });
|
||||||
|
harness.mountChild(<LayerFocusProvider><LayersPanel /></LayerFocusProvider>);
|
||||||
|
expect(harness.container.textContent).not.toContain('Unplaced');
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the Unplaced group appears and lists a node unreachable from ROOT', () => {
|
||||||
|
// 'stray' is a real node in the deserialized state, but no node's
|
||||||
|
// `nodes`/`linkedNodes` list references it -- exactly the "dropped
|
||||||
|
// outside the page" scenario findUnreachableNodeIds exists to catch.
|
||||||
|
const heading = {
|
||||||
|
type: { resolvedName: 'Heading' }, isCanvas: false,
|
||||||
|
props: { text: 'Title', level: 2 }, displayName: 'Heading',
|
||||||
|
custom: {}, hidden: false, nodes: [], linkedNodes: {}, parent: 'ROOT',
|
||||||
|
};
|
||||||
|
const stray = {
|
||||||
|
type: { resolvedName: 'HtmlBlock' }, isCanvas: false,
|
||||||
|
props: { code: '<p>stranded</p>', style: {} }, displayName: 'HTML',
|
||||||
|
custom: {}, hidden: false, nodes: [], linkedNodes: {}, parent: 'ghost',
|
||||||
|
};
|
||||||
|
const harness = renderEditorHarness({
|
||||||
|
initialState: stateWith({ h1: heading, stray }, ['h1']),
|
||||||
|
});
|
||||||
|
harness.mountChild(<LayerFocusProvider><LayersPanel /></LayerFocusProvider>);
|
||||||
|
|
||||||
|
expect(harness.container.textContent).toContain('Unplaced');
|
||||||
|
expect(harness.container.textContent).toContain('Unplaced (1)');
|
||||||
|
|
||||||
|
// The orphan itself is rendered as a selectable/deletable LayerNode row
|
||||||
|
// (displayName 'HTML') underneath the Unplaced heading, not silently
|
||||||
|
// dropped from the tree.
|
||||||
|
const nodeRows = harness.container.querySelectorAll('.layer-node-row');
|
||||||
|
const nodeText = Array.from(nodeRows).map((el) => el.textContent).join(' | ');
|
||||||
|
expect(nodeText).toContain('HTML');
|
||||||
|
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -1,6 +1,9 @@
|
|||||||
import React, { useCallback, useEffect, useRef } from 'react';
|
import React, { useCallback, useEffect, useRef } from 'react';
|
||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import { clickableProps } from '../../utils/a11y';
|
import { clickableProps } from '../../utils/a11y';
|
||||||
|
import { deriveVirtualRows, VIRTUAL_CHILD_PROPS } from './layers-virtual-rows';
|
||||||
|
import { useLayerFocus } from './LayerFocusContext';
|
||||||
|
import { findUnreachableNodeIds } from '../../utils/orphan-repair';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Per-type icon lookup keyed by the component's `craft.displayName` (the
|
* Per-type icon lookup keyed by the component's `craft.displayName` (the
|
||||||
@@ -62,12 +65,51 @@ const TYPE_ICONS: Record<string, string> = {
|
|||||||
const DEFAULT_ICON = 'fa-cube';
|
const DEFAULT_ICON = 'fa-cube';
|
||||||
const ROOT_ICON = 'fa-desktop';
|
const ROOT_ICON = 'fa-desktop';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* A display-only row for one item of a composite's array prop (a Features
|
||||||
|
* Grid feature, a Tabs tab, ...). Not a Craft node: it can't be dragged or
|
||||||
|
* deleted. Clicking it selects the PARENT and asks the array editor to
|
||||||
|
* scroll that item's card into view.
|
||||||
|
*/
|
||||||
|
const VirtualRowNode: React.FC<{
|
||||||
|
parentId: string;
|
||||||
|
prop: string;
|
||||||
|
index: number;
|
||||||
|
label: string;
|
||||||
|
depth: number;
|
||||||
|
onActivate: () => void;
|
||||||
|
}> = ({ index, label, depth, onActivate }) => (
|
||||||
|
<div
|
||||||
|
{...clickableProps(onActivate)}
|
||||||
|
className="layer-virtual-row"
|
||||||
|
title={label}
|
||||||
|
style={{
|
||||||
|
display: 'flex',
|
||||||
|
alignItems: 'center',
|
||||||
|
padding: '4px 8px',
|
||||||
|
paddingLeft: `${8 + depth * 16}px`,
|
||||||
|
fontSize: 11,
|
||||||
|
color: 'var(--color-text-dim)',
|
||||||
|
cursor: 'pointer',
|
||||||
|
whiteSpace: 'nowrap',
|
||||||
|
overflow: 'hidden',
|
||||||
|
textOverflow: 'ellipsis',
|
||||||
|
userSelect: 'none',
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<span style={{ marginRight: 6, fontSize: 8, flexShrink: 0 }} aria-hidden="true">▪</span>
|
||||||
|
<span style={{ overflow: 'hidden', textOverflow: 'ellipsis' }}>{label}</span>
|
||||||
|
<span style={{ marginLeft: 'auto', paddingLeft: 6, opacity: 0.6, flexShrink: 0 }}>{index + 1}</span>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
|
||||||
interface LayerNodeProps {
|
interface LayerNodeProps {
|
||||||
nodeId: string;
|
nodeId: string;
|
||||||
depth: number;
|
depth: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
||||||
|
const { requestFocus } = useLayerFocus();
|
||||||
const { node, selectedId, actions, query } = useEditor((state) => {
|
const { node, selectedId, actions, query } = useEditor((state) => {
|
||||||
const n = state.nodes[nodeId];
|
const n = state.nodes[nodeId];
|
||||||
const selectedIds = state.events.selected;
|
const selectedIds = state.events.selected;
|
||||||
@@ -140,6 +182,10 @@ const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
|||||||
const isRoot = nodeId === 'ROOT';
|
const isRoot = nodeId === 'ROOT';
|
||||||
const icon = isRoot ? ROOT_ICON : TYPE_ICONS[displayName] || DEFAULT_ICON;
|
const icon = isRoot ? ROOT_ICON : TYPE_ICONS[displayName] || DEFAULT_ICON;
|
||||||
|
|
||||||
|
const virtualSpec = VIRTUAL_CHILD_PROPS[displayName];
|
||||||
|
const virtualRows = virtualSpec ? deriveVirtualRows(displayName, node.data.props || {}) : [];
|
||||||
|
const hasDisclosure = allChildren.length + virtualRows.length > 0;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div>
|
<div>
|
||||||
<div
|
<div
|
||||||
@@ -187,7 +233,7 @@ const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
|||||||
))}
|
))}
|
||||||
|
|
||||||
{/* Indentation/disclosure indicator */}
|
{/* Indentation/disclosure indicator */}
|
||||||
{allChildren.length > 0 ? (
|
{hasDisclosure ? (
|
||||||
<span style={{ marginRight: 4, fontSize: 8, color: 'var(--color-text-dim)', flexShrink: 0 }}>
|
<span style={{ marginRight: 4, fontSize: 8, color: 'var(--color-text-dim)', flexShrink: 0 }}>
|
||||||
▼
|
▼
|
||||||
</span>
|
</span>
|
||||||
@@ -217,6 +263,23 @@ const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
|||||||
</span>
|
</span>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
{/* Virtual rows: array-prop items (composite content Craft doesn't see
|
||||||
|
as child nodes), rendered before real children. */}
|
||||||
|
{virtualSpec && virtualRows.map((row) => (
|
||||||
|
<VirtualRowNode
|
||||||
|
key={`${nodeId}:${virtualSpec.prop}:${row.index}`}
|
||||||
|
parentId={nodeId}
|
||||||
|
prop={virtualSpec.prop}
|
||||||
|
index={row.index}
|
||||||
|
label={row.label}
|
||||||
|
depth={depth + 1}
|
||||||
|
onActivate={() => {
|
||||||
|
actions.selectNode(nodeId);
|
||||||
|
requestFocus(nodeId, virtualSpec.prop, row.index);
|
||||||
|
}}
|
||||||
|
/>
|
||||||
|
))}
|
||||||
|
|
||||||
{/* Render children */}
|
{/* Render children */}
|
||||||
{allChildren.map((childId) => (
|
{allChildren.map((childId) => (
|
||||||
<LayerNode key={childId} nodeId={childId} depth={depth + 1} />
|
<LayerNode key={childId} nodeId={childId} depth={depth + 1} />
|
||||||
@@ -226,9 +289,17 @@ const LayerNode: React.FC<LayerNodeProps> = ({ nodeId, depth }) => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
export const LayersPanel: React.FC = () => {
|
export const LayersPanel: React.FC = () => {
|
||||||
const { nodeIds } = useEditor((state) => {
|
const { nodeIds, unplacedIds } = useEditor((state) => {
|
||||||
|
const serializable: Record<string, any> = {};
|
||||||
|
for (const [id, n] of Object.entries(state.nodes)) {
|
||||||
|
serializable[id] = {
|
||||||
|
nodes: n.data.nodes || [],
|
||||||
|
linkedNodes: n.data.linkedNodes || {},
|
||||||
|
};
|
||||||
|
}
|
||||||
return {
|
return {
|
||||||
nodeIds: Object.keys(state.nodes),
|
nodeIds: Object.keys(state.nodes),
|
||||||
|
unplacedIds: findUnreachableNodeIds(serializable),
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -243,13 +314,7 @@ export const LayersPanel: React.FC = () => {
|
|||||||
}
|
}
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div
|
<div style={{ display: 'flex', flexDirection: 'column', margin: '-12px', minHeight: 0 }}>
|
||||||
style={{
|
|
||||||
display: 'flex',
|
|
||||||
flexDirection: 'column',
|
|
||||||
margin: '-12px',
|
|
||||||
}}
|
|
||||||
>
|
|
||||||
<div
|
<div
|
||||||
style={{
|
style={{
|
||||||
padding: '8px 12px',
|
padding: '8px 12px',
|
||||||
@@ -259,11 +324,44 @@ export const LayersPanel: React.FC = () => {
|
|||||||
letterSpacing: '0.5px',
|
letterSpacing: '0.5px',
|
||||||
color: 'var(--color-text-muted)',
|
color: 'var(--color-text-muted)',
|
||||||
borderBottom: '1px solid var(--color-border)',
|
borderBottom: '1px solid var(--color-border)',
|
||||||
|
flexShrink: 0,
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
Component Tree
|
Component Tree
|
||||||
</div>
|
</div>
|
||||||
<LayerNode nodeId="ROOT" depth={0} />
|
|
||||||
|
{/* Own scroll container: a deep or long tree must stay fully reachable
|
||||||
|
regardless of how the parent tab panel is sized. */}
|
||||||
|
<div className="layers-tree-scroll" style={{ overflowY: 'auto', flex: 1, minHeight: 0 }}>
|
||||||
|
<LayerNode nodeId="ROOT" depth={0} />
|
||||||
|
|
||||||
|
{/* Unplaced: nodes no parent lists. `repairOrphanNodes` reattaches
|
||||||
|
these on load, so this should stay empty -- it exists so an
|
||||||
|
element stranded mid-session is still selectable and deletable
|
||||||
|
rather than invisible. */}
|
||||||
|
{unplacedIds.length > 0 && (
|
||||||
|
<>
|
||||||
|
<div
|
||||||
|
style={{
|
||||||
|
padding: '8px 12px',
|
||||||
|
marginTop: 8,
|
||||||
|
fontSize: 11,
|
||||||
|
fontWeight: 600,
|
||||||
|
textTransform: 'uppercase',
|
||||||
|
letterSpacing: '0.5px',
|
||||||
|
color: 'var(--color-warning, #f59e0b)',
|
||||||
|
borderTop: '1px solid var(--color-border)',
|
||||||
|
}}
|
||||||
|
title="These elements are not attached to the page. Select one to delete it."
|
||||||
|
>
|
||||||
|
Unplaced ({unplacedIds.length})
|
||||||
|
</div>
|
||||||
|
{unplacedIds.map((id) => (
|
||||||
|
<LayerNode key={id} nodeId={id} depth={1} />
|
||||||
|
))}
|
||||||
|
</>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -0,0 +1,234 @@
|
|||||||
|
import React, { useState, useEffect } from 'react';
|
||||||
|
import { createPortal } from 'react-dom';
|
||||||
|
import { Modal } from '../../ui/Modal';
|
||||||
|
import { AssetPicker } from '../../ui/AssetPicker';
|
||||||
|
import { PageData, PageSeo } from '../../types';
|
||||||
|
|
||||||
|
interface PageSettingsModalProps {
|
||||||
|
open: boolean;
|
||||||
|
onClose: () => void;
|
||||||
|
page: PageData | null;
|
||||||
|
updatePageSeo: (pageId: string, seo: Partial<PageSeo>) => void;
|
||||||
|
}
|
||||||
|
|
||||||
|
const EMPTY_SEO: PageSeo = {
|
||||||
|
metaTitle: '',
|
||||||
|
metaDescription: '',
|
||||||
|
ogTitle: '',
|
||||||
|
ogImage: '',
|
||||||
|
twitterCard: 'summary_large_image',
|
||||||
|
noindex: false,
|
||||||
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Per-page SEO/meta settings (PKG-H contract §1/§4). Opened via the gear
|
||||||
|
* icon on a page row in PagesPanel. Fields map 1:1 onto `PageData.seo`
|
||||||
|
* (`types/index.ts`) and are consumed by `html-export.ts`'s `wrapInDocument`
|
||||||
|
* (Preview) and the backend's `generateCompiledHTML` (published output) --
|
||||||
|
* field names here MUST match the shared contract exactly.
|
||||||
|
*
|
||||||
|
* Follows the HeadCodeModal precedent: portaled to `document.body` (escapes
|
||||||
|
* the topbar/left-panel's own stacking context, same fix HeadCodeModal and
|
||||||
|
* TemplateModal already needed), built on the shared `Modal` shell, edits
|
||||||
|
* commit immediately via `updatePageSeo` (no separate Save step) rather than
|
||||||
|
* buffering to a "Save" button -- consistent with HeadCodeModal's live-edit
|
||||||
|
* pattern for `design.headCode`.
|
||||||
|
*/
|
||||||
|
export const PageSettingsModal: React.FC<PageSettingsModalProps> = ({ open, onClose, page, updatePageSeo }) => {
|
||||||
|
const [seo, setSeo] = useState<PageSeo>(EMPTY_SEO);
|
||||||
|
|
||||||
|
// Re-sync local form state from the target page's stored seo whenever the
|
||||||
|
// modal opens (or the target page changes while open) -- mirrors the
|
||||||
|
// pattern of resetting form-local state on prop identity change rather
|
||||||
|
// than deriving directly from props (dropdowns/checkboxes need editable
|
||||||
|
// local state).
|
||||||
|
useEffect(() => {
|
||||||
|
if (!open) return;
|
||||||
|
setSeo({ ...EMPTY_SEO, ...(page?.seo || {}) });
|
||||||
|
}, [open, page?.id, page?.seo]);
|
||||||
|
|
||||||
|
if (!page) return null;
|
||||||
|
|
||||||
|
const update = (patch: Partial<PageSeo>) => {
|
||||||
|
setSeo((prev) => ({ ...prev, ...patch }));
|
||||||
|
updatePageSeo(page.id, patch);
|
||||||
|
};
|
||||||
|
|
||||||
|
return createPortal(
|
||||||
|
<Modal open={open} onClose={onClose}>
|
||||||
|
<div style={modalStyle} onClick={(e) => e.stopPropagation()}>
|
||||||
|
{/* Header */}
|
||||||
|
<div style={modalHeaderStyle}>
|
||||||
|
<div style={{ display: 'flex', alignItems: 'center', gap: 10 }}>
|
||||||
|
<i className="fa fa-cog" style={{ color: 'var(--color-accent)', fontSize: 16 }} />
|
||||||
|
<div>
|
||||||
|
<div style={{ fontSize: 15, fontWeight: 600, color: 'var(--color-text)' }}>
|
||||||
|
Page Settings — {page.name}
|
||||||
|
</div>
|
||||||
|
<div style={{ fontSize: 11, color: 'var(--color-text-muted)', marginTop: 2 }}>
|
||||||
|
SEO and social-sharing metadata for this page only.
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
<button onClick={onClose} style={closeButtonStyle} aria-label="Close">
|
||||||
|
<i className="fa fa-times" />
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
{/* Body */}
|
||||||
|
<div style={{ padding: 20, flex: 1, overflowY: 'auto', display: 'flex', flexDirection: 'column', gap: 14 }}>
|
||||||
|
<div>
|
||||||
|
<label style={fieldLabelStyle}>Meta Title</label>
|
||||||
|
<input
|
||||||
|
type="text"
|
||||||
|
className="control-input"
|
||||||
|
value={seo.metaTitle || ''}
|
||||||
|
onChange={(e) => update({ metaTitle: e.target.value })}
|
||||||
|
placeholder={page.name}
|
||||||
|
data-testid="page-seo-meta-title"
|
||||||
|
/>
|
||||||
|
<p style={hintStyle}>Overrides the browser tab title. Leave blank to use the page name.</p>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div>
|
||||||
|
<label style={fieldLabelStyle}>Meta Description</label>
|
||||||
|
<textarea
|
||||||
|
className="control-input"
|
||||||
|
value={seo.metaDescription || ''}
|
||||||
|
onChange={(e) => update({ metaDescription: e.target.value })}
|
||||||
|
placeholder="A short summary shown in search results and link previews..."
|
||||||
|
rows={3}
|
||||||
|
style={{ resize: 'vertical' as const }}
|
||||||
|
data-testid="page-seo-meta-description"
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div>
|
||||||
|
<label style={fieldLabelStyle}>Social Share Title (og:title)</label>
|
||||||
|
<input
|
||||||
|
type="text"
|
||||||
|
className="control-input"
|
||||||
|
value={seo.ogTitle || ''}
|
||||||
|
onChange={(e) => update({ ogTitle: e.target.value })}
|
||||||
|
placeholder={seo.metaTitle || page.name}
|
||||||
|
data-testid="page-seo-og-title"
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div>
|
||||||
|
<label style={fieldLabelStyle}>Social Share Image (og:image)</label>
|
||||||
|
<AssetPicker
|
||||||
|
value={seo.ogImage || ''}
|
||||||
|
onChange={(url) => update({ ogImage: url })}
|
||||||
|
mediaType="image"
|
||||||
|
variant="full"
|
||||||
|
placeholder="Or paste image URL..."
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div>
|
||||||
|
<label style={fieldLabelStyle}>Twitter Card Type</label>
|
||||||
|
<select
|
||||||
|
className="control-select"
|
||||||
|
value={seo.twitterCard || 'summary_large_image'}
|
||||||
|
onChange={(e) => update({ twitterCard: e.target.value as PageSeo['twitterCard'] })}
|
||||||
|
data-testid="page-seo-twitter-card"
|
||||||
|
>
|
||||||
|
<option value="summary">Summary</option>
|
||||||
|
<option value="summary_large_image">Summary with Large Image</option>
|
||||||
|
</select>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<label style={{ display: 'flex', alignItems: 'center', gap: 8, fontSize: 12, color: 'var(--color-text)', cursor: 'pointer' }}>
|
||||||
|
<input
|
||||||
|
type="checkbox"
|
||||||
|
checked={!!seo.noindex}
|
||||||
|
onChange={(e) => update({ noindex: e.target.checked })}
|
||||||
|
data-testid="page-seo-noindex"
|
||||||
|
/>
|
||||||
|
Hide this page from search engines (noindex)
|
||||||
|
</label>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
{/* Footer */}
|
||||||
|
<div style={{
|
||||||
|
padding: '12px 20px',
|
||||||
|
borderTop: '1px solid var(--color-border)',
|
||||||
|
display: 'flex',
|
||||||
|
justifyContent: 'flex-end',
|
||||||
|
gap: 8,
|
||||||
|
}}>
|
||||||
|
<button onClick={onClose} style={doneButtonStyle}>
|
||||||
|
Done
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
</Modal>,
|
||||||
|
document.body,
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
/* ---------- Styles ---------- */
|
||||||
|
|
||||||
|
const modalStyle: React.CSSProperties = {
|
||||||
|
width: '90vw',
|
||||||
|
maxWidth: 560,
|
||||||
|
maxHeight: '85vh',
|
||||||
|
backgroundColor: 'var(--color-bg-surface)',
|
||||||
|
borderRadius: 12,
|
||||||
|
border: '1px solid var(--color-border)',
|
||||||
|
display: 'flex',
|
||||||
|
flexDirection: 'column',
|
||||||
|
overflow: 'hidden',
|
||||||
|
boxShadow: '0 20px 60px rgba(0,0,0,0.5)',
|
||||||
|
};
|
||||||
|
|
||||||
|
const modalHeaderStyle: React.CSSProperties = {
|
||||||
|
display: 'flex',
|
||||||
|
alignItems: 'center',
|
||||||
|
justifyContent: 'space-between',
|
||||||
|
padding: '16px 20px',
|
||||||
|
borderBottom: '1px solid var(--color-border)',
|
||||||
|
flexShrink: 0,
|
||||||
|
};
|
||||||
|
|
||||||
|
const closeButtonStyle: React.CSSProperties = {
|
||||||
|
width: 32,
|
||||||
|
height: 32,
|
||||||
|
display: 'inline-flex',
|
||||||
|
alignItems: 'center',
|
||||||
|
justifyContent: 'center',
|
||||||
|
background: 'none',
|
||||||
|
border: '1px solid var(--color-border)',
|
||||||
|
borderRadius: 6,
|
||||||
|
color: 'var(--color-text-muted)',
|
||||||
|
cursor: 'pointer',
|
||||||
|
fontSize: 14,
|
||||||
|
};
|
||||||
|
|
||||||
|
const doneButtonStyle: React.CSSProperties = {
|
||||||
|
padding: '8px 24px',
|
||||||
|
fontSize: 13,
|
||||||
|
fontWeight: 600,
|
||||||
|
background: 'var(--color-accent)',
|
||||||
|
color: '#fff',
|
||||||
|
border: 'none',
|
||||||
|
borderRadius: 6,
|
||||||
|
cursor: 'pointer',
|
||||||
|
};
|
||||||
|
|
||||||
|
const fieldLabelStyle: React.CSSProperties = {
|
||||||
|
display: 'block',
|
||||||
|
fontSize: 11,
|
||||||
|
fontWeight: 600,
|
||||||
|
color: 'var(--color-text-muted)',
|
||||||
|
marginBottom: 6,
|
||||||
|
textTransform: 'uppercase',
|
||||||
|
letterSpacing: '0.3px',
|
||||||
|
};
|
||||||
|
|
||||||
|
const hintStyle: React.CSSProperties = {
|
||||||
|
fontSize: 10,
|
||||||
|
color: 'var(--color-text-dim)',
|
||||||
|
margin: '4px 0 0',
|
||||||
|
};
|
||||||
@@ -0,0 +1,119 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { renderEditorHarness } from '../../test-utils/editorHarness';
|
||||||
|
import { PageProvider, usePages } from '../../state/PageContext';
|
||||||
|
import { PagesPanel } from './PagesPanel';
|
||||||
|
|
||||||
|
function clickByLabel(container: HTMLElement, label: string): HTMLButtonElement {
|
||||||
|
const btn = container.querySelector(`[aria-label="${label}"]`) as HTMLButtonElement | null;
|
||||||
|
if (!btn) throw new Error(`No button found with aria-label "${label}"`);
|
||||||
|
return btn;
|
||||||
|
}
|
||||||
|
|
||||||
|
function clickByText(container: HTMLElement, text: string): HTMLButtonElement {
|
||||||
|
const btn = Array.from(container.querySelectorAll('button')).find(
|
||||||
|
(b) => b.textContent === text,
|
||||||
|
) as HTMLButtonElement | undefined;
|
||||||
|
if (!btn) throw new Error(`No button found with text "${text}"`);
|
||||||
|
return btn;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* I3 (review): `deleteConfirmId`, `resetConfirmId` and `editingId` are three
|
||||||
|
* independent bits of local state, but the row rendering treats them as
|
||||||
|
* mutually exclusive (edit -> delete -> reset -> normal, first match wins).
|
||||||
|
* Before this fix, none of the three setters cleared the other two, so if
|
||||||
|
* both `resetConfirmId` and `deleteConfirmId` were ever set to the same page
|
||||||
|
* id, the delete-confirm view would win (it's checked first) and cancelling
|
||||||
|
* it would fall through to reveal the reset-confirm view "unbidden" -- a
|
||||||
|
* destructive prompt the user never asked for.
|
||||||
|
*
|
||||||
|
* This is reachable any time two arm-clicks land in the same render pass
|
||||||
|
* (e.g. a fast double click / synthetic dual dispatch before React commits
|
||||||
|
* the first click's re-render) -- reproduced below by issuing both clicks
|
||||||
|
* inside a single `act()` batch, which is exactly what removes the re-render
|
||||||
|
* that would otherwise make the second button disappear before it can be
|
||||||
|
* clicked.
|
||||||
|
*/
|
||||||
|
describe('PagesPanel confirmation-state isolation (I3 review finding)', () => {
|
||||||
|
async function setupTwoPages() {
|
||||||
|
let ctx: ReturnType<typeof usePages> | null = null;
|
||||||
|
const Probe: React.FC = () => { ctx = usePages(); return null; };
|
||||||
|
const harness = renderEditorHarness();
|
||||||
|
harness.mountChild(
|
||||||
|
<PageProvider>
|
||||||
|
<Probe />
|
||||||
|
<PagesPanel />
|
||||||
|
</PageProvider>,
|
||||||
|
);
|
||||||
|
harness.act(() => { ctx!.addPage('About', 'about'); });
|
||||||
|
await harness.act(async () => { await new Promise((resolve) => setTimeout(resolve, 10)); });
|
||||||
|
return harness;
|
||||||
|
}
|
||||||
|
|
||||||
|
test('arming Reset then Delete for the same page in one batch shows Delete (render precedence), and cancelling Delete does NOT reveal a leftover Reset prompt', async () => {
|
||||||
|
const harness = await setupTwoPages();
|
||||||
|
|
||||||
|
// Both arm-clicks land before any re-render commits.
|
||||||
|
harness.act(() => {
|
||||||
|
clickByLabel(harness.container, 'Reset About to blank').click();
|
||||||
|
clickByLabel(harness.container, 'Delete About').click();
|
||||||
|
});
|
||||||
|
expect(harness.container.textContent).toContain('Delete "About"?');
|
||||||
|
expect(harness.container.textContent).not.toContain('Clear every element from "About"?');
|
||||||
|
|
||||||
|
harness.act(() => {
|
||||||
|
clickByText(harness.container, 'Cancel').click();
|
||||||
|
});
|
||||||
|
|
||||||
|
// The fix: arming Delete clears any pending Reset confirmation for the
|
||||||
|
// same page, so cancelling Delete returns to the normal row, not a
|
||||||
|
// surprise Reset prompt.
|
||||||
|
expect(harness.container.textContent).not.toContain('Clear every element from "About"?');
|
||||||
|
expect(harness.container.textContent).not.toContain('Delete "About"?');
|
||||||
|
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('arming Delete then Reset for the same page in one batch shows Reset, and cancelling Reset does NOT reveal a leftover Delete prompt', async () => {
|
||||||
|
const harness = await setupTwoPages();
|
||||||
|
|
||||||
|
harness.act(() => {
|
||||||
|
clickByLabel(harness.container, 'Delete About').click();
|
||||||
|
clickByLabel(harness.container, 'Reset About to blank').click();
|
||||||
|
});
|
||||||
|
expect(harness.container.textContent).toContain('Clear every element from "About"?');
|
||||||
|
|
||||||
|
harness.act(() => {
|
||||||
|
clickByText(harness.container, 'Cancel').click();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(harness.container.textContent).not.toContain('Delete "About"?');
|
||||||
|
expect(harness.container.textContent).not.toContain('Clear every element from "About"?');
|
||||||
|
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('starting a Rename while a Reset confirmation is pending for the same page clears the pending Reset', async () => {
|
||||||
|
const harness = await setupTwoPages();
|
||||||
|
|
||||||
|
// Arm Reset, then (same batch) start editing the same row -- edit wins
|
||||||
|
// in render precedence, but the fix also clears resetConfirmId so
|
||||||
|
// cancelling the rename doesn't fall through to a stale Reset prompt.
|
||||||
|
harness.act(() => {
|
||||||
|
clickByLabel(harness.container, 'Reset About to blank').click();
|
||||||
|
clickByLabel(harness.container, 'Rename About').click();
|
||||||
|
});
|
||||||
|
const nameInput = harness.container.querySelector('input.control-input') as HTMLInputElement | null;
|
||||||
|
expect(nameInput).toBeTruthy();
|
||||||
|
expect(nameInput!.value).toBe('About');
|
||||||
|
|
||||||
|
harness.act(() => {
|
||||||
|
clickByText(harness.container, 'Cancel').click();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(harness.container.textContent).not.toContain('Clear every element from "About"?');
|
||||||
|
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,195 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { renderEditorHarness } from '../../test-utils/editorHarness';
|
||||||
|
import { EMPTY_CANVAS, PageProvider, usePages } from '../../state/PageContext';
|
||||||
|
import { PagesPanel } from './PagesPanel';
|
||||||
|
|
||||||
|
const withHeading = JSON.stringify({
|
||||||
|
ROOT: {
|
||||||
|
type: { resolvedName: 'Container' }, isCanvas: true,
|
||||||
|
props: { style: {}, tag: 'div' }, displayName: 'Container',
|
||||||
|
custom: {}, hidden: false, nodes: ['h1'], linkedNodes: {}, parent: null,
|
||||||
|
},
|
||||||
|
h1: {
|
||||||
|
type: { resolvedName: 'Heading' }, isCanvas: false,
|
||||||
|
props: { text: 'Keep me', level: 2 }, displayName: 'Heading',
|
||||||
|
custom: {}, hidden: false, nodes: [], linkedNodes: {}, parent: 'ROOT',
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
/** Same real-timer-flush pattern as `PageContext.orphan-repair-wiring.test.tsx`
|
||||||
|
* -- `PageContext.loadState`/this feature's own reset handler both schedule
|
||||||
|
* their `actions.deserialize()` calls via `setTimeout(..., 0)` rather than
|
||||||
|
* applying them synchronously, so tests that exercise either path need to
|
||||||
|
* let a real macrotask turn run before asserting on the live Frame. */
|
||||||
|
async function flushTimers(harness: ReturnType<typeof renderEditorHarness>): Promise<void> {
|
||||||
|
await harness.act(async () => {
|
||||||
|
await new Promise((resolve) => setTimeout(resolve, 10));
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function clickByLabel(container: HTMLElement, label: string): HTMLButtonElement {
|
||||||
|
const btn = container.querySelector(`[aria-label="${label}"]`) as HTMLButtonElement | null;
|
||||||
|
if (!btn) throw new Error(`No button found with aria-label "${label}"`);
|
||||||
|
return btn;
|
||||||
|
}
|
||||||
|
|
||||||
|
function clickByText(container: HTMLElement, text: string): HTMLButtonElement {
|
||||||
|
const btn = Array.from(container.querySelectorAll('button')).find(
|
||||||
|
(b) => b.textContent === text,
|
||||||
|
) as HTMLButtonElement | undefined;
|
||||||
|
if (!btn) throw new Error(`No button found with text "${text}"`);
|
||||||
|
return btn;
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('resetting a page to EMPTY_CANVAS (Craft.js characterisation)', () => {
|
||||||
|
test('clears the canvas', () => {
|
||||||
|
const harness = renderEditorHarness({ initialState: withHeading });
|
||||||
|
expect(JSON.parse(harness.getSerialized()).ROOT.nodes).toEqual(['h1']);
|
||||||
|
|
||||||
|
harness.act(() => { harness.actions.deserialize(EMPTY_CANVAS); });
|
||||||
|
expect(JSON.parse(harness.getSerialized()).ROOT.nodes).toEqual([]);
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the reset is undoable through Craft history', () => {
|
||||||
|
const harness = renderEditorHarness({ initialState: withHeading });
|
||||||
|
harness.act(() => { harness.actions.deserialize(EMPTY_CANVAS); });
|
||||||
|
harness.act(() => { harness.actions.history.undo(); });
|
||||||
|
expect(JSON.parse(harness.getSerialized()).ROOT.nodes).toEqual(['h1']);
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('PagesPanel Reset Page control', () => {
|
||||||
|
test('a Reset button is rendered for every page row, and the dialog names the page', () => {
|
||||||
|
const harness = renderEditorHarness();
|
||||||
|
harness.mountChild(
|
||||||
|
<PageProvider>
|
||||||
|
<PagesPanel />
|
||||||
|
</PageProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
// Fresh PageProvider starts with exactly one page: "Home".
|
||||||
|
const erasers = harness.container.querySelectorAll('.fa-eraser');
|
||||||
|
expect(erasers.length).toBe(1);
|
||||||
|
expect(clickByLabel(harness.container, 'Reset Home to blank')).toBeTruthy();
|
||||||
|
|
||||||
|
harness.act(() => {
|
||||||
|
clickByLabel(harness.container, 'Reset Home to blank').click();
|
||||||
|
});
|
||||||
|
expect(harness.container.textContent).toContain('Clear every element from "Home"?');
|
||||||
|
expect(harness.container.textContent).toContain('Ctrl+Z undoes this.');
|
||||||
|
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the Header and Footer zone rows never grow a Reset control', () => {
|
||||||
|
const harness = renderEditorHarness();
|
||||||
|
harness.mountChild(
|
||||||
|
<PageProvider>
|
||||||
|
<PagesPanel />
|
||||||
|
</PageProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
const zoneRows = harness.container.querySelectorAll('.zone-row');
|
||||||
|
expect(zoneRows.length).toBe(2); // Header, Footer
|
||||||
|
zoneRows.forEach((row) => {
|
||||||
|
expect(row.querySelector('.fa-eraser')).toBeNull();
|
||||||
|
});
|
||||||
|
// No aria-label anywhere in the panel offers to reset the header/footer.
|
||||||
|
expect(harness.container.querySelector('[aria-label="Reset Header to blank"]')).toBeNull();
|
||||||
|
expect(harness.container.querySelector('[aria-label="Reset Footer to blank"]')).toBeNull();
|
||||||
|
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('clicking Reset then Cancel leaves the active page untouched', () => {
|
||||||
|
const harness = renderEditorHarness({ initialState: withHeading });
|
||||||
|
harness.mountChild(
|
||||||
|
<PageProvider>
|
||||||
|
<PagesPanel />
|
||||||
|
</PageProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
harness.act(() => {
|
||||||
|
clickByLabel(harness.container, 'Reset Home to blank').click();
|
||||||
|
});
|
||||||
|
harness.act(() => {
|
||||||
|
clickByText(harness.container, 'Cancel').click();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(JSON.parse(harness.getSerialized()).ROOT.nodes).toEqual(['h1']);
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('clicking Reset then confirming blanks the ACTIVE page', async () => {
|
||||||
|
const harness = renderEditorHarness({ initialState: withHeading });
|
||||||
|
harness.mountChild(
|
||||||
|
<PageProvider>
|
||||||
|
<PagesPanel />
|
||||||
|
</PageProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
harness.act(() => {
|
||||||
|
clickByLabel(harness.container, 'Reset Home to blank').click();
|
||||||
|
});
|
||||||
|
harness.act(() => {
|
||||||
|
clickByText(harness.container, 'Reset page').click();
|
||||||
|
});
|
||||||
|
await flushTimers(harness);
|
||||||
|
|
||||||
|
expect(JSON.parse(harness.getSerialized()).ROOT.nodes).toEqual([]);
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('resetting a page that is NOT on screen switches to it first, then blanks it -- ' +
|
||||||
|
'the switch-in load must resolve BEFORE the blank, or the blank would just get ' +
|
||||||
|
'overwritten by the page\'s real content', async () => {
|
||||||
|
let ctx: ReturnType<typeof usePages> | null = null;
|
||||||
|
const Probe: React.FC = () => {
|
||||||
|
ctx = usePages();
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
|
const harness = renderEditorHarness({ initialState: withHeading });
|
||||||
|
harness.mountChild(
|
||||||
|
<PageProvider>
|
||||||
|
<Probe />
|
||||||
|
<PagesPanel />
|
||||||
|
</PageProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
// addPage() saves the live Frame (withHeading) into Home's slot, adds
|
||||||
|
// "About", and switches the live Frame to About's (empty) canvas.
|
||||||
|
harness.act(() => { ctx!.addPage('About', 'about'); });
|
||||||
|
await flushTimers(harness);
|
||||||
|
expect(ctx!.activePageId).not.toBe('home');
|
||||||
|
expect(JSON.parse(harness.getSerialized()).ROOT.nodes).toEqual([]); // About is blank
|
||||||
|
|
||||||
|
// Now reset Home while About is the active/on-screen page.
|
||||||
|
harness.act(() => {
|
||||||
|
clickByLabel(harness.container, 'Reset Home to blank').click();
|
||||||
|
});
|
||||||
|
harness.act(() => {
|
||||||
|
clickByText(harness.container, 'Reset page').click();
|
||||||
|
});
|
||||||
|
await flushTimers(harness);
|
||||||
|
|
||||||
|
// The live Frame now shows Home (switchPage ran) and it's blank (reset ran
|
||||||
|
// after the switch-in load, not before it).
|
||||||
|
expect(ctx!.activePageId).toBe('home');
|
||||||
|
expect(JSON.parse(harness.getSerialized()).ROOT.nodes).toEqual([]);
|
||||||
|
|
||||||
|
// And the blank state actually persisted into Home's stored slot, not
|
||||||
|
// just transiently on the Frame: switch away and back, still blank.
|
||||||
|
const aboutId = ctx!.pages.find((p) => p.id !== 'home')!.id;
|
||||||
|
harness.act(() => { ctx!.switchPage(aboutId); });
|
||||||
|
await flushTimers(harness);
|
||||||
|
harness.act(() => { ctx!.switchPage('home'); });
|
||||||
|
await flushTimers(harness);
|
||||||
|
expect(JSON.parse(harness.getSerialized()).ROOT.nodes).toEqual([]);
|
||||||
|
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -1,6 +1,8 @@
|
|||||||
import React, { useState } from 'react';
|
import React, { useState } from 'react';
|
||||||
import { usePages } from '../../state/PageContext';
|
import { useEditor } from '@craftjs/core';
|
||||||
|
import { usePages, EMPTY_CANVAS } from '../../state/PageContext';
|
||||||
import { clickableProps } from '../../utils/a11y';
|
import { clickableProps } from '../../utils/a11y';
|
||||||
|
import { PageSettingsModal } from './PageSettingsModal';
|
||||||
|
|
||||||
export const PagesPanel: React.FC = () => {
|
export const PagesPanel: React.FC = () => {
|
||||||
const {
|
const {
|
||||||
@@ -14,7 +16,12 @@ export const PagesPanel: React.FC = () => {
|
|||||||
addPage,
|
addPage,
|
||||||
deletePage,
|
deletePage,
|
||||||
renamePage,
|
renamePage,
|
||||||
|
duplicatePage,
|
||||||
|
movePage,
|
||||||
|
setLandingPage,
|
||||||
|
updatePageSeo,
|
||||||
} = usePages();
|
} = usePages();
|
||||||
|
const { actions: editorActions } = useEditor();
|
||||||
const [isAdding, setIsAdding] = useState(false);
|
const [isAdding, setIsAdding] = useState(false);
|
||||||
const [newName, setNewName] = useState('');
|
const [newName, setNewName] = useState('');
|
||||||
const [newSlug, setNewSlug] = useState('');
|
const [newSlug, setNewSlug] = useState('');
|
||||||
@@ -22,6 +29,9 @@ export const PagesPanel: React.FC = () => {
|
|||||||
const [editName, setEditName] = useState('');
|
const [editName, setEditName] = useState('');
|
||||||
const [editSlug, setEditSlug] = useState('');
|
const [editSlug, setEditSlug] = useState('');
|
||||||
const [deleteConfirmId, setDeleteConfirmId] = useState<string | null>(null);
|
const [deleteConfirmId, setDeleteConfirmId] = useState<string | null>(null);
|
||||||
|
const [resetConfirmId, setResetConfirmId] = useState<string | null>(null);
|
||||||
|
const [seoSettingsPageId, setSeoSettingsPageId] = useState<string | null>(null);
|
||||||
|
const seoSettingsPage = pages.find((p) => p.id === seoSettingsPageId) || null;
|
||||||
|
|
||||||
const handleAdd = () => {
|
const handleAdd = () => {
|
||||||
if (!newName.trim()) return;
|
if (!newName.trim()) return;
|
||||||
@@ -42,11 +52,32 @@ export const PagesPanel: React.FC = () => {
|
|||||||
setDeleteConfirmId(null);
|
setDeleteConfirmId(null);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Blanks `pageId`'s canvas to `EMPTY_CANVAS`. `actions.deserialize()` acts
|
||||||
|
* on the LIVE `<Frame>`, so resetting a page that isn't currently on
|
||||||
|
* screen requires switching to it first. `switchPage` itself defers its
|
||||||
|
* own `actions.deserialize(targetState)` via `setTimeout(..., 0)` (see
|
||||||
|
* `PageContext.loadState`) rather than applying it synchronously -- so the
|
||||||
|
* blanking `setTimeout` scheduled here must run AFTER that one, or it
|
||||||
|
* would blank the frame and then have `switchPage`'s own deferred load
|
||||||
|
* immediately overwrite the blank with the target page's real content.
|
||||||
|
* Since `switchPage(pageId)` runs synchronously above (registering its
|
||||||
|
* internal setTimeout first) before this function schedules its own,
|
||||||
|
* same-delay `setTimeout` callbacks fire in registration order -- the
|
||||||
|
* switch's load always resolves before this reset does.
|
||||||
|
*/
|
||||||
|
const handleResetPage = (pageId: string): void => {
|
||||||
|
if (pageId !== activePageId) switchPage(pageId);
|
||||||
|
setTimeout(() => editorActions.deserialize(EMPTY_CANVAS), 0);
|
||||||
|
setResetConfirmId(null);
|
||||||
|
};
|
||||||
|
|
||||||
const startEditing = (page: { id: string; name: string; slug: string }) => {
|
const startEditing = (page: { id: string; name: string; slug: string }) => {
|
||||||
setEditingId(page.id);
|
setEditingId(page.id);
|
||||||
setEditName(page.name);
|
setEditName(page.name);
|
||||||
setEditSlug(page.slug);
|
setEditSlug(page.slug);
|
||||||
setDeleteConfirmId(null);
|
setDeleteConfirmId(null);
|
||||||
|
setResetConfirmId(null);
|
||||||
};
|
};
|
||||||
|
|
||||||
const autoSlug = (name: string): string => {
|
const autoSlug = (name: string): string => {
|
||||||
@@ -64,6 +95,33 @@ export const PagesPanel: React.FC = () => {
|
|||||||
* differently-colored category. The active/editing state reuses the same
|
* differently-colored category. The active/editing state reuses the same
|
||||||
* accent-outline treatment the page list already uses for the active page,
|
* accent-outline treatment the page list already uses for the active page,
|
||||||
* so there's one consistent "this is what's currently open" affordance. */
|
* so there's one consistent "this is what's currently open" affordance. */
|
||||||
|
/* ---------- Per-page-row icon button ----------
|
||||||
|
* Shared 24x24 icon-button styling used by every action in the page row
|
||||||
|
* (SEO settings, rename, duplicate, reorder, set-as-home, delete) so a new
|
||||||
|
* action slots in looking identical to the pre-existing gear/pencil/trash
|
||||||
|
* buttons -- same dark-theme neutral treatment, `disabled` dims the icon
|
||||||
|
* (matching how `disabled` already reads elsewhere in this panel, e.g. the
|
||||||
|
* "Add Page" button), and `danger` reuses the existing delete-button
|
||||||
|
* accent color. */
|
||||||
|
const pageActionBtnStyle = (opts: { disabled?: boolean; danger?: boolean } = {}): React.CSSProperties => ({
|
||||||
|
width: 24,
|
||||||
|
height: 24,
|
||||||
|
display: 'inline-flex',
|
||||||
|
alignItems: 'center',
|
||||||
|
justifyContent: 'center',
|
||||||
|
fontSize: 11,
|
||||||
|
color: opts.disabled
|
||||||
|
? 'var(--color-text-dim)'
|
||||||
|
: opts.danger
|
||||||
|
? 'var(--color-danger)'
|
||||||
|
: 'var(--color-text-muted)',
|
||||||
|
background: 'transparent',
|
||||||
|
border: 'none',
|
||||||
|
borderRadius: 'var(--radius-sm)',
|
||||||
|
cursor: opts.disabled ? 'default' : 'pointer',
|
||||||
|
opacity: opts.disabled ? 0.5 : 1,
|
||||||
|
});
|
||||||
|
|
||||||
const zoneRowStyle = (isActive: boolean): React.CSSProperties => ({
|
const zoneRowStyle = (isActive: boolean): React.CSSProperties => ({
|
||||||
display: 'flex',
|
display: 'flex',
|
||||||
alignItems: 'center',
|
alignItems: 'center',
|
||||||
@@ -267,6 +325,60 @@ export const PagesPanel: React.FC = () => {
|
|||||||
</button>
|
</button>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
) : resetConfirmId === page.id ? (
|
||||||
|
/* Reset-to-blank confirmation -- mirrors the delete confirmation
|
||||||
|
* above, since both are destructive per-page actions. */
|
||||||
|
<div
|
||||||
|
style={{
|
||||||
|
padding: 10,
|
||||||
|
background: 'var(--color-bg-elevated)',
|
||||||
|
borderRadius: 'var(--radius-md)',
|
||||||
|
border: '1px solid var(--color-danger)',
|
||||||
|
display: 'flex',
|
||||||
|
flexDirection: 'column',
|
||||||
|
gap: 8,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<div style={{ fontSize: 12, color: 'var(--color-text)' }}>
|
||||||
|
Clear every element from "{page.name}"? Your header, footer and other
|
||||||
|
pages are untouched, and the published site doesn't change until you
|
||||||
|
publish again. Ctrl+Z undoes this.
|
||||||
|
</div>
|
||||||
|
<div style={{ display: 'flex', gap: 6 }}>
|
||||||
|
<button
|
||||||
|
onClick={() => handleResetPage(page.id)}
|
||||||
|
style={{
|
||||||
|
flex: 1,
|
||||||
|
padding: '5px 10px',
|
||||||
|
fontSize: 11,
|
||||||
|
fontWeight: 600,
|
||||||
|
color: '#fff',
|
||||||
|
background: 'var(--color-danger)',
|
||||||
|
border: 'none',
|
||||||
|
borderRadius: 'var(--radius-sm)',
|
||||||
|
cursor: 'pointer',
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Reset page
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
onClick={() => setResetConfirmId(null)}
|
||||||
|
style={{
|
||||||
|
flex: 1,
|
||||||
|
padding: '5px 10px',
|
||||||
|
fontSize: 11,
|
||||||
|
fontWeight: 600,
|
||||||
|
color: 'var(--color-text-muted)',
|
||||||
|
background: 'var(--color-bg-base)',
|
||||||
|
border: '1px solid var(--color-border)',
|
||||||
|
borderRadius: 'var(--radius-sm)',
|
||||||
|
cursor: 'pointer',
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Cancel
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
) : (
|
) : (
|
||||||
/* Normal page item */
|
/* Normal page item */
|
||||||
<div
|
<div
|
||||||
@@ -340,47 +452,89 @@ export const PagesPanel: React.FC = () => {
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
<div
|
<div
|
||||||
style={{ display: 'flex', gap: 4, flexShrink: 0 }}
|
style={{ display: 'flex', gap: 2, flexShrink: 0, flexWrap: 'wrap', justifyContent: 'flex-end', maxWidth: 96 }}
|
||||||
onClick={(e) => e.stopPropagation()}
|
onClick={(e) => e.stopPropagation()}
|
||||||
>
|
>
|
||||||
|
<button
|
||||||
|
onClick={() => movePage(page.id, 'up')}
|
||||||
|
disabled={pageIndex === 0}
|
||||||
|
data-tooltip="Move up"
|
||||||
|
aria-label={`Move ${page.name} up`}
|
||||||
|
style={pageActionBtnStyle({ disabled: pageIndex === 0 })}
|
||||||
|
>
|
||||||
|
<i className="fa fa-arrow-up" aria-hidden="true" />
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
onClick={() => movePage(page.id, 'down')}
|
||||||
|
disabled={pageIndex === pages.length - 1}
|
||||||
|
data-tooltip="Move down"
|
||||||
|
aria-label={`Move ${page.name} down`}
|
||||||
|
style={pageActionBtnStyle({ disabled: pageIndex === pages.length - 1 })}
|
||||||
|
>
|
||||||
|
<i className="fa fa-arrow-down" aria-hidden="true" />
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
onClick={() => duplicatePage(page.id)}
|
||||||
|
data-tooltip="Duplicate"
|
||||||
|
aria-label={`Duplicate ${page.name}`}
|
||||||
|
style={pageActionBtnStyle()}
|
||||||
|
>
|
||||||
|
<i className="fa fa-clone" aria-hidden="true" />
|
||||||
|
</button>
|
||||||
|
{isLanding ? (
|
||||||
|
<span
|
||||||
|
data-tooltip="This is the home page"
|
||||||
|
aria-label={`${page.name} is the home page`}
|
||||||
|
style={pageActionBtnStyle({ disabled: true })}
|
||||||
|
>
|
||||||
|
<i className="fa fa-home" aria-hidden="true" />
|
||||||
|
</span>
|
||||||
|
) : (
|
||||||
|
<button
|
||||||
|
onClick={() => setLandingPage(page.id)}
|
||||||
|
data-tooltip="Set as home page"
|
||||||
|
aria-label={`Set ${page.name} as the home page`}
|
||||||
|
style={pageActionBtnStyle()}
|
||||||
|
>
|
||||||
|
<i className="fa fa-home" aria-hidden="true" />
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
<button
|
||||||
|
onClick={() => setSeoSettingsPageId(page.id)}
|
||||||
|
data-tooltip="Page Settings (SEO)"
|
||||||
|
aria-label={`Page settings for ${page.name}`}
|
||||||
|
style={pageActionBtnStyle()}
|
||||||
|
>
|
||||||
|
<i className="fa fa-cog" aria-hidden="true" />
|
||||||
|
</button>
|
||||||
<button
|
<button
|
||||||
onClick={() => startEditing(page)}
|
onClick={() => startEditing(page)}
|
||||||
data-tooltip="Rename"
|
data-tooltip="Rename"
|
||||||
aria-label={`Rename ${page.name}`}
|
aria-label={`Rename ${page.name}`}
|
||||||
style={{
|
style={pageActionBtnStyle()}
|
||||||
width: 24,
|
|
||||||
height: 24,
|
|
||||||
display: 'inline-flex',
|
|
||||||
alignItems: 'center',
|
|
||||||
justifyContent: 'center',
|
|
||||||
fontSize: 11,
|
|
||||||
color: 'var(--color-text-muted)',
|
|
||||||
background: 'transparent',
|
|
||||||
border: 'none',
|
|
||||||
borderRadius: 'var(--radius-sm)',
|
|
||||||
cursor: 'pointer',
|
|
||||||
}}
|
|
||||||
>
|
>
|
||||||
<i className="fa fa-pencil" aria-hidden="true" />
|
<i className="fa fa-pencil" aria-hidden="true" />
|
||||||
</button>
|
</button>
|
||||||
|
<button
|
||||||
|
onClick={() => {
|
||||||
|
setResetConfirmId(page.id);
|
||||||
|
setDeleteConfirmId(null);
|
||||||
|
}}
|
||||||
|
data-tooltip="Reset to blank"
|
||||||
|
aria-label={`Reset ${page.name} to blank`}
|
||||||
|
style={pageActionBtnStyle({ danger: true })}
|
||||||
|
>
|
||||||
|
<i className="fa fa-eraser" aria-hidden="true" />
|
||||||
|
</button>
|
||||||
{pages.length > 1 && !isLanding && (
|
{pages.length > 1 && !isLanding && (
|
||||||
<button
|
<button
|
||||||
onClick={() => setDeleteConfirmId(page.id)}
|
onClick={() => {
|
||||||
|
setDeleteConfirmId(page.id);
|
||||||
|
setResetConfirmId(null);
|
||||||
|
}}
|
||||||
data-tooltip="Delete"
|
data-tooltip="Delete"
|
||||||
aria-label={`Delete ${page.name}`}
|
aria-label={`Delete ${page.name}`}
|
||||||
style={{
|
style={pageActionBtnStyle({ danger: true })}
|
||||||
width: 24,
|
|
||||||
height: 24,
|
|
||||||
display: 'inline-flex',
|
|
||||||
alignItems: 'center',
|
|
||||||
justifyContent: 'center',
|
|
||||||
fontSize: 11,
|
|
||||||
color: 'var(--color-text-muted)',
|
|
||||||
background: 'transparent',
|
|
||||||
border: 'none',
|
|
||||||
borderRadius: 'var(--radius-sm)',
|
|
||||||
cursor: 'pointer',
|
|
||||||
}}
|
|
||||||
>
|
>
|
||||||
<i className="fa fa-trash" aria-hidden="true" />
|
<i className="fa fa-trash" aria-hidden="true" />
|
||||||
</button>
|
</button>
|
||||||
@@ -492,6 +646,13 @@ export const PagesPanel: React.FC = () => {
|
|||||||
+ Add Page
|
+ Add Page
|
||||||
</button>
|
</button>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
|
<PageSettingsModal
|
||||||
|
open={seoSettingsPageId !== null}
|
||||||
|
onClose={() => setSeoSettingsPageId(null)}
|
||||||
|
page={seoSettingsPage}
|
||||||
|
updatePageSeo={updatePageSeo}
|
||||||
|
/>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -0,0 +1,84 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import { deriveVirtualRows, VIRTUAL_CHILD_PROPS } from './layers-virtual-rows';
|
||||||
|
|
||||||
|
describe('deriveVirtualRows', () => {
|
||||||
|
test('returns one row per item, labelled by the registered field', () => {
|
||||||
|
const rows = deriveVirtualRows('Features Grid', {
|
||||||
|
features: [{ title: 'Fast' }, { title: 'Secure' }],
|
||||||
|
});
|
||||||
|
expect(rows).toEqual([
|
||||||
|
{ index: 0, label: 'Fast' },
|
||||||
|
{ index: 1, label: 'Secure' },
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('falls back to "<Fallback> N" when the label field is missing or blank', () => {
|
||||||
|
const rows = deriveVirtualRows('Features Grid', {
|
||||||
|
features: [{ title: '' }, { description: 'no title key' }],
|
||||||
|
});
|
||||||
|
expect(rows).toEqual([
|
||||||
|
{ index: 0, label: 'Feature 1' },
|
||||||
|
{ index: 1, label: 'Feature 2' },
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('trims and truncates a long label to 40 characters with an ellipsis', () => {
|
||||||
|
const long = 'x'.repeat(60);
|
||||||
|
const rows = deriveVirtualRows('Features Grid', { features: [{ title: ` ${long} ` }] });
|
||||||
|
expect(rows[0].label).toHaveLength(41);
|
||||||
|
expect(rows[0].label.endsWith('…')).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('an unregistered component yields no rows', () => {
|
||||||
|
expect(deriveVirtualRows('Heading', { text: 'hi' })).toEqual([]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a missing or non-array prop yields no rows instead of throwing', () => {
|
||||||
|
expect(deriveVirtualRows('Tabs', {})).toEqual([]);
|
||||||
|
expect(deriveVirtualRows('Tabs', { tabs: 'not an array' })).toEqual([]);
|
||||||
|
expect(deriveVirtualRows('Tabs', { tabs: null })).toEqual([]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a non-object item still gets a fallback label', () => {
|
||||||
|
expect(deriveVirtualRows('Menu', { links: ['raw string'] })).toEqual([
|
||||||
|
{ index: 0, label: 'Link 1' },
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('Hero, Call to Action and CTA Section derive rows from their shared ctas prop', () => {
|
||||||
|
const ctas = [
|
||||||
|
{ text: 'Get Started', href: '#', variant: 'primary' },
|
||||||
|
{ text: 'Learn More', href: '#learn', variant: 'outline' },
|
||||||
|
];
|
||||||
|
expect(deriveVirtualRows('Hero', { ctas })).toEqual([
|
||||||
|
{ index: 0, label: 'Get Started' },
|
||||||
|
{ index: 1, label: 'Learn More' },
|
||||||
|
]);
|
||||||
|
expect(deriveVirtualRows('Call to Action', { ctas })).toEqual([
|
||||||
|
{ index: 0, label: 'Get Started' },
|
||||||
|
{ index: 1, label: 'Learn More' },
|
||||||
|
]);
|
||||||
|
expect(deriveVirtualRows('CTA Section', { ctas })).toEqual([
|
||||||
|
{ index: 0, label: 'Get Started' },
|
||||||
|
{ index: 1, label: 'Learn More' },
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a CTA with no text falls back to "Button N"', () => {
|
||||||
|
const rows = deriveVirtualRows('Hero', {
|
||||||
|
ctas: [{ href: '#' }, { text: '', href: '#empty' }],
|
||||||
|
});
|
||||||
|
expect(rows).toEqual([
|
||||||
|
{ index: 0, label: 'Button 1' },
|
||||||
|
{ index: 1, label: 'Button 2' },
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('every registry entry has a non-empty prop, label and fallback', () => {
|
||||||
|
for (const [name, spec] of Object.entries(VIRTUAL_CHILD_PROPS)) {
|
||||||
|
expect(spec.prop, `${name}.prop`).toBeTruthy();
|
||||||
|
expect(spec.label, `${name}.label`).toBeTruthy();
|
||||||
|
expect(spec.fallback, `${name}.fallback`).toBeTruthy();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,87 @@
|
|||||||
|
/**
|
||||||
|
* Virtual Layers rows for components whose content lives in ARRAY PROPS
|
||||||
|
* rather than Craft child nodes.
|
||||||
|
*
|
||||||
|
* FeaturesGrid, Tabs, Accordion, PricingTable, Testimonials, Gallery,
|
||||||
|
* ContentSlider, NumberCounter, Menu, SocialLinks, Navbar and ContactForm all
|
||||||
|
* render their items from a prop array, so Craft sees them as leaf nodes and
|
||||||
|
* the Layers tree showed nothing underneath them -- the "Layers doesn't show
|
||||||
|
* everything" report. These rows are display-only: they are not Craft nodes,
|
||||||
|
* cannot be dragged, and selecting one selects the PARENT node (plus asks the
|
||||||
|
* array editor to scroll that item into view -- see LayerFocusContext).
|
||||||
|
*
|
||||||
|
* ColumnLayout is deliberately absent: it uses real `<Element canvas>`
|
||||||
|
* children, which LayersPanel already nests correctly.
|
||||||
|
*/
|
||||||
|
|
||||||
|
export interface VirtualRow {
|
||||||
|
index: number;
|
||||||
|
label: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface VirtualChildSpec {
|
||||||
|
/** Name of the array prop holding the items. */
|
||||||
|
prop: string;
|
||||||
|
/** Per-item field used as the row label. */
|
||||||
|
label: string;
|
||||||
|
/** Used as "<fallback> <n>" when the label field is missing or blank. */
|
||||||
|
fallback: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Keyed by the component's craft `displayName` -- the same string
|
||||||
|
* `LayerNode` already resolves and shows as the row text.
|
||||||
|
*
|
||||||
|
* Verified against each component's actual item interface and
|
||||||
|
* `craft.props` defaults (see task-9-report.md, Step 1):
|
||||||
|
* - Tabs items are `{ label, content }`, not `{ title }` -- registry
|
||||||
|
* corrected from `title` to `label`.
|
||||||
|
* - ContentSlider items are `{ heading, text, ... }`, not `{ title }` --
|
||||||
|
* registry corrected from `title` to `heading`.
|
||||||
|
* Every other entry (prop name and label field) matched the component as
|
||||||
|
* originally drafted.
|
||||||
|
*
|
||||||
|
* Hero, Call to Action and CTA Section were added after a follow-up sweep
|
||||||
|
* of every component under src/components/ for top-level array props (not
|
||||||
|
* just the 12 files initially listed) turned up three more leaf components
|
||||||
|
* with the identical pattern: all three render a `ctas?: CtaButton[]` prop
|
||||||
|
* (see sections/_cta-helpers.tsx) whose items are `{ text, href, variant?,
|
||||||
|
* target? }`, so `text` is the label field. Verified against each file's
|
||||||
|
* `craft.displayName` and `craft.props.ctas` defaults. That sweep found no
|
||||||
|
* further candidates -- the only other array fields in the tree are nested
|
||||||
|
* one level down inside already-covered items (ContactFormField.options,
|
||||||
|
* PricingPlan.features), not top-level component props. */
|
||||||
|
export const VIRTUAL_CHILD_PROPS: Record<string, VirtualChildSpec> = {
|
||||||
|
'Features Grid': { prop: 'features', label: 'title', fallback: 'Feature' },
|
||||||
|
Tabs: { prop: 'tabs', label: 'label', fallback: 'Tab' },
|
||||||
|
Accordion: { prop: 'items', label: 'title', fallback: 'Item' },
|
||||||
|
'Pricing Table': { prop: 'plans', label: 'name', fallback: 'Plan' },
|
||||||
|
Testimonials: { prop: 'testimonials', label: 'name', fallback: 'Testimonial' },
|
||||||
|
Gallery: { prop: 'images', label: 'alt', fallback: 'Image' },
|
||||||
|
'Content Slider': { prop: 'slides', label: 'heading', fallback: 'Slide' },
|
||||||
|
'Number Counter': { prop: 'counters', label: 'label', fallback: 'Counter' },
|
||||||
|
Menu: { prop: 'links', label: 'text', fallback: 'Link' },
|
||||||
|
'Social Links': { prop: 'links', label: 'platform', fallback: 'Link' },
|
||||||
|
Navbar: { prop: 'links', label: 'text', fallback: 'Link' },
|
||||||
|
'Contact Form': { prop: 'fields', label: 'label', fallback: 'Field' },
|
||||||
|
Hero: { prop: 'ctas', label: 'text', fallback: 'Button' },
|
||||||
|
'Call to Action': { prop: 'ctas', label: 'text', fallback: 'Button' },
|
||||||
|
'CTA Section': { prop: 'ctas', label: 'text', fallback: 'Button' },
|
||||||
|
};
|
||||||
|
|
||||||
|
const MAX_LABEL = 40;
|
||||||
|
|
||||||
|
export function deriveVirtualRows(displayName: string, props: Record<string, any>): VirtualRow[] {
|
||||||
|
const spec = VIRTUAL_CHILD_PROPS[displayName];
|
||||||
|
if (!spec) return [];
|
||||||
|
|
||||||
|
const items = props?.[spec.prop];
|
||||||
|
if (!Array.isArray(items)) return [];
|
||||||
|
|
||||||
|
return items.map((item, index) => {
|
||||||
|
const raw = item && typeof item === 'object' ? item[spec.label] : undefined;
|
||||||
|
const text = typeof raw === 'string' ? raw.trim() : '';
|
||||||
|
if (!text) return { index, label: `${spec.fallback} ${index + 1}` };
|
||||||
|
const label = text.length > MAX_LABEL ? `${text.slice(0, MAX_LABEL)}…` : text;
|
||||||
|
return { index, label };
|
||||||
|
});
|
||||||
|
}
|
||||||
@@ -17,6 +17,7 @@ import {
|
|||||||
PricingStylePanel,
|
PricingStylePanel,
|
||||||
BackgroundSectionStylePanel,
|
BackgroundSectionStylePanel,
|
||||||
GenericPropsEditor,
|
GenericPropsEditor,
|
||||||
|
HtmlStylePanel,
|
||||||
} from './styles';
|
} from './styles';
|
||||||
|
|
||||||
/* ================================================================
|
/* ================================================================
|
||||||
@@ -75,8 +76,10 @@ export const GuidedStyles: React.FC = () => {
|
|||||||
const isSocial = /^social links$|^icon$|^star rating$/i.test(typeName);
|
const isSocial = /^social links$|^icon$|^star rating$/i.test(typeName);
|
||||||
const isPricing = /^pricing/i.test(typeName);
|
const isPricing = /^pricing/i.test(typeName);
|
||||||
const isSection = /^accordion$|^tabs$|^testimonial|^countdown$|^number counter$|^cta section$|^call to action$|^features grid$/i.test(typeName);
|
const isSection = /^accordion$|^tabs$|^testimonial|^countdown$|^number counter$|^cta section$|^call to action$|^features grid$/i.test(typeName);
|
||||||
// Utility types that need minimal controls
|
const isHtml = /^html$/i.test(typeName);
|
||||||
const isUtility = /^divider$|^spacer$|^html$/i.test(typeName);
|
// Utility types that need minimal controls. HTML is deliberately NOT here
|
||||||
|
// -- it gets HtmlStylePanel, which shows the code editor and nothing else.
|
||||||
|
const isUtility = /^divider$|^spacer$/i.test(typeName);
|
||||||
|
|
||||||
// Icon for the type badge
|
// Icon for the type badge
|
||||||
const typeIcon = isText ? 'fa-font'
|
const typeIcon = isText ? 'fa-font'
|
||||||
@@ -90,6 +93,7 @@ export const GuidedStyles: React.FC = () => {
|
|||||||
: isForm ? 'fa-wpforms'
|
: isForm ? 'fa-wpforms'
|
||||||
: isSocial ? 'fa-share-alt'
|
: isSocial ? 'fa-share-alt'
|
||||||
: isSection ? 'fa-th-large'
|
: isSection ? 'fa-th-large'
|
||||||
|
: isHtml ? 'fa-code'
|
||||||
: isUtility ? 'fa-ellipsis-h'
|
: isUtility ? 'fa-ellipsis-h'
|
||||||
: 'fa-cube';
|
: 'fa-cube';
|
||||||
|
|
||||||
@@ -158,11 +162,14 @@ export const GuidedStyles: React.FC = () => {
|
|||||||
{/* SECTION-TYPE (Accordion, Tabs, Testimonials, Countdown, Counter, CTA, Features) */}
|
{/* SECTION-TYPE (Accordion, Tabs, Testimonials, Countdown, Counter, CTA, Features) */}
|
||||||
{isSection && <SectionTypePanel selectedId={selected} nodeProps={nodeProps} typeName={typeName} />}
|
{isSection && <SectionTypePanel selectedId={selected} nodeProps={nodeProps} typeName={typeName} />}
|
||||||
|
|
||||||
{/* UTILITY (Divider, Spacer, HTML) -- use generic but it works well for these */}
|
{/* HTML -- code editor only */}
|
||||||
|
{isHtml && <HtmlStylePanel selectedId={selected} nodeProps={nodeProps} />}
|
||||||
|
|
||||||
|
{/* UTILITY (Divider, Spacer) -- use generic but it works well for these */}
|
||||||
{isUtility && <GenericPropsEditor selectedId={selected} nodeProps={nodeProps} typeName={typeName} />}
|
{isUtility && <GenericPropsEditor selectedId={selected} nodeProps={nodeProps} typeName={typeName} />}
|
||||||
|
|
||||||
{/* FALLBACK: Anything not matched above */}
|
{/* FALLBACK: Anything not matched above */}
|
||||||
{!isText && !isButton && !isImage && !isBgSection && !isContainer && !isHero && !isNav && !isMedia && !isForm && !isSocial && !isPricing && !isSection && !isUtility && (
|
{!isText && !isButton && !isImage && !isBgSection && !isContainer && !isHero && !isNav && !isMedia && !isForm && !isSocial && !isPricing && !isSection && !isUtility && !isHtml && (
|
||||||
<GenericPropsEditor selectedId={selected} nodeProps={nodeProps} typeName={typeName} />
|
<GenericPropsEditor selectedId={selected} nodeProps={nodeProps} typeName={typeName} />
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -0,0 +1,97 @@
|
|||||||
|
import { describe, test, expect } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { renderEditorHarness } from '../../test-utils/editorHarness';
|
||||||
|
import { EditorConfigProvider } from '../../state/EditorConfigContext';
|
||||||
|
import { PageProvider, usePages } from '../../state/PageContext';
|
||||||
|
import { SiteDesignProvider, useSiteDesign, DEFAULT_SITE_DESIGN } from '../../state/SiteDesignContext';
|
||||||
|
import { SiteDesignPanel } from './SiteDesignPanel';
|
||||||
|
|
||||||
|
/** React tracks a controlled `<input>`'s value via a wrapped native setter --
|
||||||
|
* a plain `input.value = x` assignment doesn't go through it, so React never
|
||||||
|
* sees the change and skips onChange. */
|
||||||
|
function setInputValue(input: HTMLInputElement, value: string) {
|
||||||
|
const setter = Object.getOwnPropertyDescriptor(window.HTMLInputElement.prototype, 'value')!.set!;
|
||||||
|
setter.call(input, value);
|
||||||
|
input.dispatchEvent(new Event('input', { bubbles: true }));
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Real-provider integration test -- NO mocks. Exercises the actual
|
||||||
|
* `replaceAllPages`/`setHeader`/`setFooter`/`resetToDefaults` implementations,
|
||||||
|
* which route the component's blank trees through the real
|
||||||
|
* `treeToCraftState` -> `sanitizeAiTree`/`flattenTreeForCraft` pipeline (see
|
||||||
|
* `state/PageContext.tsx` and `utils/craft-tree.ts`). This is the check the
|
||||||
|
* task brief calls out specifically: a tree shape that fails sanitisation
|
||||||
|
* would silently fall back to an empty canvas (masking a bug) rather than
|
||||||
|
* throwing, so asserting only on mock call arguments (as
|
||||||
|
* `SiteDesignPanel.reset.test.tsx` does) would not catch a bad tree shape --
|
||||||
|
* the mocked assertions there only prove the component PASSED a
|
||||||
|
* `{type:{resolvedName:'Container'}, nodes:[]}`-shaped object; they can't
|
||||||
|
* prove that object is actually valid input to the real pipeline.
|
||||||
|
*/
|
||||||
|
describe('Reset Entire Site -- real PageContext/SiteDesignContext integration', () => {
|
||||||
|
test('confirming produces a real, valid single blank Home page + header + footer + default design', () => {
|
||||||
|
let pageCtx: ReturnType<typeof usePages> | null = null;
|
||||||
|
let designCtx: ReturnType<typeof useSiteDesign> | null = null;
|
||||||
|
const Probe: React.FC = () => {
|
||||||
|
pageCtx = usePages();
|
||||||
|
designCtx = useSiteDesign();
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
|
const harness = renderEditorHarness();
|
||||||
|
harness.mountChild(
|
||||||
|
<EditorConfigProvider config={{
|
||||||
|
user: 'u', apiUrl: '/api', csrfToken: 't', siteId: 1,
|
||||||
|
siteDomain: 'example.com', siteName: 'Example', backUrl: '/', isRoot: false,
|
||||||
|
}}>
|
||||||
|
<PageProvider>
|
||||||
|
<SiteDesignProvider>
|
||||||
|
<Probe />
|
||||||
|
<SiteDesignPanel />
|
||||||
|
</SiteDesignProvider>
|
||||||
|
</PageProvider>
|
||||||
|
</EditorConfigProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
// Dirty the design tokens first so resetToDefaults has something to undo.
|
||||||
|
harness.act(() => { designCtx!.updateDesign({ primaryColor: '#000000' }); });
|
||||||
|
expect(designCtx!.design.primaryColor).toBe('#000000');
|
||||||
|
|
||||||
|
harness.act(() => {
|
||||||
|
(harness.container.querySelector('[data-action="open-site-reset"]') as HTMLButtonElement).click();
|
||||||
|
});
|
||||||
|
const input = harness.container.querySelector('[data-testid="site-reset-domain"]') as HTMLInputElement;
|
||||||
|
harness.act(() => { setInputValue(input, 'example.com'); });
|
||||||
|
harness.act(() => {
|
||||||
|
(harness.container.querySelector('[data-action="confirm-site-reset"]') as HTMLButtonElement).click();
|
||||||
|
});
|
||||||
|
|
||||||
|
// Exactly one page, "Home", landing-page slug -- and its stored
|
||||||
|
// craftState is real, parseable Craft.js state with a Container ROOT
|
||||||
|
// and no children (i.e. sanitizeAiTree did NOT reject the tree and fall
|
||||||
|
// back to a silent empty canvas for the wrong reason -- it's genuinely
|
||||||
|
// ROOT with zero nodes because that's what we asked for).
|
||||||
|
expect(pageCtx!.pages).toHaveLength(1);
|
||||||
|
expect(pageCtx!.pages[0].name).toBe('Home');
|
||||||
|
expect(pageCtx!.pages[0].slug).toBe('index');
|
||||||
|
const homeState = JSON.parse(pageCtx!.pages[0].craftState!);
|
||||||
|
expect(homeState.ROOT.type.resolvedName).toBe('Container');
|
||||||
|
expect(homeState.ROOT.nodes).toEqual([]);
|
||||||
|
|
||||||
|
const headerState = JSON.parse(pageCtx!.headerPage.craftState!);
|
||||||
|
expect(headerState.ROOT.type.resolvedName).toBe('Container');
|
||||||
|
expect(headerState.ROOT.nodes).toEqual([]);
|
||||||
|
expect(headerState.ROOT.props.tag).toBe('header');
|
||||||
|
|
||||||
|
const footerState = JSON.parse(pageCtx!.footerPage.craftState!);
|
||||||
|
expect(footerState.ROOT.type.resolvedName).toBe('Container');
|
||||||
|
expect(footerState.ROOT.nodes).toEqual([]);
|
||||||
|
expect(footerState.ROOT.props.tag).toBe('footer');
|
||||||
|
|
||||||
|
// Design tokens are back to the defaults.
|
||||||
|
expect(designCtx!.design).toEqual(DEFAULT_SITE_DESIGN);
|
||||||
|
|
||||||
|
harness.unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,213 @@
|
|||||||
|
import { describe, test, expect, vi } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
|
||||||
|
/* -------------------------------------------------------------------------
|
||||||
|
* Mocked-hook tests -- pure UI-logic coverage: the domain-match guard, that
|
||||||
|
* confirming calls the right context functions with tree-shaped arguments,
|
||||||
|
* and that standalone mode (empty siteDomain) hides the entry point
|
||||||
|
* entirely. The real `replaceAllPages`/`setHeader`/`setFooter`/
|
||||||
|
* `resetToDefaults` implementations (and whether the blank trees this
|
||||||
|
* component builds actually survive `treeToCraftState`/`sanitizeAiTree`) are
|
||||||
|
* covered separately, WITHOUT mocks, in
|
||||||
|
* `SiteDesignPanel.reset.integration.test.tsx` -- `vi.mock` is hoisted and
|
||||||
|
* file-scoped, so it can't be selectively "undone" partway through one file
|
||||||
|
* for a real-provider test.
|
||||||
|
* ---------------------------------------------------------------------- */
|
||||||
|
|
||||||
|
const replaceAllPages = vi.fn();
|
||||||
|
const setHeader = vi.fn();
|
||||||
|
const setFooter = vi.fn();
|
||||||
|
const resetToDefaults = vi.fn();
|
||||||
|
let mockSiteDomain = 'example.com';
|
||||||
|
|
||||||
|
vi.mock('../../state/PageContext', () => ({
|
||||||
|
usePages: () => ({ replaceAllPages, setHeader, setFooter, pages: [], siteDesign: {} }),
|
||||||
|
}));
|
||||||
|
vi.mock('../../state/SiteDesignContext', () => ({
|
||||||
|
useSiteDesign: () => ({ design: {}, updateDesign: vi.fn(), resetToDefaults }),
|
||||||
|
DEFAULT_SITE_DESIGN: {},
|
||||||
|
}));
|
||||||
|
vi.mock('../../state/EditorConfigContext', () => ({
|
||||||
|
useEditorConfig: () => ({ whpConfig: mockSiteDomain ? { siteDomain: mockSiteDomain } : null, isWHP: !!mockSiteDomain }),
|
||||||
|
}));
|
||||||
|
|
||||||
|
import { SiteDesignPanel, siteResetConfirmMatches } from './SiteDesignPanel';
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
|
||||||
|
function render() {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(<SiteDesignPanel />);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function unmount() {
|
||||||
|
act(() => { root.unmount(); });
|
||||||
|
container.remove();
|
||||||
|
}
|
||||||
|
|
||||||
|
/** React tracks a controlled `<input>`'s value via a wrapped native setter --
|
||||||
|
* a plain `input.value = x` assignment doesn't go through it, so React never
|
||||||
|
* sees the change and skips onChange. Using the real native setter (same
|
||||||
|
* pattern as `MediaStylePanel.slides.test.tsx`) makes the subsequent
|
||||||
|
* `input` event register as a genuine value change. */
|
||||||
|
function setInputValue(input: HTMLInputElement, value: string) {
|
||||||
|
const setter = Object.getOwnPropertyDescriptor(window.HTMLInputElement.prototype, 'value')!.set!;
|
||||||
|
setter.call(input, value);
|
||||||
|
input.dispatchEvent(new Event('input', { bubbles: true }));
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Reach past React's OWN disabled-button protection to grab the `onClick`
|
||||||
|
* function it attached to a DOM node, and call it directly.
|
||||||
|
*
|
||||||
|
* Verified empirically (see task-15 follow-up investigation) that neither
|
||||||
|
* `el.disabled = false; el.click()` nor a raw `dispatchEvent(new
|
||||||
|
* MouseEvent('click', ...))` actually invokes a React `onClick` handler once
|
||||||
|
* React has rendered the element with `disabled` truthy: react-dom's event
|
||||||
|
* system special-cases form controls and refuses to dispatch synthetic
|
||||||
|
* click/similar events against its own last-rendered `disabled` prop,
|
||||||
|
* regardless of what the live DOM property says. That's a second, redundant
|
||||||
|
* safety net on top of the native browser behavior -- but it also means a
|
||||||
|
* pure DOM-level "disabled bypass" can't reach `handleResetSite` at all
|
||||||
|
* through the button, and so can't exercise the handler's OWN guard the way
|
||||||
|
* this test needs to. Pulling `onClick` off the fiber's stashed props
|
||||||
|
* (`__reactProps$...`, the same object React itself calls into) and
|
||||||
|
* invoking it directly is what actually reaches `handleResetSite` -- the
|
||||||
|
* same code path a differently-wired future trigger (a keyboard shortcut, a
|
||||||
|
* second button, a copy-paste bug) would also go through without passing
|
||||||
|
* back through the `disabled` gate at all.
|
||||||
|
*/
|
||||||
|
function invokeReactOnClick(el: HTMLElement): void {
|
||||||
|
const propsKey = Object.keys(el).find((k) => k.startsWith('__reactProps$'));
|
||||||
|
const onClick = propsKey ? (el as unknown as Record<string, { onClick?: () => void }>)[propsKey].onClick : undefined;
|
||||||
|
if (!onClick) throw new Error('no React onClick prop found on element');
|
||||||
|
onClick();
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('siteResetConfirmMatches -- the guard predicate itself', () => {
|
||||||
|
test('matches only an exact (trimmed) domain match', () => {
|
||||||
|
expect(siteResetConfirmMatches('example.com', 'example.com')).toBe(true);
|
||||||
|
expect(siteResetConfirmMatches('example.co', 'example.com')).toBe(false);
|
||||||
|
expect(siteResetConfirmMatches('', 'example.com')).toBe(false);
|
||||||
|
expect(siteResetConfirmMatches(' example.com ', 'example.com')).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('an empty domain never matches, even against an empty typed value -- ' +
|
||||||
|
'this is the guard that must hold even if the (currently hidden) entry ' +
|
||||||
|
'point were ever reachable in standalone mode', () => {
|
||||||
|
expect(siteResetConfirmMatches('', '')).toBe(false);
|
||||||
|
expect(siteResetConfirmMatches(' ', '')).toBe(false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Reset Entire Site -- guard + wiring (mocked hooks)', () => {
|
||||||
|
test('the confirm button is disabled until the domain is typed exactly', () => {
|
||||||
|
mockSiteDomain = 'example.com';
|
||||||
|
render();
|
||||||
|
act(() => { (container.querySelector('[data-action="open-site-reset"]') as HTMLButtonElement).click(); });
|
||||||
|
|
||||||
|
const confirm = container.querySelector('[data-action="confirm-site-reset"]') as HTMLButtonElement;
|
||||||
|
expect(confirm.disabled).toBe(true);
|
||||||
|
|
||||||
|
const input = container.querySelector('[data-testid="site-reset-domain"]') as HTMLInputElement;
|
||||||
|
act(() => { setInputValue(input, 'example.co'); });
|
||||||
|
expect((container.querySelector('[data-action="confirm-site-reset"]') as HTMLButtonElement).disabled).toBe(true);
|
||||||
|
|
||||||
|
act(() => { setInputValue(input, 'example.com'); });
|
||||||
|
expect((container.querySelector('[data-action="confirm-site-reset"]') as HTMLButtonElement).disabled).toBe(false);
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('confirming blanks pages, header, footer and design tokens', () => {
|
||||||
|
mockSiteDomain = 'example.com';
|
||||||
|
replaceAllPages.mockClear();
|
||||||
|
setHeader.mockClear();
|
||||||
|
setFooter.mockClear();
|
||||||
|
resetToDefaults.mockClear();
|
||||||
|
|
||||||
|
render();
|
||||||
|
act(() => { (container.querySelector('[data-action="open-site-reset"]') as HTMLButtonElement).click(); });
|
||||||
|
const input = container.querySelector('[data-testid="site-reset-domain"]') as HTMLInputElement;
|
||||||
|
act(() => { setInputValue(input, 'example.com'); });
|
||||||
|
act(() => { (container.querySelector('[data-action="confirm-site-reset"]') as HTMLButtonElement).click(); });
|
||||||
|
|
||||||
|
expect(replaceAllPages).toHaveBeenCalledTimes(1);
|
||||||
|
const pagesArg = replaceAllPages.mock.calls[0][0];
|
||||||
|
expect(pagesArg).toHaveLength(1);
|
||||||
|
expect(pagesArg[0].name).toBe('Home');
|
||||||
|
// The replacement is a SerializedTreeNode (recursive tree), not a flat
|
||||||
|
// craft-state entry: a real Container root with no children.
|
||||||
|
expect(pagesArg[0].tree.type.resolvedName).toBe('Container');
|
||||||
|
expect(pagesArg[0].tree.nodes).toEqual([]);
|
||||||
|
|
||||||
|
expect(setHeader).toHaveBeenCalledTimes(1);
|
||||||
|
expect(setHeader.mock.calls[0][0].type.resolvedName).toBe('Container');
|
||||||
|
expect(setFooter).toHaveBeenCalledTimes(1);
|
||||||
|
expect(setFooter.mock.calls[0][0].type.resolvedName).toBe('Container');
|
||||||
|
expect(resetToDefaults).toHaveBeenCalledTimes(1);
|
||||||
|
|
||||||
|
// The panel closes its own dialog back up after confirming.
|
||||||
|
expect(container.querySelector('[data-action="confirm-site-reset"]')).toBeNull();
|
||||||
|
expect(container.querySelector('[data-action="open-site-reset"]')).toBeTruthy();
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the handler itself refuses a non-matching value, even when its onClick is invoked ' +
|
||||||
|
'directly (bypassing `disabled` and React\'s own disabled-click suppression) -- proves ' +
|
||||||
|
'the guard is load-bearing in handleResetSite, not just a UI affordance a different ' +
|
||||||
|
'trigger path could route around', () => {
|
||||||
|
mockSiteDomain = 'example.com';
|
||||||
|
replaceAllPages.mockClear();
|
||||||
|
setHeader.mockClear();
|
||||||
|
setFooter.mockClear();
|
||||||
|
resetToDefaults.mockClear();
|
||||||
|
|
||||||
|
render();
|
||||||
|
act(() => { (container.querySelector('[data-action="open-site-reset"]') as HTMLButtonElement).click(); });
|
||||||
|
const input = container.querySelector('[data-testid="site-reset-domain"]') as HTMLInputElement;
|
||||||
|
act(() => { setInputValue(input, 'not-the-domain'); });
|
||||||
|
|
||||||
|
const confirm = container.querySelector('[data-action="confirm-site-reset"]') as HTMLButtonElement;
|
||||||
|
expect(confirm.disabled).toBe(true); // sanity: the UI affordance is still doing its job too
|
||||||
|
|
||||||
|
act(() => { invokeReactOnClick(confirm); });
|
||||||
|
|
||||||
|
expect(replaceAllPages).not.toHaveBeenCalled();
|
||||||
|
expect(setHeader).not.toHaveBeenCalled();
|
||||||
|
expect(setFooter).not.toHaveBeenCalled();
|
||||||
|
expect(resetToDefaults).not.toHaveBeenCalled();
|
||||||
|
// The dialog is still open -- handleResetSite returned early before
|
||||||
|
// reaching its own close-the-dialog cleanup.
|
||||||
|
expect(container.querySelector('[data-action="confirm-site-reset"]')).toBeTruthy();
|
||||||
|
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('standalone mode (no WHP_CONFIG, siteDomain "") hides the entry point entirely, ' +
|
||||||
|
'while non-standalone mode shows it -- an empty typed input must never trivially ' +
|
||||||
|
'satisfy the guard. Asserted as a contrast within one test (not "absence" alone) ' +
|
||||||
|
'so this fails if the whole feature -- not just the guard -- were ever removed.', () => {
|
||||||
|
mockSiteDomain = '';
|
||||||
|
render();
|
||||||
|
expect(container.querySelector('[data-action="open-site-reset"]')).toBeNull();
|
||||||
|
expect(container.querySelector('[data-testid="site-reset-domain"]')).toBeNull();
|
||||||
|
expect(container.textContent).not.toContain('Danger zone');
|
||||||
|
expect(container.textContent).not.toContain('Reset Entire Site');
|
||||||
|
unmount();
|
||||||
|
|
||||||
|
mockSiteDomain = 'example.com';
|
||||||
|
render();
|
||||||
|
expect(container.querySelector('[data-action="open-site-reset"]')).toBeTruthy();
|
||||||
|
expect(container.textContent).toContain('Danger zone');
|
||||||
|
unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -1,6 +1,11 @@
|
|||||||
import React, { useState } from 'react';
|
import React, { useState } from 'react';
|
||||||
import { useSiteDesign, DEFAULT_SITE_DESIGN } from '../../state/SiteDesignContext';
|
import { useSiteDesign, DEFAULT_SITE_DESIGN } from '../../state/SiteDesignContext';
|
||||||
|
import { usePages } from '../../state/PageContext';
|
||||||
|
import { useEditorConfig } from '../../state/EditorConfigContext';
|
||||||
|
import { SerializedTreeNode } from '../../types/sitesmith';
|
||||||
import { FONT_FAMILIES } from '../../constants/presets';
|
import { FONT_FAMILIES } from '../../constants/presets';
|
||||||
|
import { AssetPicker } from '../../ui/AssetPicker';
|
||||||
|
import { inputStyle } from './styles/shared';
|
||||||
|
|
||||||
type DesignTab = 'basic' | 'advanced';
|
type DesignTab = 'basic' | 'advanced';
|
||||||
|
|
||||||
@@ -155,12 +160,94 @@ const NavStyleField: React.FC<NavStyleFieldProps> = ({ value, onChange }) => (
|
|||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
|
|
||||||
|
/* ---------- Reset Entire Site (danger zone) ---------- */
|
||||||
|
|
||||||
|
// Blank replacement trees for the "Reset Entire Site" escape hatch. Shaped
|
||||||
|
// as a `SerializedTreeNode` (type + props + nodes), NOT a flat Craft.js
|
||||||
|
// state entry -- this is what `replaceAllPages`/`setHeader`/`setFooter`
|
||||||
|
// feed into `treeToCraftState` -> `sanitizeAiTree`/`flattenTreeForCraft`
|
||||||
|
// (see `state/PageContext.tsx`/`utils/craft-tree.ts`). A single `Container`
|
||||||
|
// root with no children mirrors the (unexported) EMPTY_CANVAS/EMPTY_HEADER/
|
||||||
|
// EMPTY_FOOTER constants already used elsewhere for "blank".
|
||||||
|
const BLANK_PAGE_TREE: SerializedTreeNode = {
|
||||||
|
type: { resolvedName: 'Container' },
|
||||||
|
props: { style: { minHeight: '100vh', backgroundColor: '#ffffff' }, tag: 'div' },
|
||||||
|
nodes: [],
|
||||||
|
};
|
||||||
|
|
||||||
|
const BLANK_HEADER_TREE: SerializedTreeNode = {
|
||||||
|
type: { resolvedName: 'Container' },
|
||||||
|
props: {
|
||||||
|
style: { minHeight: '60px', backgroundColor: '#ffffff', padding: '12px 24px', display: 'flex', alignItems: 'center' },
|
||||||
|
tag: 'header',
|
||||||
|
},
|
||||||
|
nodes: [],
|
||||||
|
};
|
||||||
|
|
||||||
|
const BLANK_FOOTER_TREE: SerializedTreeNode = {
|
||||||
|
type: { resolvedName: 'Container' },
|
||||||
|
props: {
|
||||||
|
style: { minHeight: '60px', backgroundColor: '#0f172a', color: '#94a3b8', padding: '40px 24px', textAlign: 'center' },
|
||||||
|
tag: 'footer',
|
||||||
|
},
|
||||||
|
nodes: [],
|
||||||
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Single source of truth for "has the user typed enough to arm the confirm
|
||||||
|
* button" -- used for the `disabled` attribute/cursor/opacity AND, more
|
||||||
|
* importantly, inside `handleResetSite` itself. `disabled` is a UI
|
||||||
|
* affordance, not a safety mechanism (it only stops a plain mouse click);
|
||||||
|
* for the one action in this app that irreversibly wipes a user's whole
|
||||||
|
* site draft, the real guard has to live in the handler, checked against
|
||||||
|
* this exact same predicate rather than a second hand-rolled comparison
|
||||||
|
* that could drift out of sync with it.
|
||||||
|
*
|
||||||
|
* An empty/falsy `domain` always returns `false`, even if `typed` is also
|
||||||
|
* empty -- `''.trim() === ''.trim()` would otherwise "match" trivially.
|
||||||
|
* Standalone mode (no `WHP_CONFIG`) has `siteDomain === ''`, and while the
|
||||||
|
* entry point that would let a user reach this code is hidden in that case
|
||||||
|
* (see the `siteDomain &&` guard around the whole danger zone below), this
|
||||||
|
* function must not depend on that -- it has to fail safe on its own if
|
||||||
|
* ever reached with no configured domain.
|
||||||
|
*
|
||||||
|
* Exported so it's directly unit-testable without needing a way to render
|
||||||
|
* the (deliberately unreachable-when-`siteDomain`-is-empty) confirm UI.
|
||||||
|
*/
|
||||||
|
export function siteResetConfirmMatches(typed: string, domain: string): boolean {
|
||||||
|
return !!domain && typed.trim() === domain.trim();
|
||||||
|
}
|
||||||
|
|
||||||
/* ---------- Main SiteDesignPanel ---------- */
|
/* ---------- Main SiteDesignPanel ---------- */
|
||||||
|
|
||||||
export const SiteDesignPanel: React.FC = () => {
|
export const SiteDesignPanel: React.FC = () => {
|
||||||
const { design, updateDesign, resetToDefaults } = useSiteDesign();
|
const { design, updateDesign, resetToDefaults } = useSiteDesign();
|
||||||
|
const { replaceAllPages, setHeader, setFooter } = usePages();
|
||||||
|
const { whpConfig } = useEditorConfig();
|
||||||
|
// Standalone mode (no WHP_CONFIG) has no site domain to confirm against --
|
||||||
|
// an empty typed input would then trivially "match" an empty siteDomain,
|
||||||
|
// arming the destructive confirm button with no guard at all. The entry
|
||||||
|
// point itself is hidden in that case (see the `siteDomain &&` guard below).
|
||||||
|
const siteDomain = whpConfig?.siteDomain ?? '';
|
||||||
|
const [siteResetOpen, setSiteResetOpen] = useState(false);
|
||||||
|
const [siteResetTyped, setSiteResetTyped] = useState('');
|
||||||
const [tab, setTab] = useState<DesignTab>('basic');
|
const [tab, setTab] = useState<DesignTab>('basic');
|
||||||
|
|
||||||
|
const handleResetSite = (): void => {
|
||||||
|
// Load-bearing guard -- see `siteResetConfirmMatches`'s docstring. Not
|
||||||
|
// just a UI nicety: this must hold even if the confirm button's
|
||||||
|
// `disabled` attribute were ever bypassed (a synthetic click, or a
|
||||||
|
// future refactor that drops it).
|
||||||
|
if (!siteResetConfirmMatches(siteResetTyped, siteDomain)) return;
|
||||||
|
|
||||||
|
replaceAllPages([{ name: 'Home', tree: BLANK_PAGE_TREE }]);
|
||||||
|
setHeader(BLANK_HEADER_TREE);
|
||||||
|
setFooter(BLANK_FOOTER_TREE);
|
||||||
|
resetToDefaults();
|
||||||
|
setSiteResetOpen(false);
|
||||||
|
setSiteResetTyped('');
|
||||||
|
};
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div style={{ display: 'flex', flexDirection: 'column', gap: 0 }}>
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 0 }}>
|
||||||
{/* Header */}
|
{/* Header */}
|
||||||
@@ -200,6 +287,19 @@ export const SiteDesignPanel: React.FC = () => {
|
|||||||
{/* Basic tab */}
|
{/* Basic tab */}
|
||||||
{tab === 'basic' && (
|
{tab === 'basic' && (
|
||||||
<>
|
<>
|
||||||
|
<div className="guided-section">
|
||||||
|
<label className="guided-section-label">Favicon</label>
|
||||||
|
<AssetPicker
|
||||||
|
value={design.favicon}
|
||||||
|
onChange={(url) => updateDesign({ favicon: url })}
|
||||||
|
mediaType="image"
|
||||||
|
variant="full"
|
||||||
|
placeholder="Or paste favicon URL..."
|
||||||
|
/>
|
||||||
|
<p style={{ fontSize: 10, color: 'var(--color-text-dim)', margin: '4px 0 0' }}>
|
||||||
|
Shown in browser tabs and bookmarks. Applies site-wide.
|
||||||
|
</p>
|
||||||
|
</div>
|
||||||
<ColorField
|
<ColorField
|
||||||
label="Primary Color"
|
label="Primary Color"
|
||||||
value={design.primaryColor}
|
value={design.primaryColor}
|
||||||
@@ -357,6 +457,85 @@ export const SiteDesignPanel: React.FC = () => {
|
|||||||
</p>
|
</p>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
{/* Reset Entire Site (danger zone) -- hidden entirely in standalone
|
||||||
|
mode, where siteDomain is '' and typing nothing would trivially
|
||||||
|
satisfy an empty-string match. */}
|
||||||
|
{siteDomain && (
|
||||||
|
<div
|
||||||
|
style={{
|
||||||
|
marginTop: 18, padding: 12,
|
||||||
|
border: '1px solid rgba(239,68,68,0.35)',
|
||||||
|
borderRadius: 'var(--radius-sm)',
|
||||||
|
background: 'rgba(239,68,68,0.06)',
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<div style={{ fontSize: 11, fontWeight: 700, color: '#ef4444', textTransform: 'uppercase', letterSpacing: '0.5px', marginBottom: 6 }}>
|
||||||
|
Danger zone
|
||||||
|
</div>
|
||||||
|
|
||||||
|
{!siteResetOpen ? (
|
||||||
|
<button
|
||||||
|
data-action="open-site-reset"
|
||||||
|
onClick={() => setSiteResetOpen(true)}
|
||||||
|
style={{
|
||||||
|
width: '100%', padding: '8px 12px', fontSize: 11, fontWeight: 600,
|
||||||
|
color: '#ef4444', background: 'transparent',
|
||||||
|
border: '1px solid rgba(239,68,68,0.5)', borderRadius: 'var(--radius-sm)', cursor: 'pointer',
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Reset Entire Site
|
||||||
|
</button>
|
||||||
|
) : (
|
||||||
|
<>
|
||||||
|
<p style={{ fontSize: 11, color: 'var(--color-text-muted)', lineHeight: 1.5, margin: '0 0 8px' }}>
|
||||||
|
This blanks <strong>every page</strong>, the header, the footer, all
|
||||||
|
design tokens (colors, fonts, radii), and your custom head code and
|
||||||
|
favicon, leaving one empty Home page. Uploaded images are kept.
|
||||||
|
<strong> This cannot be undone.</strong> Your published site stays as it
|
||||||
|
is until you publish again — but the editor auto-saves roughly every 30
|
||||||
|
seconds, so the blank version becomes your saved draft shortly after.
|
||||||
|
</p>
|
||||||
|
<p style={{ fontSize: 11, color: 'var(--color-text-muted)', margin: '0 0 4px' }}>
|
||||||
|
Type <code>{siteDomain}</code> to confirm:
|
||||||
|
</p>
|
||||||
|
<input
|
||||||
|
data-testid="site-reset-domain"
|
||||||
|
value={siteResetTyped}
|
||||||
|
onChange={(e) => setSiteResetTyped(e.target.value)}
|
||||||
|
placeholder={siteDomain}
|
||||||
|
style={inputStyle}
|
||||||
|
/>
|
||||||
|
<div style={{ display: 'flex', gap: 6, marginTop: 8 }}>
|
||||||
|
<button
|
||||||
|
data-action="confirm-site-reset"
|
||||||
|
disabled={!siteResetConfirmMatches(siteResetTyped, siteDomain)}
|
||||||
|
onClick={handleResetSite}
|
||||||
|
style={{
|
||||||
|
flex: 1, padding: '7px 10px', fontSize: 11, fontWeight: 600,
|
||||||
|
color: '#fff', background: '#ef4444', border: 'none',
|
||||||
|
borderRadius: 'var(--radius-sm)',
|
||||||
|
cursor: siteResetConfirmMatches(siteResetTyped, siteDomain) ? 'pointer' : 'not-allowed',
|
||||||
|
opacity: siteResetConfirmMatches(siteResetTyped, siteDomain) ? 1 : 0.5,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Reset everything
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
onClick={() => { setSiteResetOpen(false); setSiteResetTyped(''); }}
|
||||||
|
style={{
|
||||||
|
flex: 1, padding: '7px 10px', fontSize: 11, fontWeight: 600,
|
||||||
|
color: 'var(--color-text-muted)', background: 'var(--color-bg-elevated)',
|
||||||
|
border: '1px solid var(--color-border)', borderRadius: 'var(--radius-sm)', cursor: 'pointer',
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Cancel
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
</>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
import React from 'react';
|
import React, { useEffect, useRef } from 'react';
|
||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import { CollapsibleSection, ArrayPropEditor, smallInputStyle } from './shared';
|
import { CollapsibleSection, ArrayPropEditor, smallInputStyle } from './shared';
|
||||||
|
import { useLayerFocus } from '../../left/LayerFocusContext';
|
||||||
|
|
||||||
/* ---------- Shared array-item field editor ----------
|
/* ---------- Shared array-item field editor ----------
|
||||||
Extracted from SectionTypePanel and GenericPropsEditor, which both had a
|
Extracted from SectionTypePanel and GenericPropsEditor, which both had a
|
||||||
@@ -18,7 +19,26 @@ export const ArrayItemFieldsEditor: React.FC<{ selectedId: string; propKey: stri
|
|||||||
const sampleItem = arrayItems[0] || {};
|
const sampleItem = arrayItems[0] || {};
|
||||||
const itemFields = typeof sampleItem === 'object' && sampleItem !== null ? Object.keys(sampleItem) : [];
|
const itemFields = typeof sampleItem === 'object' && sampleItem !== null ? Object.keys(sampleItem) : [];
|
||||||
|
|
||||||
|
// Layers panel -> array editor "scroll to this item" hookup. The outer
|
||||||
|
// <div ref={rootRef}> wraps ArrayPropEditor's rendered cards (the actual
|
||||||
|
// per-item background box lives in shared.tsx's ArrayPropEditor, which is
|
||||||
|
// also used by MediaStylePanel/FormStylePanel -- rather than touch that
|
||||||
|
// shared component for one consumer, the data-array-item tag below goes
|
||||||
|
// on the content renderItem returns, which is enough for scrollIntoView
|
||||||
|
// to bring the right card into the viewport.
|
||||||
|
const { focus } = useLayerFocus();
|
||||||
|
const rootRef = useRef<HTMLDivElement | null>(null);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!focus || focus.prop !== propKey) return;
|
||||||
|
const card = rootRef.current?.querySelector(`[data-array-item="${propKey}:${focus.index}"]`);
|
||||||
|
card?.scrollIntoView?.({ block: 'nearest', behavior: 'smooth' });
|
||||||
|
// `focus.nonce` is in the dep list so clicking the SAME row twice
|
||||||
|
// re-scrolls (the request object is otherwise identical).
|
||||||
|
}, [focus?.nonce, focus?.prop, focus?.index, propKey]);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
|
<div ref={rootRef}>
|
||||||
<CollapsibleSection title={propKey.replace(/([A-Z])/g, ' $1').trim()}>
|
<CollapsibleSection title={propKey.replace(/([A-Z])/g, ' $1').trim()}>
|
||||||
<ArrayPropEditor
|
<ArrayPropEditor
|
||||||
selectedId={selectedId}
|
selectedId={selectedId}
|
||||||
@@ -29,6 +49,7 @@ export const ArrayItemFieldsEditor: React.FC<{ selectedId: string; propKey: stri
|
|||||||
return (
|
return (
|
||||||
<input
|
<input
|
||||||
type="text"
|
type="text"
|
||||||
|
data-array-item={`${propKey}:${index}`}
|
||||||
value={String(item)}
|
value={String(item)}
|
||||||
onChange={(e) => {
|
onChange={(e) => {
|
||||||
actions.setProp(selectedId, (props: any) => {
|
actions.setProp(selectedId, (props: any) => {
|
||||||
@@ -42,7 +63,7 @@ export const ArrayItemFieldsEditor: React.FC<{ selectedId: string; propKey: stri
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
return (
|
return (
|
||||||
<div style={{ display: 'flex', flexDirection: 'column', gap: 3 }}>
|
<div data-array-item={`${propKey}:${index}`} style={{ display: 'flex', flexDirection: 'column', gap: 3 }}>
|
||||||
{itemFields.map((field) => {
|
{itemFields.map((field) => {
|
||||||
const fieldVal = item[field];
|
const fieldVal = item[field];
|
||||||
if (typeof fieldVal === 'boolean') {
|
if (typeof fieldVal === 'boolean') {
|
||||||
@@ -123,5 +144,6 @@ export const ArrayItemFieldsEditor: React.FC<{ selectedId: string; propKey: stri
|
|||||||
}
|
}
|
||||||
/>
|
/>
|
||||||
</CollapsibleSection>
|
</CollapsibleSection>
|
||||||
|
</div>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ import {
|
|||||||
BG_COLORS,
|
BG_COLORS,
|
||||||
RADIUS_PRESETS,
|
RADIUS_PRESETS,
|
||||||
SPACING_PRESETS,
|
SPACING_PRESETS,
|
||||||
|
SHADOW_PRESETS,
|
||||||
} from '../../../constants/presets';
|
} from '../../../constants/presets';
|
||||||
import {
|
import {
|
||||||
StylePanelProps,
|
StylePanelProps,
|
||||||
@@ -11,16 +12,49 @@ import {
|
|||||||
ColorSwatchGrid,
|
ColorSwatchGrid,
|
||||||
PresetButtonGrid,
|
PresetButtonGrid,
|
||||||
TextInputField,
|
TextInputField,
|
||||||
|
ColorPickerField,
|
||||||
|
CollapsibleSection,
|
||||||
|
SpacingControl,
|
||||||
|
SpacingSide,
|
||||||
|
BorderControl,
|
||||||
|
BorderValue,
|
||||||
|
buildBorderShorthand,
|
||||||
|
AnimationControl,
|
||||||
|
VisibilityControl,
|
||||||
|
sectionGap,
|
||||||
|
labelStyle,
|
||||||
autoTextColor,
|
autoTextColor,
|
||||||
useNodeProp,
|
useNodeProp,
|
||||||
} from './shared';
|
} from './shared';
|
||||||
|
|
||||||
|
function capitalize(s: string): string {
|
||||||
|
return s.charAt(0).toUpperCase() + s.slice(1);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Parses a `border` shorthand string (e.g. "2px solid #ff0000") back into
|
||||||
|
* the {width,style,color} shape BorderControl edits. Only needs to
|
||||||
|
* round-trip values this same panel produced via buildBorderShorthand. */
|
||||||
|
function parseBorderShorthand(v: string | undefined): BorderValue {
|
||||||
|
if (!v || v === 'none') return { width: '', style: 'none', color: '#000000' };
|
||||||
|
const m = String(v).trim().match(/^(\d+(?:\.\d+)?(?:px|em|rem)?)\s+(\w+)\s+(.+)$/);
|
||||||
|
if (!m) return { width: '', style: 'none', color: '#000000' };
|
||||||
|
return { width: m[1], style: m[2], color: m[3] };
|
||||||
|
}
|
||||||
|
|
||||||
|
/** style.opacity is a CSS-length-free numeric string ("0.8") or blank
|
||||||
|
* (treated as fully opaque). Converts to a 0-100 integer for the UI. */
|
||||||
|
function opacityPercent(v: unknown): number {
|
||||||
|
if (v === undefined || v === null || v === '') return 100;
|
||||||
|
const n = parseFloat(String(v));
|
||||||
|
return Number.isFinite(n) ? Math.round(n * 100) : 100;
|
||||||
|
}
|
||||||
|
|
||||||
/* ---------- BUTTON ---------- */
|
/* ---------- BUTTON ---------- */
|
||||||
export const ButtonStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodeProps }) => {
|
export const ButtonStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodeProps }) => {
|
||||||
const { actions } = useEditor();
|
const { actions } = useEditor();
|
||||||
const style: CSSProperties = nodeProps.style || {};
|
const style: CSSProperties = nodeProps.style || {};
|
||||||
|
|
||||||
const { setPropStyle } = useNodeProp(selectedId);
|
const { setProp, setPropStyle } = useNodeProp(selectedId);
|
||||||
|
|
||||||
const setButtonColor = useCallback(
|
const setButtonColor = useCallback(
|
||||||
(bgColor: string) => {
|
(bgColor: string) => {
|
||||||
@@ -61,6 +95,16 @@ export const ButtonStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodePr
|
|||||||
actions.setProp(selectedId, (props: any) => { props.href = v; });
|
actions.setProp(selectedId, (props: any) => { props.href = v; });
|
||||||
}}
|
}}
|
||||||
/>
|
/>
|
||||||
|
<div className="guided-section">
|
||||||
|
<label style={{ display: 'flex', alignItems: 'center', gap: 6, fontSize: 11, color: '#e4e4e7', cursor: 'pointer' }}>
|
||||||
|
<input
|
||||||
|
type="checkbox"
|
||||||
|
checked={nodeProps.target === '_blank'}
|
||||||
|
onChange={(e) => setProp('target', e.target.checked ? '_blank' : '_self')}
|
||||||
|
/>
|
||||||
|
Open in new tab
|
||||||
|
</label>
|
||||||
|
</div>
|
||||||
<div className="guided-section">
|
<div className="guided-section">
|
||||||
<SectionLabel>Border Radius</SectionLabel>
|
<SectionLabel>Border Radius</SectionLabel>
|
||||||
<PresetButtonGrid
|
<PresetButtonGrid
|
||||||
@@ -77,6 +121,70 @@ export const ButtonStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodePr
|
|||||||
onSelect={(v) => setPropStyle('padding', v)}
|
onSelect={(v) => setPropStyle('padding', v)}
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
{/* Hover state -- rendered into a scoped <style>...:hover{} block by
|
||||||
|
ButtonLink.toHtml (published export only; not shown live in the
|
||||||
|
editor canvas beyond the hover preview ButtonLink itself does). */}
|
||||||
|
<CollapsibleSection title="Hover State" defaultOpen={false}>
|
||||||
|
<ColorPickerField
|
||||||
|
label="Hover Background"
|
||||||
|
value={nodeProps.hoverBg || ''}
|
||||||
|
onChange={(v) => setProp('hoverBg', v)}
|
||||||
|
/>
|
||||||
|
<ColorPickerField
|
||||||
|
label="Hover Text Color"
|
||||||
|
value={nodeProps.hoverColor || ''}
|
||||||
|
onChange={(v) => setProp('hoverColor', v)}
|
||||||
|
/>
|
||||||
|
</CollapsibleSection>
|
||||||
|
|
||||||
|
{/* Box model + border/effects + animation/visibility rollout */}
|
||||||
|
<CollapsibleSection title="Spacing" defaultOpen={false}>
|
||||||
|
<SpacingControl
|
||||||
|
label="Margin"
|
||||||
|
value={{ top: style.marginTop as string, right: style.marginRight as string, bottom: style.marginBottom as string, left: style.marginLeft as string }}
|
||||||
|
onChange={(side: SpacingSide, v: string) => setPropStyle(`margin${capitalize(side)}`, v)}
|
||||||
|
/>
|
||||||
|
</CollapsibleSection>
|
||||||
|
<CollapsibleSection title="Border & Effects" defaultOpen={false}>
|
||||||
|
<BorderControl
|
||||||
|
value={parseBorderShorthand(style.border as string)}
|
||||||
|
onChange={(v) => setPropStyle('border', buildBorderShorthand(v))}
|
||||||
|
/>
|
||||||
|
<div className="guided-section">
|
||||||
|
<SectionLabel>Shadow</SectionLabel>
|
||||||
|
<PresetButtonGrid presets={SHADOW_PRESETS} activeValue={style.boxShadow as string} onSelect={(v) => setPropStyle('boxShadow', v)} />
|
||||||
|
</div>
|
||||||
|
<div style={sectionGap}>
|
||||||
|
<label style={labelStyle}>Opacity: {opacityPercent(style.opacity)}%</label>
|
||||||
|
<input
|
||||||
|
type="range"
|
||||||
|
min={0}
|
||||||
|
max={100}
|
||||||
|
value={opacityPercent(style.opacity)}
|
||||||
|
onChange={(e) => setPropStyle('opacity', String(Number(e.target.value) / 100))}
|
||||||
|
style={{ width: '100%' }}
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
</CollapsibleSection>
|
||||||
|
<CollapsibleSection title="Animation & Visibility" defaultOpen={false}>
|
||||||
|
<AnimationControl
|
||||||
|
value={{ animation: nodeProps.animation || 'none', animationDelay: nodeProps.animationDelay }}
|
||||||
|
onChange={(v) => { setProp('animation', v.animation); setProp('animationDelay', v.animationDelay); }}
|
||||||
|
/>
|
||||||
|
<VisibilityControl
|
||||||
|
value={{
|
||||||
|
hideOnDesktop: nodeProps.hideOnDesktop,
|
||||||
|
hideOnTablet: nodeProps.hideOnTablet,
|
||||||
|
hideOnMobile: nodeProps.hideOnMobile,
|
||||||
|
}}
|
||||||
|
onChange={(v) => {
|
||||||
|
setProp('hideOnDesktop', !!v.hideOnDesktop);
|
||||||
|
setProp('hideOnTablet', !!v.hideOnTablet);
|
||||||
|
setProp('hideOnMobile', !!v.hideOnMobile);
|
||||||
|
}}
|
||||||
|
/>
|
||||||
|
</CollapsibleSection>
|
||||||
</>
|
</>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -10,18 +10,40 @@ import {
|
|||||||
ColorSwatchGrid,
|
ColorSwatchGrid,
|
||||||
GradientSwatchGrid,
|
GradientSwatchGrid,
|
||||||
PresetButtonGrid,
|
PresetButtonGrid,
|
||||||
|
NumericUnitInput,
|
||||||
labelStyle,
|
labelStyle,
|
||||||
inputStyle,
|
inputStyle,
|
||||||
sectionGap,
|
sectionGap,
|
||||||
useNodeProp,
|
useNodeProp,
|
||||||
} from './shared';
|
} from './shared';
|
||||||
|
import { BoxModelSection, BorderEffectsSection, AnimVisSection } from './containerBoxModel';
|
||||||
|
|
||||||
/* ---------- CONTAINER / SECTION ---------- */
|
// Vertical Alignment options shown to the user identically regardless of
|
||||||
|
// which CSS property they end up mapped to (align-items for the Columns
|
||||||
|
// flex ROW vs. justify-content for Container/Section's flex COLUMN root --
|
||||||
|
// see the per-type branch below).
|
||||||
|
const VERTICAL_ALIGN_OPTIONS: { label: string; value: string }[] = [
|
||||||
|
{ label: 'Top', value: 'flex-start' },
|
||||||
|
{ label: 'Center', value: 'center' },
|
||||||
|
{ label: 'Bottom', value: 'flex-end' },
|
||||||
|
{ label: 'Stretch', value: 'stretch' },
|
||||||
|
];
|
||||||
|
|
||||||
|
/* ---------- CONTAINER / SECTION / COLUMNS ---------- */
|
||||||
export const ContainerStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodeProps }) => {
|
export const ContainerStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodeProps }) => {
|
||||||
const style: CSSProperties = nodeProps.style || {};
|
const style: CSSProperties = nodeProps.style || {};
|
||||||
|
|
||||||
const { setProp, setPropStyle } = useNodeProp(selectedId);
|
const { setProp, setPropStyle } = useNodeProp(selectedId);
|
||||||
|
|
||||||
|
// ColumnLayout only ever carries `columns`/`split` props -- Container and
|
||||||
|
// Section never set them -- so checking either alone distinguishes the
|
||||||
|
// flex-ROW case (align its columns via align-items, aligning uneven
|
||||||
|
// column heights) from the flex-COLUMN case (Container/Section, which
|
||||||
|
// vertically center/position their OWN content via justify-content,
|
||||||
|
// paired with a Min Height control so centering is meaningful).
|
||||||
|
const isColumns = nodeProps.columns !== undefined || nodeProps.split !== undefined;
|
||||||
|
const vAlignKey = isColumns ? 'alignItems' : 'justifyContent';
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<>
|
||||||
{nodeProps.cssId !== undefined && (
|
{nodeProps.cssId !== undefined && (
|
||||||
@@ -94,6 +116,30 @@ export const ContainerStylePanel: React.FC<StylePanelProps> = ({ selectedId, nod
|
|||||||
))}
|
))}
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
<div className="guided-section">
|
||||||
|
<SectionLabel>Vertical Alignment</SectionLabel>
|
||||||
|
<PresetButtonGrid
|
||||||
|
presets={VERTICAL_ALIGN_OPTIONS}
|
||||||
|
activeValue={style[vAlignKey] as string}
|
||||||
|
onSelect={(v) => setPropStyle(vAlignKey, v)}
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
{!isColumns && (
|
||||||
|
<div className="guided-section">
|
||||||
|
<SectionLabel>Min Height</SectionLabel>
|
||||||
|
<NumericUnitInput
|
||||||
|
value={(style.minHeight as string) || ''}
|
||||||
|
onChange={(v) => setPropStyle('minHeight', v)}
|
||||||
|
units={['px', 'vh', '%']}
|
||||||
|
placeholder="auto"
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
|
{/* Box model + border/effects + animation/visibility rollout */}
|
||||||
|
<BoxModelSection style={style} setPropStyle={setPropStyle} />
|
||||||
|
<BorderEffectsSection style={style} setPropStyle={setPropStyle} />
|
||||||
|
<AnimVisSection nodeProps={nodeProps} setProp={setProp} />
|
||||||
</>
|
</>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -1,7 +1,8 @@
|
|||||||
import React from 'react';
|
import React, { useEffect, useRef } from 'react';
|
||||||
import { useEditor } from '@craftjs/core';
|
import { useEditor } from '@craftjs/core';
|
||||||
import { labelStyle, inputStyle, sectionGap } from './shared';
|
import { labelStyle, inputStyle, sectionGap } from './shared';
|
||||||
import { AssetPicker } from '../../../ui/AssetPicker';
|
import { AssetPicker } from '../../../ui/AssetPicker';
|
||||||
|
import { useLayerFocus } from '../../left/LayerFocusContext';
|
||||||
|
|
||||||
interface Feature {
|
interface Feature {
|
||||||
title?: string; description?: string; icon?: string;
|
title?: string; description?: string; icon?: string;
|
||||||
@@ -27,10 +28,24 @@ export const FeaturesEditor: React.FC<{ selectedId: string; features: unknown }>
|
|||||||
mutate((arr) => [...arr, { title: 'New Feature', description: 'Describe this feature.', icon: '🔧', image: '', imageAlt: '', buttonText: '', buttonUrl: '' }]);
|
mutate((arr) => [...arr, { title: 'New Feature', description: 'Describe this feature.', icon: '🔧', image: '', imageAlt: '', buttonText: '', buttonUrl: '' }]);
|
||||||
const remove = (i: number) => mutate((arr) => { arr.splice(i, 1); return arr; });
|
const remove = (i: number) => mutate((arr) => { arr.splice(i, 1); return arr; });
|
||||||
|
|
||||||
|
// Layers panel -> array editor "scroll to this item" hookup. See
|
||||||
|
// ArrayItemFields.tsx for the generic-editor counterpart; this component
|
||||||
|
// keeps its own per-feature cards, so it tags/scrolls them directly.
|
||||||
|
const { focus } = useLayerFocus();
|
||||||
|
const rootRef = useRef<HTMLDivElement | null>(null);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!focus || focus.prop !== 'features') return;
|
||||||
|
const card = rootRef.current?.querySelector(`[data-array-item="features:${focus.index}"]`);
|
||||||
|
card?.scrollIntoView?.({ block: 'nearest', behavior: 'smooth' });
|
||||||
|
// `focus.nonce` is in the dep list so clicking the SAME row twice
|
||||||
|
// re-scrolls (the request object is otherwise identical).
|
||||||
|
}, [focus?.nonce, focus?.prop, focus?.index]);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div style={{ display: 'flex', flexDirection: 'column', gap: 8 }}>
|
<div ref={rootRef} style={{ display: 'flex', flexDirection: 'column', gap: 8 }}>
|
||||||
{list.map((feat, i) => (
|
{list.map((feat, i) => (
|
||||||
<div key={i} style={{ background: '#1e1e22', borderRadius: 6, padding: 8, display: 'flex', flexDirection: 'column', gap: 6 }}>
|
<div key={i} data-array-item={`features:${i}`} style={{ background: '#1e1e22', borderRadius: 6, padding: 8, display: 'flex', flexDirection: 'column', gap: 6 }}>
|
||||||
<div style={{ display: 'flex', gap: 4, alignItems: 'center' }}>
|
<div style={{ display: 'flex', gap: 4, alignItems: 'center' }}>
|
||||||
<input type="text" value={feat.title || ''} onChange={(e) => update(i, 'title', e.target.value)} placeholder="Title" style={{ ...inputStyle, flex: 1 }} />
|
<input type="text" value={feat.title || ''} onChange={(e) => update(i, 'title', e.target.value)} placeholder="Title" style={{ ...inputStyle, flex: 1 }} />
|
||||||
<button onClick={() => remove(i)} title="Remove" style={{ padding: '2px 8px', fontSize: 11, background: '#ef4444', color: '#fff', border: 'none', borderRadius: 4, cursor: 'pointer', flex: 'none' }}>×</button>
|
<button onClick={() => remove(i)} title="Remove" style={{ padding: '2px 8px', fontSize: 11, background: '#ef4444', color: '#fff', border: 'none', borderRadius: 4, cursor: 'pointer', flex: 'none' }}>×</button>
|
||||||
|
|||||||
@@ -1,8 +1,10 @@
|
|||||||
import React from 'react';
|
import React from 'react';
|
||||||
|
import { useEditor } from '@craftjs/core';
|
||||||
import {
|
import {
|
||||||
BG_COLORS,
|
BG_COLORS,
|
||||||
SPACING_PRESETS,
|
SPACING_PRESETS,
|
||||||
RADIUS_PRESETS,
|
RADIUS_PRESETS,
|
||||||
|
SHADOW_PRESETS,
|
||||||
} from '../../../constants/presets';
|
} from '../../../constants/presets';
|
||||||
import {
|
import {
|
||||||
StylePanelProps,
|
StylePanelProps,
|
||||||
@@ -10,21 +12,152 @@ import {
|
|||||||
ColorSwatchGrid,
|
ColorSwatchGrid,
|
||||||
PresetButtonGrid,
|
PresetButtonGrid,
|
||||||
CollapsibleSection,
|
CollapsibleSection,
|
||||||
|
ArrayPropEditor,
|
||||||
|
SpacingControl,
|
||||||
|
BorderControl,
|
||||||
|
BorderValue,
|
||||||
|
AnimationControl,
|
||||||
|
VisibilityControl,
|
||||||
|
buildBorderShorthand,
|
||||||
labelStyle,
|
labelStyle,
|
||||||
inputStyle,
|
inputStyle,
|
||||||
|
smallInputStyle,
|
||||||
btnActiveStyle,
|
btnActiveStyle,
|
||||||
sectionGap,
|
sectionGap,
|
||||||
useNodeProp,
|
useNodeProp,
|
||||||
} from './shared';
|
} from './shared';
|
||||||
|
|
||||||
|
/* The full sanitizeInputType (utils/escape.ts) allowlist, plus the two
|
||||||
|
fake "types" (textarea/select) that take their own ContactForm render
|
||||||
|
branch instead of an <input type>. Kept as a local list (rather than
|
||||||
|
importing the runtime array from utils/escape.ts) since this is
|
||||||
|
presentation-only -- the actual security boundary is enforced in
|
||||||
|
ContactForm.toHtml via sanitizeInputType, not here. */
|
||||||
|
const CONTACT_FIELD_TYPES = [
|
||||||
|
'text', 'email', 'tel', 'number', 'password', 'url', 'search', 'date',
|
||||||
|
'checkbox', 'radio', 'textarea', 'select',
|
||||||
|
];
|
||||||
|
|
||||||
|
const moveBtnStyle: React.CSSProperties = {
|
||||||
|
flex: 1, padding: '3px 6px', fontSize: 10, background: '#27272a', color: '#a1a1aa',
|
||||||
|
border: '1px solid #3f3f46', borderRadius: 4, cursor: 'pointer',
|
||||||
|
};
|
||||||
|
|
||||||
|
function parseBorderValue(v: unknown): BorderValue {
|
||||||
|
const s = typeof v === 'string' ? v.trim() : '';
|
||||||
|
if (!s || s === 'none') return { width: '', style: 'none', color: '' };
|
||||||
|
const m = s.match(/^(\S+)\s+(\S+)\s+(.+)$/);
|
||||||
|
if (!m) return { width: '', style: 'none', color: '' };
|
||||||
|
return { width: m[1], style: m[2], color: m[3] };
|
||||||
|
}
|
||||||
|
|
||||||
|
const SPACING_SIDE_KEYS: { side: 'top' | 'right' | 'bottom' | 'left'; suffix: 'Top' | 'Right' | 'Bottom' | 'Left' }[] = [
|
||||||
|
{ side: 'top', suffix: 'Top' },
|
||||||
|
{ side: 'right', suffix: 'Right' },
|
||||||
|
{ side: 'bottom', suffix: 'Bottom' },
|
||||||
|
{ side: 'left', suffix: 'Left' },
|
||||||
|
];
|
||||||
|
|
||||||
/* ---------- FORM ---------- */
|
/* ---------- FORM ---------- */
|
||||||
export const FormStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodeProps }) => {
|
export const FormStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodeProps }) => {
|
||||||
|
const { actions } = useEditor();
|
||||||
const { setProp, setPropStyle } = useNodeProp(selectedId);
|
const { setProp, setPropStyle } = useNodeProp(selectedId);
|
||||||
|
|
||||||
const style = nodeProps.style || {};
|
const style = nodeProps.style || {};
|
||||||
|
|
||||||
|
const updateField = (index: number, patch: Record<string, any>) => {
|
||||||
|
actions.setProp(selectedId, (props: any) => {
|
||||||
|
const updated = [...(props.fields || [])];
|
||||||
|
updated[index] = { ...updated[index], ...patch };
|
||||||
|
props.fields = updated;
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
|
const moveField = (index: number, direction: -1 | 1) => {
|
||||||
|
actions.setProp(selectedId, (props: any) => {
|
||||||
|
const updated = [...(props.fields || [])];
|
||||||
|
const newIndex = index + direction;
|
||||||
|
if (newIndex < 0 || newIndex >= updated.length) return;
|
||||||
|
[updated[index], updated[newIndex]] = [updated[newIndex], updated[index]];
|
||||||
|
props.fields = updated;
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<>
|
||||||
|
{/* ContactForm field editor: add/remove/reorder fields, set each
|
||||||
|
field's label, name, type (full allowlist + textarea/select),
|
||||||
|
options (select only), and required flag. */}
|
||||||
|
{nodeProps.fields !== undefined && Array.isArray(nodeProps.fields) && (
|
||||||
|
<CollapsibleSection title="Fields">
|
||||||
|
<ArrayPropEditor
|
||||||
|
selectedId={selectedId}
|
||||||
|
propKey="fields"
|
||||||
|
items={nodeProps.fields}
|
||||||
|
renderItem={(item: any, index: number) => (
|
||||||
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 4 }}>
|
||||||
|
<input
|
||||||
|
type="text"
|
||||||
|
value={item.label || ''}
|
||||||
|
onChange={(e) => updateField(index, { label: e.target.value })}
|
||||||
|
placeholder="Label"
|
||||||
|
style={smallInputStyle}
|
||||||
|
/>
|
||||||
|
<input
|
||||||
|
type="text"
|
||||||
|
value={item.name || ''}
|
||||||
|
onChange={(e) => updateField(index, { name: e.target.value })}
|
||||||
|
placeholder="Field name (e.g. email)"
|
||||||
|
style={smallInputStyle}
|
||||||
|
/>
|
||||||
|
<input
|
||||||
|
type="text"
|
||||||
|
value={item.placeholder || ''}
|
||||||
|
onChange={(e) => updateField(index, { placeholder: e.target.value })}
|
||||||
|
placeholder="Placeholder"
|
||||||
|
style={smallInputStyle}
|
||||||
|
/>
|
||||||
|
<select
|
||||||
|
value={item.type || 'text'}
|
||||||
|
onChange={(e) => updateField(index, { type: e.target.value })}
|
||||||
|
style={{ ...smallInputStyle, cursor: 'pointer' }}
|
||||||
|
>
|
||||||
|
{CONTACT_FIELD_TYPES.map((t) => <option key={t} value={t}>{t}</option>)}
|
||||||
|
</select>
|
||||||
|
{item.type === 'select' && (
|
||||||
|
<input
|
||||||
|
type="text"
|
||||||
|
value={(item.options || []).join(', ')}
|
||||||
|
onChange={(e) => updateField(index, {
|
||||||
|
options: e.target.value.split(',').map((s: string) => s.trim()).filter(Boolean),
|
||||||
|
})}
|
||||||
|
placeholder="Options (comma-separated)"
|
||||||
|
style={smallInputStyle}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
<label style={{ display: 'flex', alignItems: 'center', gap: 6, fontSize: 11, color: '#e4e4e7', cursor: 'pointer' }}>
|
||||||
|
<input
|
||||||
|
type="checkbox"
|
||||||
|
checked={!!item.required}
|
||||||
|
onChange={(e) => updateField(index, { required: e.target.checked })}
|
||||||
|
/>
|
||||||
|
Required
|
||||||
|
</label>
|
||||||
|
<div style={{ display: 'flex', gap: 4 }}>
|
||||||
|
<button disabled={index === 0} onClick={() => moveField(index, -1)} style={{ ...moveBtnStyle, opacity: index === 0 ? 0.4 : 1 }} title="Move up">
|
||||||
|
<i className="fa fa-arrow-up" />
|
||||||
|
</button>
|
||||||
|
<button disabled={index === nodeProps.fields.length - 1} onClick={() => moveField(index, 1)} style={{ ...moveBtnStyle, opacity: index === nodeProps.fields.length - 1 ? 0.4 : 1 }} title="Move down">
|
||||||
|
<i className="fa fa-arrow-down" />
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
emptyItem={{ type: 'text', label: 'New Field', name: 'field', placeholder: '', required: false }}
|
||||||
|
/>
|
||||||
|
</CollapsibleSection>
|
||||||
|
)}
|
||||||
|
|
||||||
{/* Contact-form relay: where submissions are emailed. Present on ContactForm
|
{/* Contact-form relay: where submissions are emailed. Present on ContactForm
|
||||||
and FormContainer (both have recipientEmail/thankYouUrl props). */}
|
and FormContainer (both have recipientEmail/thankYouUrl props). */}
|
||||||
{nodeProps.recipientEmail !== undefined && (
|
{nodeProps.recipientEmail !== undefined && (
|
||||||
@@ -43,13 +176,35 @@ export const FormStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodeProp
|
|||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{/* Form action/method */}
|
{/* Form action/method (FormContainer). SearchBar also has an `action`
|
||||||
{nodeProps.action !== undefined && (
|
prop but is distinguished via its unique `showButton` prop -- see
|
||||||
|
the dedicated Search block below -- so it doesn't get this label. */}
|
||||||
|
{nodeProps.action !== undefined && nodeProps.showButton === undefined && (
|
||||||
<div style={sectionGap}>
|
<div style={sectionGap}>
|
||||||
<label style={labelStyle}>Form Action URL</label>
|
<label style={labelStyle}>Form Action URL</label>
|
||||||
<input type="text" value={nodeProps.action || ''} onChange={(e) => setProp('action', e.target.value)} placeholder="https://..." style={inputStyle} />
|
<input type="text" value={nodeProps.action || ''} onChange={(e) => setProp('action', e.target.value)} placeholder="https://..." style={inputStyle} />
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
|
{/* SearchBar: where the GET search request is submitted. */}
|
||||||
|
{nodeProps.showButton !== undefined && nodeProps.action !== undefined && (
|
||||||
|
<div style={sectionGap}>
|
||||||
|
<label style={labelStyle}>Search Results Page</label>
|
||||||
|
<input type="text" value={nodeProps.action || ''} onChange={(e) => setProp('action', e.target.value)} placeholder="/ (site root) or /search" style={inputStyle} />
|
||||||
|
<p style={{ fontSize: 10, color: '#71717a', margin: '4px 0 0' }}>
|
||||||
|
Submits a GET request with the query as ?q=... to this URL.
|
||||||
|
</p>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
{nodeProps.showButton !== undefined && (
|
||||||
|
<div style={sectionGap}>
|
||||||
|
<label style={{ ...labelStyle, display: 'flex', alignItems: 'center', gap: 6, cursor: 'pointer' }}>
|
||||||
|
<input type="checkbox" checked={nodeProps.showButton !== false} onChange={(e) => setProp('showButton', e.target.checked)} />
|
||||||
|
Show Search Button
|
||||||
|
</label>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
{nodeProps.method !== undefined && (
|
{nodeProps.method !== undefined && (
|
||||||
<div style={sectionGap}>
|
<div style={sectionGap}>
|
||||||
<label style={labelStyle}>Method</label>
|
<label style={labelStyle}>Method</label>
|
||||||
@@ -142,6 +297,64 @@ export const FormStylePanel: React.FC<StylePanelProps> = ({ selectedId, nodeProp
|
|||||||
<PresetButtonGrid presets={RADIUS_PRESETS} activeValue={style.borderRadius as string} onSelect={(v) => setPropStyle('borderRadius', v)} />
|
<PresetButtonGrid presets={RADIUS_PRESETS} activeValue={style.borderRadius as string} onSelect={(v) => setPropStyle('borderRadius', v)} />
|
||||||
</div>
|
</div>
|
||||||
</CollapsibleSection>
|
</CollapsibleSection>
|
||||||
|
|
||||||
|
{/* Box model: margin/padding (per-side), border, shadow, opacity --
|
||||||
|
common enh-batch rollout, applies to the whole form family since
|
||||||
|
they all spread `style` onto their root element. */}
|
||||||
|
<CollapsibleSection title="Spacing, Border & Effects" defaultOpen={false}>
|
||||||
|
<SpacingControl
|
||||||
|
label="Margin"
|
||||||
|
value={{ top: style.marginTop, right: style.marginRight, bottom: style.marginBottom, left: style.marginLeft }}
|
||||||
|
onChange={(side, v) => setPropStyle(`margin${SPACING_SIDE_KEYS.find((s) => s.side === side)!.suffix}`, v)}
|
||||||
|
/>
|
||||||
|
<SpacingControl
|
||||||
|
label="Padding (per side)"
|
||||||
|
value={{ top: style.paddingTop, right: style.paddingRight, bottom: style.paddingBottom, left: style.paddingLeft }}
|
||||||
|
onChange={(side, v) => setPropStyle(`padding${SPACING_SIDE_KEYS.find((s) => s.side === side)!.suffix}`, v)}
|
||||||
|
/>
|
||||||
|
<BorderControl
|
||||||
|
value={parseBorderValue(style.border)}
|
||||||
|
onChange={(v) => setPropStyle('border', buildBorderShorthand(v))}
|
||||||
|
/>
|
||||||
|
<div className="guided-section">
|
||||||
|
<SectionLabel>Box Shadow</SectionLabel>
|
||||||
|
<PresetButtonGrid presets={SHADOW_PRESETS} activeValue={style.boxShadow as string} onSelect={(v) => setPropStyle('boxShadow', v)} />
|
||||||
|
</div>
|
||||||
|
<div className="guided-section">
|
||||||
|
<SectionLabel>Opacity</SectionLabel>
|
||||||
|
<input
|
||||||
|
type="range"
|
||||||
|
min={0}
|
||||||
|
max={100}
|
||||||
|
value={style.opacity !== undefined && style.opacity !== '' ? Math.round(Number(style.opacity) * 100) : 100}
|
||||||
|
onChange={(e) => setPropStyle('opacity', String(Number(e.target.value) / 100))}
|
||||||
|
style={{ width: '100%' }}
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
</CollapsibleSection>
|
||||||
|
|
||||||
|
{/* Animation & Visibility -- gated on the blank/false defaults added to
|
||||||
|
each owned component's craft.props (ContactForm, FormContainer,
|
||||||
|
InputField, TextareaField, FormButton, SubscribeForm, SearchBar).
|
||||||
|
No toHtml change needed: the export's buildDataAttrs() already
|
||||||
|
emits data-animation/data-hide-* from these exact prop names for
|
||||||
|
every node. */}
|
||||||
|
{nodeProps.animation !== undefined && (
|
||||||
|
<CollapsibleSection title="Animation & Visibility" defaultOpen={false}>
|
||||||
|
<AnimationControl
|
||||||
|
value={{ animation: nodeProps.animation, animationDelay: nodeProps.animationDelay }}
|
||||||
|
onChange={(v) => { setProp('animation', v.animation); setProp('animationDelay', v.animationDelay); }}
|
||||||
|
/>
|
||||||
|
<VisibilityControl
|
||||||
|
value={{ hideOnDesktop: nodeProps.hideOnDesktop, hideOnTablet: nodeProps.hideOnTablet, hideOnMobile: nodeProps.hideOnMobile }}
|
||||||
|
onChange={(v) => {
|
||||||
|
setProp('hideOnDesktop', v.hideOnDesktop);
|
||||||
|
setProp('hideOnTablet', v.hideOnTablet);
|
||||||
|
setProp('hideOnMobile', v.hideOnMobile);
|
||||||
|
}}
|
||||||
|
/>
|
||||||
|
</CollapsibleSection>
|
||||||
|
)}
|
||||||
</>
|
</>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -17,12 +17,13 @@ import {
|
|||||||
useNodeProp,
|
useNodeProp,
|
||||||
} from './shared';
|
} from './shared';
|
||||||
import { ArrayItemFieldsEditor } from './ArrayItemFields';
|
import { ArrayItemFieldsEditor } from './ArrayItemFields';
|
||||||
|
import { HtmlCodeField } from './HtmlCodeField';
|
||||||
|
|
||||||
/* ---------- SMART GENERIC PROPS EDITOR (Fallback) ---------- */
|
/* ---------- SMART GENERIC PROPS EDITOR (Fallback) ---------- */
|
||||||
export const GenericPropsEditor: React.FC<{ selectedId: string; nodeProps: Record<string, any>; typeName: string }> = ({
|
export const GenericPropsEditor: React.FC<{ selectedId: string; nodeProps: Record<string, any>; typeName: string }> = ({
|
||||||
selectedId, nodeProps, typeName,
|
selectedId, nodeProps, typeName,
|
||||||
}) => {
|
}) => {
|
||||||
const SKIP_PROPS = new Set(['style', 'children', 'cssId', 'cssClass']);
|
const SKIP_PROPS = new Set(['style', 'children', 'cssId', 'cssClass', 'code']);
|
||||||
|
|
||||||
const { setProp: setPropValue, setPropStyle: setStyleValue } = useNodeProp(selectedId);
|
const { setProp: setPropValue, setPropStyle: setStyleValue } = useNodeProp(selectedId);
|
||||||
|
|
||||||
@@ -35,9 +36,15 @@ export const GenericPropsEditor: React.FC<{ selectedId: string; nodeProps: Recor
|
|||||||
const arrayProps = allProps.filter(([_, val]) => Array.isArray(val));
|
const arrayProps = allProps.filter(([_, val]) => Array.isArray(val));
|
||||||
|
|
||||||
const style = nodeProps.style || {};
|
const style = nodeProps.style || {};
|
||||||
|
const hasCodeProp = typeof nodeProps.code === 'string';
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<>
|
||||||
|
{/* Raw HTML (HtmlBlock's `code` prop) -- dedicated CodeEditor modal */}
|
||||||
|
{hasCodeProp && (
|
||||||
|
<HtmlCodeField value={nodeProps.code} onChange={(v) => setPropValue('code', v)} />
|
||||||
|
)}
|
||||||
|
|
||||||
{/* String props */}
|
{/* String props */}
|
||||||
{stringProps.length > 0 && (
|
{stringProps.length > 0 && (
|
||||||
<CollapsibleSection title="Properties">
|
<CollapsibleSection title="Properties">
|
||||||
|
|||||||
@@ -0,0 +1,82 @@
|
|||||||
|
import React, { useRef, useState } from 'react';
|
||||||
|
import { CollapsibleSection, sectionGap } from './shared';
|
||||||
|
import { Modal } from '../../../ui/Modal';
|
||||||
|
import { CodeEditor, type CodeEditorHandle } from '../../../ui/CodeEditor';
|
||||||
|
import { HtmlToolbar } from './HtmlToolbar';
|
||||||
|
import { formatHtml } from '../../../utils/format-html';
|
||||||
|
|
||||||
|
/* "Edit HTML" modal for the HtmlBlock `code` prop. `code` is raw HTML
|
||||||
|
(potentially many lines, embedded <style>/<script>), so it gets a
|
||||||
|
dedicated syntax-highlighted CodeEditor in a modal rather than the
|
||||||
|
generic single-line/textarea string-prop rendering. */
|
||||||
|
export const HtmlCodeField: React.FC<{ value: string; onChange: (v: string) => void }> = ({ value, onChange }) => {
|
||||||
|
const [open, setOpen] = useState(false);
|
||||||
|
const editorRef = useRef<CodeEditorHandle>(null);
|
||||||
|
const handleFormat = (): void => {
|
||||||
|
const current = editorRef.current?.getValue() ?? value;
|
||||||
|
onChange(formatHtml(current));
|
||||||
|
};
|
||||||
|
return (
|
||||||
|
<CollapsibleSection title="HTML Code">
|
||||||
|
<div style={sectionGap}>
|
||||||
|
<button
|
||||||
|
onClick={() => setOpen(true)}
|
||||||
|
style={{
|
||||||
|
width: '100%', padding: '8px 12px', fontSize: 12, fontWeight: 600,
|
||||||
|
display: 'flex', alignItems: 'center', justifyContent: 'center', gap: 6,
|
||||||
|
background: '#27272a', color: '#e4e4e7', border: '1px solid #3f3f46',
|
||||||
|
borderRadius: 6, cursor: 'pointer',
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<i className="fa fa-code" /> Edit HTML
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
<Modal open={open} onClose={() => setOpen(false)} width="min(720px, 90vw)">
|
||||||
|
<div
|
||||||
|
style={{
|
||||||
|
background: 'var(--color-bg-surface)',
|
||||||
|
border: '1px solid var(--color-border)',
|
||||||
|
borderRadius: 12,
|
||||||
|
boxShadow: '0 20px 60px rgba(0,0,0,0.5)',
|
||||||
|
display: 'flex',
|
||||||
|
flexDirection: 'column',
|
||||||
|
overflow: 'hidden',
|
||||||
|
}}
|
||||||
|
onClick={(e) => e.stopPropagation()}
|
||||||
|
>
|
||||||
|
<div style={{
|
||||||
|
display: 'flex', alignItems: 'center', justifyContent: 'space-between',
|
||||||
|
padding: '14px 16px', borderBottom: '1px solid var(--color-border)',
|
||||||
|
}}>
|
||||||
|
<div style={{ fontSize: 14, fontWeight: 600, color: 'var(--color-text)' }}>Edit HTML</div>
|
||||||
|
<button
|
||||||
|
onClick={() => setOpen(false)}
|
||||||
|
style={{
|
||||||
|
width: 28, height: 28, display: 'inline-flex', alignItems: 'center', justifyContent: 'center',
|
||||||
|
background: 'none', border: '1px solid var(--color-border)', borderRadius: 6,
|
||||||
|
color: 'var(--color-text-muted)', cursor: 'pointer', fontSize: 13,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<i className="fa fa-times" />
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
<div style={{ padding: 16 }}>
|
||||||
|
<HtmlToolbar editorRef={editorRef} onFormat={handleFormat} />
|
||||||
|
<CodeEditor ref={editorRef} value={value} onChange={onChange} language="html" height={420} />
|
||||||
|
</div>
|
||||||
|
<div style={{ padding: '10px 16px', borderTop: '1px solid var(--color-border)', display: 'flex', justifyContent: 'flex-end' }}>
|
||||||
|
<button
|
||||||
|
onClick={() => setOpen(false)}
|
||||||
|
style={{
|
||||||
|
padding: '7px 20px', fontSize: 13, fontWeight: 600,
|
||||||
|
background: 'var(--color-accent)', color: '#fff', border: 'none', borderRadius: 6, cursor: 'pointer',
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Done
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
</Modal>
|
||||||
|
</CollapsibleSection>
|
||||||
|
);
|
||||||
|
};
|
||||||
@@ -0,0 +1,38 @@
|
|||||||
|
import { describe, test, expect, vi } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
|
||||||
|
vi.mock('@craftjs/core', () => ({
|
||||||
|
useEditor: () => ({ actions: { setProp: vi.fn() }, query: {} }),
|
||||||
|
}));
|
||||||
|
|
||||||
|
import { HtmlStylePanel } from './HtmlStylePanel';
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
|
||||||
|
function render(ui: React.ReactElement) {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(ui);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('HtmlStylePanel', () => {
|
||||||
|
test('renders the Edit HTML control', () => {
|
||||||
|
render(<HtmlStylePanel selectedId="n1" nodeProps={{ code: '<p>x</p>', style: {} }} />);
|
||||||
|
expect(container.textContent).toContain('Edit HTML');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('renders NO colour or style controls (they never reach the live page)', () => {
|
||||||
|
render(<HtmlStylePanel selectedId="n1" nodeProps={{ code: '<p>x</p>', style: {} }} />);
|
||||||
|
expect(container.querySelector('input[type="color"]')).toBeNull();
|
||||||
|
expect(container.textContent).not.toContain('Background');
|
||||||
|
expect(container.textContent).not.toContain('Text Color');
|
||||||
|
expect(container.textContent).not.toContain('Padding');
|
||||||
|
expect(container.textContent).not.toContain('Border Radius');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,30 @@
|
|||||||
|
import React from 'react';
|
||||||
|
import { useNodeProp } from './shared';
|
||||||
|
import { HtmlCodeField } from './HtmlCodeField';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The HTML block's entire style panel.
|
||||||
|
*
|
||||||
|
* Deliberately ONLY the code editor. `HtmlBlock.toHtml()` emits nothing but
|
||||||
|
* the purified `code`, so every colour/padding/alignment control the generic
|
||||||
|
* editor used to offer here was dead on the published page. Styling an HTML
|
||||||
|
* block is done inside the user's own markup.
|
||||||
|
*/
|
||||||
|
export const HtmlStylePanel: React.FC<{ selectedId: string; nodeProps: Record<string, any> }> = ({
|
||||||
|
selectedId,
|
||||||
|
nodeProps,
|
||||||
|
}) => {
|
||||||
|
const { setProp: setPropValue } = useNodeProp(selectedId);
|
||||||
|
return (
|
||||||
|
<>
|
||||||
|
<HtmlCodeField
|
||||||
|
value={typeof nodeProps.code === 'string' ? nodeProps.code : ''}
|
||||||
|
onChange={(v) => setPropValue('code', v)}
|
||||||
|
/>
|
||||||
|
<p style={{ fontSize: 10, color: 'var(--color-text-dim)', lineHeight: 1.4, padding: '0 2px' }}>
|
||||||
|
Style this block inside your own markup — a wrapper set here would show
|
||||||
|
in the editor but not on the published page.
|
||||||
|
</p>
|
||||||
|
</>
|
||||||
|
);
|
||||||
|
};
|
||||||
@@ -0,0 +1,65 @@
|
|||||||
|
import { describe, test, expect, vi } from 'vitest';
|
||||||
|
import React from 'react';
|
||||||
|
import { createRoot, Root } from 'react-dom/client';
|
||||||
|
import { act } from 'react-dom/test-utils';
|
||||||
|
import { HtmlToolbar, SNIPPETS } from './HtmlToolbar';
|
||||||
|
import type { CodeEditorHandle } from '../../../ui/CodeEditor';
|
||||||
|
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let root: Root;
|
||||||
|
|
||||||
|
function render(ui: React.ReactElement) {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.appendChild(container);
|
||||||
|
act(() => {
|
||||||
|
root = createRoot(container);
|
||||||
|
root.render(ui);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function fakeHandle() {
|
||||||
|
return { insertAtCursor: vi.fn(), getValue: vi.fn(() => '') } as unknown as CodeEditorHandle;
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('HtmlToolbar', () => {
|
||||||
|
test('every snippet button inserts its snippet with its caret offset', () => {
|
||||||
|
const handle = fakeHandle();
|
||||||
|
const ref = { current: handle } as React.RefObject<CodeEditorHandle>;
|
||||||
|
render(<HtmlToolbar editorRef={ref} onFormat={vi.fn()} />);
|
||||||
|
|
||||||
|
for (const snippet of SNIPPETS) {
|
||||||
|
const btn = container.querySelector(`[data-snippet="${snippet.label}"]`) as HTMLButtonElement;
|
||||||
|
expect(btn, `missing button for ${snippet.label}`).not.toBeNull();
|
||||||
|
act(() => { btn.click(); });
|
||||||
|
expect(handle.insertAtCursor).toHaveBeenCalledWith(snippet.text, snippet.caret);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the colour input inserts a style attribute at the caret', () => {
|
||||||
|
const handle = fakeHandle();
|
||||||
|
const ref = { current: handle } as React.RefObject<CodeEditorHandle>;
|
||||||
|
render(<HtmlToolbar editorRef={ref} onFormat={vi.fn()} />);
|
||||||
|
|
||||||
|
const colour = container.querySelector('input[type="color"]') as HTMLInputElement;
|
||||||
|
colour.value = '#ff8800';
|
||||||
|
act(() => { colour.dispatchEvent(new Event('input', { bubbles: true })); });
|
||||||
|
|
||||||
|
expect(handle.insertAtCursor).toHaveBeenCalledWith(' style="color: #ff8800"');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('Format calls onFormat', () => {
|
||||||
|
const onFormat = vi.fn();
|
||||||
|
const ref = { current: fakeHandle() } as React.RefObject<CodeEditorHandle>;
|
||||||
|
render(<HtmlToolbar editorRef={ref} onFormat={onFormat} />);
|
||||||
|
const btn = container.querySelector('[data-action="format"]') as HTMLButtonElement;
|
||||||
|
act(() => { btn.click(); });
|
||||||
|
expect(onFormat).toHaveBeenCalledTimes(1);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a null editor ref is a no-op, not a crash', () => {
|
||||||
|
const ref = { current: null } as React.RefObject<CodeEditorHandle>;
|
||||||
|
render(<HtmlToolbar editorRef={ref} onFormat={vi.fn()} />);
|
||||||
|
const btn = container.querySelector('[data-snippet="div"]') as HTMLButtonElement;
|
||||||
|
expect(() => act(() => { btn.click(); })).not.toThrow();
|
||||||
|
});
|
||||||
|
});
|
||||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user