rho_n
/
hpr_generator
4
2
Fork 1
Code Issues 33 Pull Requests Projects 1 Releases Wiki Activity

Future episodes are not being produced #123

New Issue
Closed
opened 2023-06-17 16:19:46 +00:00 by ken_fallon · 9 comments
ken_fallon commented 2023-06-17 16:19:46 +00:00
Collaborator
Copy Link

Shows from the future feed are considered to be "posted", and as such should also be published to the website.

Actual behavior
https://hackerpublicradio.org/eps/hpr4080/index.html

Not Found

The requested URL was not found on this server.

Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.

Shows from the future feed are considered to be "posted", and as such should also be published to the website. Actual behavior https://hackerpublicradio.org/eps/hpr4080/index.html Not Found The requested URL was not found on this server. Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.
rho_n was assigned by ken_fallon 2023-06-17 16:19:46 +00:00
rho_n changed title from Future episodes are not been produced to Future episodes are not being produced 2023-06-18 10:26:30 +00:00
rho_n added the
Bug Found
 label 2023-06-18 10:51:24 +00:00
rho_n commented 2023-06-18 10:52:32 +00:00
Owner
Copy Link

@ken_fallon and @davmo do we allow comments on future show?

@ken_fallon and @davmo do we allow comments on future show?
rho_n commented 2023-06-18 10:55:21 +00:00
Owner
Copy Link

@ken_fallon and @davmo should the show navigation (prev show/next show) links work, be broken, or can we remove them for future shows?

@ken_fallon and @davmo should the show navigation (prev show/next show) links work, be broken, or can we remove them for future shows?
davmo commented 2023-06-19 08:11:24 +00:00
Collaborator
Copy Link

We have allowed "future comments" up to the changeover, but the comment form has required more questions to be answered. There haven't been a huge lot of comments to future shows, but the feature has been used.

We have allowed "future comments" up to the changeover, but the comment form has required more questions to be answered. There haven't been a huge lot of comments to future shows, but the feature has been used.
ken_fallon commented 2023-06-21 19:17:23 +00:00
Author
Collaborator
Copy Link

Yes they can be broken for now. Once we get it working we can see what solutions present themselves.

Yes they can be broken for now. Once we get it working we can see what solutions present themselves.
davmo commented 2023-06-21 19:24:17 +00:00
Collaborator
Copy Link

@ken_fallon and @davmo should the show navigation (prev show/next show) links work, be broken, or can we remove them for future shows?

Ha! Yes. It's always concerned me that these haven't adapted to the fact that the show is a future show. I vote that we drop the prev/next and possibly have something that gets you to the latest show.

> @ken_fallon and @davmo should the show navigation (prev show/next show) links work, be broken, or can we remove them for future shows? Ha! Yes. It's always concerned me that these haven't adapted to the fact that the show is a future show. I vote that we drop the prev/next and possibly have something that gets you to the latest show.
ken_fallon commented 2023-06-22 07:27:24 +00:00
Author
Collaborator
Copy Link

OK then drop the prev/next for the future shows

OK then drop the prev/next for the future shows
ken_fallon commented 2023-06-26 18:54:34 +00:00
Author
Collaborator
Copy Link

Dave Morriss investigated and reported "The function get_ids_from_db in site-generator runs the template ids-episode.tpl.html which invokes the query in queries-ids-episode-mysql.tpl.html and gets a CSV list of episode numbers. A loop at line 185 in site-generator then processes this list of pages."

I removed the where eps.date < date(\'now\', \'+1 days\') from the query and the future shows generated.

While it has produced the pages, it is not ideal as the next, previous and last are not working correctly.

Dave Morriss investigated and reported "The function get_ids_from_db in site-generator runs the template ids-episode.tpl.html which invokes the query in queries-ids-episode-mysql.tpl.html and gets a CSV list of episode numbers. A loop at line 185 in site-generator then processes this list of pages." I removed the `where eps.date < date(\'now\', \'+1 days\')` from the query and the future shows generated. While it has produced the pages, it is not ideal as the next, previous and last are not working correctly.
davmo commented 2023-06-26 20:27:16 +00:00
Collaborator
Copy Link

Further refinement:

  • Shows that are currently being processed are being (or going to be) flagged as "not ready yet".
  • There are now more steps involved with preparing a show for access, and we don't want to release prematurely
  • The flag will be changed to "ready" once all the steps have been completed
  • The static site generator needs to take this into account

Summary: only make shows available where valid = 1

Further refinement: * Shows that are currently being processed are being (or going to be) flagged as "not ready yet". * There are now more steps involved with preparing a show for access, and we don't want to release prematurely * The flag will be changed to "ready" once all the steps have been completed * The static site generator needs to take this into account Summary: only make shows available where `valid = 1`
davmo added a new dependency 2023-07-23 15:55:29 +00:00
#145 Various bug fixes
davmo commented 2023-07-31 10:42:33 +00:00
Collaborator
Copy Link

Future shows are visible and the comment forms are changed to the more complex one. We still include the 'first, previous, next, last' links in these shows.

Most of the issues were dealt with on the hub and in the updates for issue #145.

Future shows are visible and the comment forms are changed to the more complex one. We still include the 'first, previous, next, last' links in these shows. Most of the issues were dealt with on the `hub` and in the updates for issue #145.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
167_Several_templates_use_non-existent_absolute_url
I145_Various_bug_fixes
I123_Future_episodes_are_not_being_produced
I30-Series_name_for_filename
2023-03
2023-02
Labels
Clear labels   
Bug Found

For issues related to the code or the content of the created HTML files

  
Feature Request

   
General Discussion

For discussing HPR site generation in general

  
Help Request

For issues running or installing the site-generator

No Label
Bug Found
Feature Request
General Discussion
Help Request
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
rho_n
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#145 Various bug fixes
rho_n/hpr_generator
Reference: rho_n/hpr_generator#123
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?