I112_Add_support_for_a_different_php_basename #113

ken_fallon · 2023-05-30T07:15:00Z

ken_fallon commented

2023-05-30 07:15:00 +00:00

Changes to allow for the separation of static content from dynamic(php) content.

ken_fallon added 3 commits 2023-05-30 07:15:01 +00:00

db5774f642 Added support for having a different php FQDN location from the main site via php_baseurl

52c5d02dbc Add config entry for php_baseurl

69055d6e9c Added php_baseurl

rho_n commented

2023-05-30 14:55:19 +00:00

I see the reason for the php_baseurl and implementation looks ok.

Although I would replace all the

<!--% absolute_path(php_baseurl) %-->

with

<!--% php_baseurl %-->

The absolute_path macro was more to deal with absolute paths when using the baseurl variable.

So for the Upload links in it should be:

<a href="<!--% php_baseurl %-->calendar.php"><strong>⇧Upload⇧</strong></a>

I see the reason for the php_baseurl and implementation looks ok. Although I would replace all the ```  ``` with ```  ``` The absolute_path macro was more to deal with absolute paths when using the baseurl variable. So for the Upload links in it should be: ``` <a href="calendar.php"><strong>⇧Upload⇧</strong></a> ```

ken_fallon added 1 commit 2023-05-30 16:00:04 +00:00

f95ff21c5e Remove references to absolute_path(php_baseurl)

ken_fallon commented

2023-05-30 16:00:31 +00:00

Well spotted. I fixed that.

ken_fallon added 1 commit 2023-05-30 18:10:42 +00:00

6211b9a033 Change dynamic site name to hub.hackerpublicradio.com

ken_fallon added 1 commit 2023-05-30 18:49:03 +00:00

d828cdbce8 Rename php_baseurl to hub_baseurl

ken_fallon added 1 commit 2023-05-31 08:25:51 +00:00

c9510516f1 Change php_baseurl to hub_baseurl in the template files

ken_fallon merged commit de58d9dc61 into main