Fixing issue #140 #155

Merged
ken_fallon merged 1 commits from I140_Convert_the_RSS_feeds_from_php_to_the_static_site into main 2023-08-20 15:07:33 +00:00
Collaborator

site-generator:

Cosmetic adjustments. Additions to the POD documentation.
Additions to module list.
Additions to work better with UTF-8.
Addition of functions 'parse_csv' and 'xml_entity'

templates/queries-episodes-sqlite.tpl.html:
templates/shared-utils.tpl.html:

Cosmetic changes

templates/rss-query-hpr-mysql.tpl.xml:
templates/rss-query-hpr-sqlite.tpl.xml:
templates/rss-query-hpr_total-mysql.tpl.xml:
templates/rss-query-hpr_total-sqlite.tpl.xml:

Enhancements to allow the query to collect the audio length from the
'assets' table. The audio file extension is passed as an argument to
the 'execute' statement.

templates/rss.tpl.xml:

Cosmetic changes
Changed one 'php' URL to 'html'.

templates/shared-episode-summary.tpl.html:

Change to 'display_tags' macro to turn the 'eps.tags' field into
a list of links. This works, but needs further development because
using the tag strings as anchor ids is not reliable.

templates/shared-item.tpl.xml:

Cosmetic changes.
Addition of filter 'HTML.strip' which is used as a means of removing
HTML tags from '<itunes:summary>' strings.
Using new filter 'xml_entity' which converts all non-ASCII
characters in the notes to numeric hexadecimal entities for
'<itunes:summary>'.
The '<enclosure>' tag now uses 'episode.length' rather than
'episode.duration' which has been extracted from the 'assets' table.
site-generator: Cosmetic adjustments. Additions to the POD documentation. Additions to module list. Additions to work better with UTF-8. Addition of functions 'parse_csv' and 'xml_entity' templates/queries-episodes-sqlite.tpl.html: templates/shared-utils.tpl.html: Cosmetic changes templates/rss-query-hpr-mysql.tpl.xml: templates/rss-query-hpr-sqlite.tpl.xml: templates/rss-query-hpr_total-mysql.tpl.xml: templates/rss-query-hpr_total-sqlite.tpl.xml: Enhancements to allow the query to collect the audio length from the 'assets' table. The audio file extension is passed as an argument to the 'execute' statement. templates/rss.tpl.xml: Cosmetic changes Changed one 'php' URL to 'html'. templates/shared-episode-summary.tpl.html: Change to 'display_tags' macro to turn the 'eps.tags' field into a list of links. This works, but needs further development because using the tag strings as anchor ids is not reliable. templates/shared-item.tpl.xml: Cosmetic changes. Addition of filter 'HTML.strip' which is used as a means of removing HTML tags from '<itunes:summary>' strings. Using new filter 'xml_entity' which converts all non-ASCII characters in the notes to numeric hexadecimal entities for '<itunes:summary>'. The '<enclosure>' tag now uses 'episode.length' rather than 'episode.duration' which has been extracted from the 'assets' table.
davmo added 1 commit 2023-08-19 13:01:12 +00:00
dc138596ea Fixing issue #140
site-generator:

    Cosmetic adjustments. Additions to the POD documentation.
    Additions to module list.
    Additions to work better with UTF-8.
    Addition of functions 'parse_csv' and 'xml_entity'

templates/queries-episodes-sqlite.tpl.html:
templates/shared-utils.tpl.html:

    Cosmetic changes

templates/rss-query-hpr-mysql.tpl.xml:
templates/rss-query-hpr-sqlite.tpl.xml:
templates/rss-query-hpr_total-mysql.tpl.xml:
templates/rss-query-hpr_total-sqlite.tpl.xml:

    Enhancements to allow the query to collect the audio length from the
    'assets' table. The audio file extension is passed as an argument to
    the 'execute' statement.

templates/rss.tpl.xml:

    Cosmetic changes
    Changed one 'php' URL to 'html'.

templates/shared-episode-summary.tpl.html:

    Change to 'display_tags' macro to turn the 'eps.tags' field into
    a list of links. This works, but needs further development because
    using the tag strings as anchor ids is not reliable.

templates/shared-item.tpl.xml:

    Cosmetic changes.
    Addition of filter 'HTML.strip' which is used as a means of removing
    HTML tags from '<itunes:summary>' strings.
    Using new filter 'xml_entity' which converts all non-ASCII
    characters in the notes to numeric hexadecimal entities for
    '<itunes:summary>'.
    The '<enclosure>' tag now uses 'episode.length' rather than
    'episode.duration' which has been extracted from the 'assets' table.
ken_fallon reviewed 2023-08-20 15:01:59 +00:00
@ -206,0 +203,4 @@
if ($page_config->{'multipage'} && $page_config->{'multipage'} eq 'true') {
# Empty arrayref bug fixed, so count is reduced by 1
# was: if (scalar @{$parsed_arg{'ids'}} == 1) {
Collaborator

Just remove lines like this - we have git for history.

Just remove lines like this - we have git for history.
Author
Collaborator

Yes, true. However, would the git history have explained why the change was made? Personally I would have had to revert to the broken version, and debug it again to be sure.

I do have personal notes about this I admit, so happy to comply if you prefer. Also, having the change annotated, committed and then deleted also gives history.

Yes, true. However, would the git history have explained why the change was made? Personally I would have had to revert to the broken version, and debug it again to be sure. I do have personal notes about this I admit, so happy to comply if you prefer. Also, having the change annotated, committed and then deleted also gives history.
ken_fallon merged commit c263646cf2 into main 2023-08-20 15:07:33 +00:00
ken_fallon deleted branch I140_Convert_the_RSS_feeds_from_php_to_the_static_site 2023-08-20 15:07:40 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rho_n/hpr_generator#155
No description provided.