CyberCoveLLC/threshold-ui
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(e2e): Remove attempt to delete session recording due to UI change (#2687)

Browse Source 
This test attempted to delete a session recording when the policy did not allow it. However, there was a UI change to remove that option entirely, so we are removing the check.
This commit is contained in:
Michael Li authored and GitHub committed 2025-02-14 11:10:53 -05:00
1 parent c5fdbfd62d
commit f9411794c4
2 files changed
-46
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

e2e-tests/admin/tests/session-recording-aws-ent.spec.js
-23
View File
@@ -163,24 +163,6 @@ test(
await page.locator('div.session-recording-player').hover();
await page.locator('.ap-playback-button').click();
// Try to delete session recording: expect failure
await page.getByRole('link', { name: 'Orgs', exact: true }).click();
await page
.getByRole('navigation', { name: 'General' })
.getByRole('link', { name: 'Session Recordings', exact: true })
.click();
await page
.getByRole('row', { name: targetName })
.getByRole('link', { name: 'View' })
.click();
await page.getByText('Manage').click();
await page.getByRole('button', { name: 'Delete recording' }).click();
await page.getByRole('button', { name: 'OK', exact: true }).click();
await expect(
page.getByRole('alert').getByText('Error', { exact: true }),
).toBeVisible();
await page.getByRole('button', { name: 'Dismiss' }).click();
// Edit storage policy: do not protect from deletion
await page.getByRole('link', { name: 'Orgs', exact: true }).click();
await expect(page.getByRole('heading', { name: 'Orgs' })).toBeVisible();
@@ -207,11 +189,6 @@ test(
).toBeVisible();
await page.getByRole('button', { name: 'Dismiss' }).click();
// BUG? After the error trying to delete the session recording, subsequent
// actions result in an error. Reloading the page fixes the issue. This is a
// temporary workaround.
await page.reload();
// Re-apply storage policy to the session recording and delete
await page.getByRole('link', { name: 'Orgs', exact: true }).click();
await page
e2e-tests/admin/tests/session-recording-minio-ent.spec.js
-23
View File
@@ -171,24 +171,6 @@ test(
await page.locator('div.session-recording-player').hover();
await page.locator('.ap-playback-button').click();
// Try to delete session recording: expect failure
await page.getByRole('link', { name: 'Orgs', exact: true }).click();
await page
.getByRole('navigation', { name: 'General' })
.getByRole('link', { name: 'Session Recordings', exact: true })
.click();
await page
.getByRole('row', { name: targetName })
.getByRole('link', { name: 'View' })
.click();
await page.getByText('Manage').click();
await page.getByRole('button', { name: 'Delete recording' }).click();
await page.getByRole('button', { name: 'OK', exact: true }).click();
await expect(
page.getByRole('alert').getByText('Error', { exact: true }),
).toBeVisible();
await page.getByRole('button', { name: 'Dismiss' }).click();
// Edit storage policy: do not protect from deletion
await page.getByRole('link', { name: 'Orgs', exact: true }).click();
await expect(page.getByRole('heading', { name: 'Orgs' })).toBeVisible();
@@ -215,11 +197,6 @@ test(
).toBeVisible();
await page.getByRole('button', { name: 'Dismiss' }).click();
// BUG? After the error trying to delete the session recording, subsequent
// actions result in an error. Reloading the page fixes the issue. This is a
// temporary workaround.
await page.reload();
// Re-apply storage policy to the session recording and delete
await page.getByRole('link', { name: 'Orgs', exact: true }).click();
await page